[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2135 Merge to master if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2135 Looks good to me :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user dlukyanov commented on the issue: https://github.com/apache/zeppelin/pull/2135 @Leemoonsoo , @AhyoungRyu , any other comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2135 Thanks for addressing my comments! I left some minor comments again about "author name" in the source code and removing unnecessary `log.info`. Except these two things, LGTM ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user dlukyanov commented on the issue: https://github.com/apache/zeppelin/pull/2135 @AhyoungRyu, changes committed,waiting for travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2135 Merge to master if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2135 Thanks @dlukyanov for the contribution. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user dlukyanov commented on the issue: https://github.com/apache/zeppelin/pull/2135 @Leemoonsoo , done. waiting for travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@dlukyanov Thanks for the update and explanation on behavior.
Inside of docs directory, groovy.md will need some header to be compiled
with Jekyll. For example,
[spark.md](https://raw.githubusercontent.com/apache/zeppelin/master/docs/interpreter/spark.md)
```
---
layout: page
title: "Apache Spark Interpreter for Apache Zeppelin"
description: "Apache Spark is a fast and general-purpose cluster computing
system. It provides high-level APIs in Java, Scala, Python and R, and an
optimized engine that supports general execution engine."
group: interpreter
---
{% include JB/setup %}
```
Menu in docs also need link to groovy.
https://github.com/apache/zeppelin/blob/master/docs/_includes/themes/zeppelin/_navigation.html#L56
`.travis.yml` is updated since this branch is created. And we need add
`!groovy` in [this
line](https://github.com/apache/zeppelin/blob/master/.travis.yml#L40). Could
you handle it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user dlukyanov commented on the issue:
https://github.com/apache/zeppelin/pull/2135
@Leemoonsoo, Just committed changes.
Doc moved.
About shared vars - it will be a little different from scala/spark.
If you use groovy script variable (undeclared or annotated) it will behave
like you mentioned
```java
a="Hello world"
//or
@groovy.transform.Field String aa = "Hello world"
//or
g.put('aaa',"Hello world")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user dlukyanov commented on the issue: https://github.com/apache/zeppelin/pull/2135 @Leemoonsoo Interesting) I did not knew that... i'll take a look how it's implemented... With doc - i'll move it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2135 I tested last commit and it works well. However the variable can't be read from the other paragraph.  This behavior is different from other interpreters, like spark (scala), python, r. Is it intended? Also, can we place document under `/docs/interpreter/` instead of `/groovy/`, so website can show groovy documentation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2135 Looks like second test matrix succeeded after the manual restart. In this case, you also need to trigger Jenkins again to check latest build status. Simply close and reopen this PR will do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
