[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda Thanks! Will merge into master if there are no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2174 @AhyoungRyu Tested and works as described. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @felixcheung Thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda I updated the pagination as you said and this is the current status. Will be appreciated if you can take a look again.  @felixcheung I set the maximum pagination size as "5" and tested in the smallest mobile device size that Chrome dev tool provides (`320 x 568`) like below.  The pagination is not broken when the screen is small. But `enable` btn and package type selection btn are broken instead ð Let me handle them in another PR. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2174 @AhyoungRyu Yes, it would be great to hide unnecessary things --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda Thanks for the detailed explanation.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2174 @AhyoungRyu more precisely, 1. If we are in page 1, we don't need `<<`  2. If we are in some pages which can go to page 1, we need both `<<` && `>>`  3. the last case  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda No worries :) Then how about 1 page ? I mean if there is only 1 page, we can hide `<<` & `>>`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2174 @AhyoungRyu Sorry for confusing. It works as described. maybe i mixed commits ð - It would be nice if we hide `<<` and `>>` when users don't need it. (e.g less than 5 pages)  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @felixcheung Let me check again for that part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda It's wired. This is what I can see when I build my branch.  There are two `ng-repeat` like below. And [the pagination DOM](https://github.com/AhyoungRyu/zeppelin/blob/7150e7cb596c2bbe9148ea2a09009c6fb273a20e/zeppelin-web/src/app/helium/helium.html#L195) is placed inside of the first `ng-repeat`(for pkg type checking loop) and outside of the second one(each type of package listing). https://cloud.githubusercontent.com/assets/10060731/24363549/26531e08-134b-11e7-8f05-4b71bf1b277b.png;> FYI, the data is like this. https://cloud.githubusercontent.com/assets/10060731/24363853/ff811018-134b-11e7-84a3-867ec956539e.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2174 @AhyoungRyu pagination DOM should be located outside of `ng-repeat` for helium containers. https://cloud.githubusercontent.com/assets/4968473/24344271/9e910240-1305-11e7-86f1-51438b9a76c3.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda I fixed it in the latest commit bc7643c46dc6690b5b1f1a91249bcf4ee0e93a43. You can simply check whether it was fixed or not by comparing `INTERPRETER` type of packages are well located as version `0.7.0` -> `0.6.0` order. The `0.6.0` packages should be in 3rd page of `INTERPRETER` tab. (Before this commit, I could see some `0.6.0` of package in the middle of `INTERPRETER` package list.) FYI >Actually same problem is in https://zeppelin.apache.org/helium_packages.html. So need to fix it as well I made a PR for this in #2180 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda Just noticed that `orderBy: publishedDate` doesn't work well properly now. Let me updated again and will let you know when it's resolved. (Actually same problem is in https://zeppelin.apache.org/helium_packages.html. So need to fix it as well..ð ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2174 @AhyoungRyu sure! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda Will be really appreciated if you can help review this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
