[GitHub] zeppelin issue #2177: [ZEPPELIN-2301] DON'T overwrite editor text when note ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2177 Let me implement locking and realtime notification soon. I will close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2177: [ZEPPELIN-2301] DON'T overwrite editor text when note ...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2177 Sure. I'll test it and get back you soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2177: [ZEPPELIN-2301] DON'T overwrite editor text when note ...
Github user FRosner commented on the issue: https://github.com/apache/zeppelin/pull/2177 Thanks @1ambda. I'm quite busy at this moment so if someone else (e.g. @AhyoungRyu) can also take a look that would be greatly appreciated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2177: [ZEPPELIN-2301] DON'T overwrite editor text when note ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2177 @AhyoungRyu Could you help review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2177: [ZEPPELIN-2301] DON'T overwrite editor text when note ...
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2177
@FRosner Anything would be greatly appreciated. For example trying this PR,
suggestion for how to write test code for this, and so on.
regarding to triggering auto-save, Zeppelin send `startSavveTimer`
broadcast message, but there is no `$scope.$on('startSaveTimer', ...)`. That's
the reason why auto save is not working properly.
```
app/notebook/paragraph/paragraph.controller.js
602:$scope.$broadcast('startSaveTimer');
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2177: [ZEPPELIN-2301] DON'T overwrite editor text when note ...
Github user FRosner commented on the issue: https://github.com/apache/zeppelin/pull/2177 Gotcha @1ambda, The gifs make it clear now, thanks! Not sure about the exact code changes as I'm not that familiar with the code base you're touching. Do you have any specific part I should dive into or can someone else also take a look? I agree with the priorities as well. If we combine it with save-on-lost-focus the time window is at least lower to get your changes overwritten. Just one more related question: I noticed that there is a save timer for notebooks in the code. I tried to figure out when it is triggered but I didn't succeed. What is it used for? When is it triggered? What's the difference between saveNote and saving of a paragraph? Thanks! Frank --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2177: [ZEPPELIN-2301] DON'T overwrite editor text when note ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2177 @FRosner I updated GIF. What #2176 and #2177 is trying to prevent local change from overwritten. Overwriting occurs in many cases. - #2176 is only about **when other browsers run the same paragraph** - #2177 is related with **the case when people rename, remove, create notes** --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2177: [ZEPPELIN-2301] DON'T overwrite editor text when note ...
Github user FRosner commented on the issue: https://github.com/apache/zeppelin/pull/2177 I am not sure I understand the exact difference between this and #2176. Can you try to upload bigger versions of the gif or elaborate a bit on the difference? Are the two PR (#2176 and #2177) fixes for the same problem but in a different way or are they addressing different problems? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
