[GitHub] zeppelin issue #2196: fix bugs for timer saver
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2196 @wary Thanks for the contribution! LGTM and merge to master and branch-0.7 if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2196: fix bugs for timer saver
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2196 @wary No worry! It's okay! And thanks and Congrats for your contribution. :smile: Let me test it out and give you feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2196: fix bugs for timer saver
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2196 Thanks @wary for fixing this! But, could you explain detail this PR such as `what is this PR for` and `How should this be test`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2196: fix bugs for timer saver
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2196 Hi @wary Thanks for contribution. - Zeppelin build system relies on travis. So please setup your travis account and travis project for Zeppelin. - https://zeppelin.apache.org/contribution/contributions.html#continuous-integration - The repository name must be `zeppelin` (not `incubator-zeppelin`, ...) - It's not mandatory to pass all tests to be reviewed. But some reviewers might select passed PRs first Please trigger travis CI by pushing new commits or amend your last commit (`git commit --amend` and `git push your-remote HEAD --force`) after setup your travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
