[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2207 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 will be merging if no further comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2207 hmm, right. Seems document is not needed ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 @zjffdu How to use is the same as the existing one. If I add a document, should I add something like __zeppelin__ or __spark__? What do you think? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2207 @cloverhearts I left one minor comment. Besides, we need to add document for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 I would like to merge this. This solves the problem of usability. I will merge this if I no longer have any opinion. Thank you :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 Okay, Ci pass :) @felixcheung @zjffdu Could you please check on this pr? Thank you :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 and tested environment. | | pyspark intp | python intp | |-||--| |python3 with matplotlib | O| O | |python2 with matplotlib | O | O | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2207
apply to namespace on python
and zeppelin context name change
before
```
z = _zc = zeppelin context
```
to
```
z = __zeppelin__ = zeppelin context
```
same
```
z.input("title", "my title")
__zeppelin__.input("title", "my title")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 @zjffdu Yes, I will also reflect the namespace. Thank you for your advice :) . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2207 we need to check if namespace work properly on py2 and py3... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2207 I think a more thorough solution is to separate the namespace between python process and python repl. Only `ZeppelinContext` should be `available` in python repl namespace. It would be better to specify a space in `exec`. e.g. ``` exec(code, global=repl_namespace) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2207 right, I think it's everything that is called after calling `exec(code)`, might have been overwritten by the user code ``` or node in to_run_exec: mod = ast.Module([node]) code = compile(mod, '', 'exec') exec(code) for node in to_run_single: mod = ast.Interactive([node]) code = compile(mod, '', 'single') exec(code) for node in to_run_hooks: mod = ast.Module([node]) code = compile(mod, '', 'exec') exec(code) ``` so I think: `intp`, `output` and perhaps `to_run_exec`, `to_run_single`, `to_run_hooks`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 @felixcheung Thank you for your good advice. I will check your opinion. and fix :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2207 Nice!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2207 @cloverhearts Great! Tested this patch and it works well as you described. - Before  - After  If @astroshim feedback can also be addressed, looks GOOD to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2207 @cloverhearts It looks also great! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 @astroshim So what about `__zeppelin__`? Actually, I feel similar like a python system environment word It is less likely to be redefined by other libraries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2207 Looks great. one thing i worrying about is that the `_zc` can be possibly used by user easily? how about assigning more unique key word like `__zc__` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
