[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2323 Great improvement. Submitted https://issues.apache.org/jira/browse/ZEPPELIN-3251 to consider showing rows/columns lazily on scrolling events as otherwise ui-grid has a significant overhead for wide datasets so it randers much slower too. Other ideas? ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user vglushak commented on the issue: https://github.com/apache/zeppelin/pull/2323 > Now table renders HTML display in the cells and adjusts row height based on the content. There are some limitations for this feature. img, links works. But when I want to place button it just ignore html and display text only. ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2323 GTM. Thanks @1ambda for great improvement. Merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2323 @Leemoonsoo just rebased and updated to use `white` color in each cell background in c56edca now it looks like  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2323 @Leemoonsoo Oops. I missed that feature. 1. Now table renders HTML display in the cells  2. Fixed to have more bright even rows.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2323 Bright version looks better for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2323 @Leemoonsoo Colorizing (even rows) is cognitively better because we are not confused when investigating closer rows. Here are more bright versions https://cloud.githubusercontent.com/assets/4968473/26037441/6eef6ace-392d-11e7-992d-4fb38186852b.png;> https://cloud.githubusercontent.com/assets/4968473/26037442/764ea582-392d-11e7-9ae8-254b8b3100e3.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2323 And this PR adds background in rows. Master branch  This PR  What do you think? Keep appearance the same as before, so we can keep user experience change minimum. Or is adding background color in rows brings more benefit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2323 Each cell in table supposed to print html. For example ``` %sh echo -e "%table key\tvalue\nsun\t%html http://www.freeiconspng.com/uploads/sun-icon-4.jpg>" ``` This PR  In master branch  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2323 @guptarajat Hi, refer the last GIF. "persist" means that all state of table is saved in the note.josn. For example, sorting state will be saved after this PR but it is not in current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user guptarajat commented on the issue: https://github.com/apache/zeppelin/pull/2323 "all these things are persisted and synchronized among web socket clients" What does this mean? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2323 Here's few feedbacks. 1. Table does not refreshed after height / width of paragraph change. TBD 2. How about remove 'type' in column table option? - Removed - While adding tooltip for each option  3. showColumnFilter It's used to display aggregated values. I changed the name to `showAggregationFooter` which easier to understand than before.  4. pagination - Removed pagination related settings.  5. Header bar in the option - Removed the `save` button. - Updated icon for reset and added tooltip for it.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2323 Tested and overall it's great improvement! Here's few feedbacks. 1. Table does not refreshed after height / width of paragraph change. 2. How about remove 'type' in column table option?  I guess user will be okay without knowing it. 3. showColumnFilter Following is screenshot with 'showColumnFilter' on. I don't know what this option supposed to do except for adding empty sticky row in the bottom.  4. pagenation `defaultPaginationSize ` size can be only changed after the Table is displayed with `defaultPaginationSize ` applied. So changing default does not mean too much in this case. Isn't it? `availablePaginationSizes` - It's minor opinion, I think it is okay with hardcoded value and not make user configurable. 5. Header bar in the option  Two buttons - 'Save', 'Delete' icon - on right little bit confuses me. It was difficult to guess what those button supposed to do. And figured out 'save' - apply option to the table. 'delete' - restore to default options While option change applies immediately, how about hide 'Save' button? And change 'delete' icon to something more appropriate? For example "Restore the default values" text would be more intuitive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
