[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2343 LGTM. Will merge it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2343 If there is no more comment on this, I will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2343 @cloverhearts Did you test this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2343 Ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/2343 @tinkoff-dwh Sorry it was my problem. Tested and working good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2343 @astroshim it is strangely. do you package new jar? 407 line SqlConleter.java it is start of comment (multiline) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/2343
I think this feature is really cool.
BTW I got following exception whenever i try to run sql completion.
```
==> logs/zeppelin-interpreter-jdbc-jdbc.log <==
ERROR [2017-05-25 01:29:57,441] ({pool-1-thread-5}
TThreadPoolServer.java[run]:296) - Error occurred during processing of message.
java.lang.NullPointerException
at
org.apache.zeppelin.jdbc.SqlCompleter.completeKeyword(SqlCompleter.java:407)
at
org.apache.zeppelin.jdbc.SqlCompleter.completeName(SqlCompleter.java:469)
at org.apache.zeppelin.jdbc.SqlCompleter.complete(SqlCompleter.java:105)
at
org.apache.zeppelin.jdbc.JDBCInterpreter.completion(JDBCInterpreter.java:844)
at
org.apache.zeppelin.interpreter.LazyOpenInterpreter.completion(LazyOpenInterpreter.java:136)
at
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer.completion(RemoteInterpreterServer.java:573)
at
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Processor$completion.getResult(RemoteInterpreterService.java:1940)
at
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Processor$completion.getResult(RemoteInterpreterService.java:1925)
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39)
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39)
at
org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:285)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
==> logs/zeppelin-.local.log <==
ERROR [2017-05-25 01:29:57,443] ({qtp517210187-14}
NotebookServer.java[onMessage]:383) - Can't handle message
org.apache.zeppelin.interpreter.InterpreterException:
org.apache.thrift.transport.TTransportException
at
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.completion(RemoteInterpreter.java:493)
at
org.apache.zeppelin.interpreter.LazyOpenInterpreter.completion(LazyOpenInterpreter.java:136)
at org.apache.zeppelin.notebook.Paragraph.completion(Paragraph.java:304)
at org.apache.zeppelin.notebook.Note.completion(Note.java:664)
at
org.apache.zeppelin.socket.NotebookServer.completion(NotebookServer.java:1345)
at
org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:330)
at
org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:59)
at
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128)
at
org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
at
org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
at
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122)
at
org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
at
org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
at
org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
at
org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
at
org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
at
org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
at
org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
at
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
at
org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.thrift.transport.TTransportException
at
org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:132)
at org.apache.thrift.transport.TTransport.readAll(TTransport.java:86)
at
org.apache.thrift.protocol.TBinaryProtocol.readAll(TBinaryProtocol.java:429)
at
org.apache.thrift.protocol.TBinaryProtocol.readI32(TBinaryProtocol.java:318)
at
org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:219)
at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:69)
at
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Client.recv_completion(RemoteInterpreterService.java:372)
at
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2343 I will test on this pr. Thank you for greate feature. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2343 \cc @cloverhearts @astroshim --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
