[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Will merge this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Tried locally works fine. @tinkoff-dwh can you resolve these conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 looks OK, let me test it out on my cluster, I'll update this thread. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Tried the above: With multiple queries; https://cloud.githubusercontent.com/assets/674497/26358329/d46cf470-3fef-11e7-9afc-76e3bb448270.png;> With single query; https://cloud.githubusercontent.com/assets/674497/26358330/d46ffbde-3fef-11e7-86e6-fa483d729153.png;> And hence I repeat (https://github.com/apache/zeppelin/pull/2347#discussion_r117439158) keep changes to a minimum, the community has tested it, let's not try to break. And add an option in interpreter where it can default to single query mode (not use this logic). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2347 if jdbc driver does not implement this method (getMoreResults), it will work like you said will return the first result --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Sure, I do see this working for Postgres as posted in the screenshot, do you think this will work for rest of the data sources listed here http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/interpreter/jdbc.html#overview? Will try to test this on some of these and update this thread. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2347 another solution, but I think it's better --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Yes, correct. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2347 if all quieries is valid then the result will return from the first. is it correct? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 IMO there should be a workaround if the logic fails. And for handling error scenarios, here is what I think will happen. Before recommendation:  After recommendation:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Which is fine, with the document there will be a workaround. And the case that you are talking is true for Postgres, but for Hive if you will try to execute multiple SQLs in one statement then it fails. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2347 single mode is default and the user will always get an incorrect result if he writes multiple queries to in paragraph --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Which I think is fine, because in that case, we will not try to use this logic, and at least there will be a workaround if the user is facing any problem because of this issue, and we can have a document for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2347 @felixcheung @prabhjyotsingh have a problem with single mode, if user execute multiple queries (all text executes as single query) then result set is incorrect. I think this setting is redundant. If the user wants to execute single query, he can write a single query --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2347 yes for interpreter settings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 IMO property in settings of interpreter makes more sense, with a bit of a documentation on how to enable/disable it. cc: @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2347 @prabhjyotsingh checkbox (for paragraph) which indicates to parse the request or not? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Tested this on local, looks OK. Can you also implement this comment https://github.com/apache/zeppelin/pull/2347#issuecomment-302747859, i.e. default to single query with a switch to make multiple queries work? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2347 @prabhjyotsingh fixed problems --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2347 hmm, I see, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 @felixcheung +1 for defaulting to the single query. And for all of your questions answer is yes.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2347 Perhaps multiple queries was the reason we tried to parse the text (we really need to document these things better) - though I'm not sure how it would work exactly? Do you get multiple table in result if there are multiple queries in one paragraph? Does it even handle the multiple results correctly since that was added after JDBC interpreter is implemented? In any case I do think it is much cleaner not to mess with the content. Perhaps default to single query with a switch to fallback to old code and see if we get any feedback on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2347 Thanks, @zjffdu. @tinkoff-dwh will try to review this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2347 This is for multiple line sql support, seems this is the only way. @prabhjyotsingh has more context. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2347 \cc @prabhjyotsingh --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
