[GitHub] zeppelin issue #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2398 Thanks guys! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2398 Merging if there's no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2398 Ready for another look. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2398 Thanks for the feedback @Leemoonsoo. Yes, I was 50-50 on having a new API or reusing the "version" one. I'll go with your suggestion and refactor this later this week. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2398: [ZEPPELIN-2622] Add Zeppelin Git info REST API
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2398 Thanks @necosta for very useful improvement. It's not a strong opinion, but how about make `api/version` return version and git hash instead of add new api endpoint `api/git`? I think commit hash and timestamp can be part of version information. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
