[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action

2017-06-26 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2415
  
@jongyoul sounds good! 
I'll created JIRA ticket to improve personalized mode and test, after merge.

@zjffdu in my local, it works very well. and even my CI is failing other 
selenium. one thing, I can test in Travis many times. so let me test more on 
Travis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action

2017-06-26 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2415
  
Could we run it many times to make sure this is not flaky test ? Sadly, I 
see flaky test in selenium test very often.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action

2017-06-26 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2415
  
We'd better divide this test into two or three issues as it's not passed by 
some minor bugs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action

2017-06-26 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2415
  
Simple action test LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action

2017-06-22 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2415
  
Hi, there.
I just added two test cases as the @1ambda comment and have written PR 
description as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---