[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2484 Can you address with LICENSE issue moon mentioned? ---
[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2484 Agreed. we can improve this feature after adopting one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2484 @jongyoul good q. I tried another stats libraries I've seen used around (airlift), but had a hard time reconciling dependencies, so went with the smallest footprint one + implementing the servlet myself. It looks like metrics-core is [pretty self contained too](https://mvnrepository.com/artifact/com.codahale.metrics/metrics-core/3.0.2) - I'd be fine giving it a try, if folks prefer it for some reason (I'm honestly not super up-to-speed on what's popular these days, so I'm glad to defer this decision :-)) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2484 Hi, I have a simple question. AFAIK, dropwizard metrics are more popular and have powerful features. Have you consider it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2484 Apologies for late response. @herval It looks great. While this PR adds dependencies, ``` [INFO] +- org.weakref:jmxutils:jar:1.9:compile [INFO] +- org.hdrhistogram:HdrHistogram:jar:2.1.4:compile ``` We'll need add their license into `https://github.com/apache/zeppelin/blob/master/zeppelin-distribution/src/bin_license/LICENSE`. Could you update license file? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2484 Hi folks - any thoughts on this approach? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2484: [ZEPPELIN-2711] basic metrics for paragraphs & noteboo...
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2484 This is the basic set of functionality needed to start monitoring some common metrics - Comments & observations welcome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
