[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2503
  
1. Let's expose the config using REST API we already have. 

- 
http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/usage/rest_api/configuration.html#configuration-rest-api-list

2. Check it in frontend and hide if it's disabled using `ng-if` or 
something.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

[herval]

Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2503
  
any arguments against following the current way most sites do it (which is 
having "remember me" on by default, instead of a checkbox option)?

Showing/hiding the checkbox depending on a config will introduce quite a 
lot of config code, so unless there's a reasoning not to always support 
remembering credentials, I'd say it's a more sensible way to go


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2503
  
Then, I think we need to hide when cookie manager is disabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

[herval]

Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2503
  
Hmm It shouldn’t work without the Cookie manager. The checkbox will still 
show, though, which begs the question if it should be a default? (Otherwise 
we’ll have to hide the checkbox based on some shiro config)


From: Kun 
Sent: Friday, August 4, 2017 7:24:19 PM
To: apache/zeppelin
Cc: Herval Freire; Author
Subject: Re: [apache/zeppelin] [ZEPPELIN-2808] remember me support (#2503)


@1ambda commented on this pull request.



In 
conf/shiro.ini.template:

> @@ -46,6 +46,12 @@ user3 = password4, role2
 #ldapRealm.userDnTemplate = uid={0},ou=Users,dc=COMPANY,dc=COM
 #ldapRealm.contextFactory.authenticationMechanism = simple

+### If you want "remember me" to keep used logged in between sessions


Hi, without enalbing these lines, remember me feature works. Is it intended?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2503
  
Thanks. I updated the previous comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

[herval]

Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2503
  
That popup is not the site’s “remember me” - github actually keeps 
you logged in by default (close the browser and reopen, and you’re still 
logged, no need to re-authenticate)

You can see some examples of the “remember me”/“keep logged in” 
I’m talking about on this ticket here: 
http://www.uxforthemasses.com/login-page/


From: Kun 
Sent: Tuesday, July 25, 2017 8:25:01 PM
To: apache/zeppelin
Cc: Herval Freire; Author
Subject: Re: [apache/zeppelin] [ZEPPELIN-2808] remember me support (#2503)


I don't have a preference, but in my experience, many web apps rely on the 
browser provided remember-me feature. Here is an example of Github sign-in page

  *   https://github.com/login

Chrome


[image]

Safari


[image]

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2503: [ZEPPELIN-2808] remember me support

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2503
  
I don't have a preference, but in my experience, many web apps rely on the 
browser provided remember-me feature. Here is an example of Github sign-in page

- https://github.com/login

### Chrome 


![image](https://user-images.githubusercontent.com/4968473/28603134-460fcad2-71fd-11e7-8008-09e0e02e08e0.png)

### Safari


![image](https://user-images.githubusercontent.com/4968473/28603151-6036d1a8-71fd-11e7-9dc2-7fed43dff894.png)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---