[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-30 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@felixcheung this might help : 

https://issues.apache.org/jira/secure/ViewProfile.jspa?name=gfalcone=jira.user.profile.panels:user-profile-summary-panel


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-30 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@gfalcone Could you check if it is an account on 
https://issues.apache.org/jira/projects/ZEPPELIN?
It couldn't find gfalcone or falcone


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-29 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@felixcheung thanks for merging. Yes I have a jira account, same nickname 
as github's


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-29 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@gfalcone do you have a JIRA account? we could assign this to you


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-27 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
any more comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-26 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@1ambda @zjffdu @felixcheung do you still need clarifications or 
modifications from me? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-23 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@1ambda Thanks for clarfiying these scenarios. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-23 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
IMO introducing `EXECUTE` permission makes sense. For instance.

1. A shared notebook (dashboard) contains important indices and it requires 
large query executions. Thus I don't want to allow readers to change dynamic 
forms (dropdown). **It will be used only view-mode**

2. I have another notebook made for cooperation between UI team and 
developer team. the developer team wrote queries and UI team will change 
dynamic forms and execute queries. But the developer also wants to allow a 
manager of the project sees the notebook but not execute.

for case (1), we need READ-ONLY permissions.
for case (2). we need to support READ-ONLY + EXECUTE permissions.

**introducing `EXECUTE` permission gives Zeppelin users flexibility can be 
applied to multiple use cases**


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-23 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
I think about the problem again. And wondering would only `read + write` be 
suffient for zeppelin ?
And `read` means user can open the notebook and run it, but can not change 
the code. Because there's one scenario that require reader to run the notebook. 
E.g. We build a dashboard in zeppelin which allow user to interact with the 
dashboard (with textbox and dropdown list), then as a reader, he may want to 
interact with the dashboard via changing value of textbox of dropdown list. If 
we don't allow reader to run the notebook, I think user would be confused and 
doesn't make sense to me. And introducing Runner role for this scanrio seems a 
little over design to me. 

@gfalcone @felixcheung @Leemoonsoo what do you think ?





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-23 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@zjffdu it would have been a good idea to do that but rights on zeppelin 
are different than rights on a Unix system. For example, a user that has write 
permission can write, read and execute the note. So the rights are not properly 
isolated and I think this should bring another type of discussion to whether 
isolate the rights or not in order to make it more similar to a Unix system 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-22 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
Agree with this @felixcheung , linux permission mode : `read + write + 
execute` seems more suitable and understable. We should be very careful to 
deliver this kind of feature, because once we deliver it, it is better not to 
change it to keep compatibility and user experience. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-22 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@felixcheung do you need me for something? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-20 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@felixcheung CI ok 
https://travis-ci.org/gfalcone/zeppelin/builds/266447940?utm_source=email_medium=notification


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-18 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
Tested this branch and it works well.

Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-18 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
I see, so to summarize, before:
```
Readers
Writers
Owners
```

After
```
Readers
Writers
Runners
Owners
```
where Writers are also Runners

I think it'll be great to get some community feedback on whether this is a 
good model to go forward.
Open to others to comment?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-18 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@felixcheung no problem :), so yes writers can run in the current version, 
but since I didn't want to modify how writers and readers behave, I created an 
in-between user 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-18 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
ok, sorry for dragging it on... then I'll flip the question, are Writers 
also Runners then?
In the case someone is upgrading from the current version of Zeppelin with 
an existing notebook with ~~Readers~~ Writers role set, would they run into 
trouble that those users can no longer run the notebook?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-17 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@felixcheung nothing would change for them because readers cannot run the 
notebook. The only rights allowed to run a notebook are writers and owners 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-17 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
I see. In the case someone is upgrading from the current version of 
Zeppelin with an existing notebook with Readers role set, would they run into 
trouble that those users can no longer run the notebook?





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-16 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@felixcheung no readers cannot run, that's why I made a new type of user to 
enable the possibility of running a notebook without modifying its content. 

This feature also avoids changing rights to readers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-16 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
Can Readers here Run as well, so it's a bit different from the Linux 
permission model. Can Runners Read?

I am not sure if we should change the existing Readers role and it's 
semantics though. Would love to see how other think about this.





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-16 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@felixcheung CI ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-15 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@1ambda yes this PR totally address this problem 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-14 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
I saw that people were asking there is this kind of permission. 

- 
https://stackoverflow.com/questions/43971836/how-do-i-set-permissions-to-a-zeppelin-note-to-be-able-to-execute-but-not-change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-14 Thread gfalcone
Github user gfalcone commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
@felixcheung CI passed https://travis-ci.org/gfalcone/zeppelin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---