[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

2017-11-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2616
  
LGTM. Thanks @gef756 for the contribution!

Merge to master if no further discussions.


---


[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

2017-11-24 Thread gef756
Github user gef756 commented on the issue:

https://github.com/apache/zeppelin/pull/2616
  
@1ambda Let me know if you need anything else! Just pulled in master again, 
and got CI green.


---


[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

2017-10-16 Thread gef756
Github user gef756 commented on the issue:

https://github.com/apache/zeppelin/pull/2616
  
@1ambda Done. Green!


---


[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

2017-10-14 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2616
  
@gef756 Could u make CI green?


---


[GitHub] zeppelin issue #2616: ZEPPELIN-2984: allow enter from username

2017-10-11 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2616
  
Nowadays many browser support password auto-completion. (e.g Chrome, ...)
So +1 for this feature. 


---