[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version

2017-12-19 Thread jongyoul 
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2707
  
@felixcheung Yes, yarn is faster than npm4 but recently, npm5 is much 
faster than yarn. FE moves so fast :-)


---

[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version

2017-12-18 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2707
  
I see, Thanks. LGTM


---

[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version

2017-12-18 Thread jongyoul 
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2707
  
This is generated by npm v5 and it would not be changed until we change
dependencies. If it doesn't exist, npm creates it again when it runs
scripts. So adding it helps to reduce whole build time.

On Tue, 19 Dec 2017 at 7:57 AM Jeff Zhang  wrote:

> *@zjffdu* commented on this pull request.
> --
>
> In zeppelin-web/package-lock.json
> :
>
> > @@ -0,0 +1,11751 @@
> +{
>
> Is this a necessary change ? Would version upgrade involve such large
> change ?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>
-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net



---

[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version

2017-12-18 Thread cloverhearts 
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2707
  
I was tested. Looks good :)
Lgtm


---

[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version

2017-12-18 Thread jongyoul 
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2707
  
@1ambda Can you review it? It's kind of your idea :-)


---