[GitHub] zeppelin issue #3055: ZEPPELIN-3587. Interpret paragarph text as whole code ...

2018-07-18 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue:

https://github.com/apache/zeppelin/pull/3055
  
@zjffdu do we have an expected date for this fix?


---


[GitHub] zeppelin issue #3055: ZEPPELIN-3587. Interpret paragarph text as whole code ...

2018-07-12 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3055
  
Actually we already import this when initialize spark interpreter. 
https://github.com/apache/zeppelin/blob/master/spark/spark-scala-parent/src/main/scala/org/apache/zeppelin/spark/BaseSparkScalaInterpreter.scala#L171

The problem is that we would still hit this kind of error when run the 
tutorial note of bank data. This is due to an issue scala 2.10 
(SI-6649)[https://issues.scala-lang.org/browse/SI-6649]. This error doesn't' 
happen before just because we split code into lines and interpret it line by 
line. But as I mentioned before, interpret it line by line is not a correct 
approach. 
The good news is that it only affect scala 2.10.


---


[GitHub] zeppelin issue #3055: ZEPPELIN-3587. Interpret paragarph text as whole code ...

2018-07-11 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3055
  
ping @felixcheung 


---


[GitHub] zeppelin issue #3055: ZEPPELIN-3587. Interpret paragarph text as whole code ...

2018-07-09 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3055
  
@felixcheung @jongyoul I have updated the PR to run the paragraph text once 
instead of breaking it into lines. But it leads one behavior change: the order 
of output is changed compared to previous implementation. Basically there're 
two kinds of outputs: repl output and code execution output. e.g.g

```
val a = "hello world"
println(a)
```
Output
```
hello world (This is code execution output)
a: String = hello world   (This is repl output)
```

Code execution output will be displayed while code is running, but repl 
output is only displayed after scala repl complete the code execution. That's 
why you will see that the repl output is always after the code execution 
output, that's why I update some test code in this PR.



---


[GitHub] zeppelin issue #3055: ZEPPELIN-3587. Interpret paragarph text as whole code ...

2018-07-06 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3055
  
oops, please ignore my last comment. Actually we could interpreter 
paragraph text as whole 


---