[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-11-05 Thread dongjoon-hyun 
Github user dongjoon-hyun commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
Hi, @Leemoonsoo , @zjffdu ,  @felixcheung , @HyukjinKwon , @ajaygk95 .
Spark 2.4.0 is on the Maven Central. Can we restart this PR?


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-31 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
Thanks for confirmation.


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-31 Thread ajaygk95 
Github user ajaygk95 commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
> picked

I was able to get this working by doing cherry-picking. We needed some 
changes in our environment not related to zeppelin, but for the usage of 
spark-images.
Thanks for the help.


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-30 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
Awesome @HyukjinKwon Let's wait for spark 2.4 release


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-30 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
I also tested this patch against Spark RC5.


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-30 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
BTW, I tested this via my Travis CI - 
https://travis-ci.org/HyukjinKwon/zeppelin/builds/448215776. Tests seems got 
passed.


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-29 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
It should be usable if the changes is cherry-picked properly. This PR 
basically just replace one line:


https://github.com/apache/zeppelin/blob/v0.8.0/spark/scala-2.11/src/main/scala/org/apache/zeppelin/spark/SparkScala211Interpreter.scala#L84

to a private function.


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-29 Thread ajaygk95 
Github user ajaygk95 commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
> 
> 
> The error message:
> 
> ```
> [ERROR] /home/cloud-user/ajay/code/csf-cc-zeppelin-k8szep/spark/scala-
> 
2.11/src/main/scala/org/apache/zeppelin/spark/SparkScala211Interpreter.scala:37:
 error: class 
> SparkScala211Interpreter needs to be abstract, since method interpret in 
class 
> BaseSparkScalaInterpreter of type (code: String, context: 
> 
org.apache.zeppelin.interpreter.InterpreterContext)org.apache.zeppelin.interpreter.InterpreterResult
 is 
> not defined
> ```
> 
> complains there's no `interpret` method defined at 
`BaseSparkScalaInterpreter`.

Thanks for the reply.
I found the issue. I was using zeppelin 0.8.0 source code where "interpret" 
method was overriden. I think in the current branch this method is not present.


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-29 Thread ajaygk95 
Github user ajaygk95 commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
> 
> 
> Does that happen only with this code changes? The change here does not 
touch signature at `class SparkScala211Interpreter(` and the error message 
looks pretty unrelated. The whole change proposed here does not change any 
signature.

Yes. With the original 0.8.0 source code I'm able to build. 


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-29 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
The error message:

```
[ERROR] 
/home/cloud-user/ajay/code/csf-cc-zeppelin-k8szep/spark/scala-2.11/src/main/scala/org/apache/zeppelin/spark/SparkScala211Interpreter.scala:37:
 error: class 
SparkScala211Interpreter needs to be abstract, since method interpret in 
class 
BaseSparkScalaInterpreter of type (code: String, context: 
org.apache.zeppelin.interpreter.InterpreterContext)org.apache.zeppelin.interpreter.InterpreterResult
 is 
not defined
```

complains there's no `interpret` method defined at 
`BaseSparkScalaInterpreter`.


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-29 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
Does that happen only with this code changes? The change here does not 
touch signature at `class SparkScala211Interpreter(` and the error message 
looks pretty unrelated. The whole change proposed here does not change any 
signature.


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-29 Thread ajaygk95 
Github user ajaygk95 commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
Hello,

I was trying to run zeppelin with spark 2.4. I have pulled your code.
While building zeppelin I'm facing the below issue,

```
[ERROR] 
/home/cloud-user/ajay/code/csf-cc-zeppelin-k8szep/spark/scala-2.11/src/main/scala/org/apache/zeppelin/spark/SparkScala211Interpreter.scala:37:
 error: class SparkScala211Interpreter needs to be abstract, since method 
interpret in class BaseSparkScalaInterpreter of type (code: String, context: 
org.apache.zeppelin.interpreter.InterpreterContext)org.apache.zeppelin.interpreter.InterpreterResult
 is not defined
[ERROR] class SparkScala211Interpreter(override val conf: SparkConf,
[ERROR]   ^
[ERROR] one error found
[INFO] 

```
Can you please help.
Thanks



---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-20 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
Nope, it will work for both 2.11.8 and 2.11.12. I manually checked. This 
change only uses the methods existing in both 2.11.8 and 2.11.12 at Scala.


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-19 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
is this going to break, say spark 2.3 with scala 2.11.8?


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-17 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
Yes， we need to support scala 2.11 for spark 2.4 first. 
And please also update travis.yml to build it with spark-2.4 profile


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-17 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
oops. I haven't. Will check that too while I am here.

BTW, my understanding is that we need this one as well since Spark still 
can be compiled against Scala 2.11.x, am I in the right way?


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-17 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
Thanks @HyukjinKwon Have you checked this PR 
(https://github.com/apache/zeppelin/pull/3034) for supporting scala 2.12


---

[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4

2018-10-17 Thread HyukjinKwon 
Github user HyukjinKwon commented on the issue:

https://github.com/apache/zeppelin/pull/3206
  
This is a WIP. We should wait for Spark 2.4.0.

cc @zjffdu and @felixcheung


---