[GitHub] zeppelin pull request #1361: [ZEPPELIN-1354] [WIP] Inject Services

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1361


---

[GitHub] zeppelin pull request #1361: [ZEPPELIN-1354] [WIP] Inject Services

[echarles]

GitHub user echarles opened a pull request:

https://github.com/apache/zeppelin/pull/1361

[ZEPPELIN-1354] [WIP] Inject Services

### What is this PR for?

Services like authentication, authorization, security filters... should be 
injected rather than manually instanciated.

This will allow to give central + finer control and abstracting the 
functionaly in interface and allow third parties to implement their own 
functions in with configurable injection points.

For this, I propose to use Guice as injection framework.


### What type of PR is it?
Improvement

### Todos
* [ ] - Documentation
* [ ] - Tests

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1354

### How should this be tested?
Just compile and run

### Screenshots (if appropriate)
NA

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/datalayer/zeppelin-datalayer inject-services

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1361.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1361


commit 5002a1583681cff847c08977e614963a854d8f1b
Author: Eric Charles 
Date:   2016-08-24T16:05:52Z

add guice dependencies

commit 0fd9096e44c92b715cf7efa9dc82fc672564542e
Author: Eric Charles 
Date:   2016-08-25T08:16:51Z

Merge branch 'master' into inject-services

Conflicts:
pom.xml

zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java

zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java

commit 1d2b80a9be1054312ccba3b5d4b4f3086ecd3f33
Author: Eric Charles 
Date:   2016-08-25T08:17:58Z

Initial working implemenation of service injection for WebSecurity and 
SearchService




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---