[GitHub] zeppelin pull request #1365: ZEPPELIN-1374. Should prevent use dot in interp...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1365


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1365: ZEPPELIN-1374. Should prevent use dot in interp...

2016-08-25 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1365

ZEPPELIN-1374. Should prevent use dot in interpreter name

### What is this PR for?
dot is invalid for interpreter name as it is used as the seprater of 
interpreter group name and interpreter name.


### What type of PR is it?
[Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1374

### How should this be tested?
Tested it manually as shown in the screenshot. 

### Screenshots (if appropriate)

![image](https://cloud.githubusercontent.com/assets/164491/17995181/3047152e-6b92-11e6-9fbf-c683330359a9.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1374

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1365


commit 94ce731f1ba212f0b398db75eb4cec017032b850
Author: Jeff Zhang 
Date:   2016-08-26T05:34:46Z

ZEPPELIN-1374. Should prevent use dot in interpreter name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---