[GitHub] zeppelin pull request #1395: [ZEPPELIN-1404] invalid html structure for boot...

2016-09-08 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1395


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1395: [ZEPPELIN-1404] invalid html structure for boot...

2016-09-02 Thread cloverhearts
GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/1395

[ZEPPELIN-1404] invalid html structure for bootstrap in interpreter setting 
page

### What is this PR for?
invalid html structure for bootstrap in interpreter setting page.
for example :
correct
```html




```

invalid now.
```html






```
There occurs a problem with the current designers, and shape.

Please, check to Screenshots in this pr.


### What type of PR is it?
Bug Fix

### Todos
- [x] Fixed html structure
- [x] modification to margin for checkbox.

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1404

### How should this be tested?
click to interpreter menu in web ui.

### Screenshots (if appropriate)
 before wide screen.

![beforewide](https://cloud.githubusercontent.com/assets/10525473/18195922/60cee8ba-7129-11e6-8ec5-08aa2dd67ff1.png)

 after wide screen.

![afterwide](https://cloud.githubusercontent.com/assets/10525473/18195926/653d0756-7129-11e6-8c08-2ba150496e7c.png)
- active stripe table, and fixed margin, and other layout.

 before mobile size screen

![beforemobile](https://cloud.githubusercontent.com/assets/10525473/18195948/91598d5a-7129-11e6-9068-17f9a6b22717.png)

 after mobile size screen

![aftermobile](https://cloud.githubusercontent.com/assets/10525473/18195952/951c7664-7129-11e6-982b-0e5a494c228c.png)



### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin 
dev/interpreter-tag-fixed

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1395


commit 771c9014e8e7b2b759aedafc885d84e37f89283a
Author: CloverHearts 
Date:   2016-09-02T07:12:31Z

fixed to correct html(bootstrap) syntax for interpreter setting page.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---