[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1689 [ZEPPELIN-1709] Update checkstyle rule file, plugin ### What is this PR for? We have - outdated checkstyle.xml - old maven checkstyle plugin - no detailed style plugin guide (e.g available plugins, how to use them in your IDEA) By fixing those issues, we can keep our code clean. It will results the number of rebase count (reduced conflict due to just style) and boost our productivity. **important note** 1. This PR set an option to print all checkstyle warnings into stdout. The reason is, people should be told about invalid styles of not only errors but also warnings. 2. They would fix it progressionally. (unfortunately, we can fix all warnings in this PR. too much) 3. Once those warnings are all fixed, we can set `warning` to fail build even when checkstyle warning is occurred. That means we have more strict rule for our java code :) ```xml true ``` ### What type of PR is it? [Improvement] ### Todos * [x] - update check style plugin (6.19, the most recent for java 7) * [x] - update checkstyle.xml (brought from checkstyle 6.19 release) * [x] - fix some styles * [x] - print checkstyle WARN * [x] - update docs ### What is the Jira issue? [ZEPPELIN-1709](https://issues.apache.org/jira/browse/ZEPPELIN-1709) ### How should this be tested? ``` mvn validate -Denforcer.skip=true ``` ### Questions: * Does the licenses files need update - NO * Is there breaking changes for older versions - NO * Does this needs documentation - NO, but I added some docs about how to use checkstyle.xml in IDEA (https://github.com/apache/zeppelin/pull/1690) You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin feat/update-checkstyle Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1689.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1689 commit 0ae295639e69f2cbd79ab349cdd6234414e7c463 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:27:18Z chore: Use pluginManagement block so that config be shared in children projects commit 092155dfb06a17f78a0dd949b2edd152a12b907e Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:28:29Z chore: Remove useless failOnViolation config its default value is already `true` see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html commit 1c3048ea763c5108f1489fdf15a72b40b19436f4 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:29:46Z chore: Remove duplicated exclude commit 0e90cc3d39845388742b99bf9501c08965746025 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:52:15Z style: Fix Invalid indents in interpreter [INFO] [INFO] Building Zeppelin: Interpreter 0.7.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-interpreter --- [INFO] There are 5 errors reported by Checkstyle 6.11.2 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/dep/DependencyResolver.java:[162] (indentation) Indentation: 'Collection' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:[242] (indentation) Indentation: 'getClassName' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[59] (indentation) Indentation: 'extends' have incorrect indentation level 2, expected level should be 4. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[60] (indentation) Indentation: 'implements' have incorrect indentation level 2, expected level should be 4. [ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile: File does not end with a newline. [INFO] [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ... SUCCESS [ 3.587 s] [INFO] Zeppelin: Interpreter .. FAILURE [ 0.901 s] commit 13c53fcdfc526f63f083cedb991128fcda1ba739 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T03:03:06Z style: Fix invalid indents in zengine [INFO]
[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1689 [ZEPPELIN-1709] Update checkstyle rule file, plugin ### What is this PR for? We have - outdated checkstyle.xml - old maven checkstyle plugin - no detailed style plugin guide (e.g available plugins, how to use them in your IDEA) By fixing those issues, we can keep our code clean. It will results the number of rebase count (reduced conflict due to just style) and boost our productivity. **important note** 1. This PR set an option to print all checkstyle warnings into stdout. The reason is, people should be told about invalid styles of not only errors but also warnings. 2. They would fix it progressionally. (unfortunately, we can fix all warnings in this PR. too much) 3. Once those warnings are all fixed, we can set `warning` to fail build even when checkstyle warning is occurred. That means we have more strict rule for our java code :) ```xml true ``` ### What type of PR is it? [Improvement] ### Todos * [x] - update check style plugin (6.19, the most recent for java 7) * [x] - update checkstyle.xml (brought from checkstyle 6.19 release) * [x] - fix some styles * [x] - print checkstyle WARN * [x] - update docs ### What is the Jira issue? [ZEPPELIN-1709](https://issues.apache.org/jira/browse/ZEPPELIN-1709) ### How should this be tested? ``` mvn validate -Denforcer.skip=true ``` ### Questions: * Does the licenses files need update - NO * Is there breaking changes for older versions - NO * Does this needs documentation - NO, but I added some docs about how to use checkstyle.xml in IDEA (https://github.com/apache/zeppelin/pull/1690) You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin feat/update-checkstyle Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1689.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1689 commit faef368b7955e731171049cec2aa46a05959cb9e Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:27:18Z chore: Use pluginManagement block so that config be shared in children projects commit 9d28e188b8758ae56b99f5ddd88db0f161aa1df2 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:28:29Z chore: Remove useless failOnViolation config its default value is already `true` see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html commit d1d5cfea0d236f999f1e52f2a94cff6d753188ec Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:29:46Z chore: Remove duplicated exclude commit 7e57fada02a589a57e6502f5094bf547135338ae Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:52:15Z style: Fix Invalid indents in interpreter [INFO] [INFO] Building Zeppelin: Interpreter 0.7.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-interpreter --- [INFO] There are 5 errors reported by Checkstyle 6.11.2 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/dep/DependencyResolver.java:[162] (indentation) Indentation: 'Collection' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:[242] (indentation) Indentation: 'getClassName' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[59] (indentation) Indentation: 'extends' have incorrect indentation level 2, expected level should be 4. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[60] (indentation) Indentation: 'implements' have incorrect indentation level 2, expected level should be 4. [ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile: File does not end with a newline. [INFO] [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ... SUCCESS [ 3.587 s] [INFO] Zeppelin: Interpreter .. FAILURE [ 0.901 s] commit aebdc82c85a52d84fff9572c798e738c9227f451 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T03:03:06Z style: Fix invalid indents in zengine [INFO]
[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1689 [ZEPPELIN-1709] Update checkstyle rule file, plugin ### What is this PR for? We have - outdated checkstyle.xml - old maven checkstyle plugin - no detailed style plugin guide (e.g available plugins, how to use them in your IDEA) By fixing those issues, we can keep our code clean. It will results the number of rebase count (reduced conflict due to just style) and boost our productivity. **important note** This PR set an option to print all checkstyle warnings into stdout. The reason is, people should be told about invalid styles of not only errors but also warnings. Once those warnings are all fixed, we can set `warning` to fail build even when checkstyle warning is occurred. By doing that, we can make our code more consistent. ```xml true ``` ### What type of PR is it? [Improvement] ### Todos * [x] - update check style plugin * [x] - update checkstyle.xml * [x] - fix some styles * [x] - print checkstyle WARN ### What is the Jira issue? [ZEPPELIN-1709](https://issues.apache.org/jira/browse/ZEPPELIN-1709) ### How should this be tested? ``` mvn validate -Denforcer.skip=true ``` ### Questions: * Does the licenses files need update - NO * Is there breaking changes for older versions - NO * Does this needs documentation - NO, but I added some docs about how to use checkstyle.xml in IDEA You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin feat/update-checkstyle Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1689.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1689 commit 46c59bae0daf38df9dae39203632f0d7a2c8d6d1 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:27:18Z chore: Use pluginManagement block so that config be shared in children projects commit 2fa6f734a1176a35f0cec7a440e0f992fb781cdb Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:28:29Z chore: Remove useless failOnViolation config its default value is already `true` see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html commit 1988d41f26c20b1633963abd5ea93d35d7007f4b Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:29:46Z chore: Remove duplicated exclude commit 83e0c7b0d75b52cee695f186ef9743bbc575e31d Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:13:15Z chore: Update checkstyle version commit 70b15c9b0d231ec4a12cc01e889e8ed1d75ad828 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:52:15Z style: Fix Invalid indents in interpreter [INFO] [INFO] Building Zeppelin: Interpreter 0.7.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-interpreter --- [INFO] There are 5 errors reported by Checkstyle 6.11.2 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/dep/DependencyResolver.java:[162] (indentation) Indentation: 'Collection' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:[242] (indentation) Indentation: 'getClassName' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[59] (indentation) Indentation: 'extends' have incorrect indentation level 2, expected level should be 4. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[60] (indentation) Indentation: 'implements' have incorrect indentation level 2, expected level should be 4. [ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile: File does not end with a newline. [INFO] [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ... SUCCESS [ 3.587 s] [INFO] Zeppelin: Interpreter .. FAILURE [ 0.901 s] commit 6f0d72fb281c04bd44e839adc08cfbcd4dd9654e Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T03:03:06Z style: Fix invalid indents in zengine [INFO] [INFO] Building Zeppelin: Zengine 0.7.0-SNAPSHOT [INFO]
