[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...
GitHub user marchpig reopened a pull request: https://github.com/apache/zeppelin/pull/1723 [ZEPPELIN-1747] Fix Korean notename input problem ### What is this PR for? Korean notename is incorrectly typed on Firefox. This PR fixes the issue by changing placeholder attribute of the input field. Getting the placeholder text from `noteName()` is unnecessary because the text is visible only when the notename is blank. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1747 ### How should this be tested? Type Korean notename in action bar using Firefox browser. ### Screenshots (if appropriate) ![korean-notename-issue](https://cloud.githubusercontent.com/assets/17305893/20859768/d7f5cf60-b9ab-11e6-926d-814b8e0cafb3.gif) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin fix-korean-notename Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1723.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1723 commit 666f30ced0acdbf05aa4c4ce445f4d090f461c52 Author: Sangwoo Lee Date: 2016-12-03T13:52:47Z Fix Korean notename input problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...
Github user marchpig closed the pull request at: https://github.com/apache/zeppelin/pull/1723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1723 [ZEPPELIN-1747] Fix Korean notename input problem ### What is this PR for? Korean notename is incorrectly typed on Firefox. This PR fixes the issue by changing placeholder attribute of the input field. Getting the placeholder text from `noteName()` is unnecessary because the text is only visible when the notename is blank. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1747 ### How should this be tested? Type Korean notename in action bar using Firefox browser. ### Screenshots (if appropriate) ![korean-notename-issue](https://cloud.githubusercontent.com/assets/17305893/20859768/d7f5cf60-b9ab-11e6-926d-814b8e0cafb3.gif) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin fix-korean-notename Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1723.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1723 commit 666f30ced0acdbf05aa4c4ce445f4d090f461c52 Author: Sangwoo Lee Date: 2016-12-03T13:52:47Z Fix Korean notename input problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---