[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 3b861ee85b93805ec6298f5d17d88f211ef4b8a3
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit e2b2902f4aa4b6456643ec13105928e3afc409b0
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 77d79499f83923f07f8a2451fdb9f2a0e448528d
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 1d597ee152e62e03aa9645284478507821a315ef
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 710c474c022b010ab5ed8038862dbdbbf44f58e3
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit f40e763f33158b82bc4be1cdb08657a248f12baf
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit d5389c016fc018d2c70125429e00836a8d107dd2
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit 731a2da29c41b8d3602c105bfa5fab3f7b70ef7d
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit b1c459da81d61c131f997150d8644a0f05701c03
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit ab28178a0e818dd1f269969489ec87520ef0e14d
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit ecaed2e5740e8cdd5cec1beecee65b9486a8a2dc
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 7afdc886ac0113f5123ef032fe6847a3d8d2fd65
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 3b861ee85b93805ec6298f5d17d88f211ef4b8a3
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit e2b2902f4aa4b6456643ec13105928e3afc409b0
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 77d79499f83923f07f8a2451fdb9f2a0e448528d
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 1d597ee152e62e03aa9645284478507821a315ef
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 710c474c022b010ab5ed8038862dbdbbf44f58e3
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit f40e763f33158b82bc4be1cdb08657a248f12baf
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit d5389c016fc018d2c70125429e00836a8d107dd2
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit 731a2da29c41b8d3602c105bfa5fab3f7b70ef7d
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit b1c459da81d61c131f997150d8644a0f05701c03
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit ab28178a0e818dd1f269969489ec87520ef0e14d
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit ecaed2e5740e8cdd5cec1beecee65b9486a8a2dc
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 7afdc886ac0113f5123ef032fe6847a3d8d2fd65
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 94407574e4182f93dfd9dce39e7e63fde824e461
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 1a2a7c5a719a3127720c40cdbafe054008200988
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 423748811b1a56f4ed4df0950aa8b30f89cd7927
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 51cc60de3c709a2c7bc45cd8713521c87738d5aa
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit eb2d64b82afb260933f6f1d0ee59388eeece47bf
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit da00e3cc0db8ef896706f9a2263c929bc1cd929a
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 6ddeeb729e97f8408504627f26caa2ffdcbeee59
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit beaf265ac1eef802588d42cc5967323bfdbe96ff
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 35aca48d83ec971068aab63a8e222feb269ab5e2
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit e627ae7eee7cfc93585c0d438d5822daa11e6d1d
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit dd1f506ae8e7617ec257b52634540a44e4f0159f
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 0f10bb59384c81bfd0b2c73122d1188dd670e776
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit a010f8724329efe198bcb9406c8ed5892deea7d7
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 6fc1846a044cc27ef5e5c69519b54cead25034a2
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit bf4641007ea209a44278514f0c5251b4a5732ac1
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 7ab945fbfef0da222e2291d32863931a81933edd
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit b4f42b26f781c341a1d035e685024bef229370ba
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit 43cf08bac15f1e979a2ff6f1e1b7d21f9e07c62a
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3490494a087f16e6d4b12101e829da571756e27f
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit d7131799c9f614a986400e8d9ee7830fb3d602a7
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 25d7b8f633639b9335b7eefd22e53e7b9b8a9070
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit cb84473046b40e229e5f95f00608805b676f6e06
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit 2407844911184e6cd750d20b7ad76d5dd9c11a8e
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 5a33b176fc4d79fb47e033e438ed49c2c6b728dc
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit a010f8724329efe198bcb9406c8ed5892deea7d7
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 6fc1846a044cc27ef5e5c69519b54cead25034a2
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit bf4641007ea209a44278514f0c5251b4a5732ac1
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 7ab945fbfef0da222e2291d32863931a81933edd
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit b4f42b26f781c341a1d035e685024bef229370ba
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit 43cf08bac15f1e979a2ff6f1e1b7d21f9e07c62a
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3490494a087f16e6d4b12101e829da571756e27f
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit d7131799c9f614a986400e8d9ee7830fb3d602a7
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 25d7b8f633639b9335b7eefd22e53e7b9b8a9070
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit cb84473046b40e229e5f95f00608805b676f6e06
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit 2407844911184e6cd750d20b7ad76d5dd9c11a8e
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 5a33b176fc4d79fb47e033e438ed49c2c6b728dc
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 87722747798f908da78752a48cca693f6ac34469
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit 04954ac33c2d9cf96dd331abb5a8b1eb09f05e54
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit d97718c9e74afe41372ec904b0f6744027f21b8c
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3c16e09f42204bb784140cceb7946c7140f9e12d
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit c69b9e32290d2b16d558967721be5fac95ad9f64
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 2167c86c5d72b5cbef431c79a51848ef1790781b
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit 1558ba52d31832ba6f006fb623c3d74421e42c61
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit d58517c33a212555aca5cdd12cb743de9fbd7ea7
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 6568bf2c71bb90511b590d437e0ac0accc6d7384
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 8d53a1347028b09588027fa8715ea99d23abb65b
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 7caebdaee036a3276d6c116aaa0307466fe3c1d0
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun opened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 665e30227a903b067b9b3d4e887f603bedf61698
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---