[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...

2017-01-08 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1832


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...

2017-01-02 Thread astroshim 
GitHub user astroshim reopened a pull request:

https://github.com/apache/zeppelin/pull/1832

[ZEPPELIN-1884] Prevent NullPointerException when JDBC query.

### What is this PR for?
Sometimes users don't want to set the properties which they don't want to 
care about and `common.max_count` of JDBC interpreter is one of that property.
If it does not set the `common.max_count`, NullPointerException will occur.


### What type of PR is it?
Bug Fix 


### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1884


### How should this be tested?
 - Set properties like as following image and run select query.

![image](https://cloud.githubusercontent.com/assets/3348133/21585284/02c433ee-d072-11e6-8ca1-d120617bb7f1.png)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1884

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1832


commit f1efda772d70d9f0247d07195ab8913050e2339d
Author: astroshim 
Date:   2017-01-02T06:22:49Z

add checking commonkey exists




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...

2017-01-02 Thread astroshim 
Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/1832


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...

2017-01-01 Thread astroshim 
GitHub user astroshim reopened a pull request:

https://github.com/apache/zeppelin/pull/1832

[ZEPPELIN-1884] Prevent NullPointerException when JDBC query.

### What is this PR for?
Sometimes users don't want to set the properties which they don't want to 
care about and `common.max_count` of JDBC interpreter is one of that property.
If it does not set the `common.max_count`, NullPointerException will occur.


### What type of PR is it?
Bug Fix 


### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1884


### How should this be tested?
 - Set properties like as following image and run select query.

![image](https://cloud.githubusercontent.com/assets/3348133/21585284/02c433ee-d072-11e6-8ca1-d120617bb7f1.png)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1884

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1832


commit f1efda772d70d9f0247d07195ab8913050e2339d
Author: astroshim 
Date:   2017-01-02T06:22:49Z

add checking commonkey exists




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...

2017-01-01 Thread astroshim 
Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/1832


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1832: [ZEPPELIN-1884] Prevent NullPointerException wh...

2017-01-01 Thread astroshim 
GitHub user astroshim opened a pull request:

https://github.com/apache/zeppelin/pull/1832

[ZEPPELIN-1884] Prevent NullPointerException when JDBC query.

### What is this PR for?
Sometimes users don't want to set the properties which they don't want to 
care about and `common.max_count` of JDBC interpreter is one of that property.
If it does not set the `common.max_count`, NullPointerException will occur.


### What type of PR is it?
Bug Fix 


### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1884


### How should this be tested?
 - Set properties like as following image and run select query.

![image](https://cloud.githubusercontent.com/assets/3348133/21585284/02c433ee-d072-11e6-8ca1-d120617bb7f1.png)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1884

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1832.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1832


commit f1efda772d70d9f0247d07195ab8913050e2339d
Author: astroshim 
Date:   2017-01-02T06:22:49Z

add checking commonkey exists




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---