[GitHub] zeppelin pull request #1843: [ZEPPELIN-1905] fix: "Clear All Paragraphs" doe...

2017-01-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1843


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1843: [ZEPPELIN-1905] fix: "Clear All Paragraphs" doe...

2017-01-04 Thread 1ambda
GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1843

[ZEPPELIN-1905] fix: "Clear All Paragraphs" doens't work in a note

### What is this PR for?

Fixed **Clear all paragraphs** button in a note (I attached a screenshot)

### What type of PR is it?
[Bug Fix]

### Todos

Nothing

### What is the Jira issue?

[ZEPPELIN-1905](https://issues.apache.org/jira/browse/ZEPPELIN-1905)

### How should this be tested?

1. Open a note
2. Run some paragraphs.
3. Click the **Run all paragraphs** button.

### Screenshots (if appropriate)


![clear-all-output-bug](https://cloud.githubusercontent.com/assets/4968473/21660976/391d5010-d315-11e6-9ad0-c4feff32eee6.gif)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-1905/fix-clear-all-paras

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1843.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1843


commit 7f95b9bbab389a860d7618d89c5dca6a4141ccf7
Author: 1ambda <1am...@gmail.com>
Date:   2017-01-04T21:59:11Z

fix: Set note content

commit 1f9257e74642845393a418f7bb430282215af83b
Author: 1ambda <1am...@gmail.com>
Date:   2017-01-04T22:00:29Z

fix: Calling isFocused of null (TypeError)

TypeError: Cannot read property 'isFocused' of null
at ChildScope.ParagraphCtrl.$scope.scrollToCursor 
(paragraph.controller.js:718)
at paragraph.controller.js:708
at Scope.$broadcast (angular.js:17143)
at paragraph.controller.js:1052




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---