[GitHub] zeppelin pull request #2278: [ZEPPELIN-2431] Corrected deletion of notes by ...

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2278


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2278: [ZEPPELIN-2431] Corrected deletion of notes by ...

2017-04-24 Thread cloverhearts
GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/2278

[ZEPPELIN-2431] Corrected deletion of notes by incorrect interpreter.json

### What is this PR for?

We sometimes can not delete a note, or we will be accompanied by an NPE for 
deleting a note.

This problem occurs when:
When interpreter.json 's note binding is wrong, or there is a problem.
If you are configuring an interpreter that is not through zeppelin's user 
interface.
As a result, it happens when synchronization of notes deletion and setting 
retention is not normal.
Therefore, we should add handling for note deletion and exception handling 
for nonexistent interpreter bindings.
It reduces the synchronization problem of interpreter.json.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2431

### How should this be tested?
1. zeppelin stop
2. edit con/interpreter.json and `interpreterBindings`
  fix any notes or incorrect information.
  for example 
  ```
},  
  "interpreterBindings": {
"2CFS9YSM5": [
  "2CFRR1D3TINVALIDINVALIDINVALID", <-- edit
  "2CFZ1JKUR",
  "2CEAJK1VW",
  "2CGSESWBH",
  "2CERNPGW5",
   }
  ```
3. zeppelin start
4. You can try remove invalid interpreter bind note on web. (on example = 
`2CFS9YSM5`)

result : 
If the modifications to this PR are not reflected,
It will not be deleted or an error will appear on the server.
Also, the interpreterBindings information in interpreter.json does not 
respond to delete events.

### Screenshots (if appropriate)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin 
fix/invalidsyncInterpreterJson

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2278


commit 35da524cc00c40531072130424fb38419e4612f4
Author: CloverHearts 
Date:   2017-04-24T07:16:47Z

notebook interpreter binding synchronization process




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---