[GitHub] zeppelin pull request #2514: replace pegdown to markdown zeppelin interprete...

2017-08-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2514


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2514: replace pegdown to markdown zeppelin interprete...

2017-08-02 Thread cloverhearts
GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/2514

replace pegdown to markdown zeppelin interpreter

### What is this PR for?
I was change markdown render librarry for Jupyter note convertor.
currently, we can got a same result for markdown.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2824

### How should this be tested?
1. build jupyter module
  `mvn clean package -DskipTests -pl 'zeppelin-jupyter' --am`
2. `cd zeppelin-jupyter/target`
3. `java -classpath zeppelin-jupyter-0.8.0-SNAPSHOT.jar 
org.apache.zeppelin.jupyter.JupyterUtil -i {your ipynb note file 
path!/getting_started.ipynb`
(good sample : [go to 
sample](https://github.com/SciRuby/sciruby-notebooks/blob/master/getting_started.ipynb)
4. get a `note.json` and import to zeppelin on frontend!
5. enjoy
### Screenshots (if appropriate)

 problem

![28689484-9b13f3d2-72ca-11e7-9bda-02d33b30f036](https://user-images.githubusercontent.com/10525473/28861908-0d05c592-779e-11e7-9a4e-94e3fd2bd176.png)

 after

![image](https://user-images.githubusercontent.com/10525473/28807730-029510e6-76b2-11e7-9111-0e18569b1630.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-2824-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2514


commit 2e8b3326b6fe3fb017f78cdfd6cecf1135484706
Author: CloverHearts 
Date:   2017-08-02T07:12:45Z

replace pegdown to markdown zeppelin interpreter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---