[GitHub] zeppelin pull request #2647: [ZEPPELIN-3012] Interpreter Permissions not wor...

2017-11-08 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2647


---


[GitHub] zeppelin pull request #2647: [ZEPPELIN-3012] Interpreter Permissions not wor...

2017-11-02 Thread weand
GitHub user weand opened a pull request:

https://github.com/apache/zeppelin/pull/2647

[ZEPPELIN-3012] Interpreter Permissions not working properly for groups

### What is this PR for?
This fixes issues when using Zeppelin with permissions for users belonging 
to more than one roles / groups. Constructor of 
org.apache.zeppelin.user.AuthenticationInfo didn't consider that the roles 
String will contain spaces, in case there is more than one role, e.g. 'role1, 
role2'.

This change fixes the issue, by invoking trim() on each role.

### What type of PR is it?
[Bug Fix]

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3012

### How should this be tested?
* Enable shiro.ini, including 'admin' user
* Login with 'admin' and enable Interpreter Permissions for any 
Interpreter, granting access to 'role2'
* Try to use this Interpreter with 'user1', who belongs to role2.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/weand/zeppelin ZEPPELIN-3012

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2647


commit 1e5d2b72491289ca7572966d74c7bf6bc7ac81ec
Author: Andreas Weise 
Date:   2017-11-02T23:11:53Z

[ZEPPELIN-3012] Interpreter Permissions not working properly for groups




---