[GitHub] zeppelin pull request #2903: [ZEPPELIN-3377] Passing Z variables to JDBC int...

2018-04-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2903


---

[GitHub] zeppelin pull request #2903: [ZEPPELIN-3377] Passing Z variables to JDBC int...

2018-04-22 Thread sanjaydasgupta 
GitHub user sanjaydasgupta reopened a pull request:

https://github.com/apache/zeppelin/pull/2903

[ZEPPELIN-3377] Passing Z variables to JDBC interpreter

### What is this PR for?
This PR enables the interpolation of ZeppelinContext objects into the 
paragraph text of JDBC cells. It also introduces a new interpreter-level 
configuration parameter named _zeppelin.jdbc.interpolation_. This new parameter 
is _false_ by default, and must be set to _true_ to enable object 
interpolation. The default value of _false_ guarantees backward compatibility 
for users who are not aware of the new feature.

The implementation takes the same approach that was followed in 
[PR-2898](https://github.com/apache/zeppelin/pull/2898).

I have also taken the liberty to correct a preexisting error in the 
description of the use of Dynamic Forms in the associated documentation 
(_jdbc.md_).

### What type of PR is it?
[Feature]

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3377

### How should this be tested?
CI Pass. 

The code in this PR merely causes the JDBC interpreter to "opt-in" to the 
implementation already existing in the `Interpreter` base class - described in 
[PR-2898](https://github.com/apache/zeppelin/pull/2898). The unit tests 
necessary are already present in PR-2898

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, documentation has been added to the 
file _jdbc.md_. I have also taken the liberty to correct a preexisting error in 
the description of the use of Dynamic Forms in the associated documentation.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanjaydasgupta/zeppelin zeppelin-3342-jdbc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2903.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2903


commit 28688256f3b11e696c08ed10875e0596db8c0463
Author: Sanjay Dasgupta 
Date:   2018-03-04T07:36:48Z

ZEPPELIN-1967: Initial updates

commit b461c82569e86436239c9d14a8ae38230bc4f357
Author: Sanjay Dasgupta 
Date:   2018-03-05T02:00:10Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit ced295cb8b27f499b739758b1b17460ab6d67e58
Author: Sanjay Dasgupta 
Date:   2018-03-06T03:47:32Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit a3215fca058398ecbed840a69b4dbf57a2167447
Author: Sanjay Dasgupta 
Date:   2018-03-07T05:15:11Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit f43fd9987b7a10ae41879c52096fdb99f8a28f34
Author: Sanjay Dasgupta 
Date:   2018-03-11T05:40:21Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 3beebce5b5fbb45b295fd5b4bf4b28f9bef8350f
Author: Sanjay Dasgupta 
Date:   2018-03-13T11:33:09Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 3b30ea2143813dfbc48970b1ac094fea30d7d775
Author: Sanjay Dasgupta 
Date:   2018-03-15T10:43:53Z

Reversing previous incorrect update

commit 1718e79646b8de4682cb1c76eb6d4a24e83b3184
Author: Sanjay Dasgupta 
Date:   2018-03-15T14:17:49Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 526880301877125501ea0b1b06c61fcfdc19fe60
Author: Sanjay Dasgupta 
Date:   2018-03-18T04:41:52Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit b7ddf6ba202c2624a289aff67cfad669510ca80d
Author: Sanjay Dasgupta 
Date:   2018-03-18T09:54:23Z

Implementing configuration (global enable/disable interpolation) following 
https://github.com/apache/zeppelin/pull/2834#issuecomment-373948398

commit a1703b820e42e3956f45edf3c02aec8fc3475739
Author: Sanjay Dasgupta 
Date:   2018-03-18T21:05:42Z

Changes suggested in Felix Cheung's review 
https://github.com/apache/zeppelin/pull/2834#pullrequestreview-104805661

commit 3dd3dd879187e20a80cb202df7869c923da8a690
Author: Sanjay Dasgupta 
Date:   2018-03-20T03:47:11Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 1e2c87dd36dc091ca898baf8e9f178d6d1a5e600
Author: Sanjay Dasgupta 
Date:   2018-03-21T01:18:09Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit

[GitHub] zeppelin pull request #2903: [ZEPPELIN-3377] Passing Z variables to JDBC int...

2018-04-22 Thread sanjaydasgupta 
Github user sanjaydasgupta closed the pull request at:

https://github.com/apache/zeppelin/pull/2903


---

[GitHub] zeppelin pull request #2903: [ZEPPELIN-3377] Passing Z variables to JDBC int...

2018-04-02 Thread sanjaydasgupta 
GitHub user sanjaydasgupta opened a pull request:

https://github.com/apache/zeppelin/pull/2903

[ZEPPELIN-3377] Passing Z variables to JDBC interpreter

### What is this PR for?
This PR enables the interpolation of ZeppelinContext objects into the 
paragraph text of JDBC cells. It also introduces a new interpreter-level 
configuration parameter named _zeppelin.jdbc.interpolation_. This new parameter 
is _false_ by default, and must be set to _true_ to enable object 
interpolation. The default value of _false_ guarantees backward compatibility 
for users who are not aware of the new feature.

The implementation takes the same approach that was followed in 
[PR-2898](https://github.com/apache/zeppelin/pull/2898).

I have also taken the liberty to correct a preexisting error in the 
description of the use of Dynamic Forms in the associated documentation 
(_jdbc.md_).

### What type of PR is it?
[Feature]

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3377

### How should this be tested?
CI Pass. 

The code in this PR merely causes the JDBC interpreter to "opt-in" to the 
implementation already existing in the `Interpreter` base class - described in 
[PR-2898](https://github.com/apache/zeppelin/pull/2898). The unit tests 
necessary are already present in PR-2898

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, documentation has been added to the 
file _jdbc.md_. I have also taken the liberty to correct a preexisting error in 
the description of the use of Dynamic Forms in the associated documentation.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanjaydasgupta/zeppelin zeppelin-3342-jdbc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2903.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2903


commit 28688256f3b11e696c08ed10875e0596db8c0463
Author: Sanjay Dasgupta 
Date:   2018-03-04T07:36:48Z

ZEPPELIN-1967: Initial updates

commit b461c82569e86436239c9d14a8ae38230bc4f357
Author: Sanjay Dasgupta 
Date:   2018-03-05T02:00:10Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit ced295cb8b27f499b739758b1b17460ab6d67e58
Author: Sanjay Dasgupta 
Date:   2018-03-06T03:47:32Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit a3215fca058398ecbed840a69b4dbf57a2167447
Author: Sanjay Dasgupta 
Date:   2018-03-07T05:15:11Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit f43fd9987b7a10ae41879c52096fdb99f8a28f34
Author: Sanjay Dasgupta 
Date:   2018-03-11T05:40:21Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 3beebce5b5fbb45b295fd5b4bf4b28f9bef8350f
Author: Sanjay Dasgupta 
Date:   2018-03-13T11:33:09Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 3b30ea2143813dfbc48970b1ac094fea30d7d775
Author: Sanjay Dasgupta 
Date:   2018-03-15T10:43:53Z

Reversing previous incorrect update

commit 1718e79646b8de4682cb1c76eb6d4a24e83b3184
Author: Sanjay Dasgupta 
Date:   2018-03-15T14:17:49Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 526880301877125501ea0b1b06c61fcfdc19fe60
Author: Sanjay Dasgupta 
Date:   2018-03-18T04:41:52Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit b7ddf6ba202c2624a289aff67cfad669510ca80d
Author: Sanjay Dasgupta 
Date:   2018-03-18T09:54:23Z

Implementing configuration (global enable/disable interpolation) following 
https://github.com/apache/zeppelin/pull/2834#issuecomment-373948398

commit a1703b820e42e3956f45edf3c02aec8fc3475739
Author: Sanjay Dasgupta 
Date:   2018-03-18T21:05:42Z

Changes suggested in Felix Cheung's review 
https://github.com/apache/zeppelin/pull/2834#pullrequestreview-104805661

commit 3dd3dd879187e20a80cb202df7869c923da8a690
Author: Sanjay Dasgupta 
Date:   2018-03-20T03:47:11Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 1e2c87dd36dc091ca898baf8e9f178d6d1a5e600
Author: Sanjay Dasgupta 
Date:   2018-03-21T01:18:09Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit