Re: Disable Flaky Test
Hi, I think it's good but we might need a plan when we enable them again. Basically, I agree with it. On Tue, Jun 19, 2018 at 1:49 AM, Jeff Zhang wrote: > Hi Folks, > > Seems there's no objection on this, so I assume everyone agree on it. I > have merged this PR. From now on, please double check the travis status > before you merge your PR if you are committer and make sure the travis > build status before you ask others to review if you are not committer. As I > mentioned before, you need to add unit test for your PR and rerun the > travis if it still fails. If your PR make the travis failed, every > committer has the privilege to revert your PR. > > > > Jeff Zhang 于2018年6月15日周五 上午9:46写道: > > > > > BTW, please* add unit test for any new PR* unless it is very trivial > > change and other committer agree it is OK without unit test. If you find > > it is difficult to add unit test. There will be several reasons according > > my experience. > > > > 1. It is due to the architecture and evolution of zeppelin, as more and > > more components and features added to zeppelin, many things may be > coupled > > together which make it difficult to add unit test. In this case, please > > comment in your PR why it is difficult to add unit test, and what is your > > plan for that. Code refactoring in some component of zeppelin or unit > test. > > > > 2. It is due to your PR that introduce too much complexity or didn't do > it > > in a elegant approach. In this case, please rethink your PR to improve > it. > > > > > > > > > > Jeff Zhang 于2018年6月15日周五 上午8:59写道: > > > >> Hi Folks, > >> > >> The zeppelin travis become unstable again recently. I know it is really > >> annoying and frustrated, so I create a PR to disable these flaky tests. > >> There still some flaky test, but happens in low frequency. According my > >> experience, if you still have travis build failure after this PR, you > can > >> try to rerun the travis build to get travis build pass. Just rerun the > >> failed one, don't run the whole travis build matrix and also please > clear > >> travis cache first. If there's no objection, I would commit this PR. And > >> after that, please keep travis build passed before you commit any new > >> changes. Thanks. > >> > >> https://github.com/apache/zeppelin/pull/3020 > >> > >> > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net
Re: Disable Flaky Test
Hi Folks, Seems there's no objection on this, so I assume everyone agree on it. I have merged this PR. From now on, please double check the travis status before you merge your PR if you are committer and make sure the travis build status before you ask others to review if you are not committer. As I mentioned before, you need to add unit test for your PR and rerun the travis if it still fails. If your PR make the travis failed, every committer has the privilege to revert your PR. Jeff Zhang 于2018年6月15日周五 上午9:46写道: > > BTW, please* add unit test for any new PR* unless it is very trivial > change and other committer agree it is OK without unit test. If you find > it is difficult to add unit test. There will be several reasons according > my experience. > > 1. It is due to the architecture and evolution of zeppelin, as more and > more components and features added to zeppelin, many things may be coupled > together which make it difficult to add unit test. In this case, please > comment in your PR why it is difficult to add unit test, and what is your > plan for that. Code refactoring in some component of zeppelin or unit test. > > 2. It is due to your PR that introduce too much complexity or didn't do it > in a elegant approach. In this case, please rethink your PR to improve it. > > > > > Jeff Zhang 于2018年6月15日周五 上午8:59写道: > >> Hi Folks, >> >> The zeppelin travis become unstable again recently. I know it is really >> annoying and frustrated, so I create a PR to disable these flaky tests. >> There still some flaky test, but happens in low frequency. According my >> experience, if you still have travis build failure after this PR, you can >> try to rerun the travis build to get travis build pass. Just rerun the >> failed one, don't run the whole travis build matrix and also please clear >> travis cache first. If there's no objection, I would commit this PR. And >> after that, please keep travis build passed before you commit any new >> changes. Thanks. >> >> https://github.com/apache/zeppelin/pull/3020 >> >>
[GitHub] zeppelin pull request #3020: ZEPPELIN-3535. Disable flaky test
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/3020 ---
[GitHub] zeppelin issue #3020: ZEPPELIN-3535. Disable flaky test
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3020 Github fails to sync up with apache git, now it is synced. ---
Re: Disable Flaky Test
BTW, please* add unit test for any new PR* unless it is very trivial change and other committer agree it is OK without unit test. If you find it is difficult to add unit test. There will be several reasons according my experience. 1. It is due to the architecture and evolution of zeppelin, as more and more components and features added to zeppelin, many things may be coupled together which make it difficult to add unit test. In this case, please comment in your PR why it is difficult to add unit test, and what is your plan for that. Code refactoring in some component of zeppelin or unit test. 2. It is due to your PR that introduce too much complexity or didn't do it in a elegant approach. In this case, please rethink your PR to improve it. Jeff Zhang 于2018年6月15日周五 上午8:59写道: > Hi Folks, > > The zeppelin travis become unstable again recently. I know it is really > annoying and frustrated, so I create a PR to disable these flaky tests. > There still some flaky test, but happens in low frequency. According my > experience, if you still have travis build failure after this PR, you can > try to rerun the travis build to get travis build pass. Just rerun the > failed one, don't run the whole travis build matrix and also please clear > travis cache first. If there's no objection, I would commit this PR. And > after that, please keep travis build passed before you commit any new > changes. Thanks. > > https://github.com/apache/zeppelin/pull/3020 > >
Disable Flaky Test
Hi Folks, The zeppelin travis become unstable again recently. I know it is really annoying and frustrated, so I create a PR to disable these flaky tests. There still some flaky test, but happens in low frequency. According my experience, if you still have travis build failure after this PR, you can try to rerun the travis build to get travis build pass. Just rerun the failed one, don't run the whole travis build matrix and also please clear travis cache first. If there's no objection, I would commit this PR. And after that, please keep travis build passed before you commit any new changes. Thanks. https://github.com/apache/zeppelin/pull/3020
[GitHub] zeppelin pull request #3020: ZEPPELIN-3535. Disable flaky test
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3020 ZEPPELIN-3535. Disable flaky test ### What is this PR for? This PR is trying to disable the flaky test of zeppelin that fails very frequently. ### What type of PR is it? [Bug Fix | Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3535 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3535 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3020.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3020 commit c30cd1f3712b658cd48a754e29baa30da8050fa5 Author: Jeff Zhang Date: 2018-06-13T03:13:04Z ZEPPELIN-3535. Disable flaky test ---