[GitHub] zeppelin pull request #1407: [ZEPPELIN-1412] add support multiline for pytho...

[cloverhearts]

GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/1407

[ZEPPELIN-1412] add support multiline for pythonErrorIn method on python 
interpreter

### What is this PR for?
currently, has not support multiline exception text on python interpreter.
for example:

```
Exception: blabla
```
is error.

but

```
Traceback (most recent call last):
  File "", line 1, in 
Exception: test exception
```
is sucess (now)


to resolve this issue.

### What type of PR is it?
Bug Fix

### Todos
- [x] modification pythonErrorIn method
- [x] add test case

### What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1412?jql=project%20%3D%20ZEPPELIN%20AND%20status%20%3D%20Open

### How should this be tested?
added test case.

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin dev/ZEPPELIN-1412

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1407.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1407


commit e6741348c9a5338141f90f6f91cc7dbb2c9e284a
Author: CloverHearts 
Date:   2016-09-06T06:35:45Z

add multiline support pythonErrorIn method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1396
  
Thanks! I'll look into it. btw, don't you have any problem when you were 
testing mysql?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1415) Zeppelin-Web Good Practices #2 - Event Dispatching

[CORNEAU Damien (JIRA)]

CORNEAU Damien created ZEPPELIN-1415:


 Summary: Zeppelin-Web Good Practices #2 - Event Dispatching
 Key: ZEPPELIN-1415
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1415
 Project: Zeppelin
  Issue Type: Task
Reporter: CORNEAU Damien
Assignee: CORNEAU Damien


This Good Practice Guide will focus on how to handle the event dispatching 
correctly in the app ($broadcast, $emit, $on)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1396
  
Thanks @jongyoul and there was no problem running mysql.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...

[kavinkumarks]

Github user kavinkumarks commented on the issue:

https://github.com/apache/zeppelin/pull/1393
  
@khalidhuseynov thanks for the review! I have replied to the comments and 
the CI build is in progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

[corneadoug]

GitHub user corneadoug opened a pull request:

https://github.com/apache/zeppelin/pull/1406

[ZEPPELIN-1414] Remove CONTRIBUTING.md files

### What is this PR for?
Following the PR #1356, we now have the contribution documentation to on 
Apache Zeppelin Website.

We can now remove the contributing files from the repository, and replace 
the links to that documentation.


### What type of PR is it?
Documentation

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1414

### How should this be tested?
Just check if there is other CONTRIBUTING.md files and if there is other 
links to replace

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1414

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1406.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1406


commit 194fe846df391c684314a43cf39a8654367b6211
Author: Damien CORNEAU 
Date:   2016-09-06T06:32:00Z

Remove contributing files

commit 1168a898ae26b2234af399f4227bafb19a77838d
Author: Damien CORNEAU 
Date:   2016-09-06T06:32:23Z

Remove contributing files from RAT

commit 3271d54dd45a0588b780101d06f6e041296efc30
Author: Damien CORNEAU 
Date:   2016-09-06T06:33:15Z

Make links to contribution material point to the website




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1359: [ZEPPELIN-966] job manager change information collecti...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1359
  
@cloverhearts Okay i'll check this tomorrow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1384
  
@Leemoonsoo @felixcheung Are we good on that PR?
CI is failing on tests, not related to this PR as its happening to other 
PRs.
But would be better to merge this one after CI is fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1387: [ZEPPELIN-1398] Use relative path for search_da...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1387


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1384
  
Because now github-markdown-css is downloaded on build time instead of 
packed in the source tree, related license now need to moved back to under 
bin_licenses. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1384
  
@1ambda 👍  fot tests, looks great to me except for licensing issue 
raised by Moon and small comment above.

If you could let me know you user name in ASF JIRA I'll be happy to help 
assigning ZEPPELIN-1387 to you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

[echarles]

Github user echarles commented on the issue:

https://github.com/apache/zeppelin/pull/1390
  
@khalidhuseynov 

-  have fixed the format issues
- I didn't change Notebook#getNotebookAuthorization, it was already 
present. However, a single global NotebookAuthorization as you like will change 
this. Will push something that moves the NotebookAuthorization out of the 
Notebook.
- The ZEPPELIN_AUTH_USER_KEY is used to remove the object from the user WEB 
session when user session expires... (to free memory and avoid OOM) however it 
is not yet used to put the objects... Will also push something.

@corneadoug I will write asap a small document explaining the logic behing 
this PR (interpreter factory by user, runAs...).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1407: [ZEPPELIN-1412] add support multiline for pythonErrorI...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1407
  
Thank you for improvements, @cloverhearts 

Looks good to me.

Although as discussed under 
[ZEPPELIN-1360](https://issues.apache.org/jira/browse/ZEPPELIN-1360) - this 
approach have performance implications and this code most probably is going to 
be removed under 
[ZEPPELIN-1325](https://issues.apache.org/jira/browse/ZEPPELIN-1325).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1405: Update Zeppelin Website building instructions

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1405
  
@corneadoug There is one more `--safe` in here : 
[https://github.com/apache/zeppelin/blob/gh-pages/contribution/documentation.md#deploy-to-asf-svnpubsub-infra](https://github.com/apache/zeppelin/blob/gh-pages/contribution/documentation.md#deploy-to-asf-svnpubsub-infra)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1359: [ZEPPELIN-966] job manager change information collecti...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1359
  
@Leemoonsoo Thank you very much!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1406
  
@AhyoungRyu Yes, this one could also be replaced.
There is actually a few pages of content inside the docs directory that we 
may want to move to the website later, so maybe we should create a JIRA issue 
for that migration too.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1407: [ZEPPELIN-1412] add support multiline for pythonErrorI...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1407
  
@bzz 
thank you.
This code works with both Python 3 and 2.
In this code, the part that related to the Python version does not exist 
except `print (" Exception ( "test exception")) `entry in the test code.
Thank you for your answer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1401: [ZEPPELIN-1409] Refactor RAT build on Travis.CI config...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1401
  
Looks good to me, merging if there is no further discussion.

CI fails on single profile with 1 flaky test

```
[INFO] Zeppelin: Server ... FAILURE [03:39 
min]

Failed tests: 
  ZeppelinSparkClusterTest.zRunTest:204 expected: but was:
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1401: [ZEPPELIN-1409] Refactor RAT build on Travis.CI...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1401


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1406
  
@corneadoug There is one more "how to contribute" link - 
[http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/#100-opensource](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/#100-opensource)
 :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1334
  
After running it locally, I think it is great but the last thing that would 
be very nice to have, is to expand the example in the docs to be 
self-contained, meaning easily runnable by the the first-time Beam user. 

Also rebase this branch on the latest master is needed (I guess 
`.travis.yaml` was changed a bit by skipping RAT in all default profiles)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1408: [ZEPPELIN-808] Changed Permissions on Notebooks...

[kavinkumarks]

GitHub user kavinkumarks opened a pull request:

https://github.com/apache/zeppelin/pull/1408

[ZEPPELIN-808] Changed Permissions on Notebooks do not provide helpful 
error to user

### What is this PR for?
This is about showing information to the user when there are errors on 
running paragraphs eg. there could be permission related issue with notebook.

### What type of PR is it?
Improvement

### Todos
NA

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-808

### How should this be tested?
* Create a notebook as a different user than the current user running the 
zeppelin instance
* Try to run all the paragraphs or any individual paragraph for the notebook
* The information as shown in the screenshot should be displayed and the 
dialog could be closed by the 'Close' button.

### Screenshots (if appropriate)

![erroraboutrunningparagraph](https://cloud.githubusercontent.com/assets/20789766/18273907/603f1104-745d-11e6-9ba9-89d444170a1a.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kavinkumarks/zeppelin 
zeppelin-808-handle-notebook-permission-error

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1408


commit 491972b7b989cd1c6a4ff8ca8599f121cc11a9a0
Author: Kavin 
Date:   2016-09-06T12:21:26Z

Show information to the user when there are errors with related to
permission on running paragraphs.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1393: [ZEPPELIN-1142] Zeppelin allows two users to si...

[kavinkumarks]

GitHub user kavinkumarks reopened a pull request:

https://github.com/apache/zeppelin/pull/1393

[ZEPPELIN-1142] Zeppelin allows two users to simultaneously edit the 
notebook permissions

### What is this PR for?
This is about storing the owner information on creating a note so when the 
same user tries to edit the permissions of the note he could do it successfully.

### What type of PR is it?
Improvement

### Todos
NA

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1142

### How should this be tested?
Check the below cases via the web application or REST API calls and the 
owner information should be persisted properly.
* Create note
* Clone note
* Import note

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kavinkumarks/zeppelin 
zeppelin-1142-simultaneous-note-permission-error

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1393


commit 4412692cdd48a23ccf9578ddbcfe0205784ac92d
Author: Kavin 
Date:   2016-09-01T11:19:41Z

Store owner information on creating a note and added integration test
cases for the relevant scenarios.

commit 85af4e6178c82414526386ac3d72239a279789b4
Author: Kavin 
Date:   2016-09-06T09:20:14Z

Removed the duplicate instance of notebook variable and reused the
existing one.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1393: [ZEPPELIN-1142] Zeppelin allows two users to si...

[kavinkumarks]

Github user kavinkumarks closed the pull request at:

https://github.com/apache/zeppelin/pull/1393


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...

[kavinkumarks]

Github user kavinkumarks commented on the issue:

https://github.com/apache/zeppelin/pull/1393
  
Found an build test failure, working on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1393: [ZEPPELIN-1142] Zeppelin allows two users to simultane...

[kavinkumarks]

Github user kavinkumarks commented on the issue:

https://github.com/apache/zeppelin/pull/1393
  
Reopening to trigger the CI build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1265
  
@corneadoug I summarize all of unique combination. I think 'Per user' is 
the first criteria and 'Per note' is the second priority. And I also have a 
question. Can front-end know if shiro is enabled or not? If it's possible, I 
have another request that if shiro is disabled, hide 'Per user' option. It's 
actually useless without shiro and reduces the confusion. thus I appreciate you 
will make UI support only for the below:

[Per user] - [isolated] and [Per note] - [scoped]
[Per user] - [isolated] and [Per note] - [isolated]
[Per user] - [scoped] and [Per note] - [scoped]

I also thought about the modes above if it's possible or not, and I've 
figure out the above are possible. And I think that [Per user] - [scoped] and 
[Per note] - [isolated] doesn't makes sense and I want to disable to set the 
option like that.

Thanks for your help!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1379: [ZEPPELIN-1116]send out more exception msg

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1379


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1379: [ZEPPELIN-1116]send out more exception msg

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1379
  
@passionke Can you tell me your jira id?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1380: ZEPPELIN-1326: make profile to select dependency of ha...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1380
  
@Leemoonsoo I've misunderstood your comment. LGTM. Merging if there's no 
more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1379: [ZEPPELIN-1116]send out more exception msg

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1379
  
@passionke Sorry for the late reply. Thanks for the comment. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1390
  
@echarles I've looked around your PR. I think your PR makes Zeppelin 
support separate users within a same instance. I have two questions regarding 
current behaviour. The first is about collaborative mode. If some users want to 
share their notebook to others which are able to login in same Zeppelin 
instance, and enable them to run it, how can user do that? The second one is 
about running interpreter instance. For now, Zeppelin supports three mode for 
different notes to run an interpreter, 'shared', 'scoped', 'isolated'. But in 
your PR, because you make interpreterFactory divided by users, all interpreters 
run a 'isolated' mode for all users. This means that if hundred users run 
simple markdown interpreter, Zeppelin launches same number of JVM on a same 
host. My PR considers that situation but your PR divide interpreterFactory by 
user, then will break my consideration. What do you think of it?

And complexity of configuration, @corneadoug will help to make intuitive 
menu.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1399: [ZEPPELIN-1182] Zeppelin should have Startup and Shutd...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1399
  
Done or WIP?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: How to start Zeppelin By IDE

[Jongyoul Lee]

Hello,

I'm using IntelliJ and there's my step below.

1. mvn clean pakcage -DskipTest
2. Debug ZeppelinServer

Regards,
Jongyoul

On Fri, Sep 2, 2016 at 6:02 AM, moon soo Lee  wrote:

> Hi,
>
> Eclipse, i used to create eclipse project file by running "mvn
> eclipse:eclipse".
> IDEA, just importing maven project and it usually works without problem.
>
> You can also check
> http://zeppelin.apache.org/docs/latest/development/howtocontribute.html#
> integrated-development-environment-ide
> http://zeppelin.apache.org/docs/latest/development/
> howtocontributewebsite.html
>
> Thanks,
> moon
>
>
> On Fri, Sep 2, 2016 at 6:58 AM Hefei Li  wrote:
>
> > Hi,all:
> >
> > I want to try start Zeppelin server in development mode by IDE
> (Eclipse
> > or IDEA.).
> >
> > Now, can you give me some help and advice！
> > --
> >
> > =
> >
> > Hefei Li
> >
> > MP: +86 18701581473
> > MSN: lh...@live.cn
> > =
> >
>



-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1406
  
Good! I like it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1416) Update Flink with latest version 1.1.1

[Trevor Grant (JIRA)]

Trevor Grant created ZEPPELIN-1416:
--

 Summary: Update Flink with latest version 1.1.1
 Key: ZEPPELIN-1416
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1416
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Trevor Grant
Assignee: Trevor Grant






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1384
  
looks fine to me, I'd defer to others on licensing. thanks for the great 
contribution!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1409: [ZEPPELIN-1461] Update Flink with latest versio...

[rawkintrevo]

GitHub user rawkintrevo opened a pull request:

https://github.com/apache/zeppelin/pull/1409

[ZEPPELIN-1461] Update Flink with latest version 1.1.2

### What is this PR for?
Flink has had two releases since 1.0.3, we are now on 1.1.2

This includes new functionality for streaming support in repl environment.

### What type of PR is it?
 Improvement 

### Todos
* [x] - Update `pom.xml`
* [x] - Update single (batch) environment to batch and streaming 
environments

### What is the Jira issue?

[https://issues.apache.org/jira/browse/ZEPPELIN-1416?filter=-1](https://issues.apache.org/jira/browse/ZEPPELIN-1416?filter=-1)

### How should this be tested?
Tests for previous versions are the same as new version.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
Yes* older code written in the Flink interpreter will now have to use 
`benv` in place of `env`
* Does this needs documentation?
No 




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/incubator-zeppelin zeppelin-1461

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1409


commit 9921a7ecfa4102461a2f79baac77d4c423238e37
Author: rawkintrevo 
Date:   2016-09-06T17:10:20Z

[ZEPPELIN-1461] Update Flink with latest version 1.1.2




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1409: [ZEPPELIN-1461] Update Flink with latest version 1.1.2

[rawkintrevo]

Github user rawkintrevo commented on the issue:

https://github.com/apache/zeppelin/pull/1409
  
[Profile 2](https://travis-ci.org/apache/zeppelin/jobs/157948630) 
[Profile 3](https://travis-ci.org/apache/zeppelin/jobs/157948631)
[Profile 4](https://travis-ci.org/apache/zeppelin/jobs/157948632)
All fail at `testWordCount`
```
testWordCount(org.apache.zeppelin.flink.FlinkInterpreterTest)  Time 
elapsed: 0.204 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.zeppelin.flink.FlinkInterpreterTest.testWordCount(FlinkInterpreterTest.java:87)


Results :

Failed tests: 
  FlinkInterpreterTest.testWordCount:87 expected: but was:
```

[Profile 6](https://travis-ci.org/apache/zeppelin/jobs/157948634) Stalled 
in pyspark interpreter.

Very curious that some profiles fail this test, but others pass. Will 
explore tonight. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1402: [MINOR] Remove duplicated dependency declaratio...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1402


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1399: [ZEPPELIN-1182] Zeppelin should have Startup and Shutd...

[rajarajan-g]

Github user rajarajan-g commented on the issue:

https://github.com/apache/zeppelin/pull/1399
  
I am logging the configuration details of Zeppelin . I am not sure if we 
have any more configuration details to be logged. Please check PR and let me 
know if any more configuration needs to be added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1369
  
I also checked the interpreter setting page like @astroshim  did. 
(edit interpreter -> add `one:two:1.1.1` to the dependency table -> save ) 

Two things are different with master branch. 
1. Only Spark interpreter throw the `ng-toast` error message.
2. The other interpreters' status circle is looping infinitely. It need to 
be reload to turn to red and also don't show the `ng-toast` error message. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

[doanduyhai]

Github user doanduyhai commented on the issue:

https://github.com/apache/zeppelin/pull/1369
  
Let me investigate the root cause, it should be some Javascript subtle bug 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1406: [ZEPPELIN-1414] Remove CONTRIBUTING.md files

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1406
  
Not sure if it's important, the thing with having a file called 
Contributing.md is that github actually automatically notify the person 
creating a PR:

![image](https://cloud.githubusercontent.com/assets/8969467/18301223/96df8a32-7484-11e6-818f-d5e1c56e774d.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---