[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2925
  
I am saying using group is not good, it just depends on user's setting. 
BTW, it looks like this PR also works for your scenario. In this PR, I would 
always choose the owner to run the cronjob. And in your case, you just set the 
owner as group. Do I understand it correctly ? :)




---

[GitHub] zeppelin issue #2932: [ZEPPELIN-3415] Fix export notebook functionality

[r-kamath]

Github user r-kamath commented on the issue:

https://github.com/apache/zeppelin/pull/2932
  
LGTM


---

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2925
  
@mebelousov Your solution depends on shiro setting, we  could not assume 
that in code.


---

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

[mebelousov]

Github user mebelousov commented on the issue:

https://github.com/apache/zeppelin/pull/2925
  
@zjffdu This is your solution ;) I have tested your branch.

Do we have uniform opinion that running document as the group is not good?


---

[GitHub] zeppelin issue #2932: [ZEPPELIN-3415] Fix export notebook functionality

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2932
  
Merging this to master and branch-0.8 if no more discussion.


---

[GitHub] zeppelin issue #2930: ZEPPELIN-3414. branch-0.8 - download py4j from main re...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2930
  
@mebelousov I don't think this will work for 0.8. In 0.9, I just put py4j 
in the code base of zeppelin, that's why I can avoid downloading it in pom. 


---

[GitHub] zeppelin issue #2930: ZEPPELIN-3414. branch-0.8 - download py4j from main re...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2930
  
@mebelousov I don't think this will work for 0.8. In 0.9, I just put py4j 
in the code base of zeppelin, that's why I can avoid downloading it in pom. 


---

[GitHub] zeppelin issue #2864: ZEPPELIN-3325: R interpreter build bugfix

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2864
  
4 is flaky test, LGTM


---

[GitHub] zeppelin issue #2864: ZEPPELIN-3325: R interpreter build bugfix

[necosta]

Github user necosta commented on the issue:

https://github.com/apache/zeppelin/pull/2864
  
ping @zjffdu 
https://travis-ci.org/nokia/zeppelin/builds/368034675 (stage 4 looks broken)
Thanks


---

[GitHub] zeppelin pull request #2933: ZEPPELIN-3416: Bump up the version of xercesImp...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2933

ZEPPELIN-3416: Bump up the version of xercesImpl to 2.11.0.SP5

### What is this PR for?
Update xercesImpl to 2.11.0.SP5 to get some fixes. This is a required 
dependency for jdbc-phoenix.



### What type of PR is it?
[ Improvement ]

### What is the Jira issue?
* [ZEPPELIN-3416](https://issues.apache.org/jira/browse/ZEPPELIN-3416)

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3416

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2933.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2933


commit 8c891b6ae42dc804473f491786ac48e4439ac389
Author: Prabhjyot Singh 
Date:   2018-04-19T10:38:09Z

ZEPPELIN-3416: Update xercesImpl to 2.11.0.SP5

Change-Id: Ic6b87bad7a13db1bb0bc32478fe302c53818fa0e




---

[GitHub] zeppelin issue #2933: ZEPPELIN-3416: Bump up the version of xercesImpl to 2....

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2933
  
@zjffdu @r-kamath  Please help review this.


---

[jira] [Created] (ZEPPELIN-3416) Update xercesImpl to 2.11.0.SP5 to get some fixes.

[Prabhjyot Singh (JIRA)]

Prabhjyot Singh created ZEPPELIN-3416:
-

 Summary: Update xercesImpl to 2.11.0.SP5 to get some fixes.
 Key: ZEPPELIN-3416
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3416
 Project: Zeppelin
  Issue Type: Bug
 Environment: Update xercesImpl to 2.11.0.SP5 to get some fixes.
Reporter: Prabhjyot Singh






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zeppelin pull request #2934: [ZEPPELIN-3417] fix dependency in zeppelin-web/...

[Savalek]

GitHub user Savalek opened a pull request:

https://github.com/apache/zeppelin/pull/2934

[ZEPPELIN-3417] fix dependency in zeppelin-web/package.json

### What is this PR for?
The address of the dependency in zeppelin-web/package.json changed from 
"shahata/angular-viewport-watch" to "wix/angular-viewport-watch"

[LINK](https://github.com/wix/angular-viewport-watch) to current repository 
of angular-viewport-watch

### What type of PR is it?
[Improvement]

### What is the Jira issue?
[ZEPPELIN-3417](https://issues.apache.org/jira/browse/ZEPPELIN-3417)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3417

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2934.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2934


commit 1cd64aeb16b01eb442f14393b35683a6b98065d0
Author: Savalek 
Date:   2018-04-19T12:42:39Z

fix dependency in zeppelin-web/package.json




---

[GitHub] zeppelin issue #2931: ZEPPELIN-3405 Zeppelin fails to display the User home ...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2931
  
LGTM


---

[GitHub] zeppelin issue #2931: ZEPPELIN-3405 Zeppelin fails to display the User home ...

[r-kamath]

Github user r-kamath commented on the issue:

https://github.com/apache/zeppelin/pull/2931
  
will merge this if there are no more discussions


---

[GitHub] zeppelin pull request #2931: ZEPPELIN-3405 Zeppelin fails to display the Use...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2931


---

[GitHub] zeppelin pull request #2864: ZEPPELIN-3325: R interpreter build bugfix

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2864


---

[jira] [Created] (ZEPPELIN-3417) Change the dependency in zeppelin-web/package.json

[Aleksey Savelenko (JIRA)]

Aleksey Savelenko created ZEPPELIN-3417:
---

 Summary: Change the dependency in zeppelin-web/package.json
 Key: ZEPPELIN-3417
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3417
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Aleksey Savelenko
Assignee: Aleksey Savelenko
 Fix For: 0.9.0


The package has a dependency. But the desired package is now at a different 
address. Yeah, well, GIT is doing the forwarding, but maybe someday it'll make 
a error.

old: "angular-viewport-watch": "github:wix/angular-viewport-watch"

new: "angular-viewport-watch": "github:shahata/angular-viewport-watch"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

[weand]

Github user weand commented on the issue:

https://github.com/apache/zeppelin/pull/2925
  
@mebelousov I fully agree that running document as the group is not what a 
user would expect.

That's why I'm proposing another approach again:
1) prior to #2914 the cronExecutionUser config property was added to 
org.apache.zeppelin.notebook.Note.config when activating the cron and entering 
a username
2) that property is not set anymore. this PR here only sets the 
authentication info at running time to something (a principal) from the 
permission tab (which can be user or groups, which can not be determined 
properly)
3) so why not again set that cronExecutionUser config property from 1) 
(under the hood): with the user who activates the cron schedule expression. 
when only the owner can enable cron expressions, it will always be the username 
regardless of what principals exactly are configured in the permissions tab.


---

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2925
  
Thanks @weand , I agree with you that your proposal seems much easier. I 
have updated the PR, please help verify it, thanks 


---