[jira] [Created] (ZEPPELIN-4609) Unable to streaming output when there's different types of output
Jeff Zhang created ZEPPELIN-4609:
Summary: Unable to streaming output when there's different types
of output
Key: ZEPPELIN-4609
URL: https://issues.apache.org/jira/browse/ZEPPELIN-4609
Project: Zeppelin
Issue Type: Improvement
Affects Versions: 0.9.0
Reporter: Jeff Zhang
{code:java}
%python.ipython
print("hello world")
print("%html hello world")
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [zeppelin] alexott commented on issue #3636: [ZEPPELIN-4597]. Deprecate r module
alexott commented on issue #3636: [ZEPPELIN-4597]. Deprecate r module URL: https://github.com/apache/zeppelin/pull/3636#issuecomment-585148201 Just general comment - should we have a document that will describe "bigger" changes, like, removal or addition of interpreters, etc.? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] alexott commented on a change in pull request #3641: [ZEPPELIN-3751]. Interpreter Binding menu of note only shows default interpreter
alexott commented on a change in pull request #3641: [ZEPPELIN-3751].
Interpreter Binding menu of note only shows default interpreter
URL: https://github.com/apache/zeppelin/pull/3641#discussion_r378177138
##
File path: zeppelin-web/src/app/notebook/notebook.controller.js
##
@@ -1251,11 +1251,11 @@ function NotebookCtrl($scope, $route, $routeParams,
$location, $rootScope,
};
const isSettingDirty = function() {
-// if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
-// return false;
-// } else {
-return false;
-// }
+if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
+ return false;
+} else {
+ return false;
Review comment:
do we need condition if we just return false in both cases?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3636: [ZEPPELIN-4597]. Deprecate r module
zjffdu commented on issue #3636: [ZEPPELIN-4597]. Deprecate r module URL: https://github.com/apache/zeppelin/pull/3636#issuecomment-585179595 Make sense, thanks for the suggestion. @alexott This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3641: [ZEPPELIN-3751]. Interpreter Binding menu of note only shows default interpreter
zjffdu commented on a change in pull request #3641: [ZEPPELIN-3751].
Interpreter Binding menu of note only shows default interpreter
URL: https://github.com/apache/zeppelin/pull/3641#discussion_r378217150
##
File path: zeppelin-web/src/app/notebook/notebook.controller.js
##
@@ -1251,11 +1251,11 @@ function NotebookCtrl($scope, $route, $routeParams,
$location, $rootScope,
};
const isSettingDirty = function() {
-// if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
-// return false;
-// } else {
-return false;
-// }
+if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
+ return false;
+} else {
+ return false;
Review comment:
False is for the case when there's no changes in interpreter binding, then
we don't need to invoke the rest api.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] alexott commented on a change in pull request #3641: [ZEPPELIN-3751]. Interpreter Binding menu of note only shows default interpreter
alexott commented on a change in pull request #3641: [ZEPPELIN-3751].
Interpreter Binding menu of note only shows default interpreter
URL: https://github.com/apache/zeppelin/pull/3641#discussion_r378218366
##
File path: zeppelin-web/src/app/notebook/notebook.controller.js
##
@@ -1251,11 +1251,11 @@ function NotebookCtrl($scope, $route, $routeParams,
$location, $rootScope,
};
const isSettingDirty = function() {
-// if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
-// return false;
-// } else {
-return false;
-// }
+if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
+ return false;
+} else {
+ return false;
Review comment:
but we return false in both cases... should `else` return `true`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3641: [ZEPPELIN-3751]. Interpreter Binding menu of note only shows default interpreter
zjffdu commented on a change in pull request #3641: [ZEPPELIN-3751].
Interpreter Binding menu of note only shows default interpreter
URL: https://github.com/apache/zeppelin/pull/3641#discussion_r378218709
##
File path: zeppelin-web/src/app/notebook/notebook.controller.js
##
@@ -1251,11 +1251,11 @@ function NotebookCtrl($scope, $route, $routeParams,
$location, $rootScope,
};
const isSettingDirty = function() {
-// if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
-// return false;
-// } else {
-return false;
-// }
+if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
+ return false;
+} else {
+ return false;
Review comment:
Oops, I think this is a bug, I will fix it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3641: [ZEPPELIN-3751]. Interpreter Binding menu of note only shows default interpreter
zjffdu commented on a change in pull request #3641: [ZEPPELIN-3751].
Interpreter Binding menu of note only shows default interpreter
URL: https://github.com/apache/zeppelin/pull/3641#discussion_r378218709
##
File path: zeppelin-web/src/app/notebook/notebook.controller.js
##
@@ -1251,11 +1251,11 @@ function NotebookCtrl($scope, $route, $routeParams,
$location, $rootScope,
};
const isSettingDirty = function() {
-// if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
-// return false;
-// } else {
-return false;
-// }
+if (angular.equals($scope.interpreterBindings,
$scope.interpreterBindingsOrig)) {
+ return false;
+} else {
+ return false;
Review comment:
Oop, I think this is a bug, I will fix it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (ZEPPELIN-4610) Paragraph is always in PENDING state even when the job is done
Jeff Zhang created ZEPPELIN-4610: Summary: Paragraph is always in PENDING state even when the job is done Key: ZEPPELIN-4610 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4610 Project: Zeppelin Issue Type: Bug Reporter: Jeff Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378631166 ## File path: influxdb/README.md ## @@ -0,0 +1,18 @@ +InfluxDB 2.0 interpreter for Apache Zeppelin + + +## Description: + +Provide InfluxDB Interpreter for Zeppelin. + +## Build + +``` +mvn -pl zeppelin-interpreter,zeppelin-display,influxdb -DskipTests package Review comment: You can use `mvn -pl influxdb -am -DskipTests package`, influxdb depends on zeppelin-interpreter-shaded, so use `-am` would be easier. BTW, does influxdb interpreter depends on zeppelin-display ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378631341
##
File path: influxdb/pom.xml
##
@@ -0,0 +1,87 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+4.0.0
+
+zeppelin-interpreter-parent
+org.apache.zeppelin
+0.9.0-SNAPSHOT
+../zeppelin-interpreter-parent/pom.xml
+
+
+zeppelin-influxdb
+jar
+0.9.0-SNAPSHOT
+Zeppelin: InfluxDB interpreter
+InfluxDB 2.0 timeseries database support
+
+
+influxdb
+UTF-8
+
+1.4.0
+3.13.1
+2.8.5
+
+
+
+
+com.influxdb
+influxdb-client-java
+${influxdb.client.version}
Review comment:
What is the license of this dependency ? You need to put it in LICENCE file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378631422
##
File path: influxdb/pom.xml
##
@@ -0,0 +1,87 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+4.0.0
+
+zeppelin-interpreter-parent
+org.apache.zeppelin
+0.9.0-SNAPSHOT
+../zeppelin-interpreter-parent/pom.xml
+
+
+zeppelin-influxdb
+jar
+0.9.0-SNAPSHOT
+Zeppelin: InfluxDB interpreter
+InfluxDB 2.0 timeseries database support
+
+
+influxdb
+UTF-8
+
+1.4.0
+3.13.1
+2.8.5
+
+
+
+
+com.influxdb
+influxdb-client-java
+${influxdb.client.version}
+
+
+com.google.code.gson
+gson
+${dependency.gson.version}
+
+
+com.squareup.okhttp3
+mockwebserver
+${dependency.okhttp3.version}
Review comment:
Same licence issue as above
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added initial version of InfluxDB interpreter
zjffdu commented on a change in pull request #3640: [ZEPPELIN-4602] Added
initial version of InfluxDB interpreter
URL: https://github.com/apache/zeppelin/pull/3640#discussion_r378631501
##
File path: influxdb/pom.xml
##
@@ -0,0 +1,87 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+4.0.0
+
+zeppelin-interpreter-parent
+org.apache.zeppelin
+0.9.0-SNAPSHOT
+../zeppelin-interpreter-parent/pom.xml
+
+
+zeppelin-influxdb
+jar
+0.9.0-SNAPSHOT
+Zeppelin: InfluxDB interpreter
+InfluxDB 2.0 timeseries database support
+
+
+influxdb
+UTF-8
+
+1.4.0
+3.13.1
+2.8.5
+
+
+
+
+com.influxdb
+influxdb-client-java
+${influxdb.client.version}
+
+
+com.google.code.gson
+gson
+${dependency.gson.version}
+
+
+com.squareup.okhttp3
+mockwebserver
+${dependency.okhttp3.version}
+test
+
+
+
+
+
+
+maven-enforcer-plugin
+
+
+maven-dependency-plugin
+
+
+maven-resources-plugin
+
+
+maven-shade-plugin
+
+
+org.apache.maven.plugins
+maven-checkstyle-plugin
+
+false
Review comment:
It's better to enable it. We are planning to enable it for other modules as
well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (ZEPPELIN-4611) Fetching rows with newline character (\n) breaks entire table
Woong Seok Kang created ZEPPELIN-4611:
-
Summary: Fetching rows with newline character (\n) breaks entire
table
Key: ZEPPELIN-4611
URL: https://issues.apache.org/jira/browse/ZEPPELIN-4611
Project: Zeppelin
Issue Type: Bug
Components: front-end
Affects Versions: 0.8.2
Reporter: Woong Seok Kang
Attachments: Screen Shot 2020-02-13 at 12.24.04.png, Screen Shot
2020-02-13 at 12.25.28.png, image-2020-02-13-12-25-04-118.png
Original contents:
{noformat}
Comment
블랙데님워싱에 와이드한 일자핏으로 멋스럽게 입기 좋은 멜빵바지입니다.
어깨 오버롤로 기장을 조절할 수 있으며 앞중심의 포켓으로 포인트를 주었답니다.
Size
s,m,l,xl,xxl 사이즈로 기존 s,m,l,xl,xxl 사이즈 착용시 입을 수 있습니다.
... much more ...{noformat}
SELECT result using Zeppelin with a totally broken table:
!image-2020-02-13-12-25-04-118.png!
Expected result: I manually replace newline character to whitespace.
!Screen Shot 2020-02-13 at 12.25.28.png!
Other query browser, such as AWS Athena will automatically replaces newline
character into the whitespace rather than broken table. It would be great if
Zeppelin have a similar behavior in this situation. Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [zeppelin] weand commented on issue #3641: [ZEPPELIN-3751]. Interpreter Binding menu of note only shows default interpreter
weand commented on issue #3641: [ZEPPELIN-3751]. Interpreter Binding menu of note only shows default interpreter URL: https://github.com/apache/zeppelin/pull/3641#issuecomment-585580630 sorry :-1: the proposed change doesn't cover the use case discussed in the jira. With the current changeset, endusers still can't select another default interpreter, if it's not explicitly used in at least one paragraph. So users first need to create a dummy paragraph for each interpreter that should be available for selection. this is useless and not intuitive. In my understanding the list of interpreters available in the list should NOT be derived from the paragraphs. instead we should list every interpreter, to which the current user has access to + the current default interpreter. in case the current default interpreter X is changed to Y and the user has no access to the X, it will be hidden, as soon as the interpreter binding is saved. what do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZEPPELIN-4612) Optimize Notebooks loading
Axel Van Damme created ZEPPELIN-4612:
Summary: Optimize Notebooks loading
Key: ZEPPELIN-4612
URL: https://issues.apache.org/jira/browse/ZEPPELIN-4612
Project: Zeppelin
Issue Type: Improvement
Components: NotebookRepo
Affects Versions: 0.9.0
Environment: Number of Notebooks in NotebookRepo:
{code:java}
root@zeppelin:/opt# find NotebookRepo/ -type f -not -path "NotebookRepo/.git/*"
| wc -l
1524
{code}
Disk space used by the NotebookRepo:
{code:java}
root@zeppelin:/opt# du -skh NotebookRepo/
2.7GNotebookRepo/
{code}
Environment variable:
{code:java}
root@zeppelin:/opt/zeppelin/logs# echo $ZEPPELIN_MEM
-Xmx8192m -XX:MaxPermSize=1024m
{code}
Memory used before first login in Zeppelin UI (298.7MiB):
{code:java}
CONTAINER IDNAMECPU %
MEM USAGE / LIMIT MEM % NET I/O BLOCK I/O
PIDS
38bf46661dc9avan_zeppelin.1.ow2ckxn7pghvgk3osewrtr16j 0.09%
298.7MiB / 16GiB1.82% 2.14kB / 820B 0B / 0B
65
{code}
Memory used after first login in Zeppelin UI (5.491GiB):
{code:java}
CONTAINER IDNAMECPU %
MEM USAGE / LIMIT MEM % NET I/O BLOCK I/O
PIDS
38bf46661dc9avan_zeppelin.1.ow2ckxn7pghvgk3osewrtr16j 0.12%
5.491GiB / 16GiB34.32% 11.9kB / 40.2kB 0B / 73.7kB
{code}
Logs of first login attached (zeppelin–zeppelin.log), login phase occured
between 2020-02-13 08:23:11 and 2020-02-13 08:23:53
Reporter: Axel Van Damme
Attachments: zeppelin--zeppelin.log
Our current Notebooks base contains more than 1500 Notebooks.
While in Zeppelin 0.8.3 the solution was not ideal because all Notebooks were
loaded in memory at Zeppelin startup, the situation in Zeppelin 0.9 is worse
because loading the Notebooks is occuring at login phase. So the end user has
to wait a long long time before he is getting in Zeppelin and usually thinks
that Zeppelin is down.
Also, the solution of loading the entire Notebook base in memory is not
scalable because as new Notebooks are created we always have to increase the
ZEPPELIN_MEM environment variable.
At the moment to be able to log in Zeppelin with our 1500 Notebooks we set:
{code:java}
ZEPPELIN_MEM=-Xmx8192m -XX:MaxPermSize=1024m
{code}
This is a lot of memory that cannot be used for actual code processing.
The first logging takes 42 sec (see logs from 2020-02-13 08:23:11 to 2020-02-13
08:23:53)
Wouldn't be possible to just walk through the directory structure of the
NotebookRepo to display Zeppelin welcome page with the tree structure?
This would be a great improvement and would offer the possibility to use
Zeppelin at scale.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [zeppelin] zjffdu commented on issue #3641: [ZEPPELIN-3751]. Interpreter Binding menu of note only shows default interpreter
zjffdu commented on issue #3641: [ZEPPELIN-3751]. Interpreter Binding menu of note only shows default interpreter URL: https://github.com/apache/zeppelin/pull/3641#issuecomment-585592355 @weand The current listed interpreter are the default interpreter type you selected when creating note + interpreter with the same group of the default interpreter type and all the interpreters used in the note. e.g. you create a note with default interpreter `spark` and in your zeppelin instance there's another spark interpreter say `spark2` with other configurations, then both `spark` and `spark2` will be displayed. Does this work for you ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3639: [ZEPPELIN-4598]. upgrade-note.sh GitNotebookRepo cannot be cast to OldNotebookRepo
zjffdu commented on issue #3639: [ZEPPELIN-4598]. upgrade-note.sh GitNotebookRepo cannot be cast to OldNotebookRepo URL: https://github.com/apache/zeppelin/pull/3639#issuecomment-585597943 Someone has verified it (see jira comment). Will merge it if no more comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
