[GitHub] [zeppelin-site] dependabot[bot] opened a new pull request, #1: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web
dependabot[bot] opened a new pull request, #1: URL: https://github.com/apache/zeppelin-site/pull/1 Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. Release notes Sourced from https://github.com/SamVerschueren/decode-uri-component/releases;>decode-uri-component's releases. v0.2.2 Prevent overwriting previously decoded tokens 980e0bf https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.1...v0.2.2;>https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.1...v0.2.2 v0.2.1 Switch to GitHub workflows 76abc93 Fix issue where decode throws - fixes https://redirect.github.com/SamVerschueren/decode-uri-component/issues/6;>#6 746ca5d Update license (https://redirect.github.com/SamVerschueren/decode-uri-component/issues/1;>#1) 486d7e2 Tidelift tasks a650457 Meta tweaks 66e1c28 https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.1;>https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.1 Commits https://github.com/SamVerschueren/decode-uri-component/commit/a0eea469d26eb0df668b081672cdb9581feb78eb;>a0eea46 0.2.2 https://github.com/SamVerschueren/decode-uri-component/commit/980e0bf09b64d94f1aa79012f895816c30ffd152;>980e0bf Prevent overwriting previously decoded tokens https://github.com/SamVerschueren/decode-uri-component/commit/3c8a373dd4837e89b3f970e01295dd03e1405a33;>3c8a373 0.2.1 https://github.com/SamVerschueren/decode-uri-component/commit/76abc939783fe3900fadb7d384a74d324d5557f3;>76abc93 Switch to GitHub workflows https://github.com/SamVerschueren/decode-uri-component/commit/746ca5dcb6667c5d364e782d53c542830e4c10b9;>746ca5d Fix issue where decode throws - fixes https://redirect.github.com/SamVerschueren/decode-uri-component/issues/6;>#6 https://github.com/SamVerschueren/decode-uri-component/commit/486d7e26d3a8c0fbe860fb651fe1bc98c2f2be30;>486d7e2 Update license (https://redirect.github.com/SamVerschueren/decode-uri-component/issues/1;>#1) https://github.com/SamVerschueren/decode-uri-component/commit/a65045724e6234acef87f31da499d4807b20b134;>a650457 Tidelift tasks https://github.com/SamVerschueren/decode-uri-component/commit/66e1c2834c0e189201cb65196ec3101372459b02;>66e1c28 Meta tweaks See full diff in https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/zeppelin-site/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin-site] dependabot[bot] opened a new pull request, #2: Bump jszip from 3.1.5 to 3.10.1 in /zeppelin-web
dependabot[bot] opened a new pull request, #2: URL: https://github.com/apache/zeppelin-site/pull/2 Bumps [jszip](https://github.com/Stuk/jszip) from 3.1.5 to 3.10.1. Changelog Sourced from https://github.com/Stuk/jszip/blob/main/CHANGES.md;>jszip's changelog. v3.10.1 2022-08-02 Add sponsorship files. If you appreciate the time spent maintaining JSZip then I would really appreciate https://github.com/sponsors/Stuk;>your sponsorship. Consolidate metadata types and expose OnUpdateCallback https://redirect.github.com/Stuk/jszip/pull/851;>#851 and https://redirect.github.com/Stuk/jszip/pull/852;>#852 use const instead var in example from README.markdown https://redirect.github.com/Stuk/jszip/pull/828;>#828 Switch manual download link to HTTPS https://redirect.github.com/Stuk/jszip/pull/839;>#839 Internals: Replace jshint with eslint https://redirect.github.com/Stuk/jszip/pull/842;>#842 Add performance tests https://redirect.github.com/Stuk/jszip/pull/834;>#834 v3.10.0 2022-05-20 Change setimmediate dependency to more efficient one. Fixes https://redirect.github.com/Stuk/jszip/issues/617;>Stuk/jszip#617 (see https://redirect.github.com/Stuk/jszip/pull/829;>#829) Update types of currentFile metadata to include null (see https://redirect.github.com/Stuk/jszip/pull/826;>#826) v3.9.1 2022-04-06 Fix recursive definition of InputFileFormat introduced in 3.9.0. v3.9.0 2022-04-04 Update types JSZip#loadAsync to accept a promise for data, and remove arguments from new JSZip() (see https://redirect.github.com/Stuk/jszip/pull/752;>#752) Update types for compressionOptions to JSZipFileOptions and JSZipGeneratorOptions (see https://redirect.github.com/Stuk/jszip/pull/722;>#722) Add types for generateInternalStream (see https://redirect.github.com/Stuk/jszip/pull/774;>#774) v3.8.0 2022-03-30 Santize filenames when files are loaded with loadAsync, to avoid https://snyk.io/research/zip-slip-vulnerability;>zip slip attacks. The original filename is available on each zip entry as unsafeOriginalName. See the https://stuk.github.io/jszip/documentation/api_jszip/load_async.html;>documentation. Many thanks to McCaulay Hudson for reporting. v3.7.1 2021-08-05 Fix build of dist files. Note: this version ensures the changes from 3.7.0 are actually included in the dist files. Thanks to Evan W for reporting. v3.7.0 2021-07-23 Fix: Use a null prototype object for this.files (see https://redirect.github.com/Stuk/jszip/pull/766;>#766) This change might break existing code if it uses prototype methods on the .files property of a zip object, for example zip.files.toString(). This approach is taken to prevent files in the zip overriding object methods that would exist on a normal object. v3.6.0 2021-02-09 Fix: redirect main to dist on browsers (see https://redirect.github.com/Stuk/jszip/pull/742;>#742) Fix duplicate require DataLengthProbe, utils (see https://redirect.github.com/Stuk/jszip/pull/734;>#734) Fix small error in read_zip.md (see https://redirect.github.com/Stuk/jszip/pull/703;>#703) v3.5.0 2020-05-31 ... (truncated) Commits https://github.com/Stuk/jszip/commit/0f2f1e4d0509514417db83fe5b86bde90e0ffe8d;>0f2f1e4 3.10.1 https://github.com/Stuk/jszip/commit/cae55105f5e8bd37c270cdb76eab2cf40388dfd9;>cae5510 Updates for v3.10.1 https://github.com/Stuk/jszip/commit/179c9a0340477985b82734f1b09560411adb5b94;>179c9a0 Update changelog for 3.10.1 https://github.com/Stuk/jszip/commit/61e1df58dac54eec1e9733649638518b79896731;>61e1df5 Add Jekyll files to gitignore https://github.com/Stuk/jszip/commit/f299cce9b8d9e2be11db997919cf1777167902b7;>f299cce Merge pull request https://redirect.github.com/Stuk/jszip/issues/852;>#852 from Stuk/metadata-ts https://github.com/Stuk/jszip/commit/852887aa9483c552cd88e4eb8c298a475c0f9269;>852887a Consolidate metadata types and expose OnUpdateCallback https://github.com/Stuk/jszip/commit/5be00dfd0cc86c948420901e911e2b0fb286f19a;>5be00df Add sponsorship files https://github.com/Stuk/jszip/commit/dabe86445ce60705936ad15830c817ccb182e649;>dabe864 Update package-lock for benchmark https://github.com/Stuk/jszip/commit/cc554dae51d306fe0f188891f33e16cb6d81372d;>cc554da Merge pull request https://redirect.github.com/Stuk/jszip/issues/841;>#841 from stevennyman/patch-2 https://github.com/Stuk/jszip/commit/caefbc082d4bed536207fe473819fc91041d4f65;>caefbc0 Merge pull request https://redirect.github.com/Stuk/jszip/issues/834;>#834 from Stuk/benchmark Additional commits viewable in https://github.com/Stuk/jszip/compare/v3.1.5...v3.10.1;>compare view [![Dependabot compatibility
[GitHub] [zeppelin-site] jongyoul closed pull request #1: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web
jongyoul closed pull request #1: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web URL: https://github.com/apache/zeppelin-site/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin-site] jongyoul closed pull request #2: Bump jszip from 3.1.5 to 3.10.1 in /zeppelin-web
jongyoul closed pull request #2: Bump jszip from 3.1.5 to 3.10.1 in /zeppelin-web URL: https://github.com/apache/zeppelin-site/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1402059634 @halfvector @zenozeng @PrabhuJoseph @vineethNaroju I have updated this PR and CI is passed now. Feel free to try it to see whether it solves your problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4545: [ZEPPELIN-5861] Correct shading Prefix
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1400269014 Can someone do a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] huage1994 commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine
huage1994 commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1400410386 > @huage1994 I think we can proceed with this change. Please rebase your branch to the current master. Thanks @Reamer for reminding! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4532: [ZEPPELIN-5851][JUnit 5 Migration] Module: zeppelin-zengine
Reamer commented on PR #4532: URL: https://github.com/apache/zeppelin/pull/4532#issuecomment-1400278340 @huage1994 I think we can proceed with this change. Please rebase your branch to the current master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4545: [ZEPPELIN-5861] Correct shading Prefix
jongyoul merged PR #4545: URL: https://github.com/apache/zeppelin/pull/4545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #805: ZEPPELIN-580 Add support for multi select in form select box
jongyoul commented on PR #805: URL: https://github.com/apache/zeppelin/pull/805#issuecomment-1403144355 @ustas4 Thank you for the feedback. BTW, could you please make an issue and share it with user@, dev@, or slack channel? I would be helpful for others to understand the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4506: [ZEPPELIN-5844] Support flink 1.16
zjffdu commented on code in PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#discussion_r1086503324
##
.github/workflows/core.yml:
##
@@ -277,10 +277,10 @@ jobs:
auto-activate-base: false
use-mamba: true
- name: run tests for flink before 1.15 (exclusive)
-if: matrix.flink != '115'
-run: ./mvnw verify -pl
flink/flink-scala-2.11,flink/flink-scala-2.12,flink-cmd,zeppelin-interpreter-integration
-am -Pflink-${{ matrix.flink }} -Phadoop2 -Pintegration -DfailIfNoTests=false
-Dtest=org.apache.zeppelin.flink.*Test,FlinkIntegrationTest${{ matrix.flink }}
${MAVEN_ARGS}
- - name: run tests for flink before 1.15 (inclusive)
-if: matrix.flink == '115'
+if: matrix.flink < '115'
+run: ./mvnw verify -pl
flink/flink-scala-2.11,flink/flink-scala-2.12,flink-cmd,zeppelin-interpreter-integration
-Pflink-${{ matrix.flink }} -Phadoop2 -Pintegration -DfailIfNoTests=false -B
-Dtest=org.apache.zeppelin.flink.*Test,FlinkIntegrationTest${{ matrix.flink }}
${MAVEN_ARGS}
Review Comment:
Thanks @Reamer , I have removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4519: [ZEPPELIN-5855] Refactor docker plugin and remove powermock
jongyoul commented on code in PR #4519:
URL: https://github.com/apache/zeppelin/pull/4519#discussion_r1087820276
##
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java:
##
@@ -242,18 +233,22 @@ public void progress(ProgressMessage message) throws
DockerException {
throw new IOException(e.getMessage());
} catch (InterruptedException e) {
LOGGER.error(e.getMessage(), e);
+ // Restore interrupted state...
+ Thread.currentThread().interrupt();
throw new IOException(e.getMessage());
}
long startTime = System.currentTimeMillis();
// wait until interpreter send dockerStarted message through thrift rpc
synchronized (dockerStarted) {
- if (!dockerStarted.get()) {
+ while (!dockerStarted.get()) {
Review Comment:
It sometimes can make an infinite loop even if docker is really stable and
guarantee to return in time. How about having maximum retry or timeout like the
below code? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4519: [ZEPPELIN-5855] Refactor docker plugin and remove powermock
jongyoul commented on code in PR #4519:
URL: https://github.com/apache/zeppelin/pull/4519#discussion_r1087820276
##
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java:
##
@@ -242,18 +233,22 @@ public void progress(ProgressMessage message) throws
DockerException {
throw new IOException(e.getMessage());
} catch (InterruptedException e) {
LOGGER.error(e.getMessage(), e);
+ // Restore interrupted state...
+ Thread.currentThread().interrupt();
throw new IOException(e.getMessage());
}
long startTime = System.currentTimeMillis();
// wait until interpreter send dockerStarted message through thrift rpc
synchronized (dockerStarted) {
- if (!dockerStarted.get()) {
+ while (!dockerStarted.get()) {
Review Comment:
It sometimes can make an infinite loop even if docker is really stable and
guarantee to return in time. How about maximum retry or timeout like the below
code? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4519: [ZEPPELIN-5855] Refactor docker plugin and remove powermock
Reamer commented on code in PR #4519:
URL: https://github.com/apache/zeppelin/pull/4519#discussion_r1087924889
##
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java:
##
@@ -242,18 +233,22 @@ public void progress(ProgressMessage message) throws
DockerException {
throw new IOException(e.getMessage());
} catch (InterruptedException e) {
LOGGER.error(e.getMessage(), e);
+ // Restore interrupted state...
+ Thread.currentThread().interrupt();
throw new IOException(e.getMessage());
}
long startTime = System.currentTimeMillis();
// wait until interpreter send dockerStarted message through thrift rpc
synchronized (dockerStarted) {
- if (!dockerStarted.get()) {
+ while (!dockerStarted.get()) {
Review Comment:
Your right, I will change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4519: [ZEPPELIN-5855] Refactor docker plugin and remove powermock
Reamer commented on PR #4519: URL: https://github.com/apache/zeppelin/pull/4519#issuecomment-1404800082 I need a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4506: [ZEPPELIN-5844] Support flink 1.16
Reamer commented on code in PR #4506:
URL: https://github.com/apache/zeppelin/pull/4506#discussion_r1086434414
##
.github/workflows/core.yml:
##
@@ -277,10 +277,10 @@ jobs:
auto-activate-base: false
use-mamba: true
- name: run tests for flink before 1.15 (exclusive)
-if: matrix.flink != '115'
-run: ./mvnw verify -pl
flink/flink-scala-2.11,flink/flink-scala-2.12,flink-cmd,zeppelin-interpreter-integration
-am -Pflink-${{ matrix.flink }} -Phadoop2 -Pintegration -DfailIfNoTests=false
-Dtest=org.apache.zeppelin.flink.*Test,FlinkIntegrationTest${{ matrix.flink }}
${MAVEN_ARGS}
- - name: run tests for flink before 1.15 (inclusive)
-if: matrix.flink == '115'
+if: matrix.flink < '115'
+run: ./mvnw verify -pl
flink/flink-scala-2.11,flink/flink-scala-2.12,flink-cmd,zeppelin-interpreter-integration
-Pflink-${{ matrix.flink }} -Phadoop2 -Pintegration -DfailIfNoTests=false -B
-Dtest=org.apache.zeppelin.flink.*Test,FlinkIntegrationTest${{ matrix.flink }}
${MAVEN_ARGS}
Review Comment:
`-B` is part of `${MAVEN_ARGS} it is therefore not necessary at this point.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] zjffdu merged pull request #4506: [ZEPPELIN-5844] Support flink 1.16
zjffdu merged PR #4506: URL: https://github.com/apache/zeppelin/pull/4506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16
Reamer commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1410210938 I think we can merge this change and move forward with #4558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4567: [ZEPPELIN-5882] Upgrade Kotlin interpreter to 1.8.10
jongyoul commented on PR #4567: URL: https://github.com/apache/zeppelin/pull/4567#issuecomment-1459737471 Is it still in progress? I'm asking because it's still draft pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4525: Bump decode-uri-component from 0.2.0 to 0.2.2 in /zeppelin-web
jongyoul commented on PR #4525: URL: https://github.com/apache/zeppelin/pull/4525#issuecomment-1459740582 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] akishichinibu opened a new pull request, #4573: [ZEPPELIN-5888] Upgrade sparql version to 3.17.0
akishichinibu opened a new pull request, #4573: URL: https://github.com/apache/zeppelin/pull/4573 ### What is this PR for? Zeppelin Interpreter Support SPARQL From 3.12.0 To 3.17.0 ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5888 ### How should this be tested? * CI passed ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4573: [ZEPPELIN-5888] Upgrade sparql version to 3.17.0
akishichinibu commented on code in PR #4573: URL: https://github.com/apache/zeppelin/pull/4573#discussion_r1127450230 ## sparql/pom.xml: ## @@ -33,7 +33,7 @@ sparql -3.12.0 +3.17.0 Review Comment: The Java 11 is [required since Jena 4](https://jena.apache.org/download/index.cgi#:~:text=Jena4%20requires%20Java%2011.). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4559: [ZEPPELIN-5879] Migrate Zeppelin Plugins to JUnit5
Reamer merged PR #4559: URL: https://github.com/apache/zeppelin/pull/4559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] michaelSaid closed pull request #4574: feat [INC-58754] Incorta notebook base imp
michaelSaid closed pull request #4574: feat [INC-58754] Incorta notebook base imp URL: https://github.com/apache/zeppelin/pull/4574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4575: Bump jettison from 1.5.2 to 1.5.4
dependabot[bot] opened a new pull request, #4575: URL: https://github.com/apache/zeppelin/pull/4575 Bumps [jettison](https://github.com/jettison-json/jettison) from 1.5.2 to 1.5.4. Release notes Sourced from https://github.com/jettison-json/jettison/releases;>jettison's releases. Jettison 1.5.4 What's Changed Fixing issue 60 by https://github.com/coheigea;>@coheigea in https://redirect.github.com/jettison-json/jettison/pull/62;>jettison-json/jettison#62 Full Changelog: https://github.com/jettison-json/jettison/compare/jettison-1.5.3...jettison-1.5.4;>https://github.com/jettison-json/jettison/compare/jettison-1.5.3...jettison-1.5.4 Jettison 1.5.3 Full Changelog: https://github.com/jettison-json/jettison/compare/jettison-1.5.2...jettison-1.5.3;>https://github.com/jettison-json/jettison/compare/jettison-1.5.2...jettison-1.5.3 Commits https://github.com/jettison-json/jettison/commit/a77ffc4a70e91945603f4947828cd7d4633a3cdb;>a77ffc4 [maven-release-plugin] prepare release jettison-1.5.4 https://github.com/jettison-json/jettison/commit/c20a8be23f698d7d89b7ccf8d328971cf4709b9f;>c20a8be Fixing issue 60 https://github.com/jettison-json/jettison/commit/3e1a913eaeda4bbebc972a731330d8f697eba95c;>3e1a913 [maven-release-plugin] prepare for next development iteration https://github.com/jettison-json/jettison/commit/da6d8bc48a1f5d840ad54b3269297f6636f41f04;>da6d8bc [maven-release-plugin] prepare release jettison-1.5.3 https://github.com/jettison-json/jettison/commit/9e3ec6fe002f635c11f2d7ae5f04c722e2771406;>9e3ec6f Remove commented out code https://github.com/jettison-json/jettison/commit/b3c40001b92f5153ace0687e4ef6fb488d655d0c;>b3c4000 Adding another test for backslashes https://github.com/jettison-json/jettison/commit/631c21e9c467c310a22f5276a2ee0f1aa65359ce;>631c21e Try and fix backslash escaping. Throw syntax exception on invalid json sooner https://github.com/jettison-json/jettison/commit/d9da8084b221dfbc8752e35e006c10ca468dc9d7;>d9da808 Introducing new static methods to set the recursion depth limit https://github.com/jettison-json/jettison/commit/888eec8ea8ef97c0d01a86550589ee7c81896f45;>888eec8 Incorrect recursion depth check in JSONTokener https://github.com/jettison-json/jettison/commit/677aba586094fafbf53f7588aec6218d93933997;>677aba5 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/jettison-json/jettison/compare/jettison-1.5.2...jettison-1.5.4;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/zeppelin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] huage1994 merged pull request #4575: Bump jettison from 1.5.2 to 1.5.4
huage1994 merged PR #4575: URL: https://github.com/apache/zeppelin/pull/4575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4573: [ZEPPELIN-5888] Upgrade sparql version to 3.17.0
jongyoul commented on PR #4573: URL: https://github.com/apache/zeppelin/pull/4573#issuecomment-1458109071 BTW, is it necessary to keep this interpreter? I don't know about the detail but sometimes I feel like we should think we could maintain this interpreter continuously or not. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note
Reamer merged PR #4563: URL: https://github.com/apache/zeppelin/pull/4563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] akishichinibu opened a new pull request, #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
akishichinibu opened a new pull request, #4568: URL: https://github.com/apache/zeppelin/pull/4568 ### What is this PR for? Zeppelin Interpreter Support InfluxDB From 1.7.0 To 2.3.0 ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5883 ### How should this be tested? * CI passed ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] phongnt opened a new pull request, #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module
phongnt opened a new pull request, #4570: URL: https://github.com/apache/zeppelin/pull/4570 ### What is this PR for? Fixed maven build failed on module `zeppelin-server` with profile `hadoop3`. ### What type of PR is it? Bug Fix ### Todos * [ ] Run maven build after fixed ### What is the Jira issue? * ZEPPELIN-5881 ### How should this be tested? * Try to build module zeppelin-server by command `./mvnw -B -pl 'zeppelin-server,zeppelin-zengine,zeppelin-common,zeppelin-interpreter,zeppelin-jupyter' clean package -DskipTests -Pbuild-distr -Pinclude-hadoop -Phadoop3 -Pweb-angular` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module
Reamer commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1446266520 If no further comments are received, I will merge the PullRequest on Wednesday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] cometta commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module
cometta commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1446277819 i able to compile the master branch after your patching, but when i start python notebook example, run below cell ``` %python.ipython import sys sys? ``` i get below error, there is mismatch of python version ``` org.apache.zeppelin.interpreter.InterpreterException: org.apache.zeppelin.interpreter.InterpreterException: Fail to open JupyterKernelInterpreter: java.io.IOException: Fail to launch Jupyter Kernel as the python process is failed. Traceback (most recent call last): File "/tmp/zeppelin_jupyter_kernel_python184007101575930887/kernel_server.py", line 25, in import grpc File "/opt/conda/lib/pypy3.8/site-packages/grpc/__init__.py", line 22, in from grpc import _compression File "/opt/conda/lib/pypy3.8/site-packages/grpc/_compression.py", line 15, in from grpc._cython import cygrpc ImportError: cannot import name 'cygrpc' from 'grpc._cython' (/opt/conda/lib/pypy3.8/site-packages/grpc/_cython/__init__.py) at org.apache.zeppelin.jupyter.JupyterKernelInterpreter.launchJupyterKernel(JupyterKernelInterpreter.java:269) at org.apache.zeppelin.jupyter.JupyterKernelInterpreter.open(JupyterKernelInterpreter.java:159) at org.apache.zeppelin.python.IPythonInterpreter.open(IPythonInterpreter.java:117) at org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:70) at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:861) at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:769) at org.apache.zeppelin.scheduler.Job.run(Job.java:172) at org.apache.zeppelin.scheduler.AbstractScheduler.runJob(AbstractScheduler.java:132) at org.apache.zeppelin.scheduler.FIFOScheduler.lambda$runJobInScheduler$0(FIFOScheduler.java:42) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750) ``` can you try reproduce this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] zjffdu merged pull request #4566: [MINOR] Use flink-113 as default profile
zjffdu merged PR #4566: URL: https://github.com/apache/zeppelin/pull/4566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] canhtran opened a new pull request, #4572: [MINOR] Update doc for flink 1.16
canhtran opened a new pull request, #4572: URL: https://github.com/apache/zeppelin/pull/4572 ### What is this PR for? Update the Flink interpreter documentation to adapt with Flink 1.16 and above ### What type of PR is it? Documentation ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? * Manually tested with Flink 1.16.1 ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
akishichinibu commented on code in PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379 ## influxdb/pom.xml: ## @@ -35,8 +35,8 @@ influxdb UTF-8 -1.7.0 -3.13.1 +2.3.0 +4.7.2 Review Comment: `MockWebServer` is used in the unittests of `InfluxDBInterpeter`. The test dependency [okhttp3](https://mvnrepository.com/artifact/com.influxdb/influxdb-client-core/6.7.0#:~:text=com.squareup.okhttp3%20%C2%BB%20mockwebserver) should also be upgrade to `4.7.2` or the tests will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
akishichinibu commented on code in PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379 ## influxdb/pom.xml: ## @@ -35,8 +35,8 @@ influxdb UTF-8 -1.7.0 -3.13.1 +2.3.0 +4.7.2 Review Comment: `MockWebServer`is used in the unittests of `InfluxDBInterpeter`. The test dependency [okhttp3](https://mvnrepository.com/artifact/com.influxdb/influxdb-client-core/6.7.0#:~:text=com.squareup.okhttp3%20%C2%BB%20mockwebserver) should also be upgrade to `4.7.2` or the tests will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
akishichinibu commented on code in PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379 ## influxdb/pom.xml: ## @@ -35,8 +35,8 @@ influxdb UTF-8 -1.7.0 -3.13.1 +2.3.0 +4.7.2 Review Comment: `MockWebServer` is used in the unit test of `InfluxDBInterpeter`. The test dependency [okhttp3](https://mvnrepository.com/artifact/com.influxdb/influxdb-client-core/6.7.0#:~:text=com.squareup.okhttp3%20%C2%BB%20mockwebserver) should also be upgrade to `4.7.2` or the tests will fail. ## influxdb/pom.xml: ## @@ -35,8 +35,8 @@ influxdb UTF-8 -1.7.0 -3.13.1 +2.3.0 +4.7.2 Review Comment: `MockWebServer` is used in the unit test of `InfluxDBInterpeter`. The test dependency [okhttp3](https://mvnrepository.com/artifact/com.influxdb/influxdb-client-core/6.7.0#:~:text=com.squareup.okhttp3%20%C2%BB%20mockwebserver) should also be upgraded to `4.7.2` or the tests will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
akishichinibu commented on code in PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379 ## influxdb/pom.xml: ## @@ -35,8 +35,8 @@ influxdb UTF-8 -1.7.0 -3.13.1 +2.3.0 +4.7.2 Review Comment: The test dependency [okhttp3](https://mvnrepository.com/artifact/com.squareup.okhttp3/mockwebserver) should also be upgrade to `4.7.2` or the tests will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
akishichinibu commented on code in PR #4568: URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379 ## influxdb/pom.xml: ## @@ -35,8 +35,8 @@ influxdb UTF-8 -1.7.0 -3.13.1 +2.3.0 +4.7.2 Review Comment: The test dependency [okhttp3](https://mvnrepository.com/artifact/com.influxdb/influxdb-client-core/6.7.0#:~:text=com.squareup.okhttp3%20%C2%BB%20mockwebserver) should also be upgrade to `4.7.2` or the tests will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] phongnt commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module
phongnt commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1447567707 @cometta I think Maven command in Dockerfile is not official for distribute docker image. I tried to start Zeppelin in docker by `docker run -p 8080:8080 --rm --name zeppelin apache/zeppelin:0.10.0` And there is no issue with Python Interpreter: https://user-images.githubusercontent.com/759326/221755907-a524f542-6d08-4805-a272-89195c5c0670.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4559: [ZEPPELIN-5879] Migrate Zeppelin Plugins to JUnit5
huage1994 commented on code in PR #4559: URL: https://github.com/apache/zeppelin/pull/4559#discussion_r1122608228 ## zeppelin-plugins/notebookrepo/s3/pom.xml: ## @@ -109,15 +131,11 @@ javax.xml.bind jaxb-api - + com.fasterxml.jackson.core jackson-core - -com.fasterxml.jackson.dataformat -jackson-dataformat-xml - - + Review Comment: Everything is good except the indentation is misaligned in three places ## zeppelin-plugins/notebookrepo/s3/pom.xml: ## @@ -129,14 +147,22 @@ com.fasterxml.jackson.core jackson-databind - + Review Comment: ```suggestion ``` ## zeppelin-plugins/notebookrepo/s3/pom.xml: ## @@ -109,15 +131,11 @@ javax.xml.bind jaxb-api - + Review Comment: ```suggestion ``` ## zeppelin-plugins/notebookrepo/s3/pom.xml: ## @@ -109,15 +131,11 @@ javax.xml.bind jaxb-api - + com.fasterxml.jackson.core jackson-core - -com.fasterxml.jackson.dataformat -jackson-dataformat-xml - - + Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies
jongyoul commented on PR #4458: URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1433126434 Long time no see. I think you'd better rebase this branch, not mering current master :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] proceane commented on pull request #4458: [ZEPPELIN-5812] Add spring-boot-dependencies
proceane commented on PR #4458: URL: https://github.com/apache/zeppelin/pull/4458#issuecomment-1433197598 oh... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1432962218 Thanks @canhtran for the feedback, https://github.com/apache/zeppelin/pull/4558 indeed cause this issue. The workaround is using `mvn clean package -DskipTests -Pflink-113` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] zjffdu opened a new pull request, #4566: [MINOR] Use flink-113 as default profile
zjffdu opened a new pull request, #4566: URL: https://github.com/apache/zeppelin/pull/4566 ### What is this PR for? A trivial PR to use flink-113 as default profile, so that user don't need to specify profile to build flink-interpreter modules. Otherwise the following command won't build flink-interpreter module. ``` mvn clean package -DskipTests ``` ### What type of PR is it? Hot Fix ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? * Manually tested ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] canhtran commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16
canhtran commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1432832112 It seems like the issue starting from #4558 I built the zeppelin at commit `f30ea77accc921db3f06aadd5675f71140bc6da2` and it's fine https://user-images.githubusercontent.com/3214379/219334347-08ed0407-fdc6-4f1e-99da-15cbefa7c5ed.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] ottok92 commented on pull request #4565: Reflect ZEPPELIN-5352 changes in docs
ottok92 commented on PR #4565: URL: https://github.com/apache/zeppelin/pull/4565#issuecomment-1435643769 @zjffdu it seems this [zeppelin-server.yaml](https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml) is particularly setup for Spark. I tried defining `ZEPPELIN_FLINK_APPLICATION_MODE: kubernetes-application` and embedding Flink in `zeppelin-interpreter` image under `/opt/flink` as suggested [here](https://github.com/apache/zeppelin/pull/3884/files#r473114030). So far, I haven't had luck making it work. For sanity, I ran the quickstart steps for Zeppelin on Spark on k8s and that works fine. Could you perhaps share some tips to reproduce your testing of this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4569: [ZEPPELIN-5884] fix: wrong path of test folder in Java Interpreter
Reamer commented on PR #4569: URL: https://github.com/apache/zeppelin/pull/4569#issuecomment-1443236925 The tests run through, but without log output. In my opinion, this can be omitted at the moment. How do you see it? ``` 2023-02-24T08:53:44.5652238Z [INFO] --- 2023-02-24T08:53:44.5652658Z [INFO] T E S T S 2023-02-24T08:53:44.5653098Z [INFO] --- 2023-02-24T08:53:45.0138413Z [INFO] Running org.apache.zeppelin.java.JavaInterpreterUtilsTest 2023-02-24T08:53:45.5101854Z [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.495 s - in org.apache.zeppelin.java.JavaInterpreterUtilsTest 2023-02-24T08:53:45.5108854Z [INFO] Running org.apache.zeppelin.java.JavaInterpreterTest 2023-02-24T08:53:45.6120582Z log4j:WARN No appenders could be found for logger (org.apache.zeppelin.java.StaticRepl). 2023-02-24T08:53:45.6121148Z log4j:WARN Please initialize the log4j system properly. 2023-02-24T08:53:45.6121610Z log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. 2023-02-24T08:53:45.6155493Z [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.103 s - in org.apache.zeppelin.java.JavaInterpreterTest 2023-02-24T08:53:45.9381040Z [INFO] 2023-02-24T08:53:45.9381487Z [INFO] Results: 2023-02-24T08:53:45.9381784Z [INFO] 2023-02-24T08:53:45.9383174Z [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4563: Solve the concurrency clone note
Reamer commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1441617178 Please open a JIRA ticket. A stack trace of the error would be good in the ticket. It would also be good if you use the pull request template. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] tranvanthai opened a new pull request, #4569: [ZEPPELIN-5884] fix: wrong path of test folder in Java Interpreter
tranvanthai opened a new pull request, #4569: URL: https://github.com/apache/zeppelin/pull/4569 ### What is this PR for? Currently, the path of the test folder in the Java Interpreter module was wrong. I open this PR to correct it. ### What type of PR is it? Improvement ### Todos * [ ] - Move the test folder of Java Interpreter to the correct path ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-5884 ### How should this be tested? * Check the test was run ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4569: [ZEPPELIN-5884] fix: wrong path of test folder in Java Interpreter
Reamer merged PR #4569: URL: https://github.com/apache/zeppelin/pull/4569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] cometta commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module
cometta commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1448202540 i use the master branch to build the docker image. below is python interpreter setting, it is the default one  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] cometta commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module
cometta commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1447899439 @phongnt , sorry you confused with number of questions i asked. for this issue, only happen in master branch of the repo, not older version of Zeppelin. To see this issue, you need to rebuild the master branch for spark 3.3 and then run the python cell i mentioned -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] phongnt commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module
phongnt commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1447926387 @cometta Base on your error message, I think your Python Interpreter have problem as your installed Python package on your server (k8s). Could you please share your Python Interpreter setting. And how do you install Python 3.8 and which packages do you installed? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4559: [ZEPPELIN-5879] Migrate Zeppelin Plugins to JUnit5
Reamer commented on PR #4559: URL: https://github.com/apache/zeppelin/pull/4559#issuecomment-1449891496 > I just have a very small question about this: I noticed that you removed the `public` modifier from the `@Test` method but retain the `public` modifier for methods that are decorated by `@BeforEeach` . > > Is there any special purpose in this? There is no deeper meaning. My IDE runs the sonarlint plugin, this plugin gives me a little hint to remove the public modifier. https://rules.sonarsource.com/java/RSPEC-5786 Unfortunately the hint is missing for @BeforeEach and other methods, so I overlooked deleting the modifier at this point. I will go back through the test classes and remove the visibility. JUnit5 recommends removing the public modifier. https://junit.org/junit5/docs/current/user-guide/#writing-tests-classes-and-methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module
Reamer merged PR #4570: URL: https://github.com/apache/zeppelin/pull/4570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] canhtran commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16
canhtran commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451342014 Thanks @PrabhuJoseph. It works by copying the `flink-sql-client-1.16.jar` to `lib` folder. The documentation missed this step, I will raise a PR for it. Thanks again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] canhtran commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16
canhtran commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451248958 I'm also facing the below issue while testing the zeppelin with flink 1.16. I guess we need to modify/copy the libraries in flink to resolve it but haven't figured it out. ``` org.apache.zeppelin.interpreter.InterpreterException: java.lang.NoClassDefFoundError: org/apache/flink/table/client/util/ClientWrapperClassLoader at org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:76) at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:861) at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:769) at org.apache.zeppelin.scheduler.Job.run(Job.java:172) at org.apache.zeppelin.scheduler.AbstractScheduler.runJob(AbstractScheduler.java:132) at org.apache.zeppelin.scheduler.FIFOScheduler.lambda$runJobInScheduler$0(FIFOScheduler.java:42) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.NoClassDefFoundError: org/apache/flink/table/client/util/ClientWrapperClassLoader at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:264) at org.apache.zeppelin.flink.FlinkShims.loadShims(FlinkShims.java:68) at org.apache.zeppelin.flink.FlinkShims.getInstance(FlinkShims.java:86) at org.apache.zeppelin.flink.FlinkScalaInterpreter.initFlinkConfig(FlinkScalaInterpreter.scala:158) at org.apache.zeppelin.flink.FlinkScalaInterpreter.open(FlinkScalaInterpreter.scala:122) at org.apache.zeppelin.flink.FlinkInterpreter.open(FlinkInterpreter.java:71) at org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:70) ... 8 more Caused by: java.lang.ClassNotFoundException: org.apache.flink.table.client.util.ClientWrapperClassLoader at java.net.URLClassLoader.findClass(URLClassLoader.java:382) at java.lang.ClassLoader.loadClass(ClassLoader.java:418) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352) at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ... 16 more ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] PrabhuJoseph commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16
PrabhuJoseph commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451314800 > I'm also facing the below issue while testing the zeppelin with flink 1.16. I guess we need to modify/copy the libraries in flink to resolve it but haven't figured it out. I think this happens as Flink Sql Client Jar is not part of Zeppelin Flink Interpreter Classpath. Could you test after copying /usr/lib/flink/opt/flink-sql-client-1.16.jar into either Flink Lib /usr/lib/flink/lib or Zeppelin Flink Interpreter Classpath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] bigjar commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16
bigjar commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1451139614 Hi, @zjffdu. when I use flink.udf.jars, I found two problems. One is it can not find the org.apache.zeppelin.shaded.com.google.common.io.Files, because the #4545 had change the shaded prefix. Another is the variable userJars should be transfrom to the file before transform to the URL when it used in createTableEnvs functions in the FlinkScalaInterpreter line 434. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] huage1994 commented on pull request #4559: [ZEPPELIN-5879] Migrate Zeppelin Plugins to JUnit5
huage1994 commented on PR #4559: URL: https://github.com/apache/zeppelin/pull/4559#issuecomment-1449293326 Hi @Reamer , this PR is a great job. It all looks good to me. I just have a very small question about this: I noticed that you removed the `public` modifier from the `@Test` method but retain the `public` modifier for methods that are decorated by `@BeforEeach` . Is there any special purpose in this? I've tried to remove `public` modifier for `@BeforEeach` methods , it looks ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4571: Bump minimist, mkdirp, karma, handlebars and protractor in /zeppelin-web-angular
dependabot[bot] opened a new pull request, #4571: URL: https://github.com/apache/zeppelin/pull/4571 Bumps [minimist](https://github.com/minimistjs/minimist) to 1.2.8 and updates ancestor dependencies [minimist](https://github.com/minimistjs/minimist), [mkdirp](https://github.com/isaacs/node-mkdirp), [karma](https://github.com/karma-runner/karma), [handlebars](https://github.com/wycats/handlebars.js) and [protractor](https://github.com/angular/protractor). These dependencies need to be updated together. Updates `minimist` from 1.2.0 to 1.2.8 Changelog Sourced from https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md;>minimist's changelog. https://github.com/minimistjs/minimist/compare/v1.2.7...v1.2.8;>v1.2.8 - 2023-02-09 Merged [Fix] Fix long option followed by single dash https://github-redirect.dependabot.com/minimistjs/minimist/pull/17;>[#17](https://github.com/minimistjs/minimist/issues/17) [Tests] Remove duplicate test https://github-redirect.dependabot.com/minimistjs/minimist/pull/12;>[#12](https://github.com/minimistjs/minimist/issues/12) [Fix] opt.string works with multiple aliases https://github-redirect.dependabot.com/minimistjs/minimist/pull/10;>[#10](https://github.com/minimistjs/minimist/issues/10) Fixed [Fix] Fix long option followed by single dash (https://github-redirect.dependabot.com/minimistjs/minimist/issues/17;>#17) https://github-redirect.dependabot.com/minimistjs/minimist/issues/15;>[#15](https://github.com/minimistjs/minimist/issues/15) [Tests] Remove duplicate test (https://github-redirect.dependabot.com/minimistjs/minimist/issues/12;>#12) https://github-redirect.dependabot.com/minimistjs/minimist/issues/8;>[#8](https://github.com/minimistjs/minimist/issues/8) [Fix] Fix long option followed by single dash https://github-redirect.dependabot.com/minimistjs/minimist/issues/15;>[#15](https://github.com/minimistjs/minimist/issues/15) [Fix] opt.string works with multiple aliases (https://github-redirect.dependabot.com/minimistjs/minimist/issues/10;>#10) https://github-redirect.dependabot.com/minimistjs/minimist/issues/9;>[#9](https://github.com/minimistjs/minimist/issues/9) [Fix] Fix handling of short option with non-trivial equals https://github-redirect.dependabot.com/minimistjs/minimist/issues/5;>[#5](https://github.com/minimistjs/minimist/issues/5) [Tests] Remove duplicate test https://github-redirect.dependabot.com/minimistjs/minimist/issues/8;>[#8](https://github.com/minimistjs/minimist/issues/8) [Fix] opt.string works with multiple aliases https://github-redirect.dependabot.com/minimistjs/minimist/issues/9;>[#9](https://github.com/minimistjs/minimist/issues/9) Commits Merge tag 'v0.2.3' https://github.com/minimistjs/minimist/commit/a0267947c7870fc5847cf2d437fbe33f392767da;>a026794 [eslint] fix indentation and whitespace https://github.com/minimistjs/minimist/commit/5368ca4147e974138a54cc0dc4cea8f756546b70;>5368ca4 [eslint] fix indentation and whitespace https://github.com/minimistjs/minimist/commit/e5f5067259ceeaf0b098d14bec910f87e58708c7;>e5f5067 [eslint] more cleanup https://github.com/minimistjs/minimist/commit/62fde7d935f83417fb046741531a9e2346a36976;>62fde7d [eslint] more cleanup https://github.com/minimistjs/minimist/commit/36ac5d0d95e4947d074e5737d94814034ca335d1;>36ac5d0 [meta] add auto-changelog https://github.com/minimistjs/minimist/commit/73923d223553fca08b1ba77e3fbc2a492862ae4c;>73923d2 [actions] add reusable workflows https://github.com/minimistjs/minimist/commit/d80727df77bfa9e631044d7f16368d8f09242c91;>d80727d [eslint] add eslint; rules to enable later are warnings https://github.com/minimistjs/minimist/commit/48bc06a1b41f00e9cdf183db34f7a51ba70e98d4;>48bc06a [eslint] fix indentation https://github.com/minimistjs/minimist/commit/34b0f1ccaa45183c3c4f06a91f9b405180a6f982;>34b0f1c [readme] rename and add badges https://github.com/minimistjs/minimist/commit/5df0fe49211bd09a3636f8686a7cb3012c3e98f0;>5df0fe4 [Dev Deps] switch from covert to nyc https://github.com/minimistjs/minimist/commit/a48b128fdb8d427dfb20a15273f83e38d97bef07;>a48b128 [Dev Deps] update covert, tape; remove unnecessary tap https://github.com/minimistjs/minimist/commit/f0fb958e9a1fe980cdffc436a211b0bda58f621b;>f0fb958 [meta] create FUNDING.yml; add funding in package.json https://github.com/minimistjs/minimist/commit/3639e0c819359a366387e425ab6eabf4c78d3caa;>3639e0c [meta] use npmignore to autogenerate an npmignore file https://github.com/minimistjs/minimist/commit/be2e038c342d8333b32f0fde67a0026b79c8150e;>be2e038 Only apps should have lockfiles https://github.com/minimistjs/minimist/commit/282b570e7489d01b03f2d6d3dabf79cd3e5f84cf;>282b570 isConstructorOrProto adapted from PR https://github.com/minimistjs/minimist/commit/ef9153fc52b6cea0744b2239921c5dcae4697f11;>ef9153f [Dev Deps] update @ljharb/eslint-config, aud
[GitHub] [zeppelin] kkalyan commented on a diff in pull request #3496: [ZEPPELIN-4407] Add the ability to copy/paste result table
kkalyan commented on code in PR #3496: URL: https://github.com/apache/zeppelin/pull/3496#discussion_r1117828333 ## zeppelin-web/src/app/notebook/paragraph/result/result-chart-selector.html: ## @@ -88,8 +88,10 @@ Toggle Dropdown -CSV -TSV +Copy as TSV +Copy as CSV +Download as TCV Review Comment: TSV ## zeppelin-web/src/app/notebook/paragraph/result/result-chart-selector.html: ## @@ -88,8 +88,10 @@ Toggle Dropdown -CSV -TSV +Copy as TSV +Copy as CSV +Download as TCV Review Comment: TCV --> TSV -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] qinbo12 commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note
qinbo12 commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1449392398 > Please open a JIRA ticket. A stack trace of the error would be good in the ticket. It would also be good if you use the pull request template. Hello, I have JIRA sheet and provided test case and stack information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on pull request #4567: [ZEPPELIN-5882] Upgrade Kotlin interpreter to 1.8.10
akishichinibu commented on PR #4567: URL: https://github.com/apache/zeppelin/pull/4567#issuecomment-1449427666 Hi @dkaznacheev, I’m trying to upgrade the Kotlin version to 1.8.10 in the Kotlin interpreter, but I found that there’s a great change in the compiler API since 1.4. Could you please provide some references or documents to help me start on this task. It would be very helpful. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] cometta commented on pull request #4570: [ZEPPELIN-5881] Missing dependency when package zeppelin-server module
cometta commented on PR #4570: URL: https://github.com/apache/zeppelin/pull/4570#issuecomment-1449479976 i retest again, the python error no longer occurs after i clear the browser cache. issue resolved. just take note that to use spark 3.3, on pom.xml , change the line 3.3.2 when using spark 3.3.0 . can proceed to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] akishichinibu opened a new pull request, #4567: [ZEPPELIN-5882] Upgrade Kotlin interpreter to 1.8.10
akishichinibu opened a new pull request, #4567: URL: https://github.com/apache/zeppelin/pull/4567 ### What is this PR for? Zeppelin Interpreter Support Kotlin From 1.3.50 To 1.8.10 ### What type of PR is it? Improvement ### Todos * [x] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-5882 ### How should this be tested? CI passed ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4580: [ZEPPELIN-5855] remove more powermock usages to support junit5
jongyoul commented on code in PR #4580:
URL: https://github.com/apache/zeppelin/pull/4580#discussion_r1164411099
##
zeppelin-server/src/test/java/org/apache/zeppelin/service/shiro/AbstractShiroTest.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zeppelin.service.shiro;
+
+import org.apache.shiro.SecurityUtils;
+import org.apache.shiro.UnavailableSecurityManagerException;
+import org.apache.shiro.mgt.SecurityManager;
+import org.apache.shiro.subject.Subject;
+import org.apache.shiro.subject.support.SubjectThreadState;
+import org.apache.shiro.util.LifecycleUtils;
+import org.apache.shiro.util.ThreadState;
+import org.junit.AfterClass;
+
+/**
+ * Abstract test case enabling Shiro in test environments.
+ * Copy from https://shiro.apache.org/testing.html
+ */
+public abstract class AbstractShiroTest {
+
+ private static ThreadState subjectThreadState;
+
+ public AbstractShiroTest() {
+ }
+
+ /**
+ * Allows subclasses to set the currently executing {@link Subject} instance.
+ *
+ * @param subject the Subject instance
+ */
+ protected void setSubject(Subject subject) {
+clearSubject();
+subjectThreadState = createThreadState(subject);
+subjectThreadState.bind();
+ }
+
+ protected Subject getSubject() {
+return SecurityUtils.getSubject();
+ }
+
+ protected ThreadState createThreadState(Subject subject) {
+return new SubjectThreadState(subject);
+ }
+
+ /**
+ * Clears Shiro's thread state, ensuring the thread remains clean for future
test execution.
+ */
+ protected void clearSubject() {
+doClearSubject();
+ }
+
+ private static void doClearSubject() {
+if (subjectThreadState != null) {
+ subjectThreadState.clear();
+ subjectThreadState = null;
+}
+ }
+
+ protected static void setSecurityManager(SecurityManager securityManager) {
+SecurityUtils.setSecurityManager(securityManager);
+ }
+
+ protected static SecurityManager getSecurityManager() {
+return SecurityUtils.getSecurityManager();
+ }
+
+ @AfterClass
+ public static void tearDownShiro() {
+doClearSubject();
+try {
+ SecurityManager securityManager = getSecurityManager();
+ LifecycleUtils.destroy(securityManager);
+} catch (UnavailableSecurityManagerException e) {
+ // we don't care about this when cleaning up the test environment
+ // (for example, maybe the subclass is a unit test and it didn't
+ // need a SecurityManager instance because it was using only
+ // mock Subject instances)
+}
+setSecurityManager(null);
+ }
+}
Review Comment:
nit: add a new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4580: [ZEPPELIN-5855] remove more powermock usages to support junit5
jongyoul commented on code in PR #4580:
URL: https://github.com/apache/zeppelin/pull/4580#discussion_r1164412779
##
zeppelin-server/src/test/java/org/apache/zeppelin/service/shiro/AbstractShiroTest.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zeppelin.service.shiro;
+
+import org.apache.shiro.SecurityUtils;
+import org.apache.shiro.UnavailableSecurityManagerException;
+import org.apache.shiro.mgt.SecurityManager;
+import org.apache.shiro.subject.Subject;
+import org.apache.shiro.subject.support.SubjectThreadState;
+import org.apache.shiro.util.LifecycleUtils;
+import org.apache.shiro.util.ThreadState;
+import org.junit.AfterClass;
+
+/**
+ * Abstract test case enabling Shiro in test environments.
+ * Copy from https://shiro.apache.org/testing.html
+ */
+public abstract class AbstractShiroTest {
+
+ private static ThreadState subjectThreadState;
+
+ public AbstractShiroTest() {
+ }
+
+ /**
+ * Allows subclasses to set the currently executing {@link Subject} instance.
+ *
+ * @param subject the Subject instance
+ */
+ protected void setSubject(Subject subject) {
+clearSubject();
+subjectThreadState = createThreadState(subject);
+subjectThreadState.bind();
+ }
+
+ protected Subject getSubject() {
+return SecurityUtils.getSubject();
+ }
+
+ protected ThreadState createThreadState(Subject subject) {
+return new SubjectThreadState(subject);
+ }
+
+ /**
+ * Clears Shiro's thread state, ensuring the thread remains clean for future
test execution.
+ */
+ protected void clearSubject() {
+doClearSubject();
+ }
+
+ private static void doClearSubject() {
+if (subjectThreadState != null) {
+ subjectThreadState.clear();
+ subjectThreadState = null;
+}
+ }
+
+ protected static void setSecurityManager(SecurityManager securityManager) {
+SecurityUtils.setSecurityManager(securityManager);
+ }
+
+ protected static SecurityManager getSecurityManager() {
+return SecurityUtils.getSecurityManager();
+ }
+
+ @AfterClass
+ public static void tearDownShiro() {
+doClearSubject();
+try {
+ SecurityManager securityManager = getSecurityManager();
+ LifecycleUtils.destroy(securityManager);
+} catch (UnavailableSecurityManagerException e) {
+ // we don't care about this when cleaning up the test environment
+ // (for example, maybe the subclass is a unit test and it didn't
+ // need a SecurityManager instance because it was using only
+ // mock Subject instances)
+}
+setSecurityManager(null);
+ }
+}
Review Comment:
```suggestion
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4580: [ZEPPELIN-5855] remove more powermock usages to support junit5
Reamer merged PR #4580: URL: https://github.com/apache/zeppelin/pull/4580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] grizzly-monkey opened a new pull request, #4581: Sanitize user labels for k8s
grizzly-monkey opened a new pull request, #4581: URL: https://github.com/apache/zeppelin/pull/4581 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. K8S labels has specific requirement to name labels which can be found here https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set if Using external auth like Shiro with OIDC or JWT where principal is name / or username or email it can have special chars which then does not allow pod to launch. ``` io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: POST at: https://172.20.0.1/api/v1/namespaces/dbdwf06018702/pods. Message: Pod "jdbc-nrgtbo" is invalid: metadata.labels: Invalid value: "Firstname Lastname": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character ... ``` ### What type of PR is it? Bug Fix ### What is the Jira issue? * NA ### How should this be tested? * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Questions: * Does the license files need to update? -NO * Is there breaking changes for older versions? -NO * Does this needs documentation? - NO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4581: Sanitize user labels for k8s
Reamer commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1517384284 Hello @grizzly-monkey, thanks for your Pull Request. We already have a sanitize method. Have a look at `K8sUtils:generateK8sName`. Please use this method or adapt the method to your needs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173957427
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java:
##
@@ -133,21 +134,14 @@ protected void runJob(Job runningJob) {
Object jobResult = runningJob.getReturn();
synchronized (runningJob) {
if (runningJob.isAborted()) {
+LOGGER.info("Job Aborted, {}, {}", runningJob.getId(),
runningJob.getErrorMessage());
runningJob.setStatus(Job.Status.ABORT);
Review Comment:
Here I have merely cleaned up. There should be no change in function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173974707
##
zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java:
##
@@ -82,10 +88,11 @@ public void runJobInScheduler(Job job) {
* RUNNING status. This thread will exist after job is in RUNNING/FINISHED
state.
*/
private class JobStatusPoller extends Thread {
Review Comment:
In the following, the interrupt behaviour of the StatusPoller has been
improved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173962995
##
zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java:
##
@@ -34,14 +36,14 @@
public class RemoteScheduler extends AbstractScheduler {
private static final Logger LOGGER =
LoggerFactory.getLogger(RemoteScheduler.class);
- private RemoteInterpreter remoteInterpreter;
- private ExecutorService executor;
+ private final RemoteInterpreter remoteInterpreter;
+ private final ExecutorService executor;
public RemoteScheduler(String name,
- ExecutorService executor,
RemoteInterpreter remoteInterpreter) {
super(name);
-this.executor = executor;
+this.executor =
Review Comment:
The RemoteScheduler creates its own executor. There is now one FIFO executor
per RemoteScheduler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173959970
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/Job.java:
##
@@ -70,6 +70,14 @@ public boolean isPending() {
public boolean isCompleted() {
return this == FINISHED || this == ERROR || this == ABORT;
}
+
Review Comment:
I found these methods very useful when debugging the problem, but they are
no longer in use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173980444
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java:
##
@@ -89,11 +89,14 @@ public void run() {
runningJob = queue.take();
} catch (InterruptedException e) {
LOGGER.warn("{} is interrupted", getClass().getSimpleName());
+// Restore interrupted state...
+Thread.currentThread().interrupt();
break;
}
runJobInScheduler(runningJob);
}
+stop();
Review Comment:
When we stop the RemoteScheduler we should set all jobs in the queue to
abort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1518056388 As this PR changes a very important component of Zeppelin, I need an accurate review. If you want me to describe the changes in more detail, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173955767
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java:
##
@@ -89,6 +89,7 @@ public void run() {
runningJob = queue.take();
} catch (InterruptedException e) {
LOGGER.warn("{} is interrupted", getClass().getSimpleName());
+stop();
Review Comment:
stop is needed to abort all jobs when the scheduler is shut down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Samrat002 closed pull request #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter
Samrat002 closed pull request #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter URL: https://github.com/apache/zeppelin/pull/4584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173955767
##
zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/AbstractScheduler.java:
##
@@ -89,6 +89,7 @@ public void run() {
runningJob = queue.take();
} catch (InterruptedException e) {
LOGGER.warn("{} is interrupted", getClass().getSimpleName());
+stop();
Review Comment:
`stop` is needed to abort all jobs when the scheduler is shut down. The
`stop` method also sets the interrupt flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173972774
##
zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java:
##
@@ -53,22 +55,26 @@ public void runJobInScheduler(Job job) {
remoteInterpreter.getProperty(".execution.mode", "paragraph");
if (executionMode.equals("paragraph")) {
// wait until it is submitted to the remote
- while (!jobRunner.isJobSubmittedInRemote()) {
+ while (!jobRunner.isJobSubmittedInRemote() &&
!Thread.currentThread().isInterrupted()) {
Review Comment:
The RemoteScheduler waits until the note or paragraph is executed on the
remote interpreter.
If an interrupt should occur, it is now reacted to and aborted accordingly.
The executor of the RemoteScheduler receives the request to terminate itself
through the `stop` in the AbstractScheduler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Samrat002 opened a new pull request, #4584: [ZEPPELIN-5894] Support Flink 1.17.0 for zeppelin interpreter
Samrat002 opened a new pull request, #4584: URL: https://github.com/apache/zeppelin/pull/4584 ### What is this PR for? - It introduces new flink 1.17.0 interpreter support in zeppelin. - Flink-1.17 is [released](https://flink.apache.org/2023/03/23/announcing-the-release-of-apache-flink-1.17/). ### What type of PR is it? Feature ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-5894 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? yes * Is there breaking changes for older versions? no * Does this needs documentation? yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1173961893
##
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:
##
@@ -342,17 +341,14 @@ public Scheduler getScheduler() {
// running under the scheduler of this session will be aborted.
String executionMode = getProperty(".execution.mode", "paragraph");
if (executionMode.equals("paragraph")) {
- Scheduler s = new RemoteScheduler(
- RemoteInterpreter.class.getSimpleName() + "-" +
getInterpreterGroup().getId() + "-" + sessionId,
- SchedulerFactory.singleton().getExecutor(),
Review Comment:
The main change in this PR. Before, the RemoteScheduler got the
SchedulerFactory executor as its own executor. This has now been switched off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4579: [ZEPPELIN-5893] Dev zeppelin client bug
zjffdu commented on PR #4579: URL: https://github.com/apache/zeppelin/pull/4579#issuecomment-1518472971 @xiaomin0322 Could you update the jira title to be more specific? `Dev zeppelin client bug` is too vague. Something like `NPE in ParagraphResult when getting progress from paragraphJson` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4585: Bump spark-core_2.12 from 3.1.2 to 3.4.0 in /spark/interpreter
dependabot[bot] opened a new pull request, #4585: URL: https://github.com/apache/zeppelin/pull/4585 Bumps spark-core_2.12 from 3.1.2 to 3.4.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/zeppelin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] grizzly-monkey commented on pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails
grizzly-monkey commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1520648767 when does it get merged ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] dependabot[bot] opened a new pull request, #4587: Bump xlsx from 0.14.5 to 0.18.5 in /zeppelin-web-angular
dependabot[bot] opened a new pull request, #4587: URL: https://github.com/apache/zeppelin/pull/4587 Bumps [xlsx](https://github.com/SheetJS/sheetjs) from 0.14.5 to 0.18.5. Changelog Sourced from https://github.com/SheetJS/sheetjs/blob/github/CHANGELOG.md;>xlsx's changelog. v0.18.5 Enabled sideEffects: false in package.json Basic NUMBERS write support v0.18.4 CSV output omits trailing record separator Properly terminate NodeJS Streams DBF preserve column types on import and use when applicable on export v0.18.3 Removed references to require and process in browser builds v0.18.2 Hotfix for unicode processing of XLSX exports v0.18.1 Removed Node ESM build script and folded into standard ESM build Removed undocumented aliases including make_formulae and get_formulae v0.18.0 Browser scripts only expose XLSX variable Module no longer ships with dist/jszip.js browser script v0.17.4 CLI script moved to xlsx-cli package v0.17.3 window.XLSX explicit assignment to satiate LWC CSV Proper formatting of errors HTML emit data-* attributes v0.17.2 Browser and Node optional ESM support DSV correct handling of bare quotes (h/t https://github.com/bgamrat;>@bgamrat) v0.17.1 XLSB writer uses short cell form when viable 0.17.0: ... (truncated) Commits See full diff in https://github.com/SheetJS/sheetjs/commits/v0.18.5;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/zeppelin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails
Reamer commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1521210881 > when does it get merged ? When all tests have been successfully completed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1521223455 > BTW it's weird that the `RemoteSchedulerTest` used to runs fine on Junit 4, Do you know why? Unfortunately no. However, since only the timing matters due to the six threads involved, JUnit-5 may have improved things here. But perhaps the CI-VM is so slow that the error occurs less frequently there. However, I have seen the error several times under JUnit 4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error
Reamer commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1524855876 Still > Thanks for the contribution @zhugezifang , could you update the PR description? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails
Reamer commented on code in PR #4581:
URL: https://github.com/apache/zeppelin/pull/4581#discussion_r1178681796
##
zeppelin-plugins/launcher/k8s-standard/src/test/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcessTest.java:
##
@@ -123,7 +123,7 @@ void testGetTemplateBindings() {
assertEquals("12321:12321" ,
p.get("zeppelin.k8s.interpreter.rpc.portRange"));
assertEquals("zeppelin.server.service" ,
p.get("zeppelin.k8s.server.rpc.service"));
assertEquals(12320 , p.get("zeppelin.k8s.server.rpc.portRange"));
-assertEquals("null", p.get("zeppelin.k8s.interpreter.user"));
+assertEquals("zeppelin", p.get("zeppelin.k8s.interpreter.user"));
Review Comment:
This value is not good. If no user is specified, the value should still be
"null". It would be better if the property is not set for an empty user at all
and the Jinja2 template does not render the user. Can you change the behaviour
like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails
Reamer commented on code in PR #4581:
URL: https://github.com/apache/zeppelin/pull/4581#discussion_r1178683279
##
zeppelin-plugins/launcher/k8s-standard/src/test/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcessTest.java:
##
@@ -123,7 +123,7 @@ void testGetTemplateBindings() {
assertEquals("12321:12321" ,
p.get("zeppelin.k8s.interpreter.rpc.portRange"));
assertEquals("zeppelin.server.service" ,
p.get("zeppelin.k8s.server.rpc.service"));
assertEquals(12320 , p.get("zeppelin.k8s.server.rpc.portRange"));
-assertEquals("null", p.get("zeppelin.k8s.interpreter.user"));
+assertEquals("zeppelin", p.get("zeppelin.k8s.interpreter.user"));
Review Comment:
I didn't programme cleanly when introducing the user in the template, sorry
about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] Reamer opened a new pull request, #4590: [ZEPPELIN-5903] Improve LRU NoteCache - Add a cleanup
Reamer opened a new pull request, #4590: URL: https://github.com/apache/zeppelin/pull/4590 ### What is this PR for? This pull request adds a cache cleanup method that attempts to remove an item from the cache that is not the eldest item and also does not have a read flag. ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-5903 ### How should this be tested? * CI ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] grizzly-monkey commented on pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails
grizzly-monkey commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1523879863 Fixed the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] zhugezifang commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error
zhugezifang commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1525302501 > Still > > > Thanks for the contribution @zhugezifang , could you update the PR description? ok，updated it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] realknorke commented on pull request #4586: [ZEPPELIN-5902] Support Spark 3.4
realknorke commented on PR #4586:
URL: https://github.com/apache/zeppelin/pull/4586#issuecomment-1525682236
Thanks for the pull request. Its possible to connect to a 3.4.0 Spark
cluster. BUT Spark Connect is not working.
```
%spark-connect
spark.read.option("basePath",
"s3a://bucket/prefix").orc("s3a://bucket/prefix/day=2023-*/").head()
```
leads to
```
org.apache.zeppelin.interpreter.InterpreterException: java.io.IOException:
Fail to launch interpreter process:
Interpreter download command: java -Dfile.encoding=UTF-8
-Dlog4j.configuration=file:///opt/zeppelin//conf/log4j.properties
-Dlog4j.configurationFile=file:///opt/zeppelin//conf/log4j2.properties
-Dzeppelin.log.file=/opt/zeppelin//logs/zeppelin-interpreter-spark-connect-shared_process--amos.log
-cp
:/opt/zeppelin//interpreter/spark/*:::/opt/zeppelin//interpreter/zeppelin-interpreter-shaded-0.11.0-SNAPSHOT.jar::/opt/zeppelin//interpreter/spark/spark-interpreter-0.11.0-SNAPSHOT.jar:
org.apache.zeppelin.interpreter.remote.RemoteInterpreterDownloader
192.168.50.6 37391 spark-connect /opt/zeppelin//local-repo/spark-connect
[INFO] Interpreter launch command: /opt/spark/bin/spark-submit --class
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer
--driver-class-path
:/opt/zeppelin//local-repo/spark-connect/*:/opt/zeppelin//interpreter/spark/*:::/opt/zeppelin//interpreter/zeppelin-interpreter-shaded-0.11.0-SNAPSHOT.jar::/opt/zeppelin//interpreter/spark/spark-interpreter-0.11.0-SNAPSHOT.jar:
--driver-java-options -Dfile.encoding=UTF-8
-Dlog4j.configuration=file:///opt/zeppelin//conf/log4j.properties
-Dlog4j.configurationFile=file:///opt/zeppelin//conf/log4j2.properties
-Dzeppelin.log.file=/opt/zeppelin//logs/zeppelin-interpreter-spark-connect-shared_process--amos.log
--conf spark.executor.memory=1g --conf spark.master=sc://localhost:15002
--conf spark.driver.memory=1g --conf spark.driver.cores=1 --conf
spark.jars.packages=org.apache.spark:spark-connect_2.12:3.4.0 --conf
spark.executor.cores=1 --conf spark.app.name=spark-connect-shared_process
--conf spark.executor.instances=2 --conf spark.we
bui.yarn.useProxy=false
/opt/zeppelin//interpreter/spark/spark-interpreter-0.11.0-SNAPSHOT.jar:
192.168.50.6 37391 spark-connect-shared_process :
Exception in thread "main" org.apache.spark.SparkException: Master must
either be yarn or start with spark, mesos, k8s, or local
at org.apache.spark.deploy.SparkSubmit.error(SparkSubmit.scala:1038)
at
org.apache.spark.deploy.SparkSubmit.prepareSubmitEnvironment(SparkSubmit.scala:254)
at
org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:955)
at
org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:192)
at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:215)
at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:91)
at
org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:)
at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:1120)
at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
at
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.open(RemoteInterpreter.java:129)
at
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.getFormType(RemoteInterpreter.java:271)
at org.apache.zeppelin.notebook.Paragraph.jobRun(Paragraph.java:429)
at org.apache.zeppelin.notebook.Paragraph.jobRun(Paragraph.java:69)
at org.apache.zeppelin.scheduler.Job.run(Job.java:172)
at
org.apache.zeppelin.scheduler.AbstractScheduler.runJob(AbstractScheduler.java:132)
at
org.apache.zeppelin.scheduler.RemoteScheduler$JobRunner.run(RemoteScheduler.java:182)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
Caused by: java.io.IOException: Fail to launch interpreter process:
Interpreter download command: java -Dfile.encoding=UTF-8
-Dlog4j.configuration=file:///opt/zeppelin//conf/log4j.properties
-Dlog4j.configurationFile=file:///opt/zeppelin//conf/log4j2.properties
-Dzeppelin.log.file=/opt/zeppelin//logs/zeppelin-interpreter-spark-connect-shared_process--amos.log
-cp
:/opt/zeppelin//interpreter/spark/*:::/opt/zeppelin//interpreter/zeppelin-interpreter-shaded-0.11.0-SNAPSHOT.jar::/opt/zeppelin//interpreter/spark/spark-interpreter-0.11.0-SNAPSHOT.jar:
[GitHub] [zeppelin] Reamer commented on pull request #4591: [ZEPPELIN-5898]fix:down csv data error
Reamer commented on PR #4591: URL: https://github.com/apache/zeppelin/pull/4591#issuecomment-1525674173 I do not understand the fix. Could you please explain it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4582: [ZEPPELIN-5900] Fix RemoteSchedulerTest
Reamer commented on PR #4582: URL: https://github.com/apache/zeppelin/pull/4582#issuecomment-1525923732 If no further comments are received till Tuesday 02.05, I will merge this PullRequest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4562: [ZEPPELIN-5880] Credentials roles
Reamer commented on PR #4562: URL: https://github.com/apache/zeppelin/pull/4562#issuecomment-1525944565 Added some Screenshots :-D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
