Re: [jira] [Updated] (ZEST-107) Entity SPI: JSONEntityState cloning logic is flawed

2015-07-28 Thread Niclas Hedhman
I just noticed one thing on GitHub...

 apache https://github.com/apache/*zest-java
https://github.com/apache/zest-java* mirrored from
git://git.apache.org/zest-qi4j.git

It doesn't look right...

Niclas

On Tue, Jul 28, 2015 at 6:24 PM, Paul Merlin (JIRA) j...@apache.org wrote:


  [
 https://issues.apache.org/jira/browse/ZEST-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

 Paul Merlin updated ZEST-107:
 -
 External issue URL: https://github.com/apache/zest-java/pull/2

  Entity SPI: JSONEntityState cloning logic is flawed
  ---
 
  Key: ZEST-107
  URL: https://issues.apache.org/jira/browse/ZEST-107
  Project: Zest
   Issue Type: Bug
 Affects Versions: 2.0
 Reporter: Tibor Mlynarik
 Assignee: Paul Merlin
  Fix For: 2.1
 
 
  The cloneStateIfGlobalStateLoaded() method of JSONEntityState is called
 before any change is made to the entity state.
  This method starts with the following check:
  if( isStateNotCloned() )
  {
  return;
  }
  // Do the clone
  And the (private) isStateNotCloned() method returns:
  status == EntityStatus.LOADED
  IOW, the code says that it will clone state if status is loaded, but it
 does the opposite!
  See discussion: http://s.apache.org/1QI



 --
 This message was sent by Atlassian JIRA
 (v6.3.4#6332)




-- 
Niclas Hedhman, Software Developer
http://zest.apache.org - New Energy for Java


Re: [jira] [Updated] (ZEST-107) Entity SPI: JSONEntityState cloning logic is flawed

2015-07-28 Thread Paul Merlin
Niclas Hedhman a écrit :
 I just noticed one thing on GitHub...

  apache https://github.com/apache/*zest-java
 https://github.com/apache/zest-java* mirrored from
 git://git.apache.org/zest-qi4j.git

 It doesn't look right...
Yep :/
Geoffrey commented about this:
https://issues.apache.org/jira/browse/INFRA-10043


The only thing you will notice on the GitHub mirror: it will still say
mirrored from git://git.apache.org/zest-qi4j.git. This is not
something that can be changed without deleting the GitHub mirror and
having them pick it up again. But the zest-java GitHub mirror is indeed
being synced from the zest-java repo on git-wip-us.apache.org.