date:20120122

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2012-01-22 Thread Camille Fournier (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190832#comment-13190832
]

Camille Fournier commented on ZOOKEEPER-1366:
-

The test in TimerTest is missing the @Test annotation which I presume is an
oversight.

Zookeeper should be tolerant of clock adjustments
-

Key: ZOOKEEPER-1366
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
Project: ZooKeeper
Issue Type: Bug
Reporter: Ted Dunning
Fix For: 3.4.3

Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch,
ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch

If you want to wreak havoc on a ZK based system just do [date -s +1hour]
and watch the mayhem as all sessions expire at once.
This shouldn't happen. Zookeeper could easily know handle elapsed times as
elapsed times rather than as differences between absolute times. The
absolute times are subject to adjustment when the clock is set while a timer
is not subject to this problem. In Java, System.currentTimeMillis() gives
you absolute time while System.nanoTime() gives you time based on a timer
from an arbitrary epoch.
I have done this and have been running tests now for some tens of minutes
with no failures. I will set up a test machine to redo the build again on
Ubuntu and post a patch here for discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2012-01-22 Thread Camille Fournier (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190837#comment-13190837
 ] 

Camille Fournier commented on ZOOKEEPER-1366:
-

So in general, I think this is a good patch and a very good thing for us to do. 
But I feel like Henry's comment is most interesting:

{quote}
The nice thing is that this is a small step towards a properly mockable time 
API in ZK, which would a) make tests much faster and b) make tests much more 
deterministic. There's a way to go still because of Thread.sleep and other 
complications, but this is a good first step.
{quote}

We really aren't doing all that much towards that end by replacing one static 
method call with another. You still can't mock that in mockito. So the only 
question I have here is, if we're going to touch all those places anyway, 
should we just be creating an actual thin object that wraps time and use 
non-static methods on that object to make these calls, in order to allow more 
mocking of timing issues in the future? Or should we save that for another 
patch?

 Zookeeper should be tolerant of clock adjustments
 -

 Key: ZOOKEEPER-1366
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Dunning
 Fix For: 3.4.3

 Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch


 If you want to wreak havoc on a ZK based system just do [date -s +1hour] 
 and watch the mayhem as all sessions expire at once.
 This shouldn't happen.  Zookeeper could easily know handle elapsed times as 
 elapsed times rather than as differences between absolute times.  The 
 absolute times are subject to adjustment when the clock is set while a timer 
 is not subject to this problem.  In Java, System.currentTimeMillis() gives 
 you absolute time while System.nanoTime() gives you time based on a timer 
 from an arbitrary epoch.
 I have done this and have been running tests now for some tens of minutes 
 with no failures.  I will set up a test machine to redo the build again on 
 Ubuntu and post a patch here for discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

ZooKeeper_branch33_solaris - Build # 82 - Still Failing

2012-01-22 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper_branch33_solaris/82/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 86811 lines...]
[junit] 2012-01-23 06:50:49,811 - INFO  [main:ZooKeeperServer@151] - 
Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7649404411818745637.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7649404411818745637.junit.dir/version-2
[junit] 2012-01-23 06:50:49,811 - INFO  [main:NIOServerCnxn$Factory@143] - 
binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2012-01-23 06:50:49,812 - INFO  [main:FileSnap@82] - Reading 
snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7649404411818745637.junit.dir/version-2/snapshot.0
[junit] 2012-01-23 06:50:49,815 - INFO  [main:FileTxnSnapLog@254] - 
Snapshotting: b
[junit] 2012-01-23 06:50:49,816 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] 2012-01-23 06:50:49,817 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - 
Accepted socket connection from /127.0.0.1:59423
[junit] 2012-01-23 06:50:49,817 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing 
stat command from /127.0.0.1:59423
[junit] 2012-01-23 06:50:49,818 - INFO  
[Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output
[junit] 2012-01-23 06:50:49,818 - INFO  [Thread-4:NIOServerCnxn@1435] - 
Closed socket connection for client /127.0.0.1:59423 (no session established 
for client)
[junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] expect:InMemoryDataTree
[junit] found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] expect:StandaloneServer_port
[junit] found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2012-01-23 06:50:49,819 - INFO  [main:ClientBase@385] - STOPPING 
server
[junit] 2012-01-23 06:50:49,821 - INFO  
[ProcessThread:-1:PrepRequestProcessor@120] - PrepRequestProcessor exited loop!
[junit] 2012-01-23 06:50:49,821 - INFO  
[SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited!
[junit] 2012-01-23 06:50:49,821 - INFO  [main:FinalRequestProcessor@378] - 
shutdown of request processor complete
[junit] 2012-01-23 06:50:49,822 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] ensureOnly:[]
[junit] 2012-01-23 06:50:49,823 - INFO  [main:ClientBase@378] - STARTING 
server
[junit] 2012-01-23 06:50:49,823 - INFO  [main:ZooKeeperServer@151] - 
Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7649404411818745637.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7649404411818745637.junit.dir/version-2
[junit] 2012-01-23 06:50:49,824 - INFO  [main:NIOServerCnxn$Factory@143] - 
binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2012-01-23 06:50:49,825 - INFO  [main:FileSnap@82] - Reading 
snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7649404411818745637.junit.dir/version-2/snapshot.b
[junit] 2012-01-23 06:50:49,827 - INFO  [main:FileTxnSnapLog@254] - 
Snapshotting: b
[junit] 2012-01-23 06:50:49,829 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] 2012-01-23 06:50:49,829 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - 
Accepted socket connection from /127.0.0.1:59425
[junit] 2012-01-23 06:50:49,830 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing 
stat command from /127.0.0.1:59425
[junit] 2012-01-23 06:50:49,830 - INFO  
[Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output
[junit] 2012-01-23 06:50:49,831 - INFO  [Thread-5:NIOServerCnxn@1435] - 
Closed socket connection for client /127.0.0.1:59425 (no session established 
for client)
[junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] expect:InMemoryDataTree
[junit] found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] expect:StandaloneServer_port
[junit] found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2012-01-23 06:50:49,841 - INFO

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

ZooKeeper_branch33_solaris - Build # 82 - Still Failing

3 matches

Site Navigation

Mail list logo

Footer information