date:20131014

Germán Blanco created ZOOKEEPER-1794:


 Summary: Add hash check to transaction history in quorum servers
 Key: ZOOKEEPER-1794
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1794
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: quorum
Reporter: Germán Blanco






--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Assigned] (ZOOKEEPER-1794) Add hash check to transaction history in quorum servers


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Germán Blanco reassigned ZOOKEEPER-1794:


Assignee: Germán Blanco

 Add hash check to transaction history in quorum servers
 ---

 Key: ZOOKEEPER-1794
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1794
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: quorum
Reporter: Germán Blanco
Assignee: Germán Blanco
 Fix For: 3.4.6, 3.5.0






--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1794) Add hash check to transaction history in quorum servers

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Germán Blanco updated ZOOKEEPER-1794:
-

Description: The goal of this task is to add a hash number to each
transaction in the transaction history. This hash number will be the same in
all members of the quorum, since it shall have the same result if the members
have the same transaction history. That means that there will be no need to
send any new information between members of the quorum. The hash number will be
checked by the leader when learnes try to connect. If the hash number does not
match, the synchronization will be done with a snashot in order to overwrite
the conflicts in the transaction history.

Add hash check to transaction history in quorum servers
---

Key: ZOOKEEPER-1794
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1794
Project: ZooKeeper
Issue Type: Sub-task
Components: quorum
Reporter: Germán Blanco
Assignee: Germán Blanco
Fix For: 3.4.6, 3.5.0

The goal of this task is to add a hash number to each transaction in the
transaction history. This hash number will be the same in all members of the
quorum, since it shall have the same result if the members have the same
transaction history. That means that there will be no need to send any new
information between members of the quorum. The hash number will be checked by
the leader when learnes try to connect. If the hash number does not match,
the synchronization will be done with a snashot in order to overwrite the
conflicts in the transaction history.

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1413) Use on-disk transaction log for learner sync up

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Germán Blanco updated ZOOKEEPER-1413:
-

Issue Type: Bug (was: Improvement)

Use on-disk transaction log for learner sync up
---

Key: ZOOKEEPER-1413
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1413
Project: ZooKeeper
Issue Type: Bug
Components: server
Affects Versions: 3.4.3
Reporter: Thawan Kooburat
Assignee: Thawan Kooburat
Priority: Minor
Labels: performance, quorum
Fix For: 3.4.6, 3.5.0

Attachments: ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch

Motivation:
The learner syncs up with leader by retrieving committed log from the leader.
Currently, the leader only keeps 500 entries of recently committed log in
memory. If the learner falls behind more than 500 updates, the leader will
send the entire snapshot to the learner.
With the size of the snapshot for some of our Zookeeper deployments (~10G),
it is prohibitively expensive to send the entire snapshot over network.
Additionally, our Zookeeper may serve more than 4K updates per seconds. As a
result, a network hiccups for less than a second will cause the learner to
use snapshot transfer.
Design:
Instead of looking only at committed log in memory, the leader will also look
at transaction log on disk. The amount of transaction log kept on disk is
configurable and the current default is 100k. This will allow Zookeeper to
tolerate longer temporal network failure before initiating the snapshot
transfer.
Implementation:
We plan to add interface to the persistence layer will can be use to retrieve
proposals from on-disk transaction log. These proposals can then be used to
send to the learner using existing protocol.

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1413) Use on-disk transaction log for learner sync up

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Germán Blanco updated ZOOKEEPER-1413:
-

Fix Version/s: 3.4.6

Use on-disk transaction log for learner sync up
---

Key: ZOOKEEPER-1413
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1413
Project: ZooKeeper
Issue Type: Improvement
Components: server
Affects Versions: 3.4.3
Reporter: Thawan Kooburat
Assignee: Thawan Kooburat
Priority: Minor
Labels: performance, quorum
Fix For: 3.4.6, 3.5.0

Attachments: ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1413) Use on-disk transaction log for learner sync up

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Germán Blanco updated ZOOKEEPER-1413:
-

Labels: performance quorum (was: performance)

Use on-disk transaction log for learner sync up
---

Attachments: ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1413) Use on-disk transaction log for learner sync up

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Germán Blanco updated ZOOKEEPER-1413:
-

Priority: Major (was: Minor)

Use on-disk transaction log for learner sync up
---

Attachments: ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1413) Use on-disk transaction log for learner sync up

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Germán Blanco updated ZOOKEEPER-1413:
-

Attachment: ZOOKEEPER-1413-3.4.patch

Please consider applying this fix also to branch 3.4.
It fixes a few problems in the synchronization of servers in the quorum.
E.g. it solves problems when using TRUNC.
Without this patch if a peer tries to connect to a leader with a higher epoch,
it will end up in an infinite loop.

Use on-disk transaction log for learner sync up
---

Attachments: ZOOKEEPER-1413-3.4.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1413) Use on-disk transaction log for learner sync up

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793949#comment-13793949
]

Germán Blanco commented on ZOOKEEPER-1413:
--

I am very sorry, I started updating this issue in order to propose the patch
for branch 3.4 (which is already prepared and attached), and now I don't know
if I should reopen the issue or not. It is already fixed in trunk and I don't
think that opening a new issue makes sense.
Please help me!

Use on-disk transaction log for learner sync up
---

Attachments: ZOOKEEPER-1413-3.4.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1413) Use on-disk transaction log for learner sync up

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Germán Blanco updated ZOOKEEPER-1413:
-

Fix Version/s: (was: 3.4.6)

Use on-disk transaction log for learner sync up
---

Attachments: ZOOKEEPER-1413-3.4.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-832) Invalid session id causes infinite loop during automatic reconnect


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793963#comment-13793963
 ] 

Germán Blanco commented on ZOOKEEPER-832:
-

Working on this proposal now:
- If this is a leader or an standalone server and the zxid of the client is 
higher than ours, then we close the session.
- If this is a learner and the zxid of the client is higher than ours, then we 
issue a SYNC to the leader. If after the SYNC is responded the zxid is still 
higher, then we close the session, otherwise we proceed with the connection.
- Add a test case.

 Invalid session id causes infinite loop during automatic reconnect
 --

 Key: ZOOKEEPER-832
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-832
 Project: ZooKeeper
  Issue Type: Improvement
  Components: c client, java client
Affects Versions: 3.3.1, 3.5.0
 Environment: Mac OS X 10.6.4
 JVM 1.6.0_20
Reporter: Ryan Holmes
Assignee: Germán Blanco
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-832.patch


 Steps to reproduce:
 1.) Connect to a standalone server using the Java client.
 2.) Stop the server.
 3.) Delete the contents of the data directory (i.e. the persisted session 
 data).
 4.) Start the server.
 The client now automatically tries to reconnect but the server refuses the 
 connection because the session id is invalid. The client and server are now 
 in an infinite loop of attempted and rejected connections. While this 
 situation represents a catastrophic failure and the current behavior is not 
 incorrect, it appears that there is no way to detect this situation on the 
 client and therefore no way to recover.
 The suggested improvement is to send an event to the default watcher 
 indicating that the current state is session invalid, similar to how the 
 session expired state is handled.
 Server log output (repeats indefinitely):
 2010-08-05 11:48:08,283 - INFO  
 [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn$Factory@250] - 
 Accepted socket connection from /127.0.0.1:63292
 2010-08-05 11:48:08,284 - INFO  
 [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@751] - Refusing 
 session request for client /127.0.0.1:63292 as it has seen zxid 0x44 our last 
 zxid is 0x0 client must try another server
 2010-08-05 11:48:08,284 - INFO  
 [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@1434] - Closed 
 socket connection for client /127.0.0.1:63292 (no session established for 
 client)
 Client log output (repeats indefinitely):
 11:47:17 org.apache.zookeeper.ClientCnxn startConnect INFO line 1000 - 
 Opening socket connection to server localhost/127.0.0.1:2181
 11:47:17 org.apache.zookeeper.ClientCnxn run WARN line 1120 - Session 
 0x12a3ae4e893000a for server null, unexpected error, closing socket 
 connection and attempting reconnect
 java.net.ConnectException: Connection refused
   at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
   at 
 sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:574)
   at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1078)
 11:47:17 org.apache.zookeeper.ClientCnxn cleanup DEBUG line 1167 - Ignoring 
 exception during shutdown input
 java.nio.channels.ClosedChannelException
   at 
 sun.nio.ch.SocketChannelImpl.shutdownInput(SocketChannelImpl.java:638)
   at sun.nio.ch.SocketAdaptor.shutdownInput(SocketAdaptor.java:360)
   at 
 org.apache.zookeeper.ClientCnxn$SendThread.cleanup(ClientCnxn.java:1164)
   at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1129)
 11:47:17 org.apache.zookeeper.ClientCnxn cleanup DEBUG line 1174 - Ignoring 
 exception during shutdown output
 java.nio.channels.ClosedChannelException
   at 
 sun.nio.ch.SocketChannelImpl.shutdownOutput(SocketChannelImpl.java:649)
   at sun.nio.ch.SocketAdaptor.shutdownOutput(SocketAdaptor.java:368)
   at 
 org.apache.zookeeper.ClientCnxn$SendThread.cleanup(ClientCnxn.java:1171)
   at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1129)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

ZooKeeper-trunk-solaris - Build # 700 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/700/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 218758 lines...]
[junit] 2013-10-14 09:01:38,751 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2013-10-14 09:01:38,752 [myid:] - INFO  [main:ZooKeeperServer@428] 
- shutting down
[junit] 2013-10-14 09:01:38,752 [myid:] - INFO  
[main:SessionTrackerImpl@183] - Shutting down
[junit] 2013-10-14 09:01:38,752 [myid:] - INFO  
[main:PrepRequestProcessor@972] - Shutting down
[junit] 2013-10-14 09:01:38,753 [myid:] - INFO  
[main:SyncRequestProcessor@190] - Shutting down
[junit] 2013-10-14 09:01:38,753 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2013-10-14 09:01:38,753 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@168] - SyncRequestProcessor exited!
[junit] 2013-10-14 09:01:38,753 [myid:] - INFO  
[main:FinalRequestProcessor@442] - shutdown of request processor complete
[junit] 2013-10-14 09:01:38,754 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-10-14 09:01:38,754 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[]
[junit] 2013-10-14 09:01:38,756 [myid:] - INFO  [main:ClientBase@414] - 
STARTING server
[junit] 2013-10-14 09:01:38,756 [myid:] - INFO  [main:ZooKeeperServer@149] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test382767235267967740.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test382767235267967740.junit.dir/version-2
[junit] 2013-10-14 09:01:38,757 [myid:] - INFO  
[main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2013-10-14 09:01:38,757 [myid:] - INFO  
[main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-10-14 09:01:38,758 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test382767235267967740.junit.dir/version-2/snapshot.b
[junit] 2013-10-14 09:01:38,761 [myid:] - INFO  [main:FileTxnSnapLog@297] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test382767235267967740.junit.dir/version-2/snapshot.b
[junit] 2013-10-14 09:01:38,762 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-10-14 09:01:38,763 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:39372
[junit] 2013-10-14 09:01:38,763 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@828] - Processing stat command from 
/127.0.0.1:39372
[junit] 2013-10-14 09:01:38,764 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn$StatCommand@677] - Stat command output
[junit] 2013-10-14 09:01:38,764 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@999] - Closed socket connection for client 
/127.0.0.1:39372 (no session established for client)
[junit] 2013-10-14 09:01:38,764 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2013-10-14 09:01:38,766 [myid:] - INFO  [main:JMXEnv@105] - 
expect:InMemoryDataTree
[junit] 2013-10-14 09:01:38,766 [myid:] - INFO  [main:JMXEnv@108] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2013-10-14 09:01:38,766 [myid:] - INFO  [main:JMXEnv@105] - 
expect:StandaloneServer_port
[junit] 2013-10-14 09:01:38,766 [myid:] - INFO  [main:JMXEnv@108] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-10-14 09:01:38,766 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota
[junit] 2013-10-14 09:01:38,767 [myid:] - INFO  [main:ClientBase@451] - 
tearDown starting
[junit] 2013-10-14 09:01:38,839 [myid:] - INFO  [main:ZooKeeper@777] - 
Session: 0x141b6330101 closed
[junit] 2013-10-14 09:01:38,839 [myid:] - INFO  [main:ClientBase@421] - 
STOPPING server
[junit] 2013-10-14 09:01:38,839 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down
[junit] 2013-10-14 09:01:38,840 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
-

ZooKeeper_branch33 - Build # 1104 - Failure

See https://builds.apache.org/job/ZooKeeper_branch33/1104/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 6079 lines...]
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:246)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)Caused 
by: hudson.remoting.ChannelClosedException: channel is already closed
at hudson.remoting.Channel.send(Channel.java:516)
at hudson.remoting.Request.call(Request.java:129)
at hudson.remoting.Channel.call(Channel.java:714)
at hudson.FilePath.act(FilePath.java:898)
... 13 more
Caused by: java.io.IOException: Unexpected termination of the channel
at 
hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:50)
Caused by: java.io.EOFException

at 
java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2596)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1316)
at java.io.ObjectInputStream.readObject(ObjectInputStream.java:370)
at hudson.remoting.Command.readFrom(Command.java:92)
at 
hudson.remoting.ClassicCommandTransport.read(ClassicCommandTransport.java:71)
at 
hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:48)
FATAL: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected 
termination of the channel
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1143)
[junit] 2013-10-14 09:34:19,317 - WARN  
[QuorumPeer:/0:0:0:0:0:0:0:0:11231:QuorumCnxManager@384] - Cannot open channel 
to 2 at election address /127.0.0.1:12230
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
[junit] at sun.nio.ch.SocketAdaptor.connect(SocketAdaptor.java:100)
hudson.remoting.RequestAbortedException: 
hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected 
termination of the channel
at 
hudson.remoting.RequestAbortedException.wrapForRethrow(RequestAbortedException.java:41)
at 
hudson.remoting.RequestAbortedException.wrapForRethrow(RequestAbortedException.java:34)
at hudson.remoting.Request.call(Request.java:174)
at hudson.remoting.Channel.call(Channel.java:714)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:167)
at com.sun.proxy.$Proxy42.join(Unknown Source)
at hudson.Launcher$RemoteLauncher$ProcImpl.join(Launcher.java:925)
at hudson.Launcher$ProcStarter.join(Launcher.java:360)
at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:91)
at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:60)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:782)
at hudson.model.Build$BuildExecution.build(Build.java:199)
at hudson.model.Build$BuildExecution.doRun(Build.java:160)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:567)
at hudson.model.Run.execute(Run.java:1603)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:246)
Caused by: hudson.remoting.RequestAbortedException: java.io.IOException: 
Unexpected termination of the channel
at hudson.remoting.Request.abort(Request.java:299)
at hudson.remoting.Channel.terminate(Channel.java:774)
at 
hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:69)
Caused by: java.io.IOException: Unexpected termination of the channel
at 
hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:50)
Caused by: java.io.EOFException
at 
java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2596)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1316)
at java.io.ObjectInputStream.readObject(ObjectInputStream.java:370)
at hudson.remoting.Command.readFrom(Command.java:92)
at 
hudson.remoting.ClassicCommandTransport.read(ClassicCommandTransport.java:71)
at 
hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:48)



###
##

ZooKeeper-3.4-WinVS2008_java - Build # 324 - Still Failing

See https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/324/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 217203 lines...]
[junit] 2013-10-14 11:17:22,619 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2013-10-14 11:17:22,619 [myid:] - INFO  
[main:PrepRequestProcessor@761] - Shutting down
[junit] 2013-10-14 11:17:22,619 [myid:] - INFO  
[main:SyncRequestProcessor@190] - Shutting down
[junit] 2013-10-14 11:17:22,620 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2013-10-14 11:17:22,621 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@168] - SyncRequestProcessor exited!
[junit] 2013-10-14 11:17:22,700 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@968] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11221. Will not attempt to 
authenticate using SASL (java.lang.SecurityException: Unable to locate a login 
configuration)
[junit] 2013-10-14 11:17:22,721 [myid:] - INFO  
[main:FinalRequestProcessor@415] - shutdown of request processor complete
[junit] 2013-10-14 11:17:22,722 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-10-14 11:17:23,711 [myid:] - WARN  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1095] - Session 
0x141b6785137 for server null, unexpected error, closing socket connection 
and attempting reconnect
[junit] java.net.ConnectException: Connection refused: no further 
information
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1074)
[junit] 2013-10-14 11:17:23,731 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[]
[junit] 2013-10-14 11:17:23,732 [myid:] - INFO  [main:ClientBase@414] - 
STARTING server
[junit] 2013-10-14 11:17:23,732 [myid:] - INFO  [main:ZooKeeperServer@162] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test3929390334339141682.junit.dir\version-2
 snapdir 
f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test3929390334339141682.junit.dir\version-2
[junit] 2013-10-14 11:17:23,827 [myid:] - INFO  
[main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-10-14 11:17:23,828 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test3929390334339141682.junit.dir\version-2\snapshot.b
[junit] 2013-10-14 11:17:23,831 [myid:] - INFO  [main:FileTxnSnapLog@240] - 
Snapshotting: 0xb to 
f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test3929390334339141682.junit.dir\version-2\snapshot.b
[junit] 2013-10-14 11:17:23,929 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-10-14 11:17:23,930 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - 
Accepted socket connection from /127.0.0.1:65516
[junit] 2013-10-14 11:17:23,930 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@817] - Processing 
stat command from /127.0.0.1:65516
[junit] 2013-10-14 11:17:23,931 [myid:] - INFO  
[Thread-5:NIOServerCnxn$StatCommand@653] - Stat command output
[junit] 2013-10-14 11:17:24,000 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop!
[junit] 2013-10-14 11:17:24,000 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop!
[junit] 2013-10-14 11:17:24,028 [myid:] - INFO  
[Thread-5:NIOServerCnxn@997] - Closed socket connection for client 
/127.0.0.1:65516 (no session established for client)
[junit] 2013-10-14 11:17:24,028 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2013-10-14 11:17:24,030 [myid:] - INFO  [main:JMXEnv@105] - 
expect:InMemoryDataTree
[junit] 2013-10-14 11:17:24,128 [myid:] - INFO  [main:JMXEnv@108] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2013-10-14 11:17:24,128 [myid:] - INFO  [main:JMXEnv@105] - 
expect:StandaloneServer_port
[junit] 2013-10-14 11:17:24,128 [myid:] - INFO  [main:JMXEnv@108] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-10-14 11:17:24,129 [myid:] - INFO

ZooKeeper-trunk-WinVS2008_java - Build # 572 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/572/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 281694 lines...]
[junit] 2013-10-14 11:30:12,899 [myid:] - INFO  
[main:FinalRequestProcessor@442] - shutdown of request processor complete
[junit] 2013-10-14 11:30:13,000 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-10-14 11:30:14,000 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[]
[junit] 2013-10-14 11:30:14,001 [myid:] - INFO  [main:ClientBase@414] - 
STARTING server
[junit] 2013-10-14 11:30:14,001 [myid:] - INFO  [main:ZooKeeperServer@149] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test2763137930823797806.junit.dir\version-2
 snapdir 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test2763137930823797806.junit.dir\version-2
[junit] 2013-10-14 11:30:14,006 [myid:] - INFO  
[main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 1 selector thread(s), 4 worker threads, and 64 
kB direct buffers.
[junit] 2013-10-14 11:30:14,007 [myid:] - INFO  
[main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-10-14 11:30:14,009 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test2763137930823797806.junit.dir\version-2\snapshot.b
[junit] 2013-10-14 11:30:14,108 [myid:] - INFO  [main:FileTxnSnapLog@297] - 
Snapshotting: 0xb to 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test2763137930823797806.junit.dir\version-2\snapshot.b
[junit] 2013-10-14 11:30:14,110 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-10-14 11:30:14,111 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:51338
[junit] 2013-10-14 11:30:14,208 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@828] - Processing stat command from 
/127.0.0.1:51338
[junit] 2013-10-14 11:30:14,208 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn$StatCommand@677] - Stat command output
[junit] 2013-10-14 11:30:14,209 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@999] - Closed socket connection for client 
/127.0.0.1:51338 (no session established for client)
[junit] 2013-10-14 11:30:14,209 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2013-10-14 11:30:14,308 [myid:] - INFO  [main:JMXEnv@105] - 
expect:InMemoryDataTree
[junit] 2013-10-14 11:30:14,308 [myid:] - INFO  [main:JMXEnv@108] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2013-10-14 11:30:14,308 [myid:] - INFO  [main:JMXEnv@105] - 
expect:StandaloneServer_port
[junit] 2013-10-14 11:30:14,308 [myid:] - INFO  [main:JMXEnv@108] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-10-14 11:30:14,309 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota
[junit] 2013-10-14 11:30:14,408 [myid:] - INFO  [main:ClientBase@451] - 
tearDown starting
[junit] 2013-10-14 11:30:14,526 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1008] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11221. Will not attempt to 
authenticate using SASL (java.lang.SecurityException: Unable to locate a login 
configuration)
[junit] 2013-10-14 11:30:14,527 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@882] - Socket 
connection established to 127.0.0.1/127.0.0.1:11221, initiating session
[junit] 2013-10-14 11:30:14,527 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:51339
[junit] 2013-10-14 11:30:14,610 [myid:] - INFO  
[NIOWorkerThread-2:ZooKeeperServer@858] - Client attempting to renew session 
0x141b6840edc at /127.0.0.1:51339
[junit] 2013-10-14 11:30:14,611 [myid:] - INFO  
[NIOWorkerThread-2:ZooKeeperServer@604] - Established session 0x141b6840edc 
with negotiated timeout 3 for client /127.0.0.1:51339
[junit] 2013-10-14 11:30:14,611 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1261] - Session 
establishment complete on server 127.0.0.1/127.0.0.1:11221, sessionid = 
0x141b6840edc, negotiated timeout = 3
[junit] 2013-10-14 11:30:14,711 [myid:] - INFO  [ProcessThread(sid:0

[jira] [Commented] (ZOOKEEPER-1413) Use on-disk transaction log for learner sync up

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794179#comment-13794179
]

Flavio Junqueira commented on ZOOKEEPER-1413:
-

This is currently marked as a bug, but I don't think it is a bug, it's an
improvement. I'd rather leave this one out of 3.4.6.

Use on-disk transaction log for learner sync up
---

Attachments: ZOOKEEPER-1413-3.4.patch, ZOOKEEPER-1413-3.4.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch, ZOOKEEPER-1413.patch,
ZOOKEEPER-1413.patch

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1667) Watch event isn't handled correctly when a client reestablish to a server


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794184#comment-13794184
 ] 

Flavio Junqueira commented on ZOOKEEPER-1667:
-

[~fanster.z], let me know if you need any help.

 Watch event isn't handled correctly when a client reestablish to a server
 -

 Key: ZOOKEEPER-1667
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1667
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.3.6, 3.4.5
Reporter: Jacky007
Assignee: Jacky007
Priority: Blocker
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1667.patch, ZOOKEEPER-1667-r34.patch


 When a client reestablish to a server, it will send the watches which have 
 not been triggered. But the code in DataTree does not handle it correctly.
 It is obvious, we just do not notice it :)
 scenario:
 1) Client a set a data watch on /d, then disconnect, client b delete /d and 
 create it again. When client a reestablish to zk, it will receive a 
 NodeCreated rather than a NodeDataChanged.
 2) Client a set a exists watch on /e(not exist), then disconnect, client b 
 create /e. When client a reestablish to zk, it will receive a NodeDataChanged 
 rather than a NodeCreated.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1413) Use on-disk transaction log for learner sync up

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Germán Blanco updated ZOOKEEPER-1413:
-

Issue Type: Improvement (was: Bug)

Use on-disk transaction log for learner sync up
---

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1413) Use on-disk transaction log for learner sync up

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Germán Blanco updated ZOOKEEPER-1413:
-

Priority: Minor (was: Major)

Use on-disk transaction log for learner sync up
---

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1413) Use on-disk transaction log for learner sync up

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794230#comment-13794230
]

Germán Blanco commented on ZOOKEEPER-1413:
--

I changed it from Improvement to Bug this morning. Now it is back to what it
was.
The problem that I see without this patch is that sometimes the new peer and
the leader end up in an infinite loop.
I have seen this when there is a new peer that has a higher epoch than the
leader.
Should that be reported in a different JIRA?

Use on-disk transaction log for learner sync up
---

--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1768) Cluster fails election loop until the device is full


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794244#comment-13794244
 ] 

Flavio Junqueira commented on ZOOKEEPER-1768:
-

If it is what I think it is, then you need to increase the initLimit. I don't 
know of a way of changing the initLimit dynamically, though. Also, another 
problem seems to be that the autopurge feature is removing correct snapshots 
and leaving partial snapshots on disk. If we can't complete the write of the 
snapshot, then perhaps we should delete it write after learning it. Given the 
behavior you're describing, I believe this is not what we are doing. 

 Cluster fails election loop until the device is full
 

 Key: ZOOKEEPER-1768
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1768
 Project: ZooKeeper
  Issue Type: Bug
  Components: leaderElection
Affects Versions: 3.4.5
Reporter: yuxin.yan
 Fix For: 3.4.6, 3.5.0

 Attachments: zk_debug.log.2013-09-25.log, zoo.cfg


 Hi, 
 I have a five nodes cluster versioned 3.4.5 and now i find one node is 
 offline.
 Firstly i restart the node but i find that Error contacting service. It is 
 probably not running. and i find that the node always elect the leader and 
 always sync the snapshot logs and the device will be full every ten mins. 
 so could someone help me？ i will put the log and zoo.cfg in the attachment.
 Thanks all.
 yyx,



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1646) mt c client tests fail on Ubuntu Raring


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794249#comment-13794249
 ] 

Flavio Junqueira commented on ZOOKEEPER-1646:
-

Just so that I understand, in your comment in ZOOKEEPER-1742, you say that 
you're observing this problem only on trunk, so why is it a blocker for 3.4.6?

 mt c client tests fail on Ubuntu Raring
 ---

 Key: ZOOKEEPER-1646
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1646
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.4.5
 Environment: Ubuntu 13.04 (raring), glibc 2.17
Reporter: James Page
Assignee: Patrick Hunt
Priority: Blocker
 Fix For: 3.4.6


 Misc tests fail in the c client binding under the current Ubuntu development 
 release:
 ./zktest-mt 
  ZooKeeper server startedRunning 
 Zookeeper_clientretry::testRetry ZooKeeper server started ZooKeeper server 
 started : elapsed 9315 : OK
 Zookeeper_operations::testAsyncWatcher1 : assertion : elapsed 1054
 Zookeeper_operations::testAsyncGetOperation : assertion : elapsed 1055
 Zookeeper_operations::testOperationsAndDisconnectConcurrently1 : assertion : 
 elapsed 1066
 Zookeeper_operations::testOperationsAndDisconnectConcurrently2 : elapsed 0 : 
 OK
 Zookeeper_operations::testConcurrentOperations1 : assertion : elapsed 1055
 Zookeeper_init::testBasic : elapsed 1 : OK
 Zookeeper_init::testAddressResolution : elapsed 0 : OK
 Zookeeper_init::testMultipleAddressResolution : elapsed 0 : OK
 Zookeeper_init::testNullAddressString : elapsed 0 : OK
 Zookeeper_init::testEmptyAddressString : elapsed 0 : OK
 Zookeeper_init::testOneSpaceAddressString : elapsed 0 : OK
 Zookeeper_init::testTwoSpacesAddressString : elapsed 0 : OK
 Zookeeper_init::testInvalidAddressString1 : elapsed 0 : OK
 Zookeeper_init::testInvalidAddressString2 : elapsed 175 : OK
 Zookeeper_init::testNonexistentHost : elapsed 92 : OK
 Zookeeper_init::testOutOfMemory_init : elapsed 0 : OK
 Zookeeper_init::testOutOfMemory_getaddrs1 : elapsed 0 : OK
 Zookeeper_init::testOutOfMemory_getaddrs2 : elapsed 1 : OK
 Zookeeper_init::testPermuteAddrsList : elapsed 0 : OK
 Zookeeper_close::testIOThreadStoppedOnExpire : assertion : elapsed 1056
 Zookeeper_close::testCloseUnconnected : elapsed 0 : OK
 Zookeeper_close::testCloseUnconnected1 : elapsed 91 : OK
 Zookeeper_close::testCloseConnected1 : assertion : elapsed 1056
 Zookeeper_close::testCloseFromWatcher1 : assertion : elapsed 1076
 Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server started : 
 elapsed 12155 : OK
 Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK
 Zookeeper_simpleSystem::testNullData : elapsed 1031 : OK
 Zookeeper_simpleSystem::testIPV6 : elapsed 1005 : OK
 Zookeeper_simpleSystem::testPath : elapsed 1024 : OK
 Zookeeper_simpleSystem::testPathValidation : elapsed 1053 : OK
 Zookeeper_simpleSystem::testPing : elapsed 17287 : OK
 Zookeeper_simpleSystem::testAcl : elapsed 1019 : OK
 Zookeeper_simpleSystem::testChroot : elapsed 3052 : OK
 Zookeeper_simpleSystem::testAuth : assertion : elapsed 7010
 Zookeeper_simpleSystem::testHangingClient : elapsed 1015 : OK
 Zookeeper_simpleSystem::testWatcherAutoResetWithGlobal ZooKeeper server 
 started ZooKeeper server started ZooKeeper server started : elapsed 20556 : OK
 Zookeeper_simpleSystem::testWatcherAutoResetWithLocal ZooKeeper server 
 started ZooKeeper server started ZooKeeper server started : elapsed 20563 : OK
 Zookeeper_simpleSystem::testGetChildren2 : elapsed 1041 : OK
 Zookeeper_multi::testCreate : elapsed 1017 : OK
 Zookeeper_multi::testCreateDelete : elapsed 1007 : OK
 Zookeeper_multi::testInvalidVersion : elapsed 1011 : OK
 Zookeeper_multi::testNestedCreate : elapsed 1009 : OK
 Zookeeper_multi::testSetData : elapsed 6019 : OK
 Zookeeper_multi::testUpdateConflict : elapsed 1014 : OK
 Zookeeper_multi::testDeleteUpdateConflict : elapsed 1007 : OK
 Zookeeper_multi::testAsyncMulti : elapsed 2001 : OK
 Zookeeper_multi::testMultiFail : elapsed 1006 : OK
 Zookeeper_multi::testCheck : elapsed 1020 : OK
 Zookeeper_multi::testWatch : elapsed 2013 : OK
 Zookeeper_watchers::testDefaultSessionWatcher1zktest-mt: 
 tests/ZKMocks.cc:271: SyncedBoolCondition 
 DeliverWatchersWrapper::isDelivered() const: Assertion `i1000' failed.
 Aborted (core dumped)
 It would appear that the zookeeper connection does not transition to 
 connected within the required time; I increased the time allowed but no 
 change.
 Ubuntu raring has glibc 2.17; the test suite works fine on previous Ubuntu 
 releases and this is the only difference that stood out.
 Interestingly the cli_mt worked just fine connecting to the same zookeeper 
 instance that the tests left lying around so I'm assuming this is a test 
 error rather than an actual bug.



--

Status of release 3.4.6

2013-10-14 Thread FPJ

There are currently 5 blockers:

 

-ZOOKEEPER-1732: patch converging

-ZOOKEEPER-1667: needs documentation

-ZOOKEEPER-1646: no patch yet

-ZOOKEEPER-1558: patch converging

-ZOOKEEPER-1430: there is patch, but I don't think it has been reviewed yet

 

I was thinking of reclassifying a few that I'd like to have in as well. As
soon as these blockers get in, I'll work on putting a release candidate
together.

 

-Flavio

[jira] [Commented] (ZOOKEEPER-1597) Windows build failing


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794255#comment-13794255
 ] 

Flavio Junqueira commented on ZOOKEEPER-1597:
-

[~michim], do you think you can produce a patch for this soon? I think it would 
be really good to have this one in.

 Windows build failing
 -

 Key: ZOOKEEPER-1597
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1597
 Project: ZooKeeper
  Issue Type: Bug
  Components: build, c client
Affects Versions: 3.5.0
Reporter: Alexander Shraer
Assignee: Michi Mutsuzaki
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1597.patch, ZOOKEEPER-1597.patch, 
 ZOOKEEPER-1597.patch


 Seems to be related to C client changes done for ZK-1355.
 We're not sure why these build failures happen on Windows.
 ###
 ## LAST 60 LINES OF THE CONSOLE 
 ###
 [...truncated 376 lines...]
   .\src\zookeeper.c(768): error C2224: left of '.count' must have 
 struct/union type
   .\src\zookeeper.c(768): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(770): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(770): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(770): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(773): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(774): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(780): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(781): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(788): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(789): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(792): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(792): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(794): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(814): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(825): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(825): error C2440: '=' : cannot convert from 'int' to 
 'addrvec_t'
   .\src\zookeeper.c(843): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(843): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(845): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(848): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(849): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(850): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(853): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1177): error C2143: syntax error : missing ';' before 
 'const'
   .\src\zookeeper.c(1179): error C2065: 'endpoint_info' : undeclared 
 identifier
   .\src\zookeeper.c(1883): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1884): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1885): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1916): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1920): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1927): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1928): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1944): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1949): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1962): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1963): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): fatal error C1003: error count exceeds 100; 
 stopping compilation
 38 Warning(s)
 102 Error(s)



--
This message

[jira] [Commented] (ZOOKEEPER-1646) mt c client tests fail on Ubuntu Raring


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794273#comment-13794273
 ] 

Patrick Hunt commented on ZOOKEEPER-1646:
-

I reported two issues on ZOOKEEPER-1742; one that only happens on 3.4 branch 
(this one), and another one that only happens on trunk 
(tests/TestReconfigServer.cc:128:16: error: ‘sleep’ was not declared in this 
scope)

I'm looking into this one. So far I've figured out it doesn't seem to be a 
timing issue - the notification is never sent to the watcher, even after 
extending the timeout to 10 seconds (from 1). However I haven't gotten much 
further - the C++ code is cumbersome.

 mt c client tests fail on Ubuntu Raring
 ---

 Key: ZOOKEEPER-1646
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1646
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.4.5
 Environment: Ubuntu 13.04 (raring), glibc 2.17
Reporter: James Page
Assignee: Patrick Hunt
Priority: Blocker
 Fix For: 3.4.6


 Misc tests fail in the c client binding under the current Ubuntu development 
 release:
 ./zktest-mt 
  ZooKeeper server startedRunning 
 Zookeeper_clientretry::testRetry ZooKeeper server started ZooKeeper server 
 started : elapsed 9315 : OK
 Zookeeper_operations::testAsyncWatcher1 : assertion : elapsed 1054
 Zookeeper_operations::testAsyncGetOperation : assertion : elapsed 1055
 Zookeeper_operations::testOperationsAndDisconnectConcurrently1 : assertion : 
 elapsed 1066
 Zookeeper_operations::testOperationsAndDisconnectConcurrently2 : elapsed 0 : 
 OK
 Zookeeper_operations::testConcurrentOperations1 : assertion : elapsed 1055
 Zookeeper_init::testBasic : elapsed 1 : OK
 Zookeeper_init::testAddressResolution : elapsed 0 : OK
 Zookeeper_init::testMultipleAddressResolution : elapsed 0 : OK
 Zookeeper_init::testNullAddressString : elapsed 0 : OK
 Zookeeper_init::testEmptyAddressString : elapsed 0 : OK
 Zookeeper_init::testOneSpaceAddressString : elapsed 0 : OK
 Zookeeper_init::testTwoSpacesAddressString : elapsed 0 : OK
 Zookeeper_init::testInvalidAddressString1 : elapsed 0 : OK
 Zookeeper_init::testInvalidAddressString2 : elapsed 175 : OK
 Zookeeper_init::testNonexistentHost : elapsed 92 : OK
 Zookeeper_init::testOutOfMemory_init : elapsed 0 : OK
 Zookeeper_init::testOutOfMemory_getaddrs1 : elapsed 0 : OK
 Zookeeper_init::testOutOfMemory_getaddrs2 : elapsed 1 : OK
 Zookeeper_init::testPermuteAddrsList : elapsed 0 : OK
 Zookeeper_close::testIOThreadStoppedOnExpire : assertion : elapsed 1056
 Zookeeper_close::testCloseUnconnected : elapsed 0 : OK
 Zookeeper_close::testCloseUnconnected1 : elapsed 91 : OK
 Zookeeper_close::testCloseConnected1 : assertion : elapsed 1056
 Zookeeper_close::testCloseFromWatcher1 : assertion : elapsed 1076
 Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server started : 
 elapsed 12155 : OK
 Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK
 Zookeeper_simpleSystem::testNullData : elapsed 1031 : OK
 Zookeeper_simpleSystem::testIPV6 : elapsed 1005 : OK
 Zookeeper_simpleSystem::testPath : elapsed 1024 : OK
 Zookeeper_simpleSystem::testPathValidation : elapsed 1053 : OK
 Zookeeper_simpleSystem::testPing : elapsed 17287 : OK
 Zookeeper_simpleSystem::testAcl : elapsed 1019 : OK
 Zookeeper_simpleSystem::testChroot : elapsed 3052 : OK
 Zookeeper_simpleSystem::testAuth : assertion : elapsed 7010
 Zookeeper_simpleSystem::testHangingClient : elapsed 1015 : OK
 Zookeeper_simpleSystem::testWatcherAutoResetWithGlobal ZooKeeper server 
 started ZooKeeper server started ZooKeeper server started : elapsed 20556 : OK
 Zookeeper_simpleSystem::testWatcherAutoResetWithLocal ZooKeeper server 
 started ZooKeeper server started ZooKeeper server started : elapsed 20563 : OK
 Zookeeper_simpleSystem::testGetChildren2 : elapsed 1041 : OK
 Zookeeper_multi::testCreate : elapsed 1017 : OK
 Zookeeper_multi::testCreateDelete : elapsed 1007 : OK
 Zookeeper_multi::testInvalidVersion : elapsed 1011 : OK
 Zookeeper_multi::testNestedCreate : elapsed 1009 : OK
 Zookeeper_multi::testSetData : elapsed 6019 : OK
 Zookeeper_multi::testUpdateConflict : elapsed 1014 : OK
 Zookeeper_multi::testDeleteUpdateConflict : elapsed 1007 : OK
 Zookeeper_multi::testAsyncMulti : elapsed 2001 : OK
 Zookeeper_multi::testMultiFail : elapsed 1006 : OK
 Zookeeper_multi::testCheck : elapsed 1020 : OK
 Zookeeper_multi::testWatch : elapsed 2013 : OK
 Zookeeper_watchers::testDefaultSessionWatcher1zktest-mt: 
 tests/ZKMocks.cc:271: SyncedBoolCondition 
 DeliverWatchersWrapper::isDelivered() const: Assertion `i1000' failed.
 Aborted (core dumped)
 It would appear that the zookeeper connection does not transition to 
 connected within the required time; I increased the time allowed but no 
 change.

[jira] [Commented] (ZOOKEEPER-1783) Distinguish initial configuration from first established configuration

2013-10-14 Thread Alexander Shraer (JIRA)

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794306#comment-13794306
]

Alexander Shraer commented on ZOOKEEPER-1783:
-

Hi Ben,

Our invariant is that the current quorum verifier has been committed / went
through consensus, and I didn't want to break it by assigning it a version that
didn't go through consensus. This restriction means that in the NEWLEADER
message we'd have to send a config with version 0 and then have
follower/observer/learner/leader make a check (when UPTODATE arrives) that
detects version = 0 and replaces it with the version from the NEWLEADER
version. It seemed that this would require more changes in more places, this is
why I chose to do it like in the patch -- basically use the fact that
lastProposedQV is an uncommitted qv we're sending to everyone, and they already
know how to handle it.

Changes to QuorumPeer:

1. Replicating the logic we have for restarting leader election to correctly
work when read-only mode is enabled.

roZkMgr.start();
+reconfigFlagClear();
+if (shuttingDownLE) {
+ shuttingDownLE = false;
+ startLeaderElection();
+}

This is just duplicate of what we do for when read-only option is disabled.
Without this, restarting leader election doesn't work correctly (it keeps
spinning since shuttingDownLE = true. I noticed it because read-only test was
failing with my changes to Leader.java. After this changed work, I changed
FastLeaderElection not to restart in this case because the quorum verifier is
identical besides the version. The change above is still needed though.

The other two changes are there because I was hitting NullPointerException from
different tests that now had to invoke processReconfig (to write dynamic config
files with new version) but didn't initialize dynamic config related parameters
correctly. These changes are just performing sanity checks before using
variables that may be null.

Distinguish initial configuration from first established configuration
--

Key: ZOOKEEPER-1783
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1783
Project: ZooKeeper
Issue Type: Bug
Components: quorum, server
Affects Versions: 3.5.0
Reporter: Alexander Shraer
Assignee: Alexander Shraer
Fix For: 3.5.0

Attachments: ZOOKEEPER-1783.patch, ZOOKEEPER-1783-ver1.patch,
ZOOKEEPER-1783-ver2.patch, ZOOKEEPER-1783-ver3.patch,
ZOOKEEPER-1783-ver4.patch, ZOOKEEPER-1783-ver5.patch,
ZOOKEEPER-1783-ver6.patch

We need a way to distinguish an initial config of a server and an initial
config of a running ensemble (before any reconfigs happen). Currently both
have version 0.
The version of a config increases with each reconfiguration, so the problem
is just with the initial config.

--
This message was sent by Atlassian JIRA
(v6.1#6144)

Re: Status of release 3.4.6

2013-10-14 Thread Patrick Hunt

It would be great if committers not able to work directly on blockers
help by reviewing the open patch availables, we usually try to clear
those as well as the blockers.

https://issues.apache.org/jira/issues/?jql=project%20%3D%20ZOOKEEPER%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%20%223.4.6%22%20ORDER%20BY%20priority%20DESC

Patrick

On Mon, Oct 14, 2013 at 9:33 AM, FPJ fpjunque...@yahoo.com wrote:
 There are currently 5 blockers:



 -ZOOKEEPER-1732: patch converging

 -ZOOKEEPER-1667: needs documentation

 -ZOOKEEPER-1646: no patch yet

 -ZOOKEEPER-1558: patch converging

 -ZOOKEEPER-1430: there is patch, but I don't think it has been reviewed yet



 I was thinking of reclassifying a few that I'd like to have in as well. As
 soon as these blockers get in, I'll work on putting a release candidate
 together.



 -Flavio

[jira] [Created] (ZOOKEEPER-1795) unable to build c client on ubuntu

Patrick Hunt created ZOOKEEPER-1795:
---

 Summary: unable to build c client on ubuntu
 Key: ZOOKEEPER-1795
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1795
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.5.0
Reporter: Patrick Hunt
Priority: Blocker
 Fix For: 3.5.0


Seems there is an issue for Ubuntu (I'm on 13.04), however I'm only seeing it 
on trunk and not branch 34

{noformat}
make check
make  zktest-st zktest-mt
make[1]: Entering directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
g++ -DHAVE_CONFIG_H -I.  -I./include -I./tests -I./generated  -DUSE_STATIC_LIB 
-DZKSERVER_CMD=\./tests/zkServer.sh\ -DZOO_IPV6_ENABLED -g -O2 -MT 
zktest_st-TestReconfigServer.o -MD -MP -MF 
.deps/zktest_st-TestReconfigServer.Tpo -c -o zktest_st-TestReconfigServer.o 
`test -f 'tests/TestReconfigServer.cc' || echo './'`tests/TestReconfigServer.cc
tests/TestReconfigServer.cc: In member function 'bool 
TestReconfigServer::waitForConnected(zhandle_t*, uint32_t)':
tests/TestReconfigServer.cc:128:16: error: 'sleep' was not declared in this 
scope
make[1]: *** [zktest_st-TestReconfigServer.o] Error 1
make[1]: Leaving directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
make: *** [check-am] Error 2
{noformat}

I have 

{noformat}
g++ --version
g++ (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
{noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794391#comment-13794391
 ] 

Patrick Hunt commented on ZOOKEEPER-1742:
-

Sounds good, here: ZOOKEEPER-1795

 make check doesn't work on macos
 --

 Key: ZOOKEEPER-1742
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Flavio Junqueira
Assignee: Benjamin Reed
 Fix For: 3.4.6, 3.5.0


 There are two problems I have spotted when running make check with the C 
 client. First, it complains that the sleep call is not defined in two test 
 files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. 
 Including unistd.h works. The second problem is with linker options. It 
 complains that --wrap is not a valid. I'm not sure how to deal with this 
 one yet, since I'm not sure why we are using it.  



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1795) unable to build c client on ubuntu


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794392#comment-13794392
 ] 

Patrick Hunt commented on ZOOKEEPER-1795:
-

on ZOOKEEPER-1742 [~breed] mentioned @pat you should split out the ubuntu 
build problem. there are just some unistd.h includes missing

 unable to build c client on ubuntu
 --

 Key: ZOOKEEPER-1795
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1795
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.5.0
Reporter: Patrick Hunt
Priority: Blocker
 Fix For: 3.5.0


 Seems there is an issue for Ubuntu (I'm on 13.04), however I'm only seeing it 
 on trunk and not branch 34
 {noformat}
 make check
 make  zktest-st zktest-mt
 make[1]: Entering directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 g++ -DHAVE_CONFIG_H -I.  -I./include -I./tests -I./generated  
 -DUSE_STATIC_LIB -DZKSERVER_CMD=\./tests/zkServer.sh\ -DZOO_IPV6_ENABLED 
 -g -O2 -MT zktest_st-TestReconfigServer.o -MD -MP -MF 
 .deps/zktest_st-TestReconfigServer.Tpo -c -o zktest_st-TestReconfigServer.o 
 `test -f 'tests/TestReconfigServer.cc' || echo 
 './'`tests/TestReconfigServer.cc
 tests/TestReconfigServer.cc: In member function 'bool 
 TestReconfigServer::waitForConnected(zhandle_t*, uint32_t)':
 tests/TestReconfigServer.cc:128:16: error: 'sleep' was not declared in this 
 scope
 make[1]: *** [zktest_st-TestReconfigServer.o] Error 1
 make[1]: Leaving directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 make: *** [check-am] Error 2
 {noformat}
 I have 
 {noformat}
 g++ --version
 g++ (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
 Copyright (C) 2012 Free Software Foundation, Inc.
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1795) unable to build c client on ubuntu


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794400#comment-13794400
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1795:
---

fwiw, happens in Fedora 19 too. this patch works for me:

{noformat}
diff --git a/src/c/tests/TestReconfigServer.cc 
b/src/c/tests/TestReconfigServer.cc
index 90bf6f6..a847b37 100644
--- a/src/c/tests/TestReconfigServer.cc
+++ b/src/c/tests/TestReconfigServer.cc
@@ -16,6 +16,7 @@
  */
 #include algorithm
 #include cppunit/extensions/HelperMacros.h
+#include unistd.h
 #include zookeeper.h
 
 #include Util.h
diff --git a/src/c/tests/ZooKeeperQuorumServer.cc 
b/src/c/tests/ZooKeeperQuorumServer.cc
index f8049d2..23392cd 100644
--- a/src/c/tests/ZooKeeperQuorumServer.cc
+++ b/src/c/tests/ZooKeeperQuorumServer.cc
@@ -21,6 +21,7 @@
 #include cstdlib
 #include fstream
 #include sstream
+#include unistd.h
 
 ZooKeeperQuorumServer::
 ZooKeeperQuorumServer(uint32_t id, uint32_t numServers) :
{noformat}

 unable to build c client on ubuntu
 --

 Key: ZOOKEEPER-1795
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1795
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.5.0
Reporter: Patrick Hunt
Priority: Blocker
 Fix For: 3.5.0


 Seems there is an issue for Ubuntu (I'm on 13.04), however I'm only seeing it 
 on trunk and not branch 34
 {noformat}
 make check
 make  zktest-st zktest-mt
 make[1]: Entering directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 g++ -DHAVE_CONFIG_H -I.  -I./include -I./tests -I./generated  
 -DUSE_STATIC_LIB -DZKSERVER_CMD=\./tests/zkServer.sh\ -DZOO_IPV6_ENABLED 
 -g -O2 -MT zktest_st-TestReconfigServer.o -MD -MP -MF 
 .deps/zktest_st-TestReconfigServer.Tpo -c -o zktest_st-TestReconfigServer.o 
 `test -f 'tests/TestReconfigServer.cc' || echo 
 './'`tests/TestReconfigServer.cc
 tests/TestReconfigServer.cc: In member function 'bool 
 TestReconfigServer::waitForConnected(zhandle_t*, uint32_t)':
 tests/TestReconfigServer.cc:128:16: error: 'sleep' was not declared in this 
 scope
 make[1]: *** [zktest_st-TestReconfigServer.o] Error 1
 make[1]: Leaving directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 make: *** [check-am] Error 2
 {noformat}
 I have 
 {noformat}
 g++ --version
 g++ (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
 Copyright (C) 2012 Free Software Foundation, Inc.
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1597) Windows build failing

2013-10-14 Thread Michi Mutsuzaki (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michi Mutsuzaki updated ZOOKEEPER-1597:
---

Attachment: ZOOKEEPER-1597-3.4.patch

Update the solution file format to visual studio 2008. Tested the patch locally 
by building the project using visual studio 2008.

 Windows build failing
 -

 Key: ZOOKEEPER-1597
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1597
 Project: ZooKeeper
  Issue Type: Bug
  Components: build, c client
Affects Versions: 3.5.0
Reporter: Alexander Shraer
Assignee: Michi Mutsuzaki
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1597-3.4.patch, ZOOKEEPER-1597.patch, 
 ZOOKEEPER-1597.patch, ZOOKEEPER-1597.patch


 Seems to be related to C client changes done for ZK-1355.
 We're not sure why these build failures happen on Windows.
 ###
 ## LAST 60 LINES OF THE CONSOLE 
 ###
 [...truncated 376 lines...]
   .\src\zookeeper.c(768): error C2224: left of '.count' must have 
 struct/union type
   .\src\zookeeper.c(768): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(770): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(770): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(770): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(773): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(774): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(780): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(781): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(788): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(789): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(792): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(792): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(794): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(814): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(825): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(825): error C2440: '=' : cannot convert from 'int' to 
 'addrvec_t'
   .\src\zookeeper.c(843): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(843): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(845): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(848): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(849): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(850): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(853): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1177): error C2143: syntax error : missing ';' before 
 'const'
   .\src\zookeeper.c(1179): error C2065: 'endpoint_info' : undeclared 
 identifier
   .\src\zookeeper.c(1883): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1884): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1885): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1916): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1920): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1927): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1928): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1944): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1949): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1962): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1963): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): fatal error C1003: error count exceeds 100; 
 stopping compilation
 38 Warning(s)
 102

[jira] [Commented] (ZOOKEEPER-1597) Windows build failing

2013-10-14 Thread Michi Mutsuzaki (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794414#comment-13794414
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1597:


Current build failure looks a java test failure. This patch probably won't fix 
the build failure.

https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/324/console

 Windows build failing
 -

 Key: ZOOKEEPER-1597
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1597
 Project: ZooKeeper
  Issue Type: Bug
  Components: build, c client
Affects Versions: 3.5.0
Reporter: Alexander Shraer
Assignee: Michi Mutsuzaki
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1597-3.4.patch, ZOOKEEPER-1597.patch, 
 ZOOKEEPER-1597.patch, ZOOKEEPER-1597.patch


 Seems to be related to C client changes done for ZK-1355.
 We're not sure why these build failures happen on Windows.
 ###
 ## LAST 60 LINES OF THE CONSOLE 
 ###
 [...truncated 376 lines...]
   .\src\zookeeper.c(768): error C2224: left of '.count' must have 
 struct/union type
   .\src\zookeeper.c(768): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(770): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(770): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(770): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(773): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(774): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(780): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(781): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(788): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(789): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(792): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(792): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(794): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(814): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(825): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(825): error C2440: '=' : cannot convert from 'int' to 
 'addrvec_t'
   .\src\zookeeper.c(843): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(843): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(845): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(848): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(849): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(850): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(853): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1177): error C2143: syntax error : missing ';' before 
 'const'
   .\src\zookeeper.c(1179): error C2065: 'endpoint_info' : undeclared 
 identifier
   .\src\zookeeper.c(1883): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1884): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1885): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1916): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1920): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1927): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1928): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1944): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1949): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1962): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1963): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): fatal error C1003: error count exceeds 100;

Failed: ZOOKEEPER-1597 PreCommit Build #1693

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1597
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1693/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 74 lines...]
 [exec] patching file src/c/zookeeper.sln
 [exec] Reversed (or previously applied) patch detected!  Assume -R? [n] 
 [exec] Apply anyway? [n] 
 [exec] Skipping patch.
 [exec] 1 out of 1 hunk ignored -- saving rejects to file 
src/c/zookeeper.sln.rej
 [exec] patching file src/c/zookeeper.vcproj
 [exec] Hunk #1 FAILED at 1.
 [exec] 1 out of 1 hunk FAILED -- saving rejects to file 
src/c/zookeeper.vcproj.rej
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12608334/ZOOKEEPER-1597-3.4.patch
 [exec]   against trunk revision 1531444.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1693//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] d304c5ef86ebf4a0c4e59c639cb6f1e57281917c logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 1

Total time: 59 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1597
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1597) Windows build failing


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794417#comment-13794417
 ] 

Hadoop QA commented on ZOOKEEPER-1597:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12608334/ZOOKEEPER-1597-3.4.patch
  against trunk revision 1531444.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1693//console

This message is automatically generated.

 Windows build failing
 -

 Key: ZOOKEEPER-1597
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1597
 Project: ZooKeeper
  Issue Type: Bug
  Components: build, c client
Affects Versions: 3.5.0
Reporter: Alexander Shraer
Assignee: Michi Mutsuzaki
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1597-3.4.patch, ZOOKEEPER-1597.patch, 
 ZOOKEEPER-1597.patch, ZOOKEEPER-1597.patch


 Seems to be related to C client changes done for ZK-1355.
 We're not sure why these build failures happen on Windows.
 ###
 ## LAST 60 LINES OF THE CONSOLE 
 ###
 [...truncated 376 lines...]
   .\src\zookeeper.c(768): error C2224: left of '.count' must have 
 struct/union type
   .\src\zookeeper.c(768): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(770): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(770): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(770): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(773): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(774): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(780): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(781): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(788): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(789): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(792): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(792): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(794): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(814): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(825): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(825): error C2440: '=' : cannot convert from 'int' to 
 'addrvec_t'
   .\src\zookeeper.c(843): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(843): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(845): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(848): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(849): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(850): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(853): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1177): error C2143: syntax error : missing ';' before 
 'const'
   .\src\zookeeper.c(1179): error C2065: 'endpoint_info' : undeclared 
 identifier
   .\src\zookeeper.c(1883): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1884): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1885): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1916): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1920): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1927): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1927): error C2065:

[jira] [Commented] (ZOOKEEPER-1597) Windows build failing

2013-10-14 Thread Michi Mutsuzaki (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794421#comment-13794421
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1597:


How do I tell buildbot that this patch is for 3.4 branch?

 Windows build failing
 -

 Key: ZOOKEEPER-1597
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1597
 Project: ZooKeeper
  Issue Type: Bug
  Components: build, c client
Affects Versions: 3.5.0
Reporter: Alexander Shraer
Assignee: Michi Mutsuzaki
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1597-3.4.patch, ZOOKEEPER-1597.patch, 
 ZOOKEEPER-1597.patch, ZOOKEEPER-1597.patch


 Seems to be related to C client changes done for ZK-1355.
 We're not sure why these build failures happen on Windows.
 ###
 ## LAST 60 LINES OF THE CONSOLE 
 ###
 [...truncated 376 lines...]
   .\src\zookeeper.c(768): error C2224: left of '.count' must have 
 struct/union type
   .\src\zookeeper.c(768): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(770): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(770): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(770): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(773): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(774): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(780): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(781): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(788): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(789): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(792): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(792): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(794): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(814): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(825): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(825): error C2440: '=' : cannot convert from 'int' to 
 'addrvec_t'
   .\src\zookeeper.c(843): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(843): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(845): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(848): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(849): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(850): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(853): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1177): error C2143: syntax error : missing ';' before 
 'const'
   .\src\zookeeper.c(1179): error C2065: 'endpoint_info' : undeclared 
 identifier
   .\src\zookeeper.c(1883): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1884): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1885): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1916): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1920): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1927): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1928): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1944): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1949): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1962): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1963): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): fatal error C1003: error count exceeds 100; 
 stopping compilation
 38 Warning(s)
 102 Error(s)



--
This message was sent by Atlassian JIRA

[jira] [Commented] (ZOOKEEPER-1597) Windows build failing


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794435#comment-13794435
 ] 

Flavio Junqueira commented on ZOOKEEPER-1597:
-

I don't know of a way of doing it, it would be nice if we could, though.

 Windows build failing
 -

 Key: ZOOKEEPER-1597
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1597
 Project: ZooKeeper
  Issue Type: Bug
  Components: build, c client
Affects Versions: 3.5.0
Reporter: Alexander Shraer
Assignee: Michi Mutsuzaki
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1597-3.4.patch, ZOOKEEPER-1597.patch, 
 ZOOKEEPER-1597.patch, ZOOKEEPER-1597.patch


 Seems to be related to C client changes done for ZK-1355.
 We're not sure why these build failures happen on Windows.
 ###
 ## LAST 60 LINES OF THE CONSOLE 
 ###
 [...truncated 376 lines...]
   .\src\zookeeper.c(768): error C2224: left of '.count' must have 
 struct/union type
   .\src\zookeeper.c(768): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(770): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(770): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(770): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(773): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(774): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(780): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(781): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(788): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(789): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(792): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(792): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(794): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(814): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(825): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(825): error C2440: '=' : cannot convert from 'int' to 
 'addrvec_t'
   .\src\zookeeper.c(843): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(843): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(845): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(848): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(849): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(850): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(853): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1177): error C2143: syntax error : missing ';' before 
 'const'
   .\src\zookeeper.c(1179): error C2065: 'endpoint_info' : undeclared 
 identifier
   .\src\zookeeper.c(1883): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1884): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1885): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1916): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1920): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1927): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1928): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1944): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1949): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1962): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1963): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): fatal error C1003: error count exceeds 100; 
 stopping compilation
 38 Warning(s)
 102 Error(s)



--
This message was sent by

Re: The problem of using c binding function

2013-10-14 Thread Patrick Hunt

Likely because data in the second case is allocated on the stack,
which goes out of scope asa you exit the method.

Patrick

On Fri, Oct 11, 2013 at 7:08 PM, 吴腾飞 wuteng...@yy.com wrote:
 Hi



 I using c client binding fuction zoo_aget,the passed data cause problem.



 ZOOAPI int zoo_aget(zhandle_t *zh,const char *path,int
 watch,data_completion_t completion,const void *data)



 1.Using like this is ok:



 int ret = zoo_aget(zkhandle, path,0,DataCompletion,” zoo_aget”);

 DataCompletion:

 DataCompletion(int rc, const char *value, int value_len, const struct Stat
 *stat, const void *data)

 {

   Coutdataendl;//out put is :zoo_aget

 }



 2.But this is no right:

 Char* data = “zoo_aget”;

 int ret = zoo_aget(zkhandle, path,0,DataCompletion, data);

 DataCompletion:

 DataCompletion(int rc, const char *value, int value_len, const struct Stat
 *stat, const void *data)

 {

   Coutdataendl;//out put is not zoo_aget

 }



 Why I in 2 can not got correct output?Using zoo_axxx,pass data also the same
 question.



 Thanks,



 Albert Wu.

[jira] [Created] (ZOOKEEPER-1796) Move common code from {Follower, Observer}ZooKeeperServer into LearnerZooKeeperServer

Raul Gutierrez Segales created ZOOKEEPER-1796:
-

 Summary: Move common code from {Follower, Observer}ZooKeeperServer 
into LearnerZooKeeperServer
 Key: ZOOKEEPER-1796
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1796
 Project: ZooKeeper
  Issue Type: Improvement
Reporter: Raul Gutierrez Segales
Priority: Trivial


Since ZOOKEEPER-1552 we are enabling syncProcessor in Observers, so we should 
have a proper shutdown() method there. Since FollowerZooKeeperServer already 
has one, which does the same thing that we need, move that to 
LearnerZooKeeperServer along with some related instance variables. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1796) Move common code from {Follower, Observer}ZooKeeperServer into LearnerZooKeeperServer


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raul Gutierrez Segales updated ZOOKEEPER-1796:
--

Attachment: ZOOKEEPER-1796.patch

 Move common code from {Follower, Observer}ZooKeeperServer into 
 LearnerZooKeeperServer
 -

 Key: ZOOKEEPER-1796
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1796
 Project: ZooKeeper
  Issue Type: Improvement
Reporter: Raul Gutierrez Segales
Priority: Trivial
 Attachments: ZOOKEEPER-1796.patch


 Since ZOOKEEPER-1552 we are enabling syncProcessor in Observers, so we should 
 have a proper shutdown() method there. Since FollowerZooKeeperServer already 
 has one, which does the same thing that we need, move that to 
 LearnerZooKeeperServer along with some related instance variables. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira updated ZOOKEEPER-1558:


Attachment: ZOOKEEPER-1558.patch

I have removed the call to takeSnapshot(). When I did it, 
ZkDatabaseCorruptionTest started failing and I realized that there was a bug in 
the test case. We set snapCount to have servers taking a number of snapshots 
during the test. However, by the time we set snapCount to 100, randRoll has 
already been set and the values are typically much larger than the 2000 ops we 
are running. Consequently, we never have a snapshot.

To fix it, I have changed SyncRequestProcessor to change the value of randRoll 
when we set snapCount. For the purposes of this test, I think this is 
sufficient.

 Leader should not snapshot uncommitted state
 

 Key: ZOOKEEPER-1558
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: quorum
Affects Versions: 3.4.6
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
Priority: Blocker
 Fix For: 3.4.6

 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, 
 ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, 
 ZOOKEEPER-1558.patch


 Leader currently takes a snapshot when it calls loadData in the beginning of 
 the lead() method. The loaded data, however, may contain uncommitted state.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794598#comment-13794598
]

Hadoop QA commented on ZOOKEEPER-1558:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12608368/ZOOKEEPER-1558.patch
against trunk revision 1531444.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

-1 javac. The patch appears to cause tar ant target to fail.

-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//console

This message is automatically generated.

Leader should not snapshot uncommitted state

Key: ZOOKEEPER-1558
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558
Project: ZooKeeper
Issue Type: Sub-task
Components: quorum
Affects Versions: 3.4.6
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
Priority: Blocker
Fix For: 3.4.6

Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch,
ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch,
ZOOKEEPER-1558.patch

Leader currently takes a snapshot when it calls loadData in the beginning of
the lead() method. The loaded data, however, may contain uncommitted state.

--
This message was sent by Atlassian JIRA
(v6.1#6144)

Failed: ZOOKEEPER-1558 PreCommit Build #1694

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1558
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 540 lines...]
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12608368/ZOOKEEPER-1558.patch
 [exec]   against trunk revision 1531444.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] -1 javac.  The patch appears to cause tar ant target to fail.
 [exec] 
 [exec] -1 findbugs.  The patch appears to introduce 1 new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 3f01a5d96733b74043ff5fd0100134ae03e74c56 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 3

Total time: 2 minutes 41 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1558
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-1795) unable to build c client on ubuntu


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raul Gutierrez Segales updated ZOOKEEPER-1795:
--

Attachment: ZOOKEEPER-1795.patch

unistd.h is needed for sleep().

 unable to build c client on ubuntu
 --

 Key: ZOOKEEPER-1795
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1795
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.5.0
Reporter: Patrick Hunt
Priority: Blocker
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1795.patch


 Seems there is an issue for Ubuntu (I'm on 13.04), however I'm only seeing it 
 on trunk and not branch 34
 {noformat}
 make check
 make  zktest-st zktest-mt
 make[1]: Entering directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 g++ -DHAVE_CONFIG_H -I.  -I./include -I./tests -I./generated  
 -DUSE_STATIC_LIB -DZKSERVER_CMD=\./tests/zkServer.sh\ -DZOO_IPV6_ENABLED 
 -g -O2 -MT zktest_st-TestReconfigServer.o -MD -MP -MF 
 .deps/zktest_st-TestReconfigServer.Tpo -c -o zktest_st-TestReconfigServer.o 
 `test -f 'tests/TestReconfigServer.cc' || echo 
 './'`tests/TestReconfigServer.cc
 tests/TestReconfigServer.cc: In member function 'bool 
 TestReconfigServer::waitForConnected(zhandle_t*, uint32_t)':
 tests/TestReconfigServer.cc:128:16: error: 'sleep' was not declared in this 
 scope
 make[1]: *** [zktest_st-TestReconfigServer.o] Error 1
 make[1]: Leaving directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 make: *** [check-am] Error 2
 {noformat}
 I have 
 {noformat}
 g++ --version
 g++ (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
 Copyright (C) 2012 Free Software Foundation, Inc.
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1795) unable to build c client on ubuntu


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-1795:


Assignee: Raul Gutierrez Segales

 unable to build c client on ubuntu
 --

 Key: ZOOKEEPER-1795
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1795
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.5.0
Reporter: Patrick Hunt
Assignee: Raul Gutierrez Segales
Priority: Blocker
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1795.patch


 Seems there is an issue for Ubuntu (I'm on 13.04), however I'm only seeing it 
 on trunk and not branch 34
 {noformat}
 make check
 make  zktest-st zktest-mt
 make[1]: Entering directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 g++ -DHAVE_CONFIG_H -I.  -I./include -I./tests -I./generated  
 -DUSE_STATIC_LIB -DZKSERVER_CMD=\./tests/zkServer.sh\ -DZOO_IPV6_ENABLED 
 -g -O2 -MT zktest_st-TestReconfigServer.o -MD -MP -MF 
 .deps/zktest_st-TestReconfigServer.Tpo -c -o zktest_st-TestReconfigServer.o 
 `test -f 'tests/TestReconfigServer.cc' || echo 
 './'`tests/TestReconfigServer.cc
 tests/TestReconfigServer.cc: In member function 'bool 
 TestReconfigServer::waitForConnected(zhandle_t*, uint32_t)':
 tests/TestReconfigServer.cc:128:16: error: 'sleep' was not declared in this 
 scope
 make[1]: *** [zktest_st-TestReconfigServer.o] Error 1
 make[1]: Leaving directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 make: *** [check-am] Error 2
 {noformat}
 I have 
 {noformat}
 g++ --version
 g++ (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
 Copyright (C) 2012 Free Software Foundation, Inc.
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Success: ZOOKEEPER-1795 PreCommit Build #1695

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1795
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1695/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 307999 lines...]
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 0 seconds
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12608374/ZOOKEEPER-1795.patch
 [exec]   against trunk revision 1531444.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1695//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1695//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1695//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 5eaf6d76bcbe255b675eadf2e8fcf86932bfaae5 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 32 minutes 51 seconds
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1795
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1795) unable to build c client on ubuntu


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794639#comment-13794639
 ] 

Patrick Hunt commented on ZOOKEEPER-1795:
-

The attached patch fixed the compilation issue for trunk, now I'm seeing 
ZOOKEEPER-1646 (we should commit/fix this issue though once qabot signs off)


 unable to build c client on ubuntu
 --

 Key: ZOOKEEPER-1795
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1795
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.5.0
Reporter: Patrick Hunt
Assignee: Raul Gutierrez Segales
Priority: Blocker
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1795.patch


 Seems there is an issue for Ubuntu (I'm on 13.04), however I'm only seeing it 
 on trunk and not branch 34
 {noformat}
 make check
 make  zktest-st zktest-mt
 make[1]: Entering directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 g++ -DHAVE_CONFIG_H -I.  -I./include -I./tests -I./generated  
 -DUSE_STATIC_LIB -DZKSERVER_CMD=\./tests/zkServer.sh\ -DZOO_IPV6_ENABLED 
 -g -O2 -MT zktest_st-TestReconfigServer.o -MD -MP -MF 
 .deps/zktest_st-TestReconfigServer.Tpo -c -o zktest_st-TestReconfigServer.o 
 `test -f 'tests/TestReconfigServer.cc' || echo 
 './'`tests/TestReconfigServer.cc
 tests/TestReconfigServer.cc: In member function 'bool 
 TestReconfigServer::waitForConnected(zhandle_t*, uint32_t)':
 tests/TestReconfigServer.cc:128:16: error: 'sleep' was not declared in this 
 scope
 make[1]: *** [zktest_st-TestReconfigServer.o] Error 1
 make[1]: Leaving directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 make: *** [check-am] Error 2
 {noformat}
 I have 
 {noformat}
 g++ --version
 g++ (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
 Copyright (C) 2012 Free Software Foundation, Inc.
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1795) unable to build c client on ubuntu


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794635#comment-13794635
 ] 

Hadoop QA commented on ZOOKEEPER-1795:
--

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12608374/ZOOKEEPER-1795.patch
  against trunk revision 1531444.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1695//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1695//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1695//console

This message is automatically generated.

 unable to build c client on ubuntu
 --

 Key: ZOOKEEPER-1795
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1795
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.5.0
Reporter: Patrick Hunt
Assignee: Raul Gutierrez Segales
Priority: Blocker
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1795.patch


 Seems there is an issue for Ubuntu (I'm on 13.04), however I'm only seeing it 
 on trunk and not branch 34
 {noformat}
 make check
 make  zktest-st zktest-mt
 make[1]: Entering directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 g++ -DHAVE_CONFIG_H -I.  -I./include -I./tests -I./generated  
 -DUSE_STATIC_LIB -DZKSERVER_CMD=\./tests/zkServer.sh\ -DZOO_IPV6_ENABLED 
 -g -O2 -MT zktest_st-TestReconfigServer.o -MD -MP -MF 
 .deps/zktest_st-TestReconfigServer.Tpo -c -o zktest_st-TestReconfigServer.o 
 `test -f 'tests/TestReconfigServer.cc' || echo 
 './'`tests/TestReconfigServer.cc
 tests/TestReconfigServer.cc: In member function 'bool 
 TestReconfigServer::waitForConnected(zhandle_t*, uint32_t)':
 tests/TestReconfigServer.cc:128:16: error: 'sleep' was not declared in this 
 scope
 make[1]: *** [zktest_st-TestReconfigServer.o] Error 1
 make[1]: Leaving directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
 make: *** [check-am] Error 2
 {noformat}
 I have 
 {noformat}
 g++ --version
 g++ (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
 Copyright (C) 2012 Free Software Foundation, Inc.
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1646) mt c client tests fail on Ubuntu Raring


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-1646:


Affects Version/s: 3.5.0
Fix Version/s: 3.5.0

Once ZOOKEEPER-1795 is applied I'm seeing this on trunk as well.

 mt c client tests fail on Ubuntu Raring
 ---

 Key: ZOOKEEPER-1646
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1646
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.4.5, 3.5.0
 Environment: Ubuntu 13.04 (raring), glibc 2.17
Reporter: James Page
Assignee: Patrick Hunt
Priority: Blocker
 Fix For: 3.4.6, 3.5.0


 Misc tests fail in the c client binding under the current Ubuntu development 
 release:
 ./zktest-mt 
  ZooKeeper server startedRunning 
 Zookeeper_clientretry::testRetry ZooKeeper server started ZooKeeper server 
 started : elapsed 9315 : OK
 Zookeeper_operations::testAsyncWatcher1 : assertion : elapsed 1054
 Zookeeper_operations::testAsyncGetOperation : assertion : elapsed 1055
 Zookeeper_operations::testOperationsAndDisconnectConcurrently1 : assertion : 
 elapsed 1066
 Zookeeper_operations::testOperationsAndDisconnectConcurrently2 : elapsed 0 : 
 OK
 Zookeeper_operations::testConcurrentOperations1 : assertion : elapsed 1055
 Zookeeper_init::testBasic : elapsed 1 : OK
 Zookeeper_init::testAddressResolution : elapsed 0 : OK
 Zookeeper_init::testMultipleAddressResolution : elapsed 0 : OK
 Zookeeper_init::testNullAddressString : elapsed 0 : OK
 Zookeeper_init::testEmptyAddressString : elapsed 0 : OK
 Zookeeper_init::testOneSpaceAddressString : elapsed 0 : OK
 Zookeeper_init::testTwoSpacesAddressString : elapsed 0 : OK
 Zookeeper_init::testInvalidAddressString1 : elapsed 0 : OK
 Zookeeper_init::testInvalidAddressString2 : elapsed 175 : OK
 Zookeeper_init::testNonexistentHost : elapsed 92 : OK
 Zookeeper_init::testOutOfMemory_init : elapsed 0 : OK
 Zookeeper_init::testOutOfMemory_getaddrs1 : elapsed 0 : OK
 Zookeeper_init::testOutOfMemory_getaddrs2 : elapsed 1 : OK
 Zookeeper_init::testPermuteAddrsList : elapsed 0 : OK
 Zookeeper_close::testIOThreadStoppedOnExpire : assertion : elapsed 1056
 Zookeeper_close::testCloseUnconnected : elapsed 0 : OK
 Zookeeper_close::testCloseUnconnected1 : elapsed 91 : OK
 Zookeeper_close::testCloseConnected1 : assertion : elapsed 1056
 Zookeeper_close::testCloseFromWatcher1 : assertion : elapsed 1076
 Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server started : 
 elapsed 12155 : OK
 Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK
 Zookeeper_simpleSystem::testNullData : elapsed 1031 : OK
 Zookeeper_simpleSystem::testIPV6 : elapsed 1005 : OK
 Zookeeper_simpleSystem::testPath : elapsed 1024 : OK
 Zookeeper_simpleSystem::testPathValidation : elapsed 1053 : OK
 Zookeeper_simpleSystem::testPing : elapsed 17287 : OK
 Zookeeper_simpleSystem::testAcl : elapsed 1019 : OK
 Zookeeper_simpleSystem::testChroot : elapsed 3052 : OK
 Zookeeper_simpleSystem::testAuth : assertion : elapsed 7010
 Zookeeper_simpleSystem::testHangingClient : elapsed 1015 : OK
 Zookeeper_simpleSystem::testWatcherAutoResetWithGlobal ZooKeeper server 
 started ZooKeeper server started ZooKeeper server started : elapsed 20556 : OK
 Zookeeper_simpleSystem::testWatcherAutoResetWithLocal ZooKeeper server 
 started ZooKeeper server started ZooKeeper server started : elapsed 20563 : OK
 Zookeeper_simpleSystem::testGetChildren2 : elapsed 1041 : OK
 Zookeeper_multi::testCreate : elapsed 1017 : OK
 Zookeeper_multi::testCreateDelete : elapsed 1007 : OK
 Zookeeper_multi::testInvalidVersion : elapsed 1011 : OK
 Zookeeper_multi::testNestedCreate : elapsed 1009 : OK
 Zookeeper_multi::testSetData : elapsed 6019 : OK
 Zookeeper_multi::testUpdateConflict : elapsed 1014 : OK
 Zookeeper_multi::testDeleteUpdateConflict : elapsed 1007 : OK
 Zookeeper_multi::testAsyncMulti : elapsed 2001 : OK
 Zookeeper_multi::testMultiFail : elapsed 1006 : OK
 Zookeeper_multi::testCheck : elapsed 1020 : OK
 Zookeeper_multi::testWatch : elapsed 2013 : OK
 Zookeeper_watchers::testDefaultSessionWatcher1zktest-mt: 
 tests/ZKMocks.cc:271: SyncedBoolCondition 
 DeliverWatchersWrapper::isDelivered() const: Assertion `i1000' failed.
 Aborted (core dumped)
 It would appear that the zookeeper connection does not transition to 
 connected within the required time; I increased the time allowed but no 
 change.
 Ubuntu raring has glibc 2.17; the test suite works fine on previous Ubuntu 
 releases and this is the only difference that stood out.
 Interestingly the cli_mt worked just fine connecting to the same zookeeper 
 instance that the tests left lying around so I'm assuming this is a test 
 error rather than an actual bug.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (ZOOKEEPER-1663) scripts don't work when path contains spaces


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-1663:


Assignee: Amichai Rothman

 scripts don't work when path contains spaces
 

 Key: ZOOKEEPER-1663
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1663
 Project: ZooKeeper
  Issue Type: Bug
  Components: scripts
Affects Versions: 3.4.5
 Environment: Kubuntu 12.10 (GNU bash 4.2.37)
Reporter: Amichai Rothman
Assignee: Amichai Rothman
Priority: Minor
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1663-ls.trunk.patch, ZOOKEEPER-1663.patch, 
 ZOOKEEPER-1663.trunk.patch, ZOOKEEPER-1663.trunk.patch


 The shell scripts (bin/zk*.sh) don't work when there are spaces in the 
 zookeeper or java paths.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1597) Windows build failing


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794647#comment-13794647
 ] 

Patrick Hunt commented on ZOOKEEPER-1597:
-

Not supported. Just commit the change and we'll roll the dice. ;-)

 Windows build failing
 -

 Key: ZOOKEEPER-1597
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1597
 Project: ZooKeeper
  Issue Type: Bug
  Components: build, c client
Affects Versions: 3.5.0
Reporter: Alexander Shraer
Assignee: Michi Mutsuzaki
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1597-3.4.patch, ZOOKEEPER-1597.patch, 
 ZOOKEEPER-1597.patch, ZOOKEEPER-1597.patch


 Seems to be related to C client changes done for ZK-1355.
 We're not sure why these build failures happen on Windows.
 ###
 ## LAST 60 LINES OF THE CONSOLE 
 ###
 [...truncated 376 lines...]
   .\src\zookeeper.c(768): error C2224: left of '.count' must have 
 struct/union type
   .\src\zookeeper.c(768): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(770): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(770): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(770): error C2065: 'i' : undeclared identifier
   .\src\zookeeper.c(773): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(774): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(780): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(781): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(788): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(789): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(792): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(792): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(794): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(797): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(814): error C2065: 'found_current' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_new' : undeclared identifier
   .\src\zookeeper.c(819): error C2065: 'num_old' : undeclared identifier
   .\src\zookeeper.c(825): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(825): error C2440: '=' : cannot convert from 'int' to 
 'addrvec_t'
   .\src\zookeeper.c(843): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(843): error C2224: left of '.data' must have struct/union 
 type
   .\src\zookeeper.c(845): error C2065: 'resolved' : undeclared identifier
   .\src\zookeeper.c(848): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(849): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(850): error C2065: 'hosts' : undeclared identifier
   .\src\zookeeper.c(853): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1177): error C2143: syntax error : missing ';' before 
 'const'
   .\src\zookeeper.c(1179): error C2065: 'endpoint_info' : undeclared 
 identifier
   .\src\zookeeper.c(1883): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1884): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1885): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1916): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1920): error C2143: syntax error : missing ';' before 
 'type'
   .\src\zookeeper.c(1927): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1927): error C2065: 'enable_tcp_nodelay' : undeclared 
 identifier
   .\src\zookeeper.c(1928): error C2065: 'ssoresult' : undeclared identifier
   .\src\zookeeper.c(1944): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1949): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1962): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(1963): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): error C2065: 'rc' : undeclared identifier
   .\src\zookeeper.c(2004): fatal error C1003: error count exceeds 100; 
 stopping compilation
 38 Warning(s)
 102 Error(s)



--
This message was sent by Atlassian JIRA

[jira] [Resolved] (ZOOKEEPER-988) ZK server hang on leader election


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-988.


Resolution: Incomplete

 ZK server hang on leader election
 -

 Key: ZOOKEEPER-988
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-988
 Project: ZooKeeper
  Issue Type: Bug
  Components: leaderElection
Affects Versions: 3.3.2
Reporter: Xiaowei Jiang

 org.apache.zookeeper.server.quorum.QuorumCnxManager$SendWorker.run thread 
 exited unexpected, so the server hang on leader election.
 QuorumPeer:/0.0.0.0:2181:
  [1] sun.misc.Unsafe.park (native method)
  [2] java.util.concurrent.locks.LockSupport.parkNanos (LockSupport.java:198)
  [3] 
 java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos
  (AbstractQueuedSynchronizer.java:1,963)
  [4] java.util.concurrent.LinkedBlockingQueue.poll 
 (LinkedBlockingQueue.java:395)
  [5] org.apache.zookeeper.server.quorum.FastLeaderElection.lookForLeader 
 (FastLeaderElection.java:677)
  [6] org.apache.zookeeper.server.quorum.QuorumPeer.run (QuorumPeer.java:621)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (ZOOKEEPER-1796) Move common code from {Follower, Observer}ZooKeeperServer into LearnerZooKeeperServer

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794679#comment-13794679
]

Hadoop QA commented on ZOOKEEPER-1796:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12608367/ZOOKEEPER-1796.patch
against trunk revision 1531444.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1696//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1696//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1696//console

This message is automatically generated.

Move common code from {Follower, Observer}ZooKeeperServer into
LearnerZooKeeperServer
-

Key: ZOOKEEPER-1796
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1796
Project: ZooKeeper
Issue Type: Improvement
Reporter: Raul Gutierrez Segales
Priority: Trivial
Fix For: 3.5.0

Attachments: ZOOKEEPER-1796.patch

Since ZOOKEEPER-1552 we are enabling syncProcessor in Observers, so we should
have a proper shutdown() method there. Since FollowerZooKeeperServer already
has one, which does the same thing that we need, move that to
LearnerZooKeeperServer along with some related instance variables.

--
This message was sent by Atlassian JIRA
(v6.1#6144)

Failed: ZOOKEEPER-1796 PreCommit Build #1696

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1796
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1696/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 309220 lines...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12608367/ZOOKEEPER-1796.patch
 [exec]   against trunk revision 1531444.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1696//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1696//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1696//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 4cd403896447c184a7d0da6f8f42ac3bc206426f logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 1

Total time: 32 minutes 46 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1796
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Updated] (ZOOKEEPER-1783) Distinguish initial configuration from first established configuration

2013-10-14 Thread Alexander Shraer (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Shraer updated ZOOKEEPER-1783:


Attachment: ZOOKEEPER-1783-ver7.patch

Added a long comment in Leader.java about why we're doing what we're doing 
there, removed some tabs, and changed the check version  0 to version == 
0x1L in ReconfigTest.

 Distinguish initial configuration from first established configuration
 --

 Key: ZOOKEEPER-1783
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1783
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum, server
Affects Versions: 3.5.0
Reporter: Alexander Shraer
Assignee: Alexander Shraer
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1783.patch, ZOOKEEPER-1783-ver1.patch, 
 ZOOKEEPER-1783-ver2.patch, ZOOKEEPER-1783-ver3.patch, 
 ZOOKEEPER-1783-ver4.patch, ZOOKEEPER-1783-ver5.patch, 
 ZOOKEEPER-1783-ver6.patch, ZOOKEEPER-1783-ver7.patch


 We need a way to distinguish an initial config of a server and an initial 
 config of a running ensemble (before any reconfigs happen). Currently both 
 have version 0. 
 The version of a config increases with each reconfiguration, so the problem 
 is just with the initial config.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (BOOKKEEPER-664) Compaction increases latency on journal writes

2013-10-14 Thread Ivan Kelly (JIRA)


 [ 
https://issues.apache.org/jira/browse/BOOKKEEPER-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Kelly updated BOOKKEEPER-664:
--

Attachment: 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ.patch

New patch applies to trunk.

 Compaction increases latency on journal writes
 --

 Key: BOOKKEEPER-664
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-664
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-server
Affects Versions: 4.2.1
Reporter: Ivan Kelly
Assignee: Ivan Kelly
 Fix For: 4.2.2, 4.3.0

 Attachments: 
 0001-BOOKKEEPER-664-branch-4.2-Compaction-increases-laten.patch, 
 0001-BOOKKEEPER-664-branch-4.2-Compaction-increases-laten.patch, 
 0001-BOOKKEEPER-664-branch-4.2-Compaction-increases-laten.patch, 
 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ_branch4.2.patch, 
 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ-branch-4.2.patch, 
 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ.patch, 
 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ.patch, 
 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ_trunk.patch, 
 0002-BOOKKEEPER-664-trunk-Compaction-increases-latency-on.patch, bench.png, 
 BOOKKEEPER-664.patch


 Compaction writes to the journal to avoid data loss (see BOOKKEEPER-530). 
 BOOKKEEPER-530 correctly identified that this may affect latency on the 
 journal but we have observed this since in production. It is possible to 
 avoid the journal completely, as twitter do in their github branch. 
 Basically, we need to write to the entrylogger first, flush the entry log and 
 then add to the index.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (BOOKKEEPER-664) Compaction increases latency on journal writes


[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794128#comment-13794128
 ] 

Hadoop QA commented on BOOKKEEPER-664:
--

Testing JIRA BOOKKEEPER-664


Patch 
[0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ.patch|https://issues.apache.org/jira/secure/attachment/12608280/0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ.patch]
 downloaded at Mon Oct 14 14:02:00 UTC 2013



{color:red}-1{color} Patch failed to apply to head of branch



 Compaction increases latency on journal writes
 --

 Key: BOOKKEEPER-664
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-664
 Project: Bookkeeper
  Issue Type: Bug
  Components: bookkeeper-server
Affects Versions: 4.2.1
Reporter: Ivan Kelly
Assignee: Ivan Kelly
 Fix For: 4.2.2, 4.3.0

 Attachments: 
 0001-BOOKKEEPER-664-branch-4.2-Compaction-increases-laten.patch, 
 0001-BOOKKEEPER-664-branch-4.2-Compaction-increases-laten.patch, 
 0001-BOOKKEEPER-664-branch-4.2-Compaction-increases-laten.patch, 
 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ_branch4.2.patch, 
 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ-branch-4.2.patch, 
 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ.patch, 
 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ.patch, 
 0001-BOOKKEEPER-664-Compaction-increases-latency-on-journ_trunk.patch, 
 0002-BOOKKEEPER-664-trunk-Compaction-increases-latency-on.patch, bench.png, 
 BOOKKEEPER-664.patch


 Compaction writes to the journal to avoid data loss (see BOOKKEEPER-530). 
 BOOKKEEPER-530 correctly identified that this may affect latency on the 
 journal but we have observed this since in production. It is possible to 
 avoid the journal completely, as twitter do in their github branch. 
 Basically, we need to write to the entrylogger first, flush the entry log and 
 then add to the index.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (BOOKKEEPER-659) LRU page management in ledger cache.

2013-10-14 Thread Ivan Kelly (JIRA)


 [ 
https://issues.apache.org/jira/browse/BOOKKEEPER-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Kelly updated BOOKKEEPER-659:
--

Attachment: 
TEST-org.apache.bookkeeper.replication.AuditorPeriodicCheckTest.xml

Still getting the error on the same test. Could be something to do with the 
synchronization around useCount, though isn't quite clear to me.

 LRU page management in ledger cache.
 

 Key: BOOKKEEPER-659
 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-659
 Project: Bookkeeper
  Issue Type: Sub-task
  Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Robin Dhamankar
 Fix For: 4.3.0

 Attachments: 
 0001-BOOKKEEPER-659-LRU-page-management-in-ledger-cache.patch, 
 BOOKKEEPER-659.diff, BOOKKEEPER-659.diff, 
 TEST-org.apache.bookkeeper.replication.AuditorPeriodicCheckTest.xml, 
 TEST-org.apache.bookkeeper.replication.AuditorPeriodicCheckTest.xml


 better ledger page management.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (BOOKKEEPER-664) Compaction increases latency on journal writes