[jira] [Commented] (ZOOKEEPER-1179) NettyServerCnxn does not properly close socket on 4 letter word requests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855504#comment-13855504 ] Rakesh R commented on ZOOKEEPER-1179: - Yeah German, I understood your thoughts. Now only the possibility of occuring the case is in NettyServerCnxn#sendBuffer, where it directly closing the channel reference. As you told earlier, this should be replaced with NettyServerCnxn.close(). NettyServerCnxn does not properly close socket on 4 letter word requests Key: ZOOKEEPER-1179 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1179 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.0 Reporter: Camille Fournier Assignee: Rakesh R Priority: Critical Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1179.patch When calling a 4-letter-word to a server configured to use NettyServerCnxnFactory, the factory will not properly cancel all the keys and close the socket after sending the response for the 4lw. The close request will throw this exception, and the thread will not shut down: 2011-09-13 12:14:17,546 - WARN [New I/O server worker #1-1:NettyServerCnxnFactory$CnxnChannelHandler@117] - Exception caught [id: 0x009300cc, /1.1.1.1:38542 = /139.172.114.138:2181] EXCEPTION: java.io.IOException: A non-blocking socket operation could not be completed immediately java.io.IOException: A non-blocking socket operation could not be completed immediately at sun.nio.ch.SocketDispatcher.close0(Native Method) at sun.nio.ch.SocketDispatcher.preClose(SocketDispatcher.java:44) at sun.nio.ch.SocketChannelImpl.implCloseSelectableChannel(SocketChannelImpl.java:684) at java.nio.channels.spi.AbstractSelectableChannel.implCloseChannel(AbstractSelectableChannel.java:201) at java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:97) at org.jboss.netty.channel.socket.nio.NioWorker.close(NioWorker.java:593) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.handleAcceptedSocket(NioServerSocketPipelineSink.java:119) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.eventSunk(NioServerSocketPipelineSink.java:76) at org.jboss.netty.channel.Channels.close(Channels.java:720) at org.jboss.netty.channel.AbstractChannel.close(AbstractChannel.java:208) at org.apache.zookeeper.server.NettyServerCnxn.close(NettyServerCnxn.java:116) at org.apache.zookeeper.server.NettyServerCnxn.cleanupWriterSocket(NettyServerCnxn.java:241) at org.apache.zookeeper.server.NettyServerCnxn.access$0(NettyServerCnxn.java:231) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.run(NettyServerCnxn.java:314) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.start(NettyServerCnxn.java:305) at org.apache.zookeeper.server.NettyServerCnxn.checkFourLetterWord(NettyServerCnxn.java:674) at org.apache.zookeeper.server.NettyServerCnxn.receiveMessage(NettyServerCnxn.java:791) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.processMessage(NettyServerCnxnFactory.java:217) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.messageReceived(NettyServerCnxnFactory.java:141) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:350) at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:281) at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:201) at org.jboss.netty.util.internal.IoWorkerRunnable.run(IoWorkerRunnable.java:46) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
ZooKeeper-trunk-solaris - Build # 769 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/769/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 217147 lines...] [junit] 2013-12-23 09:06:05,077 [myid:] - INFO [main:SessionTrackerImpl@183] - Shutting down [junit] 2013-12-23 09:06:05,077 [myid:] - INFO [main:PrepRequestProcessor@972] - Shutting down [junit] 2013-12-23 09:06:05,077 [myid:] - INFO [main:SyncRequestProcessor@190] - Shutting down [junit] 2013-12-23 09:06:05,077 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop! [junit] 2013-12-23 09:06:05,078 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@168] - SyncRequestProcessor exited! [junit] 2013-12-23 09:06:05,078 [myid:] - INFO [main:FinalRequestProcessor@442] - shutdown of request processor complete [junit] 2013-12-23 09:06:05,079 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-12-23 09:06:05,079 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-12-23 09:06:05,080 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-12-23 09:06:05,080 [myid:] - INFO [main:ZooKeeperServer@149] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8097120243456633464.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8097120243456633464.junit.dir/version-2 [junit] 2013-12-23 09:06:05,081 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2013-12-23 09:06:05,081 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-12-23 09:06:05,083 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8097120243456633464.junit.dir/version-2/snapshot.b [junit] 2013-12-23 09:06:05,085 [myid:] - INFO [main:FileTxnSnapLog@297] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8097120243456633464.junit.dir/version-2/snapshot.b [junit] 2013-12-23 09:06:05,087 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-12-23 09:06:05,087 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:38467 [junit] 2013-12-23 09:06:05,088 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from /127.0.0.1:38467 [junit] 2013-12-23 09:06:05,088 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output [junit] 2013-12-23 09:06:05,089 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client /127.0.0.1:38467 (no session established for client) [junit] 2013-12-23 09:06:05,089 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-12-23 09:06:05,090 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-12-23 09:06:05,091 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-12-23 09:06:05,091 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-12-23 09:06:05,091 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-12-23 09:06:05,091 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 13346 [junit] 2013-12-23 09:06:05,091 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 24 [junit] 2013-12-23 09:06:05,092 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota [junit] 2013-12-23 09:06:05,092 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-12-23 09:06:05,162 [myid:] - INFO [main:ZooKeeper@777] - Session: 0x1431eb435a3 closed [junit] 2013-12-23 09:06:05,162 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down [junit] 2013-12-23 09:06:05,162 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-12-23 09:06:05,163 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@219] -
ZooKeeper-3.4-WinVS2008_java - Build # 388 - Still Failing
See https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/388/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 189367 lines...] [junit] 2013-12-23 09:25:41,655 [myid:] - INFO [main:JMXEnv@135] - ensureOnly:[] [junit] 2013-12-23 09:25:41,656 [myid:] - INFO [main:ClientBase@413] - STARTING server [junit] 2013-12-23 09:25:41,656 [myid:] - INFO [main:ZooKeeperServer@162] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test2466951176430864432.junit.dir\version-2 snapdir f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test2466951176430864432.junit.dir\version-2 [junit] 2013-12-23 09:25:41,657 [myid:] - INFO [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-12-23 09:25:41,660 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-12-23 09:25:41,661 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - Accepted socket connection from /127.0.0.1:53983 [junit] 2013-12-23 09:25:41,661 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing stat command from /127.0.0.1:53983 [junit] 2013-12-23 09:25:41,662 [myid:] - INFO [Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output [junit] 2013-12-23 09:25:41,662 [myid:] - INFO [Thread-4:NIOServerCnxn@1007] - Closed socket connection for client /127.0.0.1:53983 (no session established for client) [junit] 2013-12-23 09:25:41,662 [myid:] - INFO [main:JMXEnv@135] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-12-23 09:25:41,664 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-12-23 09:25:41,664 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-12-23 09:25:41,664 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-12-23 09:25:41,664 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-12-23 09:25:41,667 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 10591 [junit] 2013-12-23 09:25:41,667 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 21 [junit] 2013-12-23 09:25:41,667 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota [junit] 2013-12-23 09:25:41,667 [myid:] - INFO [main:ClientBase@450] - tearDown starting [junit] 2013-12-23 09:25:41,763 [myid:] - INFO [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@849] - Socket connection established to 127.0.0.1/127.0.0.1:11221, initiating session [junit] 2013-12-23 09:25:41,763 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - Accepted socket connection from /127.0.0.1:53980 [junit] 2013-12-23 09:25:41,763 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:ZooKeeperServer@861] - Client attempting to renew session 0x1431ec627ec at /127.0.0.1:53980 [junit] 2013-12-23 09:25:41,764 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:ZooKeeperServer@617] - Established session 0x1431ec627ec with negotiated timeout 3 for client /127.0.0.1:53980 [junit] 2013-12-23 09:25:41,764 [myid:] - INFO [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1228] - Session establishment complete on server 127.0.0.1/127.0.0.1:11221, sessionid = 0x1431ec627ec, negotiated timeout = 3 [junit] 2013-12-23 09:25:41,764 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@494] - Processed session termination for sessionid: 0x1431ec627ec [junit] 2013-12-23 09:25:41,765 [myid:] - INFO [SyncThread:0:FileTxnLog@199] - Creating new log file: log.c [junit] 2013-12-23 09:25:41,776 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x1431ec627ec closed [junit] 2013-12-23 09:25:41,776 [myid:] - INFO [main:ClientBase@420] - STOPPING server [junit] 2013-12-23 09:25:41,776 [myid:] - WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@357] - caught end of stream exception [junit] EndOfStreamException: Unable to read additional data from client sessionid 0x1431ec627ec, likely client has closed socket [junit] at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228) [junit] at org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208) [junit] at java.lang.Thread.run(Thread.java:722) [junit] 2013-12-23
[jira] [Commented] (ZOOKEEPER-1835) dynamic configuration file renaming fails on Windows
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855521#comment-13855521
]
Bruno Freudensprung commented on ZOOKEEPER-1835:
Before explaining the latest patch, let me summarize its content:
- I created a new AtomicFileWritingIdiom...
- reusing the existing AtomicFileOutputStream class,
- inspired by the way the writeLongToFile method of QuorumPeer is using it,
- ... and used this new AtomicFileWritingIdiom class in the writeDynamicConfig
method of QuorumPeerConfig
It took me some time to understand what was going wrong in QuorumPeerMainTest
and ObserverHierarchicalQuorumTest unit tests with my second patch.
During my investigations I discovered strange stack traces in the junit reports
of the (unpatched) trunk, related to AtomicFileOutputStream :
{code}
java.nio.channels.ClosedByInterruptException
at
java.nio.channels.spi.AbstractInterruptibleChannel.end(AbstractInterruptibleChannel.java:202)
at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:380)
at
org.apache.zookeeper.common.AtomicFileOutputStream.close(AtomicFileOutputStream.java:71)
at
org.apache.zookeeper.server.quorum.QuorumPeer.writeLongToFile(QuorumPeer.java:1499)
at
org.apache.zookeeper.server.quorum.QuorumPeer.setCurrentEpoch(QuorumPeer.java:1520)
at org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:523)
at
org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:980)
{code}
They occur in:
{code}
TEST-org.apache.zookeeper.server.quorum.Zab1_0Test.txt
TEST-org.apache.zookeeper.test.ObserverHierarchicalQuorumTest.txt
TEST-org.apache.zookeeper.test.ReadOnlyModeTest.txt
{code}
There seems to be a problem with the force(true) call on the FileChannel. I
don't know why to be honnest (maybe related to the threading model of
zookeeper).
If I simply remove this line (on the unpatched trunk),
ClosedByInterruptExceptions disappeared but I observed the same unit test
regressions in QuorumPeerMainTest as with my second patch.
However when I replaced:
{code:java}
((FileOutputStream) out).getChannel().force(true);
{code}
with:
{code:java}
((FileOutputStream) out).getFD().sync();
{code}
then there was no ClosedByInterruptException in the report, and no unit test
regression.
And if I apply my patch (the third one, including this modification), there is
no unit test regression neither (latest Hadoop QA result).
It seems that both fc.force() and fd.sync() have the same effect of flushing
data on the device:
http://stackoverflow.com/questions/5650327/are-filechannel-force-and-filedescriptor-sync-both-needed
I've tested the ZOOKEEPER-1691 patch in addition to this new one and the
configBackwardCompatibilityMode scenario. Both are still working.
dynamic configuration file renaming fails on Windows
Key: ZOOKEEPER-1835
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1835
Project: ZooKeeper
Issue Type: Bug
Components: quorum
Affects Versions: 3.5.0
Environment: Windows 7 64-bit, Oracle Java 1.6.0_32-b05
Reporter: Bruno Freudensprung
Assignee: Bruno Freudensprung
Fix For: 3.5.0
Attachments: ZOOKEEPER-1835.patch, ZOOKEEPER-1835.patch,
ZOOKEEPER-1835.patch
On Windows, reconfig fails to rename the tmp dynamic config file to the real
dynamic config filename.
Javadoc of java.io.File.renameTo says the behavior is highly plateform
dependent, so I guess this should not be a big surprise.
The problem occurs in
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java that
could be modified like this:
+ curFile.delete();
if (!tmpFile.renameTo(curFile)) {
+ configFile.delete();
if (!tmpFile.renameTo(configFile)) {
As suggested by Alex in https://issues.apache.org/jira/browse/ZOOKEEPER-1691
(btw there is more information about my test scenario over there) it is a bit
scary to delete the current configuration file.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
ZooKeeper-trunk-WinVS2008_java - Build # 634 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/634/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 229585 lines...] [junit] 2013-12-23 09:51:57,000 [myid:] - INFO [SessionTracker:SessionTrackerImpl@134] - SessionTrackerImpl exited loop! [junit] 2013-12-23 09:51:57,000 [myid:] - INFO [SessionTracker:SessionTrackerImpl@134] - SessionTrackerImpl exited loop! [junit] 2013-12-23 09:51:57,295 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-12-23 09:51:57,296 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-12-23 09:51:57,296 [myid:] - INFO [main:ZooKeeperServer@149] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test7692598752053709068.junit.dir\version-2 snapdir f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test7692598752053709068.junit.dir\version-2 [junit] 2013-12-23 09:51:57,297 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 1 selector thread(s), 4 worker threads, and 64 kB direct buffers. [junit] 2013-12-23 09:51:57,298 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-12-23 09:51:57,299 [myid:] - INFO [main:FileSnap@83] - Reading snapshot f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test7692598752053709068.junit.dir\version-2\snapshot.b [junit] 2013-12-23 09:51:57,301 [myid:] - INFO [main:FileTxnSnapLog@297] - Snapshotting: 0xb to f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test7692598752053709068.junit.dir\version-2\snapshot.b [junit] 2013-12-23 09:51:57,303 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-12-23 09:51:57,304 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:57263 [junit] 2013-12-23 09:51:57,304 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from /127.0.0.1:57263 [junit] 2013-12-23 09:51:57,304 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output [junit] 2013-12-23 09:51:57,304 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client /127.0.0.1:57263 (no session established for client) [junit] 2013-12-23 09:51:57,304 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-12-23 09:51:57,306 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-12-23 09:51:57,306 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-12-23 09:51:57,306 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-12-23 09:51:57,306 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-12-23 09:51:57,306 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 13408 [junit] 2013-12-23 09:51:57,307 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 22 [junit] 2013-12-23 09:51:57,307 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota [junit] 2013-12-23 09:51:57,307 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-12-23 09:51:57,332 [myid:] - INFO [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1008] - Opening socket connection to server 127.0.0.1/127.0.0.1:11221. Will not attempt to authenticate using SASL (unknown error) [junit] 2013-12-23 09:51:57,332 [myid:] - INFO [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@882] - Socket connection established to 127.0.0.1/127.0.0.1:11221, initiating session [junit] 2013-12-23 09:51:57,332 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:57264 [junit] 2013-12-23 09:51:57,333 [myid:] - INFO [NIOWorkerThread-2:ZooKeeperServer@858] - Client attempting to renew session 0x1431ede3206 at /127.0.0.1:57264 [junit] 2013-12-23 09:51:57,334 [myid:] - INFO [NIOWorkerThread-2:ZooKeeperServer@604] - Established session 0x1431ede3206 with negotiated timeout 3 for client /127.0.0.1:57264 [junit] 2013-12-23 09:51:57,335 [myid:] - INFO [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1261] -
ZooKeeper-trunk-openjdk7 - Build # 339 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/339/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 425 lines...] Caused by: org.tmatesoft.svn.core.SVNException: svn: E175002: OPTIONS /repos/asf/zookeeper/trunk failed at org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection.request(HTTPConnection.java:388) at org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection.request(HTTPConnection.java:373) at org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection.request(HTTPConnection.java:361) at org.tmatesoft.svn.core.internal.io.dav.DAVConnection.performHttpRequest(DAVConnection.java:707) at org.tmatesoft.svn.core.internal.io.dav.DAVConnection.exchangeCapabilities(DAVConnection.java:627) at org.tmatesoft.svn.core.internal.io.dav.DAVConnection.open(DAVConnection.java:102) at org.tmatesoft.svn.core.internal.io.dav.DAVRepository.openConnection(DAVRepository.java:1020) at org.tmatesoft.svn.core.internal.io.dav.DAVRepository.getRepositoryUUID(DAVRepository.java:148) at org.tmatesoft.svn.core.internal.wc16.SVNBasicDelegate.createRepository(SVNBasicDelegate.java:339) at org.tmatesoft.svn.core.internal.wc16.SVNBasicDelegate.createRepository(SVNBasicDelegate.java:328) at org.tmatesoft.svn.core.internal.wc16.SVNUpdateClient16.update(SVNUpdateClient16.java:482) at org.tmatesoft.svn.core.internal.wc16.SVNUpdateClient16.doUpdate(SVNUpdateClient16.java:364) at org.tmatesoft.svn.core.internal.wc16.SVNUpdateClient16.doUpdate(SVNUpdateClient16.java:274) at org.tmatesoft.svn.core.internal.wc2.old.SvnOldUpdate.run(SvnOldUpdate.java:27) at org.tmatesoft.svn.core.internal.wc2.old.SvnOldUpdate.run(SvnOldUpdate.java:11) at org.tmatesoft.svn.core.internal.wc2.SvnOperationRunner.run(SvnOperationRunner.java:20) at org.tmatesoft.svn.core.wc2.SvnOperationFactory.run(SvnOperationFactory.java:1238) at org.tmatesoft.svn.core.wc2.SvnOperation.run(SvnOperation.java:294) at org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:311) at org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:291) at org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:387) at hudson.scm.subversion.UpdateUpdater$TaskImpl.perform(UpdateUpdater.java:157) ... 14 more Caused by: svn: E175002: OPTIONS /repos/asf/zookeeper/trunk failed at org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:208) at org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:154) at org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:97) ... 36 more Caused by: org.tmatesoft.svn.core.SVNException: svn: E175002: OPTIONS request failed on '/repos/asf/zookeeper/trunk' svn: E175002: timed out waiting for server at org.tmatesoft.svn.core.internal.wc.SVNErrorManager.error(SVNErrorManager.java:64) at org.tmatesoft.svn.core.internal.wc.SVNErrorManager.error(SVNErrorManager.java:51) at org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection._request(HTTPConnection.java:777) at org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection.request(HTTPConnection.java:382) ... 35 more Caused by: svn: E175002: OPTIONS request failed on '/repos/asf/zookeeper/trunk' at org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:208) at org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection._request(HTTPConnection.java:775) ... 36 more Caused by: svn: E175002: timed out waiting for server at org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:208) at org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection._request(HTTPConnection.java:514) ... 36 more Caused by: java.net.SocketTimeoutException: connect timed out at java.net.PlainSocketImpl.socketConnect(Native Method) at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:327) at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:193) at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:180) at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:385) at java.net.Socket.connect(Socket.java:546) at org.tmatesoft.svn.core.internal.util.SVNSocketFactory.connect(SVNSocketFactory.java:146) at org.tmatesoft.svn.core.internal.util.SVNSocketFactory.createPlainSocket(SVNSocketFactory.java:73) at org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection.connect(HTTPConnection.java:280) at org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection._request(HTTPConnection.java:451) ... 36 more
[jira] [Updated] (ZOOKEEPER-1179) NettyServerCnxn does not properly close socket on 4 letter word requests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-1179: - Attachment: ZOOKEEPER-1179.patch Proposing the patch is not a problem. Adding a test case is not that easy at all, at least for me. NettyServerCnxn does not properly close socket on 4 letter word requests Key: ZOOKEEPER-1179 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1179 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.0 Reporter: Camille Fournier Assignee: Rakesh R Priority: Critical Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1179.patch, ZOOKEEPER-1179.patch When calling a 4-letter-word to a server configured to use NettyServerCnxnFactory, the factory will not properly cancel all the keys and close the socket after sending the response for the 4lw. The close request will throw this exception, and the thread will not shut down: 2011-09-13 12:14:17,546 - WARN [New I/O server worker #1-1:NettyServerCnxnFactory$CnxnChannelHandler@117] - Exception caught [id: 0x009300cc, /1.1.1.1:38542 = /139.172.114.138:2181] EXCEPTION: java.io.IOException: A non-blocking socket operation could not be completed immediately java.io.IOException: A non-blocking socket operation could not be completed immediately at sun.nio.ch.SocketDispatcher.close0(Native Method) at sun.nio.ch.SocketDispatcher.preClose(SocketDispatcher.java:44) at sun.nio.ch.SocketChannelImpl.implCloseSelectableChannel(SocketChannelImpl.java:684) at java.nio.channels.spi.AbstractSelectableChannel.implCloseChannel(AbstractSelectableChannel.java:201) at java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:97) at org.jboss.netty.channel.socket.nio.NioWorker.close(NioWorker.java:593) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.handleAcceptedSocket(NioServerSocketPipelineSink.java:119) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.eventSunk(NioServerSocketPipelineSink.java:76) at org.jboss.netty.channel.Channels.close(Channels.java:720) at org.jboss.netty.channel.AbstractChannel.close(AbstractChannel.java:208) at org.apache.zookeeper.server.NettyServerCnxn.close(NettyServerCnxn.java:116) at org.apache.zookeeper.server.NettyServerCnxn.cleanupWriterSocket(NettyServerCnxn.java:241) at org.apache.zookeeper.server.NettyServerCnxn.access$0(NettyServerCnxn.java:231) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.run(NettyServerCnxn.java:314) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.start(NettyServerCnxn.java:305) at org.apache.zookeeper.server.NettyServerCnxn.checkFourLetterWord(NettyServerCnxn.java:674) at org.apache.zookeeper.server.NettyServerCnxn.receiveMessage(NettyServerCnxn.java:791) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.processMessage(NettyServerCnxnFactory.java:217) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.messageReceived(NettyServerCnxnFactory.java:141) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:350) at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:281) at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:201) at org.jboss.netty.util.internal.IoWorkerRunnable.run(IoWorkerRunnable.java:46) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ZOOKEEPER-1179) NettyServerCnxn does not properly close socket on 4 letter word requests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855904#comment-13855904 ] Flavio Junqueira commented on ZOOKEEPER-1179: - Let's try to think of a test case, and if we can't come up with anything that is reasonable, I'll +1 it without the test. Testing races is often difficult, so I'm not surprised that there is no obvious way. Perhaps someone else has an idea for how to do it, though. NettyServerCnxn does not properly close socket on 4 letter word requests Key: ZOOKEEPER-1179 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1179 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.0 Reporter: Camille Fournier Assignee: Rakesh R Priority: Critical Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1179.patch, ZOOKEEPER-1179.patch When calling a 4-letter-word to a server configured to use NettyServerCnxnFactory, the factory will not properly cancel all the keys and close the socket after sending the response for the 4lw. The close request will throw this exception, and the thread will not shut down: 2011-09-13 12:14:17,546 - WARN [New I/O server worker #1-1:NettyServerCnxnFactory$CnxnChannelHandler@117] - Exception caught [id: 0x009300cc, /1.1.1.1:38542 = /139.172.114.138:2181] EXCEPTION: java.io.IOException: A non-blocking socket operation could not be completed immediately java.io.IOException: A non-blocking socket operation could not be completed immediately at sun.nio.ch.SocketDispatcher.close0(Native Method) at sun.nio.ch.SocketDispatcher.preClose(SocketDispatcher.java:44) at sun.nio.ch.SocketChannelImpl.implCloseSelectableChannel(SocketChannelImpl.java:684) at java.nio.channels.spi.AbstractSelectableChannel.implCloseChannel(AbstractSelectableChannel.java:201) at java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:97) at org.jboss.netty.channel.socket.nio.NioWorker.close(NioWorker.java:593) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.handleAcceptedSocket(NioServerSocketPipelineSink.java:119) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.eventSunk(NioServerSocketPipelineSink.java:76) at org.jboss.netty.channel.Channels.close(Channels.java:720) at org.jboss.netty.channel.AbstractChannel.close(AbstractChannel.java:208) at org.apache.zookeeper.server.NettyServerCnxn.close(NettyServerCnxn.java:116) at org.apache.zookeeper.server.NettyServerCnxn.cleanupWriterSocket(NettyServerCnxn.java:241) at org.apache.zookeeper.server.NettyServerCnxn.access$0(NettyServerCnxn.java:231) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.run(NettyServerCnxn.java:314) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.start(NettyServerCnxn.java:305) at org.apache.zookeeper.server.NettyServerCnxn.checkFourLetterWord(NettyServerCnxn.java:674) at org.apache.zookeeper.server.NettyServerCnxn.receiveMessage(NettyServerCnxn.java:791) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.processMessage(NettyServerCnxnFactory.java:217) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.messageReceived(NettyServerCnxnFactory.java:141) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:350) at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:281) at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:201) at org.jboss.netty.util.internal.IoWorkerRunnable.run(IoWorkerRunnable.java:46) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ZOOKEEPER-1833) fix windows build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855909#comment-13855909
]
Germán Blanco commented on ZOOKEEPER-1833:
--
Right now regression on Windows on branch 3.4 fails for me (QuorumPeerMainTest
fails) without this patch, and it works with it. The patch corrects the cleanup
in PrepRequestProcessorTest which runs before QuorumPeerMainTest.
fix windows build
-
Key: ZOOKEEPER-1833
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
Fix For: 3.4.6
Attachments: TEST-org.apache.zookeeper.test.QuorumTest.zip,
ZOOKEEPER-1833-b3.4.patch, ZOOKEEPER-1833.patch, ZOOKEEPER-1833.patch
A bunch of 3.4 tests are failing on windows.
{noformat}
[junit] 2013-12-06 08:40:59,692 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testEarlyLeaderAbandonment
[junit] 2013-12-06 08:41:10,472 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testHighestZxidJoinLate
[junit] 2013-12-06 08:45:31,085 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testUpdatingEpoch
[junit] 2013-12-06 08:55:34,630 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testObserversHammer
[junit] 2013-12-06 08:55:59,889 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncExistsFailure_NoNode
[junit] 2013-12-06 08:56:00,571 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetACL
[junit] 2013-12-06 08:56:02,626 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildrenEmpty
[junit] 2013-12-06 08:56:03,491 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildrenSingle
[junit] 2013-12-06 08:56:11,276 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildrenTwo
[junit] 2013-12-06 08:56:13,878 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildrenFailure_NoNode
[junit] 2013-12-06 08:56:16,294 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildren2Empty
[junit] 2013-12-06 08:56:18,622 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildren2Single
[junit] 2013-12-06 08:56:21,224 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildren2Two
[junit] 2013-12-06 08:56:23,738 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildren2Failure_NoNode
[junit] 2013-12-06 08:56:26,058 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetData
[junit] 2013-12-06 08:56:28,482 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetDataFailure_NoNode
[junit] 2013-12-06 08:57:35,527 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testStartupFailureCreate
[junit] 2013-12-06 08:57:38,645 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testStartupFailureSet
[junit] 2013-12-06 08:57:41,261 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testStartupFailureSnapshot
[junit] 2013-12-06 08:59:22,222 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testClientWithWatcherObj
[junit] 2013-12-06 09:00:05,592 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testClientCleanup
[junit] 2013-12-06 09:01:24,113 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testBindByAddress
[junit] 2013-12-06 09:02:14,123 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testClientwithoutWatcherObj
[junit] 2013-12-06 09:05:56,461 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testZeroWeightQuorum
[junit] 2013-12-06 09:08:18,747 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testResyncByDiffAfterFollowerCrashes
[junit] 2013-12-06 09:09:42,271 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testFourLetterWords
[junit] 2013-12-06 09:14:03,770 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testLE
[junit] 2013-12-06 09:46:30,002 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testHierarchicalQuorum
[junit] 2013-12-06 09:50:26,912 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testHammerBasic
[junit] 2013-12-06 09:51:07,604 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testQuotaWithQuorum
[junit] 2013-12-06 09:52:41,515 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testNull
[junit] 2013-12-06 09:53:22,648 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testDeleteWithChildren
[junit] 2013-12-06 09:56:49,061 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testClientwithoutWatcherObj
[junit] 2013-12-06 09:58:27,705 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testGetView
[junit] 2013-12-06 09:59:07,856 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testViewContains
[junit] 2013-12-06 10:01:31,418 [myid:] - INFO [main:ZKTestCase$1@65] -
[jira] [Commented] (ZOOKEEPER-1179) NettyServerCnxn does not properly close socket on 4 letter word requests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855924#comment-13855924 ] Hadoop QA commented on ZOOKEEPER-1179: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12620251/ZOOKEEPER-1179.patch against trunk revision 1552946. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1860//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1860//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1860//console This message is automatically generated. NettyServerCnxn does not properly close socket on 4 letter word requests Key: ZOOKEEPER-1179 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1179 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.0 Reporter: Camille Fournier Assignee: Rakesh R Priority: Critical Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1179.patch, ZOOKEEPER-1179.patch When calling a 4-letter-word to a server configured to use NettyServerCnxnFactory, the factory will not properly cancel all the keys and close the socket after sending the response for the 4lw. The close request will throw this exception, and the thread will not shut down: 2011-09-13 12:14:17,546 - WARN [New I/O server worker #1-1:NettyServerCnxnFactory$CnxnChannelHandler@117] - Exception caught [id: 0x009300cc, /1.1.1.1:38542 = /139.172.114.138:2181] EXCEPTION: java.io.IOException: A non-blocking socket operation could not be completed immediately java.io.IOException: A non-blocking socket operation could not be completed immediately at sun.nio.ch.SocketDispatcher.close0(Native Method) at sun.nio.ch.SocketDispatcher.preClose(SocketDispatcher.java:44) at sun.nio.ch.SocketChannelImpl.implCloseSelectableChannel(SocketChannelImpl.java:684) at java.nio.channels.spi.AbstractSelectableChannel.implCloseChannel(AbstractSelectableChannel.java:201) at java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:97) at org.jboss.netty.channel.socket.nio.NioWorker.close(NioWorker.java:593) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.handleAcceptedSocket(NioServerSocketPipelineSink.java:119) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.eventSunk(NioServerSocketPipelineSink.java:76) at org.jboss.netty.channel.Channels.close(Channels.java:720) at org.jboss.netty.channel.AbstractChannel.close(AbstractChannel.java:208) at org.apache.zookeeper.server.NettyServerCnxn.close(NettyServerCnxn.java:116) at org.apache.zookeeper.server.NettyServerCnxn.cleanupWriterSocket(NettyServerCnxn.java:241) at org.apache.zookeeper.server.NettyServerCnxn.access$0(NettyServerCnxn.java:231) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.run(NettyServerCnxn.java:314) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.start(NettyServerCnxn.java:305) at org.apache.zookeeper.server.NettyServerCnxn.checkFourLetterWord(NettyServerCnxn.java:674) at org.apache.zookeeper.server.NettyServerCnxn.receiveMessage(NettyServerCnxn.java:791) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.processMessage(NettyServerCnxnFactory.java:217) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.messageReceived(NettyServerCnxnFactory.java:141) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:350)
Failed: ZOOKEEPER-1179 PreCommit Build #1860
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1179 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1860/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 294010 lines...] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12620251/ZOOKEEPER-1179.patch [exec] against trunk revision 1552946. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1860//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1860//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1860//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] df7a4b0a75e4e7642dd5fbcf4fc02ccb29c9351a logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674: exec returned: 1 Total time: 33 minutes 23 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1179 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Created] (ZOOKEEPER-1851) Follower and Observer Request Processors Do Not Forward create2 Requests
Chris Chen created ZOOKEEPER-1851: - Summary: Follower and Observer Request Processors Do Not Forward create2 Requests Key: ZOOKEEPER-1851 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1851 Project: ZooKeeper Issue Type: Bug Components: quorum Affects Versions: 3.5.0 Reporter: Chris Chen Recent changes to the Observer and Follower Request Processors switch on the request opcode, but create2 is left out. This leads to a condition where the create2 request is passed to the CommitProcessor, but the leader never gets the request, the CommitProcessor can't find a matching request, so the client gets disconnected. Added tests as well. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (ZOOKEEPER-1851) Follower and Observer Request Processors Do Not Forward create2 Requests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Chen updated ZOOKEEPER-1851: -- Attachment: ZOOKEEPER-1851.patch Follower and Observer Request Processors Do Not Forward create2 Requests Key: ZOOKEEPER-1851 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1851 Project: ZooKeeper Issue Type: Bug Components: quorum Affects Versions: 3.5.0 Reporter: Chris Chen Labels: patch Attachments: ZOOKEEPER-1851.patch Recent changes to the Observer and Follower Request Processors switch on the request opcode, but create2 is left out. This leads to a condition where the create2 request is passed to the CommitProcessor, but the leader never gets the request, the CommitProcessor can't find a matching request, so the client gets disconnected. Added tests as well. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
Failed: ZOOKEEPER-1851 PreCommit Build #1861
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1851 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1861/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79 lines...] [exec] Hunk #1 FAILED at 90. [exec] 1 out of 1 hunk FAILED -- saving rejects to file b/src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java.rej [exec] patching file b/src/java/test/org/apache/zookeeper/server/quorum/QuorumRequestPipelineTest.java [exec] patching file b/src/java/test/org/apache/zookeeper/test/QuorumBase.java [exec] Hunk #1 FAILED at 43. [exec] Hunk #2 FAILED at 136. [exec] Hunk #3 FAILED at 262. [exec] Hunk #4 FAILED at 290. [exec] Hunk #5 FAILED at 409. [exec] 5 out of 5 hunks FAILED -- saving rejects to file b/src/java/test/org/apache/zookeeper/test/QuorumBase.java.rej [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12620284/ZOOKEEPER-1851.patch [exec] against trunk revision 1552946. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 5 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1861//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 9b2d87565a1ac4375b140887503527deef1311ef logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674: exec returned: 1 Total time: 1 minute 16 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1851 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-1851) Follower and Observer Request Processors Do Not Forward create2 Requests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856019#comment-13856019 ] Hadoop QA commented on ZOOKEEPER-1851: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12620284/ZOOKEEPER-1851.patch against trunk revision 1552946. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1861//console This message is automatically generated. Follower and Observer Request Processors Do Not Forward create2 Requests Key: ZOOKEEPER-1851 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1851 Project: ZooKeeper Issue Type: Bug Components: quorum Affects Versions: 3.5.0 Reporter: Chris Chen Labels: patch Attachments: ZOOKEEPER-1851.patch Recent changes to the Observer and Follower Request Processors switch on the request opcode, but create2 is left out. This leads to a condition where the create2 request is passed to the CommitProcessor, but the leader never gets the request, the CommitProcessor can't find a matching request, so the client gets disconnected. Added tests as well. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (ZOOKEEPER-1179) NettyServerCnxn does not properly close socket on 4 letter word requests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1179: Attachment: ZOOKEEPER-1179.patch NettyServerCnxn does not properly close socket on 4 letter word requests Key: ZOOKEEPER-1179 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1179 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.0 Reporter: Camille Fournier Assignee: Rakesh R Priority: Critical Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1179.patch, ZOOKEEPER-1179.patch, ZOOKEEPER-1179.patch When calling a 4-letter-word to a server configured to use NettyServerCnxnFactory, the factory will not properly cancel all the keys and close the socket after sending the response for the 4lw. The close request will throw this exception, and the thread will not shut down: 2011-09-13 12:14:17,546 - WARN [New I/O server worker #1-1:NettyServerCnxnFactory$CnxnChannelHandler@117] - Exception caught [id: 0x009300cc, /1.1.1.1:38542 = /139.172.114.138:2181] EXCEPTION: java.io.IOException: A non-blocking socket operation could not be completed immediately java.io.IOException: A non-blocking socket operation could not be completed immediately at sun.nio.ch.SocketDispatcher.close0(Native Method) at sun.nio.ch.SocketDispatcher.preClose(SocketDispatcher.java:44) at sun.nio.ch.SocketChannelImpl.implCloseSelectableChannel(SocketChannelImpl.java:684) at java.nio.channels.spi.AbstractSelectableChannel.implCloseChannel(AbstractSelectableChannel.java:201) at java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:97) at org.jboss.netty.channel.socket.nio.NioWorker.close(NioWorker.java:593) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.handleAcceptedSocket(NioServerSocketPipelineSink.java:119) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.eventSunk(NioServerSocketPipelineSink.java:76) at org.jboss.netty.channel.Channels.close(Channels.java:720) at org.jboss.netty.channel.AbstractChannel.close(AbstractChannel.java:208) at org.apache.zookeeper.server.NettyServerCnxn.close(NettyServerCnxn.java:116) at org.apache.zookeeper.server.NettyServerCnxn.cleanupWriterSocket(NettyServerCnxn.java:241) at org.apache.zookeeper.server.NettyServerCnxn.access$0(NettyServerCnxn.java:231) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.run(NettyServerCnxn.java:314) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.start(NettyServerCnxn.java:305) at org.apache.zookeeper.server.NettyServerCnxn.checkFourLetterWord(NettyServerCnxn.java:674) at org.apache.zookeeper.server.NettyServerCnxn.receiveMessage(NettyServerCnxn.java:791) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.processMessage(NettyServerCnxnFactory.java:217) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.messageReceived(NettyServerCnxnFactory.java:141) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:350) at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:281) at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:201) at org.jboss.netty.util.internal.IoWorkerRunnable.run(IoWorkerRunnable.java:46) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ZOOKEEPER-1179) NettyServerCnxn does not properly close socket on 4 letter word requests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856147#comment-13856147 ] Rakesh R commented on ZOOKEEPER-1179: - Thanks a lot Flavio/German for the help. I've tried simulating a case, where it tests the possibility of duplicate closure. Please have a look at the latest patch. NettyServerCnxn does not properly close socket on 4 letter word requests Key: ZOOKEEPER-1179 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1179 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.0 Reporter: Camille Fournier Assignee: Rakesh R Priority: Critical Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1179.patch, ZOOKEEPER-1179.patch, ZOOKEEPER-1179.patch When calling a 4-letter-word to a server configured to use NettyServerCnxnFactory, the factory will not properly cancel all the keys and close the socket after sending the response for the 4lw. The close request will throw this exception, and the thread will not shut down: 2011-09-13 12:14:17,546 - WARN [New I/O server worker #1-1:NettyServerCnxnFactory$CnxnChannelHandler@117] - Exception caught [id: 0x009300cc, /1.1.1.1:38542 = /139.172.114.138:2181] EXCEPTION: java.io.IOException: A non-blocking socket operation could not be completed immediately java.io.IOException: A non-blocking socket operation could not be completed immediately at sun.nio.ch.SocketDispatcher.close0(Native Method) at sun.nio.ch.SocketDispatcher.preClose(SocketDispatcher.java:44) at sun.nio.ch.SocketChannelImpl.implCloseSelectableChannel(SocketChannelImpl.java:684) at java.nio.channels.spi.AbstractSelectableChannel.implCloseChannel(AbstractSelectableChannel.java:201) at java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:97) at org.jboss.netty.channel.socket.nio.NioWorker.close(NioWorker.java:593) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.handleAcceptedSocket(NioServerSocketPipelineSink.java:119) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.eventSunk(NioServerSocketPipelineSink.java:76) at org.jboss.netty.channel.Channels.close(Channels.java:720) at org.jboss.netty.channel.AbstractChannel.close(AbstractChannel.java:208) at org.apache.zookeeper.server.NettyServerCnxn.close(NettyServerCnxn.java:116) at org.apache.zookeeper.server.NettyServerCnxn.cleanupWriterSocket(NettyServerCnxn.java:241) at org.apache.zookeeper.server.NettyServerCnxn.access$0(NettyServerCnxn.java:231) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.run(NettyServerCnxn.java:314) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.start(NettyServerCnxn.java:305) at org.apache.zookeeper.server.NettyServerCnxn.checkFourLetterWord(NettyServerCnxn.java:674) at org.apache.zookeeper.server.NettyServerCnxn.receiveMessage(NettyServerCnxn.java:791) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.processMessage(NettyServerCnxnFactory.java:217) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.messageReceived(NettyServerCnxnFactory.java:141) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:350) at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:281) at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:201) at org.jboss.netty.util.internal.IoWorkerRunnable.run(IoWorkerRunnable.java:46) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ZOOKEEPER-1179) NettyServerCnxn does not properly close socket on 4 letter word requests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856158#comment-13856158 ] Hadoop QA commented on ZOOKEEPER-1179: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12620307/ZOOKEEPER-1179.patch against trunk revision 1552946. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1862//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1862//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1862//console This message is automatically generated. NettyServerCnxn does not properly close socket on 4 letter word requests Key: ZOOKEEPER-1179 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1179 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.0 Reporter: Camille Fournier Assignee: Rakesh R Priority: Critical Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1179.patch, ZOOKEEPER-1179.patch, ZOOKEEPER-1179.patch When calling a 4-letter-word to a server configured to use NettyServerCnxnFactory, the factory will not properly cancel all the keys and close the socket after sending the response for the 4lw. The close request will throw this exception, and the thread will not shut down: 2011-09-13 12:14:17,546 - WARN [New I/O server worker #1-1:NettyServerCnxnFactory$CnxnChannelHandler@117] - Exception caught [id: 0x009300cc, /1.1.1.1:38542 = /139.172.114.138:2181] EXCEPTION: java.io.IOException: A non-blocking socket operation could not be completed immediately java.io.IOException: A non-blocking socket operation could not be completed immediately at sun.nio.ch.SocketDispatcher.close0(Native Method) at sun.nio.ch.SocketDispatcher.preClose(SocketDispatcher.java:44) at sun.nio.ch.SocketChannelImpl.implCloseSelectableChannel(SocketChannelImpl.java:684) at java.nio.channels.spi.AbstractSelectableChannel.implCloseChannel(AbstractSelectableChannel.java:201) at java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:97) at org.jboss.netty.channel.socket.nio.NioWorker.close(NioWorker.java:593) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.handleAcceptedSocket(NioServerSocketPipelineSink.java:119) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.eventSunk(NioServerSocketPipelineSink.java:76) at org.jboss.netty.channel.Channels.close(Channels.java:720) at org.jboss.netty.channel.AbstractChannel.close(AbstractChannel.java:208) at org.apache.zookeeper.server.NettyServerCnxn.close(NettyServerCnxn.java:116) at org.apache.zookeeper.server.NettyServerCnxn.cleanupWriterSocket(NettyServerCnxn.java:241) at org.apache.zookeeper.server.NettyServerCnxn.access$0(NettyServerCnxn.java:231) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.run(NettyServerCnxn.java:314) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.start(NettyServerCnxn.java:305) at org.apache.zookeeper.server.NettyServerCnxn.checkFourLetterWord(NettyServerCnxn.java:674) at org.apache.zookeeper.server.NettyServerCnxn.receiveMessage(NettyServerCnxn.java:791) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.processMessage(NettyServerCnxnFactory.java:217) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.messageReceived(NettyServerCnxnFactory.java:141) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:350) at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:281) at
Success: ZOOKEEPER-1179 PreCommit Build #1862
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1179 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1862/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 295569 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12620307/ZOOKEEPER-1179.patch [exec] against trunk revision 1552946. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1862//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1862//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1862//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 83fcd36b9c7a0c6ca10d0d7739f6f038f44c3b01 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 33 minutes 3 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1179 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1179) NettyServerCnxn does not properly close socket on 4 letter word requests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856175#comment-13856175 ] Germán Blanco commented on ZOOKEEPER-1179: -- +1 from my side. Excellent test case for this. NettyServerCnxn does not properly close socket on 4 letter word requests Key: ZOOKEEPER-1179 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1179 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.0 Reporter: Camille Fournier Assignee: Rakesh R Priority: Critical Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1179.patch, ZOOKEEPER-1179.patch, ZOOKEEPER-1179.patch When calling a 4-letter-word to a server configured to use NettyServerCnxnFactory, the factory will not properly cancel all the keys and close the socket after sending the response for the 4lw. The close request will throw this exception, and the thread will not shut down: 2011-09-13 12:14:17,546 - WARN [New I/O server worker #1-1:NettyServerCnxnFactory$CnxnChannelHandler@117] - Exception caught [id: 0x009300cc, /1.1.1.1:38542 = /139.172.114.138:2181] EXCEPTION: java.io.IOException: A non-blocking socket operation could not be completed immediately java.io.IOException: A non-blocking socket operation could not be completed immediately at sun.nio.ch.SocketDispatcher.close0(Native Method) at sun.nio.ch.SocketDispatcher.preClose(SocketDispatcher.java:44) at sun.nio.ch.SocketChannelImpl.implCloseSelectableChannel(SocketChannelImpl.java:684) at java.nio.channels.spi.AbstractSelectableChannel.implCloseChannel(AbstractSelectableChannel.java:201) at java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:97) at org.jboss.netty.channel.socket.nio.NioWorker.close(NioWorker.java:593) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.handleAcceptedSocket(NioServerSocketPipelineSink.java:119) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.eventSunk(NioServerSocketPipelineSink.java:76) at org.jboss.netty.channel.Channels.close(Channels.java:720) at org.jboss.netty.channel.AbstractChannel.close(AbstractChannel.java:208) at org.apache.zookeeper.server.NettyServerCnxn.close(NettyServerCnxn.java:116) at org.apache.zookeeper.server.NettyServerCnxn.cleanupWriterSocket(NettyServerCnxn.java:241) at org.apache.zookeeper.server.NettyServerCnxn.access$0(NettyServerCnxn.java:231) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.run(NettyServerCnxn.java:314) at org.apache.zookeeper.server.NettyServerCnxn$CommandThread.start(NettyServerCnxn.java:305) at org.apache.zookeeper.server.NettyServerCnxn.checkFourLetterWord(NettyServerCnxn.java:674) at org.apache.zookeeper.server.NettyServerCnxn.receiveMessage(NettyServerCnxn.java:791) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.processMessage(NettyServerCnxnFactory.java:217) at org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.messageReceived(NettyServerCnxnFactory.java:141) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:350) at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:281) at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:201) at org.jboss.netty.util.internal.IoWorkerRunnable.run(IoWorkerRunnable.java:46) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
backlog clean-up
The project has a large backlogs of JIRAs, but many of them do not reflect issues in the current versions. Wouldn't it make sense to spend a little time closing obsolete JIRAs? E.g. this one: https://issues.apache.org/jira/browse/ZOOKEEPER-1392 Seems to be Not a problem. May I just go through the list and start resolving those that are obvious? Or is there a better procedure to do this?
