Re: Gui for zk

[Anthony Barré]

There is a GUI for zk called zooinspector. This GUI is a bit slow.
I would suggest you to improve this project rather than creating a new one.

Regards,


2014/1/13 Rakesh R rake...@huawei.com

 Also, it would be good if you can prepare document describing the idea and
 post it. So will help to get early feedback and responses.

 Best wishes:)

 -Rakesh

 -Original Message-
 From: Rumesh Eranga [mailto:rehrum...@gmail.com]
 Sent: 12 January 2014 01:20
 To: dev@zookeeper.apache.org
 Subject: Re: Gui for zk

 Thank you Rakesh four your suggestions.

 First of all I will start with couple of mockups. As soon as they are done
 I'll post them here so that everyone could comment their ideas.Then with
 the help of community will come-up with a good GUI.

 Also I want it to be cross platform.

 Rumesh

 On 1/11/14, Rakesh R rake...@huawei.com wrote:
  Nice thought.
 
  It would be great if you can give more explanation about the idea and
  the motivation.
 
  If such a GUI is coming up, following are just my thoughts and will be
  interested to have:
 
  1) MyId and host details of each server
  2) server status - STANDALONE/LEADER/FOLLOWER/OBSERVER/READONLY etc
  3) Current transaction ID
  4) Client details which has connected to my server
  5) ZNode hierarchy
  6) Watches information on a znode
  7) Likely to have link to ZooKeeper server logs
  8) Also, proper authentication in place
  9) Also, would be helpful to see heap memory related info.
 
  -Rakesh
 
  -Original Message-
  From: Rumesh Eranga [mailto:rehrum...@gmail.com]
  Sent: 11 January 2014 07:07
  To: dev@zookeeper.apache.org
  Subject: Gui for zk
 
  Hi,
 
  I would like to create a gui for zk. I was hoping to develop it using
 java.
  Anyone got any suggestion on what to add??
 
  Rumesh eranga
 




-- 






*Anthony BARREEquipe fasterizesupp...@fasterize.com
supp...@fasterize.com---Suivez nous
sur Twitter: @Fasterize*

ZooKeeper-3.4-WinVS2008_java - Build # 407 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/407/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 172088 lines...]
[junit] 2014-01-13 09:19:11,457 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited!
[junit] 2014-01-13 09:19:11,457 [myid:] - INFO  
[main:FinalRequestProcessor@415] - shutdown of request processor complete
[junit] 2014-01-13 09:19:11,457 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-01-13 09:19:12,000 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop!
[junit] 2014-01-13 09:19:12,000 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop!
[junit] 2014-01-13 09:19:12,221 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@968] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11221. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2014-01-13 09:19:12,467 [myid:] - INFO  [main:JMXEnv@135] - 
ensureOnly:[]
[junit] 2014-01-13 09:19:12,468 [myid:] - INFO  [main:ClientBase@438] - 
STARTING server
[junit] 2014-01-13 09:19:12,468 [myid:] - INFO  [main:ClientBase@359] - 
CREATING server instance 127.0.0.1:11221
[junit] 2014-01-13 09:19:12,469 [myid:] - INFO  
[main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2014-01-13 09:19:12,470 [myid:] - INFO  [main:ClientBase@334] - 
STARTING server instance 127.0.0.1:11221
[junit] 2014-01-13 09:19:12,470 [myid:] - INFO  [main:ZooKeeperServer@162] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test2321905091580738034.junit.dir\version-2
 snapdir 
f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test2321905091580738034.junit.dir\version-2
[junit] 2014-01-13 09:19:12,473 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-01-13 09:19:12,474 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - 
Accepted socket connection from /127.0.0.1:58998
[junit] 2014-01-13 09:19:12,474 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:58998
[junit] 2014-01-13 09:19:12,474 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2014-01-13 09:19:12,475 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1007] - Closed socket connection for client 
/127.0.0.1:58998 (no session established for client)
[junit] 2014-01-13 09:19:12,475 [myid:] - INFO  [main:JMXEnv@135] - 
ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2014-01-13 09:19:12,476 [myid:] - INFO  [main:JMXEnv@105] - 
expect:InMemoryDataTree
[junit] 2014-01-13 09:19:12,477 [myid:] - INFO  [main:JMXEnv@108] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2014-01-13 09:19:12,477 [myid:] - INFO  [main:JMXEnv@105] - 
expect:StandaloneServer_port
[junit] 2014-01-13 09:19:12,477 [myid:] - INFO  [main:JMXEnv@108] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2014-01-13 09:19:12,477 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 10828
[junit] 2014-01-13 09:19:12,477 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 19
[junit] 2014-01-13 09:19:12,478 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota
[junit] 2014-01-13 09:19:12,478 [myid:] - INFO  [main:ClientBase@477] - 
tearDown starting
[junit] 2014-01-13 09:19:12,714 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@849] - Socket 
connection established to 127.0.0.1/127.0.0.1:11221, initiating session
[junit] 2014-01-13 09:19:12,714 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - 
Accepted socket connection from /127.0.0.1:58995
[junit] 2014-01-13 09:19:12,715 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:ZooKeeperServer@861] - Client 
attempting to renew session 0x1438ae5c3ae at /127.0.0.1:58995
[junit] 2014-01-13 09:19:12,716 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:ZooKeeperServer@617] - Established 
session 0x1438ae5c3ae with negotiated timeout 3 for client 
/127.0.0.1:58995
[junit] 2014-01-13 09:19:12,716 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1228] - Session 
establishment complete on server 127.0.0.1/127.0.0.1:11221, sessionid = 
0x1438ae5c3ae, 

ZooKeeper-trunk-solaris - Build # 790 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/790/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 213027 lines...]
[junit] 2014-01-13 09:35:07,354 [myid:] - INFO  
[main:SyncRequestProcessor@190] - Shutting down
[junit] 2014-01-13 09:35:07,354 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2014-01-13 09:35:07,355 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@168] - SyncRequestProcessor exited!
[junit] 2014-01-13 09:35:07,355 [myid:] - INFO  
[main:FinalRequestProcessor@442] - shutdown of request processor complete
[junit] 2014-01-13 09:35:07,355 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-01-13 09:35:07,356 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[]
[junit] 2014-01-13 09:35:07,357 [myid:] - INFO  [main:ClientBase@439] - 
STARTING server
[junit] 2014-01-13 09:35:07,357 [myid:] - INFO  [main:ClientBase@360] - 
CREATING server instance 127.0.0.1:11221
[junit] 2014-01-13 09:35:07,358 [myid:] - INFO  
[main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2014-01-13 09:35:07,358 [myid:] - INFO  
[main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2014-01-13 09:35:07,359 [myid:] - INFO  [main:ClientBase@335] - 
STARTING server instance 127.0.0.1:11221
[junit] 2014-01-13 09:35:07,359 [myid:] - INFO  [main:ZooKeeperServer@149] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test4555110159276833189.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test4555110159276833189.junit.dir/version-2
[junit] 2014-01-13 09:35:07,360 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test4555110159276833189.junit.dir/version-2/snapshot.b
[junit] 2014-01-13 09:35:07,362 [myid:] - INFO  [main:FileTxnSnapLog@297] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test4555110159276833189.junit.dir/version-2/snapshot.b
[junit] 2014-01-13 09:35:07,364 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-01-13 09:35:07,364 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:57875
[junit] 2014-01-13 09:35:07,365 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from 
/127.0.0.1:57875
[junit] 2014-01-13 09:35:07,365 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output
[junit] 2014-01-13 09:35:07,366 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client 
/127.0.0.1:57875 (no session established for client)
[junit] 2014-01-13 09:35:07,366 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2014-01-13 09:35:07,367 [myid:] - INFO  [main:JMXEnv@105] - 
expect:InMemoryDataTree
[junit] 2014-01-13 09:35:07,367 [myid:] - INFO  [main:JMXEnv@108] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2014-01-13 09:35:07,367 [myid:] - INFO  [main:JMXEnv@105] - 
expect:StandaloneServer_port
[junit] 2014-01-13 09:35:07,368 [myid:] - INFO  [main:JMXEnv@108] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2014-01-13 09:35:07,368 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 13340
[junit] 2014-01-13 09:35:07,368 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 24
[junit] 2014-01-13 09:35:07,368 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota
[junit] 2014-01-13 09:35:07,369 [myid:] - INFO  [main:ClientBase@478] - 
tearDown starting
[junit] 2014-01-13 09:35:07,439 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down
[junit] 2014-01-13 09:35:07,439 [myid:] - INFO  [main:ZooKeeper@777] - 
Session: 0x1438af45d8f closed
[junit] 2014-01-13 09:35:07,439 [myid:] - INFO  [main:ClientBase@448] - 
STOPPING server
[junit] 2014-01-13 09:35:07,440 [myid:] - INFO  

ZooKeeper-trunk-WinVS2008_java - Build # 653 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/653/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 257811 lines...]
[junit] 2014-01-13 09:44:17,513 [myid:] - INFO  [main:ClientBase@360] - 
CREATING server instance 127.0.0.1:11221
[junit] 2014-01-13 09:44:17,514 [myid:] - INFO  
[main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 1 selector thread(s), 4 worker threads, and 64 
kB direct buffers.
[junit] 2014-01-13 09:44:17,515 [myid:] - INFO  
[main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2014-01-13 09:44:17,516 [myid:] - INFO  [main:ClientBase@335] - 
STARTING server instance 127.0.0.1:11221
[junit] 2014-01-13 09:44:17,516 [myid:] - INFO  [main:ZooKeeperServer@149] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test6405164947300738484.junit.dir\version-2
 snapdir 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test6405164947300738484.junit.dir\version-2
[junit] 2014-01-13 09:44:17,517 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test6405164947300738484.junit.dir\version-2\snapshot.b
[junit] 2014-01-13 09:44:17,519 [myid:] - INFO  [main:FileTxnSnapLog@297] - 
Snapshotting: 0xb to 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test6405164947300738484.junit.dir\version-2\snapshot.b
[junit] 2014-01-13 09:44:17,520 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-01-13 09:44:17,521 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:62453
[junit] 2014-01-13 09:44:17,522 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from 
/127.0.0.1:62453
[junit] 2014-01-13 09:44:17,522 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output
[junit] 2014-01-13 09:44:17,522 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client 
/127.0.0.1:62453 (no session established for client)
[junit] 2014-01-13 09:44:17,522 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2014-01-13 09:44:17,524 [myid:] - INFO  [main:JMXEnv@105] - 
expect:InMemoryDataTree
[junit] 2014-01-13 09:44:17,524 [myid:] - INFO  [main:JMXEnv@108] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2014-01-13 09:44:17,524 [myid:] - INFO  [main:JMXEnv@105] - 
expect:StandaloneServer_port
[junit] 2014-01-13 09:44:17,524 [myid:] - INFO  [main:JMXEnv@108] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2014-01-13 09:44:17,525 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 13037
[junit] 2014-01-13 09:44:17,525 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 24
[junit] 2014-01-13 09:44:17,525 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota
[junit] 2014-01-13 09:44:17,525 [myid:] - INFO  [main:ClientBase@478] - 
tearDown starting
[junit] 2014-01-13 09:44:17,582 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@882] - Socket 
connection established to 127.0.0.1/127.0.0.1:11221, initiating session
[junit] 2014-01-13 09:44:17,582 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:62448
[junit] 2014-01-13 09:44:17,583 [myid:] - INFO  
[NIOWorkerThread-2:ZooKeeperServer@858] - Client attempting to renew session 
0x1438afcba87 at /127.0.0.1:62448
[junit] 2014-01-13 09:44:17,584 [myid:] - INFO  
[NIOWorkerThread-2:ZooKeeperServer@604] - Established session 0x1438afcba87 
with negotiated timeout 3 for client /127.0.0.1:62448
[junit] 2014-01-13 09:44:17,584 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1261] - Session 
establishment complete on server 127.0.0.1/127.0.0.1:11221, sessionid = 
0x1438afcba87, negotiated timeout = 3
[junit] 2014-01-13 09:44:17,585 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@678] - Processed session termination for 
sessionid: 0x1438afcba87
[junit] 2014-01-13 09:44:17,585 [myid:] - INFO  
[SyncThread:0:FileTxnLog@200] - Creating new log file: log.c
[junit] 2014-01-13 

[jira] [Commented] (ZOOKEEPER-1833) fix windows build

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869418#comment-13869418
 ] 

Flavio Junqueira commented on ZOOKEEPER-1833:
-

It sounds like we got a lot more failures in the 407 build.

 fix windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6

 Attachments: TEST-org.apache.zookeeper.test.QuorumTest.zip, 
 ZOOKEEPER-1833-b3.4.patch, ZOOKEEPER-1833.patch, ZOOKEEPER-1833.patch


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testFourLetterWords
 [junit] 2013-12-06 09:14:03,770 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testLE
 [junit] 2013-12-06 09:46:30,002 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHierarchicalQuorum
 [junit] 2013-12-06 09:50:26,912 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHammerBasic
 [junit] 2013-12-06 09:51:07,604 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testQuotaWithQuorum
 [junit] 2013-12-06 09:52:41,515 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testNull
 [junit] 2013-12-06 09:53:22,648 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testDeleteWithChildren
 [junit] 2013-12-06 09:56:49,061 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:58:27,705 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testGetView
 [junit] 2013-12-06 09:59:07,856 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testViewContains
 [junit] 2013-12-06 10:01:31,418 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testSessionMoved
 [junit] 2013-12-06 10:04:50,542 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testMultiToFollower
 [junit] 2013-12-06 

[jira] [Commented] (ZOOKEEPER-1833) fix windows build

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869434#comment-13869434
 ] 

Rakesh R commented on ZOOKEEPER-1833:
-

In 407 build, around 10 test cases are failing with the following pattern. I 
have observed the same pattern in previous build also, I was thinking about the 
same for few days, but couldn't find the reason.
{code}
[junit] junit.framework.AssertionFailedError: expected [0x1438aca88410001] 
expected:1 but was:0
[junit] at junit.framework.Assert.fail(Assert.java:47)
[junit] at junit.framework.Assert.failNotEquals(Assert.java:283)
[junit] at junit.framework.Assert.assertEquals(Assert.java:64)
[junit] at junit.framework.Assert.assertEquals(Assert.java:195)
[junit] at org.apache.zookeeper.test.JMXEnv.ensureAll(JMXEnv.java:115)
[junit] at 
org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:191)
{code}

I think, 'A non-blocking socket operation could not be completed immediately' 
exceptions has gone after ZK-1238 in. But will wait and observe some more 
builds to confirm this.

 fix windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6

 Attachments: TEST-org.apache.zookeeper.test.QuorumTest.zip, 
 ZOOKEEPER-1833-b3.4.patch, ZOOKEEPER-1833.patch, ZOOKEEPER-1833.patch


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testFourLetterWords
 [junit] 2013-12-06 09:14:03,770 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testLE
 [junit] 2013-12-06 09:46:30,002 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHierarchicalQuorum
 [junit] 2013-12-06 09:50:26,912 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED 

[jira] [Commented] (ZOOKEEPER-1833) fix windows build

[JIRA]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869459#comment-13869459
 ] 

Germán Blanco commented on ZOOKEEPER-1833:
--

I believe this could be solved if we allow some time for JMX environment to be 
updated in ensureAll and ensureNone as it was done for ensureOnly in 
ZOOKEEPER-1837.
Should I open a new sub-task for that? Or would it be better to re-open 
ZOOKEEPER-1837?

 fix windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6

 Attachments: TEST-org.apache.zookeeper.test.QuorumTest.zip, 
 ZOOKEEPER-1833-b3.4.patch, ZOOKEEPER-1833.patch, ZOOKEEPER-1833.patch


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testFourLetterWords
 [junit] 2013-12-06 09:14:03,770 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testLE
 [junit] 2013-12-06 09:46:30,002 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHierarchicalQuorum
 [junit] 2013-12-06 09:50:26,912 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHammerBasic
 [junit] 2013-12-06 09:51:07,604 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testQuotaWithQuorum
 [junit] 2013-12-06 09:52:41,515 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testNull
 [junit] 2013-12-06 09:53:22,648 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testDeleteWithChildren
 [junit] 2013-12-06 09:56:49,061 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:58:27,705 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testGetView
 [junit] 2013-12-06 09:59:07,856 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testViewContains
 [junit] 2013-12-06 10:01:31,418 [myid:] - INFO  

[jira] [Commented] (ZOOKEEPER-1833) fix windows build

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869523#comment-13869523
 ] 

Flavio Junqueira commented on ZOOKEEPER-1833:
-

Well spotted, [~abranzyck], [~rakeshr]. I think it is ok to reopen 
ZOOKEEPER-1837.

 fix windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6

 Attachments: TEST-org.apache.zookeeper.test.QuorumTest.zip, 
 ZOOKEEPER-1833-b3.4.patch, ZOOKEEPER-1833.patch, ZOOKEEPER-1833.patch


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testFourLetterWords
 [junit] 2013-12-06 09:14:03,770 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testLE
 [junit] 2013-12-06 09:46:30,002 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHierarchicalQuorum
 [junit] 2013-12-06 09:50:26,912 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHammerBasic
 [junit] 2013-12-06 09:51:07,604 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testQuotaWithQuorum
 [junit] 2013-12-06 09:52:41,515 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testNull
 [junit] 2013-12-06 09:53:22,648 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testDeleteWithChildren
 [junit] 2013-12-06 09:56:49,061 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:58:27,705 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testGetView
 [junit] 2013-12-06 09:59:07,856 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testViewContains
 [junit] 2013-12-06 10:01:31,418 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testSessionMoved
 [junit] 2013-12-06 10:04:50,542 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testMultiToFollower
 

[jira] [Reopened] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)

[JIRA]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Germán Blanco reopened ZOOKEEPER-1837:
--


The same kind of problem (delay in the update of JMX environment) occurs for 
ensureAll and potentially ensureNone.

 Fix JMXEnv checks (potential race conditions)
 -

 Key: ZOOKEEPER-1837
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: tests
Affects Versions: 3.4.5, 3.5.0
 Environment: Windows 8
Reporter: Germán Blanco
Assignee: Germán Blanco
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch


 The following failures in ZooKeeper-3.4-WinVS2008_java and 
 ZooKeeper-trunk-WinVS2008_java require fixing:
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit]   at 
 org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
 [
 junit.framework.AssertionFailedError: expected [0x142e5f027b50001] 
 expected:1 but was:0
   at org.apache.zookeeper.test.JMXEnv.ensureAll(JMXEnv.java:115)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:197)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:171)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:156)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:149)
   at 
 org.apache.zookeeper.ZooKeeperTest.testDeleteRecursive(ZooKeeperTest.java:45)
   at 
 org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Updated] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)

[JIRA]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Germán Blanco updated ZOOKEEPER-1837:
-

Attachment: ZOOKEEPER-1837-b3.4.patch

 Fix JMXEnv checks (potential race conditions)
 -

 Key: ZOOKEEPER-1837
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: tests
Affects Versions: 3.4.5, 3.5.0
 Environment: Windows 8
Reporter: Germán Blanco
Assignee: Germán Blanco
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1837-b3.4.patch, ZOOKEEPER-1837.patch, 
 ZOOKEEPER-1837.patch


 The following failures in ZooKeeper-3.4-WinVS2008_java and 
 ZooKeeper-trunk-WinVS2008_java require fixing:
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit]   at 
 org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
 [
 junit.framework.AssertionFailedError: expected [0x142e5f027b50001] 
 expected:1 but was:0
   at org.apache.zookeeper.test.JMXEnv.ensureAll(JMXEnv.java:115)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:197)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:171)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:156)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:149)
   at 
 org.apache.zookeeper.ZooKeeperTest.testDeleteRecursive(ZooKeeperTest.java:45)
   at 
 org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Updated] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)

[JIRA]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Germán Blanco updated ZOOKEEPER-1837:
-

Attachment: ZOOKEEPER-1837-b3.4.patch

adding retries for 5 seconds in ensureAll and ensureNone (as well as in 
ensureOnly, which calls ensureAll and already had the retries)

 Fix JMXEnv checks (potential race conditions)
 -

 Key: ZOOKEEPER-1837
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: tests
Affects Versions: 3.4.5, 3.5.0
 Environment: Windows 8
Reporter: Germán Blanco
Assignee: Germán Blanco
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1837-b3.4.patch, ZOOKEEPER-1837-b3.4.patch, 
 ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch


 The following failures in ZooKeeper-3.4-WinVS2008_java and 
 ZooKeeper-trunk-WinVS2008_java require fixing:
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit]   at 
 org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
 [
 junit.framework.AssertionFailedError: expected [0x142e5f027b50001] 
 expected:1 but was:0
   at org.apache.zookeeper.test.JMXEnv.ensureAll(JMXEnv.java:115)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:197)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:171)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:156)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:149)
   at 
 org.apache.zookeeper.ZooKeeperTest.testDeleteRecursive(ZooKeeperTest.java:45)
   at 
 org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Failed: ZOOKEEPER-1837 PreCommit Build #1878

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1837
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1878/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 66 lines...]
 [exec] 
==
 [exec] 
 [exec] 
 [exec] patching file src/java/test/org/apache/zookeeper/test/JMXEnv.java
 [exec] Hunk #3 FAILED at 131.
 [exec] Hunk #4 FAILED at 143.
 [exec] Hunk #5 succeeded at 149 (offset -6 lines).
 [exec] 2 out of 5 hunks FAILED -- saving rejects to file 
src/java/test/org/apache/zookeeper/test/JMXEnv.java.rej
 [exec] patching file 
src/java/test/org/apache/zookeeper/test/QuorumUtil.java
 [exec] Hunk #1 succeeded at 179 (offset 18 lines).
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12622660/ZOOKEEPER-1837-b3.4.patch
 [exec]   against trunk revision 1556976.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1878//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 2f6777464615394885bb7e6c0604d1a05ffe441f logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674:
 exec returned: 1

Total time: 1 minute 27 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1837
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869704#comment-13869704
 ] 

Hadoop QA commented on ZOOKEEPER-1837:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12622660/ZOOKEEPER-1837-b3.4.patch
  against trunk revision 1556976.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1878//console

This message is automatically generated.

 Fix JMXEnv checks (potential race conditions)
 -

 Key: ZOOKEEPER-1837
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: tests
Affects Versions: 3.4.5, 3.5.0
 Environment: Windows 8
Reporter: Germán Blanco
Assignee: Germán Blanco
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1837-b3.4.patch, ZOOKEEPER-1837-b3.4.patch, 
 ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch


 The following failures in ZooKeeper-3.4-WinVS2008_java and 
 ZooKeeper-trunk-WinVS2008_java require fixing:
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit]   at 
 org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
 [
 junit.framework.AssertionFailedError: expected [0x142e5f027b50001] 
 expected:1 but was:0
   at org.apache.zookeeper.test.JMXEnv.ensureAll(JMXEnv.java:115)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:197)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:171)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:156)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:149)
 

[jira] [Updated] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)

[JIRA]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Germán Blanco updated ZOOKEEPER-1837:
-

Attachment: ZOOKEEPER-1837.patch

 Fix JMXEnv checks (potential race conditions)
 -

 Key: ZOOKEEPER-1837
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: tests
Affects Versions: 3.4.5, 3.5.0
 Environment: Windows 8
Reporter: Germán Blanco
Assignee: Germán Blanco
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1837-b3.4.patch, ZOOKEEPER-1837-b3.4.patch, 
 ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch


 The following failures in ZooKeeper-3.4-WinVS2008_java and 
 ZooKeeper-trunk-WinVS2008_java require fixing:
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit]   at 
 org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
 [
 junit.framework.AssertionFailedError: expected [0x142e5f027b50001] 
 expected:1 but was:0
   at org.apache.zookeeper.test.JMXEnv.ensureAll(JMXEnv.java:115)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:197)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:171)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:156)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:149)
   at 
 org.apache.zookeeper.ZooKeeperTest.testDeleteRecursive(ZooKeeperTest.java:45)
   at 
 org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Failed: ZOOKEEPER-1837 PreCommit Build #1879

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1837
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1879/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 290283 lines...]
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12622661/ZOOKEEPER-1837.patch
 [exec]   against trunk revision 1556976.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 9 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1879//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1879//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1879//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 88fc4a576ad9c1f05c037dbf524f655a2e6d1547 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674:
 exec returned: 1

Total time: 29 minutes 13 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1837
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
8 tests failed.
REGRESSION:  
org.apache.zookeeper.server.quorum.Zab1_0Test.testLeaderInConnectingFollowers

Error Message:
Address already in use

Stack Trace:
java.net.BindException: Address already in use
at java.net.PlainSocketImpl.socketBind(Native Method)
at java.net.PlainSocketImpl.bind(PlainSocketImpl.java:383)
at java.net.ServerSocket.bind(ServerSocket.java:328)
at java.net.ServerSocket.bind(ServerSocket.java:286)
at org.apache.zookeeper.server.quorum.Leader.init(Leader.java:269)
at 
org.apache.zookeeper.server.quorum.Zab1_0Test.createLeader(Zab1_0Test.java:1217)
at 
org.apache.zookeeper.server.quorum.Zab1_0Test.testLeaderInConnectingFollowers(Zab1_0Test.java:152)


REGRESSION:  org.apache.zookeeper.server.quorum.Zab1_0Test.testLastAcceptedEpoch

Error Message:
Address already in use

Stack Trace:
java.net.BindException: Address already in use
at java.net.PlainSocketImpl.socketBind(Native Method)
at java.net.PlainSocketImpl.bind(PlainSocketImpl.java:383)
at java.net.ServerSocket.bind(ServerSocket.java:328)
at java.net.ServerSocket.bind(ServerSocket.java:286)
at org.apache.zookeeper.server.quorum.Leader.init(Leader.java:269)
at 
org.apache.zookeeper.server.quorum.Zab1_0Test$MockLeader.init(Zab1_0Test.java:101)
at 
org.apache.zookeeper.server.quorum.Zab1_0Test.createMockLeader(Zab1_0Test.java:1223)
at 
org.apache.zookeeper.server.quorum.Zab1_0Test.testLastAcceptedEpoch(Zab1_0Test.java:207)


REGRESSION:  
org.apache.zookeeper.server.quorum.Zab1_0Test.testLeaderInElectingFollowers

Error Message:
Address already in use

Stack Trace:

[jira] [Commented] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869738#comment-13869738
 ] 

Hadoop QA commented on ZOOKEEPER-1837:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12622661/ZOOKEEPER-1837.patch
  against trunk revision 1556976.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1879//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1879//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1879//console

This message is automatically generated.

 Fix JMXEnv checks (potential race conditions)
 -

 Key: ZOOKEEPER-1837
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: tests
Affects Versions: 3.4.5, 3.5.0
 Environment: Windows 8
Reporter: Germán Blanco
Assignee: Germán Blanco
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1837-b3.4.patch, ZOOKEEPER-1837-b3.4.patch, 
 ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch


 The following failures in ZooKeeper-3.4-WinVS2008_java and 
 ZooKeeper-trunk-WinVS2008_java require fixing:
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 

[jira] [Commented] (ZOOKEEPER-1861) ConcurrentHashMap isn't used properly in QuorumCnxManager

[Michi Mutsuzaki (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869840#comment-13869840
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1861:


Thank you for the bug report Ted. Would it be ok if I assign the ticket to you?

 ConcurrentHashMap isn't used properly in QuorumCnxManager
 -

 Key: ZOOKEEPER-1861
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1861
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Yu
Priority: Minor

 queueSendMap is a ConcurrentHashMap.
 At line 210:
 {code}
 if (!queueSendMap.containsKey(sid)) {
 queueSendMap.put(sid, new ArrayBlockingQueueByteBuffer(
 SEND_CAPACITY));
 {code}
 By the time control enters if block, there may be another concurrent put with 
 same sid to the ConcurrentHashMap.
 putIfAbsent() should be used.
 Similar issue occurs at line 307 as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Updated] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)

[JIRA]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Germán Blanco updated ZOOKEEPER-1837:
-

Attachment: ZOOKEEPER-1837.patch

 Fix JMXEnv checks (potential race conditions)
 -

 Key: ZOOKEEPER-1837
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: tests
Affects Versions: 3.4.5, 3.5.0
 Environment: Windows 8
Reporter: Germán Blanco
Assignee: Germán Blanco
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1837-b3.4.patch, ZOOKEEPER-1837-b3.4.patch, 
 ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch, 
 ZOOKEEPER-1837.patch


 The following failures in ZooKeeper-3.4-WinVS2008_java and 
 ZooKeeper-trunk-WinVS2008_java require fixing:
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit]   at 
 org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
 [
 junit.framework.AssertionFailedError: expected [0x142e5f027b50001] 
 expected:1 but was:0
   at org.apache.zookeeper.test.JMXEnv.ensureAll(JMXEnv.java:115)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:197)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:171)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:156)
   at 
 org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:149)
   at 
 org.apache.zookeeper.ZooKeeperTest.testDeleteRecursive(ZooKeeperTest.java:45)
   at 
 org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Updated] (ZOOKEEPER-1861) ConcurrentHashMap isn't used properly in QuorumCnxManager

[Ted Yu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated ZOOKEEPER-1861:
--

Attachment: zookeeper-1861-v1.txt

Sure.

Here is the patch.

 ConcurrentHashMap isn't used properly in QuorumCnxManager
 -

 Key: ZOOKEEPER-1861
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1861
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
 Attachments: zookeeper-1861-v1.txt


 queueSendMap is a ConcurrentHashMap.
 At line 210:
 {code}
 if (!queueSendMap.containsKey(sid)) {
 queueSendMap.put(sid, new ArrayBlockingQueueByteBuffer(
 SEND_CAPACITY));
 {code}
 By the time control enters if block, there may be another concurrent put with 
 same sid to the ConcurrentHashMap.
 putIfAbsent() should be used.
 Similar issue occurs at line 307 as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869929#comment-13869929
 ] 

Hadoop QA commented on ZOOKEEPER-1837:
--

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12622685/ZOOKEEPER-1837.patch
  against trunk revision 1556976.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1880//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1880//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1880//console

This message is automatically generated.

 Fix JMXEnv checks (potential race conditions)
 -

 Key: ZOOKEEPER-1837
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: tests
Affects Versions: 3.4.5, 3.5.0
 Environment: Windows 8
Reporter: Germán Blanco
Assignee: Germán Blanco
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1837-b3.4.patch, ZOOKEEPER-1837-b3.4.patch, 
 ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch, 
 ZOOKEEPER-1837.patch


 The following failures in ZooKeeper-3.4-WinVS2008_java and 
 ZooKeeper-trunk-WinVS2008_java require fixing:
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 
 org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 [junit] junit.framework.AssertionFailedError: expected:0 but was:1
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
 [junit]   at 
 org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [junit]   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [junit]   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [junit]   at java.lang.reflect.Method.invoke(Method.java:597)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
 [junit]   at 
 org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 [junit]   at 
 org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
 [junit]   at 

Success: ZOOKEEPER-1837 PreCommit Build #1880

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1837
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1880/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 288381 lines...]
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 0 seconds
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12622685/ZOOKEEPER-1837.patch
 [exec]   against trunk revision 1556976.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 9 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1880//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1880//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1880//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] e94ec4168a0dfc6f3cfea15449189991b645a707 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 33 minutes 39 seconds
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1837
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1861) ConcurrentHashMap isn't used properly in QuorumCnxManager

[Michi Mutsuzaki (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870003#comment-13870003
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1861:


Thank you for the patch Ted. Here are my comments:

- This patch only fixes the issue at line 210, but not the one at 307.
- There is a similar issue at 338, though this one is slightly more complicated 
since it does more than putting something in a map inside the containsKey block.

 ConcurrentHashMap isn't used properly in QuorumCnxManager
 -

 Key: ZOOKEEPER-1861
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1861
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
 Attachments: zookeeper-1861-v1.txt


 queueSendMap is a ConcurrentHashMap.
 At line 210:
 {code}
 if (!queueSendMap.containsKey(sid)) {
 queueSendMap.put(sid, new ArrayBlockingQueueByteBuffer(
 SEND_CAPACITY));
 {code}
 By the time control enters if block, there may be another concurrent put with 
 same sid to the ConcurrentHashMap.
 putIfAbsent() should be used.
 Similar issue occurs at line 307 as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Failed: ZOOKEEPER-1861 PreCommit Build #1881

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1861
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1881/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 274826 lines...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12622695/zookeeper-1861-v1.txt
 [exec]   against trunk revision 1556976.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1881//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1881//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1881//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] e121e0306e22672d52da56f69660428f811c84e3 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674:
 exec returned: 1

Total time: 33 minutes 52 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1861
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1861) ConcurrentHashMap isn't used properly in QuorumCnxManager

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870037#comment-13870037
 ] 

Hadoop QA commented on ZOOKEEPER-1861:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12622695/zookeeper-1861-v1.txt
  against trunk revision 1556976.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1881//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1881//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1881//console

This message is automatically generated.

 ConcurrentHashMap isn't used properly in QuorumCnxManager
 -

 Key: ZOOKEEPER-1861
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1861
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
 Attachments: zookeeper-1861-v1.txt, zookeeper-1861-v2.txt


 queueSendMap is a ConcurrentHashMap.
 At line 210:
 {code}
 if (!queueSendMap.containsKey(sid)) {
 queueSendMap.put(sid, new ArrayBlockingQueueByteBuffer(
 SEND_CAPACITY));
 {code}
 By the time control enters if block, there may be another concurrent put with 
 same sid to the ConcurrentHashMap.
 putIfAbsent() should be used.
 Similar issue occurs at line 307 as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Updated] (ZOOKEEPER-1861) ConcurrentHashMap isn't used properly in QuorumCnxManager

[Ted Yu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated ZOOKEEPER-1861:
--

Attachment: zookeeper-1861-v2.txt

Patch v2 addresses Michi's comments

 ConcurrentHashMap isn't used properly in QuorumCnxManager
 -

 Key: ZOOKEEPER-1861
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1861
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
 Attachments: zookeeper-1861-v1.txt, zookeeper-1861-v2.txt


 queueSendMap is a ConcurrentHashMap.
 At line 210:
 {code}
 if (!queueSendMap.containsKey(sid)) {
 queueSendMap.put(sid, new ArrayBlockingQueueByteBuffer(
 SEND_CAPACITY));
 {code}
 By the time control enters if block, there may be another concurrent put with 
 same sid to the ConcurrentHashMap.
 putIfAbsent() should be used.
 Similar issue occurs at line 307 as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Failed: ZOOKEEPER-1861 PreCommit Build #1882

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1861
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1882/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 269065 lines...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12622714/zookeeper-1861-v2.txt
 [exec]   against trunk revision 1556976.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1882//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1882//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1882//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] a7fafb81ea5807080df28d0e51120209a816c8b7 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674:
 exec returned: 1

Total time: 33 minutes 17 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1861
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1861) ConcurrentHashMap isn't used properly in QuorumCnxManager

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870072#comment-13870072
 ] 

Hadoop QA commented on ZOOKEEPER-1861:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12622714/zookeeper-1861-v2.txt
  against trunk revision 1556976.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1882//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1882//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1882//console

This message is automatically generated.

 ConcurrentHashMap isn't used properly in QuorumCnxManager
 -

 Key: ZOOKEEPER-1861
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1861
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
 Attachments: zookeeper-1861-v1.txt, zookeeper-1861-v2.txt


 queueSendMap is a ConcurrentHashMap.
 At line 210:
 {code}
 if (!queueSendMap.containsKey(sid)) {
 queueSendMap.put(sid, new ArrayBlockingQueueByteBuffer(
 SEND_CAPACITY));
 {code}
 By the time control enters if block, there may be another concurrent put with 
 same sid to the ConcurrentHashMap.
 putIfAbsent() should be used.
 Similar issue occurs at line 307 as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (ZOOKEEPER-442) need a way to remove watches that are no longer of interest

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870405#comment-13870405
 ] 

Patrick Hunt commented on ZOOKEEPER-442:


I'm afraid something is not quite right. I created a very simple sanity check 
which seems to be failing. :-( Please check my logic/code (note: I have some 
time this week and I'd like to keep the momentum going on this one.)

In the first case the code I created will create a watch by calling exists on a 
non-existent node (call it pre-removewatches). It does this in a loop. I 
expect the memory to become exhausted on the client. In the second case I 
immediately call removewatch on the just-set-watch. In the second case I 
expect that client to run forever (essentially). However in both cases the 
clients crash. I am using the latest patch applied to trunk codebase for this 
testing. (notice the second case does run a bit longer than the first, but 
still, based on the code I have it should run ess. forever):

first case:
{noformat}
USE_REMOVE_CALL:false
maxIter:10
maxLoops:1
Available free mem is 14614744
j:0
Available free mem is 12184072
j:1
Available free mem is 8827120
j:2
Available free mem is 6141912
j:3
Available free mem is 2600160
j:4
OOMException
{noformat}

second case:
{noformat}
USE_REMOVE_CALL:true
maxIter:10
maxLoops:1
Available free mem is 14613488
j:0
Available free mem is 12497584
j:1
Available free mem is 9470512
j:2
Available free mem is 7167880
j:3
Available free mem is 3841616
j:4
Available free mem is 854728
j:5
OOMException
{noformat}

I've posted my code to github, it's pretty simple. see:
https://github.com/phunt/zookeeper-removewatch-ex/blob/master/src/test/java/org/phunt/zookeeper/removewatchexample/ExerciseRemoveWatchTest.java

Notice the boolean USE_REMOVE_CALL at the top of the class. You can replicate 
the two output scenarios above by setting this to false (no remove) and true 
(call remove). Then running the test via mvn test at the toplevel. (note you 
need to install the 3.5.0-SNAPSHOT artifacts in your local maven cache, you can 
do this by running ant package in ZK and copying the resulting artifacts from 
the build subdir dist-maven directory into your .m2 repository)

Does my code make sense? It seems to me that given we're calling exists (on 
non-existent node), setting a watch, then immediately removing the watch, that 
the code should run w/o running out of memory.

I suspect the issue is that we are setting up some data structures to hold the 
watch information, but not fully clearing that data when removing the watch

any ideas? 

 need a way to remove watches that are no longer of interest
 ---

 Key: ZOOKEEPER-442
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-442
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: java client, server
Reporter: Benjamin Reed
Assignee: Rakesh R
Priority: Critical
 Fix For: 3.5.0

 Attachments: Remove Watch API.pdf, ZOOKEEPER-442.patch, 
 ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, 
 ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, 
 ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, 
 ZOOKEEPER-442.patch, ZOOKEEPER-442.patch


 currently the only way a watch cleared is to trigger it. we need a way to 
 enumerate the outstanding watch objects, find watch events the objects are 
 watching for, and remove interests in an event.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (ZOOKEEPER-442) need a way to remove watches that are no longer of interest

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870437#comment-13870437
 ] 

Rakesh R commented on ZOOKEEPER-442:


Thanks [~phunt] for the scenario. Looks like test code is fine and I will try 
exeucte the same in my env.

 need a way to remove watches that are no longer of interest
 ---

 Key: ZOOKEEPER-442
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-442
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: java client, server
Reporter: Benjamin Reed
Assignee: Rakesh R
Priority: Critical
 Fix For: 3.5.0

 Attachments: Remove Watch API.pdf, ZOOKEEPER-442.patch, 
 ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, 
 ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, 
 ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, 
 ZOOKEEPER-442.patch, ZOOKEEPER-442.patch


 currently the only way a watch cleared is to trigger it. we need a way to 
 enumerate the outstanding watch objects, find watch events the objects are 
 watching for, and remove interests in an event.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

ZooKeeper_branch33_solaris - Build # 767 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch33_solaris/767/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 102294 lines...]
[junit] 2014-01-14 06:55:45,240 - INFO  [main:ZooKeeperServer@154] - 
Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test1552552751967602122.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test1552552751967602122.junit.dir/version-2
[junit] 2014-01-14 06:55:45,241 - INFO  [main:NIOServerCnxn$Factory@143] - 
binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2014-01-14 06:55:45,243 - INFO  [main:FileSnap@82] - Reading 
snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test1552552751967602122.junit.dir/version-2/snapshot.0
[junit] 2014-01-14 06:55:45,247 - INFO  [main:FileTxnSnapLog@256] - 
Snapshotting: b
[junit] 2014-01-14 06:55:45,249 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] 2014-01-14 06:55:45,250 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - 
Accepted socket connection from /127.0.0.1:34366
[junit] 2014-01-14 06:55:45,251 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing 
stat command from /127.0.0.1:34366
[junit] 2014-01-14 06:55:45,252 - INFO  
[Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output
[junit] 2014-01-14 06:55:45,252 - INFO  [Thread-4:NIOServerCnxn@1435] - 
Closed socket connection for client /127.0.0.1:34366 (no session established 
for client)
[junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] expect:InMemoryDataTree
[junit] found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] expect:StandaloneServer_port
[junit] found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2014-01-14 06:55:45,264 - INFO  [main:ClientBase@408] - STOPPING 
server
[junit] 2014-01-14 06:55:45,265 - INFO  
[ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop!
[junit] 2014-01-14 06:55:45,265 - INFO  
[SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited!
[junit] 2014-01-14 06:55:45,266 - INFO  [main:FinalRequestProcessor@370] - 
shutdown of request processor complete
[junit] 2014-01-14 06:55:45,267 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] ensureOnly:[]
[junit] 2014-01-14 06:55:45,269 - INFO  [main:ClientBase@401] - STARTING 
server
[junit] 2014-01-14 06:55:45,269 - INFO  [main:ZooKeeperServer@154] - 
Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test1552552751967602122.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test1552552751967602122.junit.dir/version-2
[junit] 2014-01-14 06:55:45,270 - INFO  [main:NIOServerCnxn$Factory@143] - 
binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2014-01-14 06:55:45,272 - INFO  [main:FileSnap@82] - Reading 
snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test1552552751967602122.junit.dir/version-2/snapshot.b
[junit] 2014-01-14 06:55:45,274 - INFO  [main:FileTxnSnapLog@256] - 
Snapshotting: b
[junit] 2014-01-14 06:55:45,276 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] 2014-01-14 06:55:45,277 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - 
Accepted socket connection from /127.0.0.1:34368
[junit] 2014-01-14 06:55:45,278 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing 
stat command from /127.0.0.1:34368
[junit] 2014-01-14 06:55:45,278 - INFO  
[Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output
[junit] 2014-01-14 06:55:45,279 - INFO  [Thread-5:NIOServerCnxn@1435] - 
Closed socket connection for client /127.0.0.1:34368 (no session established 
for client)
[junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] expect:InMemoryDataTree
[junit] found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] expect:StandaloneServer_port
[junit] found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2014-01-14 06:55:45,281 - INFO  

[jira] [Updated] (ZOOKEEPER-1858) JMX checks - potential race conditions while stopping and starting server

[Rakesh R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated ZOOKEEPER-1858:


Attachment: ZOOKEEPER-1858.patch

 JMX checks - potential race conditions while stopping and starting server
 -

 Key: ZOOKEEPER-1858
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1858
 Project: ZooKeeper
  Issue Type: Sub-task
Reporter: Rakesh R
Assignee: Rakesh R
  Labels: test
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1858-br3.4.patch, ZOOKEEPER-1858.patch, 
 ZOOKEEPER-1858.patch


 I've noticed one potential case, where previously created zkclient session 
 immediately reconnected and publishing those beans while starting back the 
 zkserver and affecting zk#startup jmx checks.
 Say, before stopping the server, there is a zk client session 
 0x143576544c5 exists. While starting back the server, there could be 
 possibility of seeing the client sessions in jmx. Following is one such case. 
 Please see below logs which has taken from build 
 https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/642/
 {code}[junit] 2014-01-03 09:18:12,809 [myid:] - INFO  
 [main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1228] - Session 
 establishment complete on server 127.0.0.1/127.0.0.1:11222, sessionid = 
 0x143576544c5, negotiated timeout = 3
 [junit] 2014-01-03 09:18:12,809 [myid:] - INFO  
 [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11222:ZooKeeperServer@617] - 
 Established session 0x143576544c5 with negotiated timeout 3 for 
 client /127.0.0.1:55377{code}
 {code} [junit] 2014-01-03 09:18:12,391 [myid:] - INFO  [main:JMXEnv@135] - 
 ensureOnly:[]
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@438] - 
 STARTING server
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@359] - 
 CREATING server instance 127.0.0.1:11222
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  
 [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11222
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@334] - 
 STARTING server instance 127.0.0.1:11222
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - 
 unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=Connections,name2=127.0.0.1,name3=0x143576544c5
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - 
 unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  
 [main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED 
 testDefaultWatcherAutoResetWithChroot
 [junit] junit.framework.AssertionFailedError: expected:0 but was:2
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:144)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:443)
 [junit]   at 
 org.apache.zookeeper.test.DisconnectedWatcherTest.testDefaultWatcherAutoResetWithChroot(DisconnectedWatcherTest.java:123)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (ZOOKEEPER-1858) JMX checks - potential race conditions while stopping and starting server

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870466#comment-13870466
 ] 

Rakesh R commented on ZOOKEEPER-1858:
-

Hi Flavio, I agree with you, my previous logic was changing the semantics of 
ensureAll api.
Can you please look at the latest patch, where I tried to solve the problem in 
parent and child beans approach. Does this sound good to you?

 JMX checks - potential race conditions while stopping and starting server
 -

 Key: ZOOKEEPER-1858
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1858
 Project: ZooKeeper
  Issue Type: Sub-task
Reporter: Rakesh R
Assignee: Rakesh R
  Labels: test
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1858-br3.4.patch, ZOOKEEPER-1858.patch, 
 ZOOKEEPER-1858.patch


 I've noticed one potential case, where previously created zkclient session 
 immediately reconnected and publishing those beans while starting back the 
 zkserver and affecting zk#startup jmx checks.
 Say, before stopping the server, there is a zk client session 
 0x143576544c5 exists. While starting back the server, there could be 
 possibility of seeing the client sessions in jmx. Following is one such case. 
 Please see below logs which has taken from build 
 https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/642/
 {code}[junit] 2014-01-03 09:18:12,809 [myid:] - INFO  
 [main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1228] - Session 
 establishment complete on server 127.0.0.1/127.0.0.1:11222, sessionid = 
 0x143576544c5, negotiated timeout = 3
 [junit] 2014-01-03 09:18:12,809 [myid:] - INFO  
 [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11222:ZooKeeperServer@617] - 
 Established session 0x143576544c5 with negotiated timeout 3 for 
 client /127.0.0.1:55377{code}
 {code} [junit] 2014-01-03 09:18:12,391 [myid:] - INFO  [main:JMXEnv@135] - 
 ensureOnly:[]
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@438] - 
 STARTING server
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@359] - 
 CREATING server instance 127.0.0.1:11222
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  
 [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11222
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@334] - 
 STARTING server instance 127.0.0.1:11222
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - 
 unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=Connections,name2=127.0.0.1,name3=0x143576544c5
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - 
 unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  
 [main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED 
 testDefaultWatcherAutoResetWithChroot
 [junit] junit.framework.AssertionFailedError: expected:0 but was:2
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:144)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:443)
 [junit]   at 
 org.apache.zookeeper.test.DisconnectedWatcherTest.testDefaultWatcherAutoResetWithChroot(DisconnectedWatcherTest.java:123)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (ZOOKEEPER-1858) JMX checks - potential race conditions while stopping and starting server

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870470#comment-13870470
 ] 

Hadoop QA commented on ZOOKEEPER-1858:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12622803/ZOOKEEPER-1858.patch
  against trunk revision 1557875.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 12 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1883//console

This message is automatically generated.

 JMX checks - potential race conditions while stopping and starting server
 -

 Key: ZOOKEEPER-1858
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1858
 Project: ZooKeeper
  Issue Type: Sub-task
Reporter: Rakesh R
Assignee: Rakesh R
  Labels: test
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1858-br3.4.patch, ZOOKEEPER-1858.patch, 
 ZOOKEEPER-1858.patch


 I've noticed one potential case, where previously created zkclient session 
 immediately reconnected and publishing those beans while starting back the 
 zkserver and affecting zk#startup jmx checks.
 Say, before stopping the server, there is a zk client session 
 0x143576544c5 exists. While starting back the server, there could be 
 possibility of seeing the client sessions in jmx. Following is one such case. 
 Please see below logs which has taken from build 
 https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/642/
 {code}[junit] 2014-01-03 09:18:12,809 [myid:] - INFO  
 [main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1228] - Session 
 establishment complete on server 127.0.0.1/127.0.0.1:11222, sessionid = 
 0x143576544c5, negotiated timeout = 3
 [junit] 2014-01-03 09:18:12,809 [myid:] - INFO  
 [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11222:ZooKeeperServer@617] - 
 Established session 0x143576544c5 with negotiated timeout 3 for 
 client /127.0.0.1:55377{code}
 {code} [junit] 2014-01-03 09:18:12,391 [myid:] - INFO  [main:JMXEnv@135] - 
 ensureOnly:[]
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@438] - 
 STARTING server
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@359] - 
 CREATING server instance 127.0.0.1:11222
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  
 [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11222
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@334] - 
 STARTING server instance 127.0.0.1:11222
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - 
 unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=Connections,name2=127.0.0.1,name3=0x143576544c5
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - 
 unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  
 [main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED 
 testDefaultWatcherAutoResetWithChroot
 [junit] junit.framework.AssertionFailedError: expected:0 but was:2
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:144)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:443)
 [junit]   at 
 org.apache.zookeeper.test.DisconnectedWatcherTest.testDefaultWatcherAutoResetWithChroot(DisconnectedWatcherTest.java:123)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Failed: ZOOKEEPER-1858 PreCommit Build #1883

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1858
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1883/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 68 lines...]
 [exec] 
 [exec] 
 [exec] patching file 
src/java/test/org/apache/zookeeper/test/ClientBase.java
 [exec] Hunk #2 FAILED at 193.
 [exec] Hunk #3 succeeded at 445 (offset 1 line).
 [exec] 1 out of 3 hunks FAILED -- saving rejects to file 
src/java/test/org/apache/zookeeper/test/ClientBase.java.rej
 [exec] patching file 
src/java/test/org/apache/zookeeper/test/FourLetterWordsQuorumTest.java
 [exec] patching file 
src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
 [exec] patching file src/java/test/org/apache/zookeeper/test/JMXEnv.java
 [exec] Hunk #1 succeeded at 174 (offset -6 lines).
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12622803/ZOOKEEPER-1858.patch
 [exec]   against trunk revision 1557875.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 12 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1883//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 26d6e21a64a4cd45e095b230b508179add290277 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1674:
 exec returned: 1

Total time: 1 minute 7 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1858
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-1858) JMX checks - potential race conditions while stopping and starting server

[Rakesh R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated ZOOKEEPER-1858:


Attachment: ZOOKEEPER-1858.patch

 JMX checks - potential race conditions while stopping and starting server
 -

 Key: ZOOKEEPER-1858
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1858
 Project: ZooKeeper
  Issue Type: Sub-task
Reporter: Rakesh R
Assignee: Rakesh R
  Labels: test
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1858-br3.4.patch, ZOOKEEPER-1858.patch, 
 ZOOKEEPER-1858.patch, ZOOKEEPER-1858.patch


 I've noticed one potential case, where previously created zkclient session 
 immediately reconnected and publishing those beans while starting back the 
 zkserver and affecting zk#startup jmx checks.
 Say, before stopping the server, there is a zk client session 
 0x143576544c5 exists. While starting back the server, there could be 
 possibility of seeing the client sessions in jmx. Following is one such case. 
 Please see below logs which has taken from build 
 https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/642/
 {code}[junit] 2014-01-03 09:18:12,809 [myid:] - INFO  
 [main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1228] - Session 
 establishment complete on server 127.0.0.1/127.0.0.1:11222, sessionid = 
 0x143576544c5, negotiated timeout = 3
 [junit] 2014-01-03 09:18:12,809 [myid:] - INFO  
 [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11222:ZooKeeperServer@617] - 
 Established session 0x143576544c5 with negotiated timeout 3 for 
 client /127.0.0.1:55377{code}
 {code} [junit] 2014-01-03 09:18:12,391 [myid:] - INFO  [main:JMXEnv@135] - 
 ensureOnly:[]
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@438] - 
 STARTING server
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@359] - 
 CREATING server instance 127.0.0.1:11222
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  
 [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11222
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@334] - 
 STARTING server instance 127.0.0.1:11222
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - 
 unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=Connections,name2=127.0.0.1,name3=0x143576544c5
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - 
 unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  
 [main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED 
 testDefaultWatcherAutoResetWithChroot
 [junit] junit.framework.AssertionFailedError: expected:0 but was:2
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:144)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:443)
 [junit]   at 
 org.apache.zookeeper.test.DisconnectedWatcherTest.testDefaultWatcherAutoResetWithChroot(DisconnectedWatcherTest.java:123)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

[jira] [Commented] (ZOOKEEPER-1858) JMX checks - potential race conditions while stopping and starting server

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870487#comment-13870487
 ] 

Rakesh R commented on ZOOKEEPER-1858:
-

Ah. Previously attached patch is from branch3.4. Attaching new patch generated 
from trunk.

 JMX checks - potential race conditions while stopping and starting server
 -

 Key: ZOOKEEPER-1858
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1858
 Project: ZooKeeper
  Issue Type: Sub-task
Reporter: Rakesh R
Assignee: Rakesh R
  Labels: test
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1858-br3.4.patch, ZOOKEEPER-1858.patch, 
 ZOOKEEPER-1858.patch, ZOOKEEPER-1858.patch


 I've noticed one potential case, where previously created zkclient session 
 immediately reconnected and publishing those beans while starting back the 
 zkserver and affecting zk#startup jmx checks.
 Say, before stopping the server, there is a zk client session 
 0x143576544c5 exists. While starting back the server, there could be 
 possibility of seeing the client sessions in jmx. Following is one such case. 
 Please see below logs which has taken from build 
 https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/642/
 {code}[junit] 2014-01-03 09:18:12,809 [myid:] - INFO  
 [main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1228] - Session 
 establishment complete on server 127.0.0.1/127.0.0.1:11222, sessionid = 
 0x143576544c5, negotiated timeout = 3
 [junit] 2014-01-03 09:18:12,809 [myid:] - INFO  
 [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11222:ZooKeeperServer@617] - 
 Established session 0x143576544c5 with negotiated timeout 3 for 
 client /127.0.0.1:55377{code}
 {code} [junit] 2014-01-03 09:18:12,391 [myid:] - INFO  [main:JMXEnv@135] - 
 ensureOnly:[]
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@438] - 
 STARTING server
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@359] - 
 CREATING server instance 127.0.0.1:11222
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  
 [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11222
 [junit] 2014-01-03 09:18:12,395 [myid:] - INFO  [main:ClientBase@334] - 
 STARTING server instance 127.0.0.1:11222
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - 
 unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=Connections,name2=127.0.0.1,name3=0x143576544c5
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  [main:JMXEnv@142] - 
 unexpected:org.apache.ZooKeeperService:name0=StandaloneServer_port-1
 [junit] 2014-01-03 09:18:19,030 [myid:] - INFO  
 [main:JUnit4ZKTestRunner$LoggedInvokeMethod@62] - TEST METHOD FAILED 
 testDefaultWatcherAutoResetWithChroot
 [junit] junit.framework.AssertionFailedError: expected:0 but was:2
 [junit]   at junit.framework.Assert.fail(Assert.java:47)
 [junit]   at junit.framework.Assert.failNotEquals(Assert.java:283)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:64)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:195)
 [junit]   at junit.framework.Assert.assertEquals(Assert.java:201)
 [junit]   at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:144)
 [junit]   at 
 org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:443)
 [junit]   at 
 org.apache.zookeeper.test.DisconnectedWatcherTest.testDefaultWatcherAutoResetWithChroot(DisconnectedWatcherTest.java:123)
 [junit]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

ZooKeeper_branch34_solaris - Build # 768 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_solaris/768/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 164777 lines...]
[junit] 2014-01-14 07:55:29,994 [myid:] - INFO  [main:ClientBase@447] - 
STOPPING server
[junit] 2014-01-14 07:55:29,994 [myid:] - INFO  [main:ZooKeeperServer@441] 
- shutting down
[junit] 2014-01-14 07:55:29,995 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2014-01-14 07:55:29,995 [myid:] - INFO  
[main:PrepRequestProcessor@761] - Shutting down
[junit] 2014-01-14 07:55:29,995 [myid:] - INFO  
[main:SyncRequestProcessor@209] - Shutting down
[junit] 2014-01-14 07:55:29,995 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2014-01-14 07:55:29,995 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited!
[junit] 2014-01-14 07:55:29,995 [myid:] - INFO  
[main:FinalRequestProcessor@415] - shutdown of request processor complete
[junit] 2014-01-14 07:55:29,996 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-01-14 07:55:29,996 [myid:] - INFO  [main:JMXEnv@135] - 
ensureOnly:[]
[junit] 2014-01-14 07:55:29,997 [myid:] - INFO  [main:ClientBase@438] - 
STARTING server
[junit] 2014-01-14 07:55:29,997 [myid:] - INFO  [main:ClientBase@359] - 
CREATING server instance 127.0.0.1:11221
[junit] 2014-01-14 07:55:29,998 [myid:] - INFO  
[main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2014-01-14 07:55:29,998 [myid:] - INFO  [main:ClientBase@334] - 
STARTING server instance 127.0.0.1:11221
[junit] 2014-01-14 07:55:29,998 [myid:] - INFO  [main:ZooKeeperServer@162] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test2020516055941306727.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test2020516055941306727.junit.dir/version-2
[junit] 2014-01-14 07:55:30,001 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-01-14 07:55:30,001 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - 
Accepted socket connection from /127.0.0.1:44074
[junit] 2014-01-14 07:55:30,001 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:44074
[junit] 2014-01-14 07:55:30,002 [myid:] - INFO  
[Thread-5:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2014-01-14 07:55:30,002 [myid:] - INFO  
[Thread-5:NIOServerCnxn@1007] - Closed socket connection for client 
/127.0.0.1:44074 (no session established for client)
[junit] 2014-01-14 07:55:30,002 [myid:] - INFO  [main:JMXEnv@135] - 
ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2014-01-14 07:55:30,003 [myid:] - INFO  [main:JMXEnv@105] - 
expect:InMemoryDataTree
[junit] 2014-01-14 07:55:30,003 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop!
[junit] 2014-01-14 07:55:30,003 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop!
[junit] 2014-01-14 07:55:30,003 [myid:] - INFO  [main:JMXEnv@108] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2014-01-14 07:55:30,004 [myid:] - INFO  [main:JMXEnv@105] - 
expect:StandaloneServer_port
[junit] 2014-01-14 07:55:30,004 [myid:] - INFO  [main:JMXEnv@108] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2014-01-14 07:55:30,004 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 9053
[junit] 2014-01-14 07:55:30,004 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 18
[junit] 2014-01-14 07:55:30,005 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota
[junit] 2014-01-14 07:55:30,005 [myid:] - INFO  [main:ClientBase@477] - 
tearDown starting
[junit] 2014-01-14 07:55:30,054 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@509] - EventThread shut down
[junit] 2014-01-14 07:55:30,054 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x1438fbf8422 closed
[junit] 2014-01-14 07:55:30,055 [myid:] - INFO  [main:ClientBase@447] - 
STOPPING server
[junit] 2014-01-14 07:55:30,055 [myid:] - INFO  [main:ZooKeeperServer@441] 
- shutting down
[junit] 2014-01-14 07:55:30,056 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2014-01-14 07:55:30,056 

Jenkins build is back to normal : bookkeeper-trunk #506

[Apache Jenkins Server]

See https://builds.apache.org/job/bookkeeper-trunk/506/