[jira] [Commented] (ZOOKEEPER-1963) Make JDK 7 the minimum requirement for Zookeeper

[Edward Carter (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059559#comment-14059559
 ] 

Edward Carter commented on ZOOKEEPER-1963:
--

>From the console output, it seems like this is failing because the Jenkins 
>host is using JDK 5 or 6.

> Make JDK 7 the minimum requirement for Zookeeper
> 
>
> Key: ZOOKEEPER-1963
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1963
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Edward Carter
> Fix For: 3.6.0, 4.0.0
>
> Attachments: ZOOKEEPER-1963.patch
>
>
> JDK 6 stopped receiving public updates in early 2013:
> http://www.oracle.com/technetwork/java/eol-135779.html
> I propose making JDK 7 the minimum for Zookeeper going forward.  One patch 
> that I've personally submitted already would have been a good fit for Java 
> 7's try-with-resources statement, and another pending patch fails to build on 
> versions of Java prior to 7 because a unit test in it uses 
> InetAddress.getLoopbackAddress(), which would be awkward to replace.  I'm 
> sure there are many other examples.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (ZOOKEEPER-1964) Fix Flaky Test in ReconfigTest.java

[Hongchao Deng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hongchao Deng updated ZOOKEEPER-1964:
-

Summary: Fix Flaky Test in ReconfigTest.java  (was: Fixing Flaky in 
ReconfigTest.java)

> Fix Flaky Test in ReconfigTest.java
> ---
>
> Key: ZOOKEEPER-1964
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1964
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Hongchao Deng
>Assignee: Hongchao Deng
>Priority: Minor
> Attachments: ZOOKEEPER-1964.patch
>
>
> There is flaky tests in ReconfigTest showing something like:
> {code}
> junit.framework.AssertionFailedError: Mismatches ElectionAddress! 
> expected:<[127.0.0.1]:12369> but was:<[localhost]:12369>
>   at 
> org.apache.zookeeper.test.ReconfigTest.assertRemotePeerMXBeanAttributes(ReconfigTest.java:967)
>   at 
> org.apache.zookeeper.test.ReconfigTest.testJMXBeanAfterRemoveAddOne(ReconfigTest.java:809)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}
> Basically, the problem is that there might be inconsistency between numerical 
> ip and literal ip. Converting both sides to one (numerical IP) will fix it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (ZOOKEEPER-1964) Fixing Flaky in ReconfigTest.java

[Hongchao Deng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hongchao Deng updated ZOOKEEPER-1964:
-

Attachment: ZOOKEEPER-1964.patch

> Fixing Flaky in ReconfigTest.java
> -
>
> Key: ZOOKEEPER-1964
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1964
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Hongchao Deng
>Assignee: Hongchao Deng
>Priority: Minor
> Attachments: ZOOKEEPER-1964.patch
>
>
> There is flaky tests in ReconfigTest showing something like:
> {code}
> junit.framework.AssertionFailedError: Mismatches ElectionAddress! 
> expected:<[127.0.0.1]:12369> but was:<[localhost]:12369>
>   at 
> org.apache.zookeeper.test.ReconfigTest.assertRemotePeerMXBeanAttributes(ReconfigTest.java:967)
>   at 
> org.apache.zookeeper.test.ReconfigTest.testJMXBeanAfterRemoveAddOne(ReconfigTest.java:809)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}
> Basically, the problem is that there might be inconsistency between numerical 
> ip and literal ip. Converting both sides to one (numerical IP) will fix it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Created] (ZOOKEEPER-1964) Fixing Flaky in ReconfigTest.java

[Hongchao Deng (JIRA)]

Hongchao Deng created ZOOKEEPER-1964:


 Summary: Fixing Flaky in ReconfigTest.java
 Key: ZOOKEEPER-1964
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1964
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Hongchao Deng
Assignee: Hongchao Deng
Priority: Minor


There is flaky tests in ReconfigTest showing something like:
{code}
junit.framework.AssertionFailedError: Mismatches ElectionAddress! 
expected:<[127.0.0.1]:12369> but was:<[localhost]:12369>
at 
org.apache.zookeeper.test.ReconfigTest.assertRemotePeerMXBeanAttributes(ReconfigTest.java:967)
at 
org.apache.zookeeper.test.ReconfigTest.testJMXBeanAfterRemoveAddOne(ReconfigTest.java:809)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
{code}

Basically, the problem is that there might be inconsistency between numerical 
ip and literal ip. Converting both sides to one (numerical IP) will fix it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: svn upgrade issue

[Flavio Junqueira]

Thanks, Giri.

-Flavio

On 11 Jul 2014, at 19:26, Patrick Hunt  wrote:

> Ok, great. Thanks Giri!
> 
> Patrick
> 
> On Fri, Jul 11, 2014 at 10:53 AM, Giridharan Kesavan
>  wrote:
>> Patrick,
>> 
>> Jenkins slaves moved from ubuntu-10.04 to 14.04, with that come the svn
>> client upgrade.
>> 
>> Fixed the svn upgrade.
>> 
>> -giri
>> 
>> 
>> On Fri, Jul 11, 2014 at 8:52 AM, Patrick Hunt  wrote:
>>> 
>>> Typically you run "svn upgrade" in the svn repo. Either that or remove
>>> the repo and check it out again.
>>> 
>>> Giri can you do that?
>>> 
>>> 
>>> Was svn upgraded on that machine or something? Why is the svn version
>>> changing?
>>> 
>>> Patrick
>>> 
>>> On Fri, Jul 11, 2014 at 8:11 AM, FPJ 
>>> wrote:
 The precommit build is getting this error:
 
 
 
 [exec] svn: E155036: Please see the 'svn upgrade' command
 
 [exec] svn: E155036: The working copy at
 '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
 
 [exec] is too old (format 10) to work with client version '1.8.8
 (r1568071)' (expects format 31). You need to upgrade the working copy
 first.
 
 
 
 We need to get it upgraded.  What's the way to do it?
 
 
 
 -Flavio
 
>> 
>> 
>> 
>> CONFIDENTIALITY NOTICE
>> NOTICE: This message is intended for the use of the individual or entity to
>> which it is addressed and may contain information that is confidential,
>> privileged and exempt from disclosure under applicable law. If the reader of
>> this message is not the intended recipient, you are hereby notified that any
>> printing, copying, dissemination, distribution, disclosure or forwarding of
>> this communication is strictly prohibited. If you have received this
>> communication in error, please contact the sender immediately and delete it
>> from your system. Thank You.

Re: Review Request 23259: ZOOKEEPER-1346 - Jetty server for RESTful command interface

[Bill Havanki]

> On July 11, 2014, 2:32 p.m., Raul Gutierrez Segales wrote:
> > src/java/main/org/apache/zookeeper/server/admin/Commands.java, line 88
> > 
> >
> > how about we use a CommandResult object here instead of a Map<>? Just 
> > because we have a nice compiler that can help with type safety :-)

I'll see what I can do. A CommandResult object needs to include the other 
Map objects that we get from the toMap() methods on the new 
objects like WatchesReport. I'll try to make it somewhat elegant.


> On July 11, 2014, 2:32 p.m., Raul Gutierrez Segales wrote:
> > src/java/main/org/apache/zookeeper/server/admin/Commands.java, line 148
> > 
> >
> > ditto, return a CommandResult object perhaps?

Yes, tied in with above.


> On July 11, 2014, 2:32 p.m., Raul Gutierrez Segales wrote:
> > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, line 1325
> > 
> >
> > nit: Patrick mentioned that it would be nice to have this for 3.5.0 
> > actually, so we might need to update this before merging (probably the 
> > committer can fix it during the merge).

I'll go ahead and update this.


> On July 11, 2014, 2:32 p.m., Raul Gutierrez Segales wrote:
> > src/java/main/org/apache/zookeeper/server/admin/Commands.java, line 69
> > 
> >
> > nit, but cheaper:
> > 
> > Command prev = commands.put(name, command);
> > if (prev != null) {
> >   LOG.warn("Re-registering command... ");
> > }

Nice.


> On July 11, 2014, 2:32 p.m., Raul Gutierrez Segales wrote:
> > src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java, line 
> > 417
> > 
> >
> > why is this different than NIOServerCnxnFactory impl if both use the 
> > same cnxns protected method (which is a ConcurrentHashSet)?
> > 
> > On a broader note, it looks like the NettyServerCnxnFactory was never 
> > updated to reflect that ServerCnxnFactory now has cnxns as a 
> > ConcurrentHashSet.

I think you're right. I'll update the Netty class to match in its use of the 
cnxns field with the NIO class.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23259/#review47662
---


On July 11, 2014, 11:36 a.m., Bill Havanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23259/
> ---
> 
> (Updated July 11, 2014, 11:36 a.m.)
> 
> 
> Review request for zookeeper.
> 
> 
> Bugs: ZOOKEEPER-1346
> https://issues.apache.org/jira/browse/ZOOKEEPER-1346
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> ---
> 
> Addition of new AdminServer, with implementation using Jetty, for RESTful 
> handling of commands.
> 
> Work done by Skye Wanderman-Milne; this patch is a rebase on trunk since the 
> last patch was provided early in 2013.
> 
> Suggested ordering for review:
> 
> 1. ServerCnxn, ServerCnxnFactory and implementations.
> 2. DataTree, WatchManager, ZKDatabase.
> 3. ExpiryQueue, SessionTracker and Impl, LeaderSessionTracker, 
> LearnerSessionTracker.
> 4. ZooKeeperServer.
> 5. org.apache.zookeeper.server.admin package
> 6. Everything else (integration with admin server).
> 
> 
> Diffs
> -
> 
>   ivy.xml ad14b80 
>   src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml bb16fa5 
>   src/java/main/org/apache/zookeeper/server/DataTree.java f2a4f86 
>   src/java/main/org/apache/zookeeper/server/ExpiryQueue.java 130c58e 
>   src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 6e057a5 
>   src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 
> 6b8d2a6 
>   src/java/main/org/apache/zookeeper/server/ServerCnxn.java 35ea301 
>   src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java b0f8130 
>   src/java/main/org/apache/zookeeper/server/ServerStats.java aa0d93f 
>   src/java/main/org/apache/zookeeper/server/SessionTracker.java 4875ead 
>   src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java c971b89 
>   src/java/main/org/apache/zookeeper/server/WatchManager.java 39bf82e 
>   src/java/main/org/apache/zookeeper/server/WatchesPathReport.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/WatchesReport.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/WatchesSummary.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/ZKDatabase.java 91d6bce 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java bee35c0 
>   src/java

[jira] [Commented] (ZOOKEEPER-1346) Handle 4lws and monitoring on separate port

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059162#comment-14059162
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1346:
---

Added some more comments on the reviewboard, mainly questions about diverging 
impls in the Netty vs NIO ServerCnxnFactory and smaller nits. Oh, and one more 
case in which I think a well defined defined class is better than Map<> for 
returning values. 

After that I am happy to +1 this. Thanks [~bhavanki]!

> Handle 4lws and monitoring on separate port
> ---
>
> Key: ZOOKEEPER-1346
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1346
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: Camille Fournier
>Assignee: Bill Havanki
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1346.2.patch, ZOOKEEPER-1346.3.patch, 
> ZOOKEEPER-1346.4.patch, ZOOKEEPER-1346.6.patch, ZOOKEEPER-1346.7.patch, 
> ZOOKEEPER-1346.8.patch, ZOOKEEPER-1346.patch, ZOOKEEPER-1346_jetty.patch
>
>
> Move the 4lws to their own port, off of the client port, and support them 
> properly via long-lived sessions instead of polling. Deprecate the 4lw 
> support on the client port. Will enable us to enhance the functionality of 
> the commands via extended command syntax, address security concerns and fix 
> bugs involving the socket close being received before all of the data on the 
> client end.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: Review Request 23259: ZOOKEEPER-1346 - Jetty server for RESTful command interface

[Raul Gutierrez Segales]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23259/#review47662
---



src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml


nit: Patrick mentioned that it would be nice to have this for 3.5.0 
actually, so we might need to update this before merging (probably the 
committer can fix it during the merge). 



src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java


why is this different than NIOServerCnxnFactory impl if both use the same 
cnxns protected method (which is a ConcurrentHashSet)?

On a broader note, it looks like the NettyServerCnxnFactory was never 
updated to reflect that ServerCnxnFactory now has cnxns as a ConcurrentHashSet. 



src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java


ditto wrt to divergence w/ NIOServerCnxnFactory's impl. 



src/java/main/org/apache/zookeeper/server/WatchesReport.java


nit: newline



src/java/main/org/apache/zookeeper/server/ZooKeeperServerConf.java


nit: newline. 



src/java/main/org/apache/zookeeper/server/ZooKeeperServerConf.java


ditto



src/java/main/org/apache/zookeeper/server/ZooKeeperServerConf.java


ditto



src/java/main/org/apache/zookeeper/server/ZooKeeperServerConf.java


ditto



src/java/main/org/apache/zookeeper/server/ZooKeeperServerConf.java


ditto



src/java/main/org/apache/zookeeper/server/ZooKeeperServerConf.java


ditto



src/java/main/org/apache/zookeeper/server/ZooKeeperServerConf.java


ditto



src/java/main/org/apache/zookeeper/server/admin/CommandBase.java


either address or remove TODO 



src/java/main/org/apache/zookeeper/server/admin/Commands.java


nit, but cheaper:

Command prev = commands.put(name, command);
if (prev != null) {
  LOG.warn("Re-registering command... ");
}



src/java/main/org/apache/zookeeper/server/admin/Commands.java


how about we use a CommandResult object here instead of a Map<>? Just 
because we have a nice compiler that can help with type safety :-)



src/java/main/org/apache/zookeeper/server/admin/Commands.java


i'd say address or drop TODO



src/java/main/org/apache/zookeeper/server/admin/Commands.java


ditto, return a CommandResult object perhaps?



src/java/main/org/apache/zookeeper/server/admin/Commands.java


nit: trailing white space


- Raul Gutierrez Segales


On July 11, 2014, 3:36 p.m., Bill Havanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23259/
> ---
> 
> (Updated July 11, 2014, 3:36 p.m.)
> 
> 
> Review request for zookeeper.
> 
> 
> Bugs: ZOOKEEPER-1346
> https://issues.apache.org/jira/browse/ZOOKEEPER-1346
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> ---
> 
> Addition of new AdminServer, with implementation using Jetty, for RESTful 
> handling of commands.
> 
> Work done by Skye Wanderman-Milne; this patch is a rebase on trunk since the 
> last patch was provided early in 2013.
> 
> Suggested ordering for review:
> 
> 1. ServerCnxn, ServerCnxnFactory and implementations.
> 2. DataTree, WatchManager, ZKDatabase.
> 3. ExpiryQueue, SessionTracker and Impl, LeaderSessionTracker, 
> LearnerSessionTracker.
> 4. ZooKeeperServer.
> 5. org.apache.zookeeper.server.admin package
> 6. Everything else (integration with admin server).
> 
> 
> Diffs
> -
> 
>   ivy.xml ad14b80 
>   src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml bb16fa5 
>   src/java/main/org/apache/zookeeper/server/DataTree.java f2a4f86 
>   src/java/main/org/apache/zookeeper/server/ExpiryQueue.java 130c58e 
>   src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 6e057a5 
>   src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 
> 6b8d2a6 
>   src/java/main/org/apache/zookeeper/server/ServerCnxn.java 35ea301 
>   src/java/main/org/apache/zookeeper/s

Re: svn upgrade issue

[Patrick Hunt]

Ok, great. Thanks Giri!

Patrick

On Fri, Jul 11, 2014 at 10:53 AM, Giridharan Kesavan
 wrote:
> Patrick,
>
> Jenkins slaves moved from ubuntu-10.04 to 14.04, with that come the svn
> client upgrade.
>
> Fixed the svn upgrade.
>
> -giri
>
>
> On Fri, Jul 11, 2014 at 8:52 AM, Patrick Hunt  wrote:
>>
>> Typically you run "svn upgrade" in the svn repo. Either that or remove
>> the repo and check it out again.
>>
>> Giri can you do that?
>>
>>
>> Was svn upgraded on that machine or something? Why is the svn version
>> changing?
>>
>> Patrick
>>
>> On Fri, Jul 11, 2014 at 8:11 AM, FPJ 
>> wrote:
>> > The precommit build is getting this error:
>> >
>> >
>> >
>> >  [exec] svn: E155036: Please see the 'svn upgrade' command
>> >
>> >  [exec] svn: E155036: The working copy at
>> > '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
>> >
>> >  [exec] is too old (format 10) to work with client version '1.8.8
>> > (r1568071)' (expects format 31). You need to upgrade the working copy
>> > first.
>> >
>> >
>> >
>> > We need to get it upgraded.  What's the way to do it?
>> >
>> >
>> >
>> > -Flavio
>> >
>
>
>
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader of
> this message is not the intended recipient, you are hereby notified that any
> printing, copying, dissemination, distribution, disclosure or forwarding of
> this communication is strictly prohibited. If you have received this
> communication in error, please contact the sender immediately and delete it
> from your system. Thank You.

Failed: ZOOKEEPER-1963 PreCommit Build #2187

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1963
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2187/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 2043 lines...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] -1 javac.  The patch appears to cause tar ant target to fail.
 [exec] 
 [exec] -1 findbugs.  The patch appears to cause Findbugs (version 
2.0.3) to fail.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2187//testReport/
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2187//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 63139952fa4e8813e105d4a4820ef00be3ea194f logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1696:
 exec returned: 4

Total time: 48 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2179
Archived 4 artifacts
Archive block size is 32768
Received 0 blocks and 70113 bytes
Compression is 0.0%
Took 3.2 sec
Recording test results
Description set: ZOOKEEPER-1963
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1963) Make JDK 7 the minimum requirement for Zookeeper

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059113#comment-14059113
 ] 

Hadoop QA commented on ZOOKEEPER-1963:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12655259/ZOOKEEPER-1963.patch
  against trunk revision 1609730.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

-1 javac.  The patch appears to cause tar ant target to fail.

-1 findbugs.  The patch appears to cause Findbugs (version 2.0.3) to fail.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2187//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2187//console

This message is automatically generated.

> Make JDK 7 the minimum requirement for Zookeeper
> 
>
> Key: ZOOKEEPER-1963
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1963
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Edward Carter
> Fix For: 3.6.0, 4.0.0
>
> Attachments: ZOOKEEPER-1963.patch
>
>
> JDK 6 stopped receiving public updates in early 2013:
> http://www.oracle.com/technetwork/java/eol-135779.html
> I propose making JDK 7 the minimum for Zookeeper going forward.  One patch 
> that I've personally submitted already would have been a good fit for Java 
> 7's try-with-resources statement, and another pending patch fails to build on 
> versions of Java prior to 7 because a unit test in it uses 
> InetAddress.getLoopbackAddress(), which would be awkward to replace.  I'm 
> sure there are many other examples.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (ZOOKEEPER-1963) Make JDK 7 the minimum requirement for Zookeeper

[Edward Carter (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Carter updated ZOOKEEPER-1963:
-

Attachment: ZOOKEEPER-1963.patch

> Make JDK 7 the minimum requirement for Zookeeper
> 
>
> Key: ZOOKEEPER-1963
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1963
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Edward Carter
> Fix For: 3.6.0, 4.0.0
>
> Attachments: ZOOKEEPER-1963.patch
>
>
> JDK 6 stopped receiving public updates in early 2013:
> http://www.oracle.com/technetwork/java/eol-135779.html
> I propose making JDK 7 the minimum for Zookeeper going forward.  One patch 
> that I've personally submitted already would have been a good fit for Java 
> 7's try-with-resources statement, and another pending patch fails to build on 
> versions of Java prior to 7 because a unit test in it uses 
> InetAddress.getLoopbackAddress(), which would be awkward to replace.  I'm 
> sure there are many other examples.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Failed: ZOOKEEPER-1863 PreCommit Build #2186

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1863
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2186/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1675 lines...]
 [exec] Skipping patch.
 [exec] 3 out of 3 hunks ignored
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12655221/ZOOKEEPER-1863.patch
 [exec]   against trunk revision 1609730.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2186//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 920d95d2cb9789d03fcb82881a60a444283edf5d logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1696:
 exec returned: 1

Total time: 1 minute 40 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2179
Archived 1 artifacts
Archive block size is 32768
Received 0 blocks and 71107 bytes
Compression is 0.0%
Took 2.8 sec
Recording test results
Description set: ZOOKEEPER-1863
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059100#comment-14059100
 ] 

Hadoop QA commented on ZOOKEEPER-1863:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12655221/ZOOKEEPER-1863.patch
  against trunk revision 1609730.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2186//console

This message is automatically generated.

> Race condition in commit processor leading to out of order request 
> completion, xid mismatch on client.
> --
>
> Key: ZOOKEEPER-1863
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1863
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Dutch T. Meyer
>Assignee: Dutch T. Meyer
>Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, 
> ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, stack.17512
>
>
> In CommitProcessor.java processor, if we are at the primary request handler 
> on line 167:
> {noformat}
> while (!stopped && !isWaitingForCommit() &&
>!isProcessingCommit() &&
>(request = queuedRequests.poll()) != null) {
> if (needCommit(request)) {
> nextPending.set(request);
> } else {
> sendToNextProcessor(request);
> }
> }
> {noformat}
> A request can be handled in this block and be quickly processed and completed 
> on another thread. If queuedRequests is empty, we then exit the block. Next, 
> before this thread makes any more progress, we can get 2 more requests, one 
> get_children(say), and a sync placed on queuedRequests for the processor. 
> Then, if we are very unlucky, the sync request can complete and this object's 
> commit() routine is called (from FollowerZookeeperServer), which places the 
> sync request on the previously empty committedRequests queue. At that point, 
> this thread continues.
> We reach line 182, which is a check on sync requests.
> {noformat}
> if (!stopped && !isProcessingRequest() &&
> (request = committedRequests.poll()) != null) {
> {noformat}
> Here we are not processing any requests, because the original request has 
> completed. We haven't dequeued either the read or the sync request in this 
> processor. Next, the poll above will pull the sync request off the queue, and 
> in the following block, the sync will get forwarded to the next processor.
> This is a problem because the read request hasn't been forwarded yet, so 
> requests are now out of order.
> I've been able to reproduce this bug reliably by injecting a 
> Thread.sleep(5000) between the two blocks above to make the race condition 
> far more likely, then in a client program.
> {noformat}
> zoo_aget_children(zh, "/", 0, getchildren_cb, NULL);
> //Wait long enough for queuedRequests to drain
> sleep(1);
> zoo_aget_children(zh, "/", 0, getchildren_cb, &th_ctx[0]);
> zoo_async(zh, "/", sync_cb, &th_ctx[0]);
> {noformat}
> When this bug is triggered, 3 things can happen:
> 1) Clients will see requests complete out of order and fail on xid mismatches.
> 2) Kazoo in particular doesn't handle this runtime exception well, and can 
> orphan outstanding requests.
> 3) I've seen zookeeper servers deadlock, likely because the commit cannot be 
> completed, which can wedge the commit processor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: svn upgrade issue

[Giridharan Kesavan]

Patrick,

Jenkins slaves moved from ubuntu-10.04 to 14.04, with that come the svn
client upgrade.

Fixed the svn upgrade.

-giri


On Fri, Jul 11, 2014 at 8:52 AM, Patrick Hunt  wrote:

> Typically you run "svn upgrade" in the svn repo. Either that or remove
> the repo and check it out again.
>
> Giri can you do that?
>
>
> Was svn upgraded on that machine or something? Why is the svn version
> changing?
>
> Patrick
>
> On Fri, Jul 11, 2014 at 8:11 AM, FPJ 
> wrote:
> > The precommit build is getting this error:
> >
> >
> >
> >  [exec] svn: E155036: Please see the 'svn upgrade' command
> >
> >  [exec] svn: E155036: The working copy at
> > '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
> >
> >  [exec] is too old (format 10) to work with client version '1.8.8
> > (r1568071)' (expects format 31). You need to upgrade the working copy
> first.
> >
> >
> >
> > We need to get it upgraded.  What's the way to do it?
> >
> >
> >
> > -Flavio
> >
>

-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058993#comment-14058993
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1863:
---

Oh, the comment here has some issues too:

{noformat}
+/*
+ * ZOOKEEPER-1863: Abort the loop if there is a new request
+ * waiting in queuedRequests or it is waiting for a
+ * commit. 
+ */
+if ( !isWaitingForCommit() && !queuedRequests.isEmpty()) {
+return;
+}
{noformat}

Abort the loop is not correct.. you'll keep looping from the calling method... 
abort processing the commit perhaps? Also, it says "abort ... if it is waiting 
for a commit", whereas it's actually the contrary... right 
(!isWaitingForCommit)?

> Race condition in commit processor leading to out of order request 
> completion, xid mismatch on client.
> --
>
> Key: ZOOKEEPER-1863
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1863
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Dutch T. Meyer
>Assignee: Dutch T. Meyer
>Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, 
> ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, stack.17512
>
>
> In CommitProcessor.java processor, if we are at the primary request handler 
> on line 167:
> {noformat}
> while (!stopped && !isWaitingForCommit() &&
>!isProcessingCommit() &&
>(request = queuedRequests.poll()) != null) {
> if (needCommit(request)) {
> nextPending.set(request);
> } else {
> sendToNextProcessor(request);
> }
> }
> {noformat}
> A request can be handled in this block and be quickly processed and completed 
> on another thread. If queuedRequests is empty, we then exit the block. Next, 
> before this thread makes any more progress, we can get 2 more requests, one 
> get_children(say), and a sync placed on queuedRequests for the processor. 
> Then, if we are very unlucky, the sync request can complete and this object's 
> commit() routine is called (from FollowerZookeeperServer), which places the 
> sync request on the previously empty committedRequests queue. At that point, 
> this thread continues.
> We reach line 182, which is a check on sync requests.
> {noformat}
> if (!stopped && !isProcessingRequest() &&
> (request = committedRequests.poll()) != null) {
> {noformat}
> Here we are not processing any requests, because the original request has 
> completed. We haven't dequeued either the read or the sync request in this 
> processor. Next, the poll above will pull the sync request off the queue, and 
> in the following block, the sync will get forwarded to the next processor.
> This is a problem because the read request hasn't been forwarded yet, so 
> requests are now out of order.
> I've been able to reproduce this bug reliably by injecting a 
> Thread.sleep(5000) between the two blocks above to make the race condition 
> far more likely, then in a client program.
> {noformat}
> zoo_aget_children(zh, "/", 0, getchildren_cb, NULL);
> //Wait long enough for queuedRequests to drain
> sleep(1);
> zoo_aget_children(zh, "/", 0, getchildren_cb, &th_ctx[0]);
> zoo_async(zh, "/", sync_cb, &th_ctx[0]);
> {noformat}
> When this bug is triggered, 3 things can happen:
> 1) Clients will see requests complete out of order and fail on xid mismatches.
> 2) Kazoo in particular doesn't handle this runtime exception well, and can 
> orphan outstanding requests.
> 3) I've seen zookeeper servers deadlock, likely because the commit cannot be 
> completed, which can wedge the commit processor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058975#comment-14058975
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1863:
---

Thanks for the updated patch [~fpj]. Small readability nit, I think it reads 
better (and with less indentation) if you exit as early as you see an unmet 
condition:

{noformat}
if (stopped || isProcessingRequest() || committedRequests.peek() == null) {
return;
}

/*
 * ZOOKEEPER-1863: Abort the loop if there is a new request
 * waiting in queuedRequests or it is waiting for a
 * commit. 
 */
if ( !isWaitingForCommit() && !queuedRequests.isEmpty()) {
return;
}

/* do it */

{noformat}


> Race condition in commit processor leading to out of order request 
> completion, xid mismatch on client.
> --
>
> Key: ZOOKEEPER-1863
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1863
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Dutch T. Meyer
>Assignee: Dutch T. Meyer
>Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, 
> ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, stack.17512
>
>
> In CommitProcessor.java processor, if we are at the primary request handler 
> on line 167:
> {noformat}
> while (!stopped && !isWaitingForCommit() &&
>!isProcessingCommit() &&
>(request = queuedRequests.poll()) != null) {
> if (needCommit(request)) {
> nextPending.set(request);
> } else {
> sendToNextProcessor(request);
> }
> }
> {noformat}
> A request can be handled in this block and be quickly processed and completed 
> on another thread. If queuedRequests is empty, we then exit the block. Next, 
> before this thread makes any more progress, we can get 2 more requests, one 
> get_children(say), and a sync placed on queuedRequests for the processor. 
> Then, if we are very unlucky, the sync request can complete and this object's 
> commit() routine is called (from FollowerZookeeperServer), which places the 
> sync request on the previously empty committedRequests queue. At that point, 
> this thread continues.
> We reach line 182, which is a check on sync requests.
> {noformat}
> if (!stopped && !isProcessingRequest() &&
> (request = committedRequests.poll()) != null) {
> {noformat}
> Here we are not processing any requests, because the original request has 
> completed. We haven't dequeued either the read or the sync request in this 
> processor. Next, the poll above will pull the sync request off the queue, and 
> in the following block, the sync will get forwarded to the next processor.
> This is a problem because the read request hasn't been forwarded yet, so 
> requests are now out of order.
> I've been able to reproduce this bug reliably by injecting a 
> Thread.sleep(5000) between the two blocks above to make the race condition 
> far more likely, then in a client program.
> {noformat}
> zoo_aget_children(zh, "/", 0, getchildren_cb, NULL);
> //Wait long enough for queuedRequests to drain
> sleep(1);
> zoo_aget_children(zh, "/", 0, getchildren_cb, &th_ctx[0]);
> zoo_async(zh, "/", sync_cb, &th_ctx[0]);
> {noformat}
> When this bug is triggered, 3 things can happen:
> 1) Clients will see requests complete out of order and fail on xid mismatches.
> 2) Kazoo in particular doesn't handle this runtime exception well, and can 
> orphan outstanding requests.
> 3) I've seen zookeeper servers deadlock, likely because the commit cannot be 
> completed, which can wedge the commit processor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: ZooKeeper 3.5.0-alpha planning

[Raúl Gutiérrez Segalés]

On Jul 11, 2014 6:37 AM, "Flavio Junqueira" 
wrote:
>
> Just so that we don´t delay too much, what if we release an alpha version
without 1863 and 1807, and do another one in 2-3 weeks time?
>

+1

-rgs

> -Flavio
>
>
> On Thursday, July 3, 2014 6:12 AM, Raúl Gutiérrez Segalés <
r...@itevenworks.net> wrote:
>
>
> >
> >
> >On 2 July 2014 21:19, Patrick Hunt  wrote:
> >
> >> Update: we're down to 7 blockers on 5.1.0 (from 8 in the last check).
> >> 1810 is waiting on feedback from Michi, and Camille is threatening to
> >> commit 1863. I see some great progress in general on the patch
> >> availables queue, which is great to see.
> >>
> >> So here's something else we might consider - should we drop jdk6
> >> support from 3.5. It's long since EOL by Oracle but I suspect some
> >> folks are still using ZK with 6. We gotta move forward though, can't
> >> support it forever. Thoughts? Note that we are currently
> >> building/testing trunk against jdk6, 7 and 8.
> >> https://builds.apache.org/view/S-Z/view/ZooKeeper/
> >>
> >
> >Extra eyes/review for
https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> >would be appreciated (otherwise anyone using Observers with the upcoming
> >alpha release will see there network usage go wild...).
> >
> >
> >-rgs
> >
> >
> >
> >
> >
> >> Patrick
> >>
> >> On Tue, Jul 1, 2014 at 2:26 AM, Flavio Junqueira
> >>  wrote:
> >> > According to me, ZK-1810 should be in already, but I need a +1
there. I
> >> think Michi hasn't checked in because LETest failed in the last QA run
> >> there. However, that patch doesn't affect LETest, and in fact it fails
in
> >> trunk intermittently, so the test failure doesn't seem to be related
to the
> >> patch.
> >> >
> >> > I haven't checked ZK-1863, so I can't say anything concrete about it.
> >> >
> >> > -Flavio
> >> >
> >> >
> >> >
> >> > On Tuesday, July 1, 2014 5:53 AM, Patrick Hunt 
wrote:
> >> >
> >> >
> >> >>
> >> >>
> >> >>Hi Flavio, do you think those jiras can get reviewed/finalized before
> >> >>the end of the week? I'd like to try cutting an RC soonish...
> >> >>
> >> >>Patrick
> >> >>
> >> >>
> >> >>On Sun, Jun 29, 2014 at 5:02 AM, Flavio Junqueira
> >> >> wrote:
> >> >>> +1 for the plan of releasing alpha versions.
> >> >>>
> >> >>> I'd like to have ZK-1818 (ZK-1810) and ZK-1863 in. They are both
patch
> >> available. ZK-1870 is in trunk, but it is still open because we need a
3.4
> >> patch.
> >> >>>
> >> >>> -Flavio
> >> >>>
> >> >>>
> >> >>> On 26 Jun 2014, at 01:07, Patrick Hunt  wrote:
> >> >>>
> >>  Hey folks, we've been talking about it for a while, a few people
have
> >>  mentioned on the list as well as contacted me personally that they
> >>  would like to see some progress on the first 3.5 release. Every
> >>  release is a compromise, if we wait for perfection we'll never get
> >>  anything out the door. 3.5 has tons of great new features, lots of
> >>  hard work, let's get it out in a release so that folks can use it,
> >>  test it, and give feedback.
> >> 
> >>  Jenkins jobs have been pretty stable except for the known flakey
test
> >>  ZOOKEEPER-1870 which Flavio committed today to trunk. Note that
> >>  jenkins has also been verifying the code on jdk7 and jdk8.
> >> 
> >>  Here's my thinking again on how we should plan our releases:
> >> 
> >>  I don't think we'll be able to do a 3.5.x-stable for some time.
What I
> >>  think we should do instead is similar to what we did for 3.4.
(this is
> >>  also similar to what Hadoop did during their Hadoop 2 release
cycle)
> >>  Start with a series of alpha releases, something people can run
and
> >>  test with, once we address all the blockers and feel comfortable
with
> >>  the apis & remaining jiras we then switch to beta. Once we get
some
> >>  good feedback we remove the alpha/beta moniker and look at making
it
> >>  "stable'. At some later point it will become the "current/stable"
> >>  release, taking over from 3.4.x.
> >> 
> >>  e.g.
> >>  3.5.0-alpha (8 blockers)
> >>  3.5.1-alpha (3 blockers)
> >>  3.5.2-alpha (0 blockers)
> >>  3.5.3-beta (apis locked)
> >>  3.5.4-beta
> >>  3.5.5-beta
> >>  3.5.6 (no longer considered alpha/beta but also not "stable" vs
3.4.x,
> >>  maybe use it for production but we still expect things to shake
out)
> >>  3.5.7
> >>  
> >>  3.5.x - ready to replace 3.4 releases for production use, stable,
> >> etc...
> >> 
> >>  There are 8 blockers currently, are any of these something that
should
> >>  hold up 3.5.0-alpha?
> >> 
> >>  I'll hold open the discussion for a couple days. If folks find
this a
> >>  reasonable plan I'll start the ball rolling to cut an RC.
> >> 
> >>  Patrick
> >> >>>
> >> >>
> >> >>
> >> >>
> >>
> >
> >
> >

Re: ZooKeeper 3.5.0-alpha planning

[Patrick Hunt]

I think that would be fine. It would also allow other people to more
easily try out the release and provide additional feedback.

Patrick

On Fri, Jul 11, 2014 at 6:37 AM, Flavio Junqueira
 wrote:
> Just so that we don´t delay too much, what if we release an alpha version 
> without 1863 and 1807, and do another one in 2-3 weeks time?
>
> -Flavio
>
>
> On Thursday, July 3, 2014 6:12 AM, Raúl Gutiérrez Segalés 
>  wrote:
>
>
>>
>>
>>On 2 July 2014 21:19, Patrick Hunt  wrote:
>>
>>> Update: we're down to 7 blockers on 5.1.0 (from 8 in the last check).
>>> 1810 is waiting on feedback from Michi, and Camille is threatening to
>>> commit 1863. I see some great progress in general on the patch
>>> availables queue, which is great to see.
>>>
>>> So here's something else we might consider - should we drop jdk6
>>> support from 3.5. It's long since EOL by Oracle but I suspect some
>>> folks are still using ZK with 6. We gotta move forward though, can't
>>> support it forever. Thoughts? Note that we are currently
>>> building/testing trunk against jdk6, 7 and 8.
>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/
>>>
>>
>>Extra eyes/review for https://issues.apache.org/jira/browse/ZOOKEEPER-1807
>>would be appreciated (otherwise anyone using Observers with the upcoming
>>alpha release will see there network usage go wild...).
>>
>>
>>-rgs
>>
>>
>>
>>
>>
>>> Patrick
>>>
>>> On Tue, Jul 1, 2014 at 2:26 AM, Flavio Junqueira
>>>  wrote:
>>> > According to me, ZK-1810 should be in already, but I need a +1 there. I
>>> think Michi hasn't checked in because LETest failed in the last QA run
>>> there. However, that patch doesn't affect LETest, and in fact it fails in
>>> trunk intermittently, so the test failure doesn't seem to be related to the
>>> patch.
>>> >
>>> > I haven't checked ZK-1863, so I can't say anything concrete about it.
>>> >
>>> > -Flavio
>>> >
>>> >
>>> >
>>> > On Tuesday, July 1, 2014 5:53 AM, Patrick Hunt  wrote:
>>> >
>>> >
>>> >>
>>> >>
>>> >>Hi Flavio, do you think those jiras can get reviewed/finalized before
>>> >>the end of the week? I'd like to try cutting an RC soonish...
>>> >>
>>> >>Patrick
>>> >>
>>> >>
>>> >>On Sun, Jun 29, 2014 at 5:02 AM, Flavio Junqueira
>>> >> wrote:
>>> >>> +1 for the plan of releasing alpha versions.
>>> >>>
>>> >>> I'd like to have ZK-1818 (ZK-1810) and ZK-1863 in. They are both patch
>>> available. ZK-1870 is in trunk, but it is still open because we need a 3.4
>>> patch.
>>> >>>
>>> >>> -Flavio
>>> >>>
>>> >>>
>>> >>> On 26 Jun 2014, at 01:07, Patrick Hunt  wrote:
>>> >>>
>>>  Hey folks, we've been talking about it for a while, a few people have
>>>  mentioned on the list as well as contacted me personally that they
>>>  would like to see some progress on the first 3.5 release. Every
>>>  release is a compromise, if we wait for perfection we'll never get
>>>  anything out the door. 3.5 has tons of great new features, lots of
>>>  hard work, let's get it out in a release so that folks can use it,
>>>  test it, and give feedback.
>>> 
>>>  Jenkins jobs have been pretty stable except for the known flakey test
>>>  ZOOKEEPER-1870 which Flavio committed today to trunk. Note that
>>>  jenkins has also been verifying the code on jdk7 and jdk8.
>>> 
>>>  Here's my thinking again on how we should plan our releases:
>>> 
>>>  I don't think we'll be able to do a 3.5.x-stable for some time. What I
>>>  think we should do instead is similar to what we did for 3.4. (this is
>>>  also similar to what Hadoop did during their Hadoop 2 release cycle)
>>>  Start with a series of alpha releases, something people can run and
>>>  test with, once we address all the blockers and feel comfortable with
>>>  the apis & remaining jiras we then switch to beta. Once we get some
>>>  good feedback we remove the alpha/beta moniker and look at making it
>>>  "stable'. At some later point it will become the "current/stable"
>>>  release, taking over from 3.4.x.
>>> 
>>>  e.g.
>>>  3.5.0-alpha (8 blockers)
>>>  3.5.1-alpha (3 blockers)
>>>  3.5.2-alpha (0 blockers)
>>>  3.5.3-beta (apis locked)
>>>  3.5.4-beta
>>>  3.5.5-beta
>>>  3.5.6 (no longer considered alpha/beta but also not "stable" vs 3.4.x,
>>>  maybe use it for production but we still expect things to shake out)
>>>  3.5.7
>>>  
>>>  3.5.x - ready to replace 3.4 releases for production use, stable,
>>> etc...
>>> 
>>>  There are 8 blockers currently, are any of these something that should
>>>  hold up 3.5.0-alpha?
>>> 
>>>  I'll hold open the discussion for a couple days. If folks find this a
>>>  reasonable plan I'll start the ball rolling to cut an RC.
>>> 
>>>  Patrick
>>> >>>
>>> >>
>>> >>
>>> >>
>>>
>>
>>
>>

Re: svn upgrade issue

[Patrick Hunt]

Typically you run "svn upgrade" in the svn repo. Either that or remove
the repo and check it out again.

Giri can you do that?


Was svn upgraded on that machine or something? Why is the svn version changing?

Patrick

On Fri, Jul 11, 2014 at 8:11 AM, FPJ  wrote:
> The precommit build is getting this error:
>
>
>
>  [exec] svn: E155036: Please see the 'svn upgrade' command
>
>  [exec] svn: E155036: The working copy at
> '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
>
>  [exec] is too old (format 10) to work with client version '1.8.8
> (r1568071)' (expects format 31). You need to upgrade the working copy first.
>
>
>
> We need to get it upgraded.  What's the way to do it?
>
>
>
> -Flavio
>

Re: Review Request 23259: ZOOKEEPER-1346 - Jetty server for RESTful command interface

[Bill Havanki]

> On July 10, 2014, 3:22 p.m., Raul Gutierrez Segales wrote:
> > src/java/test/org/apache/zookeeper/server/admin/CommandsTest.java, line 139
> > 
> >
> > nit: maybe put the string & classes in a Map and then 
> > just call:
> > 
> > ```
> > testCommand("monitor", map.keys(), map.values())
> > ```
> > 
> > for readability?
> 
> Bill Havanki wrote:
> I'll make that change, good idea.

A map ended up being tricky, since map.keySet() and map.values() are a Set and 
Collection (resp.) and I was worried about whether they would iterate in 
parallel. Instead I just defined a Field object for each key/type pairing and 
worked with arrays of them. It ended up very readable.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23259/#review47594
---


On July 11, 2014, 11:36 a.m., Bill Havanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23259/
> ---
> 
> (Updated July 11, 2014, 11:36 a.m.)
> 
> 
> Review request for zookeeper.
> 
> 
> Bugs: ZOOKEEPER-1346
> https://issues.apache.org/jira/browse/ZOOKEEPER-1346
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> ---
> 
> Addition of new AdminServer, with implementation using Jetty, for RESTful 
> handling of commands.
> 
> Work done by Skye Wanderman-Milne; this patch is a rebase on trunk since the 
> last patch was provided early in 2013.
> 
> Suggested ordering for review:
> 
> 1. ServerCnxn, ServerCnxnFactory and implementations.
> 2. DataTree, WatchManager, ZKDatabase.
> 3. ExpiryQueue, SessionTracker and Impl, LeaderSessionTracker, 
> LearnerSessionTracker.
> 4. ZooKeeperServer.
> 5. org.apache.zookeeper.server.admin package
> 6. Everything else (integration with admin server).
> 
> 
> Diffs
> -
> 
>   ivy.xml ad14b80 
>   src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml bb16fa5 
>   src/java/main/org/apache/zookeeper/server/DataTree.java f2a4f86 
>   src/java/main/org/apache/zookeeper/server/ExpiryQueue.java 130c58e 
>   src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 6e057a5 
>   src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 
> 6b8d2a6 
>   src/java/main/org/apache/zookeeper/server/ServerCnxn.java 35ea301 
>   src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java b0f8130 
>   src/java/main/org/apache/zookeeper/server/ServerStats.java aa0d93f 
>   src/java/main/org/apache/zookeeper/server/SessionTracker.java 4875ead 
>   src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java c971b89 
>   src/java/main/org/apache/zookeeper/server/WatchManager.java 39bf82e 
>   src/java/main/org/apache/zookeeper/server/WatchesPathReport.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/WatchesReport.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/WatchesSummary.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/ZKDatabase.java 91d6bce 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java bee35c0 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperServerConf.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 7bffaf0 
>   src/java/main/org/apache/zookeeper/server/ZooTrace.java 42417f5 
>   src/java/main/org/apache/zookeeper/server/admin/AdminServer.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/admin/AdminServerFactory.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/admin/Command.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/admin/CommandBase.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/admin/CommandOutputter.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/admin/Commands.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/admin/DummyAdminServer.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/admin/JettyAdminServer.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/admin/JsonOutputter.java 
> PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/quorum/Leader.java 3baf41a 
>   src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
> e746892 
>   src/java/main/org/apache/zookeeper/server/quorum/Learner.java 43e1b8b 
>   src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
> cf0ecfb 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 4ec1f9a 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 
> b374c29 
>   
> src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 
> 0369eb9 
>   src/j

Re: Review Request 23259: ZOOKEEPER-1346 - Jetty server for RESTful command interface

[Bill Havanki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23259/
---

(Updated July 11, 2014, 11:36 a.m.)


Review request for zookeeper.


Changes
---

Promoted ZooKeeperServer conf map to object. Changed 
zookeeper.admin.enableAdminServer to .enableServer. Added test and Javadoc 
improvements. Also removed duplicate test in CommandsTest.


Bugs: ZOOKEEPER-1346
https://issues.apache.org/jira/browse/ZOOKEEPER-1346


Repository: zookeeper-git


Description
---

Addition of new AdminServer, with implementation using Jetty, for RESTful 
handling of commands.

Work done by Skye Wanderman-Milne; this patch is a rebase on trunk since the 
last patch was provided early in 2013.

Suggested ordering for review:

1. ServerCnxn, ServerCnxnFactory and implementations.
2. DataTree, WatchManager, ZKDatabase.
3. ExpiryQueue, SessionTracker and Impl, LeaderSessionTracker, 
LearnerSessionTracker.
4. ZooKeeperServer.
5. org.apache.zookeeper.server.admin package
6. Everything else (integration with admin server).


Diffs (updated)
-

  ivy.xml ad14b80 
  src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml bb16fa5 
  src/java/main/org/apache/zookeeper/server/DataTree.java f2a4f86 
  src/java/main/org/apache/zookeeper/server/ExpiryQueue.java 130c58e 
  src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 6e057a5 
  src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 6b8d2a6 
  src/java/main/org/apache/zookeeper/server/ServerCnxn.java 35ea301 
  src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java b0f8130 
  src/java/main/org/apache/zookeeper/server/ServerStats.java aa0d93f 
  src/java/main/org/apache/zookeeper/server/SessionTracker.java 4875ead 
  src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java c971b89 
  src/java/main/org/apache/zookeeper/server/WatchManager.java 39bf82e 
  src/java/main/org/apache/zookeeper/server/WatchesPathReport.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/WatchesReport.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/WatchesSummary.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/ZKDatabase.java 91d6bce 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java bee35c0 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServerConf.java 
PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 7bffaf0 
  src/java/main/org/apache/zookeeper/server/ZooTrace.java 42417f5 
  src/java/main/org/apache/zookeeper/server/admin/AdminServer.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/admin/AdminServerFactory.java 
PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/admin/Command.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/admin/CommandBase.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/admin/CommandOutputter.java 
PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/admin/Commands.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/admin/DummyAdminServer.java 
PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/admin/JettyAdminServer.java 
PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/admin/JsonOutputter.java 
PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java 3baf41a 
  src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
e746892 
  src/java/main/org/apache/zookeeper/server/quorum/Learner.java 43e1b8b 
  src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
cf0ecfb 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 4ec1f9a 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java b374c29 
  src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 
0369eb9 
  src/java/test/org/apache/zookeeper/ZKTestCase.java 6ecfe8f 
  src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
b1b44fb 
  src/java/test/org/apache/zookeeper/server/WatchesPathReportTest.java 
PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/WatchesReportTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/WatchesSummaryTest.java 
PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/ZooKeeperServerConfTest.java 
PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/admin/CommandsTest.java 
PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/admin/JettyAdminServerTest.java 
PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 
b04d2bd 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 
f35e1cd 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 0ea7f19 

Diff: https://reviews.apache.org/r/23259/diff/


Testing
---

Compiles, unit tests pass. Tested commands "by hand" on running instance.


Thanks,

svn upgrade issue

[FPJ]

The precommit build is getting this error:

 

 [exec] svn: E155036: Please see the 'svn upgrade' command

 [exec] svn: E155036: The working copy at
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'

 [exec] is too old (format 10) to work with client version '1.8.8
(r1568071)' (expects format 31). You need to upgrade the working copy first.

 

We need to get it upgraded.  What's the way to do it?

 

-Flavio

Failed: ZOOKEEPER-1863 PreCommit Build #2185

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1863
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2185/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by remote host 127.0.0.1
Building remotely on H5 (Mapreduce Falcon Hadoop Pig Zookeeper Tez Hdfs) in 
workspace /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build
Reverting /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk 
to depth infinity with ignoreExternals: false
Updating http://svn.apache.org/repos/asf/zookeeper/trunk at revision 
'2014-07-11T15:00:44.069 +'
At revision 1609720
no change for http://svn.apache.org/repos/asf/zookeeper/trunk since the 
previous build
No emails were triggered.
[PreCommit-ZOOKEEPER-Build] $ /bin/bash /tmp/hudson70113460173242396.sh
/usr/bin/java
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml

check-for-findbugs:

findbugs.check:

forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-1863.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] svn: E155036: Please see the 'svn upgrade' command
 [exec] svn: E155036: The working copy at 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
 [exec] is too old (format 10) to work with client version '1.8.8 
(r1568071)' (expects format 31). You need to upgrade the working copy first.
 [exec] 
 [exec] svn: E155036: Please see the 'svn upgrade' command
 [exec] svn: E155036: The working copy at 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
 [exec] is too old (format 10) to work with client version '1.8.8 
(r1568071)' (expects format 31). You need to upgrade the working copy first.
 [exec] 
 [exec] svn: E155036: Please see the 'svn upgrade' command
 [exec] svn: E155036: The working copy at 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
 [exec] is too old (format 10) to work with client version '1.8.8 
(r1568071)' (expects format 31). You need to upgrade the working copy first.
 [exec] 
 [exec] svn: E155036: Please see the 'svn upgrade' command
 [exec] svn: E155036: The working copy at 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
 [exec] is too old (format 10) to work with client version '1.8.8 
(r1568071)' (expects format 31). You need to upgrade the working copy first.
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1696:
 exec returned: 100

Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1863
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

[Flavio Junqueira (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira updated ZOOKEEPER-1863:


Attachment: ZOOKEEPER-1863.patch

> Race condition in commit processor leading to out of order request 
> completion, xid mismatch on client.
> --
>
> Key: ZOOKEEPER-1863
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1863
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Dutch T. Meyer
>Assignee: Dutch T. Meyer
>Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, 
> ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, stack.17512
>
>
> In CommitProcessor.java processor, if we are at the primary request handler 
> on line 167:
> {noformat}
> while (!stopped && !isWaitingForCommit() &&
>!isProcessingCommit() &&
>(request = queuedRequests.poll()) != null) {
> if (needCommit(request)) {
> nextPending.set(request);
> } else {
> sendToNextProcessor(request);
> }
> }
> {noformat}
> A request can be handled in this block and be quickly processed and completed 
> on another thread. If queuedRequests is empty, we then exit the block. Next, 
> before this thread makes any more progress, we can get 2 more requests, one 
> get_children(say), and a sync placed on queuedRequests for the processor. 
> Then, if we are very unlucky, the sync request can complete and this object's 
> commit() routine is called (from FollowerZookeeperServer), which places the 
> sync request on the previously empty committedRequests queue. At that point, 
> this thread continues.
> We reach line 182, which is a check on sync requests.
> {noformat}
> if (!stopped && !isProcessingRequest() &&
> (request = committedRequests.poll()) != null) {
> {noformat}
> Here we are not processing any requests, because the original request has 
> completed. We haven't dequeued either the read or the sync request in this 
> processor. Next, the poll above will pull the sync request off the queue, and 
> in the following block, the sync will get forwarded to the next processor.
> This is a problem because the read request hasn't been forwarded yet, so 
> requests are now out of order.
> I've been able to reproduce this bug reliably by injecting a 
> Thread.sleep(5000) between the two blocks above to make the race condition 
> far more likely, then in a client program.
> {noformat}
> zoo_aget_children(zh, "/", 0, getchildren_cb, NULL);
> //Wait long enough for queuedRequests to drain
> sleep(1);
> zoo_aget_children(zh, "/", 0, getchildren_cb, &th_ctx[0]);
> zoo_async(zh, "/", sync_cb, &th_ctx[0]);
> {noformat}
> When this bug is triggered, 3 things can happen:
> 1) Clients will see requests complete out of order and fail on xid mismatches.
> 2) Kazoo in particular doesn't handle this runtime exception well, and can 
> orphan outstanding requests.
> 3) I've seen zookeeper servers deadlock, likely because the commit cannot be 
> completed, which can wedge the commit processor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: ZooKeeper 3.5.0-alpha planning

[Flavio Junqueira]

Just so that we don´t delay too much, what if we release an alpha version 
without 1863 and 1807, and do another one in 2-3 weeks time?

-Flavio


On Thursday, July 3, 2014 6:12 AM, Raúl Gutiérrez Segalés 
 wrote:
 

>
>
>On 2 July 2014 21:19, Patrick Hunt  wrote:
>
>> Update: we're down to 7 blockers on 5.1.0 (from 8 in the last check).
>> 1810 is waiting on feedback from Michi, and Camille is threatening to
>> commit 1863. I see some great progress in general on the patch
>> availables queue, which is great to see.
>>
>> So here's something else we might consider - should we drop jdk6
>> support from 3.5. It's long since EOL by Oracle but I suspect some
>> folks are still using ZK with 6. We gotta move forward though, can't
>> support it forever. Thoughts? Note that we are currently
>> building/testing trunk against jdk6, 7 and 8.
>> https://builds.apache.org/view/S-Z/view/ZooKeeper/
>>
>
>Extra eyes/review for https://issues.apache.org/jira/browse/ZOOKEEPER-1807
>would be appreciated (otherwise anyone using Observers with the upcoming
>alpha release will see there network usage go wild...).
>
>
>-rgs
>
>
>
>
>
>> Patrick
>>
>> On Tue, Jul 1, 2014 at 2:26 AM, Flavio Junqueira
>>  wrote:
>> > According to me, ZK-1810 should be in already, but I need a +1 there. I
>> think Michi hasn't checked in because LETest failed in the last QA run
>> there. However, that patch doesn't affect LETest, and in fact it fails in
>> trunk intermittently, so the test failure doesn't seem to be related to the
>> patch.
>> >
>> > I haven't checked ZK-1863, so I can't say anything concrete about it.
>> >
>> > -Flavio
>> >
>> >
>> >
>> > On Tuesday, July 1, 2014 5:53 AM, Patrick Hunt  wrote:
>> >
>> >
>> >>
>> >>
>> >>Hi Flavio, do you think those jiras can get reviewed/finalized before
>> >>the end of the week? I'd like to try cutting an RC soonish...
>> >>
>> >>Patrick
>> >>
>> >>
>> >>On Sun, Jun 29, 2014 at 5:02 AM, Flavio Junqueira
>> >> wrote:
>> >>> +1 for the plan of releasing alpha versions.
>> >>>
>> >>> I'd like to have ZK-1818 (ZK-1810) and ZK-1863 in. They are both patch
>> available. ZK-1870 is in trunk, but it is still open because we need a 3.4
>> patch.
>> >>>
>> >>> -Flavio
>> >>>
>> >>>
>> >>> On 26 Jun 2014, at 01:07, Patrick Hunt  wrote:
>> >>>
>>  Hey folks, we've been talking about it for a while, a few people have
>>  mentioned on the list as well as contacted me personally that they
>>  would like to see some progress on the first 3.5 release. Every
>>  release is a compromise, if we wait for perfection we'll never get
>>  anything out the door. 3.5 has tons of great new features, lots of
>>  hard work, let's get it out in a release so that folks can use it,
>>  test it, and give feedback.
>> 
>>  Jenkins jobs have been pretty stable except for the known flakey test
>>  ZOOKEEPER-1870 which Flavio committed today to trunk. Note that
>>  jenkins has also been verifying the code on jdk7 and jdk8.
>> 
>>  Here's my thinking again on how we should plan our releases:
>> 
>>  I don't think we'll be able to do a 3.5.x-stable for some time. What I
>>  think we should do instead is similar to what we did for 3.4. (this is
>>  also similar to what Hadoop did during their Hadoop 2 release cycle)
>>  Start with a series of alpha releases, something people can run and
>>  test with, once we address all the blockers and feel comfortable with
>>  the apis & remaining jiras we then switch to beta. Once we get some
>>  good feedback we remove the alpha/beta moniker and look at making it
>>  "stable'. At some later point it will become the "current/stable"
>>  release, taking over from 3.4.x.
>> 
>>  e.g.
>>  3.5.0-alpha (8 blockers)
>>  3.5.1-alpha (3 blockers)
>>  3.5.2-alpha (0 blockers)
>>  3.5.3-beta (apis locked)
>>  3.5.4-beta
>>  3.5.5-beta
>>  3.5.6 (no longer considered alpha/beta but also not "stable" vs 3.4.x,
>>  maybe use it for production but we still expect things to shake out)
>>  3.5.7
>>  
>>  3.5.x - ready to replace 3.4 releases for production use, stable,
>> etc...
>> 
>>  There are 8 blockers currently, are any of these something that should
>>  hold up 3.5.0-alpha?
>> 
>>  I'll hold open the discussion for a couple days. If folks find this a
>>  reasonable plan I'll start the ball rolling to cut an RC.
>> 
>>  Patrick
>> >>>
>> >>
>> >>
>> >>
>>
>
>
>

Failed: ZOOKEEPER-1863 PreCommit Build #2184

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1863
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2184/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by remote host 127.0.0.1
Building remotely on H5 (Mapreduce Falcon Hadoop Pig Zookeeper Tez Hdfs) in 
workspace /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build
Reverting /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk 
to depth infinity with ignoreExternals: false
Updating http://svn.apache.org/repos/asf/zookeeper/trunk at revision 
'2014-07-11T13:11:08.435 +'
At revision 1609710
no change for http://svn.apache.org/repos/asf/zookeeper/trunk since the 
previous build
No emails were triggered.
[PreCommit-ZOOKEEPER-Build] $ /bin/bash /tmp/hudson505173877447348143.sh
/usr/bin/java
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml

check-for-findbugs:

findbugs.check:

forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-1863.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] svn: E155036: Please see the 'svn upgrade' command
 [exec] svn: E155036: The working copy at 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
 [exec] is too old (format 10) to work with client version '1.8.8 
(r1568071)' (expects format 31). You need to upgrade the working copy first.
 [exec] 
 [exec] svn: E155036: Please see the 'svn upgrade' command
 [exec] svn: E155036: The working copy at 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
 [exec] is too old (format 10) to work with client version '1.8.8 
(r1568071)' (expects format 31). You need to upgrade the working copy first.
 [exec] 
 [exec] svn: E155036: Please see the 'svn upgrade' command
 [exec] svn: E155036: The working copy at 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
 [exec] is too old (format 10) to work with client version '1.8.8 
(r1568071)' (expects format 31). You need to upgrade the working copy first.
 [exec] 
 [exec] svn: E155036: Please see the 'svn upgrade' command
 [exec] svn: E155036: The working copy at 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
 [exec] is too old (format 10) to work with client version '1.8.8 
(r1568071)' (expects format 31). You need to upgrade the working copy first.
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1696:
 exec returned: 100

Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1863
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

[Flavio Junqueira (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058735#comment-14058735
 ] 

Flavio Junqueira commented on ZOOKEEPER-1807:
-

Ping, I don't think we have converged here yet, have we?

> Observers spam each other creating connections to the election addr
> ---
>
> Key: ZOOKEEPER-1807
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
>Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, 
> ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807-ver4.patch, 
> ZOOKEEPER-1807-ver5.patch, ZOOKEEPER-1807.patch, notifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open 
> connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 14
> {noformat}
> and so and so on ad nauseam. 
> Now, looking around I found this inside FastLeaderElection.java from when you 
> committed ZOOKEEPER-107:
> {noformat}
>  private void sendNotifications() {
> -for (QuorumServer server : self.getVotingView().values()) {
> -long sid = server.id;
> -
> +for (long sid : self.getAllKnownServerIds()) {
> +QuorumVerifier qv = self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try to 
> connect to each other (as opposed as just connecting to participants). I'll 
> give it a try now and let you know. (Also, we use observer ids that are > 0, 
> and I saw some parts of the code that might not deal with that assumption - 
> so it could be that too..). 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (ZOOKEEPER-1863) Race condition in commit processor leading to out of order request completion, xid mismatch on client.

[Flavio Junqueira (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira updated ZOOKEEPER-1863:


Attachment: ZOOKEEPER-1863.patch

I was thinking that with the changes I'm proposing here, we should be able to 
write a test case by populating committedRequests and queuedRequests 
accordingly. What do you think?

> Race condition in commit processor leading to out of order request 
> completion, xid mismatch on client.
> --
>
> Key: ZOOKEEPER-1863
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1863
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Dutch T. Meyer
>Assignee: Dutch T. Meyer
>Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, 
> ZOOKEEPER-1863.patch, ZOOKEEPER-1863.patch, stack.17512
>
>
> In CommitProcessor.java processor, if we are at the primary request handler 
> on line 167:
> {noformat}
> while (!stopped && !isWaitingForCommit() &&
>!isProcessingCommit() &&
>(request = queuedRequests.poll()) != null) {
> if (needCommit(request)) {
> nextPending.set(request);
> } else {
> sendToNextProcessor(request);
> }
> }
> {noformat}
> A request can be handled in this block and be quickly processed and completed 
> on another thread. If queuedRequests is empty, we then exit the block. Next, 
> before this thread makes any more progress, we can get 2 more requests, one 
> get_children(say), and a sync placed on queuedRequests for the processor. 
> Then, if we are very unlucky, the sync request can complete and this object's 
> commit() routine is called (from FollowerZookeeperServer), which places the 
> sync request on the previously empty committedRequests queue. At that point, 
> this thread continues.
> We reach line 182, which is a check on sync requests.
> {noformat}
> if (!stopped && !isProcessingRequest() &&
> (request = committedRequests.poll()) != null) {
> {noformat}
> Here we are not processing any requests, because the original request has 
> completed. We haven't dequeued either the read or the sync request in this 
> processor. Next, the poll above will pull the sync request off the queue, and 
> in the following block, the sync will get forwarded to the next processor.
> This is a problem because the read request hasn't been forwarded yet, so 
> requests are now out of order.
> I've been able to reproduce this bug reliably by injecting a 
> Thread.sleep(5000) between the two blocks above to make the race condition 
> far more likely, then in a client program.
> {noformat}
> zoo_aget_children(zh, "/", 0, getchildren_cb, NULL);
> //Wait long enough for queuedRequests to drain
> sleep(1);
> zoo_aget_children(zh, "/", 0, getchildren_cb, &th_ctx[0]);
> zoo_async(zh, "/", sync_cb, &th_ctx[0]);
> {noformat}
> When this bug is triggered, 3 things can happen:
> 1) Clients will see requests complete out of order and fail on xid mismatches.
> 2) Kazoo in particular doesn't handle this runtime exception well, and can 
> orphan outstanding requests.
> 3) I've seen zookeeper servers deadlock, likely because the commit cannot be 
> completed, which can wedge the commit processor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

ZooKeeper-trunk - Build # 2369 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/2369/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 282992 lines...]
 [exec] mv -f .deps/zktest_mt-ZooKeeperQuorumServer.Tpo 
.deps/zktest_mt-ZooKeeperQuorumServer.Po
 [exec] g++ -DHAVE_CONFIG_H -I. 
-I/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c  
-I/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/include 
-I/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests 
-I/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/generated  
-DUSE_STATIC_LIB -DTHREADED 
-DZKSERVER_CMD="\"/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/zkServer.sh\""
 -DZOO_IPV6_ENABLED -g -O2 -MT zktest_mt-TestReadOnlyClient.o -MD -MP -MF 
.deps/zktest_mt-TestReadOnlyClient.Tpo -c -o zktest_mt-TestReadOnlyClient.o 
`test -f 'tests/TestReadOnlyClient.cc' || echo 
'/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/'`tests/TestReadOnlyClient.cc
 [exec] mv -f .deps/zktest_mt-TestReadOnlyClient.Tpo 
.deps/zktest_mt-TestReadOnlyClient.Po
 [exec] g++ -DHAVE_CONFIG_H -I. 
-I/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c  
-I/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/include 
-I/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests 
-I/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/generated  
-DUSE_STATIC_LIB -DTHREADED 
-DZKSERVER_CMD="\"/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/zkServer.sh\""
 -DZOO_IPV6_ENABLED -g -O2 -MT zktest_mt-PthreadMocks.o -MD -MP -MF 
.deps/zktest_mt-PthreadMocks.Tpo -c -o zktest_mt-PthreadMocks.o `test -f 
'tests/PthreadMocks.cc' || echo 
'/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/'`tests/PthreadMocks.cc
 [exec] mv -f .deps/zktest_mt-PthreadMocks.Tpo 
.deps/zktest_mt-PthreadMocks.Po
 [exec] /bin/bash ./libtool  --tag=CXX   --mode=link g++ -DUSE_STATIC_LIB 
-DTHREADED 
-DZKSERVER_CMD="\"/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/zkServer.sh\""
 -DZOO_IPV6_ENABLED -g -O2 -static-libtool-libs -Wl,--wrap -Wl,calloc 
-Wl,--wrap -Wl,free -Wl,--wrap -Wl,flush_send_queue -Wl,--wrap -Wl,get_xid 
-Wl,--wrap -Wl,deliverWatchers -Wl,--wrap -Wl,activateWatcher -Wl,--wrap 
-Wl,pthread_mutex_lock -Wl,--wrap -Wl,pthread_mutex_trylock -Wl,--wrap 
-Wl,pthread_mutex_unlock  -o zktest-mt zktest_mt-TestDriver.o 
zktest_mt-LibCMocks.o zktest_mt-LibCSymTable.o zktest_mt-MocksBase.o 
zktest_mt-ZKMocks.o zktest_mt-Util.o zktest_mt-ThreadingUtil.o 
zktest_mt-TestZookeeperInit.o zktest_mt-TestZookeeperClose.o 
zktest_mt-TestReconfig.o zktest_mt-TestReconfigServer.o 
zktest_mt-TestClientRetry.o zktest_mt-TestOperations.o zktest_mt-TestMulti.o 
zktest_mt-TestWatchers.o zktest_mt-TestClient.o 
zktest_mt-ZooKeeperQuorumServer.o zktest_mt-TestReadOnlyClient.o 
zktest_mt-PthreadMocks.o libzkmt.la libhashtable.la -lpthread 
-L/usr/lib/x86_64-linux-gnu -lcppunit -ldl 
 [exec] libtool: link: g++ -DUSE_STATIC_LIB -DTHREADED 
-DZKSERVER_CMD=\"/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/zkServer.sh\"
 -DZOO_IPV6_ENABLED -g -O2 -Wl,--wrap -Wl,calloc -Wl,--wrap -Wl,free -Wl,--wrap 
-Wl,flush_send_queue -Wl,--wrap -Wl,get_xid -Wl,--wrap -Wl,deliverWatchers 
-Wl,--wrap -Wl,activateWatcher -Wl,--wrap -Wl,pthread_mutex_lock -Wl,--wrap 
-Wl,pthread_mutex_trylock -Wl,--wrap -Wl,pthread_mutex_unlock -o zktest-mt 
zktest_mt-TestDriver.o zktest_mt-LibCMocks.o zktest_mt-LibCSymTable.o 
zktest_mt-MocksBase.o zktest_mt-ZKMocks.o zktest_mt-Util.o 
zktest_mt-ThreadingUtil.o zktest_mt-TestZookeeperInit.o 
zktest_mt-TestZookeeperClose.o zktest_mt-TestReconfig.o 
zktest_mt-TestReconfigServer.o zktest_mt-TestClientRetry.o 
zktest_mt-TestOperations.o zktest_mt-TestMulti.o zktest_mt-TestWatchers.o 
zktest_mt-TestClient.o zktest_mt-ZooKeeperQuorumServer.o 
zktest_mt-TestReadOnlyClient.o zktest_mt-PthreadMocks.o  ./.libs/libzkmt.a -lm 
./.libs/libhashtable.a -lpthread -L/usr/lib/x86_64-linux-gnu -lcppunit -ldl
 [exec] make[1]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/test-cppunit'
 [exec] make  check-TESTS
 [exec] make[1]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/test-cppunit'
 [exec] make[2]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/test-cppunit'
 [exec] PASS: zktest-st
 [exec] FAIL: zktest-mt
 [exec] make[3]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/test-cppunit'
 [exec] make  all-am
 [exec] make[4]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/test-cppunit'
 [exec] make[4]: Leaving dire

ZooKeeper_branch34_jdk7 - Build # 591 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/591/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 228985 lines...]
[junit] 2014-07-11 10:42:48,587 [myid:] - INFO  [main:ClientBase@490] - 
STOPPING server
[junit] 2014-07-11 10:42:48,587 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@224] - 
NIOServerCnxn factory exited run method
[junit] 2014-07-11 10:42:48,588 [myid:] - INFO  [main:ZooKeeperServer@441] 
- shutting down
[junit] 2014-07-11 10:42:48,588 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2014-07-11 10:42:48,588 [myid:] - INFO  
[main:PrepRequestProcessor@761] - Shutting down
[junit] 2014-07-11 10:42:48,588 [myid:] - INFO  
[main:SyncRequestProcessor@209] - Shutting down
[junit] 2014-07-11 10:42:48,588 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2014-07-11 10:42:48,588 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited!
[junit] 2014-07-11 10:42:48,589 [myid:] - INFO  
[main:FinalRequestProcessor@415] - shutdown of request processor complete
[junit] 2014-07-11 10:42:48,589 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-07-11 10:42:48,590 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2014-07-11 10:42:48,591 [myid:] - INFO  [main:ClientBase@443] - 
STARTING server
[junit] 2014-07-11 10:42:48,591 [myid:] - INFO  [main:ClientBase@364] - 
CREATING server instance 127.0.0.1:11221
[junit] 2014-07-11 10:42:48,591 [myid:] - INFO  
[main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2014-07-11 10:42:48,591 [myid:] - INFO  [main:ClientBase@339] - 
STARTING server instance 127.0.0.1:11221
[junit] 2014-07-11 10:42:48,592 [myid:] - INFO  [main:ZooKeeperServer@162] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/branch-3.4/build/test/tmp/test921302743568401659.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/branch-3.4/build/test/tmp/test921302743568401659.junit.dir/version-2
[junit] 2014-07-11 10:42:48,594 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-07-11 10:42:48,595 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - 
Accepted socket connection from /127.0.0.1:45775
[junit] 2014-07-11 10:42:48,595 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:45775
[junit] 2014-07-11 10:42:48,595 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2014-07-11 10:42:48,596 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1007] - Closed socket connection for client 
/127.0.0.1:45775 (no session established for client)
[junit] 2014-07-11 10:42:48,596 [myid:] - INFO  [main:JMXEnv@229] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2014-07-11 10:42:48,597 [myid:] - INFO  [main:JMXEnv@246] - 
expect:InMemoryDataTree
[junit] 2014-07-11 10:42:48,598 [myid:] - INFO  [main:JMXEnv@250] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2014-07-11 10:42:48,598 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2014-07-11 10:42:48,598 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2014-07-11 10:42:48,598 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 10405
[junit] 2014-07-11 10:42:48,598 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 20
[junit] 2014-07-11 10:42:48,599 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota
[junit] 2014-07-11 10:42:48,599 [myid:] - INFO  [main:ClientBase@520] - 
tearDown starting
[junit] 2014-07-11 10:42:48,675 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x1472504a7e5 closed
[junit] 2014-07-11 10:42:48,675 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@512] - EventThread shut down
[junit] 2014-07-11 10:42:48,675 [myid:] - INFO  [main:ClientBase@490] - 
STOPPING server
[junit] 2014-07-11 10:42:48,676 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@224] - 
NIOServerCnxn factory exited run method
[junit] 2014-07-11 10:42:48,676 [myid:] - INFO  [main:ZooKeeperServer@441] 
- shutting down
[junit] 2014-07-11 10:42:48,676 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit]

ZooKeeper-trunk-WinVS2008_java - Build # 771 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/771/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 287148 lines...]
[junit] 2014-07-11 10:49:36,752 [myid:] - INFO  
[main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2014-07-11 10:49:36,753 [myid:] - INFO  [main:ClientBase@339] - 
STARTING server instance 127.0.0.1:11221
[junit] 2014-07-11 10:49:36,753 [myid:] - INFO  [main:ZooKeeperServer@766] 
- minSessionTimeout set to 6000
[junit] 2014-07-11 10:49:36,753 [myid:] - INFO  [main:ZooKeeperServer@775] 
- maxSessionTimeout set to 6
[junit] 2014-07-11 10:49:36,753 [myid:] - INFO  [main:ZooKeeperServer@149] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test4358527383240367623.junit.dir\version-2
 snapdir 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test4358527383240367623.junit.dir\version-2
[junit] 2014-07-11 10:49:36,754 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test4358527383240367623.junit.dir\version-2\snapshot.b
[junit] 2014-07-11 10:49:36,756 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test4358527383240367623.junit.dir\version-2\snapshot.b
[junit] 2014-07-11 10:49:36,758 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-07-11 10:49:36,759 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:56903
[junit] 2014-07-11 10:49:36,760 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from 
/127.0.0.1:56903
[junit] 2014-07-11 10:49:36,760 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output
[junit] 2014-07-11 10:49:36,760 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client 
/127.0.0.1:56903 (no session established for client)
[junit] 2014-07-11 10:49:36,761 [myid:] - INFO  [main:JMXEnv@224] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2014-07-11 10:49:36,762 [myid:] - INFO  [main:JMXEnv@241] - 
expect:InMemoryDataTree
[junit] 2014-07-11 10:49:36,762 [myid:] - INFO  [main:JMXEnv@245] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2014-07-11 10:49:36,762 [myid:] - INFO  [main:JMXEnv@241] - 
expect:StandaloneServer_port
[junit] 2014-07-11 10:49:36,763 [myid:] - INFO  [main:JMXEnv@245] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2014-07-11 10:49:36,763 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 13395
[junit] 2014-07-11 10:49:36,763 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 22
[junit] 2014-07-11 10:49:36,763 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota
[junit] 2014-07-11 10:49:36,764 [myid:] - INFO  [main:ClientBase@520] - 
tearDown starting
[junit] 2014-07-11 10:49:36,989 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@963] - Socket 
connection established to 127.0.0.1/127.0.0.1:11221, initiating session
[junit] 2014-07-11 10:49:36,989 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:56898
[junit] 2014-07-11 10:49:36,990 [myid:] - INFO  
[NIOWorkerThread-2:ZooKeeperServer@858] - Client attempting to renew session 
0x14724d3ed28 at /127.0.0.1:56898
[junit] 2014-07-11 10:49:36,990 [myid:] - INFO  
[NIOWorkerThread-2:ZooKeeperServer@604] - Established session 0x14724d3ed28 
with negotiated timeout 3 for client /127.0.0.1:56898
[junit] 2014-07-11 10:49:36,991 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1346] - Session 
establishment complete on server 127.0.0.1/127.0.0.1:11221, sessionid = 
0x14724d3ed28, negotiated timeout = 3
[junit] 2014-07-11 10:49:36,992 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@685] - Processed session termination for 
sessionid: 0x14724d3ed28
[junit] 2014-07-11 10:49:36,992 [myid:] - INFO  
[SyncThread:0:FileTxnLog@200] - Creating new log file: log.c
[junit] 2014-07-11 10:49:37,062 [myid:] - INFO  [main:ZooKeeper@968] - 
Session: 0x14724d3ed28 closed
[junit] 2014-07-11 10:49:37,062 [my

ZooKeeper-3.4-WinVS2008_java - Build # 526 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/526/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 182560 lines...]
[junit] 2014-07-11 10:24:47,968 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited!
[junit] 2014-07-11 10:24:47,968 [myid:] - INFO  
[main:FinalRequestProcessor@415] - shutdown of request processor complete
[junit] 2014-07-11 10:24:47,969 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-07-11 10:24:48,000 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop!
[junit] 2014-07-11 10:24:48,000 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop!
[junit] 2014-07-11 10:24:48,768 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@975] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11221. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2014-07-11 10:24:48,963 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2014-07-11 10:24:48,964 [myid:] - INFO  [main:ClientBase@443] - 
STARTING server
[junit] 2014-07-11 10:24:48,964 [myid:] - INFO  [main:ClientBase@364] - 
CREATING server instance 127.0.0.1:11221
[junit] 2014-07-11 10:24:48,965 [myid:] - INFO  
[main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2014-07-11 10:24:48,966 [myid:] - INFO  [main:ClientBase@339] - 
STARTING server instance 127.0.0.1:11221
[junit] 2014-07-11 10:24:48,966 [myid:] - INFO  [main:ZooKeeperServer@162] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test6139781807744939295.junit.dir\version-2
 snapdir 
f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test6139781807744939295.junit.dir\version-2
[junit] 2014-07-11 10:24:48,969 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-07-11 10:24:48,970 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - 
Accepted socket connection from /127.0.0.1:49543
[junit] 2014-07-11 10:24:48,970 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:49543
[junit] 2014-07-11 10:24:48,970 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2014-07-11 10:24:48,971 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1007] - Closed socket connection for client 
/127.0.0.1:49543 (no session established for client)
[junit] 2014-07-11 10:24:48,971 [myid:] - INFO  [main:JMXEnv@229] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2014-07-11 10:24:48,973 [myid:] - INFO  [main:JMXEnv@246] - 
expect:InMemoryDataTree
[junit] 2014-07-11 10:24:48,973 [myid:] - INFO  [main:JMXEnv@250] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2014-07-11 10:24:48,973 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2014-07-11 10:24:48,973 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2014-07-11 10:24:48,973 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 10979
[junit] 2014-07-11 10:24:48,974 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 19
[junit] 2014-07-11 10:24:48,974 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota
[junit] 2014-07-11 10:24:48,974 [myid:] - INFO  [main:ClientBase@520] - 
tearDown starting
[junit] 2014-07-11 10:24:49,259 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@852] - Socket 
connection established to 127.0.0.1/127.0.0.1:11221, initiating session
[junit] 2014-07-11 10:24:49,259 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - 
Accepted socket connection from /127.0.0.1:49536
[junit] 2014-07-11 10:24:49,260 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:ZooKeeperServer@861] - Client 
attempting to renew session 0x14724bd39ce at /127.0.0.1:49536
[junit] 2014-07-11 10:24:49,260 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:ZooKeeperServer@617] - Established 
session 0x14724bd39ce with negotiated timeout 3 for client 
/127.0.0.1:49536
[junit] 2014-07-11 10:24:49,260 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1235] - Session 
establishment complete on server 127.0.0.1/127.0.0.1:11221, sessionid = 
0x14724bd39ce

ZooKeeper_branch34 - Build # 1014 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34/1014/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 209009 lines...]
[junit] 2014-07-11 08:54:42,778 [myid:] - INFO  [main:JMXEnv@229] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2014-07-11 08:54:42,780 [myid:] - INFO  [main:JMXEnv@246] - 
expect:InMemoryDataTree
[junit] 2014-07-11 08:54:42,781 [myid:] - INFO  [main:JMXEnv@250] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2014-07-11 08:54:42,781 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2014-07-11 08:54:42,781 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2014-07-11 08:54:42,781 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 31152
[junit] 2014-07-11 08:54:42,782 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 20
[junit] 2014-07-11 08:54:42,782 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota
[junit] 2014-07-11 08:54:42,782 [myid:] - INFO  [main:ClientBase@520] - 
tearDown starting
[junit] 2014-07-11 08:54:42,845 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x14724a1b2a2 closed
[junit] 2014-07-11 08:54:42,846 [myid:] - INFO  [main:ClientBase@490] - 
STOPPING server
[junit] 2014-07-11 08:54:42,846 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@512] - EventThread shut down
[junit] 2014-07-11 08:54:42,846 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@224] - 
NIOServerCnxn factory exited run method
[junit] 2014-07-11 08:54:42,846 [myid:] - INFO  [main:ZooKeeperServer@441] 
- shutting down
[junit] 2014-07-11 08:54:42,847 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2014-07-11 08:54:42,847 [myid:] - INFO  
[main:PrepRequestProcessor@761] - Shutting down
[junit] 2014-07-11 08:54:42,847 [myid:] - INFO  
[main:SyncRequestProcessor@209] - Shutting down
[junit] 2014-07-11 08:54:42,848 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2014-07-11 08:54:42,848 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited!
[junit] 2014-07-11 08:54:42,848 [myid:] - INFO  
[main:FinalRequestProcessor@415] - shutdown of request processor complete
[junit] 2014-07-11 08:54:42,849 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2014-07-11 08:54:42,850 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2014-07-11 08:54:42,854 [myid:] - INFO  [main:ClientBase@545] - 
fdcount after test is: 38 at start it was 25
[junit] 2014-07-11 08:54:42,854 [myid:] - INFO  [main:ClientBase@547] - 
sleeping for 20 secs
[junit] 2014-07-11 08:54:42,855 [myid:] - INFO  [main:ZKTestCase$1@60] - 
SUCCEEDED testQuota
[junit] 2014-07-11 08:54:42,855 [myid:] - INFO  [main:ZKTestCase$1@55] - 
FINISHED testQuota
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.605 sec

test-core-java:

call-test-cppunit:

init:

check-cppunit-makefile:

create-cppunit-makefile:

init:

check-cppunit-configure:

create-cppunit-configure:
[mkdir] Created dir: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/branch-3.4/build/test/test-cppunit
 [exec] checking for doxygen... no
 [exec] checking for perl... /usr/bin/perl
 [exec] configure: error: cannot find install-sh, install.sh, or shtool in 
"/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/branch-3.4/src/c" 
"/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/branch-3.4/src/c/.." 
"/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/branch-3.4/src/c/../.."
 [exec] checking for dot... no

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/branch-3.4/build.xml:1392:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/branch-3.4/build.xml:1351:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/branch-3.4/build.xml:1343:
 exec returned: 1

Total time: 24 minutes 57 seconds
Build step 'Execute shell' marked build as failure
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

ZooKeeper-trunk-WinVS2008 - Build # 1431 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/1431/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 158 lines...]
.\src\zookeeper.c(2505): warning C4267: '=' : conversion from 'size_t' to 
'int', possible loss of data 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
.\src\zookeeper.c(3205): warning C4267: '=' : conversion from 'size_t' to 
'int', possible loss of data 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
.\src\zookeeper.c(3831): warning C4267: 'initializing' : conversion from 
'size_t' to 'int', possible loss of data 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
Cli:
  C:\Program Files (x86)\Microsoft Visual Studio 
9.0\Common7\IDE\..\..\vc\vcpackages\vcbuild.exe 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\Cli.vcproj
 "Release|Win32" 
cli.obj : error LNK2001: unresolved external symbol __imp__ZOO_READONLY_STATE 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\Release\Cli.exe
 : fatal error LNK1120: 1 unresolved externals 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
Done Building Project 
"f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln"
 (default targets) -- FAILED.

Build FAILED.

"f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln"
 (default target) (1) ->
(zookeeper target) -> 
  cl : Command line warning D9035: option 'Wp64' has been deprecated and will 
be removed in a future release 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(252): warning C4267: 'function' : conversion from 'size_t' 
to 'int', possible loss of data 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(533): warning C4996: 'strdup': The POSIX name for this item 
is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online 
help for details. 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(781): warning C4996: 'strdup': The POSIX name for this item 
is deprecated. Instead, use the ISO C++ conformant name: _strdup. See online 
help for details. 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(1045): warning C4996: 'strdup': The POSIX name for this 
item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See 
online help for details. 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(1056): warning C4996: 'strncpy': This function or variable 
may be unsafe. Consider using strncpy_s instead. To disable deprecation, use 
_CRT_SECURE_NO_WARNINGS. See online help for details. 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(1062): warning C4996: 'strdup': The POSIX name for this 
item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See 
online help for details. 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(1137): warning C4996: 'strdup': The POSIX name for this 
item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See 
online help for details. 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(1266): warning C4996: 'strdup': The POSIX name for this 
item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See 
online help for details. 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(1269): warning C4996: 'strcpy': This function or variable 
may be unsafe. Consider using strcpy_s instead. To disable deprecation, use 
_CRT_SECURE_NO_WARNINGS. See online help for details. 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(1270): warning C4996: 'strcat': This function or variable 
may be unsafe. Consider using strcat_s instead. To disable deprecation, use 
_CRT_SECURE_NO_WARNINGS. See online help for details. 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(1289): warning C4996: 'strdup': The POSIX name for this 
item is deprecated. Instead, use the ISO C++ conformant name: _strdup. See 
online help for details. 
[f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln]
  .\src\zookeeper.c(1292): warning C4996: 'strdup': The POSIX name for this 
item is deprecated. Instead, use t

[jira] [Commented] (ZOOKEEPER-102) Need to replace Jute with supported code

[Raul Gutierrez Segales (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058511#comment-14058511
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-102:
--

We don't necessarily have to break other clients. Can't we not use the protocol 
field in the ConnectRequest to negotiate such things as serialization (or 
compression, etc... it's a 32bit after all, lots of space!)?

> Need to replace Jute with supported code
> 
>
> Key: ZOOKEEPER-102
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-102
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Benjamin Reed
> Fix For: 4.0.0
>
>
> ZooKeeper currently uses Jute to serialize objects to put on the wire and on 
> disk. We pulled Jute out of Hadoop and added a C binding. Both versions of 
> Jute have evolved (although Hadoop still doesn't have a C binding). It would 
> be nice to use a more standard serialization library. Some options include 
> Thrift or Google's protocol buffers.
> Our main requirements would be Java and C bindings and good performance. (For 
> example, serializing to XML would give us incredibly bad performance and 
> would not be acceptible!)



--
This message was sent by Atlassian JIRA
(v6.2#6252)