[jira] [Commented] (ZOOKEEPER-2105) PrintWriter left unclosed in NIOServerCnxn#checkFourLetterWord
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282139#comment-14282139
]
Rakesh R commented on ZOOKEEPER-2105:
-
Thanks [~yuzhih...@gmail.com] for reporting this.
I could see, all the commands have the cleanup logic inside {{#run()}} method.
After the execution of the {{#commandRun()}}, will do the cleanup in the
{{finally block}}. Is that sufficient to close the printwriter ?
{{CommandThread.java}}
{code}
public void run() {
try {
commandRun();
} catch (IOException ie) {
LOG.error(Error in running command , ie);
} finally {
cleanupWriterSocket(pw);
}
{code}
-Rakesh
PrintWriter left unclosed in NIOServerCnxn#checkFourLetterWord
--
Key: ZOOKEEPER-2105
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2105
Project: ZooKeeper
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
Attachments: zookeeper-2105-v1.patch
{code}
final PrintWriter pwriter = new PrintWriter(
new BufferedWriter(new SendBufferWriter()));
{code}
pwriter should be closed upon return from the method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ZooKeeper-trunk-solaris - Build # 914 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/914/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by timer
Building remotely on solaris1 (Solaris) in workspace
/export/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris
Updating http://svn.apache.org/repos/asf/zookeeper/trunk at revision
'2015-01-18T08:30:53.761 +'
At revision 1652708
Updating http://svn.apache.org/repos/asf/hadoop/nightly at revision
'2015-01-18T08:30:53.761 +'
At revision 1652708
no change for http://svn.apache.org/repos/asf/zookeeper/trunk since the
previous build
no change for http://svn.apache.org/repos/asf/hadoop/nightly since the previous
build
No emails were triggered.
[locks-and-latches] Checking to see if we really have the locks
[locks-and-latches] Have all the locks, build can start
[ZooKeeper-trunk-solaris] $ /bin/bash /var/tmp/hudson2072626013300475601.sh
[trunk] $
/export/home/hudson/hudson-slave/tools/hudson.tasks.Ant_AntInstallation/ant-1.8.2/bin/ant
-DBUILD_ARGS=-Dfindbugs.home=${FINDBUGS_HOME} -Dforrest.home=${FORREST_HOME}
-Djava5.home=${JAVA5_HOME} -DBUILD_TARGETS=hudson-test-trunk
-DANALYSIS_TARGETS=test -DBUILD_FLAGS=-Dtest.junit.output.format=xml
-Dtest.output=yes -Dtest.output=yes -Dtest.junit.output.format=xml clean
test-core-java
Error: JAVA_HOME is not defined correctly.
We cannot execute /home/jenkins/tools/java/latest1.7/bin/java
Build step 'Invoke Ant' marked build as failure
[locks-and-latches] Releasing all the locks
[locks-and-latches] All the locks released
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure
###
## FAILED TESTS (if any)
##
No tests ran.
ZooKeeper_branch35_jdk7 - Build # 176 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/176/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 352468 lines...] [junit] 2015-01-18 10:57:36,917 [myid:] - INFO [main:JMXEnv@142] - ensureOnly:[] [junit] 2015-01-18 10:57:36,919 [myid:] - INFO [main:ClientBase@443] - STARTING server [junit] 2015-01-18 10:57:36,919 [myid:] - INFO [main:ClientBase@364] - CREATING server instance 127.0.0.1:11221 [junit] 2015-01-18 10:57:36,920 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 32 worker threads, and 64 kB direct buffers. [junit] 2015-01-18 10:57:36,920 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2015-01-18 10:57:36,921 [myid:] - INFO [main:ClientBase@339] - STARTING server instance 127.0.0.1:11221 [junit] 2015-01-18 10:57:36,921 [myid:] - INFO [main:ZooKeeperServer@781] - minSessionTimeout set to 6000 [junit] 2015-01-18 10:57:36,921 [myid:] - INFO [main:ZooKeeperServer@790] - maxSessionTimeout set to 6 [junit] 2015-01-18 10:57:36,921 [myid:] - INFO [main:ZooKeeperServer@152] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build/test/tmp/test4649604446408425209.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build/test/tmp/test4649604446408425209.junit.dir/version-2 [junit] 2015-01-18 10:57:36,923 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build/test/tmp/test4649604446408425209.junit.dir/version-2/snapshot.b [junit] 2015-01-18 10:57:36,925 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build/test/tmp/test4649604446408425209.junit.dir/version-2/snapshot.b [junit] 2015-01-18 10:57:36,928 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2015-01-18 10:57:36,928 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:45571 [junit] 2015-01-18 10:57:36,929 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from /127.0.0.1:45571 [junit] 2015-01-18 10:57:36,929 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output [junit] 2015-01-18 10:57:36,930 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client /127.0.0.1:45571 (no session established for client) [junit] 2015-01-18 10:57:36,930 [myid:] - INFO [main:JMXEnv@224] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2015-01-18 10:57:36,932 [myid:] - INFO [main:JMXEnv@241] - expect:InMemoryDataTree [junit] 2015-01-18 10:57:36,933 [myid:] - INFO [main:JMXEnv@245] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2015-01-18 10:57:36,933 [myid:] - INFO [main:JMXEnv@241] - expect:StandaloneServer_port [junit] 2015-01-18 10:57:36,933 [myid:] - INFO [main:JMXEnv@245] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2015-01-18 10:57:36,933 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 18089 [junit] 2015-01-18 10:57:36,934 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 24 [junit] 2015-01-18 10:57:36,934 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota [junit] 2015-01-18 10:57:36,934 [myid:] - INFO [main:ClientBase@520] - tearDown starting [junit] 2015-01-18 10:57:36,992 [myid:] - INFO [main:ZooKeeper@968] - Session: 0x14afcb0db6c closed [junit] 2015-01-18 10:57:36,993 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2015-01-18 10:57:36,992 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@530] - EventThread shut down [junit] 2015-01-18 10:57:36,993 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2015-01-18 10:57:36,993 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2015-01-18 10:57:36,993 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2015-01-18 10:57:36,993 [myid:] - INFO
ZooKeeper-trunk - Build # 2567 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk/2567/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 2963 lines...] [clover] Updating existing database at '/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/clover/db/zookeeper_coverage.db'. [clover] Processing files at 1.3 source level. [clover] /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/java/main/org/apache/zookeeper/KeeperException.java:318:24:unexpected token: Code [clover] /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/java/main/org/apache/zookeeper/KeeperException.java:318:24:unexpected token: Code [clover] ** Error(s) occurred and the instrumentation process can't continue. BUILD FAILED /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1422: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:432: com.cenqua.clover.CloverException: /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/java/main/org/apache/zookeeper/KeeperException.java:318:24:unexpected token: Code at com.cenqua.clover.instr.Instrumenter.instrument(Instrumenter.java:155) at org.apache.tools.ant.taskdefs.CloverCompilerAdapter.setJavac(CloverCompilerAdapter.java:339) at org.apache.tools.ant.taskdefs.Javac.compile(Javac.java:1156) at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:935) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:435) at org.apache.tools.ant.Target.performTasks(Target.java:456) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:38) at org.apache.tools.ant.Project.executeTargets(Project.java:1248) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:441) at org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:105) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:435) at org.apache.tools.ant.Target.performTasks(Target.java:456) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393) at org.apache.tools.ant.Project.executeTarget(Project.java:1364) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1248) at org.apache.tools.ant.Main.runBuild(Main.java:851) at org.apache.tools.ant.Main.startAnt(Main.java:235) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) Total time: 5 seconds Build step 'Execute shell' marked build as failure [FINDBUGS] Skipping publisher since build result is FAILURE [WARNINGS] Skipping publisher since build result is FAILURE Archiving artifacts Sending artifact delta relative to ZooKeeper-trunk #2531 Archived 3 artifacts Archive block size is 32768 Received 0 blocks and 18057258 bytes Compression is 0.0% Took 7.4 sec Recording fingerprints Recording test results Publishing Javadoc Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
Failed: ZOOKEEPER-2105 PreCommit Build #2482
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2105 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2482/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 351415 lines...] [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2482//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2482//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2482//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 6a87eca78dd787a3607002f16eecf99cf404c97a logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1714: exec returned: 1 Total time: 51 minutes 4 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2464 Archived 24 artifacts Archive block size is 32768 Received 8 blocks and 33664587 bytes Compression is 0.8% Took 8.1 sec Recording test results Description set: ZOOKEEPER-2105 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Updated] (ZOOKEEPER-2105) PrintWriter left unclosed in NIOServerCnxn#checkFourLetterWord
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated ZOOKEEPER-2105:
--
Attachment: zookeeper-2105-v1.patch
PrintWriter left unclosed in NIOServerCnxn#checkFourLetterWord
--
Key: ZOOKEEPER-2105
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2105
Project: ZooKeeper
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
Attachments: zookeeper-2105-v1.patch
{code}
final PrintWriter pwriter = new PrintWriter(
new BufferedWriter(new SendBufferWriter()));
{code}
pwriter should be closed upon return from the method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2105) PrintWriter left unclosed in NIOServerCnxn#checkFourLetterWord
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281964#comment-14281964
]
Hadoop QA commented on ZOOKEEPER-2105:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12692984/zookeeper-2105-v1.patch
against trunk revision 1646992.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2482//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2482//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2482//console
This message is automatically generated.
PrintWriter left unclosed in NIOServerCnxn#checkFourLetterWord
--
Key: ZOOKEEPER-2105
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2105
Project: ZooKeeper
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
Attachments: zookeeper-2105-v1.patch
{code}
final PrintWriter pwriter = new PrintWriter(
new BufferedWriter(new SendBufferWriter()));
{code}
pwriter should be closed upon return from the method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
