[jira] [Updated] (ZOOKEEPER-2114) jute generated allocate_* functions are not externally visible

[Tim Crowder (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Crowder updated ZOOKEEPER-2114:
---
Attachment: zk-makefile-patch

 jute generated allocate_* functions are not externally visible
 --

 Key: ZOOKEEPER-2114
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2114
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.5.0
Reporter: Tim Crowder
 Attachments: zk-makefile-patch


 Some jute generated functions (e.g. allocate_ACL_vector) that should be 
 publicly exported are given local (vs global) linkage. This is due to an 
 incomplete regex for EXPORT_SYMBOLS  in the C Makefile.am.
 Without allocate_ACL_vector it's not possible to set ACL lists from C.
 The regex should include allocate_ :
 EXPORT_SYMBOLS = 
 '(zoo_|zookeeper_|zhandle|Z|format_log_message|log_message|logLevel|deallocate_|allocate_|zerror|is_unrecoverable)'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2114) jute generated allocate_* functions are not externally visible

[Tim Crowder (JIRA)]

Tim Crowder created ZOOKEEPER-2114:
--

 Summary: jute generated allocate_* functions are not externally 
visible
 Key: ZOOKEEPER-2114
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2114
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.5.0
Reporter: Tim Crowder


Some jute generated functions (e.g. allocate_ACL_vector) that should be 
publicly exported are given local (vs global) linkage. This is due to an 
incomplete regex for EXPORT_SYMBOLS  in the C Makefile.am.

Without allocate_ACL_vector it's not possible to set ACL lists from C.
The regex should include allocate_ :

EXPORT_SYMBOLS = 
'(zoo_|zookeeper_|zhandle|Z|format_log_message|log_message|logLevel|deallocate_|allocate_|zerror|is_unrecoverable)'




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2115) watcher = currentUser()

[Yukinori Suda (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yukinori Suda updated ZOOKEEPER-2115:
-
Summary: watcher = currentUser()  (was: Adding additional checks in 
zkServer-initialize.sh)

 watcher = currentUser()
 ---

 Key: ZOOKEEPER-2115
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2115
 Project: ZooKeeper
  Issue Type: Bug
  Components: scripts
Affects Versions: 3.5.0
Reporter: Manikandan Narayanaswamy
Priority: Trivial
 Fix For: 3.6.0

 Attachments: ZOOKEEPER-2115.patch


 while testing single user mode that the initialize command succeeds even 
 though it didn't in case of permission errors on the data directory:
 {code}
 
 + exec /usr/lib/zookeeper/bin/zkServer-initialize.sh --myid=1
 mkdir: cannot create directory `/var/lib/zookeeper/version-2': Permission 
 denied
 mkdir: cannot create directory `/var/lib/zookeeper/version-2': Permission 
 denied
 /usr/lib/zookeeper/bin/zkServer-initialize.sh: line 112: 
 /var/lib/zookeeper/myid: Permission denied
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Time for a 3.5.1-alpha release?

[Michi Mutsuzaki]

I'd like to get ZOOKEEPER-1506 in.

On Thu, Feb 5, 2015 at 1:25 PM, Flavio Junqueira fpjunque...@yahoo.com wrote:
 I'd like to see the SSL work in for the next release.

 -Flavio

 On 05 Feb 2015, at 19:34, Raúl Gutiérrez Segalés r...@itevenworks.net 
 wrote:

 +1

 It would be nice, but they are not blockers, to get these in:

 https://issues.apache.org/jira/browse/ZOOKEEPER-1998
 https://issues.apache.org/jira/browse/ZOOKEEPER-2051
 https://issues.apache.org/jira/browse/ZOOKEEPER-2098

 thanks Patrick!


 -rgs


 On 5 February 2015 at 11:22, Michi Mutsuzaki mi...@cs.stanford.edu wrote:

 +1 I can check in ZOOKEEPER-1366 tonight.

 On Thu, Feb 5, 2015 at 10:57 AM, Rakesh Radhakrishnan
 rakeshr.apa...@gmail.com wrote:
 +1 for 3.5.1-alpha release

 I think its good to include the following jira issues:

ZOOKEEPER-1366 (so far we got two +1)
ZOOKEEPER-1907 (its not blocking, good to have imprv)

 Best Regards,
 Rakesh

 On Thu, Feb 5, 2015 at 11:27 PM, Patrick Hunt ph...@apache.org wrote:

 Hi folks. 3.5.0-alpha has been out for a bit now, we've gotten some
 good feedback and a number of jira issues have been resolved. What do
 you think about putting out an updated 3.5.1-alpha release with the
 latest changes? Anything blocking us or that you feel important to
 include?

 Regards,

 Patrick

[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty

[Hongchao Deng (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308613#comment-14308613
 ] 

Hongchao Deng commented on ZOOKEEPER-2094:
--

I tried several ways and couldn't find a better way to include binary file 
changes except git apply.

Can we change infra to use git here? Also svn doesn't support diff of binary 
files.

 SSL feature on Netty
 

 Key: ZOOKEEPER-2094
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: server
Affects Versions: 3.4.6, 3.5.0
Reporter: Ian Dimayuga
Assignee: Ian Dimayuga
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, 
 testTrustStore.jks, testUntrustedKeyStore.jks


 Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider 
 to perform authentication.
 Review board: https://reviews.apache.org/r/30576/diff/#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

[Michi Mutsuzaki (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308633#comment-14308633
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1366:


+1 Thanks Hongchao!

 Zookeeper should be tolerant of clock adjustments
 -

 Key: ZOOKEEPER-1366
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Dunning
Assignee: Hongchao Deng
Priority: Critical
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 zookeeper-3.4.5-ZK1366-SC01.patch


 If you want to wreak havoc on a ZK based system just do [date -s +1hour] 
 and watch the mayhem as all sessions expire at once.
 This shouldn't happen.  Zookeeper could easily know handle elapsed times as 
 elapsed times rather than as differences between absolute times.  The 
 absolute times are subject to adjustment when the clock is set while a timer 
 is not subject to this problem.  In Java, System.currentTimeMillis() gives 
 you absolute time while System.nanoTime() gives you time based on a timer 
 from an arbitrary epoch.
 I have done this and have been running tests now for some tens of minutes 
 with no failures.  I will set up a test machine to redo the build again on 
 Ubuntu and post a patch here for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

[Michi Mutsuzaki (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michi Mutsuzaki updated ZOOKEEPER-1366:
---
Fix Version/s: 3.6.0

 Zookeeper should be tolerant of clock adjustments
 -

 Key: ZOOKEEPER-1366
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Dunning
Assignee: Hongchao Deng
Priority: Critical
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 zookeeper-3.4.5-ZK1366-SC01.patch


 If you want to wreak havoc on a ZK based system just do [date -s +1hour] 
 and watch the mayhem as all sessions expire at once.
 This shouldn't happen.  Zookeeper could easily know handle elapsed times as 
 elapsed times rather than as differences between absolute times.  The 
 absolute times are subject to adjustment when the clock is set while a timer 
 is not subject to this problem.  In Java, System.currentTimeMillis() gives 
 you absolute time while System.nanoTime() gives you time based on a timer 
 from an arbitrary epoch.
 I have done this and have been running tests now for some tens of minutes 
 with no failures.  I will set up a test machine to redo the build again on 
 Ubuntu and post a patch here for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

[Rakesh R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review71377
---



./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
https://reviews.apache.org/r/20071/#comment117087

When we catch and swallow InterruptedException, one common pattern is -  
call Thread.currentThread().interrupt() afterward, so that the interrupt status 
isn't lost.



./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java
https://reviews.apache.org/r/20071/#comment117088

OK, I will change



./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java
https://reviews.apache.org/r/20071/#comment117089

sure, will remove it



./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java
https://reviews.apache.org/r/20071/#comment117090

ok



./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
https://reviews.apache.org/r/20071/#comment117091

Yes, it synchronization should be improved further. Initially I thought of 
minimizing the scope of synchronized block, but I think it will not work out. 
Now, am planning to make both #startup() and #shutdown() synchronized method. 
Any comments?

synchronized startup()
//...
}

synchronized shutdown(){
if(!isRunning()){ return; }
super.shutdown();
// ...  
}


- Rakesh R


On Feb. 5, 2015, 6:32 p.m., Rakesh R wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20071/
 ---
 
 (Updated Feb. 5, 2015, 6:32 p.m.)
 
 
 Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille 
 Fournier.
 
 
 Bugs: ZOOKEEPER-1907
 https://issues.apache.org/jira/browse/ZOOKEEPER-1907
 
 
 Repository: zookeeper
 
 
 Description
 ---
 
 Improve the thread handling mechanism by detecting if any of the critical 
 thread dies.
 Here the idea is to periodically checking the status of all the critical 
 threads in ZK server using DeathWatcherThread.
 
 
 Diffs
 -
 
   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
 1657623 
   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1657623 
   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 
 1657623 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 
 1657623 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1657623 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java 
 PRE-CREATION 
   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
  1657623 
   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
  1657623 
   ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
 1657623 
   ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1657623 
   ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 
 1657623 
   
 ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
  1657623 
   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 
 1657623 
   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1657623 
   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 
 1657623 
 
 Diff: https://reviews.apache.org/r/20071/diff/
 
 
 Testing
 ---
 
 yet to be inlcuded
 
 
 Thanks,
 
 Rakesh R
 

Failed: ZOOKEEPER-2094 PreCommit Build #2516

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2516/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 2004 lines...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 30 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to introduce 4 new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] -1 release audit.  The applied patch generated 3 release audit 
warnings (more than the trunk's current 0 warnings).
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2516//testReport/
 [exec] Release audit warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2516//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2516//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2516//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] e1df23425d2f56d9ee1a6c5cd33dc267a91c77b9 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1714:
 exec returned: 3

Total time: 2 minutes 31 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2489
Archived 8 artifacts
Archive block size is 32768
Received 3 blocks and 489817 bytes
Compression is 16.7%
Took 1.4 sec
Recording test results
Description set: ZOOKEEPER-2094
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308556#comment-14308556
 ] 

Hadoop QA commented on ZOOKEEPER-2094:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12696946/ZOOKEEPER-2094.patch
  against trunk revision 1656167.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 30 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 4 new Findbugs (version 2.0.3) 
warnings.

-1 release audit.  The applied patch generated 3 release audit warnings 
(more than the trunk's current 0 warnings).

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2516//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2516//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2516//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2516//console

This message is automatically generated.

 SSL feature on Netty
 

 Key: ZOOKEEPER-2094
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: server
Affects Versions: 3.4.6, 3.5.0
Reporter: Ian Dimayuga
Assignee: Ian Dimayuga
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, 
 testTrustStore.jks, testUntrustedKeyStore.jks


 Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider 
 to perform authentication.
 Review board: https://reviews.apache.org/r/30576/diff/#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

[Michi Mutsuzaki (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308647#comment-14308647
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1907:


+1 I'll wait for Hongchao's +1 before checking this in. Thanks Rakesh!

 Improve Thread handling
 ---

 Key: ZOOKEEPER-1907
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1907
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Affects Versions: 3.5.0
Reporter: Rakesh R
Assignee: Rakesh R
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, 
 ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, 
 ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, 
 ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch


 Server has many critical threads running and co-ordinating each other like  
 RequestProcessor chains et. When going through each threads, most of them 
 having the similar structure like:
 {code}
 public void run() {
 try {
   while(running)
// processing logic
   }
 } catch (InterruptedException e) {
 LOG.error(Unexpected interruption, e);
 } catch (Exception e) {
 LOG.error(Unexpected exception, e);
 }
 LOG.info(...exited loop!);
 }
 {code}
 From the design I could see, there could be a chance of silently leaving the 
 thread by swallowing the exception. If this happens in the production, the 
 server would get hanged forever and would not be able to deliver its role. 
 Now its hard for the management tool to detect this.
 The idea of this JIRA is to discuss and imprv.
 Reference: [Community discussion 
 thread|http://mail-archives.apache.org/mod_mbox/zookeeper-user/201403.mbox/%3cc2496325850aa74c92aaf83aa9662d26458a1...@szxeml561-mbx.china.huawei.com%3E]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308687#comment-14308687
 ] 

Rakesh R commented on ZOOKEEPER-1366:
-

Thank you [~hdeng], all others for quickly fixing this issue.

[~michim] there is one subtask in OPEN state for changing C library part - 
ZOOKEEPER-1626. I feel its good to keep the parent jira in open state until all 
the sub-tasks is completed.  Either we can re-open this parent jira task or 
will move the sub-task ZOOKEEPER-1626 to a main jira and work on until it is 
closed. Whats your opinion?


 Zookeeper should be tolerant of clock adjustments
 -

 Key: ZOOKEEPER-1366
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Dunning
Assignee: Hongchao Deng
Priority: Critical
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 zookeeper-3.4.5-ZK1366-SC01.patch


 If you want to wreak havoc on a ZK based system just do [date -s +1hour] 
 and watch the mayhem as all sessions expire at once.
 This shouldn't happen.  Zookeeper could easily know handle elapsed times as 
 elapsed times rather than as differences between absolute times.  The 
 absolute times are subject to adjustment when the clock is set while a timer 
 is not subject to this problem.  In Java, System.currentTimeMillis() gives 
 you absolute time while System.nanoTime() gives you time based on a timer 
 from an arbitrary epoch.
 I have done this and have been running tests now for some tens of minutes 
 with no failures.  I will set up a test machine to redo the build again on 
 Ubuntu and post a patch here for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch34_solaris - Build # 908 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_solaris/908/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 174699 lines...]
[junit] 2015-02-06 07:57:10,663 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2015-02-06 07:57:10,663 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2015-02-06 07:57:10,663 [myid:] - INFO  [main:ClientBase@490] - 
STOPPING server
[junit] 2015-02-06 07:57:10,664 [myid:] - INFO  [main:ZooKeeperServer@441] 
- shutting down
[junit] 2015-02-06 07:57:10,664 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2015-02-06 07:57:10,664 [myid:] - INFO  
[main:PrepRequestProcessor@760] - Shutting down
[junit] 2015-02-06 07:57:10,664 [myid:] - INFO  
[main:SyncRequestProcessor@209] - Shutting down
[junit] 2015-02-06 07:57:10,664 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2015-02-06 07:57:10,664 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited!
[junit] 2015-02-06 07:57:10,665 [myid:] - INFO  
[main:FinalRequestProcessor@415] - shutdown of request processor complete
[junit] 2015-02-06 07:57:10,665 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2015-02-06 07:57:10,666 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2015-02-06 07:57:10,667 [myid:] - INFO  [main:ClientBase@443] - 
STARTING server
[junit] 2015-02-06 07:57:10,667 [myid:] - INFO  [main:ClientBase@364] - 
CREATING server instance 127.0.0.1:11221
[junit] 2015-02-06 07:57:10,667 [myid:] - INFO  
[main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2015-02-06 07:57:10,668 [myid:] - INFO  [main:ClientBase@339] - 
STARTING server instance 127.0.0.1:11221
[junit] 2015-02-06 07:57:10,668 [myid:] - INFO  [main:ZooKeeperServer@162] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test3047659809723640951.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test3047659809723640951.junit.dir/version-2
[junit] 2015-02-06 07:57:10,671 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2015-02-06 07:57:10,671 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - 
Accepted socket connection from /127.0.0.1:43648
[junit] 2015-02-06 07:57:10,671 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:43648
[junit] 2015-02-06 07:57:10,671 [myid:] - INFO  
[Thread-5:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2015-02-06 07:57:10,672 [myid:] - INFO  
[Thread-5:NIOServerCnxn@1007] - Closed socket connection for client 
/127.0.0.1:43648 (no session established for client)
[junit] 2015-02-06 07:57:10,672 [myid:] - INFO  [main:JMXEnv@229] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2015-02-06 07:57:10,673 [myid:] - INFO  [main:JMXEnv@246] - 
expect:InMemoryDataTree
[junit] 2015-02-06 07:57:10,673 [myid:] - INFO  [main:JMXEnv@250] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2015-02-06 07:57:10,673 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2015-02-06 07:57:10,674 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2015-02-06 07:57:10,674 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 8713
[junit] 2015-02-06 07:57:10,674 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 20
[junit] 2015-02-06 07:57:10,674 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota
[junit] 2015-02-06 07:57:10,674 [myid:] - INFO  [main:ClientBase@520] - 
tearDown starting
[junit] 2015-02-06 07:57:10,756 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@512] - EventThread shut down
[junit] 2015-02-06 07:57:10,756 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x14b5de47d97 closed
[junit] 2015-02-06 07:57:10,756 [myid:] - INFO  [main:ClientBase@490] - 
STOPPING server
[junit] 2015-02-06 07:57:10,757 [myid:] - INFO  [main:ZooKeeperServer@441] 
- shutting down
[junit] 2015-02-06 07:57:10,757 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 

[jira] [Commented] (ZOOKEEPER-2098) QuorumCnxManager: use BufferedOutputStream for initial msg

[Michi Mutsuzaki (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308654#comment-14308654
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-2098:


Thanks for the patch Raul! I'll check this in once Hongchao's comment is 
addressed.

 QuorumCnxManager: use BufferedOutputStream for initial msg
 --

 Key: ZOOKEEPER-2098
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2098
 Project: ZooKeeper
  Issue Type: Improvement
  Components: quorum, server
Affects Versions: 3.5.0
Reporter: Raul Gutierrez Segales
Assignee: Raul Gutierrez Segales
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2098.patch


 Whilst writing fle-dump (a tool like 
 [zk-dump|https://github.com/twitter/zktraffic/], but to dump 
 FastLeaderElection messages), I noticed that QCM is using DataOutputStream 
 (which doesn't buffer) directly.
 So all calls to write() are written immediately to the network, which means 
 simple messaages like two participants exchanging Votes can take a couple 
 RTTs! This is specially terrible for global clusters (i.e.: x-country RTTs).
 The solution is to use BufferedOutputStream for the initial negotiation 
 between members of the cluster. Note that there are other places were 
 suboptimal (but not entirely unbuffered) writes to the network still exist. 
 I'll get those in separate tickets.
 After using BufferedOutputStream we get only 1 RTT for the initial message, 
 so elections  time for for participants to join a cluster is reduced.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be tolerant of clock adjustments

[Marshall McMullen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/#review71222
---



src/java/main/org/apache/zookeeper/common/Time.java
https://reviews.apache.org/r/30573/#comment116890

I *REALLY* like the addition of the Time class. Nice abstraction layer.



src/java/main/org/apache/zookeeper/common/Time.java
https://reviews.apache.org/r/30573/#comment116891

Can you please format the body of this method like we normally do so it's 
not all on one line?



src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
https://reviews.apache.org/r/30573/#comment116893

Is it worth changing callers of ZooKeeperServer.java's getTime to instead 
call into the new Time.currentWallTime for increased clarity? Or is that a LOT 
of refactoring? I confess I didn't look.


- Marshall McMullen


On Feb. 5, 2015, 12:37 a.m., Hongchao Deng wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30573/
 ---
 
 (Updated Feb. 5, 2015, 12:37 a.m.)
 
 
 Review request for zookeeper.
 
 
 Repository: zookeeper-git
 
 
 Description
 ---
 
 Zookeeper should be tolerant of clock adjustments
 
 
 Diffs
 -
 
   src/java/main/org/apache/zookeeper/ClientCnxn.java 
 c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc 
   src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 
 16cb9120686bf982b4c68a0172600d23b6119042 
   src/java/main/org/apache/zookeeper/Login.java 
 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b 
   src/java/main/org/apache/zookeeper/Shell.java 
 62169d797a7a103d921634c4676fffea878def51 
   src/java/main/org/apache/zookeeper/ZKUtil.java 
 4713a08a934175c2b297f69740e204c7288c078c 
   src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION 
   src/java/main/org/apache/zookeeper/server/ConnectionBean.java 
 917aacfdcdcd50576029faab65ca98b89cfb2df9 
   src/java/main/org/apache/zookeeper/server/ExpiryQueue.java 
 a037bf49235e386cc20ee68633ec162b1db013d1 
   src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 
 a97be4a5452006fbd85d355c0dcb16276cbf1c59 
   src/java/main/org/apache/zookeeper/server/RateLogger.java 
 fc951cf5147bedbf1786ff1047a1e1a5fd7f5121 
   src/java/main/org/apache/zookeeper/server/Request.java 
 ee01dcfa63784a9dd380f91d768e1b3f28b9cce9 
   src/java/main/org/apache/zookeeper/server/ServerStats.java 
 c3246293e409d863412144ed76b2a91ca1ac98f2 
   src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 
 0c2c042e276c557a86f47d7ab5333e6860e12bd9 
   src/java/main/org/apache/zookeeper/server/WorkerService.java 
 c55ff48f92e5e3ae7783ad5be0262a5d9899c521 
   src/java/main/org/apache/zookeeper/server/ZKDatabase.java 
 f336049f0afb7b539460223b4903d323e2558aed 
   src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 
 30a0ed390bb7473ddb36757da97bc7d5f4281887 
   
 src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 
 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a 
   src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
 dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f 
   src/java/main/org/apache/zookeeper/server/quorum/Follower.java 
 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5 
   src/java/main/org/apache/zookeeper/server/quorum/Leader.java 
 20589045752a7ba4ae9c9090055a4fcbe86a8eda 
   
 src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java
  97b48915321aab6ea31bd7db8fe1197165507feb 
   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de 
   src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 
 4092c760f2cc4eda410ac6125e58ec399d1a6ca4 
   src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 
 809fa4819eed61aee3fcee1b5641ec85b967d479 
   src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 
 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3 
   src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION 
   src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 
 9abe47910f5d73195c57e9f33d9d2150a4861141 
   src/java/test/org/apache/zookeeper/test/ClientBase.java 
 a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb 
   src/java/test/org/apache/zookeeper/test/ClientHammerTest.java 
 b807dbb0f4350b29190b5d5862c418de84a168c5 
   src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 
 563c77c41c86c692edfd95ea48d397bc25154d26 
   src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java 
 ab84146f58e8f97ef24517703c30ef6015a71c84 
   src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 
 0579858659cec892aee3fa4362d0c55d175d87a7 
   src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java 
 bf1dcef7fbca91fee6128096e8413013fa11e0e0 
   

Re: Time for a 3.5.1-alpha release?

[Flavio Junqueira]

I'd like to see the SSL work in for the next release.

-Flavio

 On 05 Feb 2015, at 19:34, Raúl Gutiérrez Segalés r...@itevenworks.net wrote:
 
 +1
 
 It would be nice, but they are not blockers, to get these in:
 
 https://issues.apache.org/jira/browse/ZOOKEEPER-1998
 https://issues.apache.org/jira/browse/ZOOKEEPER-2051
 https://issues.apache.org/jira/browse/ZOOKEEPER-2098
 
 thanks Patrick!
 
 
 -rgs
 
 
 On 5 February 2015 at 11:22, Michi Mutsuzaki mi...@cs.stanford.edu wrote:
 
 +1 I can check in ZOOKEEPER-1366 tonight.
 
 On Thu, Feb 5, 2015 at 10:57 AM, Rakesh Radhakrishnan
 rakeshr.apa...@gmail.com wrote:
 +1 for 3.5.1-alpha release
 
 I think its good to include the following jira issues:
 
ZOOKEEPER-1366 (so far we got two +1)
ZOOKEEPER-1907 (its not blocking, good to have imprv)
 
 Best Regards,
 Rakesh
 
 On Thu, Feb 5, 2015 at 11:27 PM, Patrick Hunt ph...@apache.org wrote:
 
 Hi folks. 3.5.0-alpha has been out for a bit now, we've gotten some
 good feedback and a number of jira issues have been resolved. What do
 you think about putting out an updated 3.5.1-alpha release with the
 latest changes? Anything blocking us or that you feel important to
 include?
 
 Regards,
 
 Patrick
 
 

[jira] [Commented] (ZOOKEEPER-2098) QuorumCnxManager: use BufferedOutputStream for initial msg

[Hongchao Deng (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308043#comment-14308043
 ] 

Hongchao Deng commented on ZOOKEEPER-2098:
--

Hi [~rgs].

I realized there are two flush():
{code}
dout.flush();
buf.flush();
{code}

Is it duplicate?

 QuorumCnxManager: use BufferedOutputStream for initial msg
 --

 Key: ZOOKEEPER-2098
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2098
 Project: ZooKeeper
  Issue Type: Improvement
  Components: quorum, server
Affects Versions: 3.5.0
Reporter: Raul Gutierrez Segales
Assignee: Raul Gutierrez Segales
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2098.patch


 Whilst writing fle-dump (a tool like 
 [zk-dump|https://github.com/twitter/zktraffic/], but to dump 
 FastLeaderElection messages), I noticed that QCM is using DataOutputStream 
 (which doesn't buffer) directly.
 So all calls to write() are written immediately to the network, which means 
 simple messaages like two participants exchanging Votes can take a couple 
 RTTs! This is specially terrible for global clusters (i.e.: x-country RTTs).
 The solution is to use BufferedOutputStream for the initial negotiation 
 between members of the cluster. Note that there are other places were 
 suboptimal (but not entirely unbuffered) writes to the network still exist. 
 I'll get those in separate tickets.
 After using BufferedOutputStream we get only 1 RTT for the initial message, 
 so elections  time for for participants to join a cluster is reduced.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Time for a 3.5.1-alpha release?

[Michi Mutsuzaki]

+1 I can check in ZOOKEEPER-1366 tonight.

On Thu, Feb 5, 2015 at 10:57 AM, Rakesh Radhakrishnan
rakeshr.apa...@gmail.com wrote:
 +1 for 3.5.1-alpha release

 I think its good to include the following jira issues:

 ZOOKEEPER-1366 (so far we got two +1)
 ZOOKEEPER-1907 (its not blocking, good to have imprv)

 Best Regards,
 Rakesh

 On Thu, Feb 5, 2015 at 11:27 PM, Patrick Hunt ph...@apache.org wrote:

 Hi folks. 3.5.0-alpha has been out for a bit now, we've gotten some
 good feedback and a number of jira issues have been resolved. What do
 you think about putting out an updated 3.5.1-alpha release with the
 latest changes? Anything blocking us or that you feel important to
 include?

 Regards,

 Patrick

ZooKeeper-trunk-solaris - Build # 932 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/932/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
Building remotely on solaris1 (Solaris) in workspace 
/export/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris
Updating http://svn.apache.org/repos/asf/zookeeper/trunk at revision 
'2015-02-05T08:30:28.230 +'
At revision 1657492
Updating http://svn.apache.org/repos/asf/hadoop/nightly at revision 
'2015-02-05T08:30:28.230 +'
At revision 1657492
no change for http://svn.apache.org/repos/asf/zookeeper/trunk since the 
previous build
no change for http://svn.apache.org/repos/asf/hadoop/nightly since the previous 
build
No emails were triggered.
[locks-and-latches] Checking to see if we really have the locks
[locks-and-latches] Have all the locks, build can start
[ZooKeeper-trunk-solaris] $ /bin/bash /var/tmp/hudson1544417887677887549.sh
[trunk] $ 
/export/home/hudson/hudson-slave/tools/hudson.tasks.Ant_AntInstallation/ant-1.8.2/bin/ant
 -DBUILD_ARGS=-Dfindbugs.home=${FINDBUGS_HOME} -Dforrest.home=${FORREST_HOME} 
-Djava5.home=${JAVA5_HOME} -DBUILD_TARGETS=hudson-test-trunk 
-DANALYSIS_TARGETS=test -DBUILD_FLAGS=-Dtest.junit.output.format=xml 
-Dtest.output=yes  -Dtest.output=yes -Dtest.junit.output.format=xml clean 
test-core-java
Error: JAVA_HOME is not defined correctly.
  We cannot execute /home/jenkins/tools/java/latest1.7/bin/java
Build step 'Invoke Ant' marked build as failure
[locks-and-latches] Releasing all the locks
[locks-and-latches] All the locks released
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[Tim Crowder (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Crowder updated ZOOKEEPER-1525:
---
Attachment: ZOOKEEPER-1525.patch

New patch. Warnings removed. Testcase and example added.

 Plumb ZooKeeperServer object into auth plugins
 --

 Key: ZOOKEEPER-1525
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525
 Project: ZooKeeper
  Issue Type: Improvement
Affects Versions: 3.5.0
Reporter: Warren Turkal
Assignee: Warren Turkal
 Fix For: 3.5.1

 Attachments: ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, 
 ZOOKEEPER-1525.patch


 I want to plumb the ZooKeeperServer object into the auth plugins so that I 
 can store authentication data in zookeeper itself. With access to the 
 ZooKeeperServer object, I also have access to the ZKDatabase and can look up 
 entries in the local copy of the zookeeper data.
 In order to implement this, I make sure that a ZooKeeperServer instance is 
 passed in to the ProviderRegistry.initialize() method. Then initialize() will 
 try to find a constructor for the AuthenticationProvider that takes a 
 ZooKeeperServer instance. If the constructor is found, it will be used. 
 Otherwise, initialize() will look for a constructor that takes no arguments 
 and use that instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2114) jute generated allocate_* functions are not externally visible

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306883#comment-14306883
 ] 

Hadoop QA commented on ZOOKEEPER-2114:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12696692/zk-makefile-patch
  against trunk revision 1656167.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2510//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2510//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2510//console

This message is automatically generated.

 jute generated allocate_* functions are not externally visible
 --

 Key: ZOOKEEPER-2114
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2114
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.5.0
Reporter: Tim Crowder
 Attachments: zk-makefile-patch


 Some jute generated functions (e.g. allocate_ACL_vector) that should be 
 publicly exported are given local (vs global) linkage. This is due to an 
 incomplete regex for EXPORT_SYMBOLS  in the C Makefile.am.
 Without allocate_ACL_vector it's not possible to set ACL lists from C.
 The regex should include allocate_ :
 EXPORT_SYMBOLS = 
 '(zoo_|zookeeper_|zhandle|Z|format_log_message|log_message|logLevel|deallocate_|allocate_|zerror|is_unrecoverable)'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2114 PreCommit Build #2510

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2114
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2510/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 349196 lines...]
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2510//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2510//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2510//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 79f7bd60e7f03587280dba757654d026a491c56b logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1714:
 exec returned: 2

Total time: 45 minutes 19 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2489
Archived 7 artifacts
Archive block size is 32768
Received 6 blocks and 358402 bytes
Compression is 35.4%
Took 0.89 sec
Recording test results
Description set: ZOOKEEPER-2114
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.test.AsyncHammerTest.testHammer

Error Message:
null

Stack Trace:
junit.framework.AssertionFailedError
at 
org.apache.zookeeper.test.AsyncHammerTest.testHammer(AsyncHammerTest.java:186)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

RE: How to kick off a review

[Hongchao Deng]

I can take a look but I am currently occupied in ZK-2094 and a couple of 
issues. I will take a look later.Please be patient. We review code carefully 
and therefore some comments in code will help.
- Hongchao Deng

 Date: Thu, 5 Feb 2015 15:41:11 -0800
 From: timrc...@yahoo.com.INVALID
 Subject: How to kick off a review
 To: dev@zookeeper.apache.org
 
 Hi All-
 
 I've submitted ZOOKEEPER-2114 (missing symbols from libzookeeper) with a 
 patch,
 and a new patch for ZOOKEEPER-1525 (plumbing ZK server access to auth 
 plugins).
 
 What else should I do to help usher them along?
 
 Thanks!
 
 -timrc
  

[jira] [Commented] (ZOOKEEPER-2074) Incorrect exit codes for ./zkCli.sh cmd arg

[surendra singh lilhore (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308322#comment-14308322
 ] 

surendra singh lilhore commented on ZOOKEEPER-2074:
---

@Rakesh 

Thanks for review

 Incorrect exit codes for ./zkCli.sh cmd arg
 -

 Key: ZOOKEEPER-2074
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2074
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.5.0
Reporter: surendra singh lilhore
Assignee: surendra singh lilhore
Priority: Minor
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2074_1.patch, ZOOKEEPER-2074_2.patch


 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Created /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh create /test test
 Node already exists: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Linux@hghoulaslx406:/ echo $?
 0
 Linux@hghoulaslx406:/ $ZOOKEEPER_HOME/bin/zkCli.sh delete /test
 Node does not exist: /test1
 Linux@hghoulaslx406:/ echo $?
 0
 Here for failed command it should return exit code 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be tolerant of clock adjustments

[Hongchao Deng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/
---

(Updated Feb. 5, 2015, 5:31 p.m.)


Review request for zookeeper.


Repository: zookeeper-git


Description
---

Zookeeper should be tolerant of clock adjustments


Diffs (updated)
-

  CHANGES.txt bc587349866843af3fe43a70cd3c674338495926 
  build.xml bb5ff4f70dc7cf93d42b67b80885c13fd4c4f13c 
  src/docs/src/documentation/content/xdocs/recipes.xml 
f977a543be9b8a7bb9529ebc102b8a04980acac7 
  src/docs/src/documentation/content/xdocs/releasenotes.xml 
41f079450f3f1067c12344daf9a869a3607ce8a6 
  src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 
202051f1f7f517b1e1a3c561c0008449ab3c48a6 
  src/docs/src/documentation/content/xdocs/zookeeperInternals.xml 
4954123387ae69c19d2592208b663388120e445a 
  src/docs/src/documentation/content/xdocs/zookeeperObservers.xml 
99f80250438699c9568d651f16afa4a7fee31b13 
  src/docs/src/documentation/content/xdocs/zookeeperOver.xml 
a2961d334d38e9752be5d7ade6eedb8c9f5fa669 
  src/docs/src/documentation/content/xdocs/zookeeperTutorial.xml 
10b3606c842e1bd9cbcf626bfdf1ccb8c4d1ad49 
  src/java/main/org/apache/zookeeper/ClientCnxn.java 
b4ece07735d13f1114dc79add6d5f306f6916988 
  src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 
5ca0ba77bccfcaa799e42e98f5a5f04d3f0cf0d3 
  src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 
adb27ee843cd7ba310807dd777376a3c244ca30f 
  src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/Login.java 
6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b 
  src/java/main/org/apache/zookeeper/Shell.java 
62169d797a7a103d921634c4676fffea878def51 
  src/java/main/org/apache/zookeeper/ZKUtil.java 
4713a08a934175c2b297f69740e204c7288c078c 
  src/java/main/org/apache/zookeeper/ZooKeeperTestable.java 
775d1a26d881ec77eb403fc3268f14f6be26719f 
  src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 
dbc108019493ce13cc76a0965c4a3b2cf08353d5 
  src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/ConnectionBean.java 
917aacfdcdcd50576029faab65ca98b89cfb2df9 
  src/java/main/org/apache/zookeeper/server/ExpiryQueue.java 
a037bf49235e386cc20ee68633ec162b1db013d1 
  src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 
a97be4a5452006fbd85d355c0dcb16276cbf1c59 
  src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 
41268805fe16244aeea4db3f35f13a6987b30187 
  src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
7a03b4b4f4f7b60fd16eca60423202006ad5833d 
  src/java/main/org/apache/zookeeper/server/RateLogger.java 
fc951cf5147bedbf1786ff1047a1e1a5fd7f5121 
  src/java/main/org/apache/zookeeper/server/Request.java 
ee01dcfa63784a9dd380f91d768e1b3f28b9cce9 
  src/java/main/org/apache/zookeeper/server/ServerStats.java 
c3246293e409d863412144ed76b2a91ca1ac98f2 
  src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 
0c2c042e276c557a86f47d7ab5333e6860e12bd9 
  src/java/main/org/apache/zookeeper/server/WorkerService.java 
c55ff48f92e5e3ae7783ad5be0262a5d9899c521 
  src/java/main/org/apache/zookeeper/server/ZKDatabase.java 
f336049f0afb7b539460223b4903d323e2558aed 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 
30a0ed390bb7473ddb36757da97bc7d5f4281887 
  src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 
6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a 
  src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f 
  src/java/main/org/apache/zookeeper/server/quorum/Follower.java 
6dbb0b22a4e0658a6b04629e6efdf1ac722375e5 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java 
20589045752a7ba4ae9c9090055a4fcbe86a8eda 
  src/java/main/org/apache/zookeeper/server/quorum/Learner.java 
4dd1e947357080f3e055f3e7e2a78c979daa6ea7 
  
src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 
97b48915321aab6ea31bd7db8fe1197165507feb 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de 
  src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 
4092c760f2cc4eda410ac6125e58ec399d1a6ca4 
  src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 
809fa4819eed61aee3fcee1b5641ec85b967d479 
  src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 
9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3 
  src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java 
1eeca4329b8c9c0454888a629a7deba222bc6279 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 
9abe47910f5d73195c57e9f33d9d2150a4861141 
  src/java/test/org/apache/zookeeper/test/ClientBase.java 

Review Request 30677: ZOOKEEPER-1366: Zookeeper should be tolerant of clock adjustments

[Hongchao Deng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30677/
---

Review request for zookeeper.


Repository: zookeeper-git


Description
---

ZOOKEEPER-1366: Zookeeper should be tolerant of clock adjustments


Diffs
-

  src/java/main/org/apache/zookeeper/ClientCnxn.java 
c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc 
  src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 
16cb9120686bf982b4c68a0172600d23b6119042 
  src/java/main/org/apache/zookeeper/Login.java 
6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b 
  src/java/main/org/apache/zookeeper/Shell.java 
62169d797a7a103d921634c4676fffea878def51 
  src/java/main/org/apache/zookeeper/ZKUtil.java 
4713a08a934175c2b297f69740e204c7288c078c 
  src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/ConnectionBean.java 
917aacfdcdcd50576029faab65ca98b89cfb2df9 
  src/java/main/org/apache/zookeeper/server/ExpiryQueue.java 
a037bf49235e386cc20ee68633ec162b1db013d1 
  src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 
a97be4a5452006fbd85d355c0dcb16276cbf1c59 
  src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
7a03b4b4f4f7b60fd16eca60423202006ad5833d 
  src/java/main/org/apache/zookeeper/server/RateLogger.java 
fc951cf5147bedbf1786ff1047a1e1a5fd7f5121 
  src/java/main/org/apache/zookeeper/server/Request.java 
ee01dcfa63784a9dd380f91d768e1b3f28b9cce9 
  src/java/main/org/apache/zookeeper/server/ServerStats.java 
c3246293e409d863412144ed76b2a91ca1ac98f2 
  src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 
0c2c042e276c557a86f47d7ab5333e6860e12bd9 
  src/java/main/org/apache/zookeeper/server/WorkerService.java 
c55ff48f92e5e3ae7783ad5be0262a5d9899c521 
  src/java/main/org/apache/zookeeper/server/ZKDatabase.java 
f336049f0afb7b539460223b4903d323e2558aed 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 
30a0ed390bb7473ddb36757da97bc7d5f4281887 
  src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 
6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a 
  src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f 
  src/java/main/org/apache/zookeeper/server/quorum/Follower.java 
6dbb0b22a4e0658a6b04629e6efdf1ac722375e5 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java 
20589045752a7ba4ae9c9090055a4fcbe86a8eda 
  
src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 
97b48915321aab6ea31bd7db8fe1197165507feb 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de 
  src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 
4092c760f2cc4eda410ac6125e58ec399d1a6ca4 
  src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 
809fa4819eed61aee3fcee1b5641ec85b967d479 
  src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 
9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3 
  src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 
9abe47910f5d73195c57e9f33d9d2150a4861141 
  src/java/test/org/apache/zookeeper/test/ClientBase.java 
a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb 
  src/java/test/org/apache/zookeeper/test/ClientHammerTest.java 
b807dbb0f4350b29190b5d5862c418de84a168c5 
  src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 
563c77c41c86c692edfd95ea48d397bc25154d26 
  src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java 
ab84146f58e8f97ef24517703c30ef6015a71c84 
  src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 
0579858659cec892aee3fa4362d0c55d175d87a7 
  src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java 
bf1dcef7fbca91fee6128096e8413013fa11e0e0 
  src/java/test/org/apache/zookeeper/test/TestHammer.java 
09a678b28c1915d419d586dfc6a523060b1df1aa 
  src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 
5386a7a910686a44cbe33f5ac18674d92b6aad44 

Diff: https://reviews.apache.org/r/30677/diff/


Testing
---


Thanks,

Hongchao Deng

Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be tolerant of clock adjustments

[Hongchao Deng]

 On Feb. 5, 2015, 4:12 p.m., Marshall McMullen wrote:
  src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 321
  https://reviews.apache.org/r/30573/diff/5/?file=849386#file849386line321
 
  Is it worth changing callers of ZooKeeperServer.java's getTime to 
  instead call into the new Time.currentWallTime for increased clarity? Or is 
  that a LOT of refactoring? I confess I didn't look.

I agree with it!


- Hongchao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/#review71222
---


On Feb. 5, 2015, 12:37 a.m., Hongchao Deng wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30573/
 ---
 
 (Updated Feb. 5, 2015, 12:37 a.m.)
 
 
 Review request for zookeeper.
 
 
 Repository: zookeeper-git
 
 
 Description
 ---
 
 Zookeeper should be tolerant of clock adjustments
 
 
 Diffs
 -
 
   src/java/main/org/apache/zookeeper/ClientCnxn.java 
 c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc 
   src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 
 16cb9120686bf982b4c68a0172600d23b6119042 
   src/java/main/org/apache/zookeeper/Login.java 
 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b 
   src/java/main/org/apache/zookeeper/Shell.java 
 62169d797a7a103d921634c4676fffea878def51 
   src/java/main/org/apache/zookeeper/ZKUtil.java 
 4713a08a934175c2b297f69740e204c7288c078c 
   src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION 
   src/java/main/org/apache/zookeeper/server/ConnectionBean.java 
 917aacfdcdcd50576029faab65ca98b89cfb2df9 
   src/java/main/org/apache/zookeeper/server/ExpiryQueue.java 
 a037bf49235e386cc20ee68633ec162b1db013d1 
   src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 
 a97be4a5452006fbd85d355c0dcb16276cbf1c59 
   src/java/main/org/apache/zookeeper/server/RateLogger.java 
 fc951cf5147bedbf1786ff1047a1e1a5fd7f5121 
   src/java/main/org/apache/zookeeper/server/Request.java 
 ee01dcfa63784a9dd380f91d768e1b3f28b9cce9 
   src/java/main/org/apache/zookeeper/server/ServerStats.java 
 c3246293e409d863412144ed76b2a91ca1ac98f2 
   src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 
 0c2c042e276c557a86f47d7ab5333e6860e12bd9 
   src/java/main/org/apache/zookeeper/server/WorkerService.java 
 c55ff48f92e5e3ae7783ad5be0262a5d9899c521 
   src/java/main/org/apache/zookeeper/server/ZKDatabase.java 
 f336049f0afb7b539460223b4903d323e2558aed 
   src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 
 30a0ed390bb7473ddb36757da97bc7d5f4281887 
   
 src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 
 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a 
   src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
 dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f 
   src/java/main/org/apache/zookeeper/server/quorum/Follower.java 
 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5 
   src/java/main/org/apache/zookeeper/server/quorum/Leader.java 
 20589045752a7ba4ae9c9090055a4fcbe86a8eda 
   
 src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java
  97b48915321aab6ea31bd7db8fe1197165507feb 
   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de 
   src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 
 4092c760f2cc4eda410ac6125e58ec399d1a6ca4 
   src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 
 809fa4819eed61aee3fcee1b5641ec85b967d479 
   src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 
 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3 
   src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION 
   src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 
 9abe47910f5d73195c57e9f33d9d2150a4861141 
   src/java/test/org/apache/zookeeper/test/ClientBase.java 
 a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb 
   src/java/test/org/apache/zookeeper/test/ClientHammerTest.java 
 b807dbb0f4350b29190b5d5862c418de84a168c5 
   src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 
 563c77c41c86c692edfd95ea48d397bc25154d26 
   src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java 
 ab84146f58e8f97ef24517703c30ef6015a71c84 
   src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 
 0579858659cec892aee3fa4362d0c55d175d87a7 
   src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java 
 bf1dcef7fbca91fee6128096e8413013fa11e0e0 
   src/java/test/org/apache/zookeeper/test/TestHammer.java 
 09a678b28c1915d419d586dfc6a523060b1df1aa 
   src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 
 5386a7a910686a44cbe33f5ac18674d92b6aad44 
 
 Diff: https://reviews.apache.org/r/30573/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Hongchao Deng
 

[jira] [Updated] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

[Hongchao Deng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hongchao Deng updated ZOOKEEPER-1366:
-
Attachment: ZOOKEEPER-1366.patch

 Zookeeper should be tolerant of clock adjustments
 -

 Key: ZOOKEEPER-1366
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Dunning
Assignee: Hongchao Deng
Priority: Critical
 Fix For: 3.5.1

 Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 zookeeper-3.4.5-ZK1366-SC01.patch


 If you want to wreak havoc on a ZK based system just do [date -s +1hour] 
 and watch the mayhem as all sessions expire at once.
 This shouldn't happen.  Zookeeper could easily know handle elapsed times as 
 elapsed times rather than as differences between absolute times.  The 
 absolute times are subject to adjustment when the clock is set while a timer 
 is not subject to this problem.  In Java, System.currentTimeMillis() gives 
 you absolute time while System.nanoTime() gives you time based on a timer 
 from an arbitrary epoch.
 I have done this and have been running tests now for some tens of minutes 
 with no failures.  I will set up a test machine to redo the build again on 
 Ubuntu and post a patch here for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2115) Adding additional checks in zkServer-initialize.sh

[Manikandan Narayanaswamy (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308368#comment-14308368
 ] 

Manikandan Narayanaswamy commented on ZOOKEEPER-2115:
-

Exiting with code 1, if attempt to create either of dataDir or dataLogDir fails.

 Adding additional checks in zkServer-initialize.sh
 --

 Key: ZOOKEEPER-2115
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2115
 Project: ZooKeeper
  Issue Type: Bug
  Components: scripts
Affects Versions: 3.5.0
Reporter: Manikandan Narayanaswamy
Priority: Trivial
 Fix For: 3.6.0

 Attachments: ZOOKEEPER-2115.patch


 while testing single user mode that the initialize command succeeds even 
 though it didn't in case of permission errors on the data directory:
 {code}
 
 + exec /usr/lib/zookeeper/bin/zkServer-initialize.sh --myid=1
 mkdir: cannot create directory `/var/lib/zookeeper/version-2': Permission 
 denied
 mkdir: cannot create directory `/var/lib/zookeeper/version-2': Permission 
 denied
 /usr/lib/zookeeper/bin/zkServer-initialize.sh: line 112: 
 /var/lib/zookeeper/myid: Permission denied
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty

[Hongchao Deng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hongchao Deng updated ZOOKEEPER-2094:
-
Attachment: ZOOKEEPER-2094.patch

Made some changes on naming and whitespaces. Uploaded a new patch ( with test 
jks included) to test Jenkins.

 SSL feature on Netty
 

 Key: ZOOKEEPER-2094
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: server
Affects Versions: 3.4.6, 3.5.0
Reporter: Ian Dimayuga
Assignee: Ian Dimayuga
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, 
 testTrustStore.jks, testUntrustedKeyStore.jks


 Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider 
 to perform authentication.
 Review board: https://reviews.apache.org/r/30576/diff/#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 30576: ZOOKEEPER-2094: SSL on Netty

[Hongchao Deng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30576/
---

(Updated Feb. 6, 2015, 1:27 a.m.)


Review request for zookeeper.


Repository: zookeeper-git


Description
---

SSL on Netty


Diffs (updated)
-

  build.xml e4c8e0374b25a5bcab7cfe77543378fdb8f98b06 
  src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 
914a24471b0a27f7cf650c3ed2eef1077178853f 
  src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 
223cf8e5a856aefba6f5c106d3f4861d3de8f1e1 
  src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java 
87e7834bc91c52d4a2d100dbcc98d41a1b98b849 
  src/java/main/org/apache/zookeeper/ZooKeeper.java 
dd13cc9ba5096312b06999a03ae0057cd3677623 
  src/java/main/org/apache/zookeeper/ZooKeeperMain.java 
496e88748cf6aa291c8b71583a28fdb55fdf7761 
  src/java/main/org/apache/zookeeper/auth/X509Auth.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java 
e41465ab93a3a59dbced8294e83b1651ad0dfe69 
  src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java 
e02753f4fb926a8cc6c7a7c10af42f949c1e210c 
  src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 
acabb33f6c7a000706763ccba94cbaf5aaaca08e 
  src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java 
b4bdc82f8b52f736c6ee3d67bb793a3616c1b436 
  src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 
09a794844978456fc3580adc22b6064e2a12cf77 
  src/java/main/org/apache/zookeeper/server/ServerCnxn.java 
a47d85662970cc0c219a46b226737a8689f8fe96 
  src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 
14037722c569d560acef56de0b5a7ae13464128c 
  src/java/main/org/apache/zookeeper/server/ServerConfig.java 
f2b8463e871739319bdf40be1f014d5ad0af5602 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 
30a0ed390bb7473ddb36757da97bc7d5f4281887 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java 
0eb5c7f979199f2f7dcb9e5cfa011a9b20113713 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 
b756d349abeb1fc69534100c3633db4c1c18e031 
  src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java 
406015f84a51e6afcfe704b881f8494bdd687a25 
  
src/java/main/org/apache/zookeeper/server/auth/X509AuthenticationProvider.java 
PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java 
20589045752a7ba4ae9c9090055a4fcbe86a8eda 
  src/java/main/org/apache/zookeeper/server/quorum/Learner.java 
87f4c0627141c2cfee0533aca7ba2e7ff91433e3 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 
badc8df1f05dea4be337bc8312d7ac22f6c77dc3 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 
d17c58d59e0131a78adde1becb5c23ce8c7a16a7 
  src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 
2aab6d09f9bd980ed76f886fb8168aae2ac8f99f 
  src/java/test/data/auth/test.cert PRE-CREATION 
  src/java/test/data/auth/testKeyStore.jks PRE-CREATION 
  src/java/test/data/auth/testTrustStore.jks PRE-CREATION 
  src/java/test/data/auth/testUntrustedKeyStore.jks PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/TestServerCnxn.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 
6ce058e48d17410d89d8348ee659dd7752bfd578 
  src/java/test/org/apache/zookeeper/test/ClientBase.java 
a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb 
  src/java/test/org/apache/zookeeper/test/ReconfigTest.java 
8b238ee7463508122010208ebc3e786caa2cf1b1 
  src/java/test/org/apache/zookeeper/test/SSLAuthTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/30576/diff/


Testing
---


Thanks,

Hongchao Deng

Failed: ZOOKEEPER-2115 PreCommit Build #2514

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2115
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2514/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 109 lines...]
 [exec] Skipping patch.
 [exec] 1 out of 1 hunk ignored
 [exec] PATCH APPLICATION FAILED
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12696923/ZOOKEEPER-2115.patch
 [exec]   against trunk revision 1656167.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2514//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 0e01067f03b6a5c858934352e9166d10010fc803 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1714:
 exec returned: 1

Total time: 39 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2489
Archived 1 artifacts
Archive block size is 32768
Received 0 blocks and 60255 bytes
Compression is 0.0%
Took 1 sec
Recording test results
Description set: ZOOKEEPER-2115
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308418#comment-14308418
 ] 

Hadoop QA commented on ZOOKEEPER-2094:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12696929/ZOOKEEPER-2094.patch
  against trunk revision 1656167.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 30 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 4 new Findbugs (version 2.0.3) 
warnings.

-1 release audit.  The applied patch generated 3 release audit warnings 
(more than the trunk's current 0 warnings).

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2515//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2515//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2515//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2515//console

This message is automatically generated.

 SSL feature on Netty
 

 Key: ZOOKEEPER-2094
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: server
Affects Versions: 3.4.6, 3.5.0
Reporter: Ian Dimayuga
Assignee: Ian Dimayuga
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, 
 testKeyStore.jks, testTrustStore.jks, testUntrustedKeyStore.jks


 Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider 
 to perform authentication.
 Review board: https://reviews.apache.org/r/30576/diff/#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2115) Adding additional checks in zkServer-initialize.sh

[Manikandan Narayanaswamy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manikandan Narayanaswamy updated ZOOKEEPER-2115:

Attachment: ZOOKEEPER-2115.patch

 Adding additional checks in zkServer-initialize.sh
 --

 Key: ZOOKEEPER-2115
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2115
 Project: ZooKeeper
  Issue Type: Bug
  Components: scripts
Affects Versions: 3.5.0
Reporter: Manikandan Narayanaswamy
Priority: Trivial
 Fix For: 3.6.0

 Attachments: ZOOKEEPER-2115.patch


 while testing single user mode that the initialize command succeeds even 
 though it didn't in case of permission errors on the data directory:
 {code}
 
 + exec /usr/lib/zookeeper/bin/zkServer-initialize.sh --myid=1
 mkdir: cannot create directory `/var/lib/zookeeper/version-2': Permission 
 denied
 mkdir: cannot create directory `/var/lib/zookeeper/version-2': Permission 
 denied
 /usr/lib/zookeeper/bin/zkServer-initialize.sh: line 112: 
 /var/lib/zookeeper/myid: Permission denied
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 30576: ZOOKEEPER-2094: SSL on Netty

[Hongchao Deng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30576/
---

(Updated Feb. 6, 2015, 1:17 a.m.)


Review request for zookeeper.


Repository: zookeeper-git


Description
---

SSL on Netty


Diffs (updated)
-

  build.xml e4c8e0374b25a5bcab7cfe77543378fdb8f98b06 
  src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 
914a24471b0a27f7cf650c3ed2eef1077178853f 
  src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 
223cf8e5a856aefba6f5c106d3f4861d3de8f1e1 
  src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java 
87e7834bc91c52d4a2d100dbcc98d41a1b98b849 
  src/java/main/org/apache/zookeeper/ZooKeeper.java 
dd13cc9ba5096312b06999a03ae0057cd3677623 
  src/java/main/org/apache/zookeeper/ZooKeeperMain.java 
496e88748cf6aa291c8b71583a28fdb55fdf7761 
  src/java/main/org/apache/zookeeper/auth/X509Auth.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java 
e41465ab93a3a59dbced8294e83b1651ad0dfe69 
  src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java 
e02753f4fb926a8cc6c7a7c10af42f949c1e210c 
  src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 
acabb33f6c7a000706763ccba94cbaf5aaaca08e 
  src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java 
b4bdc82f8b52f736c6ee3d67bb793a3616c1b436 
  src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 
09a794844978456fc3580adc22b6064e2a12cf77 
  src/java/main/org/apache/zookeeper/server/ServerCnxn.java 
a47d85662970cc0c219a46b226737a8689f8fe96 
  src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 
14037722c569d560acef56de0b5a7ae13464128c 
  src/java/main/org/apache/zookeeper/server/ServerConfig.java 
f2b8463e871739319bdf40be1f014d5ad0af5602 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 
30a0ed390bb7473ddb36757da97bc7d5f4281887 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java 
0eb5c7f979199f2f7dcb9e5cfa011a9b20113713 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 
b756d349abeb1fc69534100c3633db4c1c18e031 
  src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java 
406015f84a51e6afcfe704b881f8494bdd687a25 
  
src/java/main/org/apache/zookeeper/server/auth/X509AuthenticationProvider.java 
PRE-CREATION 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java 
20589045752a7ba4ae9c9090055a4fcbe86a8eda 
  src/java/main/org/apache/zookeeper/server/quorum/Learner.java 
87f4c0627141c2cfee0533aca7ba2e7ff91433e3 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 
badc8df1f05dea4be337bc8312d7ac22f6c77dc3 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 
d17c58d59e0131a78adde1becb5c23ce8c7a16a7 
  src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 
2aab6d09f9bd980ed76f886fb8168aae2ac8f99f 
  src/java/test/data/auth/test.cert PRE-CREATION 
  src/java/test/data/auth/testKeyStore.jks PRE-CREATION 
  src/java/test/data/auth/testTrustStore.jks PRE-CREATION 
  src/java/test/data/auth/testUntrustedKeyStore.jks PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/TestServerCnxn.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 
6ce058e48d17410d89d8348ee659dd7752bfd578 
  src/java/test/org/apache/zookeeper/test/ClientBase.java 
a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb 
  src/java/test/org/apache/zookeeper/test/ReconfigTest.java 
8b238ee7463508122010208ebc3e786caa2cf1b1 
  src/java/test/org/apache/zookeeper/test/SSLAuthTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/30576/diff/


Testing
---


Thanks,

Hongchao Deng

[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty

[Hongchao Deng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hongchao Deng updated ZOOKEEPER-2094:
-
Attachment: ZOOKEEPER-2094.patch

 SSL feature on Netty
 

 Key: ZOOKEEPER-2094
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: server
Affects Versions: 3.4.6, 3.5.0
Reporter: Ian Dimayuga
Assignee: Ian Dimayuga
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, 
 testKeyStore.jks, testTrustStore.jks, testUntrustedKeyStore.jks


 Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider 
 to perform authentication.
 Review board: https://reviews.apache.org/r/30576/diff/#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2094 PreCommit Build #2515

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2515/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 635 lines...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 30 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to introduce 4 new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] -1 release audit.  The applied patch generated 3 release audit 
warnings (more than the trunk's current 0 warnings).
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2515//testReport/
 [exec] Release audit warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2515//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2515//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2515//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 45a9be7537f51e5e5ea8d9d821555eadf7904275 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1714:
 exec returned: 3

Total time: 2 minutes 27 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2489
Archived 8 artifacts
Archive block size is 32768
Received 3 blocks and 489813 bytes
Compression is 16.7%
Took 0.64 sec
Recording test results
Description set: ZOOKEEPER-2094
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2115) Adding additional checks in zkServer-initialize.sh

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308416#comment-14308416
 ] 

Hadoop QA commented on ZOOKEEPER-2115:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12696923/ZOOKEEPER-2115.patch
  against trunk revision 1656167.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2514//console

This message is automatically generated.

 Adding additional checks in zkServer-initialize.sh
 --

 Key: ZOOKEEPER-2115
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2115
 Project: ZooKeeper
  Issue Type: Bug
  Components: scripts
Affects Versions: 3.5.0
Reporter: Manikandan Narayanaswamy
Priority: Trivial
 Fix For: 3.6.0

 Attachments: ZOOKEEPER-2115.patch


 while testing single user mode that the initialize command succeeds even 
 though it didn't in case of permission errors on the data directory:
 {code}
 
 + exec /usr/lib/zookeeper/bin/zkServer-initialize.sh --myid=1
 mkdir: cannot create directory `/var/lib/zookeeper/version-2': Permission 
 denied
 mkdir: cannot create directory `/var/lib/zookeeper/version-2': Permission 
 denied
 /usr/lib/zookeeper/bin/zkServer-initialize.sh: line 112: 
 /var/lib/zookeeper/myid: Permission denied
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-jdk8 - Build # 284 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/284/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 353708 lines...]
[junit] 2015-02-05 11:38:14,127 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2015-02-05 11:38:14,128 [myid:] - INFO  [main:JMXEnv@142] - 
ensureOnly:[]
[junit] 2015-02-05 11:38:14,129 [myid:] - INFO  [main:ClientBase@443] - 
STARTING server
[junit] 2015-02-05 11:38:14,129 [myid:] - INFO  [main:ClientBase@364] - 
CREATING server instance 127.0.0.1:11221
[junit] 2015-02-05 11:38:14,129 [myid:] - INFO  
[main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 32 worker threads, and 64 
kB direct buffers.
[junit] 2015-02-05 11:38:14,129 [myid:] - INFO  
[main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2015-02-05 11:38:14,130 [myid:] - INFO  [main:ClientBase@339] - 
STARTING server instance 127.0.0.1:11221
[junit] 2015-02-05 11:38:14,130 [myid:] - INFO  [main:ZooKeeperServer@781] 
- minSessionTimeout set to 6000
[junit] 2015-02-05 11:38:14,130 [myid:] - INFO  [main:ZooKeeperServer@790] 
- maxSessionTimeout set to 6
[junit] 2015-02-05 11:38:14,130 [myid:] - INFO  [main:ZooKeeperServer@152] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk8/trunk/build/test/tmp/test1500067733819505820.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk8/trunk/build/test/tmp/test1500067733819505820.junit.dir/version-2
[junit] 2015-02-05 11:38:14,131 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk8/trunk/build/test/tmp/test1500067733819505820.junit.dir/version-2/snapshot.b
[junit] 2015-02-05 11:38:14,134 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-jdk8/trunk/build/test/tmp/test1500067733819505820.junit.dir/version-2/snapshot.b
[junit] 2015-02-05 11:38:14,135 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2015-02-05 11:38:14,136 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:34236
[junit] 2015-02-05 11:38:14,137 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from 
/127.0.0.1:34236
[junit] 2015-02-05 11:38:14,137 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output
[junit] 2015-02-05 11:38:14,137 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client 
/127.0.0.1:34236 (no session established for client)
[junit] 2015-02-05 11:38:14,138 [myid:] - INFO  [main:JMXEnv@224] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2015-02-05 11:38:14,140 [myid:] - INFO  [main:JMXEnv@241] - 
expect:InMemoryDataTree
[junit] 2015-02-05 11:38:14,140 [myid:] - INFO  [main:JMXEnv@245] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2015-02-05 11:38:14,141 [myid:] - INFO  [main:JMXEnv@241] - 
expect:StandaloneServer_port
[junit] 2015-02-05 11:38:14,141 [myid:] - INFO  [main:JMXEnv@245] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2015-02-05 11:38:14,141 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 62025
[junit] 2015-02-05 11:38:14,142 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 24
[junit] 2015-02-05 11:38:14,142 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota
[junit] 2015-02-05 11:38:14,142 [myid:] - INFO  [main:ClientBase@520] - 
tearDown starting
[junit] 2015-02-05 11:38:14,208 [myid:] - INFO  [main:ZooKeeper@968] - 
Session: 0x14b59888417 closed
[junit] 2015-02-05 11:38:14,208 [myid:] - INFO  [main:ClientBase@490] - 
STOPPING server
[junit] 2015-02-05 11:38:14,208 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@530] - EventThread shut down
[junit] 2015-02-05 11:38:14,209 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2015-02-05 11:38:14,209 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2015-02-05 11:38:14,209 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- 

[jira] [Commented] (ZOOKEEPER-1525) Plumb ZooKeeperServer object into auth plugins

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306904#comment-14306904
 ] 

Hadoop QA commented on ZOOKEEPER-1525:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12696698/ZOOKEEPER-1525.patch
  against trunk revision 1656167.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 2 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 1 new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2511//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2511//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2511//console

This message is automatically generated.

 Plumb ZooKeeperServer object into auth plugins
 --

 Key: ZOOKEEPER-1525
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1525
 Project: ZooKeeper
  Issue Type: Improvement
Affects Versions: 3.5.0
Reporter: Warren Turkal
Assignee: Warren Turkal
 Fix For: 3.5.1

 Attachments: ZOOKEEPER-1525.patch, ZOOKEEPER-1525.patch, 
 ZOOKEEPER-1525.patch


 I want to plumb the ZooKeeperServer object into the auth plugins so that I 
 can store authentication data in zookeeper itself. With access to the 
 ZooKeeperServer object, I also have access to the ZKDatabase and can look up 
 entries in the local copy of the zookeeper data.
 In order to implement this, I make sure that a ZooKeeperServer instance is 
 passed in to the ProviderRegistry.initialize() method. Then initialize() will 
 try to find a constructor for the AuthenticationProvider that takes a 
 ZooKeeperServer instance. If the constructor is found, it will be used. 
 Otherwise, initialize() will look for a constructor that takes no arguments 
 and use that instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-1525 PreCommit Build #2511

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1525
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2511/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 349268 lines...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 2 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to introduce 1 new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2511//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2511//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2511//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] d7b88ed218cb82b1ba92e36f2ffc1fd161b01387 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1714:
 exec returned: 2

Total time: 44 minutes 56 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2489
Archived 7 artifacts
Archive block size is 32768
Received 4 blocks and 429939 bytes
Compression is 23.4%
Took 0.85 sec
Recording test results
Description set: ZOOKEEPER-1525
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.test.AsyncHammerTest.testHammer

Error Message:
null

Stack Trace:
junit.framework.AssertionFailedError
at 
org.apache.zookeeper.test.AsyncHammerTest.testHammer(AsyncHammerTest.java:186)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

Re: Configuration service for zookeeper

[Flavio Junqueira]

Agreed, and I believe we can do it without a central ensemble.
-Flavio

Configuration service for zookeeper

[Ivan Kelly]

Hey folks,

I've just had an discussion about how zookeeper is harder to configure
than etcd or consul for example.

See: https://coreos.com/docs/cluster-management/setup/cluster-discovery/

As I understand it, they have a central quorum that they use for
recording requests for new node instantiation within a quorum.

I think I discussed the problem this solves on twitter a few months
ago with Flavio, about how to ensure that a node which deletes it's
disk contents can't join a quorum.

It may be a nice GSoC projecet to do something similar for ZK.

-Ivan

[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty

[Hongchao Deng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hongchao Deng updated ZOOKEEPER-2094:
-
Attachment: (was: ZOOKEEPER-2094.patch)

 SSL feature on Netty
 

 Key: ZOOKEEPER-2094
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: server
Affects Versions: 3.4.6, 3.5.0
Reporter: Ian Dimayuga
Assignee: Ian Dimayuga
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, 
 testTrustStore.jks, testUntrustedKeyStore.jks


 Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider 
 to perform authentication.
 Review board: https://reviews.apache.org/r/30576/diff/#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty

[Hongchao Deng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hongchao Deng updated ZOOKEEPER-2094:
-
Attachment: (was: ZOOKEEPER-2094.patch)

 SSL feature on Netty
 

 Key: ZOOKEEPER-2094
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: server
Affects Versions: 3.4.6, 3.5.0
Reporter: Ian Dimayuga
Assignee: Ian Dimayuga
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, 
 testTrustStore.jks, testUntrustedKeyStore.jks


 Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider 
 to perform authentication.
 Review board: https://reviews.apache.org/r/30576/diff/#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2094) SSL feature on Netty

[Hongchao Deng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hongchao Deng updated ZOOKEEPER-2094:
-
Attachment: ZOOKEEPER-2094.patch

 SSL feature on Netty
 

 Key: ZOOKEEPER-2094
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: server
Affects Versions: 3.4.6, 3.5.0
Reporter: Ian Dimayuga
Assignee: Ian Dimayuga
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
 ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, 
 testTrustStore.jks, testUntrustedKeyStore.jks


 Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider 
 to perform authentication.
 Review board: https://reviews.apache.org/r/30576/diff/#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

[Hongchao Deng (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308524#comment-14308524
 ] 

Hongchao Deng commented on ZOOKEEPER-1366:
--

Hi [~michim].

Thanks for your attention to the issue. Patch on RB:
https://reviews.apache.org/r/30677/diff/

You are cordially welcome to review and give feedback.

 Zookeeper should be tolerant of clock adjustments
 -

 Key: ZOOKEEPER-1366
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Dunning
Assignee: Hongchao Deng
Priority: Critical
 Fix For: 3.5.1

 Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 zookeeper-3.4.5-ZK1366-SC01.patch


 If you want to wreak havoc on a ZK based system just do [date -s +1hour] 
 and watch the mayhem as all sessions expire at once.
 This shouldn't happen.  Zookeeper could easily know handle elapsed times as 
 elapsed times rather than as differences between absolute times.  The 
 absolute times are subject to adjustment when the clock is set while a timer 
 is not subject to this problem.  In Java, System.currentTimeMillis() gives 
 you absolute time while System.nanoTime() gives you time based on a timer 
 from an arbitrary epoch.
 I have done this and have been running tests now for some tens of minutes 
 with no failures.  I will set up a test machine to redo the build again on 
 Ubuntu and post a patch here for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307691#comment-14307691
 ] 

Rakesh R commented on ZOOKEEPER-1907:
-

Thanks [~hdeng]. Attached patch addressing the comments.

 Improve Thread handling
 ---

 Key: ZOOKEEPER-1907
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1907
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Affects Versions: 3.5.0
Reporter: Rakesh R
Assignee: Rakesh R
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, 
 ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, 
 ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, 
 ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch


 Server has many critical threads running and co-ordinating each other like  
 RequestProcessor chains et. When going through each threads, most of them 
 having the similar structure like:
 {code}
 public void run() {
 try {
   while(running)
// processing logic
   }
 } catch (InterruptedException e) {
 LOG.error(Unexpected interruption, e);
 } catch (Exception e) {
 LOG.error(Unexpected exception, e);
 }
 LOG.info(...exited loop!);
 }
 {code}
 From the design I could see, there could be a chance of silently leaving the 
 thread by swallowing the exception. If this happens in the production, the 
 server would get hanged forever and would not be able to deliver its role. 
 Now its hard for the management tool to detect this.
 The idea of this JIRA is to discuss and imprv.
 Reference: [Community discussion 
 thread|http://mail-archives.apache.org/mod_mbox/zookeeper-user/201403.mbox/%3cc2496325850aa74c92aaf83aa9662d26458a1...@szxeml561-mbx.china.huawei.com%3E]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-1366 PreCommit Build #2512

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2512/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 345166 lines...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 46 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2512//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2512//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2512//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 4ad1e057b5c4d87752475317e2ba1cce004495db logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1714:
 exec returned: 1

Total time: 45 minutes 31 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2489
Archived 7 artifacts
Archive block size is 32768
Received 4 blocks and 424531 bytes
Compression is 23.6%
Took 1 sec
Recording test results
Description set: ZOOKEEPER-1366
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.test.AsyncHammerTest.testHammer

Error Message:
null

Stack Trace:
junit.framework.AssertionFailedError
at 
org.apache.zookeeper.test.AsyncHammerTest.testHammer(AsyncHammerTest.java:186)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

[Rakesh R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
---

(Updated Feb. 5, 2015, 6:32 p.m.)


Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille 
Fournier.


Bugs: ZOOKEEPER-1907
https://issues.apache.org/jira/browse/ZOOKEEPER-1907


Repository: zookeeper


Description
---

Improve the thread handling mechanism by detecting if any of the critical 
thread dies.
Here the idea is to periodically checking the status of all the critical 
threads in ZK server using DeathWatcherThread.


Diffs (updated)
-

  ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
  ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1657623 
  ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1657623 
  ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1657623 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 
1657623 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1657623 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java 
PRE-CREATION 
  ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
1657623 
  
./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
 1657623 
  
./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 
1657623 
  ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
1657623 
  ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 
1657623 
  ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
1657623 
  
./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 
1657623 
  ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 
1657623 
  
./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
 1657623 
  
./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 
1657623 
  
./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
 1657623 
  
./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
 1657623 
  
./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 
1657623 
  
./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
 1657623 
  ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
1657623 
  ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1657623 
  ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 1657623 
  
./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
 1657623 
  ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 
1657623 
  ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1657623 
  ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 
1657623 

Diff: https://reviews.apache.org/r/20071/diff/


Testing
---

yet to be inlcuded


Thanks,

Rakesh R

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

[Rakesh R]

 On Feb. 3, 2015, 4:52 p.m., Hongchao Deng wrote:
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java, 
  line 47
  https://reviews.apache.org/r/20071/diff/4/?file=845240#file845240line47
 
  Do you think handleException() and notifyStopping are duplicate? Can we 
  keep just one and remove the other?

removed notifyStopping and reused handleException()


- Rakesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review70766
---


On Feb. 3, 2015, 8:35 a.m., Rakesh R wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20071/
 ---
 
 (Updated Feb. 3, 2015, 8:35 a.m.)
 
 
 Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille 
 Fournier.
 
 
 Bugs: ZOOKEEPER-1907
 https://issues.apache.org/jira/browse/ZOOKEEPER-1907
 
 
 Repository: zookeeper
 
 
 Description
 ---
 
 Improve the thread handling mechanism by detecting if any of the critical 
 thread dies.
 Here the idea is to periodically checking the status of all the critical 
 threads in ZK server using DeathWatcherThread.
 
 
 Diffs
 -
 
   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
 1656643 
   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1656643 
   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 
 1656643 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 
 1656643 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1656643 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java 
 PRE-CREATION 
   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
 1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
  1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
  1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
 1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 
 1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
 1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
  1656643 
   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 
 1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
  1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
  1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
  1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
  1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
  1656643 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
  1656643 
   ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
 1656643 
   ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1656643 
   ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 
 1656643 
   
 ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
  1656643 
   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 
 1656643 
   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1656643 
   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 
 1656643 
 
 Diff: https://reviews.apache.org/r/20071/diff/
 
 
 Testing
 ---
 
 yet to be inlcuded
 
 
 Thanks,
 
 Rakesh R
 

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307726#comment-14307726
 ] 

Hadoop QA commented on ZOOKEEPER-1907:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12696797/ZOOKEEPER-1907.patch
  against trunk revision 1656167.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 21 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2513//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2513//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2513//console

This message is automatically generated.

 Improve Thread handling
 ---

 Key: ZOOKEEPER-1907
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1907
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Affects Versions: 3.5.0
Reporter: Rakesh R
Assignee: Rakesh R
 Fix For: 3.5.1, 3.6.0

 Attachments: ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, 
 ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, 
 ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, 
 ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch


 Server has many critical threads running and co-ordinating each other like  
 RequestProcessor chains et. When going through each threads, most of them 
 having the similar structure like:
 {code}
 public void run() {
 try {
   while(running)
// processing logic
   }
 } catch (InterruptedException e) {
 LOG.error(Unexpected interruption, e);
 } catch (Exception e) {
 LOG.error(Unexpected exception, e);
 }
 LOG.info(...exited loop!);
 }
 {code}
 From the design I could see, there could be a chance of silently leaving the 
 thread by swallowing the exception. If this happens in the production, the 
 server would get hanged forever and would not be able to deliver its role. 
 Now its hard for the management tool to detect this.
 The idea of this JIRA is to discuss and imprv.
 Reference: [Community discussion 
 thread|http://mail-archives.apache.org/mod_mbox/zookeeper-user/201403.mbox/%3cc2496325850aa74c92aaf83aa9662d26458a1...@szxeml561-mbx.china.huawei.com%3E]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-1907 PreCommit Build #2513

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1907
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2513/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 349473 lines...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 21 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2513//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2513//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2513//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 936b740759511b7cf9c50f7f18bcc647122f704d logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1714:
 exec returned: 1

Total time: 46 minutes 38 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2489
Archived 7 artifacts
Archive block size is 32768
Received 4 blocks and 425510 bytes
Compression is 23.5%
Took 0.94 sec
Recording test results
Description set: ZOOKEEPER-1907
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
1 tests failed.
REGRESSION:  
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig

Error Message:
waiting for server 3 being up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server 3 being up
at 
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig(ReconfigRecoveryTest.java:217)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

[Hongchao Deng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review71262
---



./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
https://reviews.apache.org/r/20071/#comment116928

Why interrupt() here?
Add comments please.



./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
https://reviews.apache.org/r/20071/#comment116929

Why interrupt()?



./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java
https://reviews.apache.org/r/20071/#comment116933

thName - threadName



./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java
https://reviews.apache.org/r/20071/#comment116931

The logging is duplicate to that in notifyStopping().

I think we should remove the one in notifyStopping() because we might want 
to print exception stack.



./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java
https://reviews.apache.org/r/20071/#comment116932

this.getName() - threadName



./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
https://reviews.apache.org/r/20071/#comment116934

Why synchronized here not startup() method? Add some comments?



./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
https://reviews.apache.org/r/20071/#comment116935

Same. Why synchronized here? Some comments will help prevent people in the 
future move it.



./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
https://reviews.apache.org/r/20071/#comment116936

Why interrupt?



./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
https://reviews.apache.org/r/20071/#comment116938

Isn't running set to false in super.shutdown()?



./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
https://reviews.apache.org/r/20071/#comment116939

Same.. it's always false.


- Hongchao Deng


On Feb. 5, 2015, 6:32 p.m., Rakesh R wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20071/
 ---
 
 (Updated Feb. 5, 2015, 6:32 p.m.)
 
 
 Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille 
 Fournier.
 
 
 Bugs: ZOOKEEPER-1907
 https://issues.apache.org/jira/browse/ZOOKEEPER-1907
 
 
 Repository: zookeeper
 
 
 Description
 ---
 
 Improve the thread handling mechanism by detecting if any of the critical 
 thread dies.
 Here the idea is to periodically checking the status of all the critical 
 threads in ZK server using DeathWatcherThread.
 
 
 Diffs
 -
 
   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
 1657623 
   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1657623 
   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 
 1657623 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 
 1657623 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1657623 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java 
 PRE-CREATION 
   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
  1657623 
   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
  1657623 
   ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
 1657623 
   ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1657623 
   ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 
 1657623 
   
 

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307758#comment-14307758
 ] 

Rakesh R commented on ZOOKEEPER-1366:
-

+1 latest patch looks good to me

 Zookeeper should be tolerant of clock adjustments
 -

 Key: ZOOKEEPER-1366
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Dunning
Assignee: Hongchao Deng
Priority: Critical
 Fix For: 3.5.1

 Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 zookeeper-3.4.5-ZK1366-SC01.patch


 If you want to wreak havoc on a ZK based system just do [date -s +1hour] 
 and watch the mayhem as all sessions expire at once.
 This shouldn't happen.  Zookeeper could easily know handle elapsed times as 
 elapsed times rather than as differences between absolute times.  The 
 absolute times are subject to adjustment when the clock is set while a timer 
 is not subject to this problem.  In Java, System.currentTimeMillis() gives 
 you absolute time while System.nanoTime() gives you time based on a timer 
 from an arbitrary epoch.
 I have done this and have been running tests now for some tens of minutes 
 with no failures.  I will set up a test machine to redo the build again on 
 Ubuntu and post a patch here for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

[Hongchao Deng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review71269
---



./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
https://reviews.apache.org/r/20071/#comment116943

And we don't need listener now... Seems like we need to refactor a lot..


- Hongchao Deng


On Feb. 5, 2015, 6:32 p.m., Rakesh R wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20071/
 ---
 
 (Updated Feb. 5, 2015, 6:32 p.m.)
 
 
 Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille 
 Fournier.
 
 
 Bugs: ZOOKEEPER-1907
 https://issues.apache.org/jira/browse/ZOOKEEPER-1907
 
 
 Repository: zookeeper
 
 
 Description
 ---
 
 Improve the thread handling mechanism by detecting if any of the critical 
 thread dies.
 Here the idea is to periodically checking the status of all the critical 
 threads in ZK server using DeathWatcherThread.
 
 
 Diffs
 -
 
   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
 1657623 
   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1657623 
   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 
 1657623 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 
 1657623 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1657623 
   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java 
 PRE-CREATION 
   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
  1657623 
   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 
 1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
  1657623 
   
 ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
  1657623 
   ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
 1657623 
   ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1657623 
   ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 
 1657623 
   
 ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
  1657623 
   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 
 1657623 
   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1657623 
   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 
 1657623 
 
 Diff: https://reviews.apache.org/r/20071/diff/
 
 
 Testing
 ---
 
 yet to be inlcuded
 
 
 Thanks,
 
 Rakesh R
 

Re: Time for a 3.5.1-alpha release?

[Rakesh Radhakrishnan]

+1 for 3.5.1-alpha release

I think its good to include the following jira issues:

ZOOKEEPER-1366 (so far we got two +1)
ZOOKEEPER-1907 (its not blocking, good to have imprv)

Best Regards,
Rakesh

On Thu, Feb 5, 2015 at 11:27 PM, Patrick Hunt ph...@apache.org wrote:

 Hi folks. 3.5.0-alpha has been out for a bit now, we've gotten some
 good feedback and a number of jira issues have been resolved. What do
 you think about putting out an updated 3.5.1-alpha release with the
 latest changes? Anything blocking us or that you feel important to
 include?

 Regards,

 Patrick

ZooKeeper-trunk - Build # 2586 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/2586/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 349012 lines...]
[junit] 2015-02-05 11:15:49,966 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/tmp/test5728578679007391953.junit.dir/version-2/snapshot.b
[junit] 2015-02-05 11:15:49,968 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2015-02-05 11:15:49,969 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:37210
[junit] 2015-02-05 11:15:49,971 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from 
/127.0.0.1:37210
[junit] 2015-02-05 11:15:49,971 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output
[junit] 2015-02-05 11:15:49,971 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client 
/127.0.0.1:37210 (no session established for client)
[junit] 2015-02-05 11:15:49,972 [myid:] - INFO  [main:JMXEnv@224] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2015-02-05 11:15:49,974 [myid:] - INFO  [main:JMXEnv@241] - 
expect:InMemoryDataTree
[junit] 2015-02-05 11:15:49,974 [myid:] - INFO  [main:JMXEnv@245] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2015-02-05 11:15:49,974 [myid:] - INFO  [main:JMXEnv@241] - 
expect:StandaloneServer_port
[junit] 2015-02-05 11:15:49,974 [myid:] - INFO  [main:JMXEnv@245] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2015-02-05 11:15:49,975 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@55] - Memory used 85021
[junit] 2015-02-05 11:15:49,975 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@60] - Number of threads 24
[junit] 2015-02-05 11:15:49,975 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@65] - FINISHED TEST METHOD testQuota
[junit] 2015-02-05 11:15:49,976 [myid:] - INFO  [main:ClientBase@520] - 
tearDown starting
[junit] 2015-02-05 11:15:50,036 [myid:] - INFO  [main:ZooKeeper@968] - 
Session: 0x14b59740182 closed
[junit] 2015-02-05 11:15:50,036 [myid:] - INFO  [main:ClientBase@490] - 
STOPPING server
[junit] 2015-02-05 11:15:50,036 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@530] - EventThread shut down
[junit] 2015-02-05 11:15:50,037 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2015-02-05 11:15:50,037 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2015-02-05 11:15:50,037 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2015-02-05 11:15:50,037 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2015-02-05 11:15:50,038 [myid:] - INFO  [main:ZooKeeperServer@443] 
- shutting down
[junit] 2015-02-05 11:15:50,038 [myid:] - INFO  
[main:SessionTrackerImpl@231] - Shutting down
[junit] 2015-02-05 11:15:50,038 [myid:] - INFO  
[main:PrepRequestProcessor@971] - Shutting down
[junit] 2015-02-05 11:15:50,038 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2015-02-05 11:15:50,038 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2015-02-05 11:15:50,039 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2015-02-05 11:15:50,039 [myid:] - INFO  
[main:FinalRequestProcessor@476] - shutdown of request processor complete
[junit] 2015-02-05 11:15:50,040 [myid:] - INFO  [main:MBeanRegistry@119] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree]
[junit] 2015-02-05 11:15:50,040 [myid:] - INFO  [main:MBeanRegistry@119] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11221]
[junit] 2015-02-05 11:15:50,040 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2015-02-05 11:15:50,041 [myid:] - INFO  [main:JMXEnv@142] - 
ensureOnly:[]
[junit] 2015-02-05 11:15:50,045 [myid:] - INFO  [main:ClientBase@545] - 
fdcount after test is: 46 at start it was 34
[junit] 2015-02-05 11:15:50,045 [myid:] - INFO  [main:ClientBase@547] - 
sleeping for 20 secs
[junit] 2015-02-05 

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

[Marshall McMullen (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307646#comment-14307646
 ] 

Marshall McMullen commented on ZOOKEEPER-1366:
--

Latest version looks great to me. 

 Zookeeper should be tolerant of clock adjustments
 -

 Key: ZOOKEEPER-1366
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Dunning
Assignee: Hongchao Deng
Priority: Critical
 Fix For: 3.5.1

 Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 zookeeper-3.4.5-ZK1366-SC01.patch


 If you want to wreak havoc on a ZK based system just do [date -s +1hour] 
 and watch the mayhem as all sessions expire at once.
 This shouldn't happen.  Zookeeper could easily know handle elapsed times as 
 elapsed times rather than as differences between absolute times.  The 
 absolute times are subject to adjustment when the clock is set while a timer 
 is not subject to this problem.  In Java, System.currentTimeMillis() gives 
 you absolute time while System.nanoTime() gives you time based on a timer 
 from an arbitrary epoch.
 I have done this and have been running tests now for some tens of minutes 
 with no failures.  I will set up a test machine to redo the build again on 
 Ubuntu and post a patch here for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Time for a 3.5.1-alpha release?

[Patrick Hunt]

Hi folks. 3.5.0-alpha has been out for a bit now, we've gotten some
good feedback and a number of jira issues have been resolved. What do
you think about putting out an updated 3.5.1-alpha release with the
latest changes? Anything blocking us or that you feel important to
include?

Regards,

Patrick

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

[Hongchao Deng (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307674#comment-14307674
 ] 

Hongchao Deng commented on ZOOKEEPER-1366:
--

Hi [~rakeshr].
Can you help take a review too?
https://reviews.apache.org/r/30677/diff/G

 Zookeeper should be tolerant of clock adjustments
 -

 Key: ZOOKEEPER-1366
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Dunning
Assignee: Hongchao Deng
Priority: Critical
 Fix For: 3.5.1

 Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 zookeeper-3.4.5-ZK1366-SC01.patch


 If you want to wreak havoc on a ZK based system just do [date -s +1hour] 
 and watch the mayhem as all sessions expire at once.
 This shouldn't happen.  Zookeeper could easily know handle elapsed times as 
 elapsed times rather than as differences between absolute times.  The 
 absolute times are subject to adjustment when the clock is set while a timer 
 is not subject to this problem.  In Java, System.currentTimeMillis() gives 
 you absolute time while System.nanoTime() gives you time based on a timer 
 from an arbitrary epoch.
 I have done this and have been running tests now for some tens of minutes 
 with no failures.  I will set up a test machine to redo the build again on 
 Ubuntu and post a patch here for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307701#comment-14307701
 ] 

Hadoop QA commented on ZOOKEEPER-1366:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12696794/ZOOKEEPER-1366.patch
  against trunk revision 1656167.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 46 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2512//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2512//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2512//console

This message is automatically generated.

 Zookeeper should be tolerant of clock adjustments
 -

 Key: ZOOKEEPER-1366
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Ted Dunning
Assignee: Hongchao Deng
Priority: Critical
 Fix For: 3.5.1

 Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, 
 zookeeper-3.4.5-ZK1366-SC01.patch


 If you want to wreak havoc on a ZK based system just do [date -s +1hour] 
 and watch the mayhem as all sessions expire at once.
 This shouldn't happen.  Zookeeper could easily know handle elapsed times as 
 elapsed times rather than as differences between absolute times.  The 
 absolute times are subject to adjustment when the clock is set while a timer 
 is not subject to this problem.  In Java, System.currentTimeMillis() gives 
 you absolute time while System.nanoTime() gives you time based on a timer 
 from an arbitrary epoch.
 I have done this and have been running tests now for some tens of minutes 
 with no failures.  I will set up a test machine to redo the build again on 
 Ubuntu and post a patch here for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Time for a 3.5.1-alpha release?

[Raúl Gutiérrez Segalés]

+1

It would be nice, but they are not blockers, to get these in:

https://issues.apache.org/jira/browse/ZOOKEEPER-1998
https://issues.apache.org/jira/browse/ZOOKEEPER-2051
https://issues.apache.org/jira/browse/ZOOKEEPER-2098

thanks Patrick!


-rgs


On 5 February 2015 at 11:22, Michi Mutsuzaki mi...@cs.stanford.edu wrote:

 +1 I can check in ZOOKEEPER-1366 tonight.

 On Thu, Feb 5, 2015 at 10:57 AM, Rakesh Radhakrishnan
 rakeshr.apa...@gmail.com wrote:
  +1 for 3.5.1-alpha release
 
  I think its good to include the following jira issues:
 
  ZOOKEEPER-1366 (so far we got two +1)
  ZOOKEEPER-1907 (its not blocking, good to have imprv)
 
  Best Regards,
  Rakesh
 
  On Thu, Feb 5, 2015 at 11:27 PM, Patrick Hunt ph...@apache.org wrote:
 
  Hi folks. 3.5.0-alpha has been out for a bit now, we've gotten some
  good feedback and a number of jira issues have been resolved. What do
  you think about putting out an updated 3.5.1-alpha release with the
  latest changes? Anything blocking us or that you feel important to
  include?
 
  Regards,
 
  Patrick
 

Re: Review Request 30576: ZOOKEEPER-2094: SSL on Netty

[Ian Dimayuga]

 On Feb. 4, 2015, 4:02 p.m., fpj wrote:
  src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, line 1107
  https://reviews.apache.org/r/30576/diff/1/?file=846510#file846510line1107
 
  Is there any use case in which we need this? Could you explain?

This is to enable the super scheme the same way the 
DigestAuthenticationProvider does. It's so that an admin can inspect/modify the 
tree even when a client has set very restrictive ACLs.


 On Feb. 4, 2015, 4:02 p.m., fpj wrote:
  src/java/test/org/apache/zookeeper/test/SSLAuthTest.java, line 20
  https://reviews.apache.org/r/30576/diff/1/?file=846539#file846539line20
 
  This isn't working for me, it seems to be looking for 
  src/java/test/data/auth instead of build/test/data.

test.data.dir is set by the ant target junit.run in a sysproperty tag. It 
should be working exactly the same way the InvalidSnapshotTest works. Have you 
downloaded the .jks files from the JIRA?


- Ian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30576/#review70954
---


On Feb. 3, 2015, 9 p.m., Hongchao Deng wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30576/
 ---
 
 (Updated Feb. 3, 2015, 9 p.m.)
 
 
 Review request for zookeeper.
 
 
 Repository: zookeeper-git
 
 
 Description
 ---
 
 SSL on Netty
 
 
 Diffs
 -
 
   build.xml e4c8e0374b25a5bcab7cfe77543378fdb8f98b06 
   src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 
 914a24471b0a27f7cf650c3ed2eef1077178853f 
   src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 
 223cf8e5a856aefba6f5c106d3f4861d3de8f1e1 
   src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java 
 87e7834bc91c52d4a2d100dbcc98d41a1b98b849 
   src/java/main/org/apache/zookeeper/ZooKeeper.java 
 dd13cc9ba5096312b06999a03ae0057cd3677623 
   src/java/main/org/apache/zookeeper/ZooKeeperMain.java 
 496e88748cf6aa291c8b71583a28fdb55fdf7761 
   src/java/main/org/apache/zookeeper/auth/X509Auth.java PRE-CREATION 
   src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java 
 e41465ab93a3a59dbced8294e83b1651ad0dfe69 
   src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java 
 e02753f4fb926a8cc6c7a7c10af42f949c1e210c 
   src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 
 acabb33f6c7a000706763ccba94cbaf5aaaca08e 
   src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java 
 b4bdc82f8b52f736c6ee3d67bb793a3616c1b436 
   src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 
 09a794844978456fc3580adc22b6064e2a12cf77 
   src/java/main/org/apache/zookeeper/server/ServerCnxn.java 
 a47d85662970cc0c219a46b226737a8689f8fe96 
   src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 
 14037722c569d560acef56de0b5a7ae13464128c 
   src/java/main/org/apache/zookeeper/server/ServerConfig.java 
 f2b8463e871739319bdf40be1f014d5ad0af5602 
   src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 
 30a0ed390bb7473ddb36757da97bc7d5f4281887 
   src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java 
 0eb5c7f979199f2f7dcb9e5cfa011a9b20113713 
   src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 
 b756d349abeb1fc69534100c3633db4c1c18e031 
   src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java 
 406015f84a51e6afcfe704b881f8494bdd687a25 
   
 src/java/main/org/apache/zookeeper/server/auth/X509AuthenticationProvider.java
  PRE-CREATION 
   src/java/main/org/apache/zookeeper/server/quorum/Leader.java 
 20589045752a7ba4ae9c9090055a4fcbe86a8eda 
   src/java/main/org/apache/zookeeper/server/quorum/Learner.java 
 87f4c0627141c2cfee0533aca7ba2e7ff91433e3 
   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de 
   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 
 badc8df1f05dea4be337bc8312d7ac22f6c77dc3 
   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 
 d17c58d59e0131a78adde1becb5c23ce8c7a16a7 
   
 src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 
 2aab6d09f9bd980ed76f886fb8168aae2ac8f99f 
   src/java/test/org/apache/zookeeper/server/TestServerCnxn.java PRE-CREATION 
   src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 
 6ce058e48d17410d89d8348ee659dd7752bfd578 
   src/java/test/org/apache/zookeeper/test/ClientBase.java 
 a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb 
   src/java/test/org/apache/zookeeper/test/ReconfigTest.java 
 8b238ee7463508122010208ebc3e786caa2cf1b1 
   src/java/test/org/apache/zookeeper/test/SSLAuthTest.java PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/30576/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Hongchao Deng