[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849207#comment-15849207
]
ASF GitHub Bot commented on ZOOKEEPER-2659:
---
Github user nerdyyatrice commented on the issue:
https://github.com/apache/zookeeper/pull/148
Thanks, the second one worked. I wonder how do I apply this to other pull
requests? I can't seem to find where to get "praste/zookeeper/"
> Use log4j2 as a logging framework as log4j 1.X is now deprecated
>
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
> Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework.
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user nerdyyatrice commented on the issue: https://github.com/apache/zookeeper/pull/148 Thanks, the second one worked. I wonder how do I apply this to other pull requests? I can't seem to find where to get "praste/zookeeper/" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
ZooKeeper-trunk - Build # 3259 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk/3259/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 481174 lines...] [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-02-02 00:19:20,132 [myid:] - INFO [ProcessThread(sid:0 cport:16854)::PrepRequestProcessor@618] - Processed session termination for sessionid: 0x100beda0e59 [junit] 2017-02-02 00:19:20,133 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x100beda0e59 [junit] 2017-02-02 00:19:20,133 [myid:] - INFO [SyncThread:0:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=Connections,name2=127.0.0.1,name3=0x100beda0e59] [junit] 2017-02-02 00:19:20,133 [myid:] - INFO [main:ZooKeeper@1324] - Session: 0x100beda0e59 closed [junit] 2017-02-02 00:19:20,133 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 190144 [junit] 2017-02-02 00:19:20,133 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1643 [junit] 2017-02-02 00:19:20,133 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2017-02-02 00:19:20,134 [myid:] - INFO [main:ClientBase@558] - tearDown starting [junit] 2017-02-02 00:19:20,134 [myid:] - INFO [main:ClientBase@528] - STOPPING server [junit] 2017-02-02 00:19:20,134 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16854 [junit] 2017-02-02 00:19:20,139 [myid:] - INFO [main:ZooKeeperServer@534] - shutting down [junit] 2017-02-02 00:19:20,139 [myid:] - ERROR [main:ZooKeeperServer@506] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-02-02 00:19:20,139 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2017-02-02 00:19:20,140 [myid:] - INFO [main:PrepRequestProcessor@1009] - Shutting down [junit] 2017-02-02 00:19:20,140 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2017-02-02 00:19:20,140 [myid:] - INFO [ProcessThread(sid:0 cport:16854)::PrepRequestProcessor@157] - PrepRequestProcessor exited loop! [junit] 2017-02-02 00:19:20,140 [myid:] - INFO [main:FinalRequestProcessor@481] - shutdown of request processor complete [junit] 2017-02-02 00:19:20,140 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2017-02-02 00:19:20,140 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=InMemoryDataTree] [junit] 2017-02-02 00:19:20,140 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854] [junit] 2017-02-02 00:19:20,141 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 16854 [junit] 2017-02-02 00:19:20,141 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2017-02-02 00:19:20,145 [myid:] - INFO [main:ClientBase@583] - fdcount after test is: 4824 at start it was 4824 [junit] 2017-02-02 00:19:20,146 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testWatcherAutoResetWithLocal [junit] 2017-02-02 00:19:20,146 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testWatcherAutoResetWithLocal [junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 490.027 sec, Thread: 3, Class: org.apache.zookeeper.test.NioNettySuiteTest [junit] 2017-02-02 00:19:20,234 [myid:127.0.0.1:16737] - INFO [main-SendThread(127.0.0.1:16737):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:16737. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-02-02 00:19:20,235 [myid:127.0.0.1:16737] - WARN [main-SendThread(127.0.0.1:16737):ClientCnxn$SendThread@1235] - Session 0x300bed6b513 for server 127.0.0.1/127.0.0.1:16737, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at
[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849131#comment-15849131
]
ASF GitHub Bot commented on ZOOKEEPER-2659:
---
Github user praste commented on the issue:
https://github.com/apache/zookeeper/pull/148
Two options
1. Use patch
* Use link
https://patch-diff.githubusercontent.com/raw/apache/zookeeper/pull/148.diff and
save it as patch. Then use `git apply-patch`
2. Pull from my fork (I have not really tested following steps, jut relying
on my muscle memory)
* `git remote add praste https://github.com/praste/zookeeper/`
* `git fetch praste`
* `git pull praste/log4j2-migration`
> Use log4j2 as a logging framework as log4j 1.X is now deprecated
>
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
> Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework.
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user praste commented on the issue: https://github.com/apache/zookeeper/pull/148 Two options 1. Use patch * Use link https://patch-diff.githubusercontent.com/raw/apache/zookeeper/pull/148.diff and save it as patch. Then use `git apply-patch` 2. Pull from my fork (I have not really tested following steps, jut relying on my muscle memory) * `git remote add praste https://github.com/praste/zookeeper/` * `git fetch praste` * `git pull praste/log4j2-migration` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Issue Comment Deleted] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pushkar Raste updated ZOOKEEPER-2659:
-
Comment: was deleted
(was: Two options
# Use patch
#* Use link
https://patch-diff.githubusercontent.com/raw/apache/zookeeper/pull/148.diff and
save it as patch. Then use {{git apply-patch}}
# Pull from my fork (I have not really tested following steps, jut relying on
my muscle memory)
#* {{git remote add praste https://github.com/praste/zookeeper/}}
#* {{git fetch praste}}
#* {{git pull praste/log4j2-migration}})
> Use log4j2 as a logging framework as log4j 1.X is now deprecated
>
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
> Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework.
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (ZOOKEEPER-2024) Major throughput improvement with mixed workloads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849096#comment-15849096 ] Ryan Zhang edited comment on ZOOKEEPER-2024 at 2/1/17 11:22 PM: We imported this commit but quickly found a bug somewhere and the commit processor crashed because the commit is not the one that is waiting smf1-chn-23-sr1.prod.twitter.com: 2017-01-25 02:14:30,147 - ERROR [CommitProcessor:4] - Got cxid 0x2c2 expected 0x3a0 for client session id 53b398c5800b6 smf1-chn-23-sr1.prod.twitter.com: 2017-01-25 02:14:30,147 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:31:16,011 - ERROR [CommitProcessor:4] - Got cxid 0x35db2 expected 0x3624c for client session id 1006589aec2087e smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:31:16,011 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:50:19,204 - ERROR [CommitProcessor:4] - Got cxid 0x0 expected 0x6126 for client session id 4003f40105a00e7 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:50:19,205 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:53:03,738 - ERROR [CommitProcessor:4] - Got cxid 0x2fe94 expected 0x2fe96 for client session id 563a1644b008b smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:53:03,738 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 23:06:05,795 - ERROR [CommitProcessor:4] - Got cxid 0x9c98c expected 0x9cb5f for client session id 10045820b228ba2 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 23:06:05,795 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 I am adding more logs on the leader to try to debug but just wonder if anyone has seen this too? was (Author: nerdyyatrice): We imported this commit but quickly found a bug somewhere and the commit processor crashed because the commit is not the one that is waiting smf1-chn-23-sr1.prod.twitter.com: 2017-01-25 02:14:30,147 - ERROR [CommitProcessor:4] - Got cxid 0x2c2 expected 0x3a0 for client session id 53b398c5800b6 smf1-chn-23-sr1.prod.twitter.com: 2017-01-25 02:14:30,147 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:31:16,011 - ERROR [CommitProcessor:4] - Got cxid 0x35db2 expected 0x3624c for client session id 1006589aec2087e smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:31:16,011 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:50:19,204 - ERROR [CommitProcessor:4] - Got cxid 0x0 expected 0x6126 for client session id 4003f40105a00e7 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:50:19,205 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:53:03,738 - ERROR [CommitProcessor:4] - Got cxid 0x2fe94 expected 0x2fe96 for client session id 563a1644b008b smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:53:03,738 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 23:06:05,795 - ERROR [CommitProcessor:4] - Got cxid 0x9c98c expected 0x9cb5f for client session id 10045820b228ba2 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 23:06:05,795 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 just wonder if anyone has seen this? > Major throughput improvement with mixed workloads > - > > Key: ZOOKEEPER-2024 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum, server >Reporter: Kfir Lev-Ari >Assignee: Kfir Lev-Ari > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, > ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, > ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, > ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, > ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch > > > The patch is applied to the commit processor, and solves two problems: > 1. Stalling - once the commit processor encounters a local write request, it > stalls local processing of all sessions until it receives a commit of that > request from the leader. > In mixed workloads, this severely hampers performance as it does not allow > read-only sessions to proceed at faster
[jira] [Commented] (ZOOKEEPER-2024) Major throughput improvement with mixed workloads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849096#comment-15849096 ] Ryan Zhang commented on ZOOKEEPER-2024: --- We imported this commit but quickly found a bug somewhere and the commit processor crashed because the commit is not the one that is waiting smf1-chn-23-sr1.prod.twitter.com: 2017-01-25 02:14:30,147 - ERROR [CommitProcessor:4] - Got cxid 0x2c2 expected 0x3a0 for client session id 53b398c5800b6 smf1-chn-23-sr1.prod.twitter.com: 2017-01-25 02:14:30,147 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:31:16,011 - ERROR [CommitProcessor:4] - Got cxid 0x35db2 expected 0x3624c for client session id 1006589aec2087e smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:31:16,011 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:50:19,204 - ERROR [CommitProcessor:4] - Got cxid 0x0 expected 0x6126 for client session id 4003f40105a00e7 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:50:19,205 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:53:03,738 - ERROR [CommitProcessor:4] - Got cxid 0x2fe94 expected 0x2fe96 for client session id 563a1644b008b smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 22:53:03,738 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 23:06:05,795 - ERROR [CommitProcessor:4] - Got cxid 0x9c98c expected 0x9cb5f for client session id 10045820b228ba2 smf1-chn-23-sr1.prod.twitter.com: 2017-02-01 23:06:05,795 - ERROR [CommitProcessor:4] - Severe unrecoverable error, from thread : CommitProcessor:4 just wonder if anyone has seen this? > Major throughput improvement with mixed workloads > - > > Key: ZOOKEEPER-2024 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum, server >Reporter: Kfir Lev-Ari >Assignee: Kfir Lev-Ari > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, > ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, > ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, > ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch, > ZOOKEEPER-2024.patch, ZOOKEEPER-2024.patch > > > The patch is applied to the commit processor, and solves two problems: > 1. Stalling - once the commit processor encounters a local write request, it > stalls local processing of all sessions until it receives a commit of that > request from the leader. > In mixed workloads, this severely hampers performance as it does not allow > read-only sessions to proceed at faster speed than read-write ones. > 2. Starvation - as long as there are read requests to process, older remote > committed write requests are starved. > This occurs due to a bug fix > (https://issues.apache.org/jira/browse/ZOOKEEPER-1505) that forces processing > of local read requests before handling any committed write. The problem is > only manifested under high local read load. > Our solution solves these two problems. It improves throughput in mixed > workloads (in our tests, by up to 8x), and reduces latency, especially higher > percentiles (i.e., slowest requests). > The main idea is to separate sessions that inherently need to stall in order > to enforce order semantics, from ones that do not need to stall. To this end, > we add data structures for buffering and managing pending requests of stalled > sessions; these requests are moved out of the critical path to these data > structures, allowing continued processing of unaffected sessions. > Please see the docs: > 1) https://goo.gl/m1cINJ - includes a detailed description of the new commit > processor algorithm. > 2) The attached patch implements our solution, and a collection of related > unit tests (https://reviews.apache.org/r/25160) > 3) https://goo.gl/W0xDUP - performance results. > (See https://issues.apache.org/jira/browse/ZOOKEEPER-2023 for the > corresponding new system test that produced these performance measurements) > > See also https://issues.apache.org/jira/browse/ZOOKEEPER-1609 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849078#comment-15849078
]
ASF GitHub Bot commented on ZOOKEEPER-2659:
---
Github user nerdyyatrice commented on the issue:
https://github.com/apache/zookeeper/pull/148
Another stupid question, how can I git pull this request to my local
machine and play with it? Thanks
> Use log4j2 as a logging framework as log4j 1.X is now deprecated
>
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
> Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework.
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] zookeeper issue #148: ZOOKEEPER-2659 Log4j 2 migration
Github user nerdyyatrice commented on the issue: https://github.com/apache/zookeeper/pull/148 Another stupid question, how can I git pull this request to my local machine and play with it? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (ZOOKEEPER-2680) Correct DataNode.getChildren() inconsistent behaviour.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848826#comment-15848826
]
ASF GitHub Bot commented on ZOOKEEPER-2680:
---
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98973726
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1045,18 +1046,16 @@ private void getCounts(String path, Counts counts) {
if (node == null) {
return;
}
-Set children = null;
+String[] children = null;
int len = 0;
synchronized (node) {
-children = node.getChildren();
+Set childs = node.getChildren();
--- End diff --
But as all tests are passing, that's fine. :smiley: Congrats!
> Correct DataNode.getChildren() inconsistent behaviour.
> --
>
> Key: ZOOKEEPER-2680
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2680
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.9, 3.5.1
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2680-01.patch
>
>
> DataNode.getChildren() API returns null and empty set if there are no
> children in it depending on when the API is called. DataNode.getChildren()
> API behavior should be changed and it should always return empty set if the
> node does not have any child
> *DataNode.getChildren() API Current Behavior:*
> # returns null initially
> When DataNode is created and no children are added yet,
> DataNode.getChildren() returns null
> # returns empty set after all the children are deleted:
> created a Node
> add a child
> delete the child
> DataNode.getChildren() returns empty set.
> After fix DataNode.getChildren() should return empty set in all the above
> cases.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] zookeeper pull request #160: ZOOKEEPER-2680:Correct DataNode.getChildren() i...
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98973726
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1045,18 +1046,16 @@ private void getCounts(String path, Counts counts) {
if (node == null) {
return;
}
-Set children = null;
+String[] children = null;
int len = 0;
synchronized (node) {
-children = node.getChildren();
+Set childs = node.getChildren();
--- End diff --
But as all tests are passing, that's fine. :smiley: Congrats!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (ZOOKEEPER-2680) Correct DataNode.getChildren() inconsistent behaviour.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848790#comment-15848790
]
ASF GitHub Bot commented on ZOOKEEPER-2680:
---
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98968169
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1045,18 +1046,16 @@ private void getCounts(String path, Counts counts) {
if (node == null) {
return;
}
-Set children = null;
+String[] children = null;
int len = 0;
synchronized (node) {
-children = node.getChildren();
+Set childs = node.getChildren();
--- End diff --
@arshadmohammad FYI (only): I guess some tests broke 'cause toArray copies
the contents of childs to children while node.getChildren() returns a internal
reference (subject to underneath change) to children. So, it would need to be
something like children = new HashSet<>(childs);
> Correct DataNode.getChildren() inconsistent behaviour.
> --
>
> Key: ZOOKEEPER-2680
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2680
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.9, 3.5.1
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2680-01.patch
>
>
> DataNode.getChildren() API returns null and empty set if there are no
> children in it depending on when the API is called. DataNode.getChildren()
> API behavior should be changed and it should always return empty set if the
> node does not have any child
> *DataNode.getChildren() API Current Behavior:*
> # returns null initially
> When DataNode is created and no children are added yet,
> DataNode.getChildren() returns null
> # returns empty set after all the children are deleted:
> created a Node
> add a child
> delete the child
> DataNode.getChildren() returns empty set.
> After fix DataNode.getChildren() should return empty set in all the above
> cases.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] zookeeper pull request #160: ZOOKEEPER-2680:Correct DataNode.getChildren() i...
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98968169
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1045,18 +1046,16 @@ private void getCounts(String path, Counts counts) {
if (node == null) {
return;
}
-Set children = null;
+String[] children = null;
int len = 0;
synchronized (node) {
-children = node.getChildren();
+Set childs = node.getChildren();
--- End diff --
@arshadmohammad FYI (only): I guess some tests broke 'cause toArray copies
the contents of childs to children while node.getChildren() returns a internal
reference (subject to underneath change) to children. So, it would need to be
something like children = new HashSet<>(childs);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (ZOOKEEPER-2680) Correct DataNode.getChildren() inconsistent behaviour.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848789#comment-15848789
]
ASF GitHub Bot commented on ZOOKEEPER-2680:
---
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98967876
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1045,18 +1046,16 @@ private void getCounts(String path, Counts counts) {
if (node == null) {
return;
}
-Set children = null;
+String[] children = null;
int len = 0;
synchronized (node) {
-children = node.getChildren();
+Set childs = node.getChildren();
+children = childs.toArray(new String[childs.size()]);
--- End diff --
FYI (only): I *guess* some tests broke 'cause `toArray` copies the contents
of `childs` to `children` while `node.getChildren()` returns a internal
reference (subject to underneath change) to `children`. So, it would need to be
something like `children = new HashSet<>(childs);`
> Correct DataNode.getChildren() inconsistent behaviour.
> --
>
> Key: ZOOKEEPER-2680
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2680
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.9, 3.5.1
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2680-01.patch
>
>
> DataNode.getChildren() API returns null and empty set if there are no
> children in it depending on when the API is called. DataNode.getChildren()
> API behavior should be changed and it should always return empty set if the
> node does not have any child
> *DataNode.getChildren() API Current Behavior:*
> # returns null initially
> When DataNode is created and no children are added yet,
> DataNode.getChildren() returns null
> # returns empty set after all the children are deleted:
> created a Node
> add a child
> delete the child
> DataNode.getChildren() returns empty set.
> After fix DataNode.getChildren() should return empty set in all the above
> cases.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] zookeeper pull request #160: ZOOKEEPER-2680:Correct DataNode.getChildren() i...
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98967876
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1045,18 +1046,16 @@ private void getCounts(String path, Counts counts) {
if (node == null) {
return;
}
-Set children = null;
+String[] children = null;
int len = 0;
synchronized (node) {
-children = node.getChildren();
+Set childs = node.getChildren();
+children = childs.toArray(new String[childs.size()]);
--- End diff --
FYI (only): I *guess* some tests broke 'cause `toArray` copies the contents
of `childs` to `children` while `node.getChildren()` returns a internal
reference (subject to underneath change) to `children`. So, it would need to be
something like `children = new HashSet<>(childs);`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (ZOOKEEPER-2680) Correct DataNode.getChildren() inconsistent behaviour.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848731#comment-15848731 ] Hadoop QA commented on ZOOKEEPER-2680: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/275//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/275//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/275//console This message is automatically generated. > Correct DataNode.getChildren() inconsistent behaviour. > -- > > Key: ZOOKEEPER-2680 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2680 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.9, 3.5.1 >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2680-01.patch > > > DataNode.getChildren() API returns null and empty set if there are no > children in it depending on when the API is called. DataNode.getChildren() > API behavior should be changed and it should always return empty set if the > node does not have any child > *DataNode.getChildren() API Current Behavior:* > # returns null initially > When DataNode is created and no children are added yet, > DataNode.getChildren() returns null > # returns empty set after all the children are deleted: > created a Node > add a child > delete the child > DataNode.getChildren() returns empty set. > After fix DataNode.getChildren() should return empty set in all the above > cases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Success: ZOOKEEPER- PreCommit Build #275
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/275/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 479395 lines...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 2 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/275//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/275//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/275//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 546378c0b7f12c19d6674c6a41d732e9c7d96be0 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ and ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ are the same file BUILD SUCCESSFUL Total time: 18 minutes 27 seconds Archiving artifacts Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Recording test results Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [description-setter] Description set: ZOOKEEPER-2680 Putting comment on the pull request Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
ZooKeeper_branch35_solaris - Build # 418 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_solaris/418/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 474044 lines...] [junit] 2017-02-01 17:15:16,489 [myid:] - INFO [main:ClientBase@386] - CREATING server instance 127.0.0.1:11222 [junit] 2017-02-01 17:15:16,490 [myid:] - INFO [main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2017-02-01 17:15:16,490 [myid:] - INFO [main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222 [junit] 2017-02-01 17:15:16,491 [myid:] - INFO [main:ClientBase@361] - STARTING server instance 127.0.0.1:11222 [junit] 2017-02-01 17:15:16,491 [myid:] - INFO [main:ZooKeeperServer@893] - minSessionTimeout set to 6000 [junit] 2017-02-01 17:15:16,492 [myid:] - INFO [main:ZooKeeperServer@902] - maxSessionTimeout set to 6 [junit] 2017-02-01 17:15:16,492 [myid:] - INFO [main:ZooKeeperServer@159] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5432366520212263657.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5432366520212263657.junit.dir/version-2 [junit] 2017-02-01 17:15:16,492 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5432366520212263657.junit.dir/version-2/snapshot.b [junit] 2017-02-01 17:15:16,494 [myid:] - INFO [main:FileTxnSnapLog@320] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test5432366520212263657.junit.dir/version-2/snapshot.b [junit] 2017-02-01 17:15:16,496 [myid:] - ERROR [main:ZooKeeperServer@505] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-02-01 17:15:16,496 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222 [junit] 2017-02-01 17:15:16,496 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:45891 [junit] 2017-02-01 17:15:16,497 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from /127.0.0.1:45891 [junit] 2017-02-01 17:15:16,497 [myid:] - INFO [NIOWorkerThread-1:StatCommand@49] - Stat command output [junit] 2017-02-01 17:15:16,497 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@614] - Closed socket connection for client /127.0.0.1:45891 (no session established for client) [junit] 2017-02-01 17:15:16,498 [myid:] - INFO [main:JMXEnv@228] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2017-02-01 17:15:16,499 [myid:] - INFO [main:JMXEnv@245] - expect:InMemoryDataTree [junit] 2017-02-01 17:15:16,499 [myid:] - INFO [main:JMXEnv@249] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree [junit] 2017-02-01 17:15:16,499 [myid:] - INFO [main:JMXEnv@245] - expect:StandaloneServer_port [junit] 2017-02-01 17:15:16,499 [myid:] - INFO [main:JMXEnv@249] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11222 [junit] 2017-02-01 17:15:16,500 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17890 [junit] 2017-02-01 17:15:16,500 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24 [junit] 2017-02-01 17:15:16,500 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testQuota [junit] 2017-02-01 17:15:16,500 [myid:] - INFO [main:ClientBase@543] - tearDown starting [junit] 2017-02-01 17:15:16,572 [myid:] - INFO [main:ZooKeeper@1322] - Session: 0x12677a57f8d closed [junit] 2017-02-01 17:15:16,572 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x12677a57f8d [junit] 2017-02-01 17:15:16,572 [myid:] - INFO [main:ClientBase@513] - STOPPING server [junit] 2017-02-01 17:15:16,573 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2017-02-01 17:15:16,573 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2017-02-01 17:15:16,573 [myid:] - INFO
[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848633#comment-15848633
]
Pushkar Raste commented on ZOOKEEPER-2659:
--
any takers for this?
Let me know if there are any changes we are waiting on for PR to get merged?
> Use log4j2 as a logging framework as log4j 1.X is now deprecated
>
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
> Issue Type: Wish
>Reporter: Pushkar Raste
>Assignee: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework.
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2125) SSL on Netty client-server communication
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848621#comment-15848621
]
Gérald Quintana commented on ZOOKEEPER-2125:
This change is interesting.
But giving truststore|keystore password using an environment variable is
dangerous, they should be stored in Zookeeper's config file.
Any user with access to the machine can do a `ps` and grab passwords, it's like
not having passwords at all.
{code}
# ps -ef |grep zookeeper
zookeeper4125 1 0 17:39 ?00:00:04
/usr/lib/java/jdk-1.8.0_91/bin/java -Dzookeeper.log.dir=/var/log/zookeeper
-Dzookeeper.root.logger=INFO,ROLLINGFILE -cp
/appli/projects/sup/supervision/zookeeper/zookeeper-3.4.6/bin/../build/classes:/opt/zookeeper-3.4.6/bin/../build/lib/*.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-log4j12-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/slf4j-api-1.6.1.jar:/opt/zookeeper-3.4.6/bin/../lib/netty-3.7.0.Final.jar:/opt/zookeeper-3.4.6/bin/../lib/log4j-1.2.16.jar:/opt/zookeeper-3.4.6/bin/../lib/jline-0.9.94.jar:/opt/zookeeper-3.4.6/bin/../zookeeper-3.4.6.jar:/opt/zookeeper-3.4.6/bin/../src/java/lib/*.jar:/opt/zookeeper-3.4.6/bin/../conf:
-Dzookeeper.serverCnxnFactory=org.apache.zookeeper.server.NettyServerCnxnFactory
-Dzookeeper.ssl.keyStore.location=/opt/zookeeper-3.4.6/conf/keystore.jks
-Dzookeeper.ssl.keyStore.password=changeme -
zookeeper.ssl.trustStore.location=/opt/zookeeper-3.4.6/conf/truststore.jks
-Dzookeeper.ssl.trustStore.password=changeme
org.apache.zookeeper.server.quorum.QuorumPeerMain
/opt/zookeeper-3.4.6/bin/../conf/zoo.cfg
{code}
> SSL on Netty client-server communication
>
>
> Key: ZOOKEEPER-2125
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2125
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Hongchao Deng
>Assignee: Hongchao Deng
> Fix For: 3.5.1, 3.6.0
>
> Attachments: testKeyStore.jks, testTrustStore.jks,
> ZOOKEEPER-2125-build.patch, ZOOKEEPER-2125.patch, ZOOKEEPER-2125.patch,
> ZOOKEEPER-2125.patch, ZOOKEEPER-2125.patch, ZOOKEEPER-2125.patch,
> ZOOKEEPER-2125.patch, ZOOKEEPER-2125.patch, ZOOKEEPER-2125.patch,
> ZOOKEEPER-2125.patch, ZOOKEEPER-2125.patch, ZOOKEEPER-2125.patch,
> ZOOKEEPER-2125.patch, ZOOKEEPER-2125.patch, ZOOKEEPER-2125.patch,
> ZOOKEEPER-2125.patch, ZOOKEEPER-2125.patch, ZOOKEEPER-2125.patch,
> ZOOKEEPER-2125.patch
>
>
> Supporting SSL on Netty client-server communication.
> 1. It supports keystore and trustore usage.
> 2. It adds an additional ZK server port which supports SSL. This would be
> useful for rolling upgrade.
> RB: https://reviews.apache.org/r/31277/
> The patch includes three files:
> * testing purpose keystore and truststore under
> "$(ZK_REPO_HOME)/src/java/test/data/ssl". Might need to create "ssl/".
> * latest ZOOKEEPER-2125.patch
> h2. How to use it
> You need to set some parameters on both ZK server and client.
> h3. Server
> You need to specify a listening SSL port in "zoo.cfg":
> {code}
> secureClientPort=2281
> {code}
> Just like what you did with "clientPort". And then set some jvm flags:
> {code}
> export
> SERVER_JVMFLAGS="-Dzookeeper.serverCnxnFactory=org.apache.zookeeper.server.NettyServerCnxnFactory
> -Dzookeeper.ssl.keyStore.location=/root/zookeeper/ssl/testKeyStore.jks
> -Dzookeeper.ssl.keyStore.password=testpass
> -Dzookeeper.ssl.trustStore.location=/root/zookeeper/ssl/testTrustStore.jks
> -Dzookeeper.ssl.trustStore.password=testpass"
> {code}
> Please change keystore and truststore parameters accordingly.
> h3. Client
> You need to set jvm flags:
> {code}
> export
> CLIENT_JVMFLAGS="-Dzookeeper.clientCnxnSocket=org.apache.zookeeper.ClientCnxnSocketNetty
> -Dzookeeper.client.secure=true
> -Dzookeeper.ssl.keyStore.location=/root/zookeeper/ssl/testKeyStore.jks
> -Dzookeeper.ssl.keyStore.password=testpass
> -Dzookeeper.ssl.trustStore.location=/root/zookeeper/ssl/testTrustStore.jks
> -Dzookeeper.ssl.trustStore.password=testpass"
> {code}
> change keystore and truststore parameters accordingly.
> And then connect to the server's SSL port, in this case:
> {code}
> bin/zkCli.sh -server 127.0.0.1:2281
> {code}
> If you have any feedback, you are more than welcome to discuss it here!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2680) Correct DataNode.getChildren() inconsistent behaviour.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848567#comment-15848567 ] ASF GitHub Bot commented on ZOOKEEPER-2680: --- Github user arshadmohammad commented on the issue: https://github.com/apache/zookeeper/pull/160 checking the CI failure. > Correct DataNode.getChildren() inconsistent behaviour. > -- > > Key: ZOOKEEPER-2680 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2680 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.9, 3.5.1 >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2680-01.patch > > > DataNode.getChildren() API returns null and empty set if there are no > children in it depending on when the API is called. DataNode.getChildren() > API behavior should be changed and it should always return empty set if the > node does not have any child > *DataNode.getChildren() API Current Behavior:* > # returns null initially > When DataNode is created and no children are added yet, > DataNode.getChildren() returns null > # returns empty set after all the children are deleted: > created a Node > add a child > delete the child > DataNode.getChildren() returns empty set. > After fix DataNode.getChildren() should return empty set in all the above > cases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] zookeeper issue #160: ZOOKEEPER-2680:Correct DataNode.getChildren() inconsis...
Github user arshadmohammad commented on the issue: https://github.com/apache/zookeeper/pull/160 checking the CI failure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (ZOOKEEPER-2680) Correct DataNode.getChildren() inconsistent behaviour.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848527#comment-15848527 ] Hadoop QA commented on ZOOKEEPER-2680: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/274//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/274//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/274//console This message is automatically generated. > Correct DataNode.getChildren() inconsistent behaviour. > -- > > Key: ZOOKEEPER-2680 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2680 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.9, 3.5.1 >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2680-01.patch > > > DataNode.getChildren() API returns null and empty set if there are no > children in it depending on when the API is called. DataNode.getChildren() > API behavior should be changed and it should always return empty set if the > node does not have any child > *DataNode.getChildren() API Current Behavior:* > # returns null initially > When DataNode is created and no children are added yet, > DataNode.getChildren() returns null > # returns empty set after all the children are deleted: > created a Node > add a child > delete the child > DataNode.getChildren() returns empty set. > After fix DataNode.getChildren() should return empty set in all the above > cases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Failed: ZOOKEEPER- PreCommit Build #274
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/274/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 482110 lines...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/274//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/274//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/274//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 37bad7b62804401fa915504ad6fc28588cad8549 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1630: exec returned: 1 Total time: 18 minutes 53 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Compressed 575.40 KB of artifacts by 27.8% relative to #273 Recording test results Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [description-setter] Description set: ZOOKEEPER-2680 Putting comment on the pull request Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ### ## FAILED TESTS (if any) ## 3 tests failed. FAILED: org.apache.zookeeper.server.CRCTest.testChecksums Error Message: null Stack Trace: java.io.EOFException at java.io.DataInputStream.readInt(DataInputStream.java:392) at org.apache.jute.BinaryInputArchive.readString(BinaryInputArchive.java:79) at org.apache.zookeeper.server.DataTree.deserialize(DataTree.java:1222) at org.apache.zookeeper.server.util.SerializeUtils.deserializeSnapshot(SerializeUtils.java:137) at org.apache.zookeeper.server.persistence.FileSnap.deserialize(FileSnap.java:127) at org.apache.zookeeper.server.CRCTest.getCheckSum(CRCTest.java:82) at org.apache.zookeeper.server.CRCTest.testChecksums(CRCTest.java:171) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79) FAILED: org.apache.zookeeper.server.InvalidSnapshotTest.testInvalidSnapshot Error Message: No snapshot found, but there are log entries. Something is broken! Stack Trace: java.io.IOException: No snapshot found, but there are log entries. Something is broken! at org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:191) at org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:225) at
[jira] [Commented] (ZOOKEEPER-2680) Correct DataNode.getChildren() inconsistent behaviour.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848510#comment-15848510 ] ASF GitHub Bot commented on ZOOKEEPER-2680: --- Github user arshadmohammad commented on the issue: https://github.com/apache/zookeeper/pull/160 1. yes, changes should be applied to branch-3.4 and branch-3.5 also. I will raise merge request for branch-3.4 and branch-3.5 after it is committed to master 2. This is very much needed. Thanks :-). I removed Null check from all references of getChildren and corrected the code as per the need > Correct DataNode.getChildren() inconsistent behaviour. > -- > > Key: ZOOKEEPER-2680 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2680 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.9, 3.5.1 >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2680-01.patch > > > DataNode.getChildren() API returns null and empty set if there are no > children in it depending on when the API is called. DataNode.getChildren() > API behavior should be changed and it should always return empty set if the > node does not have any child > *DataNode.getChildren() API Current Behavior:* > # returns null initially > When DataNode is created and no children are added yet, > DataNode.getChildren() returns null > # returns empty set after all the children are deleted: > created a Node > add a child > delete the child > DataNode.getChildren() returns empty set. > After fix DataNode.getChildren() should return empty set in all the above > cases. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] zookeeper issue #160: ZOOKEEPER-2680:Correct DataNode.getChildren() inconsis...
Github user arshadmohammad commented on the issue: https://github.com/apache/zookeeper/pull/160 1. yes, changes should be applied to branch-3.4 and branch-3.5 also. I will raise merge request for branch-3.4 and branch-3.5 after it is committed to master 2. This is very much needed. Thanks :-). I removed Null check from all references of getChildren and corrected the code as per the need --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
ZooKeeper_branch34_openjdk7 - Build # 1373 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1373/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H13 (ubuntu) in workspace
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
> git rev-parse --verify HEAD # timeout=10
Resetting working tree
> git reset --hard # timeout=10
> git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
> git --version # timeout=10
> git -c core.askpass=true fetch --tags --progress
> git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*
> git rev-parse refs/remotes/origin/branch-3.4^{commit} # timeout=10
> git rev-parse refs/remotes/origin/origin/branch-3.4^{commit} # timeout=10
Checking out Revision 4b9fe5ea71d73ba26ca722e3919b8d0afe84ab86
(refs/remotes/origin/branch-3.4)
> git config core.sparsecheckout # timeout=10
> git checkout -f 4b9fe5ea71d73ba26ca722e3919b8d0afe84ab86
> git rev-list 4b9fe5ea71d73ba26ca722e3919b8d0afe84ab86 # timeout=10
No emails were triggered.
[ZooKeeper_branch34_openjdk7] $ /home/jenkins/tools/ant/latest/bin/ant
-Dtest.output=yes -Dtest.junit.threads=8 -Dtest.junit.output.format=xml
-Djavac.target=1.7 clean test-core-java
Error: JAVA_HOME is not defined correctly.
We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
###
## FAILED TESTS (if any)
##
No tests ran.
ZooKeeper_branch34_solaris - Build # 1454 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1454/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 193535 lines...] [junit] 2017-02-01 13:58:19,344 [myid:] - INFO [main:ZooKeeperServer@497] - shutting down [junit] 2017-02-01 13:58:19,344 [myid:] - ERROR [main:ZooKeeperServer@472] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-02-01 13:58:19,344 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2017-02-01 13:58:19,345 [myid:] - INFO [main:PrepRequestProcessor@765] - Shutting down [junit] 2017-02-01 13:58:19,345 [myid:] - INFO [main:SyncRequestProcessor@208] - Shutting down [junit] 2017-02-01 13:58:19,345 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2017-02-01 13:58:19,345 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited! [junit] 2017-02-01 13:58:19,345 [myid:] - INFO [main:FinalRequestProcessor@402] - shutdown of request processor complete [junit] 2017-02-01 13:58:19,346 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2017-02-01 13:58:19,346 [myid:] - INFO [main:JMXEnv@147] - ensureOnly:[] [junit] 2017-02-01 13:58:19,347 [myid:] - INFO [main:ClientBase@445] - STARTING server [junit] 2017-02-01 13:58:19,348 [myid:] - INFO [main:ClientBase@366] - CREATING server instance 127.0.0.1:11221 [junit] 2017-02-01 13:58:19,348 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2017-02-01 13:58:19,348 [myid:] - INFO [main:ClientBase@341] - STARTING server instance 127.0.0.1:11221 [junit] 2017-02-01 13:58:19,349 [myid:] - INFO [main:ZooKeeperServer@173] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test1896511710286355130.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test1896511710286355130.junit.dir/version-2 [junit] 2017-02-01 13:58:19,353 [myid:] - ERROR [main:ZooKeeperServer@472] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-02-01 13:58:19,353 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2017-02-01 13:58:19,353 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - Accepted socket connection from /127.0.0.1:59579 [junit] 2017-02-01 13:58:19,354 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@838] - Processing stat command from /127.0.0.1:59579 [junit] 2017-02-01 13:58:19,354 [myid:] - INFO [Thread-5:NIOServerCnxn$StatCommand@674] - Stat command output [junit] 2017-02-01 13:58:19,354 [myid:] - INFO [Thread-5:NIOServerCnxn@1019] - Closed socket connection for client /127.0.0.1:59579 (no session established for client) [junit] 2017-02-01 13:58:19,355 [myid:] - INFO [main:JMXEnv@230] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2017-02-01 13:58:19,356 [myid:] - INFO [main:JMXEnv@247] - expect:InMemoryDataTree [junit] 2017-02-01 13:58:19,356 [myid:] - INFO [main:JMXEnv@251] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2017-02-01 13:58:19,356 [myid:] - INFO [main:JMXEnv@247] - expect:StandaloneServer_port [junit] 2017-02-01 13:58:19,356 [myid:] - INFO [main:JMXEnv@251] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2017-02-01 13:58:19,357 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 8996 [junit] 2017-02-01 13:58:19,357 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2017-02-01 13:58:19,357 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2017-02-01 13:58:19,357 [myid:] - INFO [main:ClientBase@522] - tearDown starting [junit] 2017-02-01 13:58:19,961 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x159f9f7fe68 closed [junit] 2017-02-01 13:58:19,962 [myid:] - INFO [main:ClientBase@492] - STOPPING server [junit] 2017-02-01 13:58:19,962 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for session: 0x159f9f7fe68 [junit] 2017-02-01 13:58:19,962 [myid:] - INFO [main:ZooKeeperServer@497] - shutting down [junit] 2017-02-01 13:58:19,963 [myid:] -
ZooKeeper-trunk-jdk8 - Build # 922 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/922/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 456090 lines...] [junit] 2017-02-01 12:00:15,527 [myid:127.0.0.1:22117] - INFO [main-SendThread(127.0.0.1:22117):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:22117. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-02-01 12:00:15,528 [myid:127.0.0.1:22117] - WARN [main-SendThread(127.0.0.1:22117):ClientCnxn$SendThread@1235] - Session 0x1028d3e2436 for server 127.0.0.1/127.0.0.1:22117, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-02-01 12:00:15,576 [myid:127.0.0.1:22123] - INFO [main-SendThread(127.0.0.1:22123):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:22123. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-02-01 12:00:15,577 [myid:127.0.0.1:22123] - WARN [main-SendThread(127.0.0.1:22123):ClientCnxn$SendThread@1235] - Session 0x3028d3e1623 for server 127.0.0.1/127.0.0.1:22123, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-02-01 12:01:42,710 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 131928 [junit] 2017-02-01 12:01:42,711 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 55 [junit] 2017-02-01 12:01:42,711 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testManyChildWatchersAutoReset [junit] 2017-02-01 12:01:42,711 [myid:] - INFO [main:ClientBase@558] - tearDown starting [junit] 2017-02-01 12:01:42,712 [myid:] - INFO [ProcessThread(sid:0 cport:27383)::PrepRequestProcessor@618] - Processed session termination for sessionid: 0x1028d371382 [junit] 2017-02-01 12:01:42,776 [myid:] - INFO [main:ZooKeeper@1324] - Session: 0x1028d371382 closed [junit] 2017-02-01 12:01:42,776 [myid:] - INFO [NIOWorkerThread-22:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port27383,name1=Connections,name2=127.0.0.1,name3=0x1028d371382] [junit] 2017-02-01 12:01:42,776 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x1028d371382 [junit] 2017-02-01 12:01:42,777 [myid:] - INFO [ProcessThread(sid:0 cport:27383)::PrepRequestProcessor@618] - Processed session termination for sessionid: 0x1028d3713820001 [junit] 2017-02-01 12:01:42,777 [myid:] - INFO [NIOWorkerThread-22:NIOServerCnxn@614] - Closed socket connection for client /127.0.0.1:41784 which had sessionid 0x1028d371382 [junit] 2017-02-01 12:01:42,811 [myid:] - INFO [NIOWorkerThread-15:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port27383,name1=Connections,name2=127.0.0.1,name3=0x1028d3713820001] [junit] 2017-02-01 12:01:42,811 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x1028d3713820001 [junit] 2017-02-01 12:01:42,811 [myid:] - INFO [NIOWorkerThread-15:NIOServerCnxn@614] - Closed socket connection for client /127.0.0.1:41790 which had sessionid 0x1028d3713820001 [junit] 2017-02-01 12:01:42,811 [myid:] - INFO [main:ZooKeeper@1324] - Session: 0x1028d3713820001 closed [junit] 2017-02-01 12:01:42,811 [myid:] - INFO [main:ClientBase@528] - STOPPING server [junit] 2017-02-01 12:01:42,812 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2017-02-01 12:01:42,814 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2017-02-01 12:01:42,817 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2017-02-01
[jira] [Commented] (ZOOKEEPER-2464) NullPointerException on ContainerManager
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848218#comment-15848218 ] Jens Rantil commented on ZOOKEEPER-2464: Hi, we are also seeing this. We have a lot of zNodes building up in production as we speak (currently at 3127223). We have a temporary script that can remove older znodes, but this is a real big operational risk waiting to explode since failover will be very heavy. What's the next step here? Can we help any way? Is there any date for when a release with a fix for this is in place? > NullPointerException on ContainerManager > > > Key: ZOOKEEPER-2464 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2464 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.1 >Reporter: Stefano Salmaso >Assignee: Jordan Zimmerman > Fix For: 3.5.3, 3.6.0 > > Attachments: ContainerManagerTest.java, ZOOKEEPER-2464.patch > > > I would like to expose you to a problem that we are experiencing. > We are using a cluster of 7 zookeeper and we use them to implement a > distributed lock using Curator > (http://curator.apache.org/curator-recipes/shared-reentrant-lock.html) > So .. we tried to play with the servers to see if everything worked properly > and we stopped and start servers to see that the system worked well > (like stop 03, stop 05, stop 06, start 05, start 06, start 03) > We saw a strange behavior. > The number of znodes grew up without stopping (normally we had 4000 or 5000, > we got to 60,000 and then we stopped our application) > In zookeeeper logs I saw this (on leader only, one every minute) > 2016-07-04 14:53:50,302 [myid:7] - ERROR > [ContainerManagerTask:ContainerManager$1@84] - Error checking containers > java.lang.NullPointerException >at > org.apache.zookeeper.server.ContainerManager.getCandidates(ContainerManager.java:151) >at > org.apache.zookeeper.server.ContainerManager.checkContainers(ContainerManager.java:111) >at > org.apache.zookeeper.server.ContainerManager$1.run(ContainerManager.java:78) >at java.util.TimerThread.mainLoop(Timer.java:555) >at java.util.TimerThread.run(Timer.java:505) > We have not yet deleted the data ... so the problem can be reproduced on our > servers -- This message was sent by Atlassian JIRA (v6.3.15#6346)
ZooKeeper-trunk-solaris - Build # 1487 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1487/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 464643 lines...] [junit] 2017-02-01 08:24:11,715 [myid:] - INFO [main:ClientBase@401] - CREATING server instance 127.0.0.1:11222 [junit] 2017-02-01 08:24:11,715 [myid:] - INFO [main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2017-02-01 08:24:11,716 [myid:] - INFO [main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222 [junit] 2017-02-01 08:24:11,717 [myid:] - INFO [main:ClientBase@376] - STARTING server instance 127.0.0.1:11222 [junit] 2017-02-01 08:24:11,717 [myid:] - INFO [main:ZooKeeperServer@894] - minSessionTimeout set to 6000 [junit] 2017-02-01 08:24:11,718 [myid:] - INFO [main:ZooKeeperServer@903] - maxSessionTimeout set to 6 [junit] 2017-02-01 08:24:11,718 [myid:] - INFO [main:ZooKeeperServer@160] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test307897425787962783.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test307897425787962783.junit.dir/version-2 [junit] 2017-02-01 08:24:11,718 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test307897425787962783.junit.dir/version-2/snapshot.b [junit] 2017-02-01 08:24:11,720 [myid:] - INFO [main:FileTxnSnapLog@346] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test307897425787962783.junit.dir/version-2/snapshot.b [junit] 2017-02-01 08:24:11,722 [myid:] - ERROR [main:ZooKeeperServer@506] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-02-01 08:24:11,723 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222 [junit] 2017-02-01 08:24:11,723 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:51225 [junit] 2017-02-01 08:24:11,724 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from /127.0.0.1:51225 [junit] 2017-02-01 08:24:11,725 [myid:] - INFO [NIOWorkerThread-1:StatCommand@49] - Stat command output [junit] 2017-02-01 08:24:11,725 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@614] - Closed socket connection for client /127.0.0.1:51225 (no session established for client) [junit] 2017-02-01 08:24:11,726 [myid:] - INFO [main:JMXEnv@228] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2017-02-01 08:24:11,727 [myid:] - INFO [main:JMXEnv@245] - expect:InMemoryDataTree [junit] 2017-02-01 08:24:11,727 [myid:] - INFO [main:JMXEnv@249] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree [junit] 2017-02-01 08:24:11,727 [myid:] - INFO [main:JMXEnv@245] - expect:StandaloneServer_port [junit] 2017-02-01 08:24:11,728 [myid:] - INFO [main:JMXEnv@249] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11222 [junit] 2017-02-01 08:24:11,728 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17909 [junit] 2017-02-01 08:24:11,728 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24 [junit] 2017-02-01 08:24:11,728 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testQuota [junit] 2017-02-01 08:24:11,728 [myid:] - INFO [main:ClientBase@558] - tearDown starting [junit] 2017-02-01 08:24:11,792 [myid:] - INFO [main:ZooKeeper@1324] - Session: 0x12675bf46cc closed [junit] 2017-02-01 08:24:11,792 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x12675bf46cc [junit] 2017-02-01 08:24:11,792 [myid:] - INFO [main:ClientBase@528] - STOPPING server [junit] 2017-02-01 08:24:11,792 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2017-02-01 08:24:11,792 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2017-02-01 08:24:11,792 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] -
