ZooKeeper_branch34_openjdk7 - Build # 1505 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1505/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on qnode1 (ubuntu) in workspace
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
> git rev-parse --verify HEAD # timeout=10
Resetting working tree
> git reset --hard # timeout=10
> git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
> git --version # timeout=10
> git fetch --tags --progress git://git.apache.org/zookeeper.git
> +refs/heads/*:refs/remotes/origin/*
> git rev-parse refs/remotes/origin/branch-3.4^{commit} # timeout=10
> git rev-parse refs/remotes/origin/origin/branch-3.4^{commit} # timeout=10
Checking out Revision 6522d3f4d2bc7de363b3c2f562a2e48cafa86d45
(refs/remotes/origin/branch-3.4)
> git config core.sparsecheckout # timeout=10
> git checkout -f 6522d3f4d2bc7de363b3c2f562a2e48cafa86d45
> git rev-list 3c4f01f6450f55d2fcc605f66c6c6584ccff1584 # timeout=10
No emails were triggered.
[ZooKeeper_branch34_openjdk7] $
/home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant -Dtest.output=yes
-Dtest.junit.threads=8 -Dtest.junit.output.format=xml -Djavac.target=1.7 clean
test-core-java
Error: JAVA_HOME is not defined correctly.
We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
###
## FAILED TESTS (if any)
##
No tests ran.
ZooKeeper_branch34_jdk8 - Build # 996 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/996/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 31.85 MB...] [junit] 2017-05-22 05:08:47,221 [myid:] - INFO [main:PrepRequestProcessor@766] - Shutting down [junit] 2017-05-22 05:08:47,221 [myid:] - INFO [main:SyncRequestProcessor@208] - Shutting down [junit] 2017-05-22 05:08:47,221 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@144] - PrepRequestProcessor exited loop! [junit] 2017-05-22 05:08:47,221 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited! [junit] 2017-05-22 05:08:47,221 [myid:] - INFO [main:FinalRequestProcessor@403] - shutdown of request processor complete [junit] 2017-05-22 05:08:47,222 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2017-05-22 05:08:47,222 [myid:] - INFO [main:JMXEnv@147] - ensureOnly:[] [junit] 2017-05-22 05:08:47,224 [myid:] - INFO [main:ClientBase@470] - STARTING server [junit] 2017-05-22 05:08:47,224 [myid:] - INFO [main:ClientBase@391] - CREATING server instance 127.0.0.1:11221 [junit] 2017-05-22 05:08:47,224 [myid:] - INFO [main:ServerCnxnFactory@111] - Using org.apache.zookeeper.server.NIOServerCnxnFactory as server connection factory [junit] 2017-05-22 05:08:47,224 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2017-05-22 05:08:47,225 [myid:] - INFO [main:ClientBase@366] - STARTING server instance 127.0.0.1:11221 [junit] 2017-05-22 05:08:47,225 [myid:] - INFO [main:ZooKeeperServer@173] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build/test/tmp/test2202386753197324785.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build/test/tmp/test2202386753197324785.junit.dir/version-2 [junit] 2017-05-22 05:08:47,228 [myid:] - ERROR [main:ZooKeeperServer@468] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-05-22 05:08:47,229 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2017-05-22 05:08:47,229 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - Accepted socket connection from /127.0.0.1:59023 [junit] 2017-05-22 05:08:47,229 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@883] - Processing stat command from /127.0.0.1:59023 [junit] 2017-05-22 05:08:47,230 [myid:] - INFO [Thread-4:NIOServerCnxn$StatCommand@674] - Stat command output [junit] 2017-05-22 05:08:47,230 [myid:] - INFO [Thread-4:NIOServerCnxn@1044] - Closed socket connection for client /127.0.0.1:59023 (no session established for client) [junit] 2017-05-22 05:08:47,230 [myid:] - INFO [main:JMXEnv@230] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2017-05-22 05:08:47,232 [myid:] - INFO [main:JMXEnv@247] - expect:InMemoryDataTree [junit] 2017-05-22 05:08:47,233 [myid:] - INFO [main:JMXEnv@251] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2017-05-22 05:08:47,233 [myid:] - INFO [main:JMXEnv@247] - expect:StandaloneServer_port [junit] 2017-05-22 05:08:47,233 [myid:] - INFO [main:JMXEnv@251] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2017-05-22 05:08:47,233 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 35535 [junit] 2017-05-22 05:08:47,233 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2017-05-22 05:08:47,234 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2017-05-22 05:08:47,234 [myid:] - INFO [main:ClientBase@547] - tearDown starting [junit] 2017-05-22 05:08:47,306 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x101f4aca600 closed [junit] 2017-05-22 05:08:47,306 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for session: 0x101f4aca600 [junit] 2017-05-22 05:08:47,307 [myid:] - INFO [main:ClientBase@517] - STOPPING server [junit] 2017-05-22 05:08:47,307 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - NIOServerCnxn factory exited run method [junit] 2017-05-22 05:08:47,307 [myid:] - INFO [main:ZooKeeperServer@501] - shutting down [junit] 2017-05-22 05:08:47,308 [myid:] - ERROR [main:ZooKeeperServer@468] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or
[jira] [Resolved] (ZOOKEEPER-2732) Cleanup findbug warnings in branch-3.4: Performance Warnings
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R resolved ZOOKEEPER-2732.
-
Resolution: Fixed
Issue resolved by pull request 258
[https://github.com/apache/zookeeper/pull/258]
> Cleanup findbug warnings in branch-3.4: Performance Warnings
>
>
> Key: ZOOKEEPER-2732
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2732
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Rakesh R
>Assignee: Abraham Fine
> Fix For: 3.4.11
>
>
> Please refer the attached sheet in parent jira. Below is the details of
> findbug warnings.
> {code}
> BxBoxing/unboxing to parse a primitive new
> org.apache.zookeeper.server.quorum.QuorumCnxManager(long, Map,
> QuorumAuthServer, QuorumAuthLearner, int, boolean, int, boolean)
> Bxnew org.apache.zookeeper.server.quorum.QuorumCnxManager(long, Map,
> QuorumAuthServer, QuorumAuthLearner, int, boolean, int, boolean) invokes
> inefficient new Integer(String) constructor; use Integer.valueOf(String)
> instead
> Dm
> org.apache.zookeeper.server.quorum.FastLeaderElection$Notification.toString()
> invokes inefficient new String(String) constructor
> WMI org.apache.zookeeper.server.DataTree.dumpEphemerals(PrintWriter) makes
> inefficient use of keySet iterator instead of entrySet iterator
> WMI
> org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.computeGroupWeight()
> makes inefficient use of keySet iterator instead of entrySet iterator
> WMI
> org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.containsQuorum(HashSet)
> makes inefficient use of keySet iterator instead of entrySet iterator
> WMI org.apache.zookeeper.ZooKeeperMain.usage() makes inefficient use of
> keySet iterator instead of entrySet iterator
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2732) Cleanup findbug warnings in branch-3.4: Performance Warnings
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019129#comment-16019129
]
ASF GitHub Bot commented on ZOOKEEPER-2732:
---
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/258
+1 LGTM, Thanks @afine for the contribution.
> Cleanup findbug warnings in branch-3.4: Performance Warnings
>
>
> Key: ZOOKEEPER-2732
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2732
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Rakesh R
>Assignee: Abraham Fine
> Fix For: 3.4.11
>
>
> Please refer the attached sheet in parent jira. Below is the details of
> findbug warnings.
> {code}
> BxBoxing/unboxing to parse a primitive new
> org.apache.zookeeper.server.quorum.QuorumCnxManager(long, Map,
> QuorumAuthServer, QuorumAuthLearner, int, boolean, int, boolean)
> Bxnew org.apache.zookeeper.server.quorum.QuorumCnxManager(long, Map,
> QuorumAuthServer, QuorumAuthLearner, int, boolean, int, boolean) invokes
> inefficient new Integer(String) constructor; use Integer.valueOf(String)
> instead
> Dm
> org.apache.zookeeper.server.quorum.FastLeaderElection$Notification.toString()
> invokes inefficient new String(String) constructor
> WMI org.apache.zookeeper.server.DataTree.dumpEphemerals(PrintWriter) makes
> inefficient use of keySet iterator instead of entrySet iterator
> WMI
> org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.computeGroupWeight()
> makes inefficient use of keySet iterator instead of entrySet iterator
> WMI
> org.apache.zookeeper.server.quorum.flexible.QuorumHierarchical.containsQuorum(HashSet)
> makes inefficient use of keySet iterator instead of entrySet iterator
> WMI org.apache.zookeeper.ZooKeeperMain.usage() makes inefficient use of
> keySet iterator instead of entrySet iterator
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] zookeeper issue #258: ZOOKEEPER-2732: Cleanup findbug warnings in branch-3.4...
Github user rakeshadr commented on the issue: https://github.com/apache/zookeeper/pull/258 +1 LGTM, Thanks @afine for the contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (ZOOKEEPER-2731) Cleanup findbug warnings in branch-3.4: Malicious code vulnerability Warnings
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019125#comment-16019125
]
ASF GitHub Bot commented on ZOOKEEPER-2731:
---
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/232#discussion_r117658709
--- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
@@ -96,21 +97,20 @@
/**
* This is a completely open ACL .
*/
-public final ArrayList OPEN_ACL_UNSAFE = new ArrayList(
-Collections.singletonList(new ACL(Perms.ALL,
ANYONE_ID_UNSAFE)));
+public final List OPEN_ACL_UNSAFE =
--- End diff --
@afine , Its touching an exposed API and changing to List will impact b/w
compatibility. Could you please follow the branch-3.5 fix like adding an
exclude entry in `findbugsExcludeFile.xml`,
```
```
API doc referenece http://zookeeper.apache.org/doc/r3.4.10/api/
Also, please read the discussions in
https://issues.apache.org/jira/browse/ZOOKEEPER-1362
> Cleanup findbug warnings in branch-3.4: Malicious code vulnerability Warnings
> -
>
> Key: ZOOKEEPER-2731
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2731
> Project: ZooKeeper
> Issue Type: Sub-task
>Affects Versions: 3.4.9
>Reporter: Rakesh R
>Assignee: Abraham Fine
> Fix For: 3.4.11
>
>
> Please refer the attached sheet in parent jira. Below is the details of
> findbug warnings.
> {code}
> MSorg.apache.zookeeper.Environment.JAAS_CONF_KEY isn't final but should be
> Bug type MS_SHOULD_BE_FINAL (click for details)
> In class org.apache.zookeeper.Environment
> Field org.apache.zookeeper.Environment.JAAS_CONF_KEY
> At Environment.java:[line 34]
> MSorg.apache.zookeeper.server.ServerCnxn.cmd2String is a mutable
> collection which should be package protected
> Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details)
> In class org.apache.zookeeper.server.ServerCnxn
> Field org.apache.zookeeper.server.ServerCnxn.cmd2String
> At ServerCnxn.java:[line 230]
> MSorg.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE is a mutable collection
> Bug type MS_MUTABLE_COLLECTION (click for details)
> In class org.apache.zookeeper.ZooDefs$Ids
> Field org.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE
> At ZooDefs.java:[line 100]
> MSorg.apache.zookeeper.ZooKeeperMain.commandMap is a mutable collection
> which should be package protected
> Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details)
> In class org.apache.zookeeper.ZooKeeperMain
> Field org.apache.zookeeper.ZooKeeperMain.commandMap
> At ZooKeeperMain.java:[line 53]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2731) Cleanup findbug warnings in branch-3.4: Malicious code vulnerability Warnings
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019126#comment-16019126
]
ASF GitHub Bot commented on ZOOKEEPER-2731:
---
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/232#discussion_r117658774
--- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
@@ -96,21 +97,20 @@
/**
* This is a completely open ACL .
*/
-public final ArrayList OPEN_ACL_UNSAFE = new ArrayList(
-Collections.singletonList(new ACL(Perms.ALL,
ANYONE_ID_UNSAFE)));
+public final List OPEN_ACL_UNSAFE =
+Collections.singletonList(new ACL(Perms.ALL,
ANYONE_ID_UNSAFE));
/**
* This ACL gives the creators authentication id's all permissions.
*/
-public final ArrayList CREATOR_ALL_ACL = new ArrayList(
-Collections.singletonList(new ACL(Perms.ALL, AUTH_IDS)));
+public final List CREATOR_ALL_ACL =
--- End diff --
Same as above, typically we won't modify the exposed APIs in 3.4.*
releases. Its OK to exclude this case as well.
> Cleanup findbug warnings in branch-3.4: Malicious code vulnerability Warnings
> -
>
> Key: ZOOKEEPER-2731
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2731
> Project: ZooKeeper
> Issue Type: Sub-task
>Affects Versions: 3.4.9
>Reporter: Rakesh R
>Assignee: Abraham Fine
> Fix For: 3.4.11
>
>
> Please refer the attached sheet in parent jira. Below is the details of
> findbug warnings.
> {code}
> MSorg.apache.zookeeper.Environment.JAAS_CONF_KEY isn't final but should be
> Bug type MS_SHOULD_BE_FINAL (click for details)
> In class org.apache.zookeeper.Environment
> Field org.apache.zookeeper.Environment.JAAS_CONF_KEY
> At Environment.java:[line 34]
> MSorg.apache.zookeeper.server.ServerCnxn.cmd2String is a mutable
> collection which should be package protected
> Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details)
> In class org.apache.zookeeper.server.ServerCnxn
> Field org.apache.zookeeper.server.ServerCnxn.cmd2String
> At ServerCnxn.java:[line 230]
> MSorg.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE is a mutable collection
> Bug type MS_MUTABLE_COLLECTION (click for details)
> In class org.apache.zookeeper.ZooDefs$Ids
> Field org.apache.zookeeper.ZooDefs$Ids.OPEN_ACL_UNSAFE
> At ZooDefs.java:[line 100]
> MSorg.apache.zookeeper.ZooKeeperMain.commandMap is a mutable collection
> which should be package protected
> Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details)
> In class org.apache.zookeeper.ZooKeeperMain
> Field org.apache.zookeeper.ZooKeeperMain.commandMap
> At ZooKeeperMain.java:[line 53]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r117658709 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -96,21 +97,20 @@ /** * This is a completely open ACL . */ -public final ArrayList OPEN_ACL_UNSAFE = new ArrayList( -Collections.singletonList(new ACL(Perms.ALL, ANYONE_ID_UNSAFE))); +public final List OPEN_ACL_UNSAFE = --- End diff -- @afine , Its touching an exposed API and changing to List will impact b/w compatibility. Could you please follow the branch-3.5 fix like adding an exclude entry in `findbugsExcludeFile.xml`, ``` ``` API doc referenece http://zookeeper.apache.org/doc/r3.4.10/api/ Also, please read the discussions in https://issues.apache.org/jira/browse/ZOOKEEPER-1362 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r117658774 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -96,21 +97,20 @@ /** * This is a completely open ACL . */ -public final ArrayList OPEN_ACL_UNSAFE = new ArrayList( -Collections.singletonList(new ACL(Perms.ALL, ANYONE_ID_UNSAFE))); +public final List OPEN_ACL_UNSAFE = +Collections.singletonList(new ACL(Perms.ALL, ANYONE_ID_UNSAFE)); /** * This ACL gives the creators authentication id's all permissions. */ -public final ArrayList CREATOR_ALL_ACL = new ArrayList( -Collections.singletonList(new ACL(Perms.ALL, AUTH_IDS))); +public final List CREATOR_ALL_ACL = --- End diff -- Same as above, typically we won't modify the exposed APIs in 3.4.* releases. Its OK to exclude this case as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
ZooKeeper_branch34_jdk7 - Build # 1520 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1520/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 30.21 MB...] [junit] 2017-05-22 02:53:30,720 [myid:] - INFO [main:PrepRequestProcessor@766] - Shutting down [junit] 2017-05-22 02:53:30,720 [myid:] - INFO [main:SyncRequestProcessor@208] - Shutting down [junit] 2017-05-22 02:53:30,721 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@144] - PrepRequestProcessor exited loop! [junit] 2017-05-22 02:53:30,721 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited! [junit] 2017-05-22 02:53:30,721 [myid:] - INFO [main:FinalRequestProcessor@403] - shutdown of request processor complete [junit] 2017-05-22 02:53:30,722 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2017-05-22 02:53:30,723 [myid:] - INFO [main:JMXEnv@147] - ensureOnly:[] [junit] 2017-05-22 02:53:30,724 [myid:] - INFO [main:ClientBase@470] - STARTING server [junit] 2017-05-22 02:53:30,725 [myid:] - INFO [main:ClientBase@391] - CREATING server instance 127.0.0.1:11221 [junit] 2017-05-22 02:53:30,725 [myid:] - INFO [main:ServerCnxnFactory@111] - Using org.apache.zookeeper.server.NIOServerCnxnFactory as server connection factory [junit] 2017-05-22 02:53:30,725 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2017-05-22 02:53:30,726 [myid:] - INFO [main:ClientBase@366] - STARTING server instance 127.0.0.1:11221 [junit] 2017-05-22 02:53:30,726 [myid:] - INFO [main:ZooKeeperServer@173] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build/test/tmp/test6950876265162131847.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build/test/tmp/test6950876265162131847.junit.dir/version-2 [junit] 2017-05-22 02:53:30,730 [myid:] - ERROR [main:ZooKeeperServer@468] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-05-22 02:53:30,730 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2017-05-22 02:53:30,731 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - Accepted socket connection from /127.0.0.1:49608 [junit] 2017-05-22 02:53:30,732 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@883] - Processing stat command from /127.0.0.1:49608 [junit] 2017-05-22 02:53:30,732 [myid:] - INFO [Thread-4:NIOServerCnxn$StatCommand@674] - Stat command output [junit] 2017-05-22 02:53:30,733 [myid:] - INFO [Thread-4:NIOServerCnxn@1044] - Closed socket connection for client /127.0.0.1:49608 (no session established for client) [junit] 2017-05-22 02:53:30,733 [myid:] - INFO [main:JMXEnv@230] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2017-05-22 02:53:30,735 [myid:] - INFO [main:JMXEnv@247] - expect:InMemoryDataTree [junit] 2017-05-22 02:53:30,735 [myid:] - INFO [main:JMXEnv@251] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2017-05-22 02:53:30,736 [myid:] - INFO [main:JMXEnv@247] - expect:StandaloneServer_port [junit] 2017-05-22 02:53:30,736 [myid:] - INFO [main:JMXEnv@251] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2017-05-22 02:53:30,736 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 35688 [junit] 2017-05-22 02:53:30,736 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2017-05-22 02:53:30,737 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2017-05-22 02:53:30,737 [myid:] - INFO [main:ClientBase@547] - tearDown starting [junit] 2017-05-22 02:53:30,800 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x10085805de0 closed [junit] 2017-05-22 02:53:30,800 [myid:] - INFO [main:ClientBase@517] - STOPPING server [junit] 2017-05-22 02:53:30,801 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for session: 0x10085805de0 [junit] 2017-05-22 02:53:30,801 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - NIOServerCnxn factory exited run method [junit] 2017-05-22 02:53:30,801 [myid:] - INFO [main:ZooKeeperServer@501] - shutting down [junit] 2017-05-22 02:53:30,801 [myid:] - ERROR [main:ZooKeeperServer@468] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR
[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019085#comment-16019085 ] Hadoop QA commented on ZOOKEEPER-2784: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/726//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/726//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/726//console This message is automatically generated. > Add some limitations on code level for `SID` to avoid configuration problem > --- > > Key: ZOOKEEPER-2784 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2784 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.5.2 >Reporter: Benedict Jin > Fix For: 3.6.0 > > Original Estimate: 168h > Remaining Estimate: 168h > > As so far, `QuorumCnxManager#receiveConnection` cannot find out the same > `SID` problem, then the Zookeeper cluster will start successfully. But the > cluster is not health, and it will throw some problem like `not > synchronized`. So, i thought we should add some limitations on code level for > `SID` to find those configuration problem more early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Success: ZOOKEEPER- PreCommit Build #726
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/726/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 69.78 MB...] [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/726//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/726//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/726//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 1655a26ad9d4461a3a3a1188f08be43e246dd5e7 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 21 minutes 41 seconds Archiving artifacts Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Recording test results Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 [description-setter] Description set: ZOOKEEPER-2784 Putting comment on the pull request Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
ZooKeeper-trunk - Build # 3398 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk/3398/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.82 MB...] [junit] 2017-05-21 23:31:39,748 [myid:] - INFO [ProcessThread(sid:0 cport:21997)::PrepRequestProcessor@617] - Processed session termination for sessionid: 0x101fa038870 [junit] 2017-05-21 23:31:39,755 [myid:] - INFO [main:ZooKeeper@1329] - Session: 0x101fa038870 closed [junit] 2017-05-21 23:31:39,755 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x101fa038870 [junit] 2017-05-21 23:31:39,755 [myid:] - INFO [NIOWorkerThread-17:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port21997,name1=Connections,name2=127.0.0.1,name3=0x101fa038870] [junit] 2017-05-21 23:31:39,756 [myid:] - INFO [ProcessThread(sid:0 cport:21997)::PrepRequestProcessor@617] - Processed session termination for sessionid: 0x101fa038871 [junit] 2017-05-21 23:31:39,757 [myid:] - INFO [NIOWorkerThread-17:NIOServerCnxn@627] - Closed socket connection for client /127.0.0.1:57445 which had sessionid 0x101fa038870 [junit] 2017-05-21 23:31:39,763 [myid:] - INFO [main:ZooKeeper@1329] - Session: 0x101fa038871 closed [junit] 2017-05-21 23:31:39,763 [myid:] - INFO [NIOWorkerThread-32:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port21997,name1=Connections,name2=127.0.0.1,name3=0x101fa038871] [junit] 2017-05-21 23:31:39,763 [myid:] - INFO [main:ClientBase@552] - STOPPING server [junit] 2017-05-21 23:31:39,763 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x101fa038871 [junit] 2017-05-21 23:31:39,764 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2017-05-21 23:31:39,764 [myid:] - INFO [NIOWorkerThread-32:NIOServerCnxn@627] - Closed socket connection for client /127.0.0.1:57446 which had sessionid 0x101fa038871 [junit] 2017-05-21 23:31:39,766 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:21997:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2017-05-21 23:31:39,769 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2017-05-21 23:31:39,770 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2017-05-21 23:31:39,773 [myid:] - INFO [main:ZooKeeperServer@542] - shutting down [junit] 2017-05-21 23:31:39,774 [myid:] - ERROR [main:ZooKeeperServer@506] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-05-21 23:31:39,774 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2017-05-21 23:31:39,774 [myid:] - INFO [main:PrepRequestProcessor@1008] - Shutting down [junit] 2017-05-21 23:31:39,774 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2017-05-21 23:31:39,774 [myid:] - INFO [ProcessThread(sid:0 cport:21997)::PrepRequestProcessor@157] - PrepRequestProcessor exited loop! [junit] 2017-05-21 23:31:39,775 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2017-05-21 23:31:39,775 [myid:] - INFO [main:FinalRequestProcessor@481] - shutdown of request processor complete [junit] 2017-05-21 23:31:39,775 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port21997,name1=InMemoryDataTree] [junit] 2017-05-21 23:31:39,776 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port21997] [junit] 2017-05-21 23:31:39,776 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 21997 [junit] 2017-05-21 23:31:39,777 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2017-05-21 23:31:39,784 [myid:] - INFO [main:ClientBase@607] - fdcount after test is: 53 at start it was 53 [junit] 2017-05-21 23:31:39,784 [myid:] - INFO [main:ZKTestCase$1@68] - SUCCEEDED testManyChildWatchersAutoReset [junit] 2017-05-21 23:31:39,784 [myid:] - INFO [main:ZKTestCase$1@63] - FINISHED testManyChildWatchersAutoReset [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 662.107 sec, Thread: 5, Class: org.apache.zookeeper.test.DisconnectedWatcherTest [junit] Running org.apache.zookeeper.server.quorum.Zab1_0Test in thread 8 [junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec, Thread:
ZooKeeper-trunk-jdk8 - Build # 1055 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1055/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 60.82 MB...] [junit] 2017-05-21 11:56:24,764 [myid:] - INFO [New I/O worker #3453:ZooKeeperServer@1026] - Client attempting to renew session 0x103a44f10a6 at /127.0.0.1:36796 [junit] 2017-05-21 11:56:24,764 [myid:] - INFO [New I/O worker #3453:ZooKeeperServer@728] - Established session 0x103a44f10a6 with negotiated timeout 6000 for client /127.0.0.1:36796 [junit] 2017-05-21 11:56:24,764 [myid:127.0.0.1:16854] - INFO [main-SendThread(127.0.0.1:16854):ClientCnxn$SendThread@1381] - Session establishment complete on server 127.0.0.1/127.0.0.1:16854, sessionid = 0x103a44f10a6, negotiated timeout = 6000 [junit] 2017-05-21 11:56:24,769 [myid:] - INFO [SyncThread:0:FileTxnLog@206] - Creating new log file: log.7 [junit] 2017-05-21 11:56:25,383 [myid:127.0.0.1:16608] - INFO [main-SendThread(127.0.0.1:16608):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:16608. Will not attempt to authenticate using SASL (unknown error) [junit] 2017-05-21 11:56:25,384 [myid:127.0.0.1:16608] - WARN [main-SendThread(127.0.0.1:16608):ClientCnxn$SendThread@1235] - Session 0x103a447b0f1 for server 127.0.0.1/127.0.0.1:16608, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2017-05-21 11:56:25,779 [myid:] - INFO [ProcessThread(sid:0 cport:16854)::PrepRequestProcessor@617] - Processed session termination for sessionid: 0x103a44f10a6 [junit] 2017-05-21 11:56:25,782 [myid:] - INFO [SyncThread:0:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=Connections,name2=127.0.0.1,name3=0x103a44f10a6] [junit] 2017-05-21 11:56:25,782 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x103a44f10a6 [junit] 2017-05-21 11:56:25,782 [myid:] - INFO [main:ZooKeeper@1329] - Session: 0x103a44f10a6 closed [junit] 2017-05-21 11:56:25,783 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 86353 [junit] 2017-05-21 11:56:25,783 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 861 [junit] 2017-05-21 11:56:25,783 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2017-05-21 11:56:25,783 [myid:] - INFO [main:ClientBase@582] - tearDown starting [junit] 2017-05-21 11:56:25,783 [myid:] - INFO [main:ClientBase@552] - STOPPING server [junit] 2017-05-21 11:56:25,783 [myid:] - INFO [main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16854 [junit] 2017-05-21 11:56:25,784 [myid:] - INFO [main:ZooKeeperServer@542] - shutting down [junit] 2017-05-21 11:56:25,785 [myid:] - ERROR [main:ZooKeeperServer@506] - ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN server state changes [junit] 2017-05-21 11:56:25,785 [myid:] - INFO [main:SessionTrackerImpl@232] - Shutting down [junit] 2017-05-21 11:56:25,785 [myid:] - INFO [main:PrepRequestProcessor@1008] - Shutting down [junit] 2017-05-21 11:56:25,785 [myid:] - INFO [main:SyncRequestProcessor@191] - Shutting down [junit] 2017-05-21 11:56:25,785 [myid:] - INFO [ProcessThread(sid:0 cport:16854)::PrepRequestProcessor@157] - PrepRequestProcessor exited loop! [junit] 2017-05-21 11:56:25,785 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited! [junit] 2017-05-21 11:56:25,786 [myid:] - INFO [main:FinalRequestProcessor@481] - shutdown of request processor complete [junit] 2017-05-21 11:56:25,786 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=InMemoryDataTree] [junit] 2017-05-21 11:56:25,786 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854] [junit] 2017-05-21 11:56:25,786 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 16854 [junit] 2017-05-21 11:56:25,787 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2017-05-21 11:56:25,795 [myid:] - INFO [main:ClientBase@607] - fdcount after test is: 2541 at start it was
[jira] [Commented] (ZOOKEEPER-2691) recreateSocketAddresses may recreate the unreachable IP address
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018735#comment-16018735
]
JiangJiafu commented on ZOOKEEPER-2691:
---
Can this patch be merged?
> recreateSocketAddresses may recreate the unreachable IP address
> ---
>
> Key: ZOOKEEPER-2691
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2691
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2, 3.4.11
> Environment: Centos6.5
> Java8
> ZooKeeper3.4.8
>Reporter: JiangJiafu
>Priority: Minor
>
> The QuorumPeer$QuorumServer.recreateSocketAddress() is used to resolved the
> hostname to a new IP address(InetAddress) when any exception happens to the
> socket. It will be very useful when a hostname can be resolved to more than
> one IP address.
> But the problem is Java API InetAddress.getByName(String hostname) will
> always return the first IP address when the hostname can be resolved to more
> than one IP address, and the first IP address may be unreachable forever. For
> example, if a machine has two network interfaces: eth0, eth1, say eth0 has
> ip1, eth1 has ip2, the relationship between hostname and the IP addresses is
> set in /etc/hosts. When I "close" the eth0 by command "ifdown eth0", the
> InetAddress.getByName(String hostname) will still return ip1, which is
> unreachable forever.
> So I think it will be better to check the IP address by
> InetAddress.isReachable(long) and choose the reachable IP address.
> I have modified the ZooKeeper source code, and test the new code in my own
> environment, and it can work very well when I turn down some network
> interfaces using "ifdown" command.
> The original code is:
> {code:title=QuorumPeer.java|borderStyle=solid}
> public void recreateSocketAddresses() {
> InetAddress address = null;
> try {
> address = InetAddress.getByName(this.hostname);
> LOG.info("Resolved hostname: {} to address: {}",
> this.hostname, address);
> this.addr = new InetSocketAddress(address, this.port);
> if (this.electionPort > 0){
> this.electionAddr = new InetSocketAddress(address,
> this.electionPort);
> }
> } catch (UnknownHostException ex) {
> LOG.warn("Failed to resolve address: {}", this.hostname, ex);
> // Have we succeeded in the past?
> if (this.addr != null) {
> // Yes, previously the lookup succeeded. Leave things as
> they are
> return;
> }
> // The hostname has never resolved. Create our
> InetSocketAddress(es) as unresolved
> this.addr = InetSocketAddress.createUnresolved(this.hostname,
> this.port);
> if (this.electionPort > 0){
> this.electionAddr =
> InetSocketAddress.createUnresolved(this.hostname,
>
> this.electionPort);
> }
> }
> }
> {code}
> After my modification:
> {code:title=QuorumPeer.java|borderStyle=solid}
> public void recreateSocketAddresses() {
> InetAddress address = null;
> try {
> address = getReachableAddress(this.hostname);
> LOG.info("Resolved hostname: {} to address: {}",
> this.hostname, address);
> this.addr = new InetSocketAddress(address, this.port);
> if (this.electionPort > 0){
> this.electionAddr = new InetSocketAddress(address,
> this.electionPort);
> }
> } catch (UnknownHostException ex) {
> LOG.warn("Failed to resolve address: {}", this.hostname, ex);
> // Have we succeeded in the past?
> if (this.addr != null) {
> // Yes, previously the lookup succeeded. Leave things as
> they are
> return;
> }
> // The hostname has never resolved. Create our
> InetSocketAddress(es) as unresolved
> this.addr = InetSocketAddress.createUnresolved(this.hostname,
> this.port);
> if (this.electionPort > 0){
> this.electionAddr =
> InetSocketAddress.createUnresolved(this.hostname,
>
> this.electionPort);
> }
> }
> }
> public InetAddress getReachableAddress(String hostname) throws
> UnknownHostException {
> InetAddress[] addresses = InetAddress.getAllByName(hostname);
> for (InetAddress
[jira] [Created] (ZOOKEEPER-2788) The define of MAX_CONNECTION_ATTEMPTS in QuorumCnxManager.java seems useless, should it be removed?
JiangJiafu created ZOOKEEPER-2788: - Summary: The define of MAX_CONNECTION_ATTEMPTS in QuorumCnxManager.java seems useless, should it be removed? Key: ZOOKEEPER-2788 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2788 Project: ZooKeeper Issue Type: Improvement Components: leaderElection, quorum Affects Versions: 3.4.10, 3.4.11 Reporter: JiangJiafu Priority: Minor The define of MAX_CONNECTION_ATTEMPTS in QuorumCnxManager.java seems useless, should it be removed? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
