date:20171212

Failed: ZOOKEEPER- PreCommit Build #1348

2017-12-12 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1348/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 37.56 KB...]
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1348//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1348//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1348//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] a728c3623dab04726f00bff4c5b0066be6e7c740 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1722:
 exec returned: 1

Total time: 2 minutes 49 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 594.41 KB of artifacts by 21.5% relative to #1341
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2953
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #1347

2017-12-12 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1347/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 2.88 MB...]
 [exec] +1 tests included.  The patch appears to include 9 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1347//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1347//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1347//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file
 [exec] b42961373cfef266ce4c2ec61e14b542b77663e4 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1778:
 exec returned: 2

Total time: 8 minutes 41 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2953
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288838#comment-16288838
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2953:
---

GitHub user afine reopened a pull request:

https://github.com/apache/zookeeper/pull/432

[WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2953

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #432


commit 68a0382093da1d64583211746ac672ed12f5da5c
Author: Abraham Fine 
Date:   2017-12-13T00:35:50Z

ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment




> Flaky Test: testNoLogBeforeLeaderEstablishment
> --
>
> Key: ZOOKEEPER-2953
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2953
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288837#comment-16288837
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2953:
---

Github user afine closed the pull request at:

https://github.com/apache/zookeeper/pull/432


> Flaky Test: testNoLogBeforeLeaderEstablishment
> --
>
> Key: ZOOKEEPER-2953
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2953
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-12 Thread afine

Github user afine closed the pull request at:

https://github.com/apache/zookeeper/pull/432


---

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-12 Thread afine

GitHub user afine reopened a pull request:

https://github.com/apache/zookeeper/pull/432

[WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2953

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #432


commit 68a0382093da1d64583211746ac672ed12f5da5c
Author: Abraham Fine 
Date:   2017-12-13T00:35:50Z

ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment




---

Failed: ZOOKEEPER- PreCommit Build #1346

2017-12-12 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1346/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 33.75 KB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] -1 javac.  The patch appears to cause tar ant target to fail.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1346//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1346//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1346//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] b4c7d3190273c74fdce3aeb282e8e79c15cff7fa logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1722:
 exec returned: 2

Total time: 2 minutes 54 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[Fast Archiver] Compressed 573.78 KB of artifacts by 22.3% relative to #1341
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2950
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch34_jdk7 - Build # 1757 - Failure

2017-12-12 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1757/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 38.12 KB...]
[junit] Running org.apache.zookeeper.test.RecoveryTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
29.467 sec
[junit] Running org.apache.zookeeper.test.RepeatStartupTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.819 sec
[junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.357 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.295 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.407 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.779 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.132 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.315 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.292 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.158 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.524 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
34.959 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.998 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.199 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.375 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.358 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.015 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.913 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.251 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
4.843 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
33.086 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.118 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.494 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build.xml:1382: 
The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build.xml:1385: 
Tests failed!

Total time: 33 minutes 31 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalFollowerRunWithDiff

Error Message:
null

Stack Trace:
java.io.EOFException
at java.io.DataInputStream.readInt(DataInputStream.java:392)
at 
org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63)
at 
org.apache.zookeeper.server.persistence.FileHeader.deserialize(FileHeader.java:66)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.inStreamCreated(FileTxnLog.java:589)
at

Failed: ZOOKEEPER- PreCommit Build #1344

2017-12-12 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1344/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 39.06 MB...]
 [exec] +1 tests included.  The patch appears to include 9 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1344//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1344//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1344//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] 09e1f8581bbd39eb1a9984c3b2142afbd401c866 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1778:
 exec returned: 1

Total time: 31 minutes 58 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2953
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testElectionFraud

Error Message:
falseLeader never attempts to become leader

Stack Trace:
junit.framework.AssertionFailedError: falseLeader never attempts to become 
leader
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testElectionFraud(QuorumPeerMainTest.java:427)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

Failed: ZOOKEEPER- PreCommit Build #1342

2017-12-12 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1342/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 6.25 KB...]
 [exec]   % Total% Received % Xferd  Average Speed   TimeTime 
Time  CurrentPull request id: 432
 [exec] 
 [exec]  Dload  Upload   Total   Spent
Left  SpeedPull request title: [WIP] ZOOKEEPER-2953: Flaky Test: 
testNoLogBeforeLeaderEstablishment
 [exec] 
 [exec] 
 [exec] Defect number: 
 [exec] - Parsed args, going to checkout -
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for pull request 432.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0100   1410   1410 0860  0 --:--:-- --:--:-- 
--:--:--   865
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Pre-build trunk to verify trunk stability and javac warnings
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant  
-Djavac.args=-Xlint -Xmaxwarns 1000 
-Djava5.home=/home/jenkins/tools/java5/latest 
-Dforrest.home=/home/jenkins/tools/forrest/latest -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0  0 00 174530 0  41149  0 --:--:-- --:--:-- 
--:--:-- 4260kmv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1722:
 exec returned: 1

Total time: 4 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2953
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #1343

2017-12-12 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1343/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 6.28 KB...]
 [exec]   % Total% Received % Xferd  Average Speed   TimeTime 
Time  CurrentPull request id: 433
 [exec] 
 [exec]  Dload  Upload   Total   Spent
Left  SpeedPull request title: ZOOKEEPER-2953: Flaky Test: 
testNoLogBeforeLeaderEstablishment
 [exec] 
 [exec] 
 [exec] Defect number: ZOOKEEPER-2953
 [exec] - Parsed args, going to checkout -
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for pull request 433.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0100   1410   1410 0761  0 --:--:-- --:--:-- 
--:--:--   762
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Pre-build trunk to verify trunk stability and javac warnings
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant  
-Djavac.args=-Xlint -Xmaxwarns 1000 
-Djava5.home=/home/jenkins/tools/java5/latest 
-Dforrest.home=/home/jenkins/tools/forrest/latest -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0  0 00 148830 0  33256  0 --:--:-- --:--:-- 
--:--:-- 3633kmv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 are the same file
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1722:
 exec returned: 1

Total time: 4 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2953
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] zookeeper pull request #434: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-12 Thread afine

GitHub user afine opened a pull request:

https://github.com/apache/zookeeper/pull/434

[WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2953_3.4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #434


commit 4834ba25b9b0a9f0448675f96ca402120833f54e
Author: Abraham Fine 
Date:   2017-12-13T01:10:21Z

ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment




---

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288563#comment-16288563
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2953:
---

GitHub user afine opened a pull request:

https://github.com/apache/zookeeper/pull/433

ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2953_3.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/433.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #433


commit 36abecd0d4389b24e22852cccac50259b2abdb1a
Author: Abraham Fine 
Date:   2017-12-13T00:51:52Z

ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment




> Flaky Test: testNoLogBeforeLeaderEstablishment
> --
>
> Key: ZOOKEEPER-2953
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2953
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288562#comment-16288562
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2953:
---

GitHub user afine opened a pull request:

https://github.com/apache/zookeeper/pull/432

[WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2953

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #432


commit 68a0382093da1d64583211746ac672ed12f5da5c
Author: Abraham Fine 
Date:   2017-12-13T00:35:50Z

ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment




> Flaky Test: testNoLogBeforeLeaderEstablishment
> --
>
> Key: ZOOKEEPER-2953
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2953
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #433: ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLead...

2017-12-12 Thread afine

GitHub user afine opened a pull request:

https://github.com/apache/zookeeper/pull/433

ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2953_3.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/433.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #433


commit 36abecd0d4389b24e22852cccac50259b2abdb1a
Author: Abraham Fine 
Date:   2017-12-13T00:51:52Z

ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment




---

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-12 Thread afine

GitHub user afine opened a pull request:

https://github.com/apache/zookeeper/pull/432

[WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2953

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #432


commit 68a0382093da1d64583211746ac672ed12f5da5c
Author: Abraham Fine 
Date:   2017-12-13T00:35:50Z

ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstablishment




---

[jira] [Created] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-12 Thread Abraham Fine (JIRA)

Abraham Fine created ZOOKEEPER-2953:
---

 Summary: Flaky Test: testNoLogBeforeLeaderEstablishment
 Key: ZOOKEEPER-2953
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2953
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.11, 3.5.3, 3.6.0
Reporter: Abraham Fine
Assignee: Abraham Fine






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ZooKeeper_branch35_openjdk7 - Build # 776 - Failure

2017-12-12 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/776/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 120.09 KB...]
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
31.599 sec, Thread: 5, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.134 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
6
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.105 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
37.561 sec, Thread: 1, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 6
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.577 sec, Thread: 1, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.171 sec, Thread: 1, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 1
[junit] Tests run: 15, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
136.292 sec, Thread: 8, Class: org.apache.zookeeper.test.QuorumTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.092 sec, Thread: 8, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 8
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.55 sec, Thread: 1, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.772 sec, Thread: 8, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 1
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 8
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.623 sec, Thread: 1, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.124 sec, Thread: 1, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
22.828 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.844 sec, Thread: 1, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 6
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.112 sec, Thread: 1, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.95 sec, Thread: 1, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
34.735 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.773 sec, Thread: 5, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
25.157 sec, Thread: 8, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
29.217 sec, Thread: 6, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
359.49 sec, Thread: 2, Class: org.apache.zookeeper.test.DisconnectedWatcherTest
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
418.418 sec, Thread: 4, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
419.427 sec, Thread: 3, Class:

ZooKeeper-trunk-openjdk7 - Build # 1730 - Still Failing

2017-12-12 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1730/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 61.15 KB...]
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.807 sec, Thread: 3, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.624 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
71.676 sec, Thread: 6, Class: org.apache.zookeeper.test.QuorumZxidSyncTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.573 sec, Thread: 5, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
5
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.098 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 5
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 6
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.621 sec, Thread: 6, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 6
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.875 sec, Thread: 6, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 6
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.146 sec, Thread: 6, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.082 sec, Thread: 6, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.98 sec, Thread: 6, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 6
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.367 sec, Thread: 6, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 6
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
22.001 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.15 sec, Thread: 5, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 5
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.536 sec, Thread: 5, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 5
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
33.973 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.103 sec, Thread: 3, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 3
[junit] Tests run: 15, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
118.113 sec, Thread: 8, Class: org.apache.zookeeper.test.QuorumTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.196 sec, Thread: 8, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
22.145 sec, Thread: 6, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
10.161 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
28.916 sec, Thread: 5, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
271.936 sec, Thread: 7, Class: org.apache.zookeeper.test.ReconfigTest
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
383.06

Re: Documentation improvements proposal for ZK

2017-12-12 Thread Michael Han

+1, this looks great, thanks for doing this Pat!

On Wed, Dec 6, 2017 at 8:45 PM, Patrick Hunt  wrote:

> Hi folks. Now that we've gotten the website issues straightened out I
> looked back at ZOOKEEPER-925 with an eye toward simplifying our mechanics
> and make it easier for people to generate and maintain the docs.
>
> Given we're using Jekyll/Markdown successfully for the site I tried
> converting our current documentation (forrest/simpledocbook(xml)) into
> Markdown using the same tooling I had originally developed for 925. It went
> pretty smoothly, pretty much looks the same as the forrest generated site,
> but is much easier to work with:
>
> 1) markdown for the source doc format rather than xml
> 2) jekyll to generate the docs, same as the new site generation
>
> I also looked at modernizing and streamlining our process around docs, in
> particular:
>
> 1) src/docs contains the jekyll/markdown based source. Basically the same
> as before with forrest/sdb but much easier to work with. e.g. consistent
> with what folks are used to on github.
>
> 2) remove /docs from the source repository (git). Committers/contributors
> no longer need to worry about committing the generated docs into /docs.
> During active development we'd only be committing src/docs (the markdown)
> and not /docs (the generated docs). As part of a release we'd still
> generate a static copy of the docs and include in the release artifact, as
> well as including on the website. The primary difference here is that the
> docs on (git) branches would just be the source. Folks could checkout and
> generate the source docs at any time using jekyll. Note that this is also
> consistent with many other apache projects.
>
> I believe this would be a significant improvement to our current experience
> around documentation, please take a look at the following branch to get
> some insight:
>
> https://github.com/phunt/zookeeper/tree/jekyll-docs/src/docs
> Here you can see the original .xml files side-by-side with the markdown
> formatted docs, in a jekyll based environment. The markdown formatted files
> having been converted using a variant of the script attached to 925. It's
> 99% there - still a bit of hand editing necessary to address the corner
> cases (typically odd/broken formatting in the current doc). You can "jekyll
> build" same as the site (in src/docs) if you would like to see the
> generation process itself.
>
> If we go ahead with this we'd need to port this to our active branches -
> 3.4/3.5 and master. (the example branch I linked to is just master).
>
> Everyone please take a look and LMK if you have any concerns. Committers
> please +1 if you agree, comments otw.
>
> Regards,
>
> Patrick
>

[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288266#comment-16288266
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2338:
---

Github user fr0stbyte commented on the issue:

https://github.com/apache/zookeeper/pull/427
  
@phunt thanks, will keep that in mind.


> c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on 
> fork/exec
> --
>
> Key: ZOOKEEPER-2338
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2338
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: James DeFelice
>Assignee: Radu Brumariu
> Fix For: 3.5.4, 3.6.0
>
>
> I've observed socket FD leaks in Apache Mesos when using ZK to coordinate 
> master leadership: https://issues.apache.org/jira/browse/MESOS-4065



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper issue #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defin...

2017-12-12 Thread fr0stbyte

Github user fr0stbyte commented on the issue:

https://github.com/apache/zookeeper/pull/427
  
@phunt thanks, will keep that in mind.


---

[jira] [Commented] (ZOOKEEPER-2950) Add keys for the Zxid from the stat command to check_zookeeper.py

2017-12-12 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288146#comment-16288146
 ] 

Hudson commented on ZOOKEEPER-2950:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3653 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3653/])
ZOOKEEPER-2950: Add keys for the Zxid from the stat command to (phunt: rev 
9e30b9bf8fac56db3846c8cc42997cdc23a9358d)
* (edit) src/contrib/monitoring/check_zookeeper.py


> Add keys for the Zxid from the stat command to check_zookeeper.py
> -
>
> Key: ZOOKEEPER-2950
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2950
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Alex Bame
>Assignee: Alex Bame
>Priority: Trivial
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add keys for the zxid and its component pieces: epoch and transaction 
> counter. These are not reported by the 'mntr' command so they must be 
> obtained from 'stat'. The counter is useful for tracking transaction rates, 
> and epoch is useful for tracking leader churn.
> zk_zxid - the 64bit zxid from ZK
> zk_zxid_counter - the lower 32 bits, AKA the counter
> zk_zxid_epoch - the upper 32 bits, AKA the epoch



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2951) zkServer.cmd does not start when JAVA_HOME ends with a \

2017-12-12 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288145#comment-16288145
 ] 

Hudson commented on ZOOKEEPER-2951:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3653 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3653/])
ZOOKEEPER-2951: remove trailing \ from JAVA_HOME (phunt: rev 
dcfbe45241855f2caccf3848be2e66e7aa23aa96)
* (edit) bin/zkEnv.cmd


> zkServer.cmd does not start when JAVA_HOME ends with a \
> 
>
> Key: ZOOKEEPER-2951
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2951
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.11
> Environment: windows 7 (not tested on other windows versions+
>Reporter: Jorg Heymans
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> this is the output i get (apologies for the cut-off line endings)
> {noformat}
> C:\RC\Tools\zookeeper-3.4.11\bin>zkServer.cmd
> call "c:\RC\jdk\jdk1.8.0_121\"\bin\java 
> "-Dzookeeper.log.dir=C:\RC\Tools\zookeeper-3.4.11\bin\.." 
> "-Dzookeeper.root.logger=INFO,CONSOLE" -cp 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\build\classes;C:\RC\Tools\zookeeper-3.4.11\bin\..\build\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\*;C:\RC\Tools\zookeeper-
> 3.4.11\bin\..\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\conf" 
> org.apache.zookeeper.server.quorum.QuorumPeerMain 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\c
> onf\zoo.cfg"
> Usage: java [-options] class [args...]
>(to execute a class)
>or  java [-options] -jar jarfile [args...]
>(to execute a jar file)
> where options include:
> -d32  use a 32-bit data model if available
> -d64  use a 64-bit data model if available
> -server   to select the "server" VM
>   The default VM is server.
> -cp 
> -classpath 
>   A ; separated list of directories, JAR archives,
>   and ZIP archives to search for class files.
> -D=
>   set a system property
> -verbose:[class|gc|jni]
>   enable verbose output
> -version  print product version and exit
> -version:
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   require the specified version to run
> -showversion  print product version and continue
> -jre-restrict-search | -no-jre-restrict-search
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   include/exclude user private JREs in the version search
> -? -help  print this help message
> -Xprint help on non-standard options
> -ea[:...|:]
> -enableassertions[:...|:]
>   enable assertions with specified granularity
> -da[:...|:]
> -disableassertions[:...|:]
>   disable assertions with specified granularity
> -esa | -enablesystemassertions
>   enable system assertions
> -dsa | -disablesystemassertions
>   disable system assertions
> -agentlib:[=]
>   load native agent library , e.g. -agentlib:hprof
>   see also, -agentlib:jdwp=help and -agentlib:hprof=help
> -agentpath:[=]
>   load native agent library by full pathname
> -javaagent:[=]
>   load Java programming language agent, see 
> java.lang.instrument
> -splash:
>   show splash screen with specified image
> See http://www.oracle.com/technetwork/java/javase/documentation/index.html 
> for more details.
> endlocal
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288071#comment-16288071
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2338:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/427
  
@fr0stbyte in future I believe you need to update the commit message, that 
doesn't seem to be updated along with the PR description I'm afraid. (something 
to consider for future changes, I'll commit this as-is for now, esp as it 
matches what went into trunk...)


> c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on 
> fork/exec
> --
>
> Key: ZOOKEEPER-2338
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2338
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: James DeFelice
>Assignee: Radu Brumariu
> Fix For: 3.5.4, 3.6.0
>
>
> I've observed socket FD leaks in Apache Mesos when using ZK to coordinate 
> master leadership: https://issues.apache.org/jira/browse/MESOS-4065



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper issue #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defin...

2017-12-12 Thread phunt

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/427
  
@fr0stbyte in future I believe you need to update the commit message, that 
doesn't seem to be updated along with the PR description I'm afraid. (something 
to consider for future changes, I'll commit this as-is for now, esp as it 
matches what went into trunk...)


---

[jira] [Resolved] (ZOOKEEPER-2950) Add keys for the Zxid from the stat command to check_zookeeper.py

2017-12-12 Thread Patrick Hunt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-2950.
-
Resolution: Fixed

Issue resolved by pull request 425
[https://github.com/apache/zookeeper/pull/425]

> Add keys for the Zxid from the stat command to check_zookeeper.py
> -
>
> Key: ZOOKEEPER-2950
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2950
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Alex Bame
>Assignee: Alex Bame
>Priority: Trivial
> Fix For: 3.4.12, 3.6.0, 3.5.4
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Add keys for the zxid and its component pieces: epoch and transaction 
> counter. These are not reported by the 'mntr' command so they must be 
> obtained from 'stat'. The counter is useful for tracking transaction rates, 
> and epoch is useful for tracking leader churn.
> zk_zxid - the 64bit zxid from ZK
> zk_zxid_counter - the lower 32 bits, AKA the counter
> zk_zxid_epoch - the upper 32 bits, AKA the epoch



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper issue #425: Add keys for the Zxid from the stat command

2017-12-12 Thread phunt

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/425
  
lgtm - +1. Thanks @alexbb !


---

[GitHub] zookeeper pull request #425: Add keys for the Zxid from the stat command

2017-12-12 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/425


---

[GitHub] zookeeper issue #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defin...

2017-12-12 Thread fr0stbyte

Github user fr0stbyte commented on the issue:

https://github.com/apache/zookeeper/pull/427
  
@phunt @mfenes updated the initial comment of this PR. Let me know if you 
need me to move it into a separate comment


---

[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288045#comment-16288045
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2338:
---

Github user fr0stbyte commented on the issue:

https://github.com/apache/zookeeper/pull/427
  
@phunt @mfenes updated the initial comment of this PR. Let me know if you 
need me to move it into a separate comment


> c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on 
> fork/exec
> --
>
> Key: ZOOKEEPER-2338
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2338
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: James DeFelice
>Assignee: Radu Brumariu
> Fix For: 3.5.4, 3.6.0
>
>
> I've observed socket FD leaks in Apache Mesos when using ZK to coordinate 
> master leadership: https://issues.apache.org/jira/browse/MESOS-4065



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2951) zkServer.cmd does not start when JAVA_HOME ends with a \

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288037#comment-16288037
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2951:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/431


> zkServer.cmd does not start when JAVA_HOME ends with a \
> 
>
> Key: ZOOKEEPER-2951
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2951
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.11
> Environment: windows 7 (not tested on other windows versions+
>Reporter: Jorg Heymans
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> this is the output i get (apologies for the cut-off line endings)
> {noformat}
> C:\RC\Tools\zookeeper-3.4.11\bin>zkServer.cmd
> call "c:\RC\jdk\jdk1.8.0_121\"\bin\java 
> "-Dzookeeper.log.dir=C:\RC\Tools\zookeeper-3.4.11\bin\.." 
> "-Dzookeeper.root.logger=INFO,CONSOLE" -cp 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\build\classes;C:\RC\Tools\zookeeper-3.4.11\bin\..\build\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\*;C:\RC\Tools\zookeeper-
> 3.4.11\bin\..\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\conf" 
> org.apache.zookeeper.server.quorum.QuorumPeerMain 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\c
> onf\zoo.cfg"
> Usage: java [-options] class [args...]
>(to execute a class)
>or  java [-options] -jar jarfile [args...]
>(to execute a jar file)
> where options include:
> -d32  use a 32-bit data model if available
> -d64  use a 64-bit data model if available
> -server   to select the "server" VM
>   The default VM is server.
> -cp 
> -classpath 
>   A ; separated list of directories, JAR archives,
>   and ZIP archives to search for class files.
> -D=
>   set a system property
> -verbose:[class|gc|jni]
>   enable verbose output
> -version  print product version and exit
> -version:
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   require the specified version to run
> -showversion  print product version and continue
> -jre-restrict-search | -no-jre-restrict-search
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   include/exclude user private JREs in the version search
> -? -help  print this help message
> -Xprint help on non-standard options
> -ea[:...|:]
> -enableassertions[:...|:]
>   enable assertions with specified granularity
> -da[:...|:]
> -disableassertions[:...|:]
>   disable assertions with specified granularity
> -esa | -enablesystemassertions
>   enable system assertions
> -dsa | -disablesystemassertions
>   disable system assertions
> -agentlib:[=]
>   load native agent library , e.g. -agentlib:hprof
>   see also, -agentlib:jdwp=help and -agentlib:hprof=help
> -agentpath:[=]
>   load native agent library by full pathname
> -javaagent:[=]
>   load Java programming language agent, see 
> java.lang.instrument
> -splash:
>   show splash screen with specified image
> See http://www.oracle.com/technetwork/java/javase/documentation/index.html 
> for more details.
> endlocal
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (ZOOKEEPER-2951) zkServer.cmd does not start when JAVA_HOME ends with a \

2017-12-12 Thread Patrick Hunt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-2951.
-
   Resolution: Fixed
Fix Version/s: 3.5.4
   3.6.0
   3.4.12

Issue resolved by pull request 431
[https://github.com/apache/zookeeper/pull/431]

> zkServer.cmd does not start when JAVA_HOME ends with a \
> 
>
> Key: ZOOKEEPER-2951
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2951
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.11
> Environment: windows 7 (not tested on other windows versions+
>Reporter: Jorg Heymans
> Fix For: 3.4.12, 3.6.0, 3.5.4
>
>
> this is the output i get (apologies for the cut-off line endings)
> {noformat}
> C:\RC\Tools\zookeeper-3.4.11\bin>zkServer.cmd
> call "c:\RC\jdk\jdk1.8.0_121\"\bin\java 
> "-Dzookeeper.log.dir=C:\RC\Tools\zookeeper-3.4.11\bin\.." 
> "-Dzookeeper.root.logger=INFO,CONSOLE" -cp 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\build\classes;C:\RC\Tools\zookeeper-3.4.11\bin\..\build\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\*;C:\RC\Tools\zookeeper-
> 3.4.11\bin\..\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\conf" 
> org.apache.zookeeper.server.quorum.QuorumPeerMain 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\c
> onf\zoo.cfg"
> Usage: java [-options] class [args...]
>(to execute a class)
>or  java [-options] -jar jarfile [args...]
>(to execute a jar file)
> where options include:
> -d32  use a 32-bit data model if available
> -d64  use a 64-bit data model if available
> -server   to select the "server" VM
>   The default VM is server.
> -cp 
> -classpath 
>   A ; separated list of directories, JAR archives,
>   and ZIP archives to search for class files.
> -D=
>   set a system property
> -verbose:[class|gc|jni]
>   enable verbose output
> -version  print product version and exit
> -version:
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   require the specified version to run
> -showversion  print product version and continue
> -jre-restrict-search | -no-jre-restrict-search
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   include/exclude user private JREs in the version search
> -? -help  print this help message
> -Xprint help on non-standard options
> -ea[:...|:]
> -enableassertions[:...|:]
>   enable assertions with specified granularity
> -da[:...|:]
> -disableassertions[:...|:]
>   disable assertions with specified granularity
> -esa | -enablesystemassertions
>   enable system assertions
> -dsa | -disablesystemassertions
>   disable system assertions
> -agentlib:[=]
>   load native agent library , e.g. -agentlib:hprof
>   see also, -agentlib:jdwp=help and -agentlib:hprof=help
> -agentpath:[=]
>   load native agent library by full pathname
> -javaagent:[=]
>   load Java programming language agent, see 
> java.lang.instrument
> -splash:
>   show splash screen with specified image
> See http://www.oracle.com/technetwork/java/javase/documentation/index.html 
> for more details.
> endlocal
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper issue #431: ZOOKEEPER-2951 remove trailing \ from JAVA_HOME

2017-12-12 Thread phunt

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/431
  
LGTM - thanks @jorgheymans !


---

[jira] [Commented] (ZOOKEEPER-2951) zkServer.cmd does not start when JAVA_HOME ends with a \

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288039#comment-16288039
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2951:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/431
  
LGTM - thanks @jorgheymans !


> zkServer.cmd does not start when JAVA_HOME ends with a \
> 
>
> Key: ZOOKEEPER-2951
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2951
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.11
> Environment: windows 7 (not tested on other windows versions+
>Reporter: Jorg Heymans
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> this is the output i get (apologies for the cut-off line endings)
> {noformat}
> C:\RC\Tools\zookeeper-3.4.11\bin>zkServer.cmd
> call "c:\RC\jdk\jdk1.8.0_121\"\bin\java 
> "-Dzookeeper.log.dir=C:\RC\Tools\zookeeper-3.4.11\bin\.." 
> "-Dzookeeper.root.logger=INFO,CONSOLE" -cp 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\build\classes;C:\RC\Tools\zookeeper-3.4.11\bin\..\build\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\*;C:\RC\Tools\zookeeper-
> 3.4.11\bin\..\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\conf" 
> org.apache.zookeeper.server.quorum.QuorumPeerMain 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\c
> onf\zoo.cfg"
> Usage: java [-options] class [args...]
>(to execute a class)
>or  java [-options] -jar jarfile [args...]
>(to execute a jar file)
> where options include:
> -d32  use a 32-bit data model if available
> -d64  use a 64-bit data model if available
> -server   to select the "server" VM
>   The default VM is server.
> -cp 
> -classpath 
>   A ; separated list of directories, JAR archives,
>   and ZIP archives to search for class files.
> -D=
>   set a system property
> -verbose:[class|gc|jni]
>   enable verbose output
> -version  print product version and exit
> -version:
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   require the specified version to run
> -showversion  print product version and continue
> -jre-restrict-search | -no-jre-restrict-search
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   include/exclude user private JREs in the version search
> -? -help  print this help message
> -Xprint help on non-standard options
> -ea[:...|:]
> -enableassertions[:...|:]
>   enable assertions with specified granularity
> -da[:...|:]
> -disableassertions[:...|:]
>   disable assertions with specified granularity
> -esa | -enablesystemassertions
>   enable system assertions
> -dsa | -disablesystemassertions
>   disable system assertions
> -agentlib:[=]
>   load native agent library , e.g. -agentlib:hprof
>   see also, -agentlib:jdwp=help and -agentlib:hprof=help
> -agentpath:[=]
>   load native agent library by full pathname
> -javaagent:[=]
>   load Java programming language agent, see 
> java.lang.instrument
> -splash:
>   show splash screen with specified image
> See http://www.oracle.com/technetwork/java/javase/documentation/index.html 
> for more details.
> endlocal
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #431: ZOOKEEPER-2951 remove trailing \ from JAVA_HOME

2017-12-12 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/431


---

[jira] [Commented] (ZOOKEEPER-2789) Reassign `ZXID` for solving 32bit overflow problem

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288015#comment-16288015
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2789:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/262
  
Are you seeing this behavior with ZOOKEEPER-1277 applied? If so it's a bug 
in that change, because after that's applied the leader should shutdown as we 
approach the rollover.

It would be nice to address this by changing the zxid semantics, but I 
don't believe that's a great idea. Instead I would rather see us address any 
shortcoming in my original fix (1277)

fwiw - what I have seen people do in this situation is to monitor the zxid 
and when it gets close (say within 10%) of the rollover they have an automated 
script which restarts the leader, which forces a re-election. However 1277 
should be doing this for you.

Given you are seeing this issue perhaps you can help with resolving any 
bugs in 1277? thanks!




> Reassign `ZXID` for solving 32bit overflow problem
> --
>
> Key: ZOOKEEPER-2789
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2789
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.5.3
>Reporter: Benedict Jin
>Assignee: Benedict Jin
> Fix For: 3.6.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> If it is `1k/s` ops, then as long as $2^32 / (86400 * 1000) \approx 49.7$ 
> days ZXID will exhausted. But, if we reassign the `ZXID` into 16bit for 
> `epoch` and 48bit for `counter`, then the problem will not occur until after  
> $Math.min(2^16 / 365, 2^48 / (86400 * 1000 * 365)) \approx Math.min(179.6, 
> 8925.5) = 179.6$ years.
> However, i thought the ZXID is `long` type, reading and writing the long type 
> (and `double` type the same) in JVM, is divided into high 32bit and low 32bit 
> part of the operation, and because the `ZXID` variable is not  modified with 
> `volatile` and is not boxed for the corresponding reference type (`Long` / 
> `Double`), so it belongs to [non-atomic operation] 
> (https://docs.oracle.com/javase/specs/jls/se8 /html/jls-17.html#jls-17.7). 
> Thus, if the lower 32 bits of the upper 32 bits are divided into the entire 
> 32 bits of the `long`, there may be a concurrent problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper issue #262: ZOOKEEPER-2789: Reassign `ZXID` for solving 32bit over...

2017-12-12 Thread phunt

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/262
  
Are you seeing this behavior with ZOOKEEPER-1277 applied? If so it's a bug 
in that change, because after that's applied the leader should shutdown as we 
approach the rollover.

It would be nice to address this by changing the zxid semantics, but I 
don't believe that's a great idea. Instead I would rather see us address any 
shortcoming in my original fix (1277)

fwiw - what I have seen people do in this situation is to monitor the zxid 
and when it gets close (say within 10%) of the rollover they have an automated 
script which restarts the leader, which forces a re-election. However 1277 
should be doing this for you.

Given you are seeing this issue perhaps you can help with resolving any 
bugs in 1277? thanks!




---

[GitHub] zookeeper issue #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defin...

2017-12-12 Thread phunt

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/427
  
For this one I'm fine with the whitespace as it also got into the trunk/3.5 
commit.

It's unfortunate that github doesn't have an option to remove whitespace 
changes from the diff they show but you can get around this by diffing the 
commit locally. (which is what I typically do)

Agree with @mfenes 's comment - even though this is a backport it's still 
nice to have. 

Thanks @fr0stbyte !


---

[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288003#comment-16288003
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2924:
---

Github user anmolnar closed the pull request at:

https://github.com/apache/zookeeper/pull/409


> Flaky Test: 
> org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
> --
>
> Key: ZOOKEEPER-2924
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server, tests
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: flaky, flaky-test
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/
> Same issue happens in jdk8 and jdk9 builds as well.
> Issue has already been fixed by 
> https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the 
> root cause here is that test startup / cleanup code is included in the tests 
> instead of using try-finally block or Before-After methods.
> As a consequence, when exception happens during test execution, ZK test 
> server doesn't get shutdown properly and still listening on the port bound to 
> the test class.
> As mentioned above there could be 2 approaches to address this:
> #1 Wrap cleanup code block with finally
> #2 Use JUnit's Before-After methods for initialization and cleanup
> Test where original issue happens:
> {noformat}
> ...   
>  [junit] 2017-10-12 15:05:20,135 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,137 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,139 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,142 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,144 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:30,479 [myid:] - INFO  
> [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, 
> timeout of 6000ms exceeded
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:ping cxid:0xfffe 
> zxid:0xf$
>  [junit] 2017-10-12 15:05:24,147 [myid:] - WARN  
> [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client 
> session timed out, have not heard from server in 4002ms for sessionid 
> 0x104cd7b190c
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  
> [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client 
> session timed out, have not heard from server in 4002ms for sessionid 
> 0x104cd7b190c, closing socket connectio$
>  [junit] 2017-10-12 15:05:21,479 [myid:] - INFO  
> [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop!
>  [junit] 2017-10-12 15:05:32,998 [myid:] - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@376] - Unable to 
> read additional data from client sessionid 0x104cd7b190c, likely client 
> has closed socket
>  [junit] 2017-10-12 15:05:33,067 [myid:] - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1040] - Closed 
> socket connection for client /127.0.0.1:45735 which had sessionid 
> 0x104cd7b190c
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@487] - Processed session termination for 
> sessionid: 0x104cd7b190c
>  [junit] 2017-10-12 15:05:33,889 [myid:] - INFO  [main:ZooKeeper@687] - 
> Session: 0x104cd7b190c closed
>  [junit] 2017-10-12 15:05:33,890 [myid:] - INFO  
> [main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for 
> session: 0x104cd7b190c
>  [junit] 2017-10-12 15:05:33,891 [myid:] - INFO  
>

[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288006#comment-16288006
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2338:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/427
  
For this one I'm fine with the whitespace as it also got into the trunk/3.5 
commit.

It's unfortunate that github doesn't have an option to remove whitespace 
changes from the diff they show but you can get around this by diffing the 
commit locally. (which is what I typically do)

Agree with @mfenes 's comment - even though this is a backport it's still 
nice to have. 

Thanks @fr0stbyte !


> c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on 
> fork/exec
> --
>
> Key: ZOOKEEPER-2338
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2338
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: James DeFelice
>Assignee: Radu Brumariu
> Fix For: 3.5.4, 3.6.0
>
>
> I've observed socket FD leaks in Apache Mesos when using ZK to coordinate 
> master leadership: https://issues.apache.org/jira/browse/MESOS-4065



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTe...

2017-12-12 Thread anmolnar

Github user anmolnar closed the pull request at:

https://github.com/apache/zookeeper/pull/409


---

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287996#comment-16287996
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2952:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/429
  
@anmolnar looks like a good change to me - however src/java/lib/ needs to 
be updated to reflect this change. Also the patch doesn't apply to branch3.4, 
please submit a separate PR for that.


> Upgrade third party libraries to address vulnerabilities
> 
>
> Key: ZOOKEEPER-2952
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Critical
>  Labels: dependencies, upgrade, vulnerabilities
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> Hi,
> I'm going to upgrade the following third party libraries in order to address 
> vulnerabilities found in them:
> - io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), 
> CVE-2014-3488 (H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), 
> CVE-1999-1198 (H), CVE-1999-1193 (H))
> - org.slf4j:slf4j-api 1.7.5 -> 1.7.25
> Please review the list and let me know if you have any concerns or would like 
> to add more deps to upgrade.
> Thanks,
> Andor



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper issue #429: ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j

2017-12-12 Thread phunt

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/429
  
@anmolnar looks like a good change to me - however src/java/lib/ needs to 
be updated to reflect this change. Also the patch doesn't apply to branch3.4, 
please submit a separate PR for that.


---

[jira] [Updated] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-12 Thread Patrick Hunt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2952:

Fix Version/s: 3.6.0

> Upgrade third party libraries to address vulnerabilities
> 
>
> Key: ZOOKEEPER-2952
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Critical
>  Labels: dependencies, upgrade, vulnerabilities
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> Hi,
> I'm going to upgrade the following third party libraries in order to address 
> vulnerabilities found in them:
> - io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), 
> CVE-2014-3488 (H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), 
> CVE-1999-1198 (H), CVE-1999-1193 (H))
> - org.slf4j:slf4j-api 1.7.5 -> 1.7.25
> Please review the list and let me know if you have any concerns or would like 
> to add more deps to upgrade.
> Thanks,
> Andor



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-12 Thread Patrick Hunt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2952:

Affects Version/s: 3.6.0

> Upgrade third party libraries to address vulnerabilities
> 
>
> Key: ZOOKEEPER-2952
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Critical
>  Labels: dependencies, upgrade, vulnerabilities
> Fix For: 3.5.4, 3.4.12
>
>
> Hi,
> I'm going to upgrade the following third party libraries in order to address 
> vulnerabilities found in them:
> - io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), 
> CVE-2014-3488 (H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), 
> CVE-1999-1198 (H), CVE-1999-1193 (H))
> - org.slf4j:slf4j-api 1.7.5 -> 1.7.25
> Please review the list and let me know if you have any concerns or would like 
> to add more deps to upgrade.
> Thanks,
> Andor



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors

2017-12-12 Thread Patrick Hunt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2924:

Fix Version/s: 3.6.0
   3.5.4

> Flaky Test: 
> org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
> --
>
> Key: ZOOKEEPER-2924
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server, tests
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: flaky, flaky-test
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/
> Same issue happens in jdk8 and jdk9 builds as well.
> Issue has already been fixed by 
> https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the 
> root cause here is that test startup / cleanup code is included in the tests 
> instead of using try-finally block or Before-After methods.
> As a consequence, when exception happens during test execution, ZK test 
> server doesn't get shutdown properly and still listening on the port bound to 
> the test class.
> As mentioned above there could be 2 approaches to address this:
> #1 Wrap cleanup code block with finally
> #2 Use JUnit's Before-After methods for initialization and cleanup
> Test where original issue happens:
> {noformat}
> ...   
>  [junit] 2017-10-12 15:05:20,135 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,137 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,139 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,142 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,144 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:30,479 [myid:] - INFO  
> [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, 
> timeout of 6000ms exceeded
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:ping cxid:0xfffe 
> zxid:0xf$
>  [junit] 2017-10-12 15:05:24,147 [myid:] - WARN  
> [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client 
> session timed out, have not heard from server in 4002ms for sessionid 
> 0x104cd7b190c
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  
> [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client 
> session timed out, have not heard from server in 4002ms for sessionid 
> 0x104cd7b190c, closing socket connectio$
>  [junit] 2017-10-12 15:05:21,479 [myid:] - INFO  
> [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop!
>  [junit] 2017-10-12 15:05:32,998 [myid:] - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@376] - Unable to 
> read additional data from client sessionid 0x104cd7b190c, likely client 
> has closed socket
>  [junit] 2017-10-12 15:05:33,067 [myid:] - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1040] - Closed 
> socket connection for client /127.0.0.1:45735 which had sessionid 
> 0x104cd7b190c
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@487] - Processed session termination for 
> sessionid: 0x104cd7b190c
>  [junit] 2017-10-12 15:05:33,889 [myid:] - INFO  [main:ZooKeeper@687] - 
> Session: 0x104cd7b190c closed
>  [junit] 2017-10-12 15:05:33,890 [myid:] - INFO  
> [main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for 
> session: 0x104cd7b190c
>  [junit] 2017-10-12 15:05:33,891 [myid:] - INFO  
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@74] - TEST METHOD FAILED 
> testRestoreWithTransactionErrors

[jira] [Resolved] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors

2017-12-12 Thread Patrick Hunt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-2924.
-
  Resolution: Fixed
Hadoop Flags: Reviewed

LGTM - +1 thanks Andor.

> Flaky Test: 
> org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
> --
>
> Key: ZOOKEEPER-2924
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server, tests
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: flaky, flaky-test
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/
> Same issue happens in jdk8 and jdk9 builds as well.
> Issue has already been fixed by 
> https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the 
> root cause here is that test startup / cleanup code is included in the tests 
> instead of using try-finally block or Before-After methods.
> As a consequence, when exception happens during test execution, ZK test 
> server doesn't get shutdown properly and still listening on the port bound to 
> the test class.
> As mentioned above there could be 2 approaches to address this:
> #1 Wrap cleanup code block with finally
> #2 Use JUnit's Before-After methods for initialization and cleanup
> Test where original issue happens:
> {noformat}
> ...   
>  [junit] 2017-10-12 15:05:20,135 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,137 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,139 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,142 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,144 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:30,479 [myid:] - INFO  
> [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, 
> timeout of 6000ms exceeded
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:ping cxid:0xfffe 
> zxid:0xf$
>  [junit] 2017-10-12 15:05:24,147 [myid:] - WARN  
> [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client 
> session timed out, have not heard from server in 4002ms for sessionid 
> 0x104cd7b190c
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  
> [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client 
> session timed out, have not heard from server in 4002ms for sessionid 
> 0x104cd7b190c, closing socket connectio$
>  [junit] 2017-10-12 15:05:21,479 [myid:] - INFO  
> [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop!
>  [junit] 2017-10-12 15:05:32,998 [myid:] - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@376] - Unable to 
> read additional data from client sessionid 0x104cd7b190c, likely client 
> has closed socket
>  [junit] 2017-10-12 15:05:33,067 [myid:] - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1040] - Closed 
> socket connection for client /127.0.0.1:45735 which had sessionid 
> 0x104cd7b190c
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@487] - Processed session termination for 
> sessionid: 0x104cd7b190c
>  [junit] 2017-10-12 15:05:33,889 [myid:] - INFO  [main:ZooKeeper@687] - 
> Session: 0x104cd7b190c closed
>  [junit] 2017-10-12 15:05:33,890 [myid:] - INFO  
> [main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for 
> session: 0x104cd7b190c
>  [junit] 2017-10-12 15:05:33,891 [myid:] - INFO  
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@74] - TEST METHOD FAILED 
>

[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287983#comment-16287983
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2924:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/409
  
+1 thanks Andor. I committed this to branch-3.4 - you'll need to close this 
PR manually.


> Flaky Test: 
> org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
> --
>
> Key: ZOOKEEPER-2924
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server, tests
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: flaky, flaky-test
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/
> Same issue happens in jdk8 and jdk9 builds as well.
> Issue has already been fixed by 
> https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the 
> root cause here is that test startup / cleanup code is included in the tests 
> instead of using try-finally block or Before-After methods.
> As a consequence, when exception happens during test execution, ZK test 
> server doesn't get shutdown properly and still listening on the port bound to 
> the test class.
> As mentioned above there could be 2 approaches to address this:
> #1 Wrap cleanup code block with finally
> #2 Use JUnit's Before-After methods for initialization and cleanup
> Test where original issue happens:
> {noformat}
> ...   
>  [junit] 2017-10-12 15:05:20,135 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,137 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,139 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,142 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,144 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:30,479 [myid:] - INFO  
> [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, 
> timeout of 6000ms exceeded
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:ping cxid:0xfffe 
> zxid:0xf$
>  [junit] 2017-10-12 15:05:24,147 [myid:] - WARN  
> [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client 
> session timed out, have not heard from server in 4002ms for sessionid 
> 0x104cd7b190c
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  
> [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client 
> session timed out, have not heard from server in 4002ms for sessionid 
> 0x104cd7b190c, closing socket connectio$
>  [junit] 2017-10-12 15:05:21,479 [myid:] - INFO  
> [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop!
>  [junit] 2017-10-12 15:05:32,998 [myid:] - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@376] - Unable to 
> read additional data from client sessionid 0x104cd7b190c, likely client 
> has closed socket
>  [junit] 2017-10-12 15:05:33,067 [myid:] - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1040] - Closed 
> socket connection for client /127.0.0.1:45735 which had sessionid 
> 0x104cd7b190c
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@487] - Processed session termination for 
> sessionid: 0x104cd7b190c
>  [junit] 2017-10-12 15:05:33,889 [myid:] - INFO  [main:ZooKeeper@687] - 
> Session: 0x104cd7b190c closed
>  [junit] 2017-10-12 15:05:33,890 [myid:] - INFO  
> [main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for 
>

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-12-12 Thread phunt

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/409
  
+1 thanks Andor. I committed this to branch-3.4 - you'll need to close this 
PR manually.


---

[jira] [Updated] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors

2017-12-12 Thread Patrick Hunt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2924:

Affects Version/s: 3.6.0
   3.4.10
   3.5.3

> Flaky Test: 
> org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
> --
>
> Key: ZOOKEEPER-2924
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server, tests
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>  Labels: flaky, flaky-test
> Fix For: 3.4.12
>
>
> From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/
> Same issue happens in jdk8 and jdk9 builds as well.
> Issue has already been fixed by 
> https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the 
> root cause here is that test startup / cleanup code is included in the tests 
> instead of using try-finally block or Before-After methods.
> As a consequence, when exception happens during test execution, ZK test 
> server doesn't get shutdown properly and still listening on the port bound to 
> the test class.
> As mentioned above there could be 2 approaches to address this:
> #1 Wrap cleanup code block with finally
> #2 Use JUnit's Before-After methods for initialization and cleanup
> Test where original issue happens:
> {noformat}
> ...   
>  [junit] 2017-10-12 15:05:20,135 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,137 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,139 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,142 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:20,144 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 
> txntype:-1 req$
>  [junit] 2017-10-12 15:05:30,479 [myid:] - INFO  
> [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, 
> timeout of 6000ms exceeded
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when 
> processing sessionid:0x104cd7b190c type:ping cxid:0xfffe 
> zxid:0xf$
>  [junit] 2017-10-12 15:05:24,147 [myid:] - WARN  
> [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client 
> session timed out, have not heard from server in 4002ms for sessionid 
> 0x104cd7b190c
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  
> [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client 
> session timed out, have not heard from server in 4002ms for sessionid 
> 0x104cd7b190c, closing socket connectio$
>  [junit] 2017-10-12 15:05:21,479 [myid:] - INFO  
> [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop!
>  [junit] 2017-10-12 15:05:32,998 [myid:] - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@376] - Unable to 
> read additional data from client sessionid 0x104cd7b190c, likely client 
> has closed socket
>  [junit] 2017-10-12 15:05:33,067 [myid:] - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1040] - Closed 
> socket connection for client /127.0.0.1:45735 which had sessionid 
> 0x104cd7b190c
>  [junit] 2017-10-12 15:05:32,996 [myid:] - INFO  [ProcessThread(sid:0 
> cport:11221)::PrepRequestProcessor@487] - Processed session termination for 
> sessionid: 0x104cd7b190c
>  [junit] 2017-10-12 15:05:33,889 [myid:] - INFO  [main:ZooKeeper@687] - 
> Session: 0x104cd7b190c closed
>  [junit] 2017-10-12 15:05:33,890 [myid:] - INFO  
> [main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for 
> session: 0x104cd7b190c
>  [junit] 2017-10-12 15:05:33,891 [myid:] - INFO  
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@74] - TEST METHOD FAILED 
>

Success: ZOOKEEPER- PreCommit Build #1341

2017-12-12 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1341/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 73.70 MB...]
 [exec]   
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1341//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1341//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1341//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] 330f9288e180024163499983ce5f2886e9a8ef64 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 47 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2951) zkServer.cmd does not start when JAVA_HOME ends with a \

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287679#comment-16287679
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2951:
---

GitHub user jorgheymans opened a pull request:

https://github.com/apache/zookeeper/pull/431

remove trailing \ from JAVA_HOME

 fixes ZOOKEEPER-2951

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jorgheymans/zookeeper master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #431


commit 8a85319da4258ad9bf9e497e8addaccd2dee88d5
Author: Jorg Heymans 
Date:   2017-12-12T14:26:38Z

remove trailing \ from JAVA_HOME

 fixes ZOOKEEPER-2951




> zkServer.cmd does not start when JAVA_HOME ends with a \
> 
>
> Key: ZOOKEEPER-2951
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2951
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.11
> Environment: windows 7 (not tested on other windows versions+
>Reporter: Jorg Heymans
>
> this is the output i get (apologies for the cut-off line endings)
> {noformat}
> C:\RC\Tools\zookeeper-3.4.11\bin>zkServer.cmd
> call "c:\RC\jdk\jdk1.8.0_121\"\bin\java 
> "-Dzookeeper.log.dir=C:\RC\Tools\zookeeper-3.4.11\bin\.." 
> "-Dzookeeper.root.logger=INFO,CONSOLE" -cp 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\build\classes;C:\RC\Tools\zookeeper-3.4.11\bin\..\build\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\*;C:\RC\Tools\zookeeper-
> 3.4.11\bin\..\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\conf" 
> org.apache.zookeeper.server.quorum.QuorumPeerMain 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\c
> onf\zoo.cfg"
> Usage: java [-options] class [args...]
>(to execute a class)
>or  java [-options] -jar jarfile [args...]
>(to execute a jar file)
> where options include:
> -d32  use a 32-bit data model if available
> -d64  use a 64-bit data model if available
> -server   to select the "server" VM
>   The default VM is server.
> -cp 
> -classpath 
>   A ; separated list of directories, JAR archives,
>   and ZIP archives to search for class files.
> -D=
>   set a system property
> -verbose:[class|gc|jni]
>   enable verbose output
> -version  print product version and exit
> -version:
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   require the specified version to run
> -showversion  print product version and continue
> -jre-restrict-search | -no-jre-restrict-search
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   include/exclude user private JREs in the version search
> -? -help  print this help message
> -Xprint help on non-standard options
> -ea[:...|:]
> -enableassertions[:...|:]
>   enable assertions with specified granularity
> -da[:...|:]
> -disableassertions[:...|:]
>   disable assertions with specified granularity
> -esa | -enablesystemassertions
>   enable system assertions
> -dsa | -disablesystemassertions
>   disable system assertions
> -agentlib:[=]
>   load native agent library , e.g. -agentlib:hprof
>   see also, -agentlib:jdwp=help and -agentlib:hprof=help
> -agentpath:[=]
>   load native agent library by full pathname
> -javaagent:[=]
>   load Java programming language agent, see 
> java.lang.instrument
> -splash:
>   show splash screen with specified image
> See http://www.oracle.com/technetwork/java/javase/documentation/index.html 
> for more details.
> endlocal
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2951) zkServer.cmd does not start when JAVA_HOME ends with a \

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287682#comment-16287682
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2951:
---

Github user jorgheymans closed the pull request at:

https://github.com/apache/zookeeper/pull/428


> zkServer.cmd does not start when JAVA_HOME ends with a \
> 
>
> Key: ZOOKEEPER-2951
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2951
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.11
> Environment: windows 7 (not tested on other windows versions+
>Reporter: Jorg Heymans
>
> this is the output i get (apologies for the cut-off line endings)
> {noformat}
> C:\RC\Tools\zookeeper-3.4.11\bin>zkServer.cmd
> call "c:\RC\jdk\jdk1.8.0_121\"\bin\java 
> "-Dzookeeper.log.dir=C:\RC\Tools\zookeeper-3.4.11\bin\.." 
> "-Dzookeeper.root.logger=INFO,CONSOLE" -cp 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\build\classes;C:\RC\Tools\zookeeper-3.4.11\bin\..\build\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\*;C:\RC\Tools\zookeeper-
> 3.4.11\bin\..\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\conf" 
> org.apache.zookeeper.server.quorum.QuorumPeerMain 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\c
> onf\zoo.cfg"
> Usage: java [-options] class [args...]
>(to execute a class)
>or  java [-options] -jar jarfile [args...]
>(to execute a jar file)
> where options include:
> -d32  use a 32-bit data model if available
> -d64  use a 64-bit data model if available
> -server   to select the "server" VM
>   The default VM is server.
> -cp 
> -classpath 
>   A ; separated list of directories, JAR archives,
>   and ZIP archives to search for class files.
> -D=
>   set a system property
> -verbose:[class|gc|jni]
>   enable verbose output
> -version  print product version and exit
> -version:
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   require the specified version to run
> -showversion  print product version and continue
> -jre-restrict-search | -no-jre-restrict-search
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   include/exclude user private JREs in the version search
> -? -help  print this help message
> -Xprint help on non-standard options
> -ea[:...|:]
> -enableassertions[:...|:]
>   enable assertions with specified granularity
> -da[:...|:]
> -disableassertions[:...|:]
>   disable assertions with specified granularity
> -esa | -enablesystemassertions
>   enable system assertions
> -dsa | -disablesystemassertions
>   disable system assertions
> -agentlib:[=]
>   load native agent library , e.g. -agentlib:hprof
>   see also, -agentlib:jdwp=help and -agentlib:hprof=help
> -agentpath:[=]
>   load native agent library by full pathname
> -javaagent:[=]
>   load Java programming language agent, see 
> java.lang.instrument
> -splash:
>   show splash screen with specified image
> See http://www.oracle.com/technetwork/java/javase/documentation/index.html 
> for more details.
> endlocal
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #428: fixes ZOOKEEPER-2951

2017-12-12 Thread jorgheymans

Github user jorgheymans closed the pull request at:

https://github.com/apache/zookeeper/pull/428


---

[jira] [Commented] (ZOOKEEPER-2951) zkServer.cmd does not start when JAVA_HOME ends with a \

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287681#comment-16287681
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2951:
---

Github user jorgheymans commented on the issue:

https://github.com/apache/zookeeper/pull/428
  
see #431 


> zkServer.cmd does not start when JAVA_HOME ends with a \
> 
>
> Key: ZOOKEEPER-2951
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2951
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.11
> Environment: windows 7 (not tested on other windows versions+
>Reporter: Jorg Heymans
>
> this is the output i get (apologies for the cut-off line endings)
> {noformat}
> C:\RC\Tools\zookeeper-3.4.11\bin>zkServer.cmd
> call "c:\RC\jdk\jdk1.8.0_121\"\bin\java 
> "-Dzookeeper.log.dir=C:\RC\Tools\zookeeper-3.4.11\bin\.." 
> "-Dzookeeper.root.logger=INFO,CONSOLE" -cp 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\build\classes;C:\RC\Tools\zookeeper-3.4.11\bin\..\build\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\*;C:\RC\Tools\zookeeper-
> 3.4.11\bin\..\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\conf" 
> org.apache.zookeeper.server.quorum.QuorumPeerMain 
> "C:\RC\Tools\zookeeper-3.4.11\bin\..\c
> onf\zoo.cfg"
> Usage: java [-options] class [args...]
>(to execute a class)
>or  java [-options] -jar jarfile [args...]
>(to execute a jar file)
> where options include:
> -d32  use a 32-bit data model if available
> -d64  use a 64-bit data model if available
> -server   to select the "server" VM
>   The default VM is server.
> -cp 
> -classpath 
>   A ; separated list of directories, JAR archives,
>   and ZIP archives to search for class files.
> -D=
>   set a system property
> -verbose:[class|gc|jni]
>   enable verbose output
> -version  print product version and exit
> -version:
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   require the specified version to run
> -showversion  print product version and continue
> -jre-restrict-search | -no-jre-restrict-search
>   Warning: this feature is deprecated and will be removed
>   in a future release.
>   include/exclude user private JREs in the version search
> -? -help  print this help message
> -Xprint help on non-standard options
> -ea[:...|:]
> -enableassertions[:...|:]
>   enable assertions with specified granularity
> -da[:...|:]
> -disableassertions[:...|:]
>   disable assertions with specified granularity
> -esa | -enablesystemassertions
>   enable system assertions
> -dsa | -disablesystemassertions
>   disable system assertions
> -agentlib:[=]
>   load native agent library , e.g. -agentlib:hprof
>   see also, -agentlib:jdwp=help and -agentlib:hprof=help
> -agentpath:[=]
>   load native agent library by full pathname
> -javaagent:[=]
>   load Java programming language agent, see 
> java.lang.instrument
> -splash:
>   show splash screen with specified image
> See http://www.oracle.com/technetwork/java/javase/documentation/index.html 
> for more details.
> endlocal
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper issue #428: fixes ZOOKEEPER-2951

2017-12-12 Thread jorgheymans

Github user jorgheymans commented on the issue:

https://github.com/apache/zookeeper/pull/428
  
see #431 


---

[GitHub] zookeeper pull request #431: remove trailing \ from JAVA_HOME

2017-12-12 Thread jorgheymans

GitHub user jorgheymans opened a pull request:

https://github.com/apache/zookeeper/pull/431

remove trailing \ from JAVA_HOME

 fixes ZOOKEEPER-2951

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jorgheymans/zookeeper master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #431


commit 8a85319da4258ad9bf9e497e8addaccd2dee88d5
Author: Jorg Heymans 
Date:   2017-12-12T14:26:38Z

remove trailing \ from JAVA_HOME

 fixes ZOOKEEPER-2951




---

Success: ZOOKEEPER- PreCommit Build #1340

2017-12-12 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1340/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 73.24 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1340//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1340//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1340//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 8fa41ebfdd13cdbea527212d8210622361176346 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 48 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2893
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-12 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287649#comment-16287649
 ] 

Hadoop QA commented on ZOOKEEPER-2893:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1340//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1340//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1340//console

This message is automatically generated.

> very poor choice of logging if client fails to connect to server
> 
>
> Key: ZOOKEEPER-2893
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2893
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Paul Millar
>Assignee: Andor Molnar
>
> We are using ZooKeeper in our project and have received reports that, when 
> suffering a networking problem, log files become flooded with messages like:
> {quote}
> 07 Sep 2017 08:22:00 (System) [] Session 0x45d3151be3600a9 for server null, 
> unexpected error, closing socket connection and attempting reconnect
> java.net.NoRouteToHostException: No route to host
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
> ~[na:1.8.0_131]
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
> ~[na:1.8.0_131]
> at 
> org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
>  ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> at 
> org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081) 
> ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> {quote}
> Looking at the code that logs this message ({{ClientCnxn}}), there seems to 
> be quite a few problems here:
> # the code logs a stack-trace, even though there is no bug here.  In our 
> project, we treat all logged stack-traces as bugs,
> # if the networking issue is not fixed promptly, the log files is flooded 
> with these message,
> # The message is built using {{ClientCnxnSocket#getRemoteSocketAddress}}, yet 
> in this case, this does not provide the expected information (yielding 
> {{null}}),
> # The log message fails to include a description of what actually went wrong.
> (Additionally, the code uses string concatenation rather than templating when 
> building the message; however, this is an optimisation issue)
> My suggestion is that this log entry is updated so that it doesn't log a 
> stack-trace, but does include some indication why the connection failed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-12 Thread Andor Molnar (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287625#comment-16287625
 ] 

Andor Molnar commented on ZOOKEEPER-2893:
-

[~paulmillar] please check it 

> very poor choice of logging if client fails to connect to server
> 
>
> Key: ZOOKEEPER-2893
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2893
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Paul Millar
>Assignee: Andor Molnar
>
> We are using ZooKeeper in our project and have received reports that, when 
> suffering a networking problem, log files become flooded with messages like:
> {quote}
> 07 Sep 2017 08:22:00 (System) [] Session 0x45d3151be3600a9 for server null, 
> unexpected error, closing socket connection and attempting reconnect
> java.net.NoRouteToHostException: No route to host
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
> ~[na:1.8.0_131]
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
> ~[na:1.8.0_131]
> at 
> org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
>  ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> at 
> org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081) 
> ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> {quote}
> Looking at the code that logs this message ({{ClientCnxn}}), there seems to 
> be quite a few problems here:
> # the code logs a stack-trace, even though there is no bug here.  In our 
> project, we treat all logged stack-traces as bugs,
> # if the networking issue is not fixed promptly, the log files is flooded 
> with these message,
> # The message is built using {{ClientCnxnSocket#getRemoteSocketAddress}}, yet 
> in this case, this does not provide the expected information (yielding 
> {{null}}),
> # The log message fails to include a description of what actually went wrong.
> (Additionally, the code uses string concatenation rather than templating when 
> building the message; however, this is an optimisation issue)
> My suggestion is that this log entry is updated so that it doesn't log a 
> stack-trace, but does include some indication why the connection failed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287622#comment-16287622
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2893:
---

GitHub user anmolnar opened a pull request:

https://github.com/apache/zookeeper/pull/430

ZOOKEEPER-2893. Make 'addr' variable available for error handling code to 
give a chance to fallback if the socket hasn't been initialized yet

'addr' variable is used to identify which server to connect to.
I've made this available for error handling code in order to let it 
fallback to this address if the remote socket hasn't been initialised yet. This 
will give us better error messages if the client is unable to connect to server 
for some reason.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2893

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/430.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #430


commit fbe4ccde8516150cfd69d2a2260266fd1c0bf10d
Author: Andor Molnar 
Date:   2017-12-12T13:46:34Z

ZOOKEEPER-2893. Make 'addr' variable available for error handling code to 
give a chance to fallback if the socket hasn't been initialized yet




> very poor choice of logging if client fails to connect to server
> 
>
> Key: ZOOKEEPER-2893
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2893
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Paul Millar
>Assignee: Andor Molnar
>
> We are using ZooKeeper in our project and have received reports that, when 
> suffering a networking problem, log files become flooded with messages like:
> {quote}
> 07 Sep 2017 08:22:00 (System) [] Session 0x45d3151be3600a9 for server null, 
> unexpected error, closing socket connection and attempting reconnect
> java.net.NoRouteToHostException: No route to host
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
> ~[na:1.8.0_131]
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
> ~[na:1.8.0_131]
> at 
> org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
>  ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> at 
> org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081) 
> ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> {quote}
> Looking at the code that logs this message ({{ClientCnxn}}), there seems to 
> be quite a few problems here:
> # the code logs a stack-trace, even though there is no bug here.  In our 
> project, we treat all logged stack-traces as bugs,
> # if the networking issue is not fixed promptly, the log files is flooded 
> with these message,
> # The message is built using {{ClientCnxnSocket#getRemoteSocketAddress}}, yet 
> in this case, this does not provide the expected information (yielding 
> {{null}}),
> # The log message fails to include a description of what actually went wrong.
> (Additionally, the code uses string concatenation rather than templating when 
> building the message; however, this is an optimisation issue)
> My suggestion is that this log entry is updated so that it doesn't log a 
> stack-trace, but does include some indication why the connection failed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. Make 'addr' variable available ...

2017-12-12 Thread anmolnar

GitHub user anmolnar opened a pull request:

https://github.com/apache/zookeeper/pull/430

ZOOKEEPER-2893. Make 'addr' variable available for error handling code to 
give a chance to fallback if the socket hasn't been initialized yet

'addr' variable is used to identify which server to connect to.
I've made this available for error handling code in order to let it 
fallback to this address if the remote socket hasn't been initialised yet. This 
will give us better error messages if the client is unable to connect to server 
for some reason.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2893

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/430.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #430


commit fbe4ccde8516150cfd69d2a2260266fd1c0bf10d
Author: Andor Molnar 
Date:   2017-12-12T13:46:34Z

ZOOKEEPER-2893. Make 'addr' variable available for error handling code to 
give a chance to fallback if the socket hasn't been initialized yet




---

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-12 Thread Andor Molnar (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287581#comment-16287581
 ] 

Andor Molnar commented on ZOOKEEPER-2893:
-

[~paulmillar] I'll take a look and submit a pull request soon.

> very poor choice of logging if client fails to connect to server
> 
>
> Key: ZOOKEEPER-2893
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2893
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Paul Millar
>Assignee: Andor Molnar
>
> We are using ZooKeeper in our project and have received reports that, when 
> suffering a networking problem, log files become flooded with messages like:
> {quote}
> 07 Sep 2017 08:22:00 (System) [] Session 0x45d3151be3600a9 for server null, 
> unexpected error, closing socket connection and attempting reconnect
> java.net.NoRouteToHostException: No route to host
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
> ~[na:1.8.0_131]
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
> ~[na:1.8.0_131]
> at 
> org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
>  ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> at 
> org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081) 
> ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> {quote}
> Looking at the code that logs this message ({{ClientCnxn}}), there seems to 
> be quite a few problems here:
> # the code logs a stack-trace, even though there is no bug here.  In our 
> project, we treat all logged stack-traces as bugs,
> # if the networking issue is not fixed promptly, the log files is flooded 
> with these message,
> # The message is built using {{ClientCnxnSocket#getRemoteSocketAddress}}, yet 
> in this case, this does not provide the expected information (yielding 
> {{null}}),
> # The log message fails to include a description of what actually went wrong.
> (Additionally, the code uses string concatenation rather than templating when 
> building the message; however, this is an optimisation issue)
> My suggestion is that this log entry is updated so that it doesn't log a 
> stack-trace, but does include some indication why the connection failed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-12 Thread Andor Molnar (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar reassigned ZOOKEEPER-2893:
---

Assignee: Andor Molnar

> very poor choice of logging if client fails to connect to server
> 
>
> Key: ZOOKEEPER-2893
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2893
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Paul Millar
>Assignee: Andor Molnar
>
> We are using ZooKeeper in our project and have received reports that, when 
> suffering a networking problem, log files become flooded with messages like:
> {quote}
> 07 Sep 2017 08:22:00 (System) [] Session 0x45d3151be3600a9 for server null, 
> unexpected error, closing socket connection and attempting reconnect
> java.net.NoRouteToHostException: No route to host
> at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) 
> ~[na:1.8.0_131]
> at 
> sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) 
> ~[na:1.8.0_131]
> at 
> org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
>  ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> at 
> org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081) 
> ~[zookeeper-3.4.6.jar:3.4.6-1569965]
> {quote}
> Looking at the code that logs this message ({{ClientCnxn}}), there seems to 
> be quite a few problems here:
> # the code logs a stack-trace, even though there is no bug here.  In our 
> project, we treat all logged stack-traces as bugs,
> # if the networking issue is not fixed promptly, the log files is flooded 
> with these message,
> # The message is built using {{ClientCnxnSocket#getRemoteSocketAddress}}, yet 
> in this case, this does not provide the expected information (yielding 
> {{null}}),
> # The log message fails to include a description of what actually went wrong.
> (Additionally, the code uses string concatenation rather than templating when 
> building the message; however, this is an optimisation issue)
> My suggestion is that this log entry is updated so that it doesn't log a 
> stack-trace, but does include some indication why the connection failed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Success: ZOOKEEPER- PreCommit Build #1339

2017-12-12 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1339/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 74.36 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1339//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1339//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1339//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] b65870dff5846e044102bf4ba15133b15a045dab logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 26 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2952
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-12 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287559#comment-16287559
 ] 

Hadoop QA commented on ZOOKEEPER-2952:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1339//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1339//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1339//console

This message is automatically generated.

> Upgrade third party libraries to address vulnerabilities
> 
>
> Key: ZOOKEEPER-2952
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.5.3, 3.4.11
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Critical
>  Labels: dependencies, upgrade, vulnerabilities
> Fix For: 3.5.4, 3.4.12
>
>
> Hi,
> I'm going to upgrade the following third party libraries in order to address 
> vulnerabilities found in them:
> - io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), 
> CVE-2014-3488 (H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), 
> CVE-1999-1198 (H), CVE-1999-1193 (H))
> - org.slf4j:slf4j-api 1.7.5 -> 1.7.25
> Please review the list and let me know if you have any concerns or would like 
> to add more deps to upgrade.
> Thanks,
> Andor



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287535#comment-16287535
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2952:
---

GitHub user anmolnar opened a pull request:

https://github.com/apache/zookeeper/pull/429

ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2952

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #429


commit 949ada4ae0ad87388269bcc728acce325f04
Author: Andor Molnar 
Date:   2017-12-12T11:04:48Z

ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j




> Upgrade third party libraries to address vulnerabilities
> 
>
> Key: ZOOKEEPER-2952
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.5.3, 3.4.11
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Critical
>  Labels: dependencies, upgrade, vulnerabilities
> Fix For: 3.5.4, 3.4.12
>
>
> Hi,
> I'm going to upgrade the following third party libraries in order to address 
> vulnerabilities found in them:
> - io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), 
> CVE-2014-3488 (H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), 
> CVE-1999-1198 (H), CVE-1999-1193 (H))
> - org.slf4j:slf4j-api 1.7.5 -> 1.7.25
> Please review the list and let me know if you have any concerns or would like 
> to add more deps to upgrade.
> Thanks,
> Andor



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #429: ZOOKEEPER-2952. Upgrade third party libs: netty...

2017-12-12 Thread anmolnar

GitHub user anmolnar opened a pull request:

https://github.com/apache/zookeeper/pull/429

ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2952

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #429


commit 949ada4ae0ad87388269bcc728acce325f04
Author: Andor Molnar 
Date:   2017-12-12T11:04:48Z

ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j




---

[jira] [Updated] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-12 Thread Andor Molnar (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar updated ZOOKEEPER-2952:

Description: 
Hi,

I'm going to upgrade the following third party libraries in order to address 
vulnerabilities found in them:

- io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), CVE-2014-3488 
(H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), CVE-1999-1198 
(H), CVE-1999-1193 (H))
- org.slf4j:slf4j-api 1.7.5 -> 1.7.25

Please review the list and let me know if you have any concerns or would like 
to add more deps to upgrade.

Thanks,
Andor


  was:
Hi,

I'm going to upgrade the following third party libraries in order to address 
vulnerabilities found in them:

- io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), CVE-2014-3488 
(H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), CVE-1999-1198 
(H), CVE-1999-1193 (H))
- org.slf4j:slf4j-api 1.6.1 -> 1.7.25
- log4j:log4j 1.2.16 -> 1.2.17

Please review the list and let me know if you have any concerns or would like 
to add more deps to upgrade.

Thanks,
Andor



> Upgrade third party libraries to address vulnerabilities
> 
>
> Key: ZOOKEEPER-2952
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.5.3, 3.4.11
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Critical
>  Labels: dependencies, upgrade, vulnerabilities
> Fix For: 3.5.4, 3.4.12
>
>
> Hi,
> I'm going to upgrade the following third party libraries in order to address 
> vulnerabilities found in them:
> - io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), 
> CVE-2014-3488 (H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), 
> CVE-1999-1198 (H), CVE-1999-1193 (H))
> - org.slf4j:slf4j-api 1.7.5 -> 1.7.25
> Please review the list and let me know if you have any concerns or would like 
> to add more deps to upgrade.
> Thanks,
> Andor



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities

2017-12-12 Thread Andor Molnar (JIRA)

Andor Molnar created ZOOKEEPER-2952:
---

 Summary: Upgrade third party libraries to address vulnerabilities
 Key: ZOOKEEPER-2952
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Affects Versions: 3.4.11, 3.5.3
Reporter: Andor Molnar
Assignee: Andor Molnar
Priority: Critical
 Fix For: 3.5.4, 3.4.12


Hi,

I'm going to upgrade the following third party libraries in order to address 
vulnerabilities found in them:

- io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), CVE-2014-3488 
(H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), CVE-1999-1198 
(H), CVE-1999-1193 (H))
- org.slf4j:slf4j-api 1.6.1 -> 1.7.25
- log4j:log4j 1.2.16 -> 1.2.17

Please review the list and let me know if you have any concerns or would like 
to add more deps to upgrade.

Thanks,
Andor




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

71 matches

Mail list logo