Failed: ZOOKEEPER- PreCommit Build #1859

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1859/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 82.26 MB...]
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] -1 release audit.  The applied patch generated 1 release audit 
warnings (more than the trunk's current 0 warnings).
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1859//testReport/
 [exec] Release audit warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1859//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1859//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1859//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16520913 added to ZOOKEEPER-3057.
 [exec] Session logged out. Session was 
JSESSIONID=4773664769F2BA928AFE1B2AA8B23703.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1806:
 exec returned: 2

Total time: 15 minutes 49 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3057
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  .org.apache.zookeeper.common.NetUtilsTest

Error Message:
org.apache.zookeeper.common.NetUtilsTest

Stack Trace:
java.lang.ClassNotFoundException: org.apache.zookeeper.common.NetUtilsTest
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:264)

[jira] [Commented] (ZOOKEEPER-3057) Fix IPv6 literal usage

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520913#comment-16520913
 ] 

Hadoop QA commented on ZOOKEEPER-3057:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 11 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

-1 release audit.  The applied patch generated 1 release audit warnings 
(more than the trunk's current 0 warnings).

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1859//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1859//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1859//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1859//console

This message is automatically generated.

> Fix IPv6 literal usage
> --
>
> Key: ZOOKEEPER-3057
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3057
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: other
>Affects Versions: 3.4.12
>Reporter: Mohamed Jeelani
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IPv6 literals are not parsed correctly and can lead to potential errors if 
> not be an eye sore. Need to parse and display them correctly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3057) Fix IPv6 literal usage

[Mohamed Jeelani (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520909#comment-16520909
 ] 

Mohamed Jeelani commented on ZOOKEEPER-3057:


Pull request submitted - appreciate review and feedback - 
https://github.com/apache/zookeeper/pull/548

> Fix IPv6 literal usage
> --
>
> Key: ZOOKEEPER-3057
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3057
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: other
>Affects Versions: 3.4.12
>Reporter: Mohamed Jeelani
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IPv6 literals are not parsed correctly and can lead to potential errors if 
> not be an eye sore. Need to parse and display them correctly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3057) Fix IPv6 literal usage

[Mohamed Jeelani (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohamed Jeelani updated ZOOKEEPER-3057:
---
Priority: Minor  (was: Trivial)

> Fix IPv6 literal usage
> --
>
> Key: ZOOKEEPER-3057
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3057
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: other
>Affects Versions: 3.4.12
>Reporter: Mohamed Jeelani
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IPv6 literals are not parsed correctly and can lead to potential errors if 
> not be an eye sore. Need to parse and display them correctly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

[mjeelanimsft]

GitHub user mjeelanimsft opened a pull request:

https://github.com/apache/zookeeper/pull/548

[ZOOKEEPER-3057] Fix IPv6 literal usage

This patch contains fixes for IPv6 literal usage and corresponding unit 
test changes. 

As per discussion in ZOOKEEPER-3057 - The issue/problem is the same as 
ZOOKEEPER-2989, but we changed the code to pass IPv6 literal [%s]:%s, also we 
changed the logging and the LocalPeerBean to show this IPv6 literal as well, 
which makes it easier to check when using Ipv6 and we added detailed tests for 
this change, sending out for review to see if it's better or not.

ZKPatch: 88e94e6f3665353446bf70a042c8f0cd50834f7c (extract)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mjeelanimsft/zookeeper fix-ipv6-literal

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/548.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #548


commit 196d6c3758df8a86cce405ce9552ea72d2cca18a
Author: Jeelani Mohamed Abdul Khader 
Date:   2018-06-06T01:58:26Z

Fix IPv6 literal usage

ZKPatch: 88e94e6f3665353446bf70a042c8f0cd50834f7c (extract)




---

[jira] [Updated] (ZOOKEEPER-3057) Fix IPv6 literal usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3057:
--
Labels: pull-request-available  (was: )

> Fix IPv6 literal usage
> --
>
> Key: ZOOKEEPER-3057
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3057
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: other
>Affects Versions: 3.4.12
>Reporter: Mohamed Jeelani
>Priority: Trivial
>  Labels: pull-request-available
>
> IPv6 literals are not parsed correctly and can lead to potential errors if 
> not be an eye sore. Need to parse and display them correctly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Should we cut a 3.4.13 release?

[Michael Han]

3.4.13 rc0 is out (see the vote thread here
),
please try it and vote.

On Thu, Jun 21, 2018 at 8:50 PM, Michael Han  wrote:

> I have limited bandwidth recently so it would take a while before I can
> get back to ZOOKEEPER-2184 (for master/3.5 version). That however should
> not block 3.4.13 release.
>
> I am preparing the release candidate for 3.4.13 release, will send out
> email to dev list for vote soon.
>
> On Mon, Jun 18, 2018 at 9:54 AM, Molnár Andor  wrote:
>
>> Michael is waiting for the master version of ZOOKEEPER-2184 to be
>> committed.
>>
>> I think I've addressed all the issues, so there shouldn't be any blockers
>> anymore.
>>
>>
>> Andor
>>
>>
>>
>>
>>
>> On 06/18/2018 04:22 PM, Patrick Hunt wrote:
>>
>>> I'm just back from vacation so I may have missed it - Michael any
>>> progress
>>> on this? Should we/can we start the release cycle? If not what's the
>>> blocker?
>>>
>>> Regards,
>>>
>>> Patrick
>>>
>>> On Tue, Jun 5, 2018 at 7:22 AM Michael Han  wrote:
>>>
>>> Perhaps you can commit the 3.5/trunk changes for 2184 prior to the 3.4
>>
> release?

 Sounds good, I'll take another look at the port and commit it this week
 if
 no other issues.

 On Tue, Jun 5, 2018 at 12:44 AM, Patrick Hunt  wrote:

 +1 - sounds good. 2959 and 2184 will be good to get out to users.
>
> Perhaps you can commit the 3.5/trunk changes for 2184 prior to the 3.4
> release? Just to ensure that we didn't miss anything and the releases
> are
> consistent, at least initially.
>
> Regards,
>
> Patrick
>
>
> On Sat, Jun 2, 2018 at 12:59 AM Michael Han  wrote:
>
> ZOOKEEPER-2184 is now merged and I think we are good to prepare a
>>
> release

> now given many eger users waiting for ZOOKEEPER-2184. I am also
>>
> interested
>
>> to take the role of RM for next release as I committed ZOOKEEPER-2184
>>
> (and
>
>> witnessed the commit of ZOOKEEPER-2959 :).
>>
>> I took a look at other 3.4.x issues, there are no blocking issues for
>>
> now.
>
>> The next release will contain 16 resolved issues most of which are bug
>> fixes.
>>
>>
>> On Tue, May 22, 2018 at 9:09 PM, Michael Han  wrote:
>>
>> I am reviewing ZOOKEEPER-2184, and hope to merge it in next few days.
>>> I'll also try to review and clean up some of the top pending requests
>>>
>> and
>
>> merge those in 3.4 as appropriate. I think it's a good idea to cut
>>>
>> another
>>
>>> release after ZK-2184 is in (ZK-2959 was already committed two weeks
>>>
>> ago),
>>
>>> as this is a long awaited feature and many users want it.
>>>
>>> On Mon, May 21, 2018 at 10:21 AM, Patrick Hunt 
>>>
>> wrote:
>
>> We've made solid progress on the next 3.4 release
 http://bit.ly/1UCURuM

 In particular Alexander committed a change which is marked as a

>>> blocker:
>
>> http://bit.ly/2LlVCbk
 Notice there are two blockers - Andor has been working with the

>>> community
>>
>>> to resolve ZOOKEEPER-2184

 After these two issues are addressed it looks like a reasonable

>>> update

> to
>>
>>> push. Does anyone have time to look at the serious/major issues that

>>> are
>
>> attached to the release?

 Thoughts?

 Patrick


>>>
>> --
>> Cheers
>> Michael
>>
>>
>>
>

[jira] [Assigned] (ZOOKEEPER-2885) zookeeper-3.5.3-beta.tar.gz file in mirror site is corrupted

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han reassigned ZOOKEEPER-2885:
--

Assignee: Michael Han

> zookeeper-3.5.3-beta.tar.gz file in mirror site is corrupted
> 
>
> Key: ZOOKEEPER-2885
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2885
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Gabriel
>Assignee: Michael Han
>Priority: Critical
> Fix For: 3.5.3
>
>
> I downloaded the zookeeper-3.5.3-beta.tar.gz file from several mirror sites 
> and all of them are corrupted.
> {quote}$ wget 
> http://www-us.apache.org/dist/zookeeper/zookeeper-3.5.3-beta/zookeeper-3.5.3-beta.tar.gz
> $:~/dockerfiles$ tar -xzvf zookeeper-3.5.3-beta.tar.gz
> gzip: stdin: not in gzip format
> tar: Child returned status 1
> tar: Error is not recoverable: exiting now{quote}
> If this is my mistake, please could you explain me what I did wrong?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[VOTE] Apache ZooKeeper release 3.4.13 candidate 0

[Michael Han]

This is a bugfix release candidate for 3.4.13. It fixes 17 issues,
including issues such as ZOOKEEPER-2959
 that could cause
data loss when observer is used, and ZOOKEEPER-2184
 that prevents
ZooKeeper Java clients working in dynamic IP (container / cloud)
environment.

The full release notes is available at:

*https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12342973
*

*** Please download, test and vote by June 27th 2018, 23:59 UTC+0. ***

Source files:
http://people.apache.org/~hanm/zookeeper/zookeeper-3.4.13-rc0/

Maven staging repo:
https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.4.13/

The release candidate tag in git to be voted upon: release-3.4.13-rc0

ZooKeeper's KEYS file containing PGP keys we use to sign the release:
http://www.apache.org/dist/zookeeper/KEYS

Should we release this candidate?


Cheers
Michael

[jira] [Resolved] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han resolved ZOOKEEPER-2184.

Resolution: Fixed

again need to temporarily resolve the issue to get the right release notes for 
3.4.13.

> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2, 
> 3.5.3, 3.4.11
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Andor Molnar
>Priority: Blocker
>  Labels: easyfix, patch, pull-request-available
> Fix For: 3.4.13
>
> Attachments: ZOOKEEPER-2184.patch
>
>  Time Spent: 8.5h
>  Remaining Estimate: 0h
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper_branch35_jdk8 - Build # 1013 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1013/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 61.88 KB...]
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 5
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.133 sec, Thread: 5, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.589 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.557 sec, Thread: 2, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 5
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.186 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
2
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.175 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 2
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
13.032 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
117.85 sec, Thread: 1, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.802 sec, Thread: 5, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.941 sec, Thread: 1, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 5
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.102 sec, Thread: 1, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
69.819 sec, Thread: 4, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 1
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.165 sec, Thread: 5, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 4
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.105 sec, Thread: 1, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.119 sec, Thread: 1, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.238 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 2
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
4.658 sec, Thread: 1, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.124 sec, Thread: 1, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
17.801 sec, Thread: 4, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.425 sec, Thread: 4, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.047 sec, Thread: 5, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.4 sec, Thread: 1, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time 

[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...

[enixon]

Github user enixon commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/546#discussion_r197574036
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -2069,4 +2073,9 @@ public QuorumCnxManager createCnxnManager() {
 this.quorumCnxnThreadsSize,
 this.isQuorumSaslAuthEnabled());
 }
+
+boolean isLeader(long id) {
+Vote vote = getCurrentVote();
+return vote != null && id == vote.getId();
--- End diff --

I'd second the request to sidestep the election logic for this method if 
possible as it makes the method harder to reason about. 

It would be nice if the method implied the server was currently performing 
active leader actions and the current way also covers a server preparing for or 
nominating itself to be leader (or at least it looks like it). For example, 
with this code on a 5 server ensemble with one server dead, if one server 
switches its vote midway through an election epoch then you could be displaying 
two "leaders" by vote but this is not the same as a two leader splitbrain 
scenario.


---

[GitHub] zookeeper issue #547: ZOOKEEPER-3068: Improve C client logging of IPv6 hosts

[enixon]

Github user enixon commented on the issue:

https://github.com/apache/zookeeper/pull/547
  
Two java tests failed - the pull request contains no java changes.


---

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
@anmolnar 

I checked the code, in my opinion the *id* inside current vote is the id of 
what the local peer thinks the leader is. See for instance updateServerState, 
in which state is calculated from the current vote.

So my code should be correct and there is no need (or it will be an error) 
to check the *state* variable.

About an additional testI don't know what will be the meaning of the 
test you are suggesting, maybe I am missing something


---

[jira] [Commented] (ZOOKEEPER-3068) Improve C client logging of IPv6 hosts

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520696#comment-16520696
 ] 

Hadoop QA commented on ZOOKEEPER-3068:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1858//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1858//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1858//console

This message is automatically generated.

> Improve C client logging of IPv6 hosts
> --
>
> Key: ZOOKEEPER-3068
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3068
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: c client
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The C client formats host-port pairings as [host:port] when logging. This is 
> visually confusing when the host is an IPv6 address (see the below). In that 
> case, it would be preferable to cleanly separate the IPv6 from the port. 
> {code:java}
> ZOO_INFO@check_events@2736: initiated connection to server 
> [2401:db00:1020:40bf:face:0:5:0:2181]{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER- PreCommit Build #1858

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1858/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 84.97 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1858//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1858//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1858//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16520696 added to ZOOKEEPER-3068.
 [exec] Session logged out. Session was 
JSESSIONID=61DDB82CE5B4D9D529D51C577AA55281.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1806:
 exec returned: 1

Total time: 18 minutes 34 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3068
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
2 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest

Error Message:
test timed out after 60 milliseconds

Stack Trace:
org.junit.runners.model.TestTimedOutException: test timed out after 60 
milliseconds
at java.lang.Object.wait(Native Method)
at java.lang.Object.wait(Object.java:502)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1506)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1494)
at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1444)
at 
org.apache.zookeeper.test.ReconfigTest.createZNode(ReconfigTest.java:192)
at 
org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:165)
at 
org.apache.zookeeper.server.quorum.StandaloneDisabledTest.testReconfig(StandaloneDisabledTest.java:243)
at 
org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest(StandaloneDisabledTest.java:68)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)


FAILED:  

[jira] [Updated] (ZOOKEEPER-3068) Improve C client logging of IPv6 hosts

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3068:
--
Labels: pull-request-available  (was: )

> Improve C client logging of IPv6 hosts
> --
>
> Key: ZOOKEEPER-3068
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3068
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: c client
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Trivial
>  Labels: pull-request-available
>
> The C client formats host-port pairings as [host:port] when logging. This is 
> visually confusing when the host is an IPv6 address (see the below). In that 
> case, it would be preferable to cleanly separate the IPv6 from the port. 
> {code:java}
> ZOO_INFO@check_events@2736: initiated connection to server 
> [2401:db00:1020:40bf:face:0:5:0:2181]{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #547: ZOOKEEPER-3068: Improve C client logging of IPv...

[enixon]

GitHub user enixon opened a pull request:

https://github.com/apache/zookeeper/pull/547

ZOOKEEPER-3068: Improve C client logging of IPv6 hosts



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/enixon/zookeeper ZOOKEEPER-3068

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/547.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #547


commit cd4045342ff14dd008bff95d1f54f925d8603bff
Author: Brian Nixon 
Date:   2018-06-22T18:23:37Z

ZOOKEEPER-3068: Improve C client logging of IPv6 hosts




---

[jira] [Created] (ZOOKEEPER-3068) Improve C client logging of IPv6 hosts

[Brian Nixon (JIRA)]

Brian Nixon created ZOOKEEPER-3068:
--

 Summary: Improve C client logging of IPv6 hosts
 Key: ZOOKEEPER-3068
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3068
 Project: ZooKeeper
  Issue Type: Improvement
  Components: c client
Affects Versions: 3.6.0
Reporter: Brian Nixon
Assignee: Brian Nixon


The C client formats host-port pairings as [host:port] when logging. This is 
visually confusing when the host is an IPv6 address (see the below). In that 
case, it would be preferable to cleanly separate the IPv6 from the port. 
{code:java}
ZOO_INFO@check_events@2736: initiated connection to server 
[2401:db00:1020:40bf:face:0:5:0:2181]{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper_branch34_openjdk7 - Build # 1967 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1967/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 41.08 KB...]
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.612 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.497 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.684 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.698 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.602 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.114 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.655 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.03 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.726 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.902 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.715 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.669 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.665 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.373 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.456 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.083 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.13 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
28.73 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.965 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.713 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1393:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1396:
 Tests failed!

Total time: 30 minutes 43 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Recording test results
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss

Error Message:
expected:<1> but was:<2>

Stack Trace:
junit.framework.AssertionFailedError: expected:<1> but was:<2>
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss(QuorumPeerMainTest.java:1202)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...

[eolivelli]

Github user eolivelli commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/546#discussion_r197497322
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -2069,4 +2073,9 @@ public QuorumCnxManager createCnxnManager() {
 this.quorumCnxnThreadsSize,
 this.isQuorumSaslAuthEnabled());
 }
+
+boolean isLeader(long id) {
+Vote vote = getCurrentVote();
+return vote != null && id == vote.getId();
--- End diff --

Should I rename the method to isLeaderForJmx or something similar?
I would like to make it clear that this method is only for external 
monitoring


---

[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...

[eolivelli]

Github user eolivelli commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/546#discussion_r197496922
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -2069,4 +2073,9 @@ public QuorumCnxManager createCnxnManager() {
 this.quorumCnxnThreadsSize,
 this.isQuorumSaslAuthEnabled());
 }
+
+boolean isLeader(long id) {
+Vote vote = getCurrentVote();
+return vote != null && id == vote.getId();
--- End diff --

@anmolnar
Do I have to check in the current view?
Is this about temporary leader election phase? I don't know the code very 
well

 can you please give an hint about this new test?

Do I have to simply test the check I am adding? Like a basic unit test with 
mockito?


---

Success: ZOOKEEPER- PreCommit Build #1857

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1857/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 82.97 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 9 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1857//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1857//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1857//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16520526 added to ZOOKEEPER-3066.
 [exec] Session logged out. Session was 
JSESSIONID=E0E0960D5E2CD4EA696F74348F38637C.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 23 minutes 7 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3066
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520526#comment-16520526
 ] 

Hadoop QA commented on ZOOKEEPER-3066:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1857//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1857//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1857//console

This message is automatically generated.

> Expose on JMX of Followers the id of the current leader
> ---
>
> Key: ZOOKEEPER-3066
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jmx, leaderElection, quorum
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> It will be useful to add to JMX beans published on Follower Peers to have an 
> information about the current "leader".
> This information is only available using 4 letter words



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/546#discussion_r197484891
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -2069,4 +2073,9 @@ public QuorumCnxManager createCnxnManager() {
 this.quorumCnxnThreadsSize,
 this.isQuorumSaslAuthEnabled());
 }
+
+boolean isLeader(long id) {
+Vote vote = getCurrentVote();
+return vote != null && id == vote.getId();
--- End diff --

You could use `state` property to check if the peer is the leader:
```java
return state == ServerState.LEADING;
```
What do you think?


---

[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/546#discussion_r197485176
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -2069,4 +2073,9 @@ public QuorumCnxManager createCnxnManager() {
 this.quorumCnxnThreadsSize,
 this.isQuorumSaslAuthEnabled());
 }
+
+boolean isLeader(long id) {
+Vote vote = getCurrentVote();
+return vote != null && id == vote.getId();
--- End diff --

I think it would be good to add unit test to verify this logic too.


---

Success: ZOOKEEPER- PreCommit Build #1856

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1856/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 86.19 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 48 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1856//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1856//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1856//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16520501 added to ZOOKEEPER-236.
 [exec] Session logged out. Session was 
JSESSIONID=387B9ACAF87E51DB4CA11D89BE0F81C6.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 3 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-236
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520501#comment-16520501
 ] 

Hadoop QA commented on ZOOKEEPER-236:
-

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 48 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1856//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1856//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1856//console

This message is automatically generated.

> SSL Support for Atomic Broadcast protocol
> -
>
> Key: ZOOKEEPER-236
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-236
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: quorum, security, server
>Reporter: Benjamin Reed
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available, ssl
>  Time Spent: 11h 10m
>  Remaining Estimate: 0h
>
> We should have the ability to use SSL to authenticate and encrypt the traffic 
> between ZooKeeper servers. For the most part this is a very easy change. We 
> would probably only want to support this for TCP based leader elections.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
@anmolnar 
test is clean now.

please also cherry pick to 3.5 branch. I am using that version 


---

[GitHub] zookeeper issue #541: ZOOKEEPER-3059 EventThread leak in case of Sasl AuthFa...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/541
  
Got it. Let's trigger a green build and I'll commit. 


---

[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/184
  
Added the 2 main properties to JMX as read-only properties.

About renaming: looks like that these 2 properties are slightly different 
from the others. Rest of the new settings have been split into 2 groups 
depending on whether they relate to Quorum or Client side of SSL. Hence the 2 
classes override the prefix: `zookeeper.ssl.*` properties belong to client 
side, `zookeeper.ssl.quorum.*` properties belong to Quorum side.

In contrast, `sslQuorum` and `portUnification` properties are global 
switches and don't really belong to any of the above groups, so keeping them 
"global" makes sense to me.


---

Failed: ZOOKEEPER- PreCommit Build #1855

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1855/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 91.04 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1855//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1855//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1855//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16520457 added to ZOOKEEPER-236.
 [exec] Session logged out. Session was 
JSESSIONID=4E4C3CDAF7A023297530CF10D7852CBE.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1810:
 exec returned: 1

Total time: 17 minutes 45 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-236
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset

Error Message:
test timed out after 60 milliseconds

Stack Trace:
org.junit.runners.model.TestTimedOutException: test timed out after 60 
milliseconds
at java.lang.Object.wait(Native Method)
at java.lang.Object.wait(Object.java:502)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1506)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1494)
at org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:2294)
at 
org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset(DisconnectedWatcherTest.java:243)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)

[jira] [Commented] (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520457#comment-16520457
 ] 

Hadoop QA commented on ZOOKEEPER-236:
-

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 48 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1855//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1855//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1855//console

This message is automatically generated.

> SSL Support for Atomic Broadcast protocol
> -
>
> Key: ZOOKEEPER-236
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-236
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: quorum, security, server
>Reporter: Benjamin Reed
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available, ssl
>  Time Spent: 11h
>  Remaining Estimate: 0h
>
> We should have the ability to use SSL to authenticate and encrypt the traffic 
> between ZooKeeper servers. For the most part this is a very easy change. We 
> would probably only want to support this for TCP based leader elections.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
@anmolnar I see with your point.

Will update the patch soon


---

[GitHub] zookeeper issue #541: ZOOKEEPER-3059 EventThread leak in case of Sasl AuthFa...

[abhishek-chouhan]

Github user abhishek-chouhan commented on the issue:

https://github.com/apache/zookeeper/pull/541
  
@anmolnar  The second one happens when 
zooKeeperSaslClient.initialize(ClientCnxn.this) throws an sasl exception, which 
from the code looks like can happen in case of incomplete initialization. In 
zookeeperSaslClient's constructor we call createSaslClient which in case of 
anything apart from LoginException will swallow the exception and would 
initialize the saslClient object as null(which would cause initialize to throw 
sasl exception in the null check). It however looks hard to simulate an 
exception in the initialization part, since there are static methods involved 
and stubbing zookeepersaslclient itself doesn't look to be an option.


---

[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/184
  
@ivmaykov Alright. :)

Wrapping up the outstanding items:

- config options renaming,
- exposing JMX properties

Hope I didn't miss anything.


---

ZooKeeper_branch34 - Build # 2388 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34/2388/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 28.73 KB...]
 [exec] Total time: 0 minutes 14 seconds,  Site size: 1,948,189 Site pages: 
65
 [exec] 
 [exec]   Copying broken links file to site root.
 [exec]   
 [exec] Copying 1 file to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/src/docs/build/site
 [exec] 
 [exec] -
 [exec] Static site was successfully generated at:
 [exec] 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/src/docs/build/site
 [exec] --
 [exec] 
 [exec] 
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 18 seconds
 [copy] Copying 109 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/docs
 [copy] Copied 7 empty directories to 3 empty directories under 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/docs
[style] Warning: the task name 

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
Thank you for the quick turnaround @eolivelli . Mockito unit test is cool, 
exactly what I meant to.

I think it's okay to validate the existence of JMX property in the existing 
test (similar checks were already there), but would you please remove checks 
for the *value* of the property? I really don't want the hammer test failing in 
case of an incorrect JMX value.


---

[GitHub] zookeeper issue #541: ZOOKEEPER-3059 EventThread leak in case of Sasl AuthFa...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/541
  
@abhishek-chouhan No problem, your test looking good. You've added 
`eventOfDeath` to 2 places in the code: line 824 and line 1168:
When I remove 824, your test will fail which is good. But if I remove 1168, 
test will still pass.

Under what conditions do we need the change at line 1168 and could you 
write unit test for that?


---

Success: ZOOKEEPER- PreCommit Build #1854

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1854/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 77.28 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 9 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1854//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1854//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1854//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16520279 added to ZOOKEEPER-3066.
 [exec] Session logged out. Session was 
JSESSIONID=5830D802CB58FAC0DDAFD47976C9FC82.
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 17 minutes 35 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3066
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520279#comment-16520279
 ] 

Hadoop QA commented on ZOOKEEPER-3066:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1854//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1854//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1854//console

This message is automatically generated.

> Expose on JMX of Followers the id of the current leader
> ---
>
> Key: ZOOKEEPER-3066
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jmx, leaderElection, quorum
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It will be useful to add to JMX beans published on Follower Peers to have an 
> information about the current "leader".
> This information is only available using 4 letter words



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
@anmolnar @nkalmar @ivankelly 
Thank you all for helping me with this patch.

I have added a bunch of Mockito based tests.

About the existing test..I have only added a check on real JMX about 
isLeader, the test was already there.
I can revert the changes on the existing test if you feel strong about it, 
but IMHO it ia not a big deal 


---

Success: ZOOKEEPER- PreCommit Build #1853

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1853/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 81.81 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1853//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1853//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1853//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16520264 added to ZOOKEEPER-3066.
 [exec] Session logged out. Session was 
JSESSIONID=8D0BECA6DFE1EBF2862487874221CB0D.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 43 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3066
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520264#comment-16520264
 ] 

Hadoop QA commented on ZOOKEEPER-3066:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1853//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1853//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1853//console

This message is automatically generated.

> Expose on JMX of Followers the id of the current leader
> ---
>
> Key: ZOOKEEPER-3066
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jmx, leaderElection, quorum
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> It will be useful to add to JMX beans published on Follower Peers to have an 
> information about the current "leader".
> This information is only available using 4 letter words



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper_branch34_jdk8 - Build # 1437 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1437/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 40.15 KB...]
[junit] Running org.apache.zookeeper.test.RepeatStartupTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.391 sec
[junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
19.183 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.94 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.875 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.357 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.764 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.876 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.81 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.111 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.877 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.61 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.075 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.022 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.101 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.829 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.844 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.654 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.171 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.107 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.593 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
28.093 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.175 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.885 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1393: 
The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1396: 
Tests failed!

Total time: 40 minutes 57 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
3 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumCnxManagerTest.testNoAuthLearnerConnectsToServerWithAuthNotRequired

Error Message:
Address already in use (Bind failed)

Stack Trace:
java.net.BindException: Address already in use (Bind failed)
at java.net.PlainSocketImpl.socketBind(Native Method)
at 
java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
at java.net.ServerSocket.bind(ServerSocket.java:375)
at java.net.ServerSocket.bind(ServerSocket.java:329)
at 

Re: Recent ZK Jenkins failures due to SSL protocol changes on central

[Andor Molnar]

+1, drop JDK 1.6 support

Andor



On Fri, Jun 22, 2018 at 5:53 AM, Michael Han  wrote:

> +1 on dropping JDK 1.6 support for branch-3.4.
>
> On Thu, Jun 21, 2018 at 3:55 PM, Brian Nixon 
> wrote:
>
> > +1 for discontinuing support for jdk1.6
> >
> >
> > On Thu, Jun 21, 2018 at 7:58 AM, Norbert Kalmar <
> > nkal...@cloudera.com.invalid> wrote:
> >
> > > Hi Patrick,
> > >
> > > In my opinion terminating support for java 1.6 is a good idea. Even
> it's
> > > extended support will end this year (
> > > http://www.oracle.com/technetwork/java/javase/eol-135779.html).
> > > And the projects I've seen are all updated from java 6 by now,
> especially
> > > as more and more libraries and components are discontinuing support for
> > 1.6
> > > (WebSphere, just to name one).
> > >
> > > Regards,
> > > Norbert
> > >
> > > On Thu, Jun 21, 2018 at 4:30 PM Patrick Hunt  wrote:
> > >
> > > > FYI - I believe we're seeing:
> > > >
> > > > https://blog.sonatype.com/enhancing-ssl-security-and-
> > > http/2-support-for-central
> > > >
> > > > 
> > > > ivy-download:
> > > >   [get] Getting:
> > > > https://repo1.maven.org/maven2/org/apache/ivy/ivy/2.4.
> 0/ivy-2.4.0.jar
> > > >   [get] To:
> > > >
> > > > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/
> > > src/java/lib/ivy-2.4.0.jar
> > > >   [get] Error getting
> > > > https://repo1.maven.org/maven2/org/apache/ivy/ivy/2.4.
> 0/ivy-2.4.0.jar
> > to
> > > >
> > > > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/
> > > src/java/lib/ivy-2.4.0.jar
> > > >
> > > > BUILD FAILED
> > > > /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/
> > build.xml:392:
> > > > javax.net.ssl.SSLException: Received fatal alert: protocol_version
> > > > -
> > > >
> > > > It looks like we are ok with jdk 1.8+, and can mitigate 1.7, however
> > 1.6
> > > > and earlier jdks have no option (aside turning off https usage which
> > > > doesn't appeal to me).
> > > >
> > > > I can update the jenkins 1.7 based jobs. Thoughts on 1.6 and earlier?
> > > > Perhaps we should use this as an opportunity to explicitly/officially
> > > > discontinue support in the next version?
> > > >
> > > > http://zookeeper.apache.org/doc/r3.4.12/zookeeperAdmin.
> > > html#sc_requiredSoftware
> > > >
> > > > Patrick
> > > >
> > >
> >
>

[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/546#discussion_r197395687
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java ---
@@ -36,7 +36,7 @@ public void 
testGetClientAddressShouldReturnEmptyStringWhenClientAddressIsNull()
 InetSocketAddress peerCommunicationAddress = null;
 // Here peerCommunicationAddress is null, also clientAddr is null
 QuorumServer peer = new QuorumServer(1, peerCommunicationAddress);
-RemotePeerBean remotePeerBean = new RemotePeerBean(peer);
+RemotePeerBean remotePeerBean = new RemotePeerBean(null 
/*QuorumPeer*/, peer);
--- End diff --

Do you think that comment could be useful? Modern IDEs like intellij give 
hints about null arguments and the comment seems to be redundant to me.


---

[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/546#discussion_r197403323
  
--- Diff: 
src/java/test/org/apache/zookeeper/test/HierarchicalQuorumTest.java ---
@@ -226,38 +227,108 @@ void startServers(boolean withObservers) throws 
Exception {
 CONNECTION_TIMEOUT));
 LOG.info(hp + " is accepting client connections");
 }
+LOG.info("initial status " + s1.getCurrentVote() + "," + 
s2.getCurrentVote() + "," + s3.getCurrentVote());
--- End diff --

I think this is not right approach for testing this. The patch is about 
adding a new field to a JMX bean to expose a new attribute of ZooKeeper. This 
test is part of `ClientHammerTest`: completely different things. For example, 
if the new functionality got broken and JMX value is not exposed correctly, 
we'll see that `ClientHammerTest` is failing which is terribly misleading.

Please revert changes to this file and add more unit tests to 
`RemotePeerBeenTest`, because that is essentially what you've changed in this 
patch and you want to validate. I'd do something like this in a new test:

```java
...
QuorumPeer peerMock = mock(QuorumPeer.class);
RemotePeerBean remotePeerBean = new RemotePeerBean(peerMock, new 
QuorumServer(5, ...));
when(peerMock.isLeader(peerId)).return(true);
assertThat("Remote peer bean should expose isLeader() property of remote 
peer", remotePeerBean.isLeader(5), isTrue());
...
```

Haven't tested the code, sorry if it's not working out of the box, but 
hopefully give you an idea.


---

ZooKeeper_branch34 - Build # 2387 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34/2387/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 28.74 KB...]
 [exec] Total time: 0 minutes 13 seconds,  Site size: 1,948,189 Site pages: 
65
 [exec] 
 [exec]   Copying broken links file to site root.
 [exec]   
 [exec] Copying 1 file to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/src/docs/build/site
 [exec] 
 [exec] -
 [exec] Static site was successfully generated at:
 [exec] 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/src/docs/build/site
 [exec] --
 [exec] 
 [exec] 
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 18 seconds
 [copy] Copying 109 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/docs
 [copy] Copied 7 empty directories to 3 empty directories under 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/docs
[style] Warning: the task name 

ZooKeeper_branch34_jdk8 - Build # 1436 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1436/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 40.19 KB...]
[junit] Running org.apache.zookeeper.test.RepeatStartupTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.405 sec
[junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
19.237 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.879 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.814 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.881 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.716 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.943 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.83 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.109 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.818 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
10.965 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.049 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.98 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.56 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.85 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.845 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
10.63 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.153 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.09 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.574 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
30.625 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
18.225 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.881 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1393: 
The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1396: 
Tests failed!

Total time: 41 minutes 40 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
3 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumCnxManagerTest.testNoAuthLearnerConnectsToServerWithAuthNotRequired

Error Message:
Address already in use (Bind failed)

Stack Trace:
java.net.BindException: Address already in use (Bind failed)
at java.net.PlainSocketImpl.socketBind(Native Method)
at 
java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
at java.net.ServerSocket.bind(ServerSocket.java:375)
at java.net.ServerSocket.bind(ServerSocket.java:329)
at 

Failed: ZOOKEEPER-1816 PreCommit Build #3695

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1816
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3695/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 2.98 KB...]

forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-1816.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] ZOOKEEPER-1816 patch is being downloaded at Fri Jun 22 06:02:49 UTC 
2018 from
 [exec] 
http://issues.apache.org/jira/secure/attachment/12837908/ZOOKEEPER-1816.patch
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Pre-build trunk to verify trunk stability and javac warnings
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/latest/bin/ant  -Djavac.args=-Xlint 
-Xmaxwarns 1000 -Djava5.home=/home/jenkins/tools/java5/latest/ 
-Dforrest.home=/home/jenkins/tools/forrest/latest/ -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/build.xml:1785:
 exec returned: 1

Total time: 34 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-2368
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER-832 PreCommit Build #3694

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-832
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3694/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 2.59 KB...]

forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-832.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] ZOOKEEPER-832 patch is being downloaded at Fri Jun 22 06:02:46 UTC 
2018 from
 [exec] 
http://issues.apache.org/jira/secure/attachment/12752793/ZOOKEEPER-832.patch
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Pre-build trunk to verify trunk stability and javac warnings
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/latest/bin/ant  -Djavac.args=-Xlint 
-Xmaxwarns 1000 -Djava5.home=/home/jenkins/tools/java5/latest/ 
-Dforrest.home=/home/jenkins/tools/forrest/latest/ -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1785: 
exec returned: 1

Total time: 38 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-2368
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.