[jira] [Commented] (ZOOKEEPER-451) ZK should enforce quota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524477#comment-16524477 ] Vi commented on ZOOKEEPER-451: -- Hello, I see this feature had a patch which did not make it through. Any reason why we can't merge it? I currently took this patch and applied it over 3.5.3-beta to make it work with few changes, it seems to pass all tests. Please let me know. Thanks. > ZK should enforce quota > --- > > Key: ZOOKEEPER-451 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-451 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.2.0 >Reporter: Raghu S >Assignee: Botond Hejj >Priority: Major > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-451.patch, ZOOKEEPER-451.patch, > ZOOKEEPER-451.patch > > > Email exchange with Mahadev: > Mahadev Konar wrote: > > Hi Raghu, > > We do have plans to enforce quota in future. Enforcing requires some more > > work then just reporting. Reporting is a good enough tool for operations to > > manage a zookeeper cluster but we would certainly like to enforce it in the > > near future. > > > > Thanks > > mahadev > > > > > > On 6/18/09 7:01 PM, "rag...@yahoo.com" wrote: > > > >> Is there a reason why node count/byte quota is not actually enforced but > >> rather ZK just warns? Are there any plans to enforce the quota in a future > >> release? > >> > >> Thanks > >> Raghu > >> > >> > >> > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198339591
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -259,6 +259,11 @@ public QuorumServer(long sid, String addressStr)
throws ConfigException {
throw new ConfigException("Address unresolved: " +
serverParts[0] + ":" + serverParts[2]);
}
+if(addr.getPort() == electionAddr.getPort()) {
--- End diff --
really happy we're adding this safeguard!
---
[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198338704
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -259,6 +259,11 @@ public QuorumServer(long sid, String addressStr)
throws ConfigException {
throw new ConfigException("Address unresolved: " +
serverParts[0] + ":" + serverParts[2]);
}
+if(addr.getPort() == electionAddr.getPort()) {
+throw new ConfigException(
+"Client and election port must be different!
Please update the configuration file on server." + sid);
+}
+
--- End diff --
Does it make sense to apply a similar change to the
`public QuorumServer(long id, InetSocketAddress addr,
InetSocketAddress electionAddr, InetSocketAddress clientAddr, LearnerType
type) {`
constructor below?
---
[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198338264
--- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java ---
@@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean
testLeader) throws Exception {
@Test
public void testUnspecifiedClientAddress() throws Exception {
- int[] ports = new int[3];
- for (int port : ports) {
- port = PortAssignment.unique();
- }
+ int[] ports = {
+PortAssignment.unique(),
+PortAssignment.unique(),
+PortAssignment.unique()
+ };
+
--- End diff --
is it necessary to make this change?
---
[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198338214
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java ---
@@ -103,6 +103,23 @@ public void testCustomSSLAuth()
}
}
+/**
+ * Test case for https://issues.apache.org/jira/browse/ZOOKEEPER-2873
+ */
+@Test
+public void testSamePortConfiguredForClientAndElection() throws
IOException, ConfigException {
--- End diff --
nit - ConfigException is unused
---
[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/549#discussion_r198339563
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java ---
@@ -103,6 +103,23 @@ public void testCustomSSLAuth()
}
}
+/**
+ * Test case for https://issues.apache.org/jira/browse/ZOOKEEPER-2873
+ */
+@Test
+public void testSamePortConfiguredForClientAndElection() throws
IOException, ConfigException {
+QuorumPeerConfig quorumPeerConfig = new QuorumPeerConfig();
+try {
+Properties zkProp = getDefaultZKProperties();
+zkProp.setProperty("server.1", "localhost:2888:2888");
+quorumPeerConfig.parseProperties(zkProp);
+fail("ConfigException is expected");
+} catch (ConfigException ce) {
--- End diff --
Instead of the try-catch paradigm, can we use `@Test(expected =
ConfigException.class)`?
---
ZooKeeper-trunk - Build # 77 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk/77/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 142.24 KB...] [junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 5 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.769 sec, Thread: 2, Class: org.apache.zookeeper.test.SaslSuperUserTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.694 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionInvalidationTest [junit] Running org.apache.zookeeper.test.SessionTest in thread 2 [junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 5 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.45 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTimeoutTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.46 sec, Thread: 3, Class: org.apache.zookeeper.test.ServerCnxnTest [junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 5 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.097 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTrackerCheckTest [junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 3 [junit] Running org.apache.zookeeper.test.StandaloneTest in thread 5 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.686 sec, Thread: 5, Class: org.apache.zookeeper.test.StandaloneTest [junit] Running org.apache.zookeeper.test.StatTest in thread 5 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.155 sec, Thread: 5, Class: org.apache.zookeeper.test.StatTest [junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 5 [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.778 sec, Thread: 5, Class: org.apache.zookeeper.test.StaticHostProviderTest [junit] Running org.apache.zookeeper.test.StringUtilTest in thread 5 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.069 sec, Thread: 5, Class: org.apache.zookeeper.test.StringUtilTest [junit] Running org.apache.zookeeper.test.SyncCallTest in thread 5 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.77 sec, Thread: 5, Class: org.apache.zookeeper.test.SyncCallTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.481 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTest [junit] Running org.apache.zookeeper.test.TruncateTest in thread 2 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 71.949 sec, Thread: 6, Class: org.apache.zookeeper.test.QuorumZxidSyncTest [junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in thread 5 [junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 6 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.077 sec, Thread: 6, Class: org.apache.zookeeper.test.WatchedEventTest [junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 6 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.229 sec, Thread: 6, Class: org.apache.zookeeper.test.WatcherFuncTest [junit] Running org.apache.zookeeper.test.WatcherTest in thread 6 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.995 sec, Thread: 2, Class: org.apache.zookeeper.test.TruncateTest [junit] Running org.apache.zookeeper.test.X509AuthTest in thread 2 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.089 sec, Thread: 2, Class: org.apache.zookeeper.test.X509AuthTest [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in thread 2 [junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 85.777 sec, Thread: 1, Class: org.apache.zookeeper.test.QuorumTest [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.763 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionUpgradeTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.803 sec, Thread: 1, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.623 sec, Thread: 5, Class: org.apache.zookeeper.test.WatchEventWhenAutoResetTest [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.71 sec, Thread: 2, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.279 sec, Thread: 6, Class: org.apache.zookeeper.test.WatcherTest [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 261.903 sec,
[GitHub] zookeeper issue #353: [ZOOKEEPER-2886] Permanent session moved error in mult...
Github user breed commented on the issue: https://github.com/apache/zookeeper/pull/353 +1 thanx @lvfangmin ! this looks good to me. are you okay with this @anmolnar ? ---
Success: ZOOKEEPER- PreCommit Build #1879
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1879/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 84.87 MB...] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1879//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1879//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1879//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16524108 added to ZOOKEEPER-3068. [exec] Session logged out. Session was JSESSIONID=0C1755431B23EEE4EF3C7F1FB147FBCA. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 17 minutes 29 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3068 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-3068) Improve C client logging of IPv6 hosts
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524108#comment-16524108
]
Hadoop QA commented on ZOOKEEPER-3068:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1879//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1879//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1879//console
This message is automatically generated.
> Improve C client logging of IPv6 hosts
> --
>
> Key: ZOOKEEPER-3068
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3068
> Project: ZooKeeper
> Issue Type: Improvement
> Components: c client
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Trivial
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The C client formats host-port pairings as [host:port] when logging. This is
> visually confusing when the host is an IPv6 address (see the below). In that
> case, it would be preferable to cleanly separate the IPv6 from the port.
> {code:java}
> ZOO_INFO@check_events@2736: initiated connection to server
> [2401:db00:1020:40bf:face:0:5:0:2181]{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3060) Logging the server local port to stderr
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohamed Jeelani resolved ZOOKEEPER-3060. Resolution: Not A Problem Fix Version/s: (was: 3.6.0) Closing this as per discussion in the pull request - This is only useful when we don't use 0 as the port in the address, which won't happen in realistic for prod usage, so it's not that meaningful to have this patch. > Logging the server local port to stderr > > > Key: ZOOKEEPER-3060 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3060 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.12 >Reporter: Mohamed Jeelani >Assignee: Mohamed Jeelani >Priority: Minor > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > This simple straightforward patch adds logging of the server local port to > stderr which aids in simplifying debugging if you want to have to look that up -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3060) Logging the server local port to stderr
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524029#comment-16524029 ] Mohamed Jeelani commented on ZOOKEEPER-3060: Closing this as per discussion in the pull request - This is only useful when we don't use 0 as the port in the address, which won't happen in realistic for prod usage, so it's not that meaningful to have this patch. > Logging the server local port to stderr > > > Key: ZOOKEEPER-3060 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3060 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.12 >Reporter: Mohamed Jeelani >Assignee: Mohamed Jeelani >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 40m > Remaining Estimate: 0h > > This simple straightforward patch adds logging of the server local port to > stderr which aids in simplifying debugging if you want to have to look that up -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper pull request #542: [ZOOKEEPER-3060] Logging the server local port ...
Github user mjeelanimsft closed the pull request at: https://github.com/apache/zookeeper/pull/542 ---
[GitHub] zookeeper issue #542: [ZOOKEEPER-3060] Logging the server local port to stde...
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/542 This is only useful when we don't use 0 as the port in the address, which won't happen in realistic for prod usage, so it's not that meaningful to have this patch. @mjeelanimsft we only use it internally for testing purpose, should consider to abandon this patch. ---
[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r198228442
--- Diff: src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java
---
@@ -86,7 +86,7 @@ public static String send4LetterWord(String host, int
port, String cmd, boolean
throws IOException, SSLContextException {
LOG.info("connecting to {} {}", host, port);
Socket sock;
-InetSocketAddress hostaddress= host != null ? new
InetSocketAddress(host, port) :
+InetSocketAddress hostaddress = host != null ? new
InetSocketAddress(host, port) :
--- End diff --
@mjeelanimsft generally, this is due to the auto-format in the editor, but
I think we should remove this change from this diff, given we haven't changed
other logic except this one.
---
[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r198228805
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -225,17 +229,25 @@ static public InitialMessage parse(Long
protocolVersion, DataInputStream din)
// FIXME: IPv6 is not supported. Using something like Guava's
HostAndPort
//parser would be good.
String addr = new String(b);
-String[] host_port = addr.split(":");
+String[] host_port;
+try {
+host_port = ConfigUtils.splitServerConfig(addr);
+} catch (ConfigException e) {
+throw new InitialMessageException("Badly formed address:
%s", addr);
+}
if (host_port.length != 2) {
throw new InitialMessageException("Badly formed address:
%s", addr);
}
+//String[] host_port = addr.split(":");
--- End diff --
Remove this line.
---
[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r198229351
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java
---
@@ -58,10 +58,10 @@ public void tearDown() throws Exception {
}
/*
- * Tests that an incremental reconfig fails if the current config is
hiearchical.
+ * Tests that an incremental reconfig fails if the current config is
hierarchical.
--- End diff --
Please remove this unrelated change as well.
---
[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r198227173
--- Diff: src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java
---
@@ -86,7 +86,7 @@ public static String send4LetterWord(String host, int
port, String cmd, boolean
throws IOException, SSLContextException {
LOG.info("connecting to {} {}", host, port);
Socket sock;
-InetSocketAddress hostaddress= host != null ? new
InetSocketAddress(host, port) :
+InetSocketAddress hostaddress = host != null ? new
InetSocketAddress(host, port) :
--- End diff --
This is generally due to some auto format done in editor.
---
[jira] [Commented] (ZOOKEEPER-2701) Timeout for RecvWorker is too long
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523964#comment-16523964
]
Tom Lee commented on ZOOKEEPER-2701:
Not entirely sure our symptoms were exactly the same as [~jiangjiafu], but
believe we were bitten by the `setSoTimeout(0)` thing too (we're running
3.4.11). Still trying to work out the exact circumstances that cause the issue
to occur, but I suspect it's something like:
# a NIC intermittently drops out & recovers quickly on a follower.
# #1 is enough to cause socket writes to fail in such a way that Linux packet
retransmission + exponential backoff foo kicks.
# the follower attempts to rejoin the cluster, but is unable to due to some
combination of the above failing write(s) and rejecting new inbound connections
from other members of the quorum because "There is already a connection for
server X".
# roughly 15-16 minutes later, Linux detects the connection is dead after
exhausting packet retransmission retries & forces the connections closed.
# #4 allows new inbound connections, socket writes start succeeding, the
follower rejoins the quorum and everything is great again.
This prevents the follower from rejoining the quorum, which obviously isn't
great. Given that, this is a little worse than a "Minor" issue when it happens
IMO – if you're unlucky this could happen across multiple machines at the same
time & easily lead to quorum loss.
I may not have the exact details down, but it's _something_ like that. This
issue has been occurring regularly across multiple clusters we've got running
in EC2.
If it's useful to anybody playing along at home: we're experimenting with
[tcp_retries2|https://www.kernel.org/doc/Documentation/networking/ip-sysctl.txt]
to work around the issue at a system level. The default behavior in our setup
(which from a quick google seems to be pretty standard) is to retry 15 times
with up to a 2 minute delay between retries for a total of 15-16 minutes –
seems safe to be a bit more aggressive given our ZK hosts are all in the same
EC2 region. I've seen some suggestions of folks going with 3 retries, but we're
being a bit more conservative & going with 5 for now, which should let us
detect dead connections within a few seconds.
> Timeout for RecvWorker is too long
> --
>
> Key: ZOOKEEPER-2701
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2701
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.8, 3.4.9, 3.4.10
> Environment: Centos6.5
> ZooKeeper 3.4.8
>Reporter: Jiafu Jiang
>Priority: Minor
>
> Environment:
> I deploy ZooKeeper in a cluster of three nodes. Each node has three network
> interfaces(eth0, eth1, eth2).
> Hostname is used instead of IP address in zoo.cfg, and
> quorumListenOnAllIPs=true
> Probleam:
> I start three ZooKeeper servers( node A, node B, and node C) one by one,
> when the leader election finishes, node B is the leader.
> Then I shutdown one network interface of node A by command "ifdown eth0". The
> ZooKeeper server on node A will lost connection to node B and node C. In my
> test, I will take about 20 minites that the ZooKeepr server of node A
> realizes the event and try to call the QuorumServer.recreateSocketAddress the
> resolve the hostname.
> I try to read the source code, and I find the code in
> {code:title=QuorumCnxManager.java:|borderStyle=solid}
> class RecvWorker extends ZooKeeperThread {
> Long sid;
> Socket sock;
> volatile boolean running = true;
> final DataInputStream din;
> final SendWorker sw;
> RecvWorker(Socket sock, DataInputStream din, Long sid, SendWorker sw)
> {
> super("RecvWorker:" + sid);
> this.sid = sid;
> this.sock = sock;
> this.sw = sw;
> this.din = din;
> try {
> // OK to wait until socket disconnects while reading.
> sock.setSoTimeout(0);
> } catch (IOException e) {
> LOG.error("Error while accessing socket for " + sid, e);
> closeSocket(sock);
> running = false;
> }
> }
>...
> }
> {code}
> I notice that the soTime is set to 0 in RecvWorker constructor. I think this
> is reasonable when the IP address of a ZooKeeper server never change, but
> considering that the IP address of each ZooKeeper server may change, maybe we
> should better set a timeout here.
> I am not pretty sure this is really a problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Success: ZOOKEEPER- PreCommit Build #1878
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1878/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 84.80 MB...] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +0 tests included. The patch appears to be a documentation patch that doesn't require tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1878//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1878//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1878//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16523753 added to ZOOKEEPER-3022. [exec] Session logged out. Session was JSESSIONID=7744017FF03F70E5BC7E0954BB334D9D. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 17 minutes 32 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3022 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Updated] (ZOOKEEPER-3022) Step 1 - Separate project structure
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3022:
--
Labels: pull-request-available (was: )
> Step 1 - Separate project structure
> ---
>
> Key: ZOOKEEPER-3022
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Labels: pull-request-available
>
> Create a project structure that separates the different parts of ZooKeeper
> into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> * First iteration - safe changes including moving src/docs to zk-docs,
> creating zk-it empty directory. Build and conf directory remains unchanged.
> These changes also have minimum impact on PR’s.
> * Second iteration - move src/recipes to zk-recipes.
> * Third iteration - move src/contrib to zk-contrib.
> * Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
> * Fifth iteration - move src/java/main to zk-server, which will be further
> separated in Step 2.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -zookeeper-client
> || -zookeeper-client-c
> | -zookeeper-contrib
> || -zookeeper-contrib-fatjar
> || -zookeeper-contrib-huebrowser
> || -zookeeper-contrib-loggraph
> || -zookeeper-contrib-monitoring
> || -zookeeper-contrib-rest
> || -zookeeper-contrib-zkfuse
> || -zookeeper-contrib-zkperl
> || -zookeeper-contrib-zkpython
> || -zookeeper-contrib-zktreeutil
> |\ -zookeeper-contrib-zooinspector
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-server
> | -zookeeper-recipes
> || -zookeeper-recipes-election
> || -zookeeper-recipes-lock
> \\ -zookeeper-recipes-queue
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] zookeeper pull request #550: ZOOKEEPER-3022 - Iteration 1 - docs, it
GitHub user nkalmar opened a pull request: https://github.com/apache/zookeeper/pull/550 ZOOKEEPER-3022 - Iteration 1 - docs, it First iteration of the directory changes in maven migration. This time, the empty zookeeper-it for future integration tests were created, and the docs source were moved to zookeeper-docs. Tested with forest v0.9, documents generations were successful with ant. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-3022-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/550.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #550 commit 93c44dfcfec7755413a3da938564c12748fa5c36 Author: Norbert Kalmar Date: 2018-06-26T13:30:40Z ZOOKEEPER-3022 - Iteration 1 - docs, it ---
[jira] [Commented] (ZOOKEEPER-3069) document: is mutual auth with DIGEST-MD5 insecure?
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523698#comment-16523698 ] Jan Zerebecki commented on ZOOKEEPER-3069: -- Perhaps: DIGEST-MD5 and MD5 are different things. > document: is mutual auth with DIGEST-MD5 insecure? > -- > > Key: ZOOKEEPER-3069 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3069 > Project: ZooKeeper > Issue Type: Bug > Components: documentation >Reporter: Jan Zerebecki >Priority: Minor > > The [documentation regarding mutual ZooKeeper server to server authentication > with > DIGEST-MD5|https://cwiki.apache.org/confluence/display/ZOOKEEPER/Server-Server+mutual+authentication#Server-Servermutualauthentication-DIGEST-MD5basedauthentication] > currently doesn't mention whether this is insecure. [DIGEST-MD5 was declared > obsolete in 2011 due to security > problems.|https://tools.ietf.org/html/rfc6331] > This is in relation to whether this is an effective mitigation for > CVE-2018-8012 AKA ZOOKEEPER-1045, as mentioned in > [https://lists.apache.org/thread.html/c75147028c1c79bdebd4f8fa5db2b77da85de2b05ecc0d54d708b393@%3Cdev.zookeeper.apache.org%3E]. > Would the following be a fitting addition to the documentation?: > DIGEST-MD5 based authentication should not be relied on for authentication as > it is insecure, it is only provided for test purposes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3069) document: is mutual auth with DIGEST-MD5 insecure?
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523694#comment-16523694 ] Jan Zerebecki commented on ZOOKEEPER-3069: -- [~maoling], how does what you said relate to the topic of this bug? > document: is mutual auth with DIGEST-MD5 insecure? > -- > > Key: ZOOKEEPER-3069 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3069 > Project: ZooKeeper > Issue Type: Bug > Components: documentation >Reporter: Jan Zerebecki >Priority: Minor > > The [documentation regarding mutual ZooKeeper server to server authentication > with > DIGEST-MD5|https://cwiki.apache.org/confluence/display/ZOOKEEPER/Server-Server+mutual+authentication#Server-Servermutualauthentication-DIGEST-MD5basedauthentication] > currently doesn't mention whether this is insecure. [DIGEST-MD5 was declared > obsolete in 2011 due to security > problems.|https://tools.ietf.org/html/rfc6331] > This is in relation to whether this is an effective mitigation for > CVE-2018-8012 AKA ZOOKEEPER-1045, as mentioned in > [https://lists.apache.org/thread.html/c75147028c1c79bdebd4f8fa5db2b77da85de2b05ecc0d54d708b393@%3Cdev.zookeeper.apache.org%3E]. > Would the following be a fitting addition to the documentation?: > DIGEST-MD5 based authentication should not be relied on for authentication as > it is insecure, it is only provided for test purposes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3022) Step 1 - Separate project structure
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norbert Kalmar updated ZOOKEEPER-3022:
--
Description:
Create a project structure that separates the different parts of ZooKeeper into
a more meaningful packages for the future maven build.
This should be done in iterations to limit the impact.
First iteration - safe changes including moving src/docs to zk-docs, creating
zk-it empty directory. Build and conf directory remains unchanged. These
changes also have minimum impact on PR’s.
Second iteration - move src/recipes to zk-recipes.
Third iteration - move src/contrib to zk-contrib.
Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
Fifth iteration - move src/java/main to zk-server, which will be further
separated in Step 2.
{noformat}
zookeeper
| -bin
| -conf
| -zookeeper-client
|| -zookeeper-client-c
| -zookeeper-contrib
|| -zookeeper-contrib-fatjar
|| -zookeeper-contrib-huebrowser
|| -zookeeper-contrib-loggraph
|| -zookeeper-contrib-monitoring
|| -zookeeper-contrib-rest
|| -zookeeper-contrib-zkfuse
|| -zookeeper-contrib-zkperl
|| -zookeeper-contrib-zkpython
|| -zookeeper-contrib-zktreeutil
|\ -zookeeper-contrib-zooinspector
| -zookeeper-docs
| -zookeeper-it (integration tests)
| -zookeeper-server
| -zookeeper-recipes
|| -zookeeper-recipes-election
|| -zookeeper-recipes-lock
\\ -zookeeper-recipes-queue
{noformat}
was:
Create a project structure that separates the different parts of ZooKeeper into
a more meaningful packages for the future maven build.
This first step should not impact Jenkins QA.
{noformat}
zookeeper
|-bin
|-conf
|-zk-client
| |-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
> Step 1 - Separate project structure
> ---
>
> Key: ZOOKEEPER-3022
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
>
> Create a project structure that separates the different parts of ZooKeeper
> into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> First iteration - safe changes including moving src/docs to zk-docs, creating
> zk-it empty directory. Build and conf directory remains unchanged. These
> changes also have minimum impact on PR’s.
> Second iteration - move src/recipes to zk-recipes.
> Third iteration - move src/contrib to zk-contrib.
> Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
> Fifth iteration - move src/java/main to zk-server, which will be further
> separated in Step 2.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -zookeeper-client
> || -zookeeper-client-c
> | -zookeeper-contrib
> || -zookeeper-contrib-fatjar
> || -zookeeper-contrib-huebrowser
> || -zookeeper-contrib-loggraph
> || -zookeeper-contrib-monitoring
> || -zookeeper-contrib-rest
> || -zookeeper-contrib-zkfuse
> || -zookeeper-contrib-zkperl
> || -zookeeper-contrib-zkpython
> || -zookeeper-contrib-zktreeutil
> |\ -zookeeper-contrib-zooinspector
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-server
> | -zookeeper-recipes
> || -zookeeper-recipes-election
> || -zookeeper-recipes-lock
> \\ -zookeeper-recipes-queue
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3022) Step 1 - Separate project structure
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norbert Kalmar updated ZOOKEEPER-3022:
--
Description:
Create a project structure that separates the different parts of ZooKeeper into
a more meaningful packages for the future maven build.
This should be done in iterations to limit the impact.
* First iteration - safe changes including moving src/docs to zk-docs, creating
zk-it empty directory. Build and conf directory remains unchanged. These
changes also have minimum impact on PR’s.
* Second iteration - move src/recipes to zk-recipes.
* Third iteration - move src/contrib to zk-contrib.
* Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
* Fifth iteration - move src/java/main to zk-server, which will be further
separated in Step 2.
{noformat}
zookeeper
| -bin
| -conf
| -zookeeper-client
|| -zookeeper-client-c
| -zookeeper-contrib
|| -zookeeper-contrib-fatjar
|| -zookeeper-contrib-huebrowser
|| -zookeeper-contrib-loggraph
|| -zookeeper-contrib-monitoring
|| -zookeeper-contrib-rest
|| -zookeeper-contrib-zkfuse
|| -zookeeper-contrib-zkperl
|| -zookeeper-contrib-zkpython
|| -zookeeper-contrib-zktreeutil
|\ -zookeeper-contrib-zooinspector
| -zookeeper-docs
| -zookeeper-it (integration tests)
| -zookeeper-server
| -zookeeper-recipes
|| -zookeeper-recipes-election
|| -zookeeper-recipes-lock
\\ -zookeeper-recipes-queue
{noformat}
was:
Create a project structure that separates the different parts of ZooKeeper into
a more meaningful packages for the future maven build.
This should be done in iterations to limit the impact.
First iteration - safe changes including moving src/docs to zk-docs, creating
zk-it empty directory. Build and conf directory remains unchanged. These
changes also have minimum impact on PR’s.
Second iteration - move src/recipes to zk-recipes.
Third iteration - move src/contrib to zk-contrib.
Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
Fifth iteration - move src/java/main to zk-server, which will be further
separated in Step 2.
{noformat}
zookeeper
| -bin
| -conf
| -zookeeper-client
|| -zookeeper-client-c
| -zookeeper-contrib
|| -zookeeper-contrib-fatjar
|| -zookeeper-contrib-huebrowser
|| -zookeeper-contrib-loggraph
|| -zookeeper-contrib-monitoring
|| -zookeeper-contrib-rest
|| -zookeeper-contrib-zkfuse
|| -zookeeper-contrib-zkperl
|| -zookeeper-contrib-zkpython
|| -zookeeper-contrib-zktreeutil
|\ -zookeeper-contrib-zooinspector
| -zookeeper-docs
| -zookeeper-it (integration tests)
| -zookeeper-server
| -zookeeper-recipes
|| -zookeeper-recipes-election
|| -zookeeper-recipes-lock
\\ -zookeeper-recipes-queue
{noformat}
> Step 1 - Separate project structure
> ---
>
> Key: ZOOKEEPER-3022
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
>
> Create a project structure that separates the different parts of ZooKeeper
> into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> * First iteration - safe changes including moving src/docs to zk-docs,
> creating zk-it empty directory. Build and conf directory remains unchanged.
> These changes also have minimum impact on PR’s.
> * Second iteration - move src/recipes to zk-recipes.
> * Third iteration - move src/contrib to zk-contrib.
> * Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
> * Fifth iteration - move src/java/main to zk-server, which will be further
> separated in Step 2.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -zookeeper-client
> || -zookeeper-client-c
> | -zookeeper-contrib
> || -zookeeper-contrib-fatjar
> || -zookeeper-contrib-huebrowser
> || -zookeeper-contrib-loggraph
> || -zookeeper-contrib-monitoring
> || -zookeeper-contrib-rest
> || -zookeeper-contrib-zkfuse
> || -zookeeper-contrib-zkperl
> || -zookeeper-contrib-zkpython
> || -zookeeper-contrib-zktreeutil
> |\ -zookeeper-contrib-zooinspector
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-server
> | -zookeeper-recipes
> || -zookeeper-recipes-election
> || -zookeeper-recipes-lock
> \\ -zookeeper-recipes-queue
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3021) Umbrella: Migrate project structure to Maven build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norbert Kalmar updated ZOOKEEPER-3021:
--
Description:
In multiple steps, Maven should replace current ant build in ZooKeeper.
First phase - separate project structure that requires no code change:
{noformat}
zookeeper
|-bin
|-conf
|-zk-client
| |-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
Second phase - separate modules that require code changes:
{noformat}
zookeeper
|-bin
|-conf
*|-jute*
|-zk-client
| |-zk-client-c
*| |-zk-client-java* (separated from zk-server)
*| \-zk-client-go* (or any other language)
*|-zk-common*
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
Every module will have the same maven structure:
{noformat}
zk-something
|-src
| |-main
| | |-java
| | | \org...
| | \resources
| \test (unit tests only?)
| |-java
| | \org...
| \resources
\pom.xml (build.xml, build.gradle?)
{noformat}
There is already ZOOKEEPER-1078, but it's main approach is to create a maven
proxy on top of ant.
The main idea here is to replace ant with "pure" maven, and update the project
structure accordingly.
It is also worth noting, that backporting only the package changes to 3.4 is a
good practice for future backport commits. Maven build implementation not
needed, just the directory structuro to be compatible with 3.5/master.
was:
In multiple steps, Maven should replace current ant build in ZooKeeper.
First phase - separate project structure that requires no code change:
{noformat}
zookeeper
|-bin
|-conf
|-zk-client
| |-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
Second phase - separate modules that require code changes:
{noformat}
zookeeper
|-bin
|-conf
*|-jute*
|-zk-client
| |-zk-client-c
*| |-zk-client-java* (separated from zk-server)
*| \-zk-client-go* (or any other language)
*|-zk-common*
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
Every module will have the same maven structure:
{noformat}
zk-something
|-src
| |-main
| | |-java
| | | \org...
| | \resources
| \test (unit tests only?)
| |-java
| | \org...
| \resources
\pom.xml (build.xml, build.gradle?)
{noformat}
There is already ZOOKEEPER-1078, but it's main approach is to create a maven
proxy on top of ant.
The main idea here is to replace ant with "pure" maven, and update the project
structure accordingly.
It is also worth noting, that backporting only the package changes to 3.4 is a
good practice for future backport commits. Maven build implementation not
needed, just the directory structuro to be compatible with 3.5/master.
> Umbrella: Migrate project structure to Maven build
> --
>
> Key: ZOOKEEPER-3021
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build, build-infrastructure, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> In multiple steps, Maven should replace current ant build in ZooKeeper.
> First phase - separate project structure that requires no code change:
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client
> | |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
>
Success: ZOOKEEPER- PreCommit Build #1877
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1877/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.73 MB...] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1877//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1877//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1877//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16523657 added to ZOOKEEPER-2873. [exec] Session logged out. Session was JSESSIONID=F2264731FDD5957FE2689F9CDD39B481. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 17 minutes 37 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-2873 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-2873) print error and/or abort on invalid server definition
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523657#comment-16523657
]
Hadoop QA commented on ZOOKEEPER-2873:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1877//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1877//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1877//console
This message is automatically generated.
> print error and/or abort on invalid server definition
> -
>
> Key: ZOOKEEPER-2873
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2873
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.4.10
>Reporter: Christopher Smith
>Assignee: Norbert Kalmar
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> While bringing up a new cluster, I managed to fat-finger a sed script and put
> some lines like this into my config file:
> {code}
> server.1=zookeeper1:2888:2888
> {code}
> This led to a predictable spew of error messages when the client and election
> components fought over the single port. Since a configuration of this case is
> *always* an error, I suggest that it would be sensible to abort the server
> startup if an entry is found with the same port for both client and election.
> (Logging the error explicitly without shutting down is less helpful because
> of how fast the logs pile up.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Success: ZOOKEEPER- PreCommit Build #1876
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1876/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.56 MB...] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1876//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1876//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1876//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16523654 added to ZOOKEEPER-2873. [exec] Session logged out. Session was JSESSIONID=DD9C62393E60A707F3B4C031BC5C94DC. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ and ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ are the same file BUILD SUCCESSFUL Total time: 20 minutes 21 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-2873 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-2873) print error and/or abort on invalid server definition
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523654#comment-16523654
]
Hadoop QA commented on ZOOKEEPER-2873:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1876//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1876//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1876//console
This message is automatically generated.
> print error and/or abort on invalid server definition
> -
>
> Key: ZOOKEEPER-2873
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2873
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.4.10
>Reporter: Christopher Smith
>Assignee: Norbert Kalmar
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> While bringing up a new cluster, I managed to fat-finger a sed script and put
> some lines like this into my config file:
> {code}
> server.1=zookeeper1:2888:2888
> {code}
> This led to a predictable spew of error messages when the client and election
> components fought over the single port. Since a configuration of this case is
> *always* an error, I suggest that it would be sensible to abort the server
> startup if an entry is found with the same port for both client and election.
> (Logging the error explicitly without shutting down is less helpful because
> of how fast the logs pile up.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] zookeeper pull request #:
Github user nkalmar commented on the pull request: https://github.com/apache/zookeeper/commit/cac68c3503d207c5f7d955ba582dfe3bfa22cb9b#commitcomment-29499851 Yes, but the intention was to use unique port numbers, although the test still passed with 3 zeros. Also, I'm not sure why this is a test for unspecified client address, if host and port is defined. But I don't want to modify more than necessary on a different issue then the one I'm doing the PR for. ---
Failed: ZOOKEEPER- PreCommit Build #1874
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1874/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 35.22 KB...] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1874//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1874//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1874//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] [exec] Client error: Invalid request: java.net.ProtocolException: Server redirected too many times (20) [exec] Ignore unexpected error logging out. Error: Invalid request: java.net.ProtocolException: Server redirected too many times (20). [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1806: exec returned: 1 Total time: 3 minutes 3 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [Fast Archiver] Compressed 491.86 KB of artifacts by 39.0% relative to #1872 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-2873 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## No tests ran.
Failed: ZOOKEEPER- PreCommit Build #1875
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1875/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.81 KB...] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] -1 contrib tests. The patch failed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1875//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1875//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1875//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/src/java/test/bin/test-github-pr.sh: line 471: 29572 Killed $ANT_HOME/bin/ant -DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib [exec] Comment with id 16523633 added to ZOOKEEPER-2873. [exec] Session logged out. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1806: exec returned: 2 Total time: 2 minutes 25 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [Fast Archiver] Compressed 582.21 KB of artifacts by 11.0% relative to #1872 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-2873 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-2873) print error and/or abort on invalid server definition
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523633#comment-16523633
]
Hadoop QA commented on ZOOKEEPER-2873:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1875//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1875//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1875//console
This message is automatically generated.
> print error and/or abort on invalid server definition
> -
>
> Key: ZOOKEEPER-2873
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2873
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.4.10
>Reporter: Christopher Smith
>Assignee: Norbert Kalmar
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> While bringing up a new cluster, I managed to fat-finger a sed script and put
> some lines like this into my config file:
> {code}
> server.1=zookeeper1:2888:2888
> {code}
> This led to a predictable spew of error messages when the client and election
> components fought over the single port. Since a configuration of this case is
> *always* an error, I suggest that it would be sensible to abort the server
> startup if an entry is found with the same port for both client and election.
> (Logging the error explicitly without shutting down is less helpful because
> of how fast the logs pile up.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] zookeeper pull request #:
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/cac68c3503d207c5f7d955ba582dfe3bfa22cb9b#commitcomment-29499666 Interesting so the test used 3 zeroes ---
[GitHub] zookeeper issue #549: ZOOKEEPER-2873 abort startup on invalid ports
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/549 Itt introduces test failures in org.apache.zookeeper.test.ReconfigTest.testUnspecifiedClientAddress, I'm working on it! ---
[jira] [Commented] (ZOOKEEPER-2873) print error and/or abort on invalid server definition
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523606#comment-16523606
]
Hadoop QA commented on ZOOKEEPER-2873:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1873//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1873//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1873//console
This message is automatically generated.
> print error and/or abort on invalid server definition
> -
>
> Key: ZOOKEEPER-2873
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2873
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.4.10
>Reporter: Christopher Smith
>Assignee: Norbert Kalmar
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While bringing up a new cluster, I managed to fat-finger a sed script and put
> some lines like this into my config file:
> {code}
> server.1=zookeeper1:2888:2888
> {code}
> This led to a predictable spew of error messages when the client and election
> components fought over the single port. Since a configuration of this case is
> *always* an error, I suggest that it would be sensible to abort the server
> startup if an entry is found with the same port for both client and election.
> (Logging the error explicitly without shutting down is less helpful because
> of how fast the logs pile up.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523608#comment-16523608 ] Hudson commented on ZOOKEEPER-3066: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #76 (See [https://builds.apache.org/job/ZooKeeper-trunk/76/]) ZOOKEEPER-3066: Expose on JMX of Followers the id of the current leader (andor: rev 3465e0ced5edda2e1299662f6b75a1979b6bdc6e) * (edit) src/java/main/org/apache/zookeeper/server/quorum/LocalPeerMXBean.java * (edit) src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) src/java/test/org/apache/zookeeper/test/HierarchicalQuorumTest.java * (edit) src/java/test/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java * (edit) src/java/test/org/apache/zookeeper/server/quorum/LocalPeerBeanTest.java * (edit) src/java/main/org/apache/zookeeper/server/quorum/LocalPeerBean.java * (edit) src/java/main/org/apache/zookeeper/server/quorum/RemotePeerMXBean.java * (edit) src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTest.java * (edit) src/java/main/org/apache/zookeeper/server/quorum/RemotePeerBean.java > Expose on JMX of Followers the id of the current leader > --- > > Key: ZOOKEEPER-3066 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066 > Project: ZooKeeper > Issue Type: New Feature > Components: jmx, leaderElection, quorum >Affects Versions: 3.5.4, 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 6h 20m > Remaining Estimate: 0h > > It will be useful to add to JMX beans published on Follower Peers to have an > information about the current "leader". > This information is only available using 4 letter words -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Failed: ZOOKEEPER- PreCommit Build #1873
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1873/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.95 MB...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1873//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1873//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1873//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16523606 added to ZOOKEEPER-2873. [exec] Session logged out. Session was JSESSIONID=B6DE3D0365D1A33CB9D45CB909F72601. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1806: exec returned: 1 Total time: 12 minutes 18 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-2873 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## 3 tests failed. FAILED: org.apache.zookeeper.test.ReconfigTest.testUnspecifiedClientAddress Error Message: Client and election port must be different! Please update the configuration file on server.0 Stack Trace: org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Client and election port must be different! Please update the configuration file on server.0 at org.apache.zookeeper.server.quorum.QuorumPeer$QuorumServer.(QuorumPeer.java:263) at org.apache.zookeeper.test.ReconfigTest.testUnspecifiedClientAddress(ReconfigTest.java:809) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79) FAILED: org.apache.zookeeper.test.ReconfigTest.testUnspecifiedClientAddress Error Message: Client and election port must be different! Please update the configuration file on server.0 Stack Trace: org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Client and election port must be different! Please update the configuration file on server.0 at org.apache.zookeeper.server.quorum.QuorumPeer$QuorumServer.(QuorumPeer.java:263) at org.apache.zookeeper.test.ReconfigTest.testUnspecifiedClientAddress(ReconfigTest.java:809) at
[jira] [Assigned] (ZOOKEEPER-1990) suspicious instantiation of java Random instances
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norbert Kalmar reassigned ZOOKEEPER-1990:
-
Assignee: Norbert Kalmar (was: Mark Fenes)
> suspicious instantiation of java Random instances
> -
>
> Key: ZOOKEEPER-1990
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1990
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Norbert Kalmar
>Priority: Critical
> Fix For: 3.6.0, 3.5.5
>
>
> It's not clear to me why we are doing this, but it looks very suspicious. Why
> aren't we just calling "new Random()" in these cases? (even for the tests I
> don't really see it - typically that would just be for repeatability)
> {noformat}
> ag "new Random[ \t]*\(" .
> src/java/main/org/apache/zookeeper/ClientCnxn.java
> 817:private Random r = new Random(System.nanoTime());
> src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
> 75: sourceOfRandomness = new Random(System.currentTimeMillis() ^
> this.hashCode());
> 98:sourceOfRandomness = new Random(randomnessSeed);
> src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
> 420:rand = new Random(java.lang.Thread.currentThread().getId()
> src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> 64:private final Random r = new Random(System.nanoTime());
> src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
> 537:Random r = new Random(id ^ superSecret);
> 554:Random r = new Random(sessionId ^ superSecret);
> src/java/test/org/apache/zookeeper/server/quorum/WatchLeakTest.java
> 271:Random r = new Random(SESSION_ID ^ superSecret);
> src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java
> 151:Random rand = new Random(Thread.currentThread().getId());
> 258:Random rand = new Random(Thread.currentThread().getId());
> 288:Random rand = new Random(Thread.currentThread().getId());
> src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java
> 40:private Random r = new Random(1);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2873) print error and/or abort on invalid server definition
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2873:
--
Labels: pull-request-available (was: )
> print error and/or abort on invalid server definition
> -
>
> Key: ZOOKEEPER-2873
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2873
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.4.10
>Reporter: Christopher Smith
>Assignee: Norbert Kalmar
>Priority: Minor
> Labels: pull-request-available
>
> While bringing up a new cluster, I managed to fat-finger a sed script and put
> some lines like this into my config file:
> {code}
> server.1=zookeeper1:2888:2888
> {code}
> This led to a predictable spew of error messages when the client and election
> components fought over the single port. Since a configuration of this case is
> *always* an error, I suggest that it would be sensible to abort the server
> startup if an entry is found with the same port for both client and election.
> (Logging the error explicitly without shutting down is less helpful because
> of how fast the logs pile up.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports
GitHub user nkalmar opened a pull request: https://github.com/apache/zookeeper/pull/549 ZOOKEEPER-2873 abort startup on invalid ports You can merge this pull request into a Git repository by running: $ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-2873 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/549.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #549 commit 3d747c08fba8170765802ce40fd5e3d7734a3fa1 Author: Norbert Kalmar Date: 2018-06-26T11:27:13Z ZOOKEEPER-2873 abort startup on invalid ports ---
[jira] [Commented] (ZOOKEEPER-3069) document: is mutual auth with DIGEST-MD5 insecure?
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523512#comment-16523512 ] maoling commented on ZOOKEEPER-3069: [~JanZerebecki] look at org.apache.zookeeper.server.auth.DigestAuthenticationProvider.generateDigest(String). In Digest Auth Mode, it uses *username:base64(SHA-1（username:password）)*,not MD5? Am I missing something? > document: is mutual auth with DIGEST-MD5 insecure? > -- > > Key: ZOOKEEPER-3069 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3069 > Project: ZooKeeper > Issue Type: Bug > Components: documentation >Reporter: Jan Zerebecki >Priority: Minor > > The [documentation regarding mutual ZooKeeper server to server authentication > with > DIGEST-MD5|https://cwiki.apache.org/confluence/display/ZOOKEEPER/Server-Server+mutual+authentication#Server-Servermutualauthentication-DIGEST-MD5basedauthentication] > currently doesn't mention whether this is insecure. [DIGEST-MD5 was declared > obsolete in 2011 due to security > problems.|https://tools.ietf.org/html/rfc6331] > This is in relation to whether this is an effective mitigation for > CVE-2018-8012 AKA ZOOKEEPER-1045, as mentioned in > [https://lists.apache.org/thread.html/c75147028c1c79bdebd4f8fa5db2b77da85de2b05ecc0d54d708b393@%3Cdev.zookeeper.apache.org%3E]. > Would the following be a fitting addition to the documentation?: > DIGEST-MD5 based authentication should not be relied on for authentication as > it is insecure, it is only provided for test purposes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3069) document: is mutual auth with DIGEST-MD5 insecure?
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3069: --- Attachment: (was: screenshot-1.png) > document: is mutual auth with DIGEST-MD5 insecure? > -- > > Key: ZOOKEEPER-3069 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3069 > Project: ZooKeeper > Issue Type: Bug > Components: documentation >Reporter: Jan Zerebecki >Priority: Minor > > The [documentation regarding mutual ZooKeeper server to server authentication > with > DIGEST-MD5|https://cwiki.apache.org/confluence/display/ZOOKEEPER/Server-Server+mutual+authentication#Server-Servermutualauthentication-DIGEST-MD5basedauthentication] > currently doesn't mention whether this is insecure. [DIGEST-MD5 was declared > obsolete in 2011 due to security > problems.|https://tools.ietf.org/html/rfc6331] > This is in relation to whether this is an effective mitigation for > CVE-2018-8012 AKA ZOOKEEPER-1045, as mentioned in > [https://lists.apache.org/thread.html/c75147028c1c79bdebd4f8fa5db2b77da85de2b05ecc0d54d708b393@%3Cdev.zookeeper.apache.org%3E]. > Would the following be a fitting addition to the documentation?: > DIGEST-MD5 based authentication should not be relied on for authentication as > it is insecure, it is only provided for test purposes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3069) document: is mutual auth with DIGEST-MD5 insecure?
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3069: --- Attachment: screenshot-1.png > document: is mutual auth with DIGEST-MD5 insecure? > -- > > Key: ZOOKEEPER-3069 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3069 > Project: ZooKeeper > Issue Type: Bug > Components: documentation >Reporter: Jan Zerebecki >Priority: Minor > Attachments: screenshot-1.png > > > The [documentation regarding mutual ZooKeeper server to server authentication > with > DIGEST-MD5|https://cwiki.apache.org/confluence/display/ZOOKEEPER/Server-Server+mutual+authentication#Server-Servermutualauthentication-DIGEST-MD5basedauthentication] > currently doesn't mention whether this is insecure. [DIGEST-MD5 was declared > obsolete in 2011 due to security > problems.|https://tools.ietf.org/html/rfc6331] > This is in relation to whether this is an effective mitigation for > CVE-2018-8012 AKA ZOOKEEPER-1045, as mentioned in > [https://lists.apache.org/thread.html/c75147028c1c79bdebd4f8fa5db2b77da85de2b05ecc0d54d708b393@%3Cdev.zookeeper.apache.org%3E]. > Would the following be a fitting addition to the documentation?: > DIGEST-MD5 based authentication should not be relied on for authentication as > it is insecure, it is only provided for test purposes. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Discover LEADER from JMX
FYI the patch has been merged to master e to 3.5 branch thank you ! https://issues.apache.org/jira/browse/ZOOKEEPER-3066 Enrico Il giorno gio 21 giu 2018 alle ore 17:38 Enrico Olivelli < eolive...@gmail.com> ha scritto: > > > Il gio 21 giu 2018, 17:13 Andor Molnar ha > scritto: > >> Okay, let's put it this way: what kind of test would you like to add here? >> >> *Unit test* >> This is a requirement for the patch to be committed. You don't need to >> fire >> up a full blown ensemble to test the new functionality. Pick the class >> that >> you'd like to test, mock out the dependencies with moquito and write some >> quick unit tests. Your tests should finish in a few hundreds millisecs >> (1-2 >> secs maximum). >> > > This is achieved in my patch. There was already a test about JMX and > LocalPeerMXBean. I have enhanced it, by extending the test to cover my new > JMX attribute and, to cover even RemotePeerMXBean, which was not tested at > all. > > One review comment asked me to perform assertions after a leadership > change. > > I did not touch ZK internals with this patch, I am only publishing > internal state to JMX endpoint. > > Maybe what I am trying to do is not needed for the patch to be > 'acceptable'. > > I think it would be useful to add such test case, but not strictly needed. > Unfortunately current test utilities seem to able to do what requested. > > I am able to add mockito based tests if requested. > > > > > >> *Integration test* >> This is not required, but more than welcome. Can you do it with reasonable >> amount of effort? Is it going to finish in an acceptable time frame (5-10 >> secs)? If yes, go ahead, if not, skip that. >> > > Not needed. Maybe existing test case is already similar to an integration > test ( it brings up a cluster of 5 nodes). > > Anyway my changes is not slowing down the full suite add I am only adding > an assertion to an existing old test. > > I think the restart of the cluster it is not strictly needed and it will > may add a new flaky test. > > Treating ZK as one of my projects, I think the existing JMX test corpus > should be refactored but given the little impact of this patch is it not > worth to spend much time. > > > > Enrico > > > > > >> Hope that helps. >> >> Regards, >> Andor >> >> >> >> >> >> >> On Thu, Jun 21, 2018 at 2:39 PM, Enrico Olivelli >> wrote: >> >> > Andor, >> > >> > I had already tried that way but without success. >> > I have updated the patch with a proposal. >> > Thanks >> > >> > Enrico >> > >> > Il gio 21 giu 2018, 13:20 Andor Molnar ha >> > scritto: >> > >> > > Hi Enrico! >> > > >> > > Take a look at testElectionFraud(), it might be useful to you. >> > > >> > > Regards, >> > > Andor >> > > >> > > >> > > >> > > On Thu, Jun 21, 2018 at 12:00 PM, Enrico Olivelli < >> eolive...@gmail.com> >> > > wrote: >> > > >> > > > Norbert, >> > > > thank you for taking a look >> > > > >> > > > Il giorno gio 21 giu 2018 alle ore 11:58 Norbert Kalmar >> > > > ha scritto: >> > > > >> > > > > Good question. Wouldn't just killing the leader do the job? >> > > > > >> > > > >> > > > It seems to me that is it not "immediate" to "kill" a QuorumPeer >> inside >> > > > such test. >> > > > If you "shutdown" it you cannot 'start' it anymore. >> > > > >> > > > This is why I am asking for help. >> > > > >> > > > -- Enrico >> > > > >> > > > >> > > > >> > > > > >> > > > > Regards, >> > > > > Norbert >> > > > > >> > > > > On Thu, Jun 21, 2018 at 3:51 AM Enrico Olivelli < >> eolive...@gmail.com >> > > >> > > > > wrote: >> > > > > >> > > > > > This is my patch >> > > > > > https://github.com/apache/zookeeper/pull/546 >> > > > > > >> > > > > > One question: >> > > > > > I would like to force the cluster to change leader in >> > > > > > HierarchicalQuorumTest, so that I can test that JMX will reflect >> > the >> > > > new >> > > > > > status of the group. >> > > > > > Any idea about how to bounce the leader ? >> > > > > > >> > > > > > Cheers >> > > > > > Enrico >> > > > > > >> > > > > > Il giorno mer 20 giu 2018 alle ore 13:45 Enrico Olivelli < >> > > > > > eolive...@gmail.com> ha scritto: >> > > > > > >> > > > > > > This is my JIRA >> > > > > > > I am going to work on a patch >> > > > > > > >> > > > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3066 >> > > > > > > >> > > > > > > Enrico >> > > > > > > >> > > > > > > Il gio 10 mag 2018, 19:47 Andor Molnar >> ha >> > > > > scritto: >> > > > > > > >> > > > > > >> "in order to guess which is the leader I have to ask to all >> of >> > the >> > > > > three >> > > > > > >> nodes in the cluster" >> > > > > > >> >> > > > > > >> That's correct. >> > > > > > >> >> > > > > > >> Regards, >> > > > > > >> Andor >> > > > > > >> >> > > > > > >> >> > > > > > >> >> > > > > > >> On Thu, May 10, 2018 at 4:07 AM, Enrico Olivelli < >> > > > eolive...@gmail.com >> > > > > > >> > > > > > >> wrote: >> > > > > > >> >> > > > > > >> > Il giorno mer 9 mag 2018 alle ore 20:24 Patrick Hunt < >> > > > > > ph...@apache.org> >> > > > > > >>
[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/546 @anmolnar thank you so much. ---
[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/546 Committed to master and 3.5 branches. Thanks @eolivelli We should not commit new features to `branch-3.5`, because it's already beta, but given that this is monitoring-only, I eventually committed. ---
[jira] [Resolved] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3066. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue resolved by pull request 546 [https://github.com/apache/zookeeper/pull/546] > Expose on JMX of Followers the id of the current leader > --- > > Key: ZOOKEEPER-3066 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066 > Project: ZooKeeper > Issue Type: New Feature > Components: jmx, leaderElection, quorum >Affects Versions: 3.5.4, 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 6h > Remaining Estimate: 0h > > It will be useful to add to JMX beans published on Follower Peers to have an > information about the current "leader". > This information is only available using 4 letter words -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/546 ---
[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/546 @anmolnar green light ! please cherry pick to 4.5 branch ---
Success: ZOOKEEPER- PreCommit Build #1872
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1872/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.41 MB...] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 12 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1872//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1872//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1872//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16523447 added to ZOOKEEPER-3066. [exec] Session logged out. Session was JSESSIONID=266E2E0928717F3876FF188C64E77B73. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 23 minutes 7 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3066 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523447#comment-16523447 ] Hadoop QA commented on ZOOKEEPER-3066: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1872//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1872//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1872//console This message is automatically generated. > Expose on JMX of Followers the id of the current leader > --- > > Key: ZOOKEEPER-3066 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066 > Project: ZooKeeper > Issue Type: New Feature > Components: jmx, leaderElection, quorum >Affects Versions: 3.5.4, 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Time Spent: 5h 40m > Remaining Estimate: 0h > > It will be useful to add to JMX beans published on Follower Peers to have an > information about the current "leader". > This information is only available using 4 letter words -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523428#comment-16523428
]
maoling commented on ZOOKEEPER-3061:
[~cpoerschke] if log level is INFO,these two logs is adjacent,and we can use
sid to associate them.is it really to necessary to do this?
> add more details to 'Unhandled scenario for peer' log.warn message
> --
>
> Key: ZOOKEEPER-3061
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3061
> Project: ZooKeeper
> Issue Type: Task
>Reporter: Christine Poerschke
>Priority: Minor
> Attachments: ZOOKEEPER-3061.patch
>
>
> A few lines earlier the {{LOG.info("Synchronizing with Follower sid: ...}}
> logging already contains most relevant details but it would be convenient to
> more directly have full details in the {{LOG.warn("Unhandled scenario for
> peer sid: ...}} itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...
Github user eolivelli closed the pull request at: https://github.com/apache/zookeeper/pull/546 ---
[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...
GitHub user eolivelli reopened a pull request: https://github.com/apache/zookeeper/pull/546 ZOOKEEPER-3066 Expose on JMX of Followers the id of the current leader Expose a new JMX attribute "isLeader" in RemotePeerBean and LocalPeerBean You can merge this pull request into a Git repository by running: $ git pull https://github.com/eolivelli/zookeeper fix/ZOOKEEPER-3066-leader-jmx Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/546.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #546 commit 067aed9efe135cae686eb6b9681f46870eec28db Author: Enrico Olivelli Date: 2018-06-21T01:11:58Z ZOOKEEPER-3066 Expose on JMX of Followers the id of the current leader Enhance RemotePeerMXBean and LocalPeerMXBean by adding information about leadership commit 5f120631f926e85c83d93c14138748e2b803615c Author: Enrico Olivelli Date: 2018-06-21T11:57:42Z ZOOKEEPER-3066 add servers restart to test case commit 2778e742799dccbe841c21b018847dc38f4eaf1e Author: Enrico Olivelli Date: 2018-06-22T11:06:21Z revert "ZOOKEEPER-3066 add servers restart to test case" This reverts commit 5f120631f926e85c83d93c14138748e2b803615c. commit 43782fe5949e522931aa2d812ca3a6bbc3438e2d Author: Enrico Olivelli Date: 2018-06-22T11:34:05Z introduce mockito tests commit b5000efc316eb4855ca8a85fc5133d9a9f61d963 Author: Enrico Olivelli Date: 2018-06-22T15:26:06Z clean up test commit 86b116b090574d5906c575c70e9fbc38c5b83f11 Author: Enrico Olivelli Date: 2018-06-25T14:20:04Z enhance tests commit eb8d1bead655ae63a3e3779d6eb10b4a86fc2c64 Author: Enrico Olivelli Date: 2018-06-25T17:56:40Z split tests commit a1984ef1bd51f26ceeb44380571d3a691ea8f483 Author: Enrico Olivelli Date: 2018-06-25T17:58:01Z fix typo commit 81d7bb1ce6fac4d61a2c0e6d9cfe400d7ec61f23 Author: Enrico Olivelli Date: 2018-06-26T06:50:05Z split tests into LocalPeerBeanTest and QuorumPeerTest commit ded4ce204b549a2e800ee10d5a8ded4a1a0c3649 Author: Enrico Olivelli Date: 2018-06-26T06:51:23Z reorder imports commit bf09e37d90445b672fdf3e7aeea72ea05c514416 Author: Enrico Olivelli Date: 2018-06-26T06:53:26Z clean up spaces ---
[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/546 retest this please ---
[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/546 @anmolnar how ? Seems that magic Jenkins words 'retest this please' does not work on ZK ---
[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/546 @eolivelli Perfect, thanks! Now you only need to trigger a green build. ;) ---
[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523313#comment-16523313 ] Hadoop QA commented on ZOOKEEPER-3066: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//console This message is automatically generated. > Expose on JMX of Followers the id of the current leader > --- > > Key: ZOOKEEPER-3066 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066 > Project: ZooKeeper > Issue Type: New Feature > Components: jmx, leaderElection, quorum >Affects Versions: 3.5.4, 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Time Spent: 4h 50m > Remaining Estimate: 0h > > It will be useful to add to JMX beans published on Follower Peers to have an > information about the current "leader". > This information is only available using 4 letter words -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523314#comment-16523314 ] Hadoop QA commented on ZOOKEEPER-3066: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//console This message is automatically generated. > Expose on JMX of Followers the id of the current leader > --- > > Key: ZOOKEEPER-3066 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066 > Project: ZooKeeper > Issue Type: New Feature > Components: jmx, leaderElection, quorum >Affects Versions: 3.5.4, 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Time Spent: 4h 50m > Remaining Estimate: 0h > > It will be useful to add to JMX beans published on Follower Peers to have an > information about the current "leader". > This information is only available using 4 letter words -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Failed: ZOOKEEPER- PreCommit Build #1871
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 35.29 KB...] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16523314 added to ZOOKEEPER-3066. [exec] Session logged out. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’ and ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’ are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1806: exec returned: 1 Total time: 2 minutes 58 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error? Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3066 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## No tests ran.
Failed: ZOOKEEPER- PreCommit Build #1870
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.44 KB...] [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] -1 contrib tests. The patch failed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/java/test/bin/test-github-pr.sh: line 441: 11533 Killed $ANT_HOME/bin/ant -DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dtest.junit.threads=8 -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME test-core [exec] /bin/kill -9 11582 [exec] /bin/kill -9 11584 [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/java/test/bin/test-github-pr.sh: line 471: 11620 Killed $ANT_HOME/bin/ant -DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib [exec] Comment with id 16523313 added to ZOOKEEPER-3066. [exec] Session logged out. Session was JSESSIONID=405A8EB43D41F8CD54FE64ED7B8F0D40. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ and ‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’ are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1806: exec returned: 2 Total time: 2 minutes 54 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [Fast Archiver] Compressed 600.68 KB of artifacts by 37.3% relative to #1867 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error? Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3066 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523311#comment-16523311 ] Hadoop QA commented on ZOOKEEPER-3066: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs (version 3.0.1) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1869//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1869//console This message is automatically generated. > Expose on JMX of Followers the id of the current leader > --- > > Key: ZOOKEEPER-3066 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066 > Project: ZooKeeper > Issue Type: New Feature > Components: jmx, leaderElection, quorum >Affects Versions: 3.5.4, 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Time Spent: 4h 50m > Remaining Estimate: 0h > > It will be useful to add to JMX beans published on Follower Peers to have an > information about the current "leader". > This information is only available using 4 letter words -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3068) Improve C client logging of IPv6 hosts
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523310#comment-16523310
]
Hadoop QA commented on ZOOKEEPER-3068:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//console
This message is automatically generated.
> Improve C client logging of IPv6 hosts
> --
>
> Key: ZOOKEEPER-3068
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3068
> Project: ZooKeeper
> Issue Type: Improvement
> Components: c client
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Trivial
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The C client formats host-port pairings as [host:port] when logging. This is
> visually confusing when the host is an IPv6 address (see the below). In that
> case, it would be preferable to cleanly separate the IPv6 from the port.
> {code:java}
> ZOO_INFO@check_events@2736: initiated connection to server
> [2401:db00:1020:40bf:face:0:5:0:2181]{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Failed: ZOOKEEPER- PreCommit Build #1869
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1869/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.57 KB...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to cause Findbugs (version 3.0.1) to fail. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1869//testReport/ [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1869//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16523311 added to ZOOKEEPER-3066. [exec] Session logged out. Session was JSESSIONID=16CA8AD598C863643DCD1D1020215F69. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1806: exec returned: 2 Total time: 2 minutes 14 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3066 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## No tests ran.
Failed: ZOOKEEPER- PreCommit Build #1868
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 2.05 MB...] [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] -1 contrib tests. The patch failed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/java/test/bin/test-github-pr.sh: line 441: 18255 Killed $ANT_HOME/bin/ant -DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dtest.junit.threads=8 -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME -Djava5.home=$JAVA5_HOME test-core [exec] /bin/kill -9 24067 [exec] /bin/kill -9 24101 [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/java/test/bin/test-github-pr.sh: line 471: 24143 Killed $ANT_HOME/bin/ant -DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes test-contrib [exec] Comment with id 16523310 added to ZOOKEEPER-3068. [exec] Session logged out. Session was JSESSIONID=38F6A15EA9730704A13E441FA3622522. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1806: exec returned: 2 Total time: 2 minutes 45 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3068 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/546 @anmolnar This round: - Explicit unit test for LocalPeerBean, which is using a mock QuorumPeer - Explicit unit test for QuorumPeer all the code changes are now covered. ---
