[GitHub] zookeeper pull request #588: [ZOOKEEPER-3109] Avoid long unavailable time du...
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r210482028
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1172,6 +1172,58 @@ synchronized public long
startForwarding(LearnerHandler handler,
}
// VisibleForTesting
protected final Set connectingFollowers = new HashSet();
+
+private volatile boolean quitWaitForEpoch = false;
+private volatile long timeStartWaitForEpoch = -1;
+private volatile SyncedLearnerTracker voteSet;
+
+public static final String MIN_TIME_WAIT_FOR_EPOCH =
"zookeeper.leader.minTimeToWaitForEpoch";
+private static int minTimeToWaitForEpoch;
+static {
+minTimeToWaitForEpoch =
Integer.getInteger(MIN_TIME_WAIT_FOR_EPOCH, -1);
+LOG.info(MIN_TIME_WAIT_FOR_EPOCH + " = " + minTimeToWaitForEpoch);
--- End diff --
Use MessageFormat style {} substitutions.
---
[GitHub] zookeeper pull request #588: [ZOOKEEPER-3109] Avoid long unavailable time du...
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/588#discussion_r210481082 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -1165,6 +1165,58 @@ synchronized public long startForwarding(LearnerHandler handler, } // VisibleForTesting protected final Set connectingFollowers = new HashSet(); + +private volatile boolean quitWaitForEpoch = false; +private volatile long timeStartWaitForEpoch = -1; +private volatile SyncedLearnerTracker voteSet; + +public static final String MIN_TIME_WAIT_FOR_EPOCH = "zookeeper.leader.minTimeToWaitForEpoch"; --- End diff -- MAX_TIME_TO_WAIT_FOR_EPOCH feels more intuitive for me. Also there should be some documentation of this new property in admin doc so users know its existence and how to configure it. ---
[GitHub] zookeeper pull request #588: [ZOOKEEPER-3109] Avoid long unavailable time du...
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r210482560
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1172,6 +1172,58 @@ synchronized public long
startForwarding(LearnerHandler handler,
}
// VisibleForTesting
protected final Set connectingFollowers = new HashSet();
+
+private volatile boolean quitWaitForEpoch = false;
+private volatile long timeStartWaitForEpoch = -1;
+private volatile SyncedLearnerTracker voteSet;
+
+public static final String MIN_TIME_WAIT_FOR_EPOCH =
"zookeeper.leader.minTimeToWaitForEpoch";
+private static int minTimeToWaitForEpoch;
+static {
+minTimeToWaitForEpoch =
Integer.getInteger(MIN_TIME_WAIT_FOR_EPOCH, -1);
+LOG.info(MIN_TIME_WAIT_FOR_EPOCH + " = " + minTimeToWaitForEpoch);
+}
+
+// visible for test
+public static void setMinTimeToWaitForEpoch(int minTimeToWaitForEpoch)
{
+Leader.minTimeToWaitForEpoch = minTimeToWaitForEpoch;
+LOG.info(MIN_TIME_WAIT_FOR_EPOCH + " set to " +
minTimeToWaitForEpoch);
+}
+
+/**
+ * Quit condition:
+ *
+ * 1 voter goes to looking again and time waitForEpoch >
minTimeToWaitForEpoch
+ *
+ * Note: the voter may go to looking again due to:
+ * 1. change mind in the last minute when received a different
notifications
+ * 2. the leader hadn't started leading when it tried to connect to it.
+ */
--- End diff --
If a connection between leader candidate and a vote is cut off right after
leader acquires enough vote but before leader receives acks from voters, the
voter will also change mind, right? If so should this also be added into
comment if it does not fall into 1 or 2?
---
[GitHub] zookeeper pull request #588: [ZOOKEEPER-3109] Avoid long unavailable time du...
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r210482115
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1172,6 +1172,58 @@ synchronized public long
startForwarding(LearnerHandler handler,
}
// VisibleForTesting
protected final Set connectingFollowers = new HashSet();
+
+private volatile boolean quitWaitForEpoch = false;
+private volatile long timeStartWaitForEpoch = -1;
+private volatile SyncedLearnerTracker voteSet;
+
+public static final String MIN_TIME_WAIT_FOR_EPOCH =
"zookeeper.leader.minTimeToWaitForEpoch";
+private static int minTimeToWaitForEpoch;
+static {
+minTimeToWaitForEpoch =
Integer.getInteger(MIN_TIME_WAIT_FOR_EPOCH, -1);
+LOG.info(MIN_TIME_WAIT_FOR_EPOCH + " = " + minTimeToWaitForEpoch);
+}
+
+// visible for test
+public static void setMinTimeToWaitForEpoch(int minTimeToWaitForEpoch)
{
+Leader.minTimeToWaitForEpoch = minTimeToWaitForEpoch;
+LOG.info(MIN_TIME_WAIT_FOR_EPOCH + " set to " +
minTimeToWaitForEpoch);
--- End diff --
Similar here for log style.
---
[GitHub] zookeeper pull request #588: [ZOOKEEPER-3109] Avoid long unavailable time du...
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r210483183
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1172,6 +1172,58 @@ synchronized public long
startForwarding(LearnerHandler handler,
}
// VisibleForTesting
protected final Set connectingFollowers = new HashSet();
+
+private volatile boolean quitWaitForEpoch = false;
+private volatile long timeStartWaitForEpoch = -1;
+private volatile SyncedLearnerTracker voteSet;
+
+public static final String MIN_TIME_WAIT_FOR_EPOCH =
"zookeeper.leader.minTimeToWaitForEpoch";
+private static int minTimeToWaitForEpoch;
+static {
+minTimeToWaitForEpoch =
Integer.getInteger(MIN_TIME_WAIT_FOR_EPOCH, -1);
+LOG.info(MIN_TIME_WAIT_FOR_EPOCH + " = " + minTimeToWaitForEpoch);
+}
+
+// visible for test
+public static void setMinTimeToWaitForEpoch(int minTimeToWaitForEpoch)
{
+Leader.minTimeToWaitForEpoch = minTimeToWaitForEpoch;
+LOG.info(MIN_TIME_WAIT_FOR_EPOCH + " set to " +
minTimeToWaitForEpoch);
+}
+
+/**
+ * Quit condition:
+ *
+ * 1 voter goes to looking again and time waitForEpoch >
minTimeToWaitForEpoch
+ *
+ * Note: the voter may go to looking again due to:
+ * 1. change mind in the last minute when received a different
notifications
+ * 2. the leader hadn't started leading when it tried to connect to it.
+ */
+private void quitLeading() {
+synchronized(connectingFollowers) {
+quitWaitForEpoch = true;
+connectingFollowers.notifyAll();
+}
+LOG.info("Quit leading due to disloyal voter.");
--- End diff --
Should we avoid using 'disloyal' here, since it's not about Byzantine style
fault, and the vote is not disloyal against the protocol? Maybe something like
'quite leading due to a voter previously voted me changed its vote because of
'. ?
---
Success: ZOOKEEPER- PreCommit Build #2062
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2062/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.68 MB...] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +0 tests included. The patch appears to be a documentation patch that doesn't require tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2062//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2062//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2062//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID=262E57E61E1B6F14AEF1FEF06027E424. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 17 minutes 49 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3103 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper issue #598: ZOOKEEPER-3120 add NetBeans nbproject directory to .gi...
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/598 +1 ---
[GitHub] zookeeper issue #545: ZOOKEEPER-2261 When only secureClientPort is configure...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/545 Oops! Nice catch @enixon , thanks for the heads-up. Maybe we've gone too far with this patch. Thanks for the heads-up! ---
[GitHub] zookeeper issue #588: [ZOOKEEPER-3109] Avoid long unavailable time due to vo...
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/588 @anmolnar it's changing the leader activation but not election part, which should be less risky, we've run this on prod to avoid long time quorum activation time due to this. It would be great if more people can take a review on this one though. ---
[jira] [Commented] (ZOOKEEPER-1990) suspicious instantiation of java Random instances
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581380#comment-16581380
]
Edward Ribeiro commented on ZOOKEEPER-1990:
---
Hi [~nkalmar], I raised the possibility of using _ThreadLocalRandom_, so my two
cents: we can call _Random()_ (option 1), imo. _ThreadLocalRandom_ advantage is
avoiding thread contention and overhead of sharing a global math.Random among
many threads, but I don't think this is a issue with current ZK codebase.
> suspicious instantiation of java Random instances
> -
>
> Key: ZOOKEEPER-1990
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1990
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Patrick Hunt
>Assignee: Norbert Kalmar
>Priority: Critical
> Fix For: 3.6.0, 3.5.5
>
>
> It's not clear to me why we are doing this, but it looks very suspicious. Why
> aren't we just calling "new Random()" in these cases? (even for the tests I
> don't really see it - typically that would just be for repeatability)
> {noformat}
> ag "new Random[ \t]*\(" .
> src/java/main/org/apache/zookeeper/ClientCnxn.java
> 817:private Random r = new Random(System.nanoTime());
> src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
> 75: sourceOfRandomness = new Random(System.currentTimeMillis() ^
> this.hashCode());
> 98:sourceOfRandomness = new Random(randomnessSeed);
> src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
> 420:rand = new Random(java.lang.Thread.currentThread().getId()
> src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
> 64:private final Random r = new Random(System.nanoTime());
> src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
> 537:Random r = new Random(id ^ superSecret);
> 554:Random r = new Random(sessionId ^ superSecret);
> src/java/test/org/apache/zookeeper/server/quorum/WatchLeakTest.java
> 271:Random r = new Random(SESSION_ID ^ superSecret);
> src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java
> 151:Random rand = new Random(Thread.currentThread().getId());
> 258:Random rand = new Random(Thread.currentThread().getId());
> 288:Random rand = new Random(Thread.currentThread().getId());
> src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java
> 40:private Random r = new Random(1);
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3031) Step 1.4 - Create zk-client maven structure
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580972#comment-16580972
]
Hadoop QA commented on ZOOKEEPER-3031:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 122 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2060//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2060//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2060//console
This message is automatically generated.
> Step 1.4 - Create zk-client maven structure
> ---
>
> Key: ZOOKEEPER-3031
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3031
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Create a project structure that separates the different parts of ZooKeeper
> into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> * First iteration - safe changes including moving src/docs to zk-docs,
> creating zk-it empty directory. Build and conf directory remains unchanged.
> These changes also have minimum impact on PR’s.
> * Second iteration - move src/recipes to zk-recipes.
> * Third iteration - move src/contrib to zk-contrib.
> * *Fourth iteration* - move src/c to zk-client (java will be moved in Phase 2)
> * Fifth iteration - move jute under src directory
> * Sixth iteration - move src/java/main to zk-server, which will be further
> separated in Step 2.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -zookeeper-client
> || -zookeeper-client-c
> | -zookeeper-contrib
> || -zookeeper-contrib-fatjar
> || -zookeeper-contrib-huebrowser
> || -zookeeper-contrib-loggraph
> || -zookeeper-contrib-monitoring
> || -zookeeper-contrib-rest
> || -zookeeper-contrib-zkfuse
> || -zookeeper-contrib-zkperl
> || -zookeeper-contrib-zkpython
> || -zookeeper-contrib-zktreeutil
> |\ -zookeeper-contrib-zooinspector
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-recipes
> || -zookeeper-recipes-election
> || -zookeeper-recipes-lock
> \\ -zookeeper-recipes-queue
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3031) Step 1.4 - Create zk-client maven structure
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580973#comment-16580973
]
Hadoop QA commented on ZOOKEEPER-3031:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 122 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2061//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2061//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2061//console
This message is automatically generated.
> Step 1.4 - Create zk-client maven structure
> ---
>
> Key: ZOOKEEPER-3031
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3031
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Create a project structure that separates the different parts of ZooKeeper
> into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> * First iteration - safe changes including moving src/docs to zk-docs,
> creating zk-it empty directory. Build and conf directory remains unchanged.
> These changes also have minimum impact on PR’s.
> * Second iteration - move src/recipes to zk-recipes.
> * Third iteration - move src/contrib to zk-contrib.
> * *Fourth iteration* - move src/c to zk-client (java will be moved in Phase 2)
> * Fifth iteration - move jute under src directory
> * Sixth iteration - move src/java/main to zk-server, which will be further
> separated in Step 2.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -zookeeper-client
> || -zookeeper-client-c
> | -zookeeper-contrib
> || -zookeeper-contrib-fatjar
> || -zookeeper-contrib-huebrowser
> || -zookeeper-contrib-loggraph
> || -zookeeper-contrib-monitoring
> || -zookeeper-contrib-rest
> || -zookeeper-contrib-zkfuse
> || -zookeeper-contrib-zkperl
> || -zookeeper-contrib-zkpython
> || -zookeeper-contrib-zktreeutil
> |\ -zookeeper-contrib-zooinspector
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-recipes
> || -zookeeper-recipes-election
> || -zookeeper-recipes-lock
> \\ -zookeeper-recipes-queue
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Failed: ZOOKEEPER- PreCommit Build #2061
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2061/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 35.09 KB...] [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2061//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2061//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2061//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16580973 added to ZOOKEEPER-3031. [exec] Session logged out. Session was JSESSIONID=9F37D2D24360746F8B2F5B78AEF258C6. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1823: exec returned: 1 Total time: 2 minutes 47 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [Fast Archiver] Compressed 625.78 KB of artifacts by 20.5% relative to #2057 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3031 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## No tests ran.
Failed: ZOOKEEPER- PreCommit Build #2060
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2060/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 25.47 MB...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] -1 contrib tests. The patch failed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2060//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2060//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2060//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16580972 added to ZOOKEEPER-3031. [exec] Session logged out. Session was JSESSIONID=0354F229A678AC912D2178B42D45ED20. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1823: exec returned: 2 Total time: 5 minutes 24 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3031 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-3033) Step 1.2 - Create zk-recipes maven structure
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580918#comment-16580918
]
Hadoop QA commented on ZOOKEEPER-3033:
--
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 69 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2058//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2058//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2058//console
This message is automatically generated.
> Step 1.2 - Create zk-recipes maven structure
>
>
> Key: ZOOKEEPER-3033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3033
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, scripts
>Affects Versions: 3.5.4, 3.6.0, 3.4.12
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5, 3.4.14
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Create a project structure that separates the different parts of ZooKeeper
> into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> * First iteration - safe changes including moving src/docs to zk-docs,
> creating zk-it empty directory. Build and conf directory remains unchanged.
> These changes also have minimum impact on PR’s.
> * *Second iteration* - move src/recipes to zk-recipes.
> * Third iteration - move src/contrib to zk-contrib.
> * Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
> * Fifth iteration - move jute under src directory
> * Sixth iteration - move src/java/main to zk-server, which will be further
> separated in Step 2.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-recipes
> || -zookeeper-recipes-election
> || -zookeeper-recipes-lock
> \\ -zookeeper-recipes-queue
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Failed: ZOOKEEPER- PreCommit Build #2058
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2058/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.59 MB...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2058//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2058//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2058//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16580918 added to ZOOKEEPER-3033. [exec] Session logged out. Session was JSESSIONID=B7818C1E2C57422014C065C48C349048. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1822: exec returned: 1 Total time: 12 minutes 32 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3033 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.test.FLETest.testTripleElection Error Message: Fewer than a a majority has joined Stack Trace: junit.framework.AssertionFailedError: Fewer than a a majority has joined at org.apache.zookeeper.test.FLETest.runElection(FLETest.java:362) at org.apache.zookeeper.test.FLETest.testTripleElection(FLETest.java:287) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
Failed: ZOOKEEPER- PreCommit Build #2059
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2059/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 6.55 KB...]
[exec] Dload Upload Total Spent
Left Speed
[exec]
[exec] Pull request title: ZOOKEEPER-3120 add NetBeans nbproject directory
to .gitignore
[exec] Defect number: ZOOKEEPER-3120
[exec] - Parsed args, going to checkout -
[exec]
[exec]
[exec]
==
[exec]
==
[exec] Testing patch for pull request 598.
[exec]
==
[exec]
==
[exec]
[exec]
[exec]
[exec] 0 00 00 0 0 0 --:--:-- --:--:--
--:--:-- 0100 1410 1410 0658 0 --:--:-- --:--:--
--:--:-- 661
[exec]
[exec]
[exec]
==
[exec]
==
[exec] Pre-build trunk to verify trunk stability and javac warnings
[exec]
==
[exec]
==
[exec]
[exec]
[exec] /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant
-Djavac.args=-Xlint -Xmaxwarns 1000
-Djava5.home=/home/jenkins/tools/java5/latest/
-Dforrest.home=/home/jenkins/tools/forrest/latest/ -DZookeeperPatchProcess=
clean tar >
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess/trunkJavacWarnings.txt
2>&1
[exec] Trunk compilation is broken?
[exec]
[exec]
[exec]
==
[exec]
==
[exec] Finished build.
[exec]
==
[exec]
==
[exec]
[exec]
[exec] 0 00 2020 0409 0 --:--:-- --:--:--
--:--:--
409/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/src/java/test/bin/test-github-pr.sh:
line 153: 9301 Killed $ANT_HOME/bin/ant -Djavac.args="-Xlint
-Xmaxwarns 1000" -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME}
-DZookeeperPatchProcess= clean tar > $PATCH_DIR/trunkJavacWarnings.txt 2>&1
[exec] mv:
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
and
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
are the same file
BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1822:
exec returned: 1
Total time: 27 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3120
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
###
## FAILED TESTS (if any)
##
No tests ran.
[jira] [Updated] (ZOOKEEPER-3120) add NetBeans nbproject directory to .gitignore
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3120: -- Labels: pull-request-available (was: ) > add NetBeans nbproject directory to .gitignore > -- > > Key: ZOOKEEPER-3120 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3120 > Project: ZooKeeper > Issue Type: Task >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Minor > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper pull request #598: ZOOKEEPER-3120 add NetBeans nbproject directory...
GitHub user eolivelli reopened a pull request: https://github.com/apache/zookeeper/pull/598 ZOOKEEPER-3120 add NetBeans nbproject directory to .gitignore You can merge this pull request into a Git repository by running: $ git pull https://github.com/eolivelli/zookeeper fix/netbeans-nbproject Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/598.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #598 commit 5b0d5c1a793aaaf61bd150ac8316a9da98e4dea0 Author: Enrico Olivelli Date: 2018-08-14T16:51:12Z ZOOKEEPER-3120 add NetBeans nbproject directory to .gitignore ---
[GitHub] zookeeper pull request #598: ZOOKEEPER-3120 add NetBeans nbproject directory...
Github user eolivelli closed the pull request at: https://github.com/apache/zookeeper/pull/598 ---
[jira] [Commented] (ZOOKEEPER-3033) Step 1.2 - Create zk-recipes maven structure
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580913#comment-16580913
]
Hadoop QA commented on ZOOKEEPER-3033:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 69 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2057//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2057//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2057//console
This message is automatically generated.
> Step 1.2 - Create zk-recipes maven structure
>
>
> Key: ZOOKEEPER-3033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3033
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, scripts
>Affects Versions: 3.5.4, 3.6.0, 3.4.12
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5, 3.4.14
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Create a project structure that separates the different parts of ZooKeeper
> into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> * First iteration - safe changes including moving src/docs to zk-docs,
> creating zk-it empty directory. Build and conf directory remains unchanged.
> These changes also have minimum impact on PR’s.
> * *Second iteration* - move src/recipes to zk-recipes.
> * Third iteration - move src/contrib to zk-contrib.
> * Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
> * Fifth iteration - move jute under src directory
> * Sixth iteration - move src/java/main to zk-server, which will be further
> separated in Step 2.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-recipes
> || -zookeeper-recipes-election
> || -zookeeper-recipes-lock
> \\ -zookeeper-recipes-queue
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Success: ZOOKEEPER- PreCommit Build #2057
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2057/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.40 MB...] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 69 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2057//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2057//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2057//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16580913 added to ZOOKEEPER-3033. [exec] Session logged out. Session was JSESSIONID=A46E9217F4C6ABF6B03F42D90828F937. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD SUCCESSFUL Total time: 18 minutes 39 seconds Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3033 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Success Sending email for trigger: Success Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[GitHub] zookeeper pull request #599: ZOOKEEPER-3033 - MAVEN MIGRATION - fix director...
GitHub user nkalmar opened a pull request: https://github.com/apache/zookeeper/pull/599 ZOOKEEPER-3033 - MAVEN MIGRATION - fix directory structure I reopened step 1.2 to fix the directory structure of the recipes, as it is better to do every directory change at once. (As it has been done in step 1.3 already - first step, docs is irrelevant in this manner). You can merge this pull request into a Git repository by running: $ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-3033_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/599.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #599 ---
[jira] [Commented] (ZOOKEEPER-3033) Step 1.2 - Create zk-recipes maven structure
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580905#comment-16580905
]
Norbert Kalmar commented on ZOOKEEPER-3033:
---
REopening issue - fix directory structures under the recipes.
> Step 1.2 - Create zk-recipes maven structure
>
>
> Key: ZOOKEEPER-3033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3033
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, scripts
>Affects Versions: 3.5.4, 3.6.0, 3.4.12
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5, 3.4.14
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Create a project structure that separates the different parts of ZooKeeper
> into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> * First iteration - safe changes including moving src/docs to zk-docs,
> creating zk-it empty directory. Build and conf directory remains unchanged.
> These changes also have minimum impact on PR’s.
> * *Second iteration* - move src/recipes to zk-recipes.
> * Third iteration - move src/contrib to zk-contrib.
> * Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
> * Fifth iteration - move jute under src directory
> * Sixth iteration - move src/java/main to zk-server, which will be further
> separated in Step 2.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-recipes
> || -zookeeper-recipes-election
> || -zookeeper-recipes-lock
> \\ -zookeeper-recipes-queue
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (ZOOKEEPER-3033) Step 1.2 - Create zk-recipes maven structure
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norbert Kalmar reopened ZOOKEEPER-3033:
---
> Step 1.2 - Create zk-recipes maven structure
>
>
> Key: ZOOKEEPER-3033
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3033
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, scripts
>Affects Versions: 3.5.4, 3.6.0, 3.4.12
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5, 3.4.14
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Create a project structure that separates the different parts of ZooKeeper
> into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> * First iteration - safe changes including moving src/docs to zk-docs,
> creating zk-it empty directory. Build and conf directory remains unchanged.
> These changes also have minimum impact on PR’s.
> * *Second iteration* - move src/recipes to zk-recipes.
> * Third iteration - move src/contrib to zk-contrib.
> * Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
> * Fifth iteration - move jute under src directory
> * Sixth iteration - move src/java/main to zk-server, which will be further
> separated in Step 2.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-recipes
> || -zookeeper-recipes-election
> || -zookeeper-recipes-lock
> \\ -zookeeper-recipes-queue
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3120) add NetBeans nbproject directory to .gitignore
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580839#comment-16580839 ] Hadoop QA commented on ZOOKEEPER-3120: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2056//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2056//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2056//console This message is automatically generated. > add NetBeans nbproject directory to .gitignore > -- > > Key: ZOOKEEPER-3120 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3120 > Project: ZooKeeper > Issue Type: Task >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Failed: ZOOKEEPER- PreCommit Build #2056
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2056/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.04 MB...] [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2056//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2056//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2056//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment with id 16580839 added to ZOOKEEPER-3120. [exec] Session logged out. Session was JSESSIONID=0D577A9E74ECEE11A93FD1FACFB0FD02. [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1822: exec returned: 1 Total time: 20 minutes 50 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Recording test results Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 [description-setter] Description set: ZOOKEEPER-3120 Putting comment on the pull request Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8 ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Resolved] (ZOOKEEPER-3121) test
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] pacawat k resolved ZOOKEEPER-3121. -- Resolution: Fixed > test > > > Key: ZOOKEEPER-3121 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3121 > Project: ZooKeeper > Issue Type: Bug >Reporter: pacawat k >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3121) test
pacawat k created ZOOKEEPER-3121: Summary: test Key: ZOOKEEPER-3121 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3121 Project: ZooKeeper Issue Type: Bug Reporter: pacawat k -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3119) test
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] pacawat k resolved ZOOKEEPER-3119. -- Resolution: Fixed > test > > > Key: ZOOKEEPER-3119 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3119 > Project: ZooKeeper > Issue Type: Bug > Components: build, jmx, kerberos >Reporter: pacawat k >Priority: Major > > test -- This message was sent by Atlassian JIRA (v7.6.3#76005)
