[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

[maoling]

Github user maoling commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/587#discussion_r223567109
  
--- Diff: 
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
 ---
@@ -68,14 +71,16 @@ public ConnectStringParser(String connectString) {
 List hostsList = split(connectString,",");
 for (String host : hostsList) {
 int port = DEFAULT_PORT;
-int pidx = host.lastIndexOf(':');
-if (pidx >= 0) {
-// otherwise : is at the end of the string, ignore
-if (pidx < host.length() - 1) {
-port = Integer.parseInt(host.substring(pidx + 1));
+try {
+String[] hostAndPort = ConfigUtils.getHostAndPort(host);
+host = hostAndPort[0];
+if (hostAndPort.length == 2) {
+port = Integer.parseInt(hostAndPort[1]);
 }
-host = host.substring(0, pidx);
+} catch (ConfigException e) {
+e.printStackTrace();
--- End diff --

@eolivelli agreed.Since this PR has been merged.Could you plz open another 
separate pull request to process it?


---

Failed: ZOOKEEPER- PreCommit Build #2391

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2391/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 149.52 KB...]
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2391//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2391//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2391//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=598FC813B4D7C49CC49D26CFA478C40F.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD SUCCESSFUL
Total time: 8 minutes 7 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3032
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting status of 34692d3814540406ac5a7e83e4e025eff520dbe1 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2391/ and 
message: 'FAILURE
 No test results found.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2391/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] zookeeper issue #658: ZOOKEEPER-3032 - MAVEN MIGRATION - branch 3.4 move jav...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/658
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2391/



---

[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/632
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2388/



---

Failed: ZOOKEEPER- PreCommit Build #2388

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2388/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 76.42 MB...]
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2388//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2388//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2388//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=778F45CC1FCE62E80935C18CBE9A4D6D.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1953:
 exec returned: 1

Total time: 17 minutes 16 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3150
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting status of 66de4c85b91544c58b03dd9abb83b3734507c71b to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2388/ and 
message: 'FAILURE
 1766 tests run, 1 skipped, 0 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2388/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #658: ZOOKEEPER-3032 - MAVEN MIGRATION - branch 3.4 move jav...

[lvfangmin]

Github user lvfangmin commented on the issue:

https://github.com/apache/zookeeper/pull/658
  
retest this please


---

[GitHub] zookeeper issue #660: ZOOKEEPER-2320. C-client crashes when removing watcher...

[lvfangmin]

Github user lvfangmin commented on the issue:

https://github.com/apache/zookeeper/pull/660
  
@anmolnar do you know why it failing the check here? From the latest 
Jenkins build link I cannot find any failure.


---

[GitHub] zookeeper pull request #659: ZOOKEEPER-3161. Refactor QuorumPeerMainTest.jav...

[lvfangmin]

Github user lvfangmin commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/659#discussion_r223564880
  
--- Diff: 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
 ---
@@ -402,4 +421,129 @@ public File getConfFile() {
 }
 
 }
+
+// This class holds the servers and clients for those servers
+protected static class Servers {
+MainThread mt[];
+ZooKeeper zk[];
+int[] clientPorts;
+
+public void shutDownAllServers() throws InterruptedException {
+for (MainThread t: mt) {
+t.shutdown();
+}
+}
+
+public void restartAllServersAndClients(Watcher watcher) throws 
IOException, InterruptedException {
+for (MainThread t : mt) {
+if (!t.isAlive()) {
+t.start();
+}
+}
+for (int i = 0; i < zk.length; i++) {
+restartClient(i, watcher);
+}
+}
+
+public void restartClient(int clientIndex, Watcher watcher) throws 
IOException, InterruptedException {
+if (zk[clientIndex] != null) {
+zk[clientIndex].close();
+}
+zk[clientIndex] = new ZooKeeper("127.0.0.1:" + 
clientPorts[clientIndex], ClientBase.CONNECTION_TIMEOUT, watcher);
+}
+
+public int findLeader() {
+for (int i = 0; i < mt.length; i++) {
+if (mt[i].main.quorumPeer.leader != null) {
+return i;
+}
+}
+return -1;
+}
+}
+
+protected Servers LaunchServers(int numServers) throws IOException, 
InterruptedException {
+return LaunchServers(numServers, null);
+}
+
+/** * This is a helper function for launching a set of servers
+ *
+ * @param numServers the number of servers
+ * @param tickTime A ticktime to pass to MainThread
+ * @return
+ * @throws IOException
+ * @throws InterruptedException
+ */
+protected Servers LaunchServers(int numServers, Integer tickTime) 
throws IOException, InterruptedException {
+int SERVER_COUNT = numServers;
+QuorumPeerMainTest.Servers svrs = new QuorumPeerMainTest.Servers();
+svrs.clientPorts = new int[SERVER_COUNT];
+StringBuilder sb = new StringBuilder();
+for(int i = 0; i < SERVER_COUNT; i++) {
+svrs.clientPorts[i] = PortAssignment.unique();
+
sb.append("server."+i+"=127.0.0.1:"+PortAssignment.unique()+":"+PortAssignment.unique()+";"+svrs.clientPorts[i]+"\n");
+}
+String quorumCfgSection = sb.toString();
+
+svrs.mt = new MainThread[SERVER_COUNT];
+svrs.zk = new ZooKeeper[SERVER_COUNT];
+for(int i = 0; i < SERVER_COUNT; i++) {
+if (tickTime != null) {
+svrs.mt[i] = new MainThread(i, svrs.clientPorts[i], 
quorumCfgSection, new HashMap(), tickTime);
+} else {
+svrs.mt[i] = new MainThread(i, svrs.clientPorts[i], 
quorumCfgSection);
+}
+svrs.mt[i].start();
+svrs.restartClient(i, this);
+}
+
+waitForAll(svrs, ZooKeeper.States.CONNECTED);
+
+return svrs;
+}
+
+public static void waitForOne(ZooKeeper zk, ZooKeeper.States state) 
throws InterruptedException {
+int iterations = ClientBase.CONNECTION_TIMEOUT / 500;
+while (zk.getState() != state) {
+if (iterations-- == 0) {
+throw new RuntimeException("Waiting too long " + 
zk.getState() + " != " + state);
+}
+Thread.sleep(500);
+}
+}
+
+protected void waitForAll(Servers servers, ZooKeeper.States state) 
throws InterruptedException {
--- End diff --

Maybe change this to public as well?


---

[GitHub] zookeeper issue #659: ZOOKEEPER-3161. Refactor QuorumPeerMainTest.java: move...

[lvfangmin]

Github user lvfangmin commented on the issue:

https://github.com/apache/zookeeper/pull/659
  
retest this please


---

Failed: ZOOKEEPER- PreCommit Build #2389

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2389/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 7.42 KB...]
 [exec] Testing patch for pull request .
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Pre-build trunk to verify trunk stability and javac warnings
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant  
-Djavac.args=-Xlint -Xmaxwarns 1000 
-Djava5.home=/home/jenkins/tools/java5/latest/ 
-Dforrest.home=/home/jenkins/tools/forrest/latest/ -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0curl: (6) Could not resolve host: .diffmv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1948:
 exec returned: 1

Total time: 18 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3125
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting status of a8b8d66698750c8805d8d58a4e8c123d78a82029 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2389/ and 
message: 'FAILURE
 No test results found.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2389/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] zookeeper issue #647: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/647
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2389/



---

Failed: ZOOKEEPER- PreCommit Build #2387

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2387/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 69.09 MB...]
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2387//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2387//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2387//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=B75918663BC2A2D19EF0469B52EC592E.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1953:
 exec returned: 1

Total time: 17 minutes 8 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-2320
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting status of daf35ce2c355fc5cdc73e0f7baf0cba5bbaeab8f to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2387/ and 
message: 'FAILURE
 1760 tests run, 1 skipped, 0 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2387/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #660: ZOOKEEPER-2320. C-client crashes when removing watcher...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/660
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2387/



---

[GitHub] zookeeper issue #660: ZOOKEEPER-2320. C-client crashes when removing watcher...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/660
  
retest this please


---

Failed: ZOOKEEPER- PreCommit Build #2386

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2386/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 76.25 MB...]
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2386//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2386//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2386//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=3E7D883979E8600A35762C29CBF75EAA.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1953:
 exec returned: 1

Total time: 12 minutes 28 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-2320
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting status of daf35ce2c355fc5cdc73e0f7baf0cba5bbaeab8f to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2386/ and 
message: 'FAILURE
 1760 tests run, 1 skipped, 1 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2386/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthTest.testValidCredentials

Error Message:
waiting for server 2 being up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server 2 being up
at 
org.apache.zookeeper.server.quorum.auth.QuorumAuthTestBase.startQuorum(QuorumAuthTestBase.java:74)
at 
org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthTest.testValidCredentials(QuorumKerberosAuthTest.java:101)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)

[GitHub] zookeeper issue #660: ZOOKEEPER-2320. C-client crashes when removing watcher...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/660
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2386/



---

[jira] [Commented] (ZOOKEEPER-2320) C-client crashes when removing watcher asynchronously in "local" mode

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642802#comment-16642802
 ] 

Hadoop QA commented on ZOOKEEPER-2320:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12814621/ZOOKEEPER-2320.patch
  against trunk revision 00c4c11853460923bdc9f3e4618382391d7b713c.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 4 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3705//console

This message is automatically generated.

> C-client crashes when removing watcher asynchronously in "local" mode
> -
>
> Key: ZOOKEEPER-2320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2320
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.1
>Reporter: Hadriel Kaplan
>Assignee: Abraham Fine
>Priority: Major
>  Labels: pull-request-available
> Attachments: ZOOKEEPER-2320.patch, ZOOKEEPER-2320.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The C-client library will crash when invoking the asynchronous 
> {{zoo_aremove_watchers()}} API function with the '{{local}}' argument set to 
> 1.
> The reason is: if the local argument is 1/true, then the code does 
> '{{notify_sync_completion((struct sync_completion *)data);}}' But casting the 
> '{{data}}' variable to a {{sync_completion}} struct pointer is bogus/invalid, 
> and when it's later handles as that struct pointer it's accessing invalid 
> memory.
> As a side note: it will work ok when called _synchronously_ through 
> {{zoo_remove_watchers()}}, because that function creates a 
> {{sync_completion}} struct and passes it to the asynch 
> {{zoo_aremove_watchers()}}, but it will not work ok when the asynch function 
> is used directly for the reason stated perviously.
> Another side note: the docs state that setting the 'local' flag makes the 
> C-client remove the watcher "even if there is no server connection" - but 
> really it makes the C-client remove the watcher without notifying the server 
> at *all*, even if the connection to a server is up. (well... that's what it 
> would do if it didn't just crash instead ;)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-2320 PreCommit Build #3705

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2320
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3705/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 8.68 KB...]
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12814621/ZOOKEEPER-2320.patch
 [exec]   against trunk revision 00c4c11853460923bdc9f3e4618382391d7b713c.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 4 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3705//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16642802 added to ZOOKEEPER-2320.
 [exec] Session logged out. Session was 
JSESSIONID=2C4C5C2E04A6297F5154126D8EB44180.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1932: 
exec returned: 1

Total time: 57 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3157
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-2320) C-client crashes when removing watcher asynchronously in "local" mode

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-2320:
--
Labels: pull-request-available  (was: )

> C-client crashes when removing watcher asynchronously in "local" mode
> -
>
> Key: ZOOKEEPER-2320
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2320
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.1
>Reporter: Hadriel Kaplan
>Assignee: Abraham Fine
>Priority: Major
>  Labels: pull-request-available
> Attachments: ZOOKEEPER-2320.patch, ZOOKEEPER-2320.patch
>
>
> The C-client library will crash when invoking the asynchronous 
> {{zoo_aremove_watchers()}} API function with the '{{local}}' argument set to 
> 1.
> The reason is: if the local argument is 1/true, then the code does 
> '{{notify_sync_completion((struct sync_completion *)data);}}' But casting the 
> '{{data}}' variable to a {{sync_completion}} struct pointer is bogus/invalid, 
> and when it's later handles as that struct pointer it's accessing invalid 
> memory.
> As a side note: it will work ok when called _synchronously_ through 
> {{zoo_remove_watchers()}}, because that function creates a 
> {{sync_completion}} struct and passes it to the asynch 
> {{zoo_aremove_watchers()}}, but it will not work ok when the asynch function 
> is used directly for the reason stated perviously.
> Another side note: the docs state that setting the 'local' flag makes the 
> C-client remove the watcher "even if there is no server connection" - but 
> really it makes the C-client remove the watcher without notifying the server 
> at *all*, even if the connection to a server is up. (well... that's what it 
> would do if it didn't just crash instead ;)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #660: ZOOKEEPER-2320. C-client crashes when removing ...

[anmolnar]

GitHub user anmolnar opened a pull request:

https://github.com/apache/zookeeper/pull/660

ZOOKEEPER-2320. C-client crashes when removing watcher asynchronously in 
"local" mode

Trying to fix invalid point issue happening intermittently in the PreCommit 
job. Looks like this old patch fixes the issue in the C client, so let's try to 
re-animate it.

I'm not a C expert, so waiting for at least 2 committers to approve.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2320

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/660.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #660


commit daf35ce2c355fc5cdc73e0f7baf0cba5bbaeab8f
Author: Andor Molnar 
Date:   2018-10-08T14:54:29Z

ZOOKEEPER-2320. Fix invalid pointer issue on zoo_aremove_watchers()




---

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

[edwardoliveira]

Github user edwardoliveira commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/632#discussion_r223546118
  
--- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -1521,4 +1562,179 @@ public boolean removeWatch(String path, WatcherType 
type, Watcher watcher) {
 public ReferenceCountedACLCache getReferenceCountedAclCache() {
 return aclCache;
 }
+
+/**
+ * Add the digest to the historical list, and update the latest zxid 
digest.
+ */
+private void logZxidDigest(long zxid, long digest) {
+ZxidDigest zxidDigest = new ZxidDigest(zxid, 
DigestCalculator.DIGEST_VERSION, digest);
+lastProcessedZxidDigest = zxidDigest;
+if (zxidDigest.zxid % 128 == 0) {
--- End diff --

Better than put a comment it is to extract as a constant...


---

Success: ZOOKEEPER- PreCommit Build #2385

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2385/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 81.21 MB...]
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2385//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2385//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2385//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out.
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 22 minutes 10 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3150
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting status of e040eae608452ff3fa73840152013b329ff95e7c to SUCCESS with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2385/ and 
message: 'SUCCESS 
 1766 tests run, 1 skipped, 0 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2385/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/632
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2385/



---

[GitHub] zookeeper issue #647: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

[lvfangmin]

Github user lvfangmin commented on the issue:

https://github.com/apache/zookeeper/pull/647
  
I remember I commented in Jira ZOOKEEPER-3157, not sure why it didn't show 
up. 

I mentioned that we still need RetryRule, because there might be temporary 
quorum unstable issues like what we found on our test environment. The quorum 
set up in the test might be down due to leader election in case there is heavy 
load/limited resources on that test environment. We have seen this happened 
internally, so it's better to have retry for ConnectionLoss in this case.


---

[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

[lvfangmin]

Github user lvfangmin commented on the issue:

https://github.com/apache/zookeeper/pull/632
  
retest this please


---

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

[lvfangmin]

Github user lvfangmin commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/632#discussion_r223538616
  
--- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -1521,4 +1562,179 @@ public boolean removeWatch(String path, WatcherType 
type, Watcher watcher) {
 public ReferenceCountedACLCache getReferenceCountedAclCache() {
 return aclCache;
 }
+
+/**
+ * Add the digest to the historical list, and update the latest zxid 
digest.
+ */
+private void logZxidDigest(long zxid, long digest) {
+ZxidDigest zxidDigest = new ZxidDigest(zxid, 
DigestCalculator.DIGEST_VERSION, digest);
+lastProcessedZxidDigest = zxidDigest;
+if (zxidDigest.zxid % 128 == 0) {
--- End diff --

I'll add the comment here, basically we want to only export the history of 
digest every 128 txns. It's a random number we picked, but not all random, in 
hex it's 80, which will print nicer when we dump the digest history.


---

ZooKeeper-trunk - Build # 224 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/224/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 332.71 KB...]
 [exec]  : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testLogCallbackClearLog Message Received: 
[2018-10-08 23:56:44,473:11461(0x2ae3a092cf40):ZOO_INFO@log_env@1080: Client 
environment:zookeeper.version=zookeeper C client 3.6.0]
 [exec] Log Message Received: [2018-10-08 
23:56:44,473:11461(0x2ae3a092cf40):ZOO_INFO@log_env@1084: Client 
environment:host.name=asf911.gq1.ygridcore.net]
 [exec] Log Message Received: [2018-10-08 
23:56:44,473:11461(0x2ae3a092cf40):ZOO_INFO@log_env@1091: Client 
environment:os.name=Linux]
 [exec] Log Message Received: [2018-10-08 
23:56:44,473:11461(0x2ae3a092cf40):ZOO_INFO@log_env@1092: Client 
environment:os.arch=3.13.0-143-generic]
 [exec] Log Message Received: [2018-10-08 
23:56:44,473:11461(0x2ae3a092cf40):ZOO_INFO@log_env@1093: Client 
environment:os.version=#192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018]
 [exec] Log Message Received: [2018-10-08 
23:56:44,473:11461(0x2ae3a092cf40):ZOO_INFO@log_env@1101: Client 
environment:user.name=jenkins]
 [exec] Log Message Received: [2018-10-08 
23:56:44,473:11461(0x2ae3a092cf40):ZOO_INFO@log_env@1109: Client 
environment:user.home=/home/jenkins]
 [exec] Log Message Received: [2018-10-08 
23:56:44,473:11461(0x2ae3a092cf40):ZOO_INFO@log_env@1121: Client 
environment:user.dir=/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build/test/test-cppunit]
 [exec] Log Message Received: [2018-10-08 
23:56:44,473:11461(0x2ae3a092cf40):ZOO_INFO@zookeeper_init_internal@1167: 
Initiating client connection, host=127.0.0.1:22181 sessionTimeout=1 
watcher=0x4639e0 sessionId=0 sessionPasswd= context=0x7ffebd10eb00 
flags=0]
 [exec] Log Message Received: [2018-10-08 
23:56:44,474:11461(0x2ae3a298f700):ZOO_INFO@check_events@2454: initiated 
connection to server 127.0.0.1:22181]
 [exec] Log Message Received: [2018-10-08 
23:56:44,493:11461(0x2ae3a298f700):ZOO_INFO@check_events@2506: session 
establishment complete on server 127.0.0.1:22181, sessionId=0x101d80dc70a000f, 
negotiated timeout=1 ]
 [exec]  : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server 
started : elapsed 10496 : OK
 [exec] Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK
 [exec] Zookeeper_simpleSystem::testFirstServerDown : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testNonexistentHost : elapsed 1045 : OK
 [exec] Zookeeper_simpleSystem::testNullData : elapsed 1037 : OK
 [exec] Zookeeper_simpleSystem::testIPV6 : elapsed 1008 : OK
 [exec] Zookeeper_simpleSystem::testCreate : elapsed 1024 : OK
 [exec] Zookeeper_simpleSystem::testPath : elapsed 1054 : OK
 [exec] Zookeeper_simpleSystem::testPathValidation : elapsed 1145 : OK
 [exec] Zookeeper_simpleSystem::testPing : elapsed 17615 : OK
 [exec] Zookeeper_simpleSystem::testAcl : elapsed 1023 : OK
 [exec] Zookeeper_simpleSystem::testChroot : elapsed 3098 : OK
 [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started ZooKeeper 
server started : elapsed 31046 : OK
 [exec] Zookeeper_simpleSystem::testHangingClient : elapsed 1045 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithGlobal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
15693 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithLocal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
15625 : OK
 [exec] Zookeeper_simpleSystem::testGetChildren2 : elapsed 1079 : OK
 [exec] Zookeeper_simpleSystem::testLastZxid : elapsed 4534 : OK
 [exec] Zookeeper_simpleSystem::testRemoveWatchers ZooKeeper server started 
: elapsed 4610 : OK
 [exec] Zookeeper_readOnly::testReadOnly : elapsed 4127 : OK
 [exec] Zookeeper_logClientEnv::testLogClientEnv : elapsed 1 : OK
 [exec] OK (76)
 [exec] FAIL: zktest-mt
 [exec] ==
 [exec] 1 of 2 tests failed
 [exec] Please report to u...@zookeeper.apache.org
 [exec] ==
 [exec] make[1]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build/test/test-cppunit'
 [exec] *** Error in `./zktest-mt': free(): invalid pointer: 
0x2ae3a0918000 ***
 [exec] /bin/bash: line 5: 11461 Aborted 
ZKROOT=/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/zookeeper-client/zookeeper-client-c/../..
 CLASSPATH=$CLASSPATH:$CLOVER_HOME/lib/clover.jar ${dir}$tst
 [exec] make[1]: *** [check-TESTS] Error 1
 [exec] make: *** [check-am] Error 2

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1550: The 
following error occurred while 

[jira] [Commented] (ZOOKEEPER-3157) Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection loss

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642002#comment-16642002
 ] 

Hudson commented on ZOOKEEPER-3157:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #223 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/223/])
ZOOKEEPER-3157: Improve FuzzySnapshotRelatedTest to avoid flaky due to (andor: 
rev 00c4c11853460923bdc9f3e4618382391d7b713c)
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java


> Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection 
> loss
> --
>
> Key: ZOOKEEPER-3157
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3157
> Project: ZooKeeper
>  Issue Type: Test
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Fangmin Lv
>Assignee: Andor Molnar
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> [~hanm] noticed that the test might failure because of ConnectionLoss when 
> trying to getData, [here is an 
> example|https://builds.apache.org/job/ZooKeepertrunk/198/testReport/junit/org.apache.zookeeper.server.quorum/FuzzySnapshotRelatedTest/testPZxidUpdatedWhenLoadingSnapshot],
>  we should catch this and retry to avoid flaky.
> Internally, we 'fixed' flaky test by adding junit.RetryRule in ZKTestCase, 
> which is the base class for most of the tests. I'm not sure this is the right 
> way to go or not, since it's actually 'hiding' the flaky tests, but this will 
> help reducing the flaky tests a lot if we're not going to tackle it in the 
> near time, and we can check the testing history to find out which tests are 
> flaky and deal with them separately. So let me know if this seems to provide 
> any benefit in short term, if it is I'll provide a patch to do that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3106) Zookeeper client supports IPv6 address and document the "IPV6 feature"

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642001#comment-16642001
 ] 

Hudson commented on ZOOKEEPER-3106:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #223 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/223/])
ZOOKEEPER-3106: Zookeeper client supports IPv6 address and document the (andor: 
rev effa016c621aea5debd640181b3e07b86fc14e0d)
* (edit) zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/ConfigUtils.java
* (edit) 
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
* (edit) 
zookeeper-common/src/test/java/org/apache/zookeeper/test/ConnectStringParserTest.java
* (edit) 
zookeeper-common/src/test/java/org/apache/zookeeper/test/ClientPortBindTest.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/util/ConfigUtilsTest.java


> Zookeeper client supports IPv6 address and document the "IPV6 feature"
> --
>
> Key: ZOOKEEPER-3106
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3106
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation, java client
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> This issue is the follow-up work of 
> [ZOOKEEPER-3057|https://issues.apache.org/jira/browse/ZOOKEEPER-3057]
> 1.ZK server side supports ipv6 style like this: 
> server.1=[2001:db8:1::242:ac11:2]:2888:3888,but zk client side supports ipv6 
> like this:2001:db8:1::242:ac11:2:2181.we need unify them.
>  Look at the kafka example 
> [KAFKA-1123|https://issues.apache.org/jira/browse/KAFKA-1123]. its producer 
> client also supports ipv6 like this: [2001:db8:1::242:ac11:2]
> 2.document the "IPV6 feature" to let user know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper-trunk - Build # 223 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/223/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 196.43 KB...]
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.401 sec, Thread: 2, Class: 
org.apache.zookeeper.server.quorum.auth.QuorumDigestAuthTest
[junit] Running 
org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.002 sec, Thread: 2, Class: 
org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthTest
[junit] Running 
org.apache.zookeeper.server.quorum.auth.QuorumKerberosHostBasedAuthTest in 
thread 2
[junit] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
36.582 sec, Thread: 8, Class: org.apache.zookeeper.server.quorum.Zab1_0Test
[junit] Running org.apache.zookeeper.server.util.BitHashSetTest in thread 8
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.086 sec, Thread: 8, Class: org.apache.zookeeper.server.util.BitHashSetTest
[junit] Running org.apache.zookeeper.server.util.BitMapTest in thread 8
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.083 sec, Thread: 8, Class: org.apache.zookeeper.server.util.BitMapTest
[junit] Running org.apache.zookeeper.server.util.ConfigUtilsTest in thread 8
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.309 sec, Thread: 8, Class: org.apache.zookeeper.server.util.ConfigUtilsTest
[junit] Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
282.766 sec, Thread: 3, Class: org.apache.zookeeper.server.PurgeTxnTest
[junit] Running org.apache.zookeeper.server.util.SerializeUtilsTest in 
thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.326 sec, Thread: 8, Class: org.apache.zookeeper.server.util.SerializeUtilsTest
[junit] Running org.apache.zookeeper.server.PurgeTxnTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 
sec, Thread: 3, Class: org.apache.zookeeper.server.PurgeTxnTest
[junit] Test org.apache.zookeeper.server.PurgeTxnTest FAILED (crashed)
[junit] Running org.apache.zookeeper.server.watch.WatchManagerTest in 
thread 3
[junit] Running org.apache.zookeeper.server.util.VerifyingFileFactoryTest 
in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.116 sec, Thread: 8, Class: 
org.apache.zookeeper.server.util.VerifyingFileFactoryTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
38.023 sec, Thread: 4, Class: 
org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest
[junit] Running org.apache.zookeeper.server.watch.WatcherCleanerTest in 
thread 8
[junit] Running org.apache.zookeeper.server.watch.WatcherOrBitSetTest in 
thread 4
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.114 sec, Thread: 4, Class: 
org.apache.zookeeper.server.watch.WatcherOrBitSetTest
[junit] Running org.apache.zookeeper.server.watch.WatchesPathReportTest in 
thread 4
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.066 sec, Thread: 4, Class: 
org.apache.zookeeper.server.watch.WatchesPathReportTest
[junit] Running org.apache.zookeeper.server.watch.WatchesReportTest in 
thread 4
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.063 sec, Thread: 4, Class: org.apache.zookeeper.server.watch.WatchesReportTest
[junit] Running org.apache.zookeeper.server.watch.WatchesSummaryTest in 
thread 4
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.065 sec, Thread: 4, Class: 
org.apache.zookeeper.server.watch.WatchesSummaryTest
[junit] Running org.apache.zookeeper.client.ZKClientConfigTest in thread 4
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.188 sec, Thread: 4, Class: org.apache.zookeeper.client.ZKClientConfigTest
[junit] Running org.apache.jute.BinaryInputArchiveTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.082 sec, Thread: 4, Class: org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 512, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
283.625 sec, Thread: 5, Class: org.apache.zookeeper.server.ServerIdTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.084 sec, Thread: 8, Class: 
org.apache.zookeeper.server.watch.WatcherCleanerTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.348 sec, Thread: 3, Class: org.apache.zookeeper.server.watch.WatchManagerTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
26.28 sec, Thread: 2, Class: 

ZooKeeper_branch35_jdk8 - Build # 1147 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1147/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 63.98 KB...]
[junit] Running org.apache.zookeeper.server.quorum.ReconfigRecoveryTest in 
thread 6
[junit] Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
90.122 sec, Thread: 2, Class: 
org.apache.zookeeper.server.quorum.QuorumRequestPipelineTest
[junit] Running 
org.apache.zookeeper.server.quorum.ReconfigRollingRestartCompatibilityTest in 
thread 2
[junit] Tests run: 512, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
227.401 sec, Thread: 8, Class: org.apache.zookeeper.server.ServerIdTest
[junit] Running org.apache.zookeeper.server.quorum.RemotePeerBeanTest in 
thread 8
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.378 sec, Thread: 8, Class: 
org.apache.zookeeper.server.quorum.RemotePeerBeanTest
[junit] Running org.apache.zookeeper.server.quorum.StandaloneDisabledTest 
in thread 8
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
27.894 sec, Thread: 2, Class: 
org.apache.zookeeper.server.quorum.ReconfigRollingRestartCompatibilityTest
[junit] Running org.apache.zookeeper.server.quorum.StatCommandTest in 
thread 2
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.456 sec, Thread: 2, Class: org.apache.zookeeper.server.quorum.StatCommandTest
[junit] Running org.apache.zookeeper.server.quorum.StatResetCommandTest in 
thread 2
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.469 sec, Thread: 2, Class: 
org.apache.zookeeper.server.quorum.StatResetCommandTest
[junit] Running org.apache.zookeeper.server.quorum.UnifiedServerSocketTest 
in thread 2
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.72 sec, Thread: 2, Class: 
org.apache.zookeeper.server.quorum.UnifiedServerSocketTest
[junit] Running org.apache.zookeeper.server.quorum.WatchLeakTest in thread 2
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
51.602 sec, Thread: 7, Class: 
org.apache.zookeeper.server.quorum.ReconfigLegacyTest
[junit] Running org.apache.zookeeper.server.quorum.Zab1_0Test in thread 7
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
60.875 sec, Thread: 1, Class: 
org.apache.zookeeper.server.quorum.ReconfigFailureCasesTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.495 sec, Thread: 2, Class: org.apache.zookeeper.server.quorum.WatchLeakTest
[junit] Running org.apache.zookeeper.server.quorum.auth.MiniKdcTest in 
thread 2
[junit] Running 
org.apache.zookeeper.server.quorum.auth.QuorumAuthUpgradeTest in thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.686 sec, Thread: 2, Class: org.apache.zookeeper.server.quorum.auth.MiniKdcTest
[junit] Running 
org.apache.zookeeper.server.quorum.auth.QuorumDigestAuthTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
848.54 sec, Thread: 5, Class: org.apache.zookeeper.test.DisconnectedWatcherTest
[junit] Test org.apache.zookeeper.test.DisconnectedWatcherTest FAILED
[junit] Running 
org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthTest in thread 5
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.292 sec, Thread: 2, Class: 
org.apache.zookeeper.server.quorum.auth.QuorumDigestAuthTest
[junit] Running 
org.apache.zookeeper.server.quorum.auth.QuorumKerberosHostBasedAuthTest in 
thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.91 sec, Thread: 5, Class: 
org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthTest
[junit] Running org.apache.zookeeper.server.util.SerializeUtilsTest in 
thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.318 sec, Thread: 5, Class: org.apache.zookeeper.server.util.SerializeUtilsTest
[junit] Running org.apache.zookeeper.server.util.VerifyingFileFactoryTest 
in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.082 sec, Thread: 5, Class: 
org.apache.zookeeper.server.util.VerifyingFileFactoryTest
[junit] Running org.apache.zookeeper.client.ZKClientConfigTest in thread 5
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.211 sec, Thread: 5, Class: org.apache.zookeeper.client.ZKClientConfigTest
[junit] Running org.apache.jute.BinaryInputArchiveTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.077 sec, Thread: 5, Class: org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
35.525 sec, Thread: 7, Class: 

[GitHub] zookeeper issue #655: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/655
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2384/



---

Failed: ZOOKEEPER- PreCommit Build #2384

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2384/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 80.55 MB...]
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2384//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2384//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2384//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=BB4C92F7AE343E38BC89B369F536C6A8.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1955:
 exec returned: 1

Total time: 22 minutes 48 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-236
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting status of eb272749d76b91cce61199e15089fa76506c8fba to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2384/ and 
message: 'FAILURE
 1798 tests run, 2 skipped, 0 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2384/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #659: ZOOKEEPER-3161. Refactor QuorumPeerMainTest.java: move...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/659
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2383/



---

Failed: ZOOKEEPER- PreCommit Build #2383

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2383/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 77.96 MB...]
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2383//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2383//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2383//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=13010DC8D46BB1336C267C7750C6BE64.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1953:
 exec returned: 1

Total time: 19 minutes 5 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3161
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting status of e3137db443ad304bf1740665e478ee60ec9f900b to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2383/ and 
message: 'FAILURE
 1760 tests run, 1 skipped, 2 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2383/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
2 tests failed.
FAILED:  
org.apache.zookeeper.server.PurgeTxnTest.testPurgeWhenLogRollingInProgress

Error Message:
ZkClient ops is not finished!

Stack Trace:
junit.framework.AssertionFailedError: ZkClient ops is not finished!
at 
org.apache.zookeeper.server.PurgeTxnTest.manyClientOps(PurgeTxnTest.java:589)
at 
org.apache.zookeeper.server.PurgeTxnTest.testPurgeWhenLogRollingInProgress(PurgeTxnTest.java:150)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


FAILED:  
org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset

Error Message:
test timed out after 84 milliseconds

Stack Trace:
org.junit.runners.model.TestTimedOutException: test timed out after 84 
milliseconds
at java.lang.Object.wait(Native Method)
at java.lang.Object.wait(Object.java:502)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1524)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1507)
at org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:2262)
at 
org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset(DisconnectedWatcherTest.java:243)
at 

[GitHub] zookeeper issue #655: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/655
  
retest this please


---

Failed: ZOOKEEPER- PreCommit Build #2382

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2382/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 76.61 MB...]
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2382//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2382//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2382//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=95FC7499BD0A1149DC0A27F0766FA19E.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1953:
 exec returned: 1

Total time: 21 minutes 54 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3113
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting status of 7454d7e7efab916ae70aea03dcbf8921c18ad2fa to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2382/ and 
message: 'FAILURE
 1764 tests run, 1 skipped, 0 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2382/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #651: ZOOKEEPER-3113 EphemeralType.get() fails to verify eph...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/651
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2382/



---

[jira] [Updated] (ZOOKEEPER-3161) Refactor QuorumPeerMainTest.java: move commonly used functions to base class

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3161:
--
Labels: pull-request-available  (was: )

> Refactor QuorumPeerMainTest.java: move commonly used functions to base class
> 
>
> Key: ZOOKEEPER-3161
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3161
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: tests
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
>
> Move the following methods to QuorumPeerTestBase.java:
> - tearDown()
> - LaunchServers()
> - waitForOne(), waitForAll()
> - logStates()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #659: ZOOKEEPER-3161. Refactor QuorumPeerMainTest.jav...

[anmolnar]

GitHub user anmolnar opened a pull request:

https://github.com/apache/zookeeper/pull/659

ZOOKEEPER-3161. Refactor QuorumPeerMainTest.java: move commonly used 
functions to base class

Move the following methods to QuorumPeerTestBase.java:

tearDown()
LaunchServers()
waitForOne(), waitForAll()
logStates()

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-3161

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #659


commit e3137db443ad304bf1740665e478ee60ec9f900b
Author: Andor Molnar 
Date:   2018-09-20T09:56:42Z

ZOOKEEPER-3161. Refactor QuorumPeerMainTest




---

Failed: ZOOKEEPER- PreCommit Build #2381

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2381/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 82.71 MB...]
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2381//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2381//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2381//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=F2EDE1928FF3049FF35F18D8BEA7C193.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1953:
 exec returned: 1

Total time: 19 minutes 10 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3159
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting status of 98012eea9f46899ffb3b4675bd19404df9d076da to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2381/ and 
message: 'FAILURE
 1751 tests run, 1 skipped, 3 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2381/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
3 tests failed.
FAILED:  org.apache.zookeeper.server.PurgeTxnTest.testPurgeTxnLogWithDataDir

Error Message:
Forked Java VM exited abnormally. Please note the time in the report does not 
reflect the time until the VM exit.

Stack Trace:
junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please 
note the time in the report does not reflect the time until the VM exit.
at java.lang.Thread.run(Thread.java:748)


FAILED:  
org.apache.zookeeper.server.quorum.ReconfigFailureCasesTest.testLeaderTimesoutOnNewQuorum

Error Message:
expected:<[leaderelection]> but was:<[following]>

Stack Trace:
junit.framework.AssertionFailedError: expected:<[leaderelection]> but 
was:<[following]>
at 
org.apache.zookeeper.server.quorum.ReconfigFailureCasesTest.testLeaderTimesoutOnNewQuorum(ReconfigFailureCasesTest.java:198)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


FAILED:  
org.apache.zookeeper.test.DisconnectedWatcherTest.testManyChildWatchersAutoReset

Error Message:
test timed out after 84 milliseconds

Stack Trace:
org.junit.runners.model.TestTimedOutException: test timed out after 84 
milliseconds
at java.lang.Object.wait(Native Method)
at 

[GitHub] zookeeper issue #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testCl...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/653
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2381/



---

[jira] [Created] (ZOOKEEPER-3161) Refactor QuorumPeerMainTest.java: move commonly used functions to base class

[Andor Molnar (JIRA)]

Andor Molnar created ZOOKEEPER-3161:
---

 Summary: Refactor QuorumPeerMainTest.java: move commonly used 
functions to base class
 Key: ZOOKEEPER-3161
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3161
 Project: ZooKeeper
  Issue Type: Improvement
  Components: tests
Affects Versions: 3.5.4, 3.6.0
Reporter: Andor Molnar
Assignee: Andor Molnar


Move the following methods to QuorumPeerTestBase.java:
- tearDown()
- LaunchServers()
- waitForOne(), waitForAll()
- logStates()




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER- PreCommit Build #2380

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2380/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 79.66 MB...]
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2380//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2380//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2380//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=3098F9D256B2FCDD9757C10C717C4B07.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1955:
 exec returned: 1

Total time: 14 minutes 41 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-236
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Adding one-line test results to commit status...
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting status of eb272749d76b91cce61199e15089fa76506c8fba to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2380/ and 
message: 'FAILURE
 1798 tests run, 2 skipped, 1 failed.'
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2380/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig

Error Message:
waiting for server 4 being up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server 4 being up
at 
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig(ReconfigRecoveryTest.java:224)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[GitHub] zookeeper issue #655: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

[asfgit]

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/655
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2380/



---

[GitHub] zookeeper issue #656: ZOOKEEPER-3032: MAVEN MIGRATION - branch-3.5 - move ja...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/656
  
This is merged. Thanks @nkalmar !
Please close this PR.


---

[jira] [Updated] (ZOOKEEPER-2979) Use dropwizard library histogram for proposal-related metrics

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-2979:
--
Labels: pull-request-available  (was: )

> Use dropwizard library histogram for proposal-related metrics
> -
>
> Key: ZOOKEEPER-2979
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2979
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
>
> This Jira in intended to be the successor of ZOOKEEPER-2939.
> By using dropwizard library's Histogram component we'll be able to provide 
> more sophisticated statistics on Proposal sizes.
> From the docs:
> "A histogram measures the statistical distribution of values in a stream of 
> data. In addition to minimum, maximum, mean, etc., it also measures median, 
> 75th, 90th, 95th, 98th, 99th, and 99.9th percentiles."
> [http://metrics.dropwizard.io/3.1.0/manual/core/#histograms]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #440: ZOOKEEPER-2979 Use dropwizard library histogram...

[anmolnar]

Github user anmolnar closed the pull request at:

https://github.com/apache/zookeeper/pull/440


---

[GitHub] zookeeper issue #657: ZOOKEEPER-3157. Improve FuzzySnapshotRelatedTest to av...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/657
  
Apologies, committed my own patch. Test fix, got 2 approvals, one from the 
original author.


---

[jira] [Resolved] (ZOOKEEPER-3157) Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection loss

[Andor Molnar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar resolved ZOOKEEPER-3157.
-
Resolution: Fixed

Issue resolved by pull request 657
[https://github.com/apache/zookeeper/pull/657]

> Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection 
> loss
> --
>
> Key: ZOOKEEPER-3157
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3157
> Project: ZooKeeper
>  Issue Type: Test
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Fangmin Lv
>Assignee: Andor Molnar
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> [~hanm] noticed that the test might failure because of ConnectionLoss when 
> trying to getData, [here is an 
> example|https://builds.apache.org/job/ZooKeepertrunk/198/testReport/junit/org.apache.zookeeper.server.quorum/FuzzySnapshotRelatedTest/testPZxidUpdatedWhenLoadingSnapshot],
>  we should catch this and retry to avoid flaky.
> Internally, we 'fixed' flaky test by adding junit.RetryRule in ZKTestCase, 
> which is the base class for most of the tests. I'm not sure this is the right 
> way to go or not, since it's actually 'hiding' the flaky tests, but this will 
> help reducing the flaky tests a lot if we're not going to tackle it in the 
> near time, and we can check the testing history to find out which tests are 
> flaky and deal with them separately. So let me know if this seems to provide 
> any benefit in short term, if it is I'll provide a patch to do that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #657: ZOOKEEPER-3157. Improve FuzzySnapshotRelatedTes...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/657


---

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

[eolivelli]

Github user eolivelli commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/587#discussion_r223347154
  
--- Diff: 
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
 ---
@@ -68,14 +71,16 @@ public ConnectStringParser(String connectString) {
 List hostsList = split(connectString,",");
 for (String host : hostsList) {
 int port = DEFAULT_PORT;
-int pidx = host.lastIndexOf(':');
-if (pidx >= 0) {
-// otherwise : is at the end of the string, ignore
-if (pidx < host.length() - 1) {
-port = Integer.parseInt(host.substring(pidx + 1));
+try {
+String[] hostAndPort = ConfigUtils.getHostAndPort(host);
+host = hostAndPort[0];
+if (hostAndPort.length == 2) {
+port = Integer.parseInt(hostAndPort[1]);
 }
-host = host.substring(0, pidx);
+} catch (ConfigException e) {
+e.printStackTrace();
--- End diff --

cc @maoling 


---

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

[eolivelli]

Github user eolivelli commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/587#discussion_r223346987
  
--- Diff: 
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
 ---
@@ -68,14 +71,16 @@ public ConnectStringParser(String connectString) {
 List hostsList = split(connectString,",");
 for (String host : hostsList) {
 int port = DEFAULT_PORT;
-int pidx = host.lastIndexOf(':');
-if (pidx >= 0) {
-// otherwise : is at the end of the string, ignore
-if (pidx < host.length() - 1) {
-port = Integer.parseInt(host.substring(pidx + 1));
+try {
+String[] hostAndPort = ConfigUtils.getHostAndPort(host);
+host = hostAndPort[0];
+if (hostAndPort.length == 2) {
+port = Integer.parseInt(hostAndPort[1]);
 }
-host = host.substring(0, pidx);
+} catch (ConfigException e) {
+e.printStackTrace();
--- End diff --

@anmolnar I forgot to push "Request changes".


---

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

[eolivelli]

Github user eolivelli commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/587#discussion_r223215411
  
--- Diff: 
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
 ---
@@ -68,14 +71,16 @@ public ConnectStringParser(String connectString) {
 List hostsList = split(connectString,",");
 for (String host : hostsList) {
 int port = DEFAULT_PORT;
-int pidx = host.lastIndexOf(':');
-if (pidx >= 0) {
-// otherwise : is at the end of the string, ignore
-if (pidx < host.length() - 1) {
-port = Integer.parseInt(host.substring(pidx + 1));
+try {
+String[] hostAndPort = ConfigUtils.getHostAndPort(host);
+host = hostAndPort[0];
+if (hostAndPort.length == 2) {
+port = Integer.parseInt(hostAndPort[1]);
 }
-host = host.substring(0, pidx);
+} catch (ConfigException e) {
+e.printStackTrace();
--- End diff --

Nit: use logger

I wonder if we should fail and not swallow the error


---

[GitHub] zookeeper issue #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 address...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/587
  
Committed to master. Thanks @maoling !
This patch doesn't apply to branch-3.5, but I think we should fix the issue 
on it too.
Would you please open a separate pull request?


---

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/587


---

ZooKeeper_branch35_jdk8 - Build # 1146 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1146/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 68.99 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
248.151 sec, Thread: 1, Class: org.apache.zookeeper.test.QuorumHammerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.532 sec, Thread: 3, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
1
[junit] Running org.apache.zookeeper.test.SessionTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.391 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.181 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
1
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.126 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 1
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
14.081 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
132.686 sec, Thread: 4, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.862 sec, Thread: 3, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.058 sec, Thread: 4, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 3
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.084 sec, Thread: 4, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.962 sec, Thread: 4, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.563 sec, Thread: 3, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 3
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
88.012 sec, Thread: 5, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.131 sec, Thread: 5, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
26.477 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 1
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
4.065 sec, Thread: 5, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 5
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.12 sec, Thread: 5, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
13.551 sec, Thread: 3, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 5
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.065 sec, Thread: 3, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Running org.apache.jute.BinaryInputArchiveTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.129 sec, Thread: 3, Class: org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
30.437 sec, Thread: 4, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.002 sec, Thread: 5, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
  

Re: ZooKeeper 3.5 blocker issues

[Andor Molnar]

Hi,

Let me summarize and give a quick update on the outstanding issues for 3.5 GA:

- ZOOKEEPER-1818 (Fix don't care for trunk)
- ZOOKEEPER-2778 (Potential server deadlock between follower sync with leader 
and follower receiving external connection requests.)
- ZOOKEEPER-3021 Migrate project structure to Maven (ongoing)
- ZOOKEEPER-925 Docs generation to Maven
- ZOOKEEPER-3104 (waiting for backport)
- ZOOKEEPER-3125 (waiting for backport PR #647)

The 2 Maven related tickets are no-brainers as well as the backports. ZK-2778 
has been picked up by Maoling (thanks!) as far as I can see, ZK-1818 is the 
only one waiting for a volunteer.

Please correct me if I’ve missed something.

Regards,
Andor




> On 2018. Sep 28., at 18:32, Tamas Penzes  wrote:
> 
> Hi All,
> 
> I would add ZOOKEEPER-3021
>  Migrate project
> structure to Maven build as a blocker too. Since the migration has started
> it would be good to finish before releasing ZK 3.5.x GA.
> 
> ZOOKEEPER-925  replace
> our forrest site and documentation generation might also be a good idea,
> since then we could deliver the new MarkDown based documentation.
> 
> Regards, Tamaas
> 
> On Fri, Sep 14, 2018 at 10:09 AM Fangmin Lv  wrote:
> 
>> Oh, sorry for the confusion, I should provide more context.
>> 
>> Leader will use on disk txn sync with followers to if the peer zxid is not
>> in it's in memory commit logs, the code is here: Leader on disk txn sync
>> <
>> https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java#L774
>>> .
>> There is bug that potentially there will be gap in the txn files, like
>> after snap sync, etc, so it's possible the peer will miss txns due to this.
>> 
>> The option to disable it is snapshotSizeFactor
>> <
>> https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZKDatabase.java#L81
>>> ,
>> set it to -1 will disable this feature. On 3.5, it's better to have a PR to
>> set this to -1 by default. It might have more SNAP sync, but from our prod
>> it doesn't seem to be a big problem to me.
>> 
>> I can send out the diff to disable it by default on 3.5 if you guys think
>> this is the right way to do.
>> 
>> Thanks,
>> Fangmin
>> 
>> On Thu, Sep 13, 2018 at 1:58 AM Andor Molnar  wrote:
>> 
>>> What’s needed to turn it off?
>>> Do we need a PR or it’s just a config option?
>>> Shall we implement a feature switch for that and turn it off by default?
>>> 
>>> Sorry I don’t have too much insight on disk txn sync.
>>> 
>>> Andor
>>> 
>>> 
>>> 
 On 2018. Sep 13., at 9:16, Fangmin Lv  wrote:
 
 And to be clear, ZOOKEEPER-2418 is actually just one case of
>>> inconsistency
 which could caused by on disk txn sync, as I mentioned in a newer JIRA
 ZOOKEEPER-2846 ,
>>> the
 snap sync or txn sync could also leave txns gap in the txn file, which
>>> is a
 more common case could trigger this issue.
 
 I would suggest to turn off the on disk txn sync by default for now to
 avoid this issue, after we finished ZOOKEEPER-3114, we can use that to
 validate the on disk txns during syncing.
 
 Thanks,
 Fangmin
 
 On Wed, Sep 12, 2018 at 9:55 AM Fangmin Lv 
>> wrote:
 
> Andor,
> 
> ZOOKEEPER-3114 is about adding real time digest checking to help
>>> detecting
> inconsistency, it's a new feature with amounts of code change. I'll
>>> start
> upstream it part by part, but I don't expect it's being merged in the
>>> next
> few weeks. So yes, it's a nice to have, but definitely not a block for
>>> 3.5.
> 
> Thanks,
> Fangmin
> 
> On Wed, Sep 12, 2018 at 2:55 AM Andor Molnar 
>> wrote:
> 
>> Fangmin,
>> 
>> Sorry, I just noticed that you want to include the consistency fixes
>> in
>> the stable version which is fine. Let’s finish the backports and
>> we’ll
>>> be
>> done with them.
>> 
>> ZOOKEEPER-3114 is essentially a new feature, I wouldn’t block 3.5
>> with
>> that. What do you think?
>> 
>> Andor
>> 
>> 
>> 
>>> On 2018. Sep 12., at 11:52, Andor Molnar  wrote:
>>> 
>>> Cool, thanks for the clarification.
>>> 
>>> The updated list is as follows:
>>> 
>>> - ZOOKEEPER-236 (SSL/TLS support for Atomic Broadcast protocol)
>>> - ZOOKEEPER-1818 (Fix don't care for trunk)
>>> - ZOOKEEPER-2778 (Potential server deadlock between follower sync
>> with
>> leader and follower receiving external connection requests.)
>>> 
>>> The following are not critical and no blockers for the stable
>> release:
>>> 
>>> Waiting for to be ported to 3.5:
>>> - ZOOKEEPER-3104
>>> - ZOOKEEPER-3125
>>> - ZOOKEEPER-3127
>>> 
>>> New feature:
>>> - ZOOKEEPER-3114 (fixes ZOOKEEPER-2184 

[GitHub] zookeeper issue #647: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/647
  
@lvfangmin Given that I've already provided a fix for the flakyness in #657 
, do we still need this retry rule?


---