[GitHub] zookeeper pull request #726: ZOOKEEPER-3205: o.a.jute test cases
Github user akkumar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/726#discussion_r236957794
--- Diff:
zookeeper-jute/src/test/java/org/apache/jute/BinaryInputArchiveTest.java ---
@@ -41,4 +42,136 @@ public void testReadStringCheckLength() {
e.getMessage().startsWith(BinaryInputArchive.UNREASONBLE_LENGTH));
}
}
+
+public interface TestWriter {
+void write(OutputArchive oa) throws IOException;
+}
+
+public interface TestReader {
+void read(InputArchive ia) throws IOException;
+}
+
+void checkWriterAndReader(TestWriter writer, TestReader reader) {
+ByteArrayOutputStream baos = new ByteArrayOutputStream();
+BinaryOutputArchive oa = BinaryOutputArchive.getArchive(baos);
+try {
+writer.write(oa);
+} catch (IOException e) {
+Assert.fail("Should not throw IOException");
+}
+InputStream is = new ByteArrayInputStream(baos.toByteArray());
+BinaryInputArchive ia = BinaryInputArchive.getArchive(is);
+try {
+reader.read(ia);
+} catch (IOException e) {
+Assert.fail("Should not throw IOException while reading back");
+}
+}
+
+@Test
+public void testWriteInt() {
+final int expected = 4;
+final String tag = "tag1";
+checkWriterAndReader(
+new TestWriter() {
--- End diff --
fixed. let me know if this looks ok !
---
[jira] [Resolved] (ZOOKEEPER-3181) ZOOKEEPER-2355 broke Curator TestingQuorumPeerMain
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka resolved ZOOKEEPER-3181. -- Resolution: Not A Problem This problem is likely to be fixed by Apache Curator side, so closing this. > ZOOKEEPER-2355 broke Curator TestingQuorumPeerMain > -- > > Key: ZOOKEEPER-3181 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3181 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.5.3, 3.4.11 >Reporter: Akira Ajisaka >Priority: Major > Labels: pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > > ZOOKEEPER-2355 added a getQuorumPeer method to QuorumPeerMain > [https://github.com/apache/zookeeper/blob/release-3.5.3/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java#L194]. > TestingQuorumPeerMain has an identically named method, which is now > unintentionally overridding the one in the base class. > This is fixed by CURATOR-409, however, I'd like this to be fixed in ZooKeeper > as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #676: ZOOKEEPER-3181: ZOOKEEPER-2355 broke Curator TestingQu...
Github user aajisaka commented on the issue: https://github.com/apache/zookeeper/pull/676 Apache Curator 2.x release is likely to happen, so I close this PR. Thank you for your discussion. ---
[GitHub] zookeeper pull request #676: ZOOKEEPER-3181: ZOOKEEPER-2355 broke Curator Te...
Github user aajisaka closed the pull request at: https://github.com/apache/zookeeper/pull/676 ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/680 @ivmaykov No, I think it's fine to keep `FileChangeWatcher`. I keep looking... ---
[GitHub] zookeeper issue #726: ZOOKEEPER-3205: o.a.jute test cases
Github user akkumar commented on the issue: https://github.com/apache/zookeeper/pull/726 Ok - in the logs I see this. Any suggestion what needs to be done to get this sorted out ? ``` [exec] [exec] [exec] Error: No value specified for option "issue" [exec] Session logged out. Session was JSESSIONID= [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] [exec] mv: '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' and '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess' are the same file ``` ---
[GitHub] zookeeper issue #726: ZOOKEEPER-3205: o.a.jute test cases
Github user akkumar commented on the issue: https://github.com/apache/zookeeper/pull/726 The test cases seem to run with no failures. It is not obvious what caused the jenkins failure ? Any suggestions where to look for ? ---
[jira] [Commented] (ZOOKEEPER-3194) Quorum TLS - fix copy/paste bug in ZKTrustManager
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701143#comment-16701143 ] Hudson commented on ZOOKEEPER-3194: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #286 (See [https://builds.apache.org/job/ZooKeeper-trunk/286/]) ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug in ZKTrustManager (andor: rev a109b8b5034a160c3ad0f4d2b790df962ff4dc47) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKTrustManager.java > Quorum TLS - fix copy/paste bug in ZKTrustManager > - > > Key: ZOOKEEPER-3194 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3194 > Project: ZooKeeper > Issue Type: Bug > Components: security >Affects Versions: 3.6.0, 3.5.5 >Reporter: Ilya Maykov >Assignee: Ilya Maykov >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > There is an obvious copy/paste bug in ZKTrustManager: > ZKTrustManager.checkClientTrusted() is calling > x509ExtendedTrustManager.checkServerTrusted(). It should call > x509ExtendedTrustManager.checkClientTrusted() instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3194) Quorum TLS - fix copy/paste bug in ZKTrustManager
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701091#comment-16701091 ] Hudson commented on ZOOKEEPER-3194: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #125 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/125/]) ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug in ZKTrustManager (andor: rev a109b8b5034a160c3ad0f4d2b790df962ff4dc47) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKTrustManager.java > Quorum TLS - fix copy/paste bug in ZKTrustManager > - > > Key: ZOOKEEPER-3194 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3194 > Project: ZooKeeper > Issue Type: Bug > Components: security >Affects Versions: 3.6.0, 3.5.5 >Reporter: Ilya Maykov >Assignee: Ilya Maykov >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > There is an obvious copy/paste bug in ZKTrustManager: > ZKTrustManager.checkClientTrusted() is calling > x509ExtendedTrustManager.checkServerTrusted(). It should call > x509ExtendedTrustManager.checkClientTrusted() instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3194) Quorum TLS - fix copy/paste bug in ZKTrustManager
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3194. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 > Quorum TLS - fix copy/paste bug in ZKTrustManager > - > > Key: ZOOKEEPER-3194 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3194 > Project: ZooKeeper > Issue Type: Bug > Components: security >Affects Versions: 3.6.0, 3.5.5 >Reporter: Ilya Maykov >Assignee: Ilya Maykov >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > There is an obvious copy/paste bug in ZKTrustManager: > ZKTrustManager.checkClientTrusted() is calling > x509ExtendedTrustManager.checkServerTrusted(). It should call > x509ExtendedTrustManager.checkClientTrusted() instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #709: ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug in ZKT...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/709 Committed. Thanks @ivmaykov ! ---
[GitHub] zookeeper pull request #709: ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug...
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/709 ---
ZooKeeper_branch35_jdk8 - Build # 1209 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1209/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 66.03 KB...] [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.653 sec, Thread: 3, Class: org.apache.zookeeper.test.SaslSuperUserTest [junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 3 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.393 sec, Thread: 3, Class: org.apache.zookeeper.test.ServerCnxnTest [junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 3 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.539 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionInvalidationTest [junit] Running org.apache.zookeeper.test.SessionTest in thread 3 [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.16 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest [junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 3 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.25 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTimeoutTest [junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 3 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.087 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTrackerCheckTest [junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 3 [junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 334.406 sec, Thread: 1, Class: org.apache.zookeeper.test.NettyNettySuiteTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.634 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionUpgradeTest [junit] Running org.apache.zookeeper.test.StandaloneTest in thread 3 [junit] Running org.apache.zookeeper.test.StatTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.215 sec, Thread: 1, Class: org.apache.zookeeper.test.StatTest [junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.623 sec, Thread: 3, Class: org.apache.zookeeper.test.StandaloneTest [junit] Running org.apache.zookeeper.test.StringUtilTest in thread 3 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.076 sec, Thread: 3, Class: org.apache.zookeeper.test.StringUtilTest [junit] Running org.apache.zookeeper.test.SyncCallTest in thread 3 [junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.069 sec, Thread: 1, Class: org.apache.zookeeper.test.StaticHostProviderTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.827 sec, Thread: 3, Class: org.apache.zookeeper.test.SyncCallTest [junit] Running org.apache.zookeeper.test.TruncateTest in thread 1 [junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in thread 3 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.271 sec, Thread: 1, Class: org.apache.zookeeper.test.TruncateTest [junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.09 sec, Thread: 1, Class: org.apache.zookeeper.test.WatchedEventTest [junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 1 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.033 sec, Thread: 1, Class: org.apache.zookeeper.test.WatcherFuncTest [junit] Running org.apache.zookeeper.test.WatcherTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.542 sec, Thread: 3, Class: org.apache.zookeeper.test.WatchEventWhenAutoResetTest [junit] Running org.apache.zookeeper.test.X509AuthTest in thread 3 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.086 sec, Thread: 3, Class: org.apache.zookeeper.test.X509AuthTest [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in thread 3 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.6 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 3 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.649 sec, Thread: 3, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Running org.apache.zookeeper.util.PemReaderTest in thread 3 [junit] Tests run: 64, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.78 sec, Thread: 3, Class: org.apache.zookeeper.util.PemReaderTest [junit] Running org.apache.jute.BinaryInputArchiveTest in thread 3
[GitHub] zookeeper pull request #726: ZOOKEEPER-3205: o.a.jute test cases
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/726#discussion_r236804588
--- Diff:
zookeeper-jute/src/test/java/org/apache/jute/BinaryInputArchiveTest.java ---
@@ -41,4 +42,136 @@ public void testReadStringCheckLength() {
e.getMessage().startsWith(BinaryInputArchive.UNREASONBLE_LENGTH));
}
}
+
+public interface TestWriter {
+void write(OutputArchive oa) throws IOException;
+}
+
+public interface TestReader {
+void read(InputArchive ia) throws IOException;
+}
+
+void checkWriterAndReader(TestWriter writer, TestReader reader) {
+ByteArrayOutputStream baos = new ByteArrayOutputStream();
+BinaryOutputArchive oa = BinaryOutputArchive.getArchive(baos);
+try {
+writer.write(oa);
+} catch (IOException e) {
+Assert.fail("Should not throw IOException");
+}
+InputStream is = new ByteArrayInputStream(baos.toByteArray());
+BinaryInputArchive ia = BinaryInputArchive.getArchive(is);
+try {
+reader.read(ia);
+} catch (IOException e) {
+Assert.fail("Should not throw IOException while reading back");
+}
+}
+
+@Test
+public void testWriteInt() {
+final int expected = 4;
+final String tag = "tag1";
+checkWriterAndReader(
+new TestWriter() {
--- End diff --
Can we use lambdas?
---
[GitHub] zookeeper issue #709: ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug in ZKT...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/709 @anmolnar could you merge this into master and branch-3.5? ---
[GitHub] zookeeper pull request #727: ZOOKEEPER-3172: Quorum TLS - fix port unificati...
Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/727 ---
[jira] [Commented] (ZOOKEEPER-3174) Quorum TLS - support reloading trust/key store
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700818#comment-16700818 ] Ilya Maykov commented on ZOOKEEPER-3174: [~mkedwards] yes, I will make sure the fix is backported to branch-3.5 as well > Quorum TLS - support reloading trust/key store > -- > > Key: ZOOKEEPER-3174 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3174 > Project: ZooKeeper > Issue Type: Improvement >Affects Versions: 3.6.0, 3.5.5 >Reporter: Ilya Maykov >Assignee: Ilya Maykov >Priority: Major > Labels: pull-request-available > Time Spent: 9h 40m > Remaining Estimate: 0h > > The Quorum TLS feature recently added in ZOOKEEPER-236 doesn't support > reloading a trust/key store from disk when it changes. In an environment > where short-lived certificates are used and are refreshed by some background > daemon / cron job, this is a problem. Let's support reloading a trust/key > store from disk when the file on disk changes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/680 @anmolnar I just stumbled across the FileMonitor class, which has similar functionality to my FileChangeWatcher. The main difference is that it polls for changes and sleeps the thread in between, rather than using WatchService. It also ignores mtime changes if the file contents have not changed. Maybe I should use FileMonitor and remove the FileChangeWatcher class? ---
[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/719 I'm waiting for @eolivelli 's feedback on the other PR. ---
[jira] [Resolved] (ZOOKEEPER-3172) Quorum TLS - fix port unification to allow rolling upgrades
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3172. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue resolved by pull request 727 [https://github.com/apache/zookeeper/pull/727] > Quorum TLS - fix port unification to allow rolling upgrades > --- > > Key: ZOOKEEPER-3172 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3172 > Project: ZooKeeper > Issue Type: Improvement > Components: security, server >Affects Versions: 3.6.0, 3.5.5 >Reporter: Ilya Maykov >Assignee: Ilya Maykov >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 10h 10m > Remaining Estimate: 0h > > ZOOKEEPER-236 was committed with port unification support disabled, because > of various issues with the implementation. These issues should be fixed so > port unification can be enabled again. Port unification is necessary to > upgrade an ensemble from plaintext to TLS quorum connections without downtime. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #727: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/727 @ivmaykov Committed. Thanks, please close this PR. ---
[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...
Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/680 ---
[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...
GitHub user ivmaykov reopened a pull request: https://github.com/apache/zookeeper/pull/680 ZOOKEEPER-3174: Quorum TLS - support reloading trust/key store Allow reloading SSL trust stores and key stores from disk when the files on disk change. ## Added support for reloading key/trust stores when the file on disk changes - new property `sslQuorumReloadCertFiles` which controls the behavior for reloading the key and trust store files for `QuorumX509Util`. Reloading of key and trust store for `ClientX509Util` is not in this PR but could be added easily - this allows a ZK server to keep running on a machine that uses short-lived certs that refresh frequently without having to restart the ZK process. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivmaykov/zookeeper ZOOKEEPER-3174 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/680.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #680 commit 6c492bbad6021c12f3e1bc0b57a3b35bab771696 Author: Ilya Maykov Date: 2018-10-25T01:54:06Z ZOOKEEPER-3174: Quorum TLS - support reloading trust/key store ---
[GitHub] zookeeper issue #707: [ZOOKEEPER-2778] QuorumPeer: encapsulate addresses
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/707 That makes perfect sense. Thanks for keeping an eye on this. ---
[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700689#comment-16700689
]
Michael K. Edwards commented on ZOOKEEPER-2778:
---
The current versions of this patch (#719 for master, #707 for branch-3.5) build
green and don't have extraneous content.
> Potential server deadlock between follower sync with leader and follower
> receiving external connection requests.
>
>
> Key: ZOOKEEPER-2778
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2778
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.5.3
>Reporter: Michael Han
>Assignee: Michael K. Edwards
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> It's possible to have a deadlock during recovery phase.
> Found this issue by analyzing thread dumps of "flaky" ReconfigRecoveryTest
> [1]. . Here is a sample thread dump that illustrates the state of the
> execution:
> {noformat}
> [junit] java.lang.Thread.State: BLOCKED
> [junit] at
> org.apache.zookeeper.server.quorum.QuorumPeer.getElectionAddress(QuorumPeer.java:686)
> [junit] at
> org.apache.zookeeper.server.quorum.QuorumCnxManager.initiateConnection(QuorumCnxManager.java:265)
> [junit] at
> org.apache.zookeeper.server.quorum.QuorumCnxManager.connectOne(QuorumCnxManager.java:445)
> [junit] at
> org.apache.zookeeper.server.quorum.QuorumCnxManager.receiveConnection(QuorumCnxManager.java:369)
> [junit] at
> org.apache.zookeeper.server.quorum.QuorumCnxManager$Listener.run(QuorumCnxManager.java:642)
> [junit]
> [junit] java.lang.Thread.State: BLOCKED
> [junit] at
> org.apache.zookeeper.server.quorum.QuorumCnxManager.connectOne(QuorumCnxManager.java:472)
> [junit] at
> org.apache.zookeeper.server.quorum.QuorumPeer.connectNewPeers(QuorumPeer.java:1438)
> [junit] at
> org.apache.zookeeper.server.quorum.QuorumPeer.setLastSeenQuorumVerifier(QuorumPeer.java:1471)
> [junit] at
> org.apache.zookeeper.server.quorum.Learner.syncWithLeader(Learner.java:520)
> [junit] at
> org.apache.zookeeper.server.quorum.Follower.followLeader(Follower.java:88)
> [junit] at
> org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1133)
> {noformat}
> The dead lock happens between the quorum peer thread which running the
> follower that doing sync with leader work, and the listener of the qcm of the
> same quorum peer that doing the receiving connection work. Basically to
> finish sync with leader, the follower needs to synchronize on both QV_LOCK
> and the qmc object it owns; while in the receiver thread to finish setup an
> incoming connection the thread needs to synchronize on both the qcm object
> the quorum peer owns, and the same QV_LOCK. It's easy to see the problem here
> is the order of acquiring two locks are different, thus depends on timing /
> actual execution order, two threads might end up acquiring one lock while
> holding another.
> [1]
> org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] zookeeper issue #707: [ZOOKEEPER-2778] QuorumPeer: encapsulate addresses
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/707 Let's see what @eolivelli saying, but I'd like to commit the other PR to master first and this one only if the other one fails to apply to 3.5. ---
[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/719 Does this look fit to merge? I'm not a committer, so I'll need help getting it merged. (The version targeted to branch-3.5 is #707.) ---
[GitHub] zookeeper issue #707: [ZOOKEEPER-2778] QuorumPeer: encapsulate addresses
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/707 @eolivelli , have I addressed all your concerns? Does this look to you like a complete fix to ZOOKEEPER-2778? ---
[GitHub] zookeeper issue #721: ZOOKEEPER-3046: wait for clients to reconnect after re...
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/721 retest this please ---
[GitHub] zookeeper issue #727: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/727 @anmolnar here is the branch-3.5 version of #679 ---
[GitHub] zookeeper pull request #727: ZOOKEEPER-3172: Quorum TLS - fix port unificati...
GitHub user ivmaykov opened a pull request: https://github.com/apache/zookeeper/pull/727 ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades Fix numerous problems with UnifiedServerSocket, such as hanging the accept() thread when the client doesn't send any data or crashing if less than 5 bytes are read from the socket in the initial read. Re-enable the "portUnification" config option. ### Fixed networking issues/bugs in UnifiedServerSocket - don't crash the accept() thread if the client closes the connection without sending any data - don't corrupt the connection if the client sends fewer than 5 bytes for the initial read - delay the detection of TLS vs. plaintext mode until a socket stream is read from or written to. This prevents the accept() thread from getting blocked on a read() operation from the newly connected socket. - prepending 5 bytes to PrependableSocket and then trying to read >5 bytes would only return the first 5 bytes, even if more bytes were available. This is fixed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivmaykov/zookeeper ZOOKEEPER-3172-branch-3.5 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/727.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #727 commit 4a6a22f083930597b8ab3a5cb35048a6ab24813b Author: Ilya Maykov Date: 2018-10-25T01:22:24Z ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades ---
ZooKeeper_branch35_jdk8 - Build # 1208 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1208/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.82 KB...] [junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 2 [junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 4 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.802 sec, Thread: 2, Class: org.apache.zookeeper.test.SaslSuperUserTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.211 sec, Thread: 1, Class: org.apache.zookeeper.test.RestoreCommittedLogTest [junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 1 [junit] Running org.apache.zookeeper.test.SessionTest in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.754 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionInvalidationTest [junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 1 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.346 sec, Thread: 4, Class: org.apache.zookeeper.test.ServerCnxnTest [junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 4 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.09 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionTrackerCheckTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.764 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionTimeoutTest [junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 4 [junit] Running org.apache.zookeeper.test.StandaloneTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.634 sec, Thread: 1, Class: org.apache.zookeeper.test.StandaloneTest [junit] Running org.apache.zookeeper.test.StatTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.444 sec, Thread: 1, Class: org.apache.zookeeper.test.StatTest [junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 1 [junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.902 sec, Thread: 1, Class: org.apache.zookeeper.test.StaticHostProviderTest [junit] Running org.apache.zookeeper.test.StringUtilTest in thread 1 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.065 sec, Thread: 1, Class: org.apache.zookeeper.test.StringUtilTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.879 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTest [junit] Running org.apache.zookeeper.test.SyncCallTest in thread 1 [junit] Running org.apache.zookeeper.test.TruncateTest in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.794 sec, Thread: 1, Class: org.apache.zookeeper.test.SyncCallTest [junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in thread 1 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.016 sec, Thread: 2, Class: org.apache.zookeeper.test.TruncateTest [junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 2 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.088 sec, Thread: 2, Class: org.apache.zookeeper.test.WatchedEventTest [junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 2 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.558 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionUpgradeTest [junit] Running org.apache.zookeeper.test.WatcherTest in thread 4 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.743 sec, Thread: 2, Class: org.apache.zookeeper.test.WatcherFuncTest [junit] Running org.apache.zookeeper.test.X509AuthTest in thread 2 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.121 sec, Thread: 2, Class: org.apache.zookeeper.test.X509AuthTest [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in thread 2 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.793 sec, Thread: 1, Class: org.apache.zookeeper.test.WatchEventWhenAutoResetTest [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 1 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.801 sec, Thread: 1, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Running org.apache.zookeeper.util.PemReaderTest in thread 1 [junit] Tests run: 64, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.231 sec, Thread: 1, Class: org.apache.zookeeper.util.PemReaderTest [junit] Running org.apache.jute.BinaryInputArchiveTest in thread 1 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.074
[GitHub] zookeeper issue #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thread and...
Github user tumativ commented on the issue: https://github.com/apache/zookeeper/pull/689 @Ivfangmin any more changes? ---
[GitHub] zookeeper pull request #720: add an API to get total count of recursive sub ...
Github user TyqITstudent commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/720#discussion_r236655892 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/ZooDefs.java --- @@ -50,6 +50,8 @@ public final int getChildren = 8; +public final int getAllChildrenNumber = 20; --- End diff -- OK, I will change the number. ---
[jira] [Commented] (ZOOKEEPER-2822) Wrong `ObjectName` about `MBeanServer` in JMX module
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700361#comment-16700361 ] Hudson commented on ZOOKEEPER-2822: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #285 (See [https://builds.apache.org/job/ZooKeeper-trunk/285/]) ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer` in JMX module (andor: rev 91c6cb253c98a5c792314b1c7998ab5b939dddad) * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperJMX.md * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java > Wrong `ObjectName` about `MBeanServer` in JMX module > > > Key: ZOOKEEPER-2822 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2822 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Original Estimate: 24h > Time Spent: 3h 10m > Remaining Estimate: 20h 50m > > The wrong `ObjectName` about `MBeanServer` in JMX module, should > `log4j:hierarchy=default` rather than `log4j:hiearchy=default`. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3172) Quorum TLS - fix port unification to allow rolling upgrades
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700362#comment-16700362 ] Hudson commented on ZOOKEEPER-3172: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #285 (See [https://builds.apache.org/job/ZooKeeper-trunk/285/]) ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling (andor: rev 64104eaeaa6508f052edfd39c24243a8e26039dc) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumSSLTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/UnifiedServerSocket.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketModeDetectionTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/PrependableSocket.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java > Quorum TLS - fix port unification to allow rolling upgrades > --- > > Key: ZOOKEEPER-3172 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3172 > Project: ZooKeeper > Issue Type: Improvement > Components: security, server >Affects Versions: 3.6.0, 3.5.5 >Reporter: Ilya Maykov >Assignee: Ilya Maykov >Priority: Major > Labels: pull-request-available > Time Spent: 9h 50m > Remaining Estimate: 0h > > ZOOKEEPER-236 was committed with port unification support disabled, because > of various issues with the implementation. These issues should be fixed so > port unification can be enabled again. Port unification is necessary to > upgrade an ensemble from plaintext to TLS quorum connections without downtime. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3193) Flaky: org.apache.zookeeper.test.SaslAuthFailNotifyTest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700359#comment-16700359 ] Hudson commented on ZOOKEEPER-3193: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #285 (See [https://builds.apache.org/job/ZooKeeper-trunk/285/]) ZOOKEEPER-3193: Flaky: org.apache.zookeeper.test.SaslAuthFailNotifyTest (andor: rev 1c488cec08809a76202f6c66be9e46533e7c409c) * (delete) zookeeper-server/src/test/java/org/apache/zookeeper/test/SaslAuthFailNotifyTest.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/SaslAuthFailTest.java > Flaky: org.apache.zookeeper.test.SaslAuthFailNotifyTest > --- > > Key: ZOOKEEPER-3193 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3193 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.5.4, 3.6.0, 3.4.13 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 40m > Remaining Estimate: 0h > > This test doesn't fail often on Apache Jenkins, but seems like quite flaky in > our in-house testing environment. It's having a race in waiting for the > AuthFailed event that could happen before client creation succeeds, causing > the wait operation to hand infinitely (notify occurred before the wait() > call). Using a CountDownLatch would be better for the same purpose. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3172) Quorum TLS - fix port unification to allow rolling upgrades
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700323#comment-16700323 ] Hudson commented on ZOOKEEPER-3172: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #123 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/123/]) ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling (andor: rev 64104eaeaa6508f052edfd39c24243a8e26039dc) * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketModeDetectionTest.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumSSLTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/PrependableSocket.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/UnifiedServerSocket.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java > Quorum TLS - fix port unification to allow rolling upgrades > --- > > Key: ZOOKEEPER-3172 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3172 > Project: ZooKeeper > Issue Type: Improvement > Components: security, server >Affects Versions: 3.6.0, 3.5.5 >Reporter: Ilya Maykov >Assignee: Ilya Maykov >Priority: Major > Labels: pull-request-available > Time Spent: 9h 50m > Remaining Estimate: 0h > > ZOOKEEPER-236 was committed with port unification support disabled, because > of various issues with the implementation. These issues should be fixed so > port unification can be enabled again. Port unification is necessary to > upgrade an ensemble from plaintext to TLS quorum connections without downtime. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3193) Flaky: org.apache.zookeeper.test.SaslAuthFailNotifyTest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700321#comment-16700321 ] Hudson commented on ZOOKEEPER-3193: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #123 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/123/]) ZOOKEEPER-3193: Flaky: org.apache.zookeeper.test.SaslAuthFailNotifyTest (andor: rev 1c488cec08809a76202f6c66be9e46533e7c409c) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/SaslAuthFailTest.java * (delete) zookeeper-server/src/test/java/org/apache/zookeeper/test/SaslAuthFailNotifyTest.java > Flaky: org.apache.zookeeper.test.SaslAuthFailNotifyTest > --- > > Key: ZOOKEEPER-3193 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3193 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.5.4, 3.6.0, 3.4.13 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 40m > Remaining Estimate: 0h > > This test doesn't fail often on Apache Jenkins, but seems like quite flaky in > our in-house testing environment. It's having a race in waiting for the > AuthFailed event that could happen before client creation succeeds, causing > the wait operation to hand infinitely (notify occurred before the wait() > call). Using a CountDownLatch would be better for the same purpose. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2822) Wrong `ObjectName` about `MBeanServer` in JMX module
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700322#comment-16700322 ] Hudson commented on ZOOKEEPER-2822: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #123 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/123/]) ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer` in JMX module (andor: rev 91c6cb253c98a5c792314b1c7998ab5b939dddad) * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperJMX.md * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java > Wrong `ObjectName` about `MBeanServer` in JMX module > > > Key: ZOOKEEPER-2822 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2822 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Original Estimate: 24h > Time Spent: 3h 10m > Remaining Estimate: 20h 50m > > The wrong `ObjectName` about `MBeanServer` in JMX module, should > `log4j:hierarchy=default` rather than `log4j:hiearchy=default`. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/294 You are welcome. ---
[GitHub] zookeeper pull request #720: add an API to get total count of recursive sub ...
Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/720#discussion_r236578709 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/ZooDefs.java --- @@ -50,6 +50,8 @@ public final int getChildren = 8; +public final int getAllChildrenNumber = 20; --- End diff -- 20 is already taken for deleteContainer, please change it to something else (22 seems to be the first free number until 100) ---
[jira] [Resolved] (ZOOKEEPER-2822) Wrong `ObjectName` about `MBeanServer` in JMX module
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-2822. - Resolution: Fixed Issue resolved by pull request 294 [https://github.com/apache/zookeeper/pull/294] > Wrong `ObjectName` about `MBeanServer` in JMX module > > > Key: ZOOKEEPER-2822 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2822 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.5.3 >Reporter: Benedict Jin >Assignee: Benedict Jin >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Original Estimate: 24h > Time Spent: 2h 50m > Remaining Estimate: 21h 10m > > The wrong `ObjectName` about `MBeanServer` in JMX module, should > `log4j:hierarchy=default` rather than `log4j:hiearchy=default`. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #692: ZOOKEEPER-3184: Use the same method to generate websit...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/692 @lvfangmin How about now? ---
[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/679 Thanks @ivmaykov ! Committed to master branch. Please create separate PR for 3.5, because it has some merge conflicts. ---
[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/679 ---
[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/294 Committed to master and 3.5 branches. Thanks @asdf2014 ! ---
[GitHub] zookeeper pull request #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBean...
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/294 ---
[jira] [Resolved] (ZOOKEEPER-3193) Flaky: org.apache.zookeeper.test.SaslAuthFailNotifyTest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3193. - Resolution: Fixed Fix Version/s: (was: 3.4.14) Issue resolved by pull request 706 [https://github.com/apache/zookeeper/pull/706] > Flaky: org.apache.zookeeper.test.SaslAuthFailNotifyTest > --- > > Key: ZOOKEEPER-3193 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3193 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.5.4, 3.6.0, 3.4.13 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 20m > Remaining Estimate: 0h > > This test doesn't fail often on Apache Jenkins, but seems like quite flaky in > our in-house testing environment. It's having a race in waiting for the > AuthFailed event that could happen before client creation succeeds, causing > the wait operation to hand infinitely (notify occurred before the wait() > call). Using a CountDownLatch would be better for the same purpose. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #706: ZOOKEEPER-3193 Flaky: org.apache.zookeeper.test.SaslAu...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/706 Committed to master and 3.5 branches. Thanks @eolivelli ! ---
[GitHub] zookeeper pull request #706: ZOOKEEPER-3193 Flaky: org.apache.zookeeper.test...
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/706 ---
